Re: [Qemu-devel] [PATCH v4 00/46] Windbg supporting

for > debugging there is no need to enable debugging mode in the kernel. This leads > to > hidden debugging. Our module supports all features of WinDbg regarding remote > debugging, besides interception of events and exceptions. Only i386 is > supported > now. > > Chan

Re: [Qemu-devel] [PATCH v4 05/46] windbg: added helper features

On Mon, Dec 11, 2017 at 2:21 PM, Mihail Abakumov wrote: > Added some helper features for windbgstub. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov

[Qemu-devel] [PATCH v4 0/4] ivshmem: MSI bug fixes

ent formatting (Markus) * Patch 3 - added reproducer info to commit message (Markus) v2->v3: * Added patch 4 v3->v4: * Added forward decl of ivshmem_disable_irqfd() instead of moving ivshmem_reset() (Eric, Markus) Ladi Prosek (4): ivshmem: Don't update non-existent MSI routes ivshmem: Alwa

[Qemu-devel] [PATCH v4 4/4] ivshmem: Disable irqfd on device reset

ash-reboot the guest by inducing a BSOD. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- hw/misc/ivshmem.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index d1bb246d12..9c7e74ef12 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @

[Qemu-devel] [PATCH v4 3/4] ivshmem: Improve MSI irqfd error handling

again the Windows driver, at the time of writing available at: https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem The issue is believed to have been masked by other guest drivers, notably Linux ones, not enabling MSI-X on the device. Signed-off-by: Ladi Prosek <l

[Qemu-devel] [PATCH v4 1/4] ivshmem: Don't update non-existent MSI routes

at: https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem The issue is believed to have been masked by other guest drivers, notably Linux ones, not enabling MSI-X on the device. Fixes: 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications") Signed-off-b

[Qemu-devel] [PATCH v4 2/4] ivshmem: Always remove irqfd notifiers

c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications") Signed-off-by: Ladi Prosek <lpro...@redhat.com> Reviewed-by: Markus Armbruster <arm...@redhat.com> --- hw/misc/ivshmem.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3 4/4] ivshmem: Disable irqfd on device reset

On Fri, Dec 8, 2017 at 6:28 PM, Markus Armbruster <arm...@redhat.com> wrote: > Ladi Prosek <lpro...@redhat.com> writes: > >> On Fri, Dec 8, 2017 at 2:36 PM, Markus Armbruster <arm...@redhat.com> wrote: >>> Ladi Prosek <lpro...@redhat.com> writes:

Re: [Qemu-devel] [PATCH v3 4/4] ivshmem: Disable irqfd on device reset

On Fri, Dec 8, 2017 at 2:36 PM, Markus Armbruster <arm...@redhat.com> wrote: > Ladi Prosek <lpro...@redhat.com> writes: > >> The effects of ivshmem_enable_irqfd() was not undone on device reset. >> >> This manifested as: >> ivshmem_add_kvm_msi_virq: Asser

Re: [Qemu-devel] [PATCH v2 0/3] ivshmem: MSI bug fixes

On Mon, Nov 20, 2017 at 1:49 PM, Ladi Prosek <lpro...@redhat.com> wrote: > On Mon, Nov 20, 2017 at 10:07 AM, Ladi Prosek <lpro...@redhat.com> wrote: >> On Sun, Nov 19, 2017 at 9:39 PM, <ge...@hostfission.com> wrote: >>> I just updated to the latest build a

[Qemu-devel] [PATCH v3 4/4] ivshmem: Disable irqfd on device reset

ash-reboot the guest by inducing a BSOD. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- hw/misc/ivshmem.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index d1bb246d12..4be0d2627b 100644 --- a/hw/misc/

[Qemu-devel] [PATCH v3 0/4] ivshmem: MSI bug fixes

ent formatting (Markus) * Patch 3 - added reproducer info to commit message (Markus) v2->v3: * Added patch 4 Ladi Prosek (4): ivshmem: Don't update non-existent MSI routes ivshmem: Always remove irqfd notifiers ivshmem: Improve MSI irqfd error handling ivshmem: Disable irqfd on device rese

[Qemu-devel] [PATCH v3 2/4] ivshmem: Always remove irqfd notifiers

c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications") Signed-off-by: Ladi Prosek <lpro...@redhat.com> Reviewed-by: Markus Armbruster <arm...@redhat.com> --- hw/misc/ivshmem.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH v3 3/4] ivshmem: Improve MSI irqfd error handling

again the Windows driver, at the time of writing available at: https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem The issue is believed to have been masked by other guest drivers, notably Linux ones, not enabling MSI-X on the device. Signed-off-by: Ladi Prosek <l

[Qemu-devel] [PATCH v3 1/4] ivshmem: Don't update non-existent MSI routes

at: https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem The issue is believed to have been masked by other guest drivers, notably Linux ones, not enabling MSI-X on the device. Fixes: 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications") Signed-off-b

[Qemu-devel] [PATCH v2] msix: don't mask already masked vectors on reset

. It is however easy to fix and the expectation that the use and release notifier invocations are always balanced is very natural. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- v1->v2: * fixed typo in commit message "or" -> "to" (Marcel) * directly set msix

Re: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

On Thu, Dec 7, 2017 at 7:27 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Wed, Nov 22, 2017 at 03:22:50PM +0200, Marcel Apfelbaum wrote: >> On 22/11/2017 14:32, Ladi Prosek wrote: >> > On Wed, Nov 22, 2017 at 11:46 AM, Marcel Apfelbaum <mar...@redhat.com&g

Re: [Qemu-devel] [PATCH v3 39/45] windbg: implemented kd_api_get_version

On Wed, Dec 6, 2017 at 10:00 AM, Mihail Abakumov <mikhail.abaku...@ispras.ru> wrote: > Ladi Prosek писал 2017-11-29 11:14: > >> On Tue, Nov 21, 2017 at 3:10 PM, Mihail Abakumov >> <mikhail.abaku...@ispras.ru> wrote: >>> >>> Signed-off-by: Mihail Abak

Re: [Qemu-devel] [PATCH v3 35/45] windbg: debug exception subscribing

On Wed, Dec 6, 2017 at 8:29 AM, Mihail Abakumov <mikhail.abaku...@ispras.ru> wrote: > Ladi Prosek писал 2017-11-29 10:13: > >> On Tue, Nov 21, 2017 at 3:10 PM, Mihail Abakumov >> <mikhail.abaku...@ispras.ru> wrote: >>> >>> Added handler registratio

[Qemu-devel] [PATCH] virtio-input: add missing KEY_COMPOSE mapping

This key tends to be located somewhere between right Alt and right Ctrl and is usually used for opening context menus. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- hw/input/virtio-input-hid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/input/virtio-input-hid.c b/hw/input/

Re: [Qemu-devel] [PATCH v3 00/45] Windbg supporting

in v3: > > - Add a support of the new api functions from the WinDbg v10. > > Changed in v2: > > - Move target specific code in the 'target/' directory. (Alistair Francis) > - Change 'kd_api_fill_memory'. Made a fill of memory by line segments. > Before that, a full array was imm

Re: [Qemu-devel] [PATCH v3 39/45] windbg: implemented kd_api_get_version

On Tue, Nov 21, 2017 at 3:10 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h |

Re: [Qemu-devel] [PATCH v3 43/45] windbg: implemented kd_api_query_memory

On Tue, Nov 21, 2017 at 3:11 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h |

Re: [Qemu-devel] [PATCH v3 41/45] windbg: implemented kd_api_search_memory

On Tue, Nov 21, 2017 at 3:11 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h |

Re: [Qemu-devel] [PATCH v3 40/45] windbg: implemented kd_api_read_msr and kd_api_write_msr

On Tue, Nov 21, 2017 at 3:11 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h |

Re: [Qemu-devel] [PATCH v3 35/45] windbg: debug exception subscribing

On Tue, Nov 21, 2017 at 3:10 PM, Mihail Abakumov wrote: > Added handler registration of gdb debug exception. Its exception also can be > used for windbg. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk

Re: [Qemu-devel] [PATCH v3 26/45] windbg: implemented windbg_read_context

On Tue, Nov 21, 2017 at 3:09 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > target/i386/windbgstub.c | 96

Re: [Qemu-devel] [PATCH v3 15/45] windbg: sized data buffer

On Tue, Nov 21, 2017 at 3:08 PM, Mihail Abakumov wrote: > Defined useful sized data buffer. It contains pointer to data and size of > this data. Also, defined some macros for init and free. > > Signed-off-by: Mihail Abakumov >

Re: [Qemu-devel] [PATCH v3 10/45] windbg: structures for parsing data stream

On Tue, Nov 21, 2017 at 3:08 PM, Mihail Abakumov wrote: > Added structures for parsing data stream from windbg to packet. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy

Re: [Qemu-devel] [PATCH v3 03/45] windbg: modified windbgkd.h

On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov wrote: > Added useful name arrays of some defines. Not used yet. Needs for the future. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk >

Re: [Qemu-devel] [PATCH v3 45/45] windbg: implemented kd_api_get_context_ex and kd_api_set_context_ex

On Tue, Nov 21, 2017 at 3:11 PM, Mihail Abakumov wrote: [...] > diff --git a/windbgstub.c b/windbgstub.c > index 36372c0ea5..3bcf6a8cbb 100755 > --- a/windbgstub.c > +++ b/windbgstub.c > @@ -224,6 +224,14 @@ static void >

Re: [Qemu-devel] [PATCH v3 01/45] windbg: added empty windbgstub files

On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > Makefile.target |

Re: [Qemu-devel] [PATCH v3 05/45] windbg: added helper features

On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov wrote: > Added some helper features for windbgstub. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov

Re: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

On Wed, Nov 22, 2017 at 11:46 AM, Marcel Apfelbaum <mar...@redhat.com> wrote: > Hi Ladi, > > On 20/11/2017 16:22, Ladi Prosek wrote: >> >> msix_mask_all() is supposed to invoke the release vector notifier if the >> state of the >> respective vector changed

[Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

. It is however easy to fix and the expectation that the use and release notifier invocations are always balanced is very natural. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- hw/pci/msix.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/msix.c b/hw/pci/

Re: [Qemu-devel] [PATCH v2 0/3] ivshmem: MSI bug fixes

On Mon, Nov 20, 2017 at 10:07 AM, Ladi Prosek <lpro...@redhat.com> wrote: > On Sun, Nov 19, 2017 at 9:39 PM, <ge...@hostfission.com> wrote: >> I just updated to the latest build and applied this patch set, now on VM >> reset the qemu crashes with the following

Re: [Qemu-devel] [PATCH v2 0/3] ivshmem: MSI bug fixes

or].pdev' failed. I see asserts too. Even with v1 on top of QEMU v2.10.0 so I must have missed something. Looking. And, needless to say, these patches should not be applied just yet :) Thanks! Ladi > On 2017-11-15 18:31, Ladi Prosek wrote: >> >> Fixes bugs in the ivshmem devic

[Qemu-devel] [PATCH v2 1/3] ivshmem: Don't update non-existent MSI routes

at: https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem The issue is believed to have been masked by other guest drivers, notably Linux ones, not enabling MSI-X on the device. Fixes: 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications") Signed-off-b

[Qemu-devel] [PATCH v2 3/3] ivshmem: Improve MSI irqfd error handling

again the Windows driver, at the time of writing available at: https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem The issue is believed to have been masked by other guest drivers, notably Linux ones, not enabling MSI-X on the device. Signed-off-by: Ladi Prosek <l

[Qemu-devel] [PATCH v2 0/3] ivshmem: MSI bug fixes

ent formatting (Markus) * Patch 3 - added reproducer info to commit message (Markus) Ladi Prosek (3): ivshmem: Don't update non-existent MSI routes ivshmem: Always remove irqfd notifiers ivshmem: Improve MSI irqfd error handling hw/misc/ivshmem.c |

[Qemu-devel] [PATCH v2 2/3] ivshmem: Always remove irqfd notifiers

c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications") Signed-off-by: Ladi Prosek <lpro...@redhat.com> Reviewed-by: Markus Armbruster <arm...@redhat.com> --- hw/misc/ivshmem.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 2/3] ivshmem: Always remove irqfd notifiers

On Mon, Nov 13, 2017 at 3:36 PM, Markus Armbruster <arm...@redhat.com> wrote: > Ladi Prosek <lpro...@redhat.com> writes: > >> As of commit 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications"), >> QEMU crashes with: >>

Re: [Qemu-devel] [PATCH 1/3] ivshmem: Don't update non-existent MSI routes

On Mon, Nov 13, 2017 at 3:22 PM, Markus Armbruster <arm...@redhat.com> wrote: > Ladi Prosek <lpro...@redhat.com> writes: > >> As of commit 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications"), >> QEMU crashes with: >> >> kv

Re: [Qemu-devel] [PATCH v2 00/43] Windbg supporting

On Wed, Nov 8, 2017 at 3:28 PM, Mihail Abakumov <mikhail.abaku...@ispras.ru> wrote: > Ladi Prosek писал 2017-11-08 16:43: > >> On Wed, Nov 8, 2017 at 12:54 PM, Mihail Abakumov >> <mikhail.abaku...@ispras.ru> wrote: >>> >>> Ladi Prosek писал 20

[Qemu-devel] [PATCH v2] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

tem_vendor_id = ... to virtio_pci_class_init(). Except for the problematic statement deleted by this patch, which reverts the Subsystem Vendor ID back to 0x1af4 for legacy devices for no good reason. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- v1->v2: * Added a comment about the default Subsystem Vendor I

[Qemu-devel] [PATCH 2/3] ivshmem: Always remove irqfd notifiers

c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications") Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- hw/misc/ivshmem.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 6e46669744..4

[Qemu-devel] [PATCH 3/3] ivshmem: Improve MSI irqfd error handling

Adds a rollback path to ivshmem_enable_irqfd() and fixes ivshmem_disable_irqfd() to bail if irqfd has not been enabled. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- hw/misc/ivshmem.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff

[Qemu-devel] [PATCH 0/3] ivshmem: MSI bug fixes

Fixes bugs in the ivshmem device implementation uncovered with the new Windows ivshmem driver: https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem Ladi Prosek (3): ivshmem: Don't update non-existent MSI routes ivshmem: Always remove irqfd notifiers ivshmem: Improve

[Qemu-devel] [PATCH 1/3] ivshmem: Don't update non-existent MSI routes

and leads to output like: Too many eventfd received, device has 1 vectors Fixes: 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications") Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- hw/misc/ivshmem.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletion

Re: [Qemu-devel] [PATCH v2 00/43] Windbg supporting

On Wed, Nov 8, 2017 at 12:54 PM, Mihail Abakumov <mikhail.abaku...@ispras.ru> wrote: > Ladi Prosek писал 2017-11-06 18:15: > >> On Mon, Oct 23, 2017 at 10:31 AM, Ladi Prosek <lpro...@redhat.com> wrote: >>> >>> On Tue, Oct 17, 2017 at 3:08 PM, Mihail Abaku

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

On Mon, Nov 6, 2017 at 5:51 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Mon, Nov 06, 2017 at 10:02:54AM +0100, Ladi Prosek wrote: >> On Fri, Nov 3, 2017 at 4:11 PM, Michael S. Tsirkin <m...@redhat.com> wrote: >> > On Fri, Nov 03, 2017 at 09:23:07AM +0100, L

Re: [Qemu-devel] [PATCH v2 00/43] Windbg supporting

On Mon, Nov 6, 2017 at 7:41 PM, Andrew Baumann <andrew.baum...@microsoft.com> wrote: > Hi, > > I just noticed this thread, and the problem sounded very familiar... > >> From: Ladi Prosek >> Sent: Monday, 6 November 2017 07:16 > [...] >> FS base

Re: [Qemu-devel] [PATCH v2 00/43] Windbg supporting

On Mon, Oct 23, 2017 at 10:31 AM, Ladi Prosek <lpro...@redhat.com> wrote: > On Tue, Oct 17, 2017 at 3:08 PM, Mihail Abakumov > <mikhail.abaku...@ispras.ru> wrote: >> An update of: >> >> v1: >> https://lists.nongnu.org/archive/html/qemu

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

On Fri, Nov 3, 2017 at 4:11 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Fri, Nov 03, 2017 at 09:23:07AM +0100, Ladi Prosek wrote: >> On Fri, Nov 3, 2017 at 8:20 AM, Gerd Hoffmann <kra...@redhat.com> wrote: >> > >> >> > > Signed-off-by: La

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

On Fri, Nov 3, 2017 at 8:20 AM, Gerd Hoffmann <kra...@redhat.com> wrote: > >> > > Signed-off-by: Ladi Prosek <lpro...@redhat.com> >> > >> > I wonder whether it's a problem that legacy devices ignore >> > the subsystem ID (that's part of spe

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

On Thu, Nov 2, 2017 at 3:52 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Thu, Nov 02, 2017 at 02:31:15PM +0100, Ladi Prosek wrote: >> The statement being removed doesn't change anything as virtio PCI devices >> already >> have Subsystem Vendor ID set to pci_de

[Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

tem_vendor_id = ... to virtio_pci_class_init(). Except for the problematic statement deleted by this patch, which reverts the Subsystem Vendor ID back to 0x1af4 for legacy devices for no good reason. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- hw/virtio/virtio-pci.c | 2 -- 1 file changed, 2 deletions(-) dif

Re: [Qemu-devel] [PATCH v2 00/43] Windbg supporting

> > - Move target specific code in the 'target/' directory. (Alistair Francis) > - Change 'kd_api_fill_memory'. Made a fill of memory by line segments. > Before that, a full array was immediately collected and written in RAM. (Ladi > Prosek) > - Change 'kd_api_search_memor

Re: [Qemu-devel] ivshmem Windows Driver

On Thu, Oct 19, 2017 at 11:41 AM, <ge...@hostfission.com> wrote: > On 2017-10-19 20:07, ge...@hostfission.com wrote: >> >> On 2017-10-19 20:01, Ladi Prosek wrote: >>> >>> On Thu, Oct 19, 2017 at 10:44 AM, <ge...@hostfission.com> wrote: >

Re: [Qemu-devel] ivshmem Windows Driver

On Thu, Oct 19, 2017 at 10:44 AM, <ge...@hostfission.com> wrote: > On 2017-10-19 19:35, Ladi Prosek wrote: >> >> On Wed, Oct 18, 2017 at 5:04 PM, <ge...@hostfission.com> wrote: >>> >>> Hi Ladi & Yan, >>> >>> I am pleased to

Re: [Qemu-devel] ivshmem Windows Driver

On Wed, Oct 18, 2017 at 5:04 PM, wrote: > Hi Ladi & Yan, > > I am pleased to present the completed driver for review, please see: > > https://github.com/gnif/kvm-guest-drivers-windows Awesome! Feel free to open pull request, it should be easier to comment on. * WoW

Re: [Qemu-devel] ivshmem Windows Driver

On Wed, Oct 18, 2017 at 8:56 AM, <ge...@hostfission.com> wrote: > On 2017-10-18 17:50, Ladi Prosek wrote: >> >> On Wed, Oct 18, 2017 at 7:50 AM, <ge...@hostfission.com> wrote: >>> >>> On 2017-10-18 16:31, Ladi Prosek wrote: >>>> >>&g

Re: [Qemu-devel] ivshmem Windows Driver

On Wed, Oct 18, 2017 at 7:50 AM, <ge...@hostfission.com> wrote: > On 2017-10-18 16:31, Ladi Prosek wrote: >> >> Hi Geoff, >> >> On Mon, Oct 16, 2017 at 8:31 PM, <ge...@hostfission.com> wrote: >>> >>> Hi Yan & Ladi. >>> >

Re: [Qemu-devel] ivshmem Windows Driver

Hi Geoff, On Mon, Oct 16, 2017 at 8:31 PM, wrote: > Hi Yan & Ladi. > > I have written an initial implementation that supports just the shared > memory > mapping at this time. I plan to add events also but before I go further I > would > like some feedback if possible on

[Qemu-devel] [PATCH trivial] Remove empty statements

Thanks to Laszlo Ersek for spotting the double semicolon in target/i386/kvm.c I have trivially grepped the tree for ';;' in C files. Suggested-by: Laszlo Ersek <ler...@redhat.com> Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- hw/misc/imx6_ccm.c | 2 +- hw/s390x/virti

Re: [Qemu-devel] [PATCH 00/43] Windbg supporting

Hi, On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov wrote: > We made the debugger module WinDbg (like GDB) for QEMU. This is the > replacement of the remote stub in Windows kernel. Used for remote Windows > kernel debugging without debugging mode. > > WinDbg is a

Re: [Qemu-devel] [PATCH 42/43] windbg: implemented kd_api_fill_memory

On Tue, Sep 26, 2017 at 1:08 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h |

Re: [Qemu-devel] [PATCH 41/43] windbg: implemented kd_api_search_memory

On Tue, Sep 26, 2017 at 1:07 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h |

Re: [Qemu-devel] [PATCH 38/43] windbg: implemented kd_api_read_physical_memory and kd_api_write_physical_memory

On Tue, Sep 26, 2017 at 1:07 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h |

Re: [Qemu-devel] [PATCH 33/43] windbg: implemented windbg_hw_breakpoint_insert and windbg_hw_breakpoint_remove

On Tue, Sep 26, 2017 at 1:07 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > windbgstub-utils.c | 60 >

Re: [Qemu-devel] [PATCH 28/43] windbg: implemented windbg_read_ks_regs

On Tue, Sep 26, 2017 at 1:06 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > windbgstub-utils.c | 38

Re: [Qemu-devel] [PATCH 26/43] windbg: implemented windbg_read_context

On Tue, Sep 26, 2017 at 1:06 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > windbgstub-utils.c | 90 >

Re: [Qemu-devel] [PATCH 22/43] windbg: implemented kd_api_read_virtual_memory and kd_api_read_virtual_memory

nit: The subject line has "kd_api_read_virtual_memory" twice in it. Was probably meant to be [PATCH 22/43] windbg: implemented kd_api_read_virtual_memory and kd_api_write_virtual_memory On Tue, Sep 26, 2017 at 1:06 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail

Re: [Qemu-devel] [PATCH 19/43] windbg: implemented windbg_process_control_packet

On Tue, Sep 26, 2017 at 1:05 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > windbgstub.c | 26

Re: [Qemu-devel] [PATCH 15/43] windbg: sized data buffer

On Tue, Sep 26, 2017 at 1:05 PM, Mihail Abakumov wrote: > Defined useful sized data buffer. It contains pointer to data and size of > this data. Also, defined some macroses for init and free. "macros" instead of "macroses", same in patch 31. > Signed-off-by: Mihail

Re: [Qemu-devel] [PATCH 15/43] windbg: sized data buffer

On Tue, Sep 26, 2017 at 1:05 PM, Mihail Abakumov wrote: > Defined useful sized data buffer. It contains pointer to data and size of > this data. Also, defined some macroses for init and free. "macros" instead of "macroses", same in patch 31. > Signed-off-by: Mihail

Re: [Qemu-devel] [PATCH 09/43] windbg: handler of fs/gs register

On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov wrote: > Added handler of fs/gs register. It tries to find and check KPCR and version > address. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk >

Re: [Qemu-devel] [PATCH 08/43] windbg: hook to wrmsr operation

On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov wrote: > Inserted hook to wrmsr operation. Windows Kernel put address on KPCR struct > to fs/gs (x32/x64) register. Needs catch this moment and allow windbg server > handle packets. > > Signed-off-by: Mihail Abakumov

Re: [Qemu-devel] [PATCH 07/43] windbg: added chardev

On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov wrote: > Added chardev for listening to windbg. Target device is a parameter in the > '-windbg' option. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk

Re: [Qemu-devel] [PATCH v3 0/9] virtio: enhance virtio_error messages

On Thu, Sep 14, 2017 at 7:59 AM, Ladi Prosek <lpro...@redhat.com> wrote: > On Fri, Jul 21, 2017 at 5:21 PM, Stefan Hajnoczi <stefa...@gmail.com> wrote: >> On Mon, Jul 17, 2017 at 10:11:43AM +0200, Ladi Prosek wrote: >>> Output like "Virtqueue size exceeded

Re: [Qemu-devel] [PATCH v3 0/9] virtio: enhance virtio_error messages

On Fri, Jul 21, 2017 at 5:21 PM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Mon, Jul 17, 2017 at 10:11:43AM +0200, Ladi Prosek wrote: >> Output like "Virtqueue size exceeded" is not much useful in identifying the >> culprit. This series beefs up virtio_error

Re: [Qemu-devel] [PATCH] virtio-input: send rel-wheel events for wheel buttons

erified that the Windows driver correctly handles axis-based wheel. Thanks! Tested-by: Ladi Prosek <lpro...@redhat.com>

Re: [Qemu-devel] [PATCH v2 1/4] i386/kvm: use a switch statement for MSR detection

On Mon, Aug 7, 2017 at 4:19 PM, David Hildenbrand <da...@redhat.com> wrote: > On 07.08.2017 10:57, Ladi Prosek wrote: >> Switch is easier on the eye and might lead to better codegen. >> >> Signed-off-by: Ladi Prosek <lpro...@redhat.com>

[Qemu-devel] [PATCH v2 4/4] i386/kvm: advertise Hyper-V frequency MSRs

03H:EAX[11] and CPUID.4003H:EDX[8] as specified in the Hyper-V TLFS and experimentally verified on a Hyper-V host. The feature is enabled with the existing hv-time CPU flag, and only if the TSC frequency is stable across migrations and known. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- t

[Qemu-devel] [PATCH v2 2/4] i386/kvm: set tsc_khz before configuring Hyper-V CPUID

Timing-related Hyper-V enlightenments will benefit from knowing the final tsc_khz value. This commit just moves the code in preparation for further changes. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- target/i386/kvm.c | 38 +++--- 1 file chang

[Qemu-devel] [PATCH v2 1/4] i386/kvm: use a switch statement for MSR detection

Switch is easier on the eye and might lead to better codegen. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- target/i386/kvm.c | 75 +++ 1 file changed, 31 insertions(+), 44 deletions(-) diff --git a/target/i386/kvm.c b/target/i386

[Qemu-devel] [PATCH v2 0/4] i386/kvm: advertise Hyper-V frequency MSRs

only if the TSC frequency is stable across migration and known, as suggested by Paolo. v1->v2: * deleted an extra empty line in patch 1 * added patch 3 introducing a helper function for the "TSC is stable and known" check (David) Ladi Prosek (4): i386/kvm: use a switch stat

[Qemu-devel] [PATCH v2 3/4] i386/kvm: introduce tsc_is_stable_and_known()

Move the "is TSC stable and known" condition to a reusable helper. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- target/i386/kvm.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 15d56ae

Re: [Qemu-devel] [PATCH 3/3] i386/kvm: advertise Hyper-V frequency MSRs

On Fri, Aug 4, 2017 at 3:39 PM, David Hildenbrand <da...@redhat.com> wrote: > On 04.08.2017 11:14, Ladi Prosek wrote: >> As of kernel commit eb82feea59d6 ("KVM: hyperv: support >> HV_X64_MSR_TSC_FREQUENCY >> and HV_X64_MSR_APIC_FREQUENCY"), KVM sup

[Qemu-devel] [PATCH 2/3] i386/kvm: set tsc_khz before configuring Hyper-V CPUID

Timing-related Hyper-V enlightenments will benefit from knowing the final tsc_khz value. This commit just moves the code in preparation for further changes. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- target/i386/kvm.c | 38 +++--- 1 file chang

[Qemu-devel] [PATCH 0/3] i386/kvm: advertise Hyper-V frequency MSRs

only if the TSC frequency is stable across migration and known, as suggested by Paolo. Ladi Prosek (3): i386/kvm: use a switch statement for MSR detection i386/kvm: set tsc_khz before configuring Hyper-V CPUID i386/kvm: advertise Hyper-V frequency MSRs target/i386/kvm.c | 130

[Qemu-devel] [PATCH 3/3] i386/kvm: advertise Hyper-V frequency MSRs

03H:EAX[11] and CPUID.4003H:EDX[8] as specified in the Hyper-V TLFS and experimentally verified on a Hyper-V host. The feature is enabled with the existing hv-time CPU flag, and only if the TSC frequency is stable across migration and known. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- t

[Qemu-devel] [PATCH 1/3] i386/kvm: use a switch statement for MSR detection

Switch is easier on the eye and might lead to better codegen. Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- target/i386/kvm.c | 76 +++ 1 file changed, 32 insertions(+), 44 deletions(-) diff --git a/target/i386/kvm.c b/target/i386

Re: [Qemu-devel] [PATCH] pc: acpi: force FADT rev1 for old i440fx machine types

On Tue, Jul 25, 2017 at 3:26 PM, Michael S. Tsirkin wrote: > On Mon, Jul 24, 2017 at 08:48:48AM +0200, Igor Mammedov wrote: >> On Sat, 22 Jul 2017 02:40:46 +0300 >> "Michael S. Tsirkin" wrote: >> >> > On Fri, Jul 21, 2017 at 12:10:48PM +0200, Igor Mammedov

Re: [Qemu-devel] [PATCH] pc: acpi: force FADT rev1 for old i440fx machine types

On Fri, Jul 21, 2017 at 12:12 PM, Igor Mammedov <imamm...@redhat.com> wrote: > On Fri, 21 Jul 2017 11:54:20 +0200 > Ladi Prosek <lpro...@redhat.com> wrote: > >> On Fri, Jul 21, 2017 at 11:32 AM, Igor Mammedov <imamm...@redhat.com> wrote: >> > w2k use

Re: [Qemu-devel] [PATCH] pc: acpi: force FADT rev1 for old i440fx machine types

> CC: Phil Dennis-Jordan <li...@philjordan.eu> > CC: "Michael S. Tsirkin" <m...@redhat.com> > > Only compile test since I don't have w2k to test with Confirming that Windows 2000 boots with this patch and -machine pc-i440fx-2.9. Tested-by: Ladi Prosek <lpro...@redhat.com>

Re: [Qemu-devel] [PATCH v4 0/8] KASLR kernel dump support

On Tue, Jul 18, 2017 at 6:18 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > Hi > > On Tue, Jul 18, 2017 at 6:05 PM Ladi Prosek <lpro...@redhat.com> wrote: >> >> >> > I would like to hear from Ladi how he intended to use the device in >>

Re: [Qemu-devel] [PATCH v4 0/8] KASLR kernel dump support

Hi Marc-Andre, On Tue, Jul 18, 2017 at 3:29 PM, Marc-André Lureau wrote: > Hi > > On Fri, Jul 14, 2017 at 4:29 PM, Michael S. Tsirkin wrote: >> On Sat, Jul 15, 2017 at 12:31:36AM +0200, Marc-André Lureau wrote: >>> Hi >>> >>> On Sat, Jul 15, 2017 at

Re: [Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf

On Mon, Jul 17, 2017 at 10:58 AM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Mon, Jul 17, 2017 at 08:54:18AM +0200, Ladi Prosek wrote: >> On Fri, Jul 14, 2017 at 12:41 PM, Daniel P. Berrange >> <berra...@redhat.com> wrote: >> > On Thu, Jul 13, 2017

[Qemu-devel] [PATCH v3 9/9] checkpatch: add virtio_error and virtqueue_error to error funcs

Two more error functions that should not contain newlines. Suggested-by: Greg Kurz <gr...@kaod.org> Signed-off-by: Ladi Prosek <lpro...@redhat.com> --- scripts/checkpatch.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpa

  1   2   3   >