Cc: Liran Alon
Signed-off-by: Paolo Bonzini
Reviewed-by: Liran Alon
---
hw/core/machine.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 1d80ab0e1d..211b4e077a 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
On 23/06/2020 11:46, Laurent Vivier wrote:
On 11/06/2020 21:43, Paolo Bonzini wrote:
From: Liran Alon
vmport_ioport_read() returns the value that should propagate to vCPU EAX
register when guest reads VMPort IOPort (i.e. By x86 IN instruction).
However, because vmport_ioport_read() calls
On 22/03/2020 13:22, Liran Alon wrote:
On 15/03/2020 13:56, Liran Alon wrote:
On 14/03/2020 22:56, Michael S. Tsirkin wrote:
On Sat, Mar 14, 2020 at 10:05:20PM +0200, Liran Alon wrote:
Michael, you can also refer to this VMware time-keeping whitepaper:
https://urldefense.com/v3/__https
16:50:08 +0200
Liran Alon wrote:
Microsoft introduced this ACPI table to avoid Windows guests performing
various workarounds for device erratas. As the virtual device emulated
by VMM may not have the errata.
Currently, WAET allows hypervisor to inform guest about two
specific behaviors: One
On 15/03/2020 13:56, Liran Alon wrote:
On 14/03/2020 22:56, Michael S. Tsirkin wrote:
On Sat, Mar 14, 2020 at 10:05:20PM +0200, Liran Alon wrote:
Michael, you can also refer to this VMware time-keeping whitepaper:
https://urldefense.com/v3/__https://www.vmware.com/pdf
Gentle ping (A week have passed since submission).
Thanks,
-Liran
On 10/03/2020 2:40, Liran Alon wrote:
Some guests are only familiar with VMware PV interface. Therefore, in
order for these guests to run properly on KVM, we need to be able to
expose VMware main CPUID leaf. i.e. leaf 0x4000
6.5 and it seems that it simply ignores the kick.
Hence, we decided to ignore the kick as well.
Signed-off-by: Elazar Leibovich
Signed-off-by: Liran Alon
---
hw/scsi/vmw_pvscsi.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
in
6.5 and it seems that it simply ignores the kick.
Hence, we decided to ignore the kick as well.
Signed-off-by: Elazar Leibovich
Signed-off-by: Liran Alon
---
hw/scsi/vmw_pvscsi.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
in
6.5 and it seems that it simply ignores the kick.
Hence, we decided to ignore the kick as well.
Signed-off-by: Elazar Leibovich
Signed-off-by: Liran Alon
---
hw/scsi/vmw_pvscsi.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
in
On 14/03/2020 22:56, Michael S. Tsirkin wrote:
On Sat, Mar 14, 2020 at 10:05:20PM +0200, Liran Alon wrote:
Michael, you can also refer to this VMware time-keeping whitepaper:
https://urldefense.com/v3/__https://www.vmware.com/pdf/vmware_timekeeping.pdf__;!!GqivPVa7Brio!K8sfnfvVgKwrQ4SMwX-K6
On 14/03/2020 23:52, Michael S. Tsirkin wrote:
On Sat, Mar 14, 2020 at 12:44:55AM +0200, Liran Alon wrote:
On 13/03/2020 22:07, Philippe Mathieu-Daudé wrote:
On 3/12/20 5:54 PM, Liran Alon wrote:
diff --git a/include/hw/i386/vmport.h b/include/hw/i386/vmport.h
index 34cc050b1ffa
On 14/03/2020 21:58, Nikita Leshenko wrote:
On 14 Mar 2020, at 21:26, Michael S. Tsirkin wrote:
On Sat, Mar 14, 2020 at 09:17:30PM +0200, Liran Alon wrote:
On 14/03/2020 21:14, Michael S. Tsirkin wrote:
On Sat, Mar 14, 2020 at 09:04:30PM +0200, Liran Alon wrote:
On 14/03/2020 20:18
On 14/03/2020 21:14, Michael S. Tsirkin wrote:
On Sat, Mar 14, 2020 at 09:04:30PM +0200, Liran Alon wrote:
On 14/03/2020 20:18, Michael S. Tsirkin wrote:
On Fri, Mar 13, 2020 at 06:26:54PM +0200, Liran Alon wrote:
On 13/03/2020 17:47, Michael S. Tsirkin wrote:
On Fri, Mar 13, 2020 at 05:25
On 14/03/2020 20:25, Michael S. Tsirkin wrote:
On Sat, Mar 14, 2020 at 09:31:31AM +0100, Philippe Mathieu-Daudé wrote:
On 3/13/20 11:38 PM, Liran Alon wrote:
On 13/03/2020 21:57, Philippe Mathieu-Daudé wrote:
On 3/12/20 5:54 PM, Liran Alon wrote:
No functional change. This is mere
On 14/03/2020 20:18, Michael S. Tsirkin wrote:
On Fri, Mar 13, 2020 at 06:26:54PM +0200, Liran Alon wrote:
On 13/03/2020 17:47, Michael S. Tsirkin wrote:
On Fri, Mar 13, 2020 at 05:25:20PM +0200, Liran Alon wrote:
@@ -168,6 +169,20 @@ static uint32_t vmport_cmd_ram_size(void *opaque
On 14/03/2020 20:18, Michael S. Tsirkin wrote:
On Fri, Mar 13, 2020 at 06:26:54PM +0200, Liran Alon wrote:
On 13/03/2020 17:47, Michael S. Tsirkin wrote:
On Fri, Mar 13, 2020 at 05:25:20PM +0200, Liran Alon wrote:
@@ -168,6 +169,20 @@ static uint32_t vmport_cmd_ram_size(void *opaque
On 14/03/2020 10:31, Philippe Mathieu-Daudé wrote:
On 3/13/20 11:38 PM, Liran Alon wrote:
On 13/03/2020 21:57, Philippe Mathieu-Daudé wrote:
On 3/12/20 5:54 PM, Liran Alon wrote:
No functional change. This is mere refactoring.
Suggested-by: Michael S. Tsirkin
Signed-off-by: Liran Alon
On 13/03/2020 22:07, Philippe Mathieu-Daudé wrote:
On 3/12/20 5:54 PM, Liran Alon wrote:
diff --git a/include/hw/i386/vmport.h b/include/hw/i386/vmport.h
index 34cc050b1ffa..aee809521aa0 100644
--- a/include/hw/i386/vmport.h
+++ b/include/hw/i386/vmport.h
@@ -12,6 +12,7 @@ typedef enum
On 13/03/2020 22:05, Philippe Mathieu-Daudé wrote:
On 3/13/20 8:59 PM, Philippe Mathieu-Daudé wrote:
On 3/12/20 5:54 PM, Liran Alon wrote:
--- a/include/hw/i386/vmport.h
+++ b/include/hw/i386/vmport.h
@@ -4,12 +4,21 @@
#define TYPE_VMPORT "vmport"
typedef uint32_t (VMPortRead
On 13/03/2020 21:59, Philippe Mathieu-Daudé wrote:
On 3/12/20 5:54 PM, Liran Alon wrote:
No functional change.
Defining an enum for all VMPort commands have the following advantages:
* It gets rid of the error-prone requirement to update VMPORT_ENTRIES
when new VMPort commands are added
On 13/03/2020 21:57, Philippe Mathieu-Daudé wrote:
On 3/12/20 5:54 PM, Liran Alon wrote:
No functional change. This is mere refactoring.
Suggested-by: Michael S. Tsirkin
Signed-off-by: Liran Alon
---
hw/i386/pc.c | 1 +
hw/i386/vmmouse.c | 1 +
hw/i386/vmport.c
On 13/03/2020 17:47, Michael S. Tsirkin wrote:
On Fri, Mar 13, 2020 at 05:25:20PM +0200, Liran Alon wrote:
@@ -168,6 +169,20 @@ static uint32_t vmport_cmd_ram_size(void *opaque, uint32_t
addr)
return ram_size;
}
+static uint32_t vmport_cmd_time(void *opaque, uint32_t addr
On 13/03/2020 17:58, no-re...@patchew.org wrote:
Patchew URL:
https://urldefense.com/v3/__https://patchew.org/QEMU/20200313145009.144820-1-liran.a...@oracle.com/__;!!GqivPVa7Brio!MCIj6t775fgVLQyuc_7yakcjRzbRpb0QfWeBkZaMwb72--7RvXHTCgm_18diSyk$
Hi,
This series seems to have some coding
On 13/03/2020 2:06, Michael S. Tsirkin wrote:
On Thu, Mar 12, 2020 at 06:54:26PM +0200, Liran Alon wrote:
Similar to CMD_GETTIME but lacks the 136-year overflow issue,
by returning full 64-bit of host uSeconds.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c
On 13/03/2020 2:04, Michael S. Tsirkin wrote:
On Thu, Mar 12, 2020 at 06:54:25PM +0200, Liran Alon wrote:
This command is used by guest to gettimeofday() from host.
See usage example in open-vm-tools TimeSyncReadHost() function.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
This is done as a preparation for the following patch to expose WAET
ACPI table to guest.
This patch performs steps 1-3 as describes in
tests/qtest/bios-tables-test.c.
Signed-off-by: Liran Alon
---
tests/data/acpi/pc/WAET | 0
tests/data/acpi/q35/WAET| 0
Hi,
This patch-series aims to expose WAET ACPI table to guest. Which
improves performance of Windows guests (since Vista) and ignored by
other guests. This ACPI table is exposed by default by other common
hypervisors such as VMware, Xen (HVM), GCP and AWS.
Regards,
-Liran
v1->v2:
- Update
5 54 28 00 00 00 01 88 42 4F 43 48 53 20 // WAET(.BOCHS
0010: 42 58 50 43 57 41 45 54 01 00 00 00 42 58 50 43 // BXPCWAETBXPC
0020: 01 00 00 00 02 00 00 00 //
Signed-off-by: Liran Alon
---
tests/data/acpi/pc/WAET | Bin
dicate that the ACPI PM timer has been enhanced to not require
multiple reads to obtain a reliable value.
This results in improving the performance of Windows guests that use
ACPI PM timer by avoiding unnecessary VMExits caused by these multiple
reads.
Co-developed-by: Elad Gabay
Signed-off-by:
On 13/03/2020 12:05, Igor Mammedov wrote:
On Thu, 12 Mar 2020 19:28:31 +0200
Liran Alon wrote:
On 12/03/2020 18:27, Igor Mammedov wrote:
On Wed, 11 Mar 2020 19:08:26 +0200
Liran Alon wrote:
+
[...]
we typically do not version ACPI table changes (there might be exceptions
but it should
On 13/03/2020 2:09, Michael S. Tsirkin wrote:
On Thu, Mar 12, 2020 at 06:54:27PM +0200, Liran Alon wrote:
Command currently returns that it is unimplemented by setting
the reserved-bit in it's return value.
Following patches will return various useful vCPU information
to guest.
Reviewed
On 12/03/2020 21:47, Michael S. Tsirkin wrote:
On Thu, Mar 12, 2020 at 07:28:31PM +0200, Liran Alon wrote:
On 12/03/2020 18:27, Igor Mammedov wrote:
On Wed, 11 Mar 2020 19:08:26 +0200
Liran Alon wrote:
we typically do not version ACPI table changes (there might be exceptions
but it should
On 12/03/2020 18:35, Igor Mammedov wrote:
On Thu, 12 Mar 2020 14:55:50 +0200
Liran Alon wrote:
On 12/03/2020 14:19, Michael S. Tsirkin wrote:
On Thu, Mar 12, 2020 at 01:30:01PM +0200, Liran Alon wrote:
On 12/03/2020 8:12, Michael S. Tsirkin wrote:
On Thu, Mar 12, 2020 at 01:20:02AM +0200
On 12/03/2020 18:27, Igor Mammedov wrote:
On Wed, 11 Mar 2020 19:08:26 +0200
Liran Alon wrote:
+
+static void
+build_waet(GArray *table_data, BIOSLinker *linker)
see build_hmat_lb() for example how to doc comment for such function
should look like. Use earliest spec version where table
No functional change.
This information will be used by following patches.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
target/i386/cpu.h | 1 +
target/i386/kvm.c | 10 +++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
ko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 19 +++
include/hw/i386/vmport.h | 1 +
2 files changed, 20 insertions(+)
diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c
index 1664a6b97332..9d3921cf418d 100644
--- a/hw/i386/vmport.c
+++ b/hw/i386/vmport.c
@@ -176
Similar to CMD_GETTIME but lacks the 136-year overflow issue,
by returning full 64-bit of host uSeconds.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 17 +
include/hw/i386/vmport.h | 1 +
2 files changed, 18 insertions(+)
diff --git
realized.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c
index 9d3921cf418d..134d793a4c65 100644
--- a/hw/i386/vmport.c
+++ b/hw/i386/vmport.c
@@ -83,6 +83,8 @@ static VMPortState
No functional change. This is mere refactoring.
Suggested-by: Michael S. Tsirkin
Signed-off-by: Liran Alon
---
hw/i386/pc.c | 1 +
hw/i386/vmmouse.c| 1 +
hw/i386/vmport.c | 1 +
include/hw/i386/pc.h | 13 -
include/hw/i386/vmport.h | 16
Command currently returns that it is unimplemented by setting
the reserved-bit in it's return value.
Following patches will return various useful vCPU information
to guest.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 14 ++
include/hw/i386
the VMPort commands supported by QEMU.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmmouse.c| 18 ++
hw/i386/vmport.c | 11 ++-
include/hw/i386/vmport.h | 11 ++-
3 files changed, 18 insertions(+), 22 deletions(-)
diff --git a/hw
As can be seen from VmCheck_GetVersion() in open-vm-tools code,
CMD_GETVERSION should return vmware-vmx-type in ECX register.
Default is to fake host as VMware ESX server. But user can control
this value by "-global vmport.vmware-vmx-type=X".
Reviewed-by: Nikita Leshenko
Signed-off
lobal vmport.vmware-vmx-version=X".
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c
index e67c7bb2afea..8e662303d5d3 100644
--- a/hw/i386/vmport.c
+++ b/hw/i38
This command is used by guest to gettimeofday() from host.
See usage example in open-vm-tools TimeSyncReadHost() function.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 21 +
include/hw/i386/vmport.h | 1 +
2 files changed, 22
->env.regs[R_EAX].
To fix this issue, change vmport_ioport_read() to explicitly override
cpu->env.regs[R_EAX] with the value it wish to propagate to vCPU EAX
register.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/core/machine.c | 1 +
hw/i386/vmport.c
t;) and Linux try_to_enable_x2apic()
function.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c
index 2ce78aaf7b4c..1664a6b97332 100644
--- a/hw/i386/vmport.c
No functional change.
This is done as a preparation for the following patches that will
introduce several device properties.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/i386/vmport.c b/hw/i386
is unimplemented.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/core/machine.c | 1 +
hw/i386/vmport.c | 19 +++
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 0496112b741c..2595a13e5650 100644
--- a/hw
This official VMware open-source project can be used as reference to
understand how guest code interacts with VMPort virtual device. Thus,
providing understanding on how device is expected to behave.
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 7 +++
1 file changed, 7 insertions
so be used by the following patches that will introduce
additional VMPort commands.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/core/machine.c| 1 +
hw/i386/vmport.c | 22 ++
include/hw/i386/vmport.h | 1 +
3 files changed, 24 insertions(+)
diff --git
Hi,
This series aims to fix several bugs in VMPort and improve it by supporting
more VMPort commands and make command results more configurable to
user via QEMU command-line.
This functionality was proven to be useful to run various VMware VMs
when attempting to run them as-is on top of
On 12/03/2020 14:19, Michael S. Tsirkin wrote:
On Thu, Mar 12, 2020 at 01:30:01PM +0200, Liran Alon wrote:
On 12/03/2020 8:12, Michael S. Tsirkin wrote:
On Thu, Mar 12, 2020 at 01:20:02AM +0200, Liran Alon wrote:
On 11/03/2020 22:36, Michael S. Tsirkin wrote:
Thanks for the patch! Some
On 12/03/2020 8:12, Michael S. Tsirkin wrote:
On Thu, Mar 12, 2020 at 01:20:02AM +0200, Liran Alon wrote:
On 11/03/2020 22:36, Michael S. Tsirkin wrote:
Thanks for the patch! Some questions/comments:
On Wed, Mar 11, 2020 at 07:08:26PM +0200, Liran Alon wrote:
From: Elad Gabay
Microsoft
On 11/03/2020 22:24, Michael S. Tsirkin wrote:
Notice the process as documented in ./tests/qtest/bios-tables-test.c
Thanks for explicitly pointing me to that process.
I have followed the process described there (Both steps 1-3 and steps 4-7).
On step (6), I have noted that many existing
On 11/03/2020 22:36, Michael S. Tsirkin wrote:
Thanks for the patch! Some questions/comments:
On Wed, Mar 11, 2020 at 07:08:26PM +0200, Liran Alon wrote:
From: Elad Gabay
Microsoft introduced this ACPI table to avoid Windows guests performing
various workarounds for device erratas
On 11/03/2020 20:59, no-re...@patchew.org wrote:
Patchew URL:
https://urldefense.com/v3/__https://patchew.org/QEMU/20200311170826.79419-1-liran.a...@oracle.com/__;!!GqivPVa7Brio!L4XXKjkDknE86ihbnytm45vsQI41J-QWVCZRoXEXtPKIAsMmknrGJWVPZpKgLyM$
Hi,
This series failed the docker-quick@centos7
-by: Elad Gabay
Co-developed-by: Liran Alon
Signed-off-by: Liran Alon
---
hw/i386/acpi-build.c| 18 ++
hw/i386/pc_piix.c | 2 ++
hw/i386/pc_q35.c| 2 ++
include/hw/acpi/acpi-defs.h | 25 +
include/hw/i386/pc.h| 1 +
5
On 11/03/2020 0:00, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 11:57:49PM +0200, Liran Alon wrote:
On 10/03/2020 23:44, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 02:29:42PM -0700, Liran Alon wrote:
On 10/03/2020 22:56, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 08:09
On 10/03/2020 23:49, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 11:34:00PM +0200, Liran Alon wrote:
On 10/03/2020 23:16, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 04:46:19PM +0200, Liran Alon wrote:
There is no license issue here. It's only definitions.
So it seems
On 10/03/2020 23:44, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 02:29:42PM -0700, Liran Alon wrote:
On 10/03/2020 22:56, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 08:09:09PM +0200, Liran Alon wrote:
On 10/03/2020 19:44, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 06:53
On 10/03/2020 23:16, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 04:46:19PM +0200, Liran Alon wrote:
There is no license issue here. It's only definitions.
So it seems that in your opinion
- definition names in the interface do not need a license
and
- it is fair to reuse them without
On 10/03/2020 22:56, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 08:09:09PM +0200, Liran Alon wrote:
On 10/03/2020 19:44, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 06:53:16PM +0200, Liran Alon wrote:
Hi,
This series aims to fix several bugs in VMPort and improve
On 10/03/2020 19:44, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 06:53:16PM +0200, Liran Alon wrote:
Hi,
This series aims to fix several bugs in VMPort and improve it by supporting
more VMPort commands and make command results more configurable to
user via QEMU command-line
On 10/03/2020 19:36, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 06:39:33PM +0200, Liran Alon wrote:
Isn't enum invented exactly for enumerating all possible values of a field?
No - it just assigns names to constants. If you then proceed not to use
the names, then it's pointless.
It's
the VMPort commands supported by QEMU.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmmouse.c| 18 ++
hw/i386/vmport.c | 11 ++-
include/hw/i386/vmport.h | 11 ++-
3 files changed, 18 insertions(+), 22 deletions(-)
diff --git a/hw
No functional change.
This information will be used by following patches.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
target/i386/cpu.h | 1 +
target/i386/kvm.c | 10 +++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
Command currently returns that it is unimplemented by setting
the reserved-bit in it's return value.
Following patches will return various useful vCPU information
to guest.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 14 ++
include/hw/i386
t;) and Linux try_to_enable_x2apic()
function.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c
index 30641d3ffb20..6ca03273066e 100644
--- a/hw/i386/vmport.c
Similar to CMD_GETTIME but lacks the 136-year overflow issue,
by returning full 64-bit of host uSeconds.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 17 +
include/hw/i386/vmport.h | 1 +
2 files changed, 18 insertions(+)
diff --git
This command is used by guest to gettimeofday() from host.
See usage example in open-vm-tools TimeSyncReadHost() function.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 21 +
include/hw/i386/vmport.h | 1 +
2 files changed, 22
This is VMware documented functionallity that some guests rely on.
Returns the BIOS UUID of the current virtual machine.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 17 +
include/hw/i386/vmport.h | 1 +
2 files changed, 18 insertions
No functional change. This is mere refactoring.
Suggested-by: Michael S. Tsirkin
Signed-off-by: Liran Alon
---
hw/i386/pc.c | 1 +
hw/i386/vmmouse.c| 1 +
hw/i386/vmport.c | 1 +
include/hw/i386/pc.h | 13 -
include/hw/i386/vmport.h | 16
is unimplemented.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c
index 736d78263889..8115852720c8 100644
--- a/hw/i386/vmport.c
+++ b/hw/i386/vmport.c
As can be seen from VmCheck_GetVersion() in open-vm-tools code,
CMD_GETVERSION should return VMX type in ECX register.
Default is to fake host as VMware ESX server. But user can control
this value by "-global vmport.vmx-type=X".
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alo
realized.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c
index 76fd49c52058..8d3d268bfd7e 100644
--- a/hw/i386/vmport.c
+++ b/hw/i386/vmport.c
@@ -72,6 +72,8 @@ static VMPortState
expect different vmx-version, make vmx-version a VMPort object
property. This would allow user to control it's value via
"-global vmport.vmx-version=X".
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletio
-by: Liran Alon
---
hw/i386/vmport.c | 8
1 file changed, 8 insertions(+)
diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c
index 8d7513e2a23c..ca4d95fc017f 100644
--- a/hw/i386/vmport.c
+++ b/hw/i386/vmport.c
@@ -44,6 +44,8 @@ typedef struct VMPortState {
MemoryRegion io
Hi,
This series aims to fix several bugs in VMPort and improve it by supporting
more VMPort commands and make command results more configurable to
user via QEMU command-line.
This functionality was proven to be useful to run various VMware VMs
when attempting to run them as-is on top of
ko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 19 +++
include/hw/i386/vmport.h | 1 +
2 files changed, 20 insertions(+)
diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c
index 6ca03273066e..76fd49c52058 100644
--- a/hw/i386/vmport.c
+++ b/hw/i386/vmport.c
@@ -165
No functional change.
This is done as a preparation for the following patches that will
introduce several device properties.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/i386/vmport.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/i386/vmport.c b/hw/i386
->env.regs[R_EAX].
To fix this issue, change vmport_ioport_read() to explicitly override
cpu->env.regs[R_EAX] with the value it wish to propagate to vCPU EAX
register.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
---
hw/core/machine.c | 1 +
hw/i386/vmport.c
On 10/03/2020 17:10, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 04:46:19PM +0200, Liran Alon wrote:
On 10/03/2020 16:08, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 03:35:25PM +0200, Liran Alon wrote:
On 10/03/2020 14:53, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 02:43
On 10/03/2020 16:39, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 04:24:45PM +0200, Liran Alon wrote:
Re-thinking about this...
QEMU VMPort interface was quite broken already (See first patch in series
"hw/i386/vmport: Propagate IOPort read to vCPU EAX register").
The in
On 10/03/2020 16:08, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 03:35:25PM +0200, Liran Alon wrote:
On 10/03/2020 14:53, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 02:43:51PM +0200, Liran Alon wrote:
On 10/03/2020 14:35, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 02:25
On 10/03/2020 13:22, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:13:21PM +0200, Liran Alon wrote:
On 10/03/2020 11:34, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote:
This is VMware documented functionallity that some guests rely on.
Returns
On 10/03/2020 14:53, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 02:43:51PM +0200, Liran Alon wrote:
On 10/03/2020 14:35, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 02:25:28PM +0200, Liran Alon wrote:
On 10/03/2020 14:14, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54
On 10/03/2020 14:35, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 02:25:28PM +0200, Liran Alon wrote:
On 10/03/2020 14:14, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54:02AM +0200, Liran Alon wrote:
As can be seen from VmCheck_GetVersion() in open-vm-tools code
On 10/03/2020 14:01, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 04:44:54AM -0700, Liran Alon wrote:
On 10/03/2020 11:22, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote:
This is VMware documented functionallity that some guests rely on.
Returns
On 10/03/2020 14:27, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 12:53:28PM +0200, Liran Alon wrote:
On 10/03/2020 11:29, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54:09AM +0200, Liran Alon wrote:
No functional change.
This information will be used by following patches
On 10/03/2020 14:14, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54:02AM +0200, Liran Alon wrote:
As can be seen from VmCheck_GetVersion() in open-vm-tools code,
CMD_GETVERSION should return VMX type in ECX register.
Default is to fake host as VMware ESX server. But user can control
On 10/03/2020 13:46, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:37:40PM +0200, Liran Alon wrote:
On 10/03/2020 13:23, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:16:51PM +0200, Liran Alon wrote:
On 10/03/2020 11:28, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54
On 10/03/2020 13:44, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:28:32PM +0200, Liran Alon wrote:
On 10/03/2020 13:18, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:05:02PM +0200, Liran Alon wrote:
On 10/03/2020 11:32, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54
On 10/03/2020 11:22, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote:
This is VMware documented functionallity that some guests rely on.
Returns the BIOS UUID of the current virtual machine.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
On 10/03/2020 13:23, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:18:44PM +0200, Liran Alon wrote:
On 10/03/2020 11:20, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54:02AM +0200, Liran Alon wrote:
As can be seen from VmCheck_GetVersion() in open-vm-tools code
On 10/03/2020 13:23, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:16:51PM +0200, Liran Alon wrote:
On 10/03/2020 11:28, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54:03AM +0200, Liran Alon wrote:
No functional change.
Defining an enum for all VMPort commands have
On 10/03/2020 13:22, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:13:21PM +0200, Liran Alon wrote:
On 10/03/2020 11:34, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote:
This is VMware documented functionallity that some guests rely on.
Returns
On 10/03/2020 13:18, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:05:02PM +0200, Liran Alon wrote:
On 10/03/2020 11:32, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54:01AM +0200, Liran Alon wrote:
Instead of hard-coding the VMX version, make it a VMPORT object property
On 10/03/2020 11:20, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54:02AM +0200, Liran Alon wrote:
As can be seen from VmCheck_GetVersion() in open-vm-tools code,
CMD_GETVERSION should return VMX type in ECX register.
Default is to fake host as VMware ESX server. But user can control
On 10/03/2020 11:28, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54:03AM +0200, Liran Alon wrote:
No functional change.
Defining an enum for all VMPort commands have the following advantages:
* It gets rid of the error-prone requirement to update VMPORT_ENTRIES
when new VMPort
On 10/03/2020 11:34, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote:
This is VMware documented functionallity that some guests rely on.
Returns the BIOS UUID of the current virtual machine.
Reviewed-by: Nikita Leshenko
Signed-off-by: Liran Alon
So
1 - 100 of 270 matches
Mail list logo
