From: M. Mohan Kumar mo...@in.ibm.com
bdrv_flags is set by bdrv_parse_discard_flags(), but later it is reset
to zero.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
blockdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index e174b7d..bc7016a 100644
Stefan Weil s...@weilnetz.de writes:
The leak was reported by cppcheck.
Function proxy_init also calls g_free for ctx-fs_root.
Avoid reuse of this memory by setting ctx-fs_root to NULL.
Signed-off-by: Stefan Weil s...@weilnetz.de
Reviewed-by: M. Mohan Kumar mo...@in.ibm.com
---
Hi,
I'm
From: M. Mohan Kumar mo...@in.ibm.com
Fix few more memory leaks in virtio-9p-device.c detected using valgrind.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
hw/9pfs/virtio-9p-device.c | 26 +-
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/hw/9pfs
Stefan Weil s...@weilnetz.de writes:
This leak was reported by cppcheck.
Signed-off-by: Stefan Weil s...@weilnetz.de
Reviewed-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/qemu-fsdev.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c
index
,
I tried ./configure --disable-system --enable-virtfs and make. But didnt
face any build failure. Could you please share your build failure
information? virtfs-proxy-helper.1 is created inside the fsdev folder.
Cc: qemu-triv...@nongnu.org
Cc: M. Mohan Kumar mo...@in.ibm.com
Signed-off
Peter Maydell peter.mayd...@linaro.org writes:
How about this approach?
[PATCH] configure: Disable virtfs if softmmu not enabled
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
configure | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
Michael Tokarev m...@tls.msk.ru writes:
11.06.2013 21:23, M. Mohan Kumar wrote:
Peter Maydell peter.mayd...@linaro.org writes:
How about this approach?
Well, this is definitely wrong :)
-if test $softmmu = yes ; then
- if test $virtfs != no ; then
+
+if test $virtfs
-fsdev can take local, handle and proxy. Could you please use try with
one of them?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1130769
Title:
VirtFS (virtio-9p-pci) error: Parameter 'driver'
Michael Tokarev m...@tls.msk.ru writes:
28.02.2013 13:12, Aneesh Kumar K.V wrote:
Michael Tokarev m...@tls.msk.ru writes:
When guest tries to chmod a block or char device file over 9pfs,
the qemu process segfaults.
On host:
qemu-system-x86_64 -virtfs
Michael Tokarev m...@tls.msk.ru writes:
Hi,
Please try mounting with -oversion=9p2000.L
With qemu-1.4.0 and 9p2000.L, I could not recreate this issue. ie not
getting Unknown error during directory listing.
I am using Guest kernel 3.8.0-rc5+.
When I mount a 9pfs filesystem in guest with no
Michael Tokarev m...@tls.msk.ru writes:
28.02.2013 17:55, M. Mohan Kumar wrote:
Michael Tokarev m...@tls.msk.ru writes:
Hi,
Please try mounting with -oversion=9p2000.L
With qemu-1.4.0 and 9p2000.L, I could not recreate this issue. ie not
getting Unknown error during directory listing
err_suid;
+}
After changing the order of setresuid and setresgid this patch works as
expected. Please move setresgid before setresuid.
Tested-by: M. Mohan Kumar mo...@in.ibm.com
Stefan Weil s...@weilnetz.de writes:
We need to change fsuid and fsgid in 9p server side when 9p client wants
to create a file with given uid and gid.
In my case setfsuid and setfsgid never return -1 even if a normal user tries to
change fsuid.
I am running F17 and glibc is 2.15-56.fc17
IMHO
From: M. Mohan Kumar mo...@in.ibm.com
In current implementation of setfsuid/setfsgid there is no way to know
if it failed by checking the return value. This patch assumes
setfsuid/setfsgid returns -1 in case of error. Eventually kernel code
needs to be fixed.
Signed-off-by: M. Mohan Kumar mo
Georg,
pass-through security model needs root privilege, if you want to run
qemu as non-root user either you have to use mapped security model or
proxy fs driver. But libvirt does not have support for proxy FS driver.
I posted a patch few months ago to libvirt for enabling the same. I will
do the
No, commit daf0b9aca9f67323266af1a92e8ea06f9d7bf408 added create
support proxy FS driver model. Local FS had support for creating files
much before.
Georg, is qemu running with root user privileges?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
Hi Max,
Could you try passing msize=262144 for 9p mount point and post the
results?
Host:
[root@llm116 media]# ls -lhas file
1.1G -rw-r--r-- 1 root root 1.0G Apr 26 11:05 file
[root@llm116 media]# dd if=/dev/zero of=file bs=1M count=1024
1024+0 records in
1024+0 records out
1073741824 bytes
Hi Anthony,
When I tried with ldconfig version 2.14.90, ldconfig successfully completed
QEMU version: 1.0.50
Kernel version: 3.3.0-rc6+
Could you please try with recent ldconfig?
On 02/22/2012 09:28 AM, C Anthony Risinger wrote:
On Sat, Feb 18, 2012 at 11:38 AM, Aneesh Kumar K.V
Hi,
I will give a fix to disable virtfs by providing a configure option
--disable-virtfs.
But if you want use virtfs with your current setup, we can give the
option to
disable handle and proxy FS driver. Still you can use local FS driver.
Meador Inge wrote:
Did these [1] builds errors
Acked-by: M. Mohan Kumar mo...@in.ibm.com
On Monday, January 16, 2012 11:41:40 PM Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
When 2c74c2cb4bedddbfa67628fbd5f9273b4e0e9903 added support for
the 'readonly' flag against 9p filesystems, it also made QEMU
add
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index baafee2..5aafc38 100644
From: M. Mohan Kumar mo...@in.ibm.com
In passthrough security model in local fs driver, after a file creation
chown and chmod are done to set the file credentials and mode as requested
by 9p client. But if there was a request to create a file with S_ISGID
bit, doing chown on that file resets
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
qemu-options.hx | 25 -
1 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index b3db10c..cfc999f 100644
--- a/qemu-options.hx
+++ b
From: M. Mohan Kumar mo...@in.ibm.com
Provide root privilege access to QEMU 9p proxy filesystem using socket
communication.
Proxy helper is started by root user as:
~ # virtfs-proxy-helper -f|--fd socket descriptor -p|--path path-to-share
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
From: M. Mohan Kumar mo...@in.ibm.com
Add xattr support for proxy FS
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 99 ++
hw/9pfs/virtio-9p-proxy.c | 124 ---
hw/9pfs/virtio-9p
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 182 ++
hw/9pfs/virtio-9p-proxy.c | 206 +--
hw/9pfs/virtio-9p-proxy.h | 34 +++
3 files
From: M. Mohan Kumar mo...@in.ibm.com
Add interfaces to open and create files for proxy file system driver.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 178 -
hw/9pfs/virtio-9p-proxy.c | 187
From: M. Mohan Kumar mo...@in.ibm.com
Add proxy getversion to get generation number
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 80 +++
hw/9pfs/virtio-9p-proxy.c | 32 +
hw/9pfs/virtio-9p-proxy.h
From: M. Mohan Kumar mo...@in.ibm.com
Add new proxy filesystem driver to add root privilege to qemu process.
It needs a helper process to be started by root user.
Following command line can be used to utilize proxy filesystem driver
-virtfs proxy,id=id,mount_tag=tag,socket_fd=socket-fd
Signed
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
This remove all conditional code from common code path and
make opt validation a FSDriver callback.
Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/file-op
From: M. Mohan Kumar mo...@in.ibm.com
Pass-through security model in QEMU 9p server needs root privilege to do
few file operations (like chown, chmod to any mode/uid:gid). There are two
issues in pass-through security model
1) TOCTTOU vulnerability: Following symbolic links in the server could
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile | 12 +++-
fsdev/virtfs-proxy-helper.texi | 59
2 files changed, 70 insertions(+), 1 deletions(-)
create mode 100644 fsdev
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
---
fsdev/virtio-9p-marshal.c | 148 --
fsdev/virtio-9p-marshal.h | 19 +-
hw/9pfs/virtio-9p.c | 467
From: M. Mohan Kumar mo...@in.ibm.com
Move p9 marshaling/unmarshaling code to a separate file so that
proxy filesytem driver can use these calls. Also made marshaling
code generic to accept struct iovec instead of V9fsPDU.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile.objs
From: M. Mohan Kumar mo...@in.ibm.com
Add file ownership interfaces like chmod/chown, utime update, rename,
remove and truncating files for proxy FS
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile|2 +-
fsdev/virtfs-proxy-helper.c | 83
From: M. Mohan Kumar mo...@in.ibm.com
Add option to use named socket for communicating between proxy helper
and qemu proxy FS. Access to socket can be given by using command line
options -u and -g. We can achive the same using a shell script over
qemu and virtfs-proxy-helper using exec fdsocket
From: M. Mohan Kumar mo...@in.ibm.com
Add interfaces to create filesystem objects like directory,
device nodes, symbolic links, links for proxy filesytem driver
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 129 ++--
hw/9pfs/virtio-9p
On Thursday, December 08, 2011 11:16:33 PM Stefan Hajnoczi wrote:
On Mon, Dec 05, 2011 at 09:48:37PM +0530, M. Mohan Kumar wrote:
From: M. Mohan Kumar mo...@in.ibm.com
Pass-through security model in QEMU 9p server needs root privilege to do
few file operations (like chown, chmod to any
On Friday, December 09, 2011 12:01:14 AM Stefan Hajnoczi wrote:
On Mon, Dec 05, 2011 at 09:48:41PM +0530, M. Mohan Kumar wrote:
+static int read_request(int sockfd, struct iovec *iovec, ProxyHeader
*header) +{
+int retval;
+
+/*
+ * read the request header
From: M. Mohan Kumar mo...@in.ibm.com
Move p9 marshaling/unmarshaling code to a separate file so that
proxy filesytem driver can use these calls. Also made marshaling
code generic to accept struct iovec instead of V9fsPDU.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile.objs
From: M. Mohan Kumar mo...@in.ibm.com
Add interfaces to open and create files for proxy file system driver.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 191 ++-
hw/9pfs/virtio-9p-proxy.c | 189
From: M. Mohan Kumar mo...@in.ibm.com
Add new proxy filesystem driver to add root privilege to qemu process.
It needs a helper process to be started by root user.
Following command line can be used to utilize proxy filesystem driver
-virtfs proxy,id=id,mount_tag=tag,socket_fd=socket-fd
Signed
From: M. Mohan Kumar mo...@in.ibm.com
Provide root privilege access to QEMU 9p proxy filesystem using socket
communication.
Proxy helper is started by root user as:
~ # virtfs-proxy-helper -f|--fd socket descriptor -p|--path path-to-share
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
From: M. Mohan Kumar mo...@in.ibm.com
Pass-through security model in QEMU 9p server needs root privilege to do
few file operations (like chown, chmod to any mode/uid:gid). There are two
issues in pass-through security model
1) TOCTTOU vulnerability: Following symbolic links in the server could
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
qemu-options.hx | 25 -
1 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 681eaf1..cde17ed 100644
--- a/qemu-options.hx
+++ b
From: M. Mohan Kumar mo...@in.ibm.com
Add option to use named socket for communicating between proxy helper
and qemu proxy FS. Access to socket can be given by using command line
options -u and -g. We can achive the same using a shell script over
qemu and virtfs-proxy-helper using exec fdsocket
From: M. Mohan Kumar mo...@in.ibm.com
Add file ownership interfaces like chmod/chown, utime update, rename,
remove and truncating files for proxy FS
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile|2 +-
fsdev/virtfs-proxy-helper.c | 83
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 182 +
hw/9pfs/virtio-9p-proxy.c | 209 +--
hw/9pfs/virtio-9p-proxy.h | 34 +++
3 files
From: M. Mohan Kumar mo...@in.ibm.com
Add proxy getversion to get generation number
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 80 +++
hw/9pfs/virtio-9p-proxy.c | 33 ++
hw/9pfs/virtio-9p-proxy.h
From: M. Mohan Kumar mo...@in.ibm.com
Add interfaces to create filesystem objects like directory,
device nodes, symbolic links, links for proxy filesytem driver
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 131 ++--
hw/9pfs/virtio-9p
From: M. Mohan Kumar mo...@in.ibm.com
Add xattr support for proxy FS
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 99 +
hw/9pfs/virtio-9p-proxy.c | 128 ---
hw/9pfs/virtio-9p-proxy.h
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
---
fsdev/virtio-9p-marshal.c | 148 --
fsdev/virtio-9p-marshal.h | 19 +-
hw/9pfs/virtio-9p.c | 467
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile | 12 +++-
fsdev/virtfs-proxy-helper.texi | 59
2 files changed, 70 insertions(+), 1 deletions(-)
create mode 100644 fsdev
Hi Avishay,
Are you running qemu as a normal user? In that case, could you please
check whether normal user has rw access to the kernel source?
Also could you please attach the output of strace scripts/kconfig/conf
--silentoldconfig Kconfig ?
--
You received this bug notification because you
Could you please give your host information? Such as gcc version, distro
version etc?
I could compile in my Fedora 15 x86-64 system using gcc 4.6.0
--
Regards,
M. Mohan Kumar
On Tuesday, November 29, 2011 06:27:00 PM erik.r...@rdsoftware.de wrote:
Hi all,
when compiling the 1.0-rc4 I get
From: M. Mohan Kumar mo...@in.ibm.com
Add proxy getversion to get generation number
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 77 +++
hw/9pfs/virtio-9p-proxy.c | 34 +++
hw/9pfs/virtio-9p
From: M. Mohan Kumar mo...@in.ibm.com
Add interfaces to create filesystem objects like directory,
device nodes, symbolic links, links for proxy filesytem driver
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 120 ++--
hw/9pfs/virtio-9p
From: M. Mohan Kumar mo...@in.ibm.com
Add validatio check to {un}marshal code.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtio-9p-marshal.c | 97 ---
fsdev/virtio-9p-marshal.h |8 +-
hw/9pfs/virtio-9p.c | 231
From: M. Mohan Kumar mo...@in.ibm.com
Add option to use named socket for communicating between proxy helper
and qemu proxy FS. Access to socket can be given by using command line
options -u and -g. We can achive the same using a shell script over
qemu and virtfs-proxy-helper using exec fdsocket
From: M. Mohan Kumar mo...@in.ibm.com
Add interfaces to open and create files for proxy file system driver.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 133 ++-
hw/9pfs/virtio-9p-proxy.c | 187
From: M. Mohan Kumar mo...@in.ibm.com
Add file ownership interfaces like chmod/chown, utime update, rename,
remove and truncating files for proxy FS
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile|2 +-
fsdev/virtfs-proxy-helper.c | 88
From: M. Mohan Kumar mo...@in.ibm.com
Provide root privilege access to QEMU 9p proxy filesystem using socket
communication.
Proxy helper is started by root user as:
~ # virtfs-proxy-helper -f|--fd socket descriptor -p|--path path-to-share
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 182 +
hw/9pfs/virtio-9p-proxy.c | 189 +--
hw/9pfs/virtio-9p-proxy.h | 34
3
From: M. Mohan Kumar mo...@in.ibm.com
Add xattr support for proxy FS
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 93 ++-
hw/9pfs/virtio-9p-proxy.c | 130 +++---
hw/9pfs/virtio-9p-proxy.h
From: M. Mohan Kumar mo...@in.ibm.com
Move p9 marshaling/unmarshaling code to a separate file so that
proxy filesytem driver can use these calls. Also made marshaling
code generic to accept struct iovec instead of V9fsPDU.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile.objs
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile | 12 +++-
fsdev/virtfs-proxy-helper.texi | 59
2 files changed, 70 insertions(+), 1 deletions(-)
create mode 100644 fsdev
From: M. Mohan Kumar mo...@in.ibm.com
Pass-through security model in QEMU 9p server needs root privilege to do
few file operations (like chown, chmod to any mode/uid:gid). There are two
issues in pass-through security model
1) TOCTTOU vulnerability: Following symbolic links in the server could
From: M. Mohan Kumar mo...@in.ibm.com
Add new proxy filesystem driver to add root privilege to qemu process.
It needs a helper process to be started by root user.
Following command line can be used to utilize proxy filesystem driver
-virtfs proxy,id=id,mount_tag=tag,socket_fd=socket-fd
Signed
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
qemu-options.hx | 25 -
1 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 681eaf1..cde17ed 100644
--- a/qemu-options.hx
+++ b
Stefan Hajnoczi wrote:
On Tue, Nov 15, 2011 at 11:57 AM, M. Mohan Kumarmo...@in.ibm.com wrote:
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
new file mode 100644
index 000..69daf7c
--- /dev/null
+++ b/fsdev/virtfs-proxy-helper.c
@@ -0,0 +1,271 @@
+/*
+ * Helper
operations
(like CAP_DAC_OVERRIDE, CAP_FOWNER etc)
M. Mohan Kumar (12):
hw/9pfs: Move pdu_marshal/unmarshal code to a seperate file
hw/9pfs: Add new proxy filesystem driver
hw/9pfs: File system helper process for qemu 9p proxy FS
hw/9pfs: Open and create files
hw/9pfs: Create other filesystem
Add file ownership interfaces like chmod/chown, utime update, rename,
remove and truncating files for proxy FS
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile|2 +-
fsdev/virtfs-proxy-helper.c | 66 +
hw/9pfs/virtio-9p-proxy.c | 134
Add interfaces to create filesystem objects like directory,
device nodes, symbolic links, links for proxy filesytem driver
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 105 --
hw/9pfs/virtio-9p-proxy.c | 173
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 165
hw/9pfs/virtio-9p-proxy.c | 174 +--
hw/9pfs/virtio-9p-proxy.h | 34 +
3 files changed, 367 insertions(+), 6
Add new proxy filesystem driver to add root privilege to qemu process.
It needs a helper process to be started by root user.
Following command line can be used to utilize proxy filesystem driver
-virtfs proxy,id=id,mount_tag=tag,socket_fd=socket-fd
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
Move p9 marshaling/unmarshaling code to a separate file so that
proxy filesytem driver can use these calls. Also made marshaling
code generic to accept struct iovec instead of V9fsPDU.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile.objs |2 +-
fsdev/virtio-9p
operations
(like CAP_DAC_OVERRIDE, CAP_FOWNER etc)
M. Mohan Kumar (12):
hw/9pfs: Move pdu_marshal/unmarshal code to a seperate file
hw/9pfs: Add new proxy filesystem driver
hw/9pfs: File system helper process for qemu 9p proxy FS
hw/9pfs: Open and create files
hw/9pfs: Create other filesystem
Add xattr support for proxy FS
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 78 -
hw/9pfs/virtio-9p-proxy.c | 119 +++
hw/9pfs/virtio-9p-proxy.h |4 ++
3 files changed, 190
Add proxy getversion to get generation number
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 74 +++
hw/9pfs/virtio-9p-proxy.c | 31 ++
hw/9pfs/virtio-9p-proxy.h |1 +
3 files changed, 106
Add interfaces to open and create files for proxy file system driver.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 136 +++-
hw/9pfs/virtio-9p-proxy.c | 180 +--
hw/9pfs/virtio-9p-proxy.h
Provide root privilege access to QEMU 9p proxy filesystem using socket
communication.
Proxy helper is started by root user as:
~ # virtfs-proxy-helper -f|--fd socket descriptor -p|--path path-to-share
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile|3
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
This remove all conditional code from common code path and
make opt validation a FSDriver callback.
Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/file-op-9p.h
From: M. Mohan Kumar mo...@in.ibm.com
Provide root privilege access to QEMU 9p proxy filesystem using socket
communication.
Proxy helper is started by root user as:
~ # virtfs-proxy-helper
{{-s|--socket socketname -u|--uid -g|--gid}|{-f|--fd socket descriptor}}
-p path-to-share [-r runasuid
From: M. Mohan Kumar mo...@in.ibm.com
Add option to use named socket for communicating between proxy helper
and qemu proxy FS. Access to socket can be given by using command line
options -u and -g.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
hw/9pfs/virtfs-proxy-helper.c | 89
From: M. Mohan Kumar mo...@in.ibm.com
Add interfaces to create filesystem objects like directory,
device nodes, symbolic links, links for proxy filesytem driver
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
hw/9pfs/proxy.h |4 ++
hw/9pfs/virtfs-proxy-helper.c | 63
From: M. Mohan Kumar mo...@in.ibm.com
Add file ownership interfaces like chmod/chown, utime update, rename,
remove and truncating files for proxy FS
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
hw/9pfs/proxy.h |6 ++
hw/9pfs/virtfs-proxy-helper.c | 61
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile | 12 ++-
hw/9pfs/virtfs-proxy-helper.texi | 63 ++
2 files changed, 74 insertions(+), 1 deletions(-)
create mode 100644 hw/9pfs
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
qemu-options.hx | 30 ++
1 files changed, 22 insertions(+), 8 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 8df6165..eef98c5 100644
--- a/qemu-options.hx
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
hw/9pfs/proxy.h |3 ++
hw/9pfs/virtfs-proxy-helper.c | 81 -
hw/9pfs/virtio-9p-proxy.c | 67 +++---
3 files
From: M. Mohan Kumar mo...@in.ibm.com
Add new proxy filesystem driver to add root privilege to qemu process.
It needs a helper process to be started by root user.
Following command line can be used to utilize proxy filesystem driver
-virtfs proxy,id=id,mount_tag=tag,sock_fd=socket-fd
Signed-off
From: M. Mohan Kumar mo...@in.ibm.com
Move p9 marshaling/unmarshaling code to a separate file so that
proxy filesytem driver can use these calls. Also made marshaling
code generic to accept struct iovec instead of V9fsPDU.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: Aneesh
From: M. Mohan Kumar mo...@in.ibm.com
Pass-through security model in QEMU 9p server needs root privilege to do
few file operations (like chown, chmod to any mode/uid:gid). There are two
issues in pass-through security model
1) TOCTTOU vulnerability: Following symbolic links in the server could
From: M. Mohan Kumar mo...@in.ibm.com
Add xattr support for proxy FS
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
hw/9pfs/proxy.h |4 ++
hw/9pfs/virtfs-proxy-helper.c | 60
hw/9pfs/virtio-9p-proxy.c | 121
From: M. Mohan Kumar mo...@in.ibm.com
Add interfaces to open and create files for proxy file system driver.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile |2 +
configure |1 +
hw/9pfs/proxy.h |6 ++
hw/9pfs/virtfs
A new fsdev parameter readonly is introduced to control accessing 9p export.
readonly can be used to specify the access type. By default rw access
is given to 9p export.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/file-op-9p.h |4 +++-
fsdev/qemu-fsdev.c |7 ++-
hw
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Changes from previous version V2:
* qemu_opt_set_bool does not need to call qemu_opt_parse, because it
supports only setting boolean types
Changes from previous version:
* Changed qemu_opt_{get|set}_bool to use 'bool' data type
qemu-option.c
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Changes from previous version:
* Changed qemu_opt_{get|set}_bool to use 'bool' data type
qemu-option.c | 43 +++
qemu-option.h |3 ++-
2 files changed, 41
From: M. Mohan Kumar mo...@in.ibm.com
A new fsdev parameter readonly is introduced to control accessing 9p export.
readonly=on|off can be used to specify the access type. By default rw access
is given to 9p export.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Changes from previous version
Except local fs driver other fs drivers (handle) don't need
security model. Update fsdev parameter parsing accordingly.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/qemu-fsdev.c | 26 +-
qemu-options.hx| 12
vl.c |6
--
Regards,
M. Mohan Kumar
On Wednesday, October 12, 2011 09:37:23 PM Daniel P. Berrange wrote:
On Wed, Oct 12, 2011 at 09:05:50PM +0530, M. Mohan Kumar wrote:
On Wed, Oct 12, 2011 at 01:24:16PM +0530, M. Mohan Kumar wrote:
Security model is needed only for 'local' fs driver
1 - 100 of 263 matches
Mail list logo
