of QEMU and need a way to properly
differentiate them.
Because there's always the chance someone will want to consume an
interface programmatically, also add a -json option that does the same
but outputs a machine-readable JSON object.
Signed-off-by: Manos Pitsidianakis
---
Changes
of QEMU and need a way to properly
differentiate them.
Because there's always the chance someone will want to consume an
interface programmatically, also add a -json option that does the same
but outputs a machine-readable JSON object.
Signed-off-by: Manos Pitsidianakis
---
Notes:
Sample o
il_error:
-error_setg(errp, "Failed to initialize PW context");
fail:
if (pw->thread_loop) {
pw_thread_loop_stop(pw->thread_loop);
--
2.44.2
Reviewed-by: Manos Pitsidianakis
il_error:
-error_setg(errp, "Failed to initialize PW context");
fail:
if (pw->thread_loop) {
pw_thread_loop_stop(pw->thread_loop);
--
2.44.2
Reviewed-by: Manos Pitsidianakis
Set rust source code to diff=rust (built-in with new git versions)
and merge=binary for Cargo.lock files (they should not be merged but
auto-generated by cargo)
Reviewed-by: Alex Bennée
Reviewed-by: Zhao Liu
Signed-off-by: Manos Pitsidianakis
---
.gitattributes | 3 +++
1 file changed, 3
From: Paolo Bonzini
Include the correct path and arguments to rustc in the native
and cross files (native compilation is needed for procedural
macros).
Based on the host architecture and OS, the compiler and optionally the argument
to --cpu, the Rust target triple can be detected automatically f
Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and
provides some declaration macros for symbols visible to the rest of
QEMU.
Co-authored-by: Junjie Mao
Co-authored-by: Paolo Bonzini
Signed-off-by: Junjie Mao
Signed-off-by: Paolo Bonzini
Signed-off-by: Manos Pitsidianakis
Co-authored-by: Paolo Bonzini
Signed-off-by: Junjie Mao
Signed-off-by: Paolo Bonzini
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS| 5 +
meson.build| 24 +
hw/arm/Kconfig
: Paolo Bonzini
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS| 4 +++
configure | 7
meson.build| 41 ++
rust/wrapper.h | 47 ++
rust/.gitignore| 3 ++
rust/meson.build
macro is introduced in this patch, #[derive(Object)]. It
generates a constructor to register a QOM TypeInfo on init and it must
be used on types that implement qemu_api::definitions::ObjectImpl trait.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS| 1
Add rust feature in meson.build, configure, to prepare for adding Rust
code in the followup commits.
Signed-off-by: Manos Pitsidianakis
Reviewed-by: Alex Bennée
---
MAINTAINERS | 5 +
meson.build | 22 +-
Kconfig
. The device is used in the arm virt machine if qemu
is compiled with rust enabled (./configure --enable-rust [...])
Signed-off-by: Manos Pitsidianakis
---
Changes in v10:
- Removed unnecessary meson version check (thanks Alex)
- Added warning in `configure` when Rust is not disabled about what to
Rust crates, introduced from the next commit onwards, can optionally use
the glib allocator API and need to know whether g_aligned_alloc etc are
available.
This commit adds a define in config_host_data that depends on glib
version >= 2.72.
Reviewed-by: Alex Bennée
Signed-off-by: Ma
On Sun, 08 Sep 2024 10:28, Joseph Kurape wrote:
Hello,
I'm new to open-source, but I've learned C and Python.
I've read the 'Getting Started' guide, but aside from signing up for the
mailing list and getting the source code, it doesn't provide much direction
for beginners.
I'm looking for som
On Wed, 04 Sep 2024 14:01, Paolo Bonzini wrote:
On Wed, Aug 28, 2024 at 6:12 AM Manos Pitsidianakis
wrote:
Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and
provides some declaration macros for symbols visible to the rest of
QEMU.
The only comment I have is that I
On Fri, 30 Aug 2024 14:03, Alex Bennée wrote:
[.snip.]
It is there:
/usr/lib/llvm-14/lib/clang/14.0.6/include/stdatomic.h
in the search path:
clang -E -Wp,-v -
clang -cc1 version 14.0.6 based upon LLVM 14.0.6 default target
x86_64-pc-linux-gnu
ignoring nonexistent directory
"/usr/bin/.
🎱
On Fri, 30 Aug 2024, 04:19 Junjie Mao, wrote:
> On 8/28/2024 9:08 PM, Alex Bennée wrote:
> > Manos Pitsidianakis writes:
> >
> >> Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and
> >> provides some declaration macros for symbols
Add rust feature in meson.build, configure, to prepare for adding Rust
code in the followup commits.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS | 5 +
meson.build | 25 -
Kconfig | 1 +
Kconfig.host
Set rust source code to diff=rust (built-in with new git versions)
and merge=binary for Cargo.lock files (they should not be merged but
auto-generated by cargo)
Reviewed-by: Alex Bennée
Reviewed-by: Zhao Liu
Signed-off-by: Manos Pitsidianakis
---
.gitattributes | 3 +++
1 file changed, 3
macro is introduced in this patch, #[derive(Object)]. It
generates a constructor to register a QOM TypeInfo on init and it must
be used on types that implement qemu_api::definitions::ObjectImpl trait.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS | 1 +
rust/meson.build
Co-authored-by: Paolo Bonzini
Signed-off-by: Junjie Mao
Signed-off-by: Paolo Bonzini
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS| 5 +
meson.build| 24 +
hw/arm/Kconfig
From: Paolo Bonzini
Include the correct path and arguments to rustc in the native
and cross files (native compilation is needed for procedural
macros).
Signed-off-by: Paolo Bonzini
---
configure | 50 --
meson.build | 8 +++-
2 files chang
Rust crates, introduced from the next commit onwards, use the glib
allocator API and need to know whether g_aligned_alloc etc are
available.
This commit adds a define in config_host_data that depends on glib
version >= 2.72.
Signed-off-by: Manos Pitsidianakis
---
meson.build | 4
1 f
: Paolo Bonzini
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS| 4 +++
meson.build| 34 +++
rust/wrapper.h | 39 +
rust/.gitignore| 3 ++
rust/meson.build | 0
scripts/rust/rustc_args.py
Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and
provides some declaration macros for symbols visible to the rest of
QEMU.
Co-authored-by: Junjie Mao
Co-authored-by: Paolo Bonzini
Signed-off-by: Junjie Mao
Signed-off-by: Paolo Bonzini
Signed-off-by: Manos Pitsidianakis
Rust, chosen for
its low complexity. The device is used in the arm virt machine if qemu
is compiled with rust enabled (./configure --enable-rust [...])
Signed-off-by: Manos Pitsidianakis
---
Changes in v9:
- Addressed v8 review comment: removed rustfmt.toml symlink (Junjie Mao)
- Address
Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and
provides some declaration macros for symbols visible to the rest of
QEMU.
Co-authored-by: Junjie Mao
Co-authored-by: Paolo Bonzini
Signed-off-by: Junjie Mao
Signed-off-by: Paolo Bonzini
Signed-off-by: Manos Pitsidianakis
Set rust source code to diff=rust (built-in with new git versions)
and merge=binary for Cargo.lock files (they should not be merged but
auto-generated by cargo)
Reviewed-by: Alex Bennée
Reviewed-by: Zhao Liu
Signed-off-by: Manos Pitsidianakis
---
.gitattributes | 3 +++
1 file changed, 3
: Paolo Bonzini
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS| 4 +++
meson.build| 34 +++
rust/wrapper.h | 39 +
rust/.gitignore| 3 ++
rust/meson.build | 0
scripts/rust/rustc_args.py
macro is introduced in this patch, #[derive(Object)]. It
generates a constructor to register a QOM TypeInfo on init and it must
be used on types that implement qemu_api::definitions::ObjectImpl trait.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS | 1 +
rust/meson.build
From: Paolo Bonzini
This is needed for Rust support.
Signed-off-by: Paolo Bonzini
---
meson.build| 2 +-
python/scripts/vendor.py | 4 ++--
python/wheels/meson-1.2.3-py3-none-any.whl | Bin 964928 -> 0 bytes
python/wheels/meson-1.5.0-py3-no
Add rust feature in meson.build, configure, to prepare for adding Rust
code in the followup commits.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS | 5 +
meson.build | 25 -
Kconfig | 1 +
Kconfig.host
Co-authored-by: Paolo Bonzini
Signed-off-by: Junjie Mao
Signed-off-by: Paolo Bonzini
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS| 5 +
meson.build| 24 +
hw/arm/Kconfig
Rust, chosen for
its low complexity. The device is used in the arm virt machine if qemu
is compiled with rust enabled (./configure --enable-rust [...])
Signed-off-by: Manos Pitsidianakis
---
Changes in v9:
- Addressed v8 review comment: removed rustfmt.toml symlink (Junjie Mao)
- Address
Rust crates, introduced from the next commit onwards, use the glib
allocator API and need to know whether g_aligned_alloc etc are
available.
This commit adds a define in config_host_data that depends on glib
version >= 2.72.
Signed-off-by: Manos Pitsidianakis
---
meson.build | 4
1 f
From: Paolo Bonzini
Include the correct path and arguments to rustc in the native
and cross files (native compilation is needed for procedural
macros).
Signed-off-by: Paolo Bonzini
---
configure | 50 --
meson.build | 8 +++-
2 files chang
On Mon, 26 Aug 2024 11:24, Thomas Huth wrote:
On 26/08/2024 08.41, Manos Pitsidianakis wrote:
On Mon, 26 Aug 2024 08:31, Junjie Mao wrote:
+unsafe impl GlobalAlloc for QemuAllocator {
+ unsafe fn alloc(&self, layout: Layout) -> *mut u8 {
+ if layout.align
On Mon, 26 Aug 2024 08:31, Junjie Mao wrote:
+unsafe impl GlobalAlloc for QemuAllocator {
+unsafe fn alloc(&self, layout: Layout) -> *mut u8 {
+if layout.align() == 0 {
+g_malloc0(layout.size().try_into().unwrap()).cast::()
+} else {
+g_aligned_alloc0(
On Mon, 26 Aug 2024 08:03, Junjie Mao wrote:
Hi Manos,
On 8/23/2024 4:11 PM, Manos Pitsidianakis wrote:
Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and
provides some declaration macros for symbols visible to the rest of
QEMU.
Co-authored-by: Junjie Mao
Co-authored
Hello Junjie,
On Mon, 26 Aug 2024 08:15, Junjie Mao wrote:
On 8/23/2024 4:11 PM, Manos Pitsidianakis wrote:
This commit adds a helper crate library, qemu-api-macros for derive (and
other procedural) macros to be used along qemu-api.
It needs to be a separate library because in Rust
macro is introduced in this patch, #[derive(Object)]. It
generates a constructor to register a QOM TypeInfo on init and it must
be used on types that implement qemu_api::definitions::ObjectImpl trait.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS| 1 +
rust
Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and
provides some declaration macros for symbols visible to the rest of
QEMU.
Co-authored-by: Junjie Mao
Co-authored-by: Paolo Bonzini
Signed-off-by: Junjie Mao
Signed-off-by: Paolo Bonzini
Signed-off-by: Manos Pitsidianakis
From: Paolo Bonzini
This is needed for Rust support.
Signed-off-by: Paolo Bonzini
---
meson.build| 2 +-
python/scripts/vendor.py | 4 ++--
python/wheels/meson-1.2.3-py3-none-any.whl | Bin 964928 -> 0 bytes
python/wheels/meson-1.5.0-py3-no
Co-authored-by: Paolo Bonzini
Signed-off-by: Junjie Mao
Signed-off-by: Paolo Bonzini
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS| 5 +
meson.build| 24 +
hw/arm/Kconfig
Add rust feature in meson.build, configure, to prepare for adding Rust
code in the followup commits.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS | 5 +
meson.build | 25 -
Kconfig | 1 +
Kconfig.host
Set rust source code to diff=rust (built-in with new git versions)
and merge=binary for Cargo.lock files (they should not be merged but
auto-generated by cargo)
Reviewed-by: Alex Bennée
Reviewed-by: Zhao Liu
Signed-off-by: Manos Pitsidianakis
---
.gitattributes | 3 +++
1 file changed, 3
: Paolo Bonzini
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS| 4 +++
meson.build| 34 +++
rust/wrapper.h | 39 +
rust/.gitignore| 3 ++
rust/meson.build | 0
scripts/rust/rustc_args.py
Rust, chosen for
its low complexity. The device is used in the arm virt machine if qemu
is compiled with rust enabled (./configure --enable-rust [...])
Signed-off-by: Manos Pitsidianakis
---
Changes in v8:
- Allow for compilation of more than one Rust-based component in Meson
by compilin
From: Paolo Bonzini
Include the correct path and arguments to rustc in the native
and cross files (native compilation is needed for procedural
macros).
Signed-off-by: Paolo Bonzini
---
configure | 50 --
meson.build | 8 +++-
2 files chang
On Fri, 16 Aug 2024 11:34, Philippe Mathieu-Daudé wrote:
On 15/8/24 17:06, Daniel P. Berrangé wrote:
On Thu, Aug 15, 2024 at 04:01:17PM +0200, Philippe Mathieu-Daudé wrote:
Hi Manos,
On 15/8/24 13:42, Manos Pitsidianakis wrote:
Add rust/qemu-api, which exposes rust-bindgen generated FFI
On Fri, 16 Aug 2024, 11:06 Junjie Mao, wrote:
> On 8/15/2024 7:42 PM, Manos Pitsidianakis wrote:
> > Outstanding issues
> > ==
> >
> > Outstanding issues that are not blocking for merge are:
> >
> > - Cross-compilation for aarch64 is not po
On Thu, 15 Aug 2024 17:01, Philippe Mathieu-Daudé wrote:
Hi Manos,
On 15/8/24 13:42, Manos Pitsidianakis wrote:
Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and
provides some declaration macros for symbols visible to the rest of
QEMU.
Co-authored-by: Junjie Mao
Co
ts low complexity. The device is used in the arm virt machine if qemu
is compiled with rust enabled (./configure --enable-rust [...])
Signed-off-by: Manos Pitsidianakis
---
Manos Pitsidianakis (5):
build-sys: Add rust feature option
rust: add bindgen step as a meson dependency
: Paolo Bonzini
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS | 4 +++
meson.build | 52 +++
rust/wrapper.h| 39
rust/.gitignore | 3 ++
rust/meson.build | 0
scripts/rustc_args.py | 84
Set rust source code to diff=rust (built-in with new git versions)
and merge=binary for Cargo.lock files (they should not be merged but
auto-generated by cargo)
Reviewed-by: Alex Bennée
Reviewed-by: Zhao Liu
Signed-off-by: Manos Pitsidianakis
---
.gitattributes | 3 +++
1 file changed, 3
From: Paolo Bonzini
This is needed for Rust support.
Signed-off-by: Paolo Bonzini
---
meson.build| 2 +-
python/scripts/vendor.py | 4 ++--
python/wheels/meson-1.2.3-py3-none-any.whl | Bin 964928 -> 0 bytes
python/wheels/meson-1.5.0-py3-no
Add rust feature in meson.build, configure, to prepare for adding Rust
code in the followup commits.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS | 5 +
meson.build | 25 -
Kconfig | 1 +
Kconfig.host
From: Paolo Bonzini
Include the correct path and arguments to rustc in the native
and cross files (native compilation is needed for procedural
macros).
Signed-off-by: Paolo Bonzini
---
configure | 50 --
meson.build | 8 +++-
2 files chang
Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and
provides some declaration macros for symbols visible to the rest of
QEMU.
Co-authored-by: Junjie Mao
Co-authored-by: Paolo Bonzini
Signed-off-by: Junjie Mao
Signed-off-by: Paolo Bonzini
Signed-off-by: Manos Pitsidianakis
Co-authored-by: Paolo Bonzini
Signed-off-by: Junjie Mao
Signed-off-by: Paolo Bonzini
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS| 5 +
hw/arm/Kconfig | 33 +-
rust/Kconfig
On Wed, 14 Aug 2024 12:08, Junjie Mao wrote:
The official way to specify Rust edition in meson is the rust_std build option
[1]. It is used for generating --edition rustc options and filling
rust-project.json which provides project layout information to
rust-analyzer. Specifying Rust edition by
On Thu, 08 Aug 2024 09:10, Paolo Bonzini wrote:
On 8/4/24 23:04, Manos Pitsidianakis wrote:
Changes
===
- Setting MSRV to 1.77.0:
* cstr crate MSRV is 1.64, which is more recent than Debian bookworm
(1.63.0) <https://github.com/upsuper/cstr/blob/master/Cargo.toml>
* p
Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and
provides some declaration macros for symbols visible to the rest of
QEMU.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS | 6 ++
rust/meson.build | 13 +++
rust/qemu-api
Add rust feature in meson.build, configure, to prepare for adding Rust
code in the followup commits.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS | 5 +
configure | 2 ++
meson.build | 25 -
Kconfig
: Manos Pitsidianakis
---
MAINTAINERS | 4 +++
meson.build | 52 +++
rust/wrapper.h| 39
rust/.gitignore | 3 ++
rust/meson.build | 0
scripts/rustc_args.py | 84 +++
6
diff --git a/MAINTAINERS b/MAINTAINERS
index 018f3a9420..2b3d96fa2f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1188,6 +1188,11 @@ F: include/hw/*/microbit*.h
F: tests/qtest/microbit-test.c
F: docs/system/arm/nrf.rst
+ARM PL011 Rust device
+M: Manos Pitsidianakis
+S: Maintained
+F: rust/hw
ches.
- Dropped vendored dependencies in favor of meson subprojects.
- Added a qom ObjectImpl trait and declaration macros
- Added # SAFETY comments.
- Changed configure flag to --{enable,disable}-rust
Manos Pitsidianakis (5):
build-sys: Add rust feature option
rust: add bindgen step as a
Set rust source code to diff=rust (built-in with new git versions)
and merge=binary for Cargo.lock files (they should not be merged but
auto-generated by cargo)
Reviewed-by: Alex Bennée
Reviewed-by: Zhao Liu
Signed-off-by: Manos Pitsidianakis
---
.gitattributes | 3 +++
1 file changed, 3
On Fri, 02 Aug 2024 08:03, Volker Rümelin wrote:
Am 01.08.24 um 10:22 schrieb Michael S. Tsirkin:
On Sat, Jul 27, 2024 at 08:55:10AM +0200, Volker Rümelin wrote:
Hi Manos,
this patch doesn't work as intended. I guess you wanted to write
if (params->format >= sizeof(supported_formats
ot;);
return cpu_to_le32(VIRTIO_SND_S_NOT_SUPP);
--
2.35.3
Thanks for the fix Volker :)
Reviewed-by: Manos Pitsidianakis
On Fri, 26 Jul 2024 12:26, Manos Pitsidianakis
wrote:
On Fri, 26 Jul 2024 at 11:19, Paolo Bonzini wrote:
As I said, I don't see the point in discussing this more, and I'm not
going to unless you provide a clear pointer to documentation that
states the opposite.
Same here.
3],
+)
+args = parser.parse_args()
+
+if not os.path.isfile(args.input_file):
+sys.exit(f"[Error] {args.input_file} does not exist or is not a regular
file.")
+
+if args.refcount_bits != 16 and args.qcow2_version != 3:
+sys.exit(f"[Error] refcount_bits={args.refcount_bits} is only supported
with qcow2_version=3.")
+
+if sys.stdout.isatty():
+sys.exit("[Error] Refusing to write to a tty. Try redirecting stdout.")
+
+with get_input_as_raw_file(args.input_file, args.input_format) as raw_file:
+create_qcow2_file(
+raw_file,
+args.cluster_size,
+args.refcount_bits,
+args.qcow2_version,
+)
--
2.39.2
Reviewed-by: Manos Pitsidianakis
On Fri, 26 Jul 2024 at 11:19, Paolo Bonzini wrote:
> As I said, I don't see the point in discussing this more, and I'm not
> going to unless you provide a clear pointer to documentation that
> states the opposite.
Same here.
On Thu, 25 Jul 2024 18:15, Paolo Bonzini wrote:
On Thu, Jul 25, 2024 at 4:48 PM Manos Pitsidianakis
wrote:
> pl011_receive (called by qemu_chr_fe_accept_input) creates a mutable
> reference that *overlaps* the lifetime of the outer reference created
> by pl011_read. This is undefined
On Thu, 25 Jul 2024 at 14:19, Paolo Bonzini wrote:
>
> On Thu, Jul 25, 2024 at 12:14 PM Manos Pitsidianakis
> wrote:
> > >Unfortunately that's a *mut, not a &mut. A &mut must be unique, so the cast
> > >in pl011_read() is undefined behavior.
On Thu, 25 Jul 2024 12:56, Thomas Huth wrote:
On 25/07/2024 11.42, Manos Pitsidianakis wrote:
Hello Daniel,
On Wed, 24 Jul 2024 12:55, "Daniel P. Berrangé" wrote:
Many times we see a build job start failing, we wonder if the installed
packages have changed since the last passing
On Thu, 25 Jul 2024 12:50, Paolo Bonzini wrote:
Il gio 25 lug 2024, 08:19 Manos Pitsidianakis <
manos.pitsidiana...@linaro.org> ha scritto:
>(before the call to qemu_chr_fe_accept_input):
>// TODO: this causes a callback that creates another "&mut self".
>// This
Hello Daniel,
On Wed, 24 Jul 2024 12:55, "Daniel P. Berrangé" wrote:
Many times we see a build job start failing, we wonder if the installed
packages have changed since the last passing build. We can rarely
diagnose this, however, since we only have the new container image, not
the old one.
On Wed, 24 Jul 2024 13:34, Paolo Bonzini wrote:
On Wed, Jul 24, 2024 at 11:58 AM Manos Pitsidianakis
wrote:
>In my opinion we should start with cargo workspaces as the
>known-imperfect (but good enough) solution, so that it could be evolved
>later. It is important that any ch
Hello Paolo, thank you for the thorough response,
On Tue, 23 Jul 2024 18:07, Paolo Bonzini wrote:
On 7/22/24 13:43, Manos Pitsidianakis wrote:
Changes from v4->v5:
- Added CI patch from Alex Benee
- Removed all cargo use, use meson rust support
- Added Kconfig logic
The following reque
On Tue, 23 Jul 2024 13:11, "Daniel P. Berrangé" wrote:
On Tue, Jul 23, 2024 at 01:06:20PM +0300, Manos Pitsidianakis wrote:
On Tue, 23 Jul 2024 11:39, "Daniel P. Berrangé" wrote:
> On Mon, Jul 22, 2024 at 02:43:33PM +0300, Manos Pitsidianakis wrote:
> > Add job
On Tue, 23 Jul 2024 11:37, Zhao Liu wrote:
Hi Manos,
(This patch contains too many codes so that mail list rejects to display
it at https://lore.kernel.org/qemu-devel)
Please correct me if I'm wrong...
Is the reason for not using git submodules here because v5 abandoned
compilation through Ca
On Tue, 23 Jul 2024 09:37, Zhao Liu wrote:
Hi Manos,
On Mon, Jul 22, 2024 at 02:43:31PM +0300, Manos Pitsidianakis wrote:
Date: Mon, 22 Jul 2024 14:43:31 +0300
From: Manos Pitsidianakis
Subject: [RFC PATCH v5 1/8] build-sys: Add rust feature option
X-Mailer: git-send-email 2.44.0
Add rust
Hello Richard,
On Tue, 23 Jul 2024 11:31, Richard Henderson
wrote:
On 7/22/24 21:43, Manos Pitsidianakis wrote:
From: Alex Bennée
For rust development we need cargo, rustc and bindgen in our various
development environments. Update the libvirt-ci project to (!495) and
regenerate the
On Tue, 23 Jul 2024 11:39, "Daniel P. Berrangé" wrote:
On Mon, Jul 22, 2024 at 02:43:33PM +0300, Manos Pitsidianakis wrote:
Add job that builds with rust support enabled on debian.
Signed-off-by: Manos Pitsidianakis
---
.gitlab-ci.d/buildtest.yml | 11 +++
1 file c
/MAINTAINERS b/MAINTAINERS
index 1789bcfd9b..0af4ef58ed 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1187,6 +1187,11 @@ F: include/hw/*/microbit*.h
F: tests/qtest/microbit-test.c
F: docs/system/arm/nrf.rst
+ARM PL011 Rust device
+M: Manos Pitsidianakis
+S: Maintained
+F: rust/hw/char/pl011/
+
AVR
nnée (1):
build deps: update lcitool to include rust bits
Manos Pitsidianakis (7):
build-sys: Add rust feature option
CI: Add build-system-rust-debian job
rust: add bindgen step as a meson dependency
.gitattributes: add Rust diff and merge attributes
rust: add crate to expose bindings and
Mathieu-Daudé
Signed-off-by: Manos Pitsidianakis
---
.gitlab-ci.d/cirrus/freebsd-13.vars | 2 +-
.gitlab-ci.d/cirrus/macos-13.vars | 2 +-
.gitlab-ci.d/cirrus/macos-14.vars | 2 +-
scripts/ci/setup/ubuntu/ubuntu-2204-aarch64.yaml | 3
Set rust source code to diff=rust (built-in with new git versions)
and merge=binary for Cargo.lock files (they should not be merged but
auto-generated by cargo)
Reviewed-by: Alex Bennée
Signed-off-by: Manos Pitsidianakis
---
.gitattributes | 3 +++
1 file changed, 3 insertions(+)
diff --git a
: Manos Pitsidianakis
---
MAINTAINERS | 4 +++
meson.build | 56 +
rust/wrapper.h| 39
rust/.gitignore | 3 ++
rust/meson.build | 0
scripts/rustc_args.py | 84 +++
6
Add rust feature in meson.build, configure, to prepare for adding Rust
code in the followup commits.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS | 5 +
configure | 12
meson.build | 17 -
Kconfig
Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and
provides some declaration macros for symbols visible to the rest of
QEMU.
Signed-off-by: Manos Pitsidianakis
---
MAINTAINERS | 6 ++
rust/meson.build | 13 +++
rust/qemu-api
Add job that builds with rust support enabled on debian.
Signed-off-by: Manos Pitsidianakis
---
.gitlab-ci.d/buildtest.yml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index e3a0758bd9..e025e2cbf6 100644
--- a/.gitlab
Hi Daniel, Alex,
I will pick this patch up with all the reviewed-by trailers for my
next Rust RFC series if that's alright with you,
Manos
On Fri, 12 Jul 2024 at 13:12, Daniel P. Berrangé wrote:
>
> On Wed, Jul 10, 2024 at 04:43:35PM +0100, Alex Bennée wrote:
> > For rust development we need ca
On Fri, 12 Jul 2024 00:23, Pierrick Bouvier wrote:
On 7/9/24 06:00, Daniel P. Berrangé wrote:
On Tue, Jul 09, 2024 at 02:28:38PM +0200, Paolo Bonzini wrote:
On Tue, Jul 9, 2024 at 2:09 PM Peter Maydell wrote:
* what is the actual baseline requirement? We definitely want
to support "usi
bits in
supported_formats/supported_rates, we must report an error.
Previously, this ended up triggering the not reached assertions later
when converting to internal QEMU values.
Reported-by: Zheyu Ma
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2416
Signed-off-by: Manos Pitsidianakis
quot;mutex"))) mutex {};
> +void lock(struct mutex *m) __attribute__((acquire_capability(m)));
> +void unlock(struct mutex *m) __attribute__((release_capability(m)));
> +
> +void test(void) {
> + struct mutex __attribute__((cleanup(unlock))) m;
> + lock(&m);
> +}
> + ''', args: ['-Wthread-safety', '-Werror'])
> + if tsa_has_cleanup
> +warn_flags += ['-Wthread-safety']
> + endif
> endif
>
> # Set up C++ compiler flags
> --
> 2.45.2
>
Reviewed-by: Manos Pitsidianakis
--
Manos Pitsidianakis
Emulation and Virtualization Engineer at Linaro Ltd
Hey Zhao,
On Thu, 11 Jul 2024 at 07:05, Zhao Liu wrote:
>
> Hi Manos and all,
>
> On Tue, Jun 11, 2024 at 01:33:32PM +0300, Manos Pitsidianakis wrote:
> > diff --git a/rust/rustfmt.toml b/rust/rustfmt.toml
> > new file mode 100644
> > index 00..ebecb99fe0
&g
On Tue, 09 Jul 2024 17:16, Matias Ezequiel Vara Larsen
wrote:
Thanks Manos for sending this,
On Mon, Jul 08, 2024 at 10:09:49AM +0300, Manos Pitsidianakis wrote:
When reading input audio in the virtio-snd input callback,
virtio_snd_pcm_in_cb(), we do not check whether the iov can actually
On Mon, 8 Jul 2024 at 21:39, Manos Pitsidianakis
wrote:
>
>
>
> On Mon, 8 Jul 2024, 21:34 Paolo Bonzini, wrote:
>>
>>
>>
>> Il lun 8 lug 2024, 19:12 Daniel P. Berrangé ha scritto:
>>>
>>> That's exactly why I suggest its a pre-requi
1 - 100 of 757 matches
Mail list logo
