Re: [Qemu-devel] [PATCH v6] Add optionrom compatible with fw_cfg DMA version

2016-05-08 Thread Marc Marí
On Mon, 25 Apr 2016 17:04:41 +0100 "Richard W.M. Jones" <rjo...@redhat.com> wrote: > From: Marc Marí <mar...@redhat.com> > > This optionrom is based on linuxboot.S. > > Signed-off-by: Marc Marí <mar...@redhat.com> > Signed-off-by: Richard W.M.

Re: [Qemu-devel] [PATCH for-2.7 3/8] libqos: drop duplicated virtio_config.h definitions

2016-05-08 Thread Marc Marí
On Sun, 8 May 2016 20:22:53 +0200 Marc Marí <marc.mari.barc...@gmail.com> wrote: > On Mon, 25 Apr 2016 13:46:08 +0100 > Stefan Hajnoczi <stefa...@redhat.com> wrote: > > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > > --- > > tests/libqos/v

Re: [Qemu-devel] [PATCH for-2.7 3/8] libqos: drop duplicated virtio_config.h definitions

2016-05-08 Thread Marc Marí
On Mon, 25 Apr 2016 13:46:08 +0100 Stefan Hajnoczi wrote: > Signed-off-by: Stefan Hajnoczi > --- > tests/libqos/virtio.c | 19 ++- > tests/libqos/virtio.h | 9 - > tests/virtio-blk-test.c | 5 +++-- > 3 files changed, 13

Re: [Qemu-devel] [PATCH v5] Add optionrom compatible with fw_cfg DMA version

2016-04-24 Thread Marc Marí
On Fri, 22 Apr 2016 14:02:28 +0100 "Richard W.M. Jones" <rjo...@redhat.com> wrote: > From: Marc Marí <mar...@redhat.com> > > This optionrom is based on linuxboot.S. > > Signed-off-by: Marc Marí <mar...@redhat.com> > Signed-off-by: Richard W.M.

Re: [Qemu-devel] [PATCH v4.1] Add optionrom compatible with fw_cfg DMA version

2016-04-07 Thread Marc Marí
On Mon, 4 Apr 2016 16:02:04 +0100 Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Fri, Apr 01, 2016 at 01:43:47PM +0100, Richard W.M. Jones wrote: > > From: Marc Marí <mar...@redhat.com> > > > > This optionrom is based on linuxboot.S. > > > >

Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

2016-02-02 Thread Marc Marí
El Tue, 02 Feb 2016 13:04:55 +0100 Gerd Hoffmann escribió: > On Di, 2016-02-02 at 12:06 +0100, Gerd Hoffmann wrote: > > Hi, > > > > > %.img: %.o > > > - $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -Ttext 0 -e > > > _start -s -o $@ $<," Building $(TARGET_DIR)$@") > > > +

Re: [Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

2016-02-02 Thread Marc Marí
El Tue, 02 Feb 2016 12:06:27 +0100 Gerd Hoffmann escribió: > Hi, > > > %.img: %.o > > - $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -Ttext 0 -e > > _start -s -o $@ $<," Building $(TARGET_DIR)$@") > > + $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -m elf_i386 > > -Ttext

[Qemu-devel] [PATCH v4] Add optionrom compatible with fw_cfg DMA version

2016-01-29 Thread Marc Marí
on the configuration script. Signed-off-by: Marc Marí <mar...@redhat.com> --- .gitignore| 4 + hw/i386/pc.c | 9 +- hw/nvram/fw_cfg.c | 2 +- include/hw/nvram/fw_cfg.h | 1 + pc-bios/optionrom/Makefile| 7 +- p

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-28 Thread Marc Marí
> When I first tried to compile this (on fc23), I got: > > In file included from /usr/include/features.h:389:0, > from /usr/include/stdint.h:25, > from > /usr/lib/gcc/x86_64-redhat-linux/5.3.1/include/stdint.h:9, > from linuxboot_dma.c:62: >

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-28 Thread Marc Marí
On Wed, 27 Jan 2016 12:17:27 -0500 "Kevin O'Connor" <ke...@koconnor.net> wrote: > On Wed, Jan 27, 2016 at 05:57:28PM +0100, Marc Marí wrote: > > On Wed, 27 Jan 2016 16:43:29 + > > Stefan Hajnoczi <stefa...@redhat.com> wrote: > > > > > On

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-28 Thread Marc Marí
On Wed, 27 Jan 2016 19:14:54 -0500 "Kevin O'Connor" <ke...@koconnor.net> wrote: > On Mon, Jan 25, 2016 at 02:17:48PM +0100, Marc Marí wrote: > > This optionrom is based on linuxboot.S. > > Hi Marc, > > Out of curiousity, how does the timing with this

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-27 Thread Marc Marí
On Wed, 27 Jan 2016 16:43:29 + Stefan Hajnoczi <stefa...@redhat.com> wrote: > On Tue, Jan 26, 2016 at 12:26:12PM +0100, Gerd Hoffmann wrote: > > On Di, 2016-01-26 at 12:20 +0100, Marc Marí wrote: > > > On Tue, 26 Jan 2016 11:11:54 + > > > Stefan Haj

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-26 Thread Marc Marí
On Tue, 26 Jan 2016 11:11:54 + Stefan Hajnoczi <stefa...@redhat.com> wrote: > On Mon, Jan 25, 2016 at 02:17:48PM +0100, Marc Marí wrote: > > +linuxboot_dma.img: linuxboot_dma.o > > + $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -m elf_i386 > > -Ttext 0 -e _st

[Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-25 Thread Marc Marí
This optionrom is based on linuxboot.S. Signed-off-by: Marc Marí <mar...@redhat.com> --- .gitignore| 4 + hw/i386/pc.c | 9 +- hw/nvram/fw_cfg.c | 2 +- include/hw/nvram/fw_cfg.h | 1 + pc-bios/optionrom/Ma

[Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version

2016-01-18 Thread Marc Marí
This optionrom is based on linuxboot.S. Signed-off-by: Marc Marí <mar...@redhat.com> --- .gitignore| 4 + hw/i386/pc.c | 9 +- hw/nvram/fw_cfg.c | 2 +- include/hw/nvram/fw_cfg.h | 1 + pc-bios/optionrom/Ma

Re: [Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version

2016-01-18 Thread Marc Marí
On Mon, 18 Jan 2016 14:42:06 + Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Mon, Jan 18, 2016 at 10:59:00AM +0100, Marc Marí wrote: > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > > index 459260b..00339fa 100644 > > --- a/hw/i386/pc.c > > +++ b/hw/

[Qemu-devel] [PATCH] Add optionrom compatible with fw_cfg DMA version

2016-01-08 Thread Marc Marí
This optionrom is based on linuxboot.S. Signed-off-by: Marc Marí <mar...@redhat.com> --- .gitignore| 4 + hw/i386/pc.c | 9 +- hw/nvram/fw_cfg.c | 2 +- include/hw/nvram/fw_cfg.h | 1 + pc-bios/optionrom/Ma

Re: [Qemu-devel] [PATCH] Add optionrom compatible with fw_cfg DMA version

2016-01-08 Thread Marc Marí
On Fri, 8 Jan 2016 16:54:07 +0100 Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 08/01/2016 15:58, Marc Marí wrote: > > > > +static inline uint16_t readw_addr32(const void *addr) { > > +uint16_t val; > > +asm("addr32 movw %1, %0

[Qemu-devel] Bug with GDB from commit ca3e40e

2015-11-16 Thread Marc Marí
Hi I was trying to debug some stuff in the bootloader and the optionrom, and I found a bug with QEMU and GDB. In commit ca3e40e (a pull request from Michael), I get this: x86_64-softmmu/qemu-system-x86_64 --enable-kvm \ -kernel /boot/vmlinuz-4.1.7-200.fc22.x86_64 -s -S

Re: [Qemu-devel] Bug with GDB from commit ca3e40e

2015-11-16 Thread Marc Marí
On Mon, 16 Nov 2015 08:45:09 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Mon, Nov 16, 2015 at 02:04:41AM +0100, Marc Marí wrote: > > Hi > > > > I was trying to debug some stuff in the bootloader and the > > optionrom, and I found

Re: [Qemu-devel] [PATCH v5 0/5] add ACPI node for fw_cfg on pc and arm

2015-11-14 Thread Marc Marí
t; >>2.4 (as suggested by Eduardo) > >> > >>I appreciate any further comments and reviews. Hopefully we can make > >>this palatable for upstream, modulo the lingering concerns about > >>whether "QEMU0002" is ok to use as the value of _HID

Re: [Qemu-devel] fw_cfg DMA security

2015-10-23 Thread Marc Marí
On Fri, 23 Oct 2015 08:56:26 +0200 Gerd Hoffmann wrote: > Hi, > > > One complication I thought of was that it might be tricky to deal > > with the implications of allowing this DMA to specify any old > > address to fill with fw_cfg data. > > > > So, for example, since Red

Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline.

2015-10-19 Thread Marc Marí
On Mon, 19 Oct 2015 08:12:22 -0400 "Kevin O'Connor" wrote: > On Mon, Oct 19, 2015 at 01:02:41PM +0100, Peter Maydell wrote: > > On 19 October 2015 at 12:52, Kevin O'Connor > > wrote: > > > On Mon, Oct 19, 2015 at 12:12:34PM +0100, Peter Maydell wrote: > >

Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline.

2015-10-19 Thread Marc Marí
On Mon, 19 Oct 2015 17:17:12 +0200 Laszlo Ersek wrote: > On 10/19/15 13:12, Peter Maydell wrote: > > On 19 October 2015 at 10:17, Gerd Hoffmann > > wrote: > >> Hi, > >> > >> As promised last week I've picked up the fw_cfg patches which are > >> ready to

Re: [Qemu-devel] [PATCHv2] fw_cfg: Define a static signature to be returned on DMA port reads

2015-10-08 Thread Marc Marí
On Tue, 6 Oct 2015 10:29:25 -0400 "Kevin O'Connor" wrote: > On Tue, Oct 06, 2015 at 09:30:18AM +0200, Laszlo Ersek wrote: > > On 10/06/15 01:51, Kevin O'Connor wrote: > > > Return a static signature ("QEMU CFG") if the guest does a read > > > to the DMA address io register. >

Re: [Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface

2015-10-08 Thread Marc Marí
On Thu, 8 Oct 2015 10:07:34 +0100 Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Tue, Oct 06, 2015 at 03:53:33PM +0100, Peter Maydell wrote: > > On 6 October 2015 at 15:44, Stefan Hajnoczi <stefa...@gmail.com> > > wrote: > > > On Thu, Oct 01, 2015

[Qemu-devel] [PATCH v5 0/6] fw_cfg DMA interface

2015-10-08 Thread Marc Marí
Implement host-side of the FW CFG DMA interface both for x86 and ARM. Based on Gerd Hoffman's initial implementation. Gabriel L. Somlo (1): fw_cfg: document fw_cfg_modify_iXX() update functions Kevin O'Connor (1): fw_cfg: Define a static signature to be returned on DMA port reads Marc Marí

[Qemu-devel] [PATCH v5 3/6] Implement fw_cfg DMA interface

2015-10-08 Thread Marc Marí
Based on the specifications on docs/specs/fw_cfg.txt This interface is an addon. The old interface can still be used as usual. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> --- hw/arm/virt.c | 2 +- hw/nvram/fw_cfg.c

[Qemu-devel] [PATCH v5 2/6] fw_cfg DMA interface documentation

2015-10-08 Thread Marc Marí
Add fw_cfg DMA interface specification in the documentation. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Laszlo Ersek <ler...@redhat.com> --- docs/spe

[Qemu-devel] [cross-post] QEMU fw_cfg DMA interface

2015-10-08 Thread Marc Marí
Implementation of the FW CFG DMA interface. When running a Linux guest on top of QEMU, using the -kernel option and with fw_cfg DMA Linux boot support, this is the timing improvement for x86: Original QEMU and SeaBIOS QEMU startup time: .080 BIOS startup time: .060 Kernel setup time: .586 Total

[Qemu-devel] [PATCH v5 5/6] Enable fw_cfg DMA interface for x86

2015-10-08 Thread Marc Marí
Enable the fw_cfg DMA interface for all the x86 platforms. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> Reviewed-by: Laszlo Ersek <ler...@redhat.com> --- hw/i386/pc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) dif

[Qemu-devel] [PATCH v5 4/6] Enable fw_cfg DMA interface for ARM

2015-10-08 Thread Marc Marí
Enable the fw_cfg DMA interface for the ARM virt machine. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Laszlo Ersek <ler...@redhat.com> --- hw/arm/virt.c |

[Qemu-devel] [PATCH v5 6/6] fw_cfg: Define a static signature to be returned on DMA port reads

2015-10-08 Thread Marc Marí
From: Kevin O'Connor Return a static signature ("QEMU CFG") if the guest does a read to the DMA address io register. Signed-off-by: Kevin O'Connor Reviewed-by: Laszlo Ersek Reviewed-by: Stefan Hajnoczi ---

[Qemu-devel] [PATCH v5 1/6] fw_cfg: document fw_cfg_modify_iXX() update functions

2015-10-08 Thread Marc Marí
From: "Gabriel L. Somlo" Document the behavior of fw_cfg_modify_iXX() for leak-less updating of integer-type blobs. Currently only fw_cfg_modify_i16() is coded, but 32- and 64-bit versions may be added later if necessary.. Signed-off-by: Gabriel Somlo

Re: [Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface

2015-10-06 Thread Marc Marí
On Tue, 6 Oct 2015 15:44:53 +0100 Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Thu, Oct 01, 2015 at 02:16:55PM +0200, Marc Marí wrote: > > @@ -292,6 +307,119 @@ static void fw_cfg_data_mem_write(void > > *opaque, hwaddr addr, } while (i); > > } > > >

Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable

2015-10-02 Thread Marc Marí
On Fri, 02 Oct 2015 10:16:26 +0200 Gerd Hoffmann wrote: > Hi, > > > That's fine with me. Marc - I think qemu_vmlinux_setup() in SeaBIOS > > with the following would work: > > > > void qemu_vmlinux_setup(void) > > { > > u32 kernel_size; > >

[Qemu-devel] QEMU fw_cfg DMA interface

2015-10-01 Thread Marc Marí
Implementation of the FW CFG DMA interface. When running a Linux guest on top of QEMU, using the -kernel options, this is the timing improvement for x86: QEMU commit b2312c6 and SeaBIOS commit 423542e QEMU startup time: .080 BIOS startup time: .060 Kernel setup time: .586 Total time: .726 QEMU

Re: [Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface

2015-10-01 Thread Marc Marí
ck it > up and try to shepherd it further.) I'll continue with it, don't worry. Thanks for your comments. Marc > > On 10/01/15 14:16, Marc Marí wrote: > > Based on the specifications on docs/specs/fw_cfg.txt > > > > This interface is an addon. The old interface c

[Qemu-devel] [PATCH v4 4/7] Enable fw_cfg DMA interface for ARM

2015-10-01 Thread Marc Marí
Enable the fw_cfg DMA interface for the ARM virt machine. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> --- hw/arm/virt.c | 8 1 file changed, 4 insertions(+), 4 deleti

[Qemu-devel] [PATCH v4 0/7] fw_cfg DMA interface

2015-10-01 Thread Marc Marí
Implement host-side of the FW CFG DMA interface both for x86 and ARM. Based on Gerd Hoffman's initial implementation. Gabriel L. Somlo (1): fw_cfg: document fw_cfg_modify_iXX() update functions Kevin O'Connor (1): fw_cfg: Define a static signature to be returned on DMA port reads Marc Marí

[Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface

2015-10-01 Thread Marc Marí
Based on the specifications on docs/specs/fw_cfg.txt This interface is an addon. The old interface can still be used as usual. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> --- hw/arm/virt.c | 2 +- hw/nvram/fw_cfg.c

[Qemu-devel] [PATCH v4 2/7] fw_cfg DMA interface documentation

2015-10-01 Thread Marc Marí
Add fw_cfg DMA interface specification in the documentation. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> --- docs/specs/fw_cfg.txt | 65 ++

[Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable

2015-10-01 Thread Marc Marí
Add an entry to the bootorder file with name "vmlinux". Give this entry more priority than the romfile. Signed-off-by: Marc Marí <mar...@redhat.com> --- hw/i386/pc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 81d93b4

[Qemu-devel] [PATCH v4 7/7] fw_cfg: Define a static signature to be returned on DMA port reads

2015-10-01 Thread Marc Marí
From: Kevin O'Connor Return a static signature ("QEMU CFG") if the guest does a read to the DMA address io register. Signed-off-by: Kevin O'Connor --- docs/specs/fw_cfg.txt | 4 hw/nvram/fw_cfg.c | 13 +++-- 2 files changed, 15

[Qemu-devel] [PATCH v4 1/7] fw_cfg: document fw_cfg_modify_iXX() update functions

2015-10-01 Thread Marc Marí
From: "Gabriel L. Somlo" Document the behavior of fw_cfg_modify_iXX() for leak-less updating of integer-type blobs. Currently only fw_cfg_modify_i16() is coded, but 32- and 64-bit versions may be added later if necessary.. Signed-off-by: Gabriel Somlo

[Qemu-devel] [PATCH v4 5/7] Enable fw_cfg DMA interface for x86

2015-10-01 Thread Marc Marí
Enable the fw_cfg DMA interface for all the x86 platforms. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> --- hw/i386/pc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 461c128..8

Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg DMA interface bootable

2015-10-01 Thread Marc Marí
On Thu, 1 Oct 2015 12:02:42 -0400 "Kevin O'Connor" <ke...@koconnor.net> wrote: > On Thu, Oct 01, 2015 at 05:25:11PM +0200, Laszlo Ersek wrote: > > On 10/01/15 14:16, Marc Marí wrote: > > > Add an entry to the bootorder file with name "vmlinux". > >

Re: [Qemu-devel] [PATCH v2 0/2] Dynamic module support for block drivers

2015-09-21 Thread Marc Marí
Ping! Anyone has more comments for the next version? Thanks Marc >On Tue, 8 Sep 2015 15:53:20 +0200 >Marc Marí <mar...@redhat.com> wrote: > > The current module infrastructure has been improved to enable dynamic > module loading. > > This reduces the load

Re: [Qemu-devel] [PATCH v2 0/2] Dynamic module support for block drivers

2015-09-21 Thread Marc Marí
On Mon, 21 Sep 2015 16:43:27 +0300 "Denis V. Lunev" <den-li...@parallels.com> wrote: > On 09/08/2015 04:53 PM, Marc Marí wrote: > > The current module infrastructure has been improved to enable > > dynamic module loading. > > > > This r

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-19 Thread Marc Marí
On Sat, 19 Sep 2015 01:10:46 +0200 Laszlo Ersek <ler...@redhat.com> wrote: > On 09/18/15 22:24, Marc Marí wrote: > > On Fri, 18 Sep 2015 22:16:46 +0200 > > Laszlo Ersek <ler...@redhat.com> wrote: > > > >> On 09/18/15 10:58, Marc Marí wrote: > >>

[Qemu-devel] [PATCH v3 2/5] fw_cfg DMA interface documentation

2015-09-18 Thread Marc Marí
Add fw_cfg DMA interface specification in the documentation. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> --- docs/specs/fw_cfg.txt | 65 +++ 1 file changed, 61 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH v3 3/5] Implement fw_cfg DMA interface

2015-09-18 Thread Marc Marí
Based on the specifications on docs/specs/fw_cfg.txt This interface is an addon. The old interface can still be used as usual. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> --- hw/arm/virt.c | 2 +- hw/nvram/fw_cfg.c

[Qemu-devel] QEMU fw_cfg DMA interface

2015-09-18 Thread Marc Marí
Implementation of the FW CFG DMA interface. When running a Linux guest on top of QEMU, using the -kernel options, this is the timing improvement for x86: QEMU commit 16a1b6e and SeaBIOS commit e4d2b8c QEMU startup time: .080 BIOS startup time: .060 Kernel setup time: .586 Total time: .726 QEMU

[Qemu-devel] [PATCH v3 5/5] Enable fw_cfg DMA interface for x86

2015-09-18 Thread Marc Marí
Enable the fw_cfg DMA interface for all the x86 platforms. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> --- hw/i386/pc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 5

[Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Marc Marí
Enable the fw_cfg DMA interface for the ARM virt machine. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> --- hw/arm/virt.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 3

[Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface

2015-09-18 Thread Marc Marí
Implement host-side of the FW CFG DMA interface both for x86 and ARM. Based on Gerd Hoffman's initial implementation. Gabriel L. Somlo (1): fw_cfg: document fw_cfg_modify_iXX() update functions Marc Marí (4): fw_cfg DMA interface documentation Implement fw_cfg DMA interface Enable

[Qemu-devel] [PATCH v3 1/5] fw_cfg: document fw_cfg_modify_iXX() update functions

2015-09-18 Thread Marc Marí
From: "Gabriel L. Somlo" Document the behavior of fw_cfg_modify_iXX() for leak-less updating of integer-type blobs. Currently only fw_cfg_modify_i16() is coded, but 32- and 64-bit versions may be added later if necessary.. Signed-off-by: Gabriel Somlo

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Marc Marí
On Fri, 18 Sep 2015 22:16:46 +0200 Laszlo Ersek <ler...@redhat.com> wrote: > On 09/18/15 10:58, Marc Marí wrote: > > Enable the fw_cfg DMA interface for the ARM virt machine. > > > > Based on Gerd Hoffman's initial implementation. > > > > Sign

Re: [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface

2015-09-18 Thread Marc Marí
On Fri, 18 Sep 2015 14:25:09 -0400 "Kevin O'Connor" <ke...@koconnor.net> wrote: > On Fri, Sep 18, 2015 at 10:58:44AM +0200, Marc Marí wrote: > > Implement host-side of the FW CFG DMA interface both for x86 and > > ARM. > > > > Based on Gerd Ho

Re: [Qemu-devel] [RFC PATCH 1/3] pc: fw_cfg: move ioport base constant to pc.h

2015-09-13 Thread Marc Marí
On Sat, 12 Sep 2015 19:30:40 -0400 "Gabriel L. Somlo" wrote: > Move BIOS_CFG_IOPORT define from pc.c to pc.h, and rename > it to FW_CFG_IO_BASE. Also, add FW_CFG_IO_SIZE define (set > to 0x02, to cover the overlapping 16-bit control and 8-bit > data ports). > > Signed-off-by:

Re: [Qemu-devel] [RFC PATCH 1/3] pc: fw_cfg: move ioport base constant to pc.h

2015-09-13 Thread Marc Marí
On Sun, 13 Sep 2015 13:28:24 -0400 "Gabriel L. Somlo" <so...@cmu.edu> wrote: > On Sun, Sep 13, 2015 at 12:51:53PM +0200, Marc Marí wrote: > > On Sat, 12 Sep 2015 19:30:40 -0400 > > "Gabriel L. Somlo" <so...@cmu.edu> wrote: > > > >

Re: [Qemu-devel] [PATCH v2 2/2] Add dynamic generation of module_block.h

2015-09-09 Thread Marc Marí
On Wed, 9 Sep 2015 10:27:13 +0800 Fam Zheng <f...@redhat.com> wrote: > On Tue, 09/08 15:53, Marc Marí wrote: > > diff --git a/include/qemu/module_block.h > > b/include/qemu/module_block.h deleted file mode 100644 > > index d725db8..000 > > --- a/include/qemu

[Qemu-devel] [PATCH v2 2/2] Add dynamic generation of module_block.h

2015-09-08 Thread Marc Marí
To simplify the addition of new block modules, add a script that generates include/qemu/module_block.h automatically from the modules' source code. This script assumes that the QEMU coding style rules are followed. Signed-off-by: Marc Marí <mar...@redhat.com> --- .git

[Qemu-devel] [PATCH v2 0/2] Dynamic module support for block drivers

2015-09-08 Thread Marc Marí
more modules (block or not block) should be easy, and will reduce the load time even more. Marc Marí (2): Add dynamic module loading for block drivers Add dynamic generation of module_block.h .gitignore | 1 + Makefile| 10 ++- block.c

[Qemu-devel] [PATCH v2 1/2] Add dynamic module loading for block drivers

2015-09-08 Thread Marc Marí
. All the necessary module information is located in a new structure found in include/qemu/module_block.h Signed-off-by: Marc Marí <mar...@redhat.com> --- block.c | 70 +++ configure | 2 +- include/qemu/module.h

Re: [Qemu-devel] [PATCH 0/2] Dynamic module support for block drivers

2015-09-03 Thread Marc Marí
On Thu, 3 Sep 2015 17:12:29 +0100 Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Mon, Aug 17, 2015 at 10:09:33AM +0200, Marc Marí wrote: > > The current module infrastructure has been improved to enable > > dynamic module loading. > > > > This reduces the

Re: [Qemu-devel] [PATCH 1/2] Add dynamic module loading for block drivers

2015-09-03 Thread Marc Marí
On Thu, 3 Sep 2015 17:33:16 +0100 Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Mon, Aug 17, 2015 at 10:09:34AM +0200, Marc Marí wrote: > > +static const struct { > > +const char *format_name; > > +const char *protocol_name; > > +const char *libr

[Qemu-devel] [PATCH v2 4/5] Enable fw_cfg DMA interface for ARM

2015-08-31 Thread Marc Marí
Enable the fw_cfg DMA interface for the ARM virt machine. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> --- hw/arm/virt.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index b

[Qemu-devel] [PATCH v2 0/5] fw_cfg DMA interface

2015-08-31 Thread Marc Marí
Implement host-side of the FW CFG DMA interface both for x86 and ARM. Based on Gerd Hoffman's initial implementation. Gabriel L. Somlo (1): fw_cfg: document fw_cfg_modify_iXX() update functions Marc Marí (4): fw_cfg DMA interface documentation Implement fw_cfg DMA interface Enable

[Qemu-devel] [PATCH v2 1/5] fw_cfg: document fw_cfg_modify_iXX() update functions

2015-08-31 Thread Marc Marí
From: "Gabriel L. Somlo" Document the behavior of fw_cfg_modify_iXX() for leak-less updating of integer-type blobs. Currently only fw_cfg_modify_i16() is coded, but 32- and 64-bit versions may be added later if necessary.. Signed-off-by: Gabriel Somlo

[Qemu-devel] QEMU fw_cfg DMA interface

2015-08-31 Thread Marc Marí
Implementation of the FW CFG DMA interface. When running a Linux guest on top of QEMU, using the -kernel options, this is the timing improvement for x86: QEMU commit 090d0bf and SeaBIOS commit 2fc20dc QEMU startup time: .078 BIOS startup time: .060 Kernel setup time: .578 Total time: .716 QEMU

[Qemu-devel] [PATCH v2 3/5] Implement fw_cfg DMA interface

2015-08-31 Thread Marc Marí
Based on the specifications on docs/specs/fw_cfg.txt This interface is an addon. The old interface can still be used as usual. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> --- hw/arm/virt.c | 2 +- hw/nvram/fw_cfg.c

[Qemu-devel] [PATCH v2 5/5] Enable fw_cfg DMA interface for x86

2015-08-31 Thread Marc Marí
Enable the fw_cfg DMA interface for all the x86 platforms. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> --- hw/i386/pc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 9

[Qemu-devel] [PATCH v2 2/5] fw_cfg DMA interface documentation

2015-08-31 Thread Marc Marí
Add fw_cfg DMA interface specification in the documentation. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí <mar...@redhat.com> --- docs/specs/fw_cfg.txt | 68 --- 1 file changed, 64 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH 2/2] Add dynamic generation of module_block.h

2015-08-27 Thread Marc Marí
On Thu, 27 Aug 2015 10:23:32 +0100 Daniel P. Berrange berra...@redhat.com wrote: On Mon, Aug 17, 2015 at 10:09:35AM +0200, Marc Marí wrote: To simplify the addition of new block modules, add a script that generates include/qemu/module_block.h automatically from the modules' source code

Re: [Qemu-devel] [PATCH 1/2] Add dynamic module loading for block drivers

2015-08-27 Thread Marc Marí
On Thu, 27 Aug 2015 10:19:35 +0100 Daniel P. Berrange berra...@redhat.com wrote: On Mon, Aug 17, 2015 at 10:09:34AM +0200, Marc Marí wrote: Extend the current module interface to allow for block drivers to be loaded dynamically on request. The only block drivers that can be converted

Re: [Qemu-devel] [PATCH 0/2] Dynamic module support for block drivers

2015-08-27 Thread Marc Marí
Ping On Mon, 17 Aug 2015 10:09:33 +0200 Marc Marí mar...@redhat.com wrote: The current module infrastructure has been improved to enable dynamic module loading. This reduces the load time for very simple guests. For the following configuration (very loaded) ./configure --enable-sdl

[Qemu-devel] [PATCH 1/2] Add dynamic module loading for block drivers

2015-08-17 Thread Marc Marí
. All the necessary module information is located in a new structure found in include/qemu/module_block.h Signed-off-by: Marc Marí mar...@redhat.com --- block.c | 73 +++-- configure | 2 +- include/qemu/module.h | 3

[Qemu-devel] [PATCH 0/2] Dynamic module support for block drivers

2015-08-17 Thread Marc Marí
more modules (block or not block) should be easy, and will reduce the load time even more. Marc Marí (2): Add dynamic module loading for block drivers Add dynamic generation of module_block.h .gitignore | 1 + Makefile| 10 ++- block.c

[Qemu-devel] [PATCH 2/2] Add dynamic generation of module_block.h

2015-08-17 Thread Marc Marí
To simplify the addition of new block modules, add a script that generates include/qemu/module_block.h automatically from the modules' source code. This script assumes that the QEMU coding style rules are followed. Signed-off-by: Marc Marí mar...@redhat.com --- .gitignore

Re: [Qemu-devel] [PATCH 3/5] Implement fw_cfg DMA interface

2015-08-07 Thread Marc Marí
On Thu, 6 Aug 2015 23:32:50 +0200 Laszlo Ersek ler...@redhat.com wrote: On 08/06/15 23:11, Marc Marí wrote: On Thu, 6 Aug 2015 22:49:12 +0200 Laszlo Ersek ler...@redhat.com wrote: [...] +static void fw_cfg_dma_mem_write(void *opaque, hwaddr addr

Re: [Qemu-devel] [PATCH 2/5] fw_cfg DMA interface documentation

2015-08-07 Thread Marc Marí
On Thu, 6 Aug 2015 10:20:38 -0400 Kevin O'Connor ke...@koconnor.net wrote: On Thu, Aug 06, 2015 at 01:01:15PM +0200, Marc Marí wrote: Add fw_cfg DMA interface specification in the documentation. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí mar

Re: [Qemu-devel] [PATCH 3/5] Implement fw_cfg DMA interface

2015-08-06 Thread Marc Marí
On Thu, 6 Aug 2015 10:47:21 -0400 Kevin O'Connor ke...@koconnor.net wrote: On Thu, Aug 06, 2015 at 01:01:16PM +0200, Marc Marí wrote: Based on the specifications on docs/specs/fw_cfg.txt This interface is an addon. The old interface can still be used as usual. For x86 arch

Re: [Qemu-devel] QEMU fw_cfg DMA interface

2015-08-06 Thread Marc Marí
On Thu, 6 Aug 2015 11:30:43 -0400 Kevin O'Connor ke...@koconnor.net wrote: On Thu, Aug 06, 2015 at 02:37:45PM +0200, Marc Marí wrote: On Thu, 6 Aug 2015 13:27:16 +0100 Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Aug 6, 2015 at 12:00 PM, Marc Marí mar...@redhat.com wrote

Re: [Qemu-devel] [PATCH 3/5] Implement fw_cfg DMA interface

2015-08-06 Thread Marc Marí
On Thu, 6 Aug 2015 22:49:12 +0200 Laszlo Ersek ler...@redhat.com wrote: [...] +static void fw_cfg_dma_mem_write(void *opaque, hwaddr addr, + uint64_t value, unsigned size) +{ +FWCfgState *s = opaque; + +s-dma_addr = be64_to_cpu(value); +

[Qemu-devel] QEMU fw_cfg DMA interface

2015-08-06 Thread Marc Marí
Implementation of the FW CFG DMA interface. When running a Linux guest on top of QEMU, using the -kernel options, this is the timing improvement for x86: QEMU commit 2be4f242b50a8 and SeaBIOS commit 908a58c1d5ff QEMU startup time: .078 BIOS startup time: .060 Kernel setup time: .578 Total time:

[Qemu-devel] [PATCH 5/5] Enable fw_cfg DMA interface for x86

2015-08-06 Thread Marc Marí
Enable the fw_cfg DMA interface for all the x86 platforms. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí mar...@redhat.com --- hw/i386/pc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 7661ea9

[Qemu-devel] [PATCH 3/5] Implement fw_cfg DMA interface

2015-08-06 Thread Marc Marí
implementation. Signed-off-by: Marc Marí mar...@redhat.com --- hw/arm/virt.c | 2 +- hw/nvram/fw_cfg.c | 212 +++--- include/hw/nvram/fw_cfg.h | 12 ++- 3 files changed, 211 insertions(+), 15 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm

[Qemu-devel] [PATCH 4/5] Enable fw_cfg DMA interface for ARM

2015-08-06 Thread Marc Marí
Enable the fw_cfg DMA interface for the ARM virt machine. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí mar...@redhat.com --- hw/arm/virt.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 374660c

[Qemu-devel] [PATCH 0/5] fw_cfg DMA interface

2015-08-06 Thread Marc Marí
Implement host-side of the FW CFG DMA interface both for x86 and ARM. Based on Gerd Hoffman's initial implementation. Gabriel L. Somlo (1): fw_cfg: document fw_cfg_modify_iXX() update functions Marc Marí (4): fw_cfg DMA interface documentation Implement fw_cfg DMA interface Enable

[Qemu-devel] [PATCH 1/5] fw_cfg: document fw_cfg_modify_iXX() update functions

2015-08-06 Thread Marc Marí
From: Gabriel L. Somlo so...@cmu.edu Document the behavior of fw_cfg_modify_iXX() for leak-less updating of integer-type blobs. Currently only fw_cfg_modify_i16() is coded, but 32- and 64-bit versions may be added later if necessary.. Signed-off-by: Gabriel Somlo so...@cmu.edu Signed-off-by:

[Qemu-devel] [PATCH 2/5] fw_cfg DMA interface documentation

2015-08-06 Thread Marc Marí
Add fw_cfg DMA interface specification in the documentation. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí mar...@redhat.com --- docs/specs/fw_cfg.txt | 42 -- 1 file changed, 40 insertions(+), 2 deletions(-) diff --git a/docs

Re: [Qemu-devel] QEMU fw_cfg DMA interface

2015-08-06 Thread Marc Marí
On Thu, 6 Aug 2015 13:27:16 +0100 Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Aug 6, 2015 at 12:00 PM, Marc Marí mar...@redhat.com wrote: When running a Linux guest on top of QEMU, using the -kernel options, this is the timing improvement for x86: QEMU commit 2be4f242b50a8

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Marc Marí
On Mon, 03 Aug 2015 10:24:56 +0100 Alex Bennée alex.ben...@linaro.org wrote: Marc Marí mar...@redhat.com writes: On Mon, 3 Aug 2015 16:22:34 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 08/03 09:52, Marc Marí wrote: So any other ideas to reduce the library overhead

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Marc Marí
On Mon, 3 Aug 2015 17:24:57 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 08/03 11:01, Marc Marí wrote: Some profiling: A QEMU with this configuration: ./configure --enable-sparse --enable-sdl --enable-gtk --enable-vte \ --enable-curses --enable-vnc --enable-vnc-{jpeg,tls,sasl,png

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Marc Marí
On Mon, 3 Aug 2015 10:23:37 +0100 Daniel P. Berrange berra...@redhat.com wrote: On Fri, Jul 31, 2015 at 05:45:42PM +0200, Marc Marí wrote: Hi everyone I propose improving the current modular driver system for QEMU so it can benefit everybody in speed and flexibility. I'm looking

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Marc Marí
On Mon, 3 Aug 2015 11:09:06 +0800 Fam Zheng f...@redhat.com wrote: On Fri, 07/31 17:45, Marc Marí wrote: Hi everyone I propose improving the current modular driver system for QEMU so it can benefit everybody in speed and flexibility. I'm looking for other ideas, comments, critics, etc

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Marc Marí
On Mon, 3 Aug 2015 16:22:34 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 08/03 09:52, Marc Marí wrote: So any other ideas to reduce the library overhead are appreciated. It would be interesting to see your profiling on the library loading overhead. For example, how much does it help

[Qemu-devel] Modularizing QEMU RFC

2015-07-31 Thread Marc Marí
Hi everyone I propose improving the current modular driver system for QEMU so it can benefit everybody in speed and flexibility. I'm looking for other ideas, comments, critics, etc. - Background - In order to speed up QEMU, I'm looking at the high number of libraries and dependencies that it

Re: [Qemu-devel] [RFC 2/7] fw_cfg dma interface

2015-07-23 Thread Marc Marí
On Thu, 23 Jul 2015 15:45:25 +0200 Laszlo Ersek ler...@redhat.com wrote: On 07/23/15 15:35, Peter Maydell wrote: On 23 July 2015 at 14:13, Laszlo Ersek ler...@redhat.com wrote: On 07/22/15 19:18, Kevin O'Connor wrote: Another possibility would be to place the new fw_cfg dma register

  1   2   3   4   >