Re: [PULL 0/9] pc,virtio: fixes

2022-08-17 Thread Michael S. Tsirkin
On Wed, Aug 17, 2022 at 12:12:03PM -0400, Michael S. Tsirkin wrote: > The following changes since commit c7208a6e0d049f9e8af15df908168a79b1f99685: > > Update version for v7.1.0-rc3 release (2022-08-16 20:45:19 -0500) > > are available in the Git repository at: > > git

[PULL 08/10] hw/cxl: Correctly handle variable sized mailbox input payloads.

2022-08-17 Thread Michael S. Tsirkin
basic mailbox (8.2.8.4)") Signed-off-by: Jonathan Cameron Message-Id: <20220817145759.32603-4-jonathan.came...@huawei.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/cxl/cxl-mailbox-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw

[PULL 02/10] hw/virtio: gracefully handle unset vhost_dev vdev

2022-08-17 Thread Michael S. Tsirkin
viewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 0827d631c0..f758f177bb 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -306,7

[PULL 06/10] hw/cxl: Add stub write function for RO MemoryRegionOps entries.

2022-08-17 Thread Michael S. Tsirkin
ement the CAP array (8.2.8.1-2)") Reported-by: Bobo WL Signed-off-by: Jonathan Cameron Message-Id: <20220817145759.32603-2-jonathan.came...@huawei.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/cxl/cxl-device-utils.c | 12 +--- 1 file changed, 9

[PULL 05/10] x86: disable rng seeding via setup_data

2022-08-17 Thread Michael S. Tsirkin
From: Gerd Hoffmann Causes regressions when doing direct kernel boots with OVMF. At this point in the release cycle the only sensible action is to just disable this for 7.1 and sort it properly in the 7.2 devel cycle. Cc: Jason A. Donenfeld Cc: Marcel Apfelbaum Cc: Paolo Bonzini Cc: Richard

[PULL 01/10] virtio-scsi: fix race in virtio_scsi_dataplane_start()

2022-08-17 Thread Michael S. Tsirkin
i?id=2099541 Reported-by: Qing Wang Signed-off-by: Stefan Hajnoczi Message-Id: <20220808162134.240405-1-stefa...@redhat.com> Reviewed-by: Emanuele Giuseppe Esposito Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/block/dataplane/virtio-blk.c | 5 + h

[PULL 09/10] tests: acpi: silence applesmc warning about invalid key

2022-08-17 Thread Michael S. Tsirkin
com> Reviewed-by: Daniel P. Berrangé Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 359916c228..7c5f

[PULL 10/10] virtio-pci: don't touch pci on virtio reset

2022-08-17 Thread Michael S. Tsirkin
;) Fixes: c2cabb3422 ("hw/virtio: fix error enabling flags in Device Control register") Cc: "Marcel Apfelbaum" Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio-pci.c b

[PULL 07/10] hw/cxl: Fix Get LSA input payload size which should be 8 bytes.

2022-08-17 Thread Michael S. Tsirkin
com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/cxl/cxl-mailbox-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c index bb66c765a5..3cea8b17a8 100644 --- a/hw/cxl/cxl-mailbox-utils.c

[PULL 00/10] pc,virtio: fixes

2022-08-17 Thread Michael S. Tsirkin
to a proper fix. Signed-off-by: Michael S. Tsirkin Alex Bennée (3): hw/virtio: gracefully handle unset vhost_dev vdev hw/virtio: handle un-configured shutdown in virtio-pci hw/virtio: fix vhost_user_read tracepoint Gerd

[PULL 04/10] hw/virtio: fix vhost_user_read tracepoint

2022-08-17 Thread Michael S. Tsirkin
Message-Id: <20220728135503.1060062-5-alex.ben...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 75b8

[PULL 03/10] hw/virtio: handle un-configured shutdown in virtio-pci

2022-08-17 Thread Michael S. Tsirkin
: <20220728135503.1060062-4-alex.ben...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 45327f0b31..5ce61f9b45 100644 --

[PATCH v2] virtio-pci: don't touch pci on virtio reset

2022-08-17 Thread Michael S. Tsirkin
;) Fixes: c2cabb3422 ("hw/virtio: fix error enabling flags in Device Control register") Cc: "Marcel Apfelbaum" Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio-pci.c b

Re: [PATCH v2 2/4] hw/virtio: gracefully handle unset vhost_dev vdev

2022-08-17 Thread Michael S. Tsirkin
On Thu, Jul 28, 2022 at 02:55:01PM +0100, Alex Bennée wrote: > I've noticed asserts firing because we query the status of vdev after > a vhost connection is closed down. Rather than faulting on the NULL > indirect just quietly reply false. > > Signed-off-by: Alex Bennée > Message-Id:

Re: [PATCH v2 1/4] hw/virtio: incorporate backend features in features

2022-08-17 Thread Michael S. Tsirkin
On Thu, Jul 28, 2022 at 02:55:00PM +0100, Alex Bennée wrote: > There are some extra bits used over a vhost-user connection which are > hidden from the device itself. We need to set them here to ensure we > enable things like the protocol extensions. > > Currently net/vhost-user.c has it's own

Re: [PATCH] hw/intc: Handle software disabling of APIC correctly

2022-08-17 Thread Michael S. Tsirkin
On Fri, Jul 29, 2022 at 11:04:47PM +0530, Jay Khandkar wrote: > On Fri, Jul 29, 2022 at 06:09:01PM +0100, Peter Maydell wrote: > > On Tue, 12 Jul 2022 at 19:38, Jay Khandkar > > wrote: > > > > > > When the local APIC is in a software disabled state, all local interrupt > > > sources must be

Re: [PATCH 2/2] pci: Sanity check mask argument to pci_set_*_by_mask()

2022-08-17 Thread Michael S. Tsirkin
On Wed, Jul 27, 2022 at 11:26:15AM +0100, Peter Maydell wrote: > On Tue, 26 Jul 2022 at 23:30, Richard Henderson > wrote: > > > > On 7/26/22 09:32, Peter Maydell wrote: > > > Coverity complains that in functions like pci_set_word_by_mask() > > > we might end up shifting by more than 31 bits. This

Re: [PATCH] x86: disable rng seeding via setup_data

2022-08-17 Thread Michael S. Tsirkin
> > Cc: Jason A. Donenfeld > Cc: Marcel Apfelbaum > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Cc: Peter Maydell > Cc: Philippe Mathieu-Daudé > Cc: Laurent Vivier > Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Will queue ASAP.

Re: [PATCH v2] xio3130_upstream: Add ACS (Access Control Services) capability

2022-08-16 Thread Michael S. Tsirkin
On Tue, Aug 16, 2022 at 05:16:38PM +0800, Paul Schlacter wrote: > v1 -> v2: > - Allow ACS to be disabled. > - Suggested by Michael S. Tsirkin, use disable-acs to set property. > > v1: > - Add ACS (Access Control Services) capability. changelog generally after --- >

Re: [PATCH 00/24] Support VIRTIO_F_RING_RESET for virtio-net, vhost-user, vhost-kernel in virtio pci-modern

2022-08-16 Thread Michael S. Tsirkin
On Tue, Aug 16, 2022 at 02:15:57PM +0800, Xuan Zhuo wrote: > On Tue, 16 Aug 2022 02:14:10 -0400, "Michael S. Tsirkin" > wrote: > > On Tue, Aug 16, 2022 at 09:06:12AM +0800, Kangjie Xu wrote: > > > The virtio queue reset function has already been define

Re: [PATCH 00/24] Support VIRTIO_F_RING_RESET for virtio-net, vhost-user, vhost-kernel in virtio pci-modern

2022-08-16 Thread Michael S. Tsirkin
On Tue, Aug 16, 2022 at 09:06:12AM +0800, Kangjie Xu wrote: > The virtio queue reset function has already been defined in the virtio spec > 1.2. > The relevant virtio spec information is here: > > https://github.com/oasis-tcs/virtio-spec/issues/124 >

Re: [PATCH] xio3130_upstream: Add ACS (Access Control Services) capability

2022-08-14 Thread Michael S. Tsirkin
On Sun, Aug 14, 2022 at 11:59:51PM +0800, Paul Schlacter wrote: > What's wrong with not disabling the old version? Old versions have to behave in the same way as they did, or close enough. Changing that breaks migration between qemu versions. > > > On Sun, Aug 14, 2022 at 6:48

Re: [PATCH] xio3130_upstream: Add ACS (Access Control Services) capability

2022-08-14 Thread Michael S. Tsirkin
On Sun, Aug 14, 2022 at 03:47:49PM +0800, Paul Schlacter wrote: > If it is a pcie device, check that all devices on the path from > > the device to the root complex have ACS enabled, and then the > > device will become an iommu_group. > > it will have the effect of isolation > > >

Re: [PATCH v2] hw/smbios: support for type 8 (port connector)

2022-08-12 Thread Michael S. Tsirkin
On Fri, Aug 12, 2022 at 03:51:53PM +0200, Hal Martin wrote: > PATCH v1: add support for SMBIOS type 8 to qemu > PATCH v2: incorporate patch v1 feedback and add smbios type=8 to qemu-options history after --- pls > internal_reference: internal reference designator > external_reference: external

Re: [PATCH v2 0/5] hw/smbios: add core_count2 to smbios table type 4

2022-08-12 Thread Michael S. Tsirkin
On Sun, Jul 31, 2022 at 06:21:36PM +0200, Julia Suvorova wrote: > The SMBIOS 3.0 specification provides the ability to reflect over > 255 cores. The 64-bit entry point has been used for a while, but > structure type 4 has not been updated before, so the dmidecode output > looked like this (-smp

Re: [PATCH v3] pc: hide linuxboot RNG seed behind a machine property

2022-08-10 Thread Michael S. Tsirkin
On Wed, Aug 10, 2022 at 09:25:05PM +0200, Paolo Bonzini wrote: > > > Il mer 10 ago 2022, 19:06 Michael S. Tsirkin ha scritto: > > > @@ -1387,6 +1405,7 @@ static void x86_machine_initfn(Object *obj) > >      x86ms->acpi = ON_OFF_AUTO_AUTO; > > 

Re: [PATCH v3] pc: hide linuxboot RNG seed behind a machine property

2022-08-10 Thread Michael S. Tsirkin
led by default, the > "x-" can be removed. > > Using a property has other advantages in general: it makes it possible > to use the normal compat property mechanism instead of ad hoc code, and > it avoids parameter proliferation in x86_load_linux. > > Cc: Michael S. Tsirki

Re: [PATCH v3] hw/i386: place setup_data at fixed place in memory

2022-08-09 Thread Michael S. Tsirkin
On Tue, Aug 09, 2022 at 02:17:23PM +0200, Jason A. Donenfeld wrote: > Hey Paolo, > > On Fri, Aug 05, 2022 at 02:47:27PM +0200, Jason A. Donenfeld wrote: > > Hi Paolo, > > > > On Fri, Aug 05, 2022 at 10:10:02AM +0200, Paolo Bonzini wrote: > > > On 8/5/22 01:04, Jason A. Donenfeld wrote: > > > > +

Re: [PATCH for-7.1] tests: acpi: silence applesmc warning about invalid key

2022-08-09 Thread Michael S. Tsirkin
On Tue, Aug 09, 2022 at 01:40:24PM +0200, Igor Mammedov wrote: > On Thu, 28 Jul 2022 09:37:13 -0400 > Igor Mammedov wrote: > > > OSK value is irrelevant for ACPI test case. > > Supply fake OSK explicitly to prevent QEMU complaining about > > invalid key when it fallbacks to default_osk. > > > >

Re: [PATCH v3] hw/i386: place setup_data at fixed place in memory

2022-08-09 Thread Michael S. Tsirkin
On Fri, Aug 05, 2022 at 07:29:29PM +0200, Paolo Bonzini wrote: > On 8/5/22 13:08, Ard Biesheuvel wrote: > > > > > > Does it work to place setup_data at the end of the cmdline file instead > > > of having it at the end of the kernel file? This way the first item > > > will be at 0x2 +

Re: [PATCH v2] virtio-scsi: fix race in virtio_scsi_dataplane_start()

2022-08-08 Thread Michael S. Tsirkin
s and cleared after detaching > host notifiers. In other words, the IOThread always sees the value true > and the main loop thread does not modify it while the IOThread is > active. > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2099541 > Reported-by: Qing Wang > Si

Re: [PATCH 0/1] Update vfio-user module to the latest

2022-08-05 Thread Michael S. Tsirkin
On Fri, Aug 05, 2022 at 09:24:56AM +0100, Daniel P. Berrangé wrote: > On Fri, Aug 05, 2022 at 09:21:07AM +0200, Thomas Huth wrote: > > On 02/08/2022 12.00, Zhang, Chen wrote: > > > > > > > > > > -Original Message- > > > > From: Qemu-devel > > > bounces+chen.zhang=intel@nongnu.org>

Re: [PATCH 0/1] Update vfio-user module to the latest

2022-08-05 Thread Michael S. Tsirkin
On Fri, Aug 05, 2022 at 09:21:07AM +0200, Thomas Huth wrote: > On 02/08/2022 12.00, Zhang, Chen wrote: > > > > > > > -Original Message- > > > From: Qemu-devel > > bounces+chen.zhang=intel@nongnu.org> On Behalf Of Jagannathan > > > Raman > > > Sent: Tuesday, August 2, 2022 9:24 AM >

Re: [PATCH v2] pc: add property for Linux setup_data random number seed

2022-08-05 Thread Michael S. Tsirkin
On Fri, Aug 05, 2022 at 10:16:37AM +0200, Paolo Bonzini wrote: > On 8/5/22 09:01, Michael S. Tsirkin wrote: > > > -if (!legacy_no_rng_seed) { > > > +if (x86ms->linuxboot_randomness != ON_OFF_AUTO_OFF && > > > +(protoco

Re: [PATCH] virtio-scsi: fix race in virtio_scsi_dataplane_start()

2022-08-05 Thread Michael S. Tsirkin
not modify it while the IOThread is > active. > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2099541 > Reported-by: Qing Wang > Signed-off-by: Stefan Hajnoczi A scsi thing that tree seems more appropriate. Reviewed-by: Michael S. Tsirkin > --- > hw/scsi/vir

Re: [PATCH 7.1] virtio-scsi: fix race in virtio_scsi_dataplane_start()

2022-08-05 Thread Michael S. Tsirkin
On Thu, Aug 04, 2022 at 02:56:59PM -0400, Stefan Hajnoczi wrote: > On Wed, Aug 03, 2022 at 12:28:24PM -0400, Stefan Hajnoczi wrote: > > As soon as virtio_scsi_data_plane_start() attaches host notifiers the > > IOThread may start virtqueue processing. There is a race between > > IOThread virtqueue

Re: [PATCH v2] pc: add property for Linux setup_data random number seed

2022-08-05 Thread Michael S. Tsirkin
ult. > > Cc: Michael S. Tsirkin > Co-developed-by: Jason A. Donenfeld > Signed-off-by: Paolo Bonzini > --- > hw/i386/microvm.c | 2 +- > hw/i386/pc.c | 5 +++-- > hw/i386/pc_piix.c | 2 +- > hw/i386/pc_q35.c

Re: [PATCH] pc: add property for Linux setup_data seed

2022-08-04 Thread Michael S. Tsirkin
On Thu, Aug 04, 2022 at 04:31:06PM +0200, Jason A. Donenfeld wrote: > Hi Daniel, > > On Thu, Aug 04, 2022 at 02:31:06PM +0100, Daniel P. Berrangé wrote: > > On Thu, Aug 04, 2022 at 03:20:59PM +0200, Jason A. Donenfeld wrote: > > > On Thu, Aug 04, 2022 at 03:13:20PM +0200, Paolo Bonzini wrote: > >

Re: [PATCH v2] hw/i386: place setup_data at fixed place in memory

2022-08-04 Thread Michael S. Tsirkin
even if OVMF or other chains relocate the kernel image, the boot > parameter still points to the correct absolute address. > > Fixes: 3cbeb52467 ("hw/i386: add device tree support") > Reported-by: Xiaoyao Li > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Peter Maydel

Re: [PATCH RFC v1] hw/i386: place setup_data at fixed place in memory

2022-08-03 Thread Michael S. Tsirkin
ebody with some x86 architectural knowledge could let me know a > better reserved place to put this, that'd be very appreciated. > > Fixes: 3cbeb52467 ("hw/i386: add device tree support") > Reported-by: Xiaoyao Li > Cc: Paolo Bonzini > Cc: Richard Henderson >

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-03 Thread Michael S. Tsirkin
On Thu, Aug 04, 2022 at 12:08:07AM +0200, Jason A. Donenfeld wrote: > Hi Michael, > > On Wed, Aug 03, 2022 at 06:03:20PM -0400, Michael S. Tsirkin wrote: > > On Wed, Aug 03, 2022 at 07:07:52PM +0200, Jason A. Donenfeld wrote: > > > On Wed, Aug 03, 2022 at 03:34:04PM +

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-03 Thread Michael S. Tsirkin
On Wed, Aug 03, 2022 at 07:07:52PM +0200, Jason A. Donenfeld wrote: > On Wed, Aug 03, 2022 at 03:34:04PM +0200, Jason A. Donenfeld wrote: > > On Wed, Aug 03, 2022 at 03:11:48PM +0200, Jason A. Donenfeld wrote: > > > Thanks for the info. Very helpful. Looking into it now. > > > > So interestingly,

Re: [PATCH for-7.1] hw/mips/malta: turn off x86 specific features of PIIX4_PM

2022-08-03 Thread Michael S. Tsirkin
om MIPS target (but forgetting about migration bits). > > Disable compiled out features using compat properties as the least > risky way to deal with issue. > > Signed-off-by: Igor Mammedov For 7.1 this seems like the lesser evil. Acked-by: Michael S. Tsirkin > --- >

Re: [PATCH v2 2/2] virtio: Add shared memory capability

2022-08-03 Thread Michael S. Tsirkin
On Wed, Aug 03, 2022 at 05:21:35PM +0200, Antonio Caggiano wrote: > From: "Dr. David Alan Gilbert" > > Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG' > and the data structure 'virtio_pci_shm_cap' to go with it. > They allow defining shared memory regions with sizes and offsets >

Re: [PATCH 0/2] vmgenid: add generation counter

2022-08-03 Thread Michael S. Tsirkin
On Wed, Aug 03, 2022 at 03:41:45PM +0200, bchal...@amazon.es wrote: > From: Babis Chalios > > VM generation ID exposes a GUID inside the VM which changes every time a > VM restore is happening. Typically, this GUID is used by the guest > kernel to re-seed its internal PRNG. As a result, this

Re: [PATCH 2/2] vdpa: Merge all net_init_vhost_vdpa error goto

2022-08-02 Thread Michael S. Tsirkin
On Tue, Aug 02, 2022 at 02:58:36PM +0200, Laurent Vivier wrote: > On 02/08/2022 14:57, Michael S. Tsirkin wrote: > > On Tue, Aug 02, 2022 at 02:10:43PM +0200, Laurent Vivier wrote: > > > On 02/08/2022 13:24, Eugenio Pérez wrote: > > > > Few steps allocate new resou

Re: [PATCH 2/2] vdpa: Merge all net_init_vhost_vdpa error goto

2022-08-02 Thread Michael S. Tsirkin
qemu-trivial too I guess then? Reviewed-by: Michael S. Tsirkin > > --- > > net/vhost-vdpa.c | 6 ++ > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c > > index 303447a68e..ac1810723c 100644 >

Re: [PATCH 1/2] vdpa: Fix file descriptor leak on get features error

2022-08-02 Thread Michael S. Tsirkin
ikely(r < 0)) { > > -return r; > > +goto err; > > } > > queue_pairs = vhost_vdpa_get_max_queue_pairs(vdpa_device_fd, features, > > Reviewed-by: Laurent Vivier > > I can take this one via the trivial branch. > > Thanks, > Laurent Not sure why it's appropriate for trivial but sure if you like Reviewed-by: Michael S. Tsirkin

Re: [PATCH] vdpa: Fix file descriptor leak on get features error

2022-08-01 Thread Michael S. Tsirkin
On Mon, Aug 01, 2022 at 08:48:41PM +0200, Eugenio Perez Martin wrote: > On Mon, Aug 1, 2022 at 8:34 PM Peter Maydell wrote: > > > > On Mon, 1 Aug 2022 at 19:31, Laurent Vivier wrote: > > > > > > On 01/08/2022 16:47, Eugenio Pérez wrote: > > > > File descriptor vdpa_device_fd is not free in the

Re: [PATCH] ipmi:smbus: Add a check around a memcpy

2022-08-01 Thread Michael S. Tsirkin
full. We have to allow len == 0 due to some > vagueness in the spec, but we don't have to call memcpy. > > Found by Coverity. This is not a problem in practice, but the results > are technically (maybe) undefined. So make Coverity happy. > > Reported-by: Peter Maydell > Si

Re: virtio: why no full reset on virtio_set_status 0 ?

2022-07-29 Thread Michael S. Tsirkin
On Fri, Jul 29, 2022 at 11:46:05AM +0200, Claudio Fontana wrote: > >> @@ -2025,7 +2031,6 @@ void virtio_reset(void *opaque) > >> VirtioDeviceClass *k = VIRTIO_DEVICE_GET_CLASS(vdev); > >> int i; > >> > >> -virtio_set_status(vdev, 0); > >> if (current_cpu) { > >> /*

Re: virtio: why no full reset on virtio_set_status 0 ?

2022-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2022 at 11:09:15AM +0200, Claudio Fontana wrote: > On 7/28/22 09:43, Claudio Fontana wrote: > > On 7/28/22 03:27, Jason Wang wrote: > >> On Wed, Jul 27, 2022 at 11:32 PM Michael S. Tsirkin > >> wrote: > >>> > >>> On Wed, Jul

Re: [PATCH for-7.2] hw: Add compat machines for 7.2

2022-07-28 Thread Michael S. Tsirkin
On Wed, Jul 27, 2022 at 02:17:55PM +0200, Cornelia Huck wrote: > Add 7.2 machine types for arm/i440fx/m68k/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin whoever needs this first, feel free to merge. > --- > hw/arm/virt.c | 9

Re: virtio: why no full reset on virtio_set_status 0 ?

2022-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2022 at 09:43:56AM +0200, Claudio Fontana wrote: > On 7/28/22 03:27, Jason Wang wrote: > > On Wed, Jul 27, 2022 at 11:32 PM Michael S. Tsirkin wrote: > >> > >> On Wed, Jul 27, 2022 at 12:51:31PM +0200, Claudio Fontana wrote: > >>> Hi Mich

Re: VIRTIO_NET_F_MTU not negotiated

2022-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2022 at 01:51:37PM +0800, Jason Wang wrote: > On Thu, Jul 28, 2022 at 1:39 PM Eli Cohen wrote: > > > > > From: Jason Wang > > > Sent: Thursday, July 28, 2022 5:09 AM > > > To: Eli Cohen > > > Cc: Eugenio Perez Martin ; qem

Re: VIRTIO_NET_F_MTU not negotiated

2022-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2022 at 05:51:32AM +, Eli Cohen wrote: > > From: Michael S. Tsirkin > > Sent: Wednesday, July 27, 2022 6:44 PM > > To: Eli Cohen > > Cc: Eugenio Perez Martin ; qemu-devel@nongnu.org; > > Jason Wang ; > > virtualizat...@lists.

Re: virtio: why no full reset on virtio_set_status 0 ?

2022-07-27 Thread Michael S. Tsirkin
On Wed, Jul 27, 2022 at 12:51:31PM +0200, Claudio Fontana wrote: > Hi Michael and all, > > I have started researching a qemu / ovs / dpdk bug: > > https://inbox.dpdk.org/dev/322122fb-619d-96f6-5c3e-9eabdbf38...@redhat.com/T/ > > that seems to be affecting multiple parties in the telco space, >

[PATCH] virtio-pci: don't touch pci on virtio reset

2022-07-27 Thread Michael S. Tsirkin
;) Fixes: c2cabb3422 ("hw/virtio: fix error enabling flags in Device Control register") Cc: "Marcel Apfelbaum" Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b

Re: VIRTIO_NET_F_MTU not negotiated

2022-07-27 Thread Michael S. Tsirkin
On Wed, Jul 27, 2022 at 10:16:19AM +, Eli Cohen wrote: > > -Original Message- > > From: Michael S. Tsirkin > > Sent: Wednesday, July 27, 2022 12:35 PM > > To: Eli Cohen > > Cc: Eugenio Perez Martin ; qemu-devel@nongnu.org; > > Jason W

Re: virtio: why no full reset on virtio_set_status 0 ?

2022-07-27 Thread Michael S. Tsirkin
On Wed, Jul 27, 2022 at 12:51:31PM +0200, Claudio Fontana wrote: > Hi Michael and all, > > I have started researching a qemu / ovs / dpdk bug: > > https://inbox.dpdk.org/dev/322122fb-619d-96f6-5c3e-9eabdbf38...@redhat.com/T/ > > that seems to be affecting multiple parties in the telco space, >

Re: VIRTIO_NET_F_MTU not negotiated

2022-07-27 Thread Michael S. Tsirkin
On Wed, Jul 27, 2022 at 09:04:47AM +, Eli Cohen wrote: > > -Original Message- > > From: Michael S. Tsirkin > > Sent: Wednesday, July 27, 2022 10:25 AM > > To: Eli Cohen > > Cc: Eugenio Perez Martin ; qemu-devel@nongnu.org; > > Jason W

Re: VIRTIO_NET_F_MTU not negotiated

2022-07-27 Thread Michael S. Tsirkin
On Wed, Jul 27, 2022 at 06:51:56AM +, Eli Cohen wrote: > I found out that the reason why I could not enforce the mtu stems from the > fact that I did not configure max mtu for the net device (e.g. through > libvirt ). > Libvirt does not allow this configuration for vdpa devices and probably

Re: [PATCH v3 for 7.2 00/21] virtio-gpio and various virtio cleanups

2022-07-26 Thread Michael S. Tsirkin
On Tue, Jul 26, 2022 at 08:21:29PM +0100, Alex Bennée wrote: > Hi, > > After much slogging through the vhost-user code I've gotten the > virtio-gpio device working again. The core change in pushing the > responsibility for VHOST_USER_F_PROTOCOL_FEATURES down to the > vhost-user layer (which knows

[PULL 11/16] i386/pc: handle unitialized mr in pc_get_cxl_range_end()

2022-07-26 Thread Michael S. Tsirkin
region end when its underlying memory region isn't yet initialized. Cc: Jonathan Cameron Signed-off-by: Joao Martins Message-Id: <20220719170014.27028-8-joao.m.mart...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Igor Mammedov --- hw/i386/pc.

[PULL 08/16] i386/pc: factor out above-4g end to an helper

2022-07-26 Thread Michael S. Tsirkin
viewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index f4d5b25fdd..d1e20ccb27 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -814,6 +814,17 @

[PULL 09/16] i386/pc: factor out cxl range end to helper

2022-07-26 Thread Michael S. Tsirkin
: Jonathan Cameron Signed-off-by: Joao Martins Acked-by: Igor Mammedov Message-Id: <20220719170014.27028-6-joao.m.mart...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 31 +-- 1 file changed, 21 insertions(

[PULL 04/16] hw/cxl: Fix size of constant in interleave granularity function.

2022-07-26 Thread Michael S. Tsirkin
meter encoding/decoding") Fixes: Coverity CID 1488868 Signed-off-by: Jonathan Cameron Message-Id: <20220701132300.2264-4-jonathan.came...@huawei.com> Acked-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/cxl/cxl_component.h | 2 +-

[PULL 06/16] i386/pc: create pci-host qdev prior to pc_memory_init()

2022-07-26 Thread Michael S. Tsirkin
: <20220719170014.27028-3-joao.m.mart...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci-host/i440fx.h | 3 ++- hw/i386/pc_piix.c| 7 +-- hw/i386/pc_q35.c | 6 +++--- hw/pci-host/i440fx.c | 5 ++--- 4 files c

[PULL 05/16] hw/i386: add 4g boundary start to X86MachineState

2022-07-26 Thread Michael S. Tsirkin
Mammedov Message-Id: <20220719170014.27028-2-joao.m.mart...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/x86.h | 3 +++ hw/i386/acpi-build.c | 2 +- hw/i386/pc.c | 11 ++- hw/i386/sgx.c | 2 +- hw/i386

[PULL 03/16] hw/i386/pc: Always place CXL Memory Regions after device_memory

2022-07-26 Thread Michael S. Tsirkin
mmedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index d2b5823ffb..46ab1dcb47 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -922,10 +922,8 @@ void pc_memory_ini

[PULL 01/16] acpi/nvdimm: Define trace events for NVDIMM and substitute nvdimm_debug()

2022-07-26 Thread Michael S. Tsirkin
From: Robert Hoo Signed-off-by: Robert Hoo Reviewed-by: Jingqi Liu Message-Id: <20220704085852.330005-1-robert...@linux.intel.com> Reviewed-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/mem/nvdimm.h | 8 hw/acpi/nv

[PULL 15/16] i386/pc: restrict AMD only enforcing of 1Tb hole to new machine type

2022-07-26 Thread Michael S. Tsirkin
enforce but not older ones. Signed-off-by: Joao Martins Acked-by: Dr. David Alan Gilbert Acked-by: Igor Mammedov Message-Id: <20220719170014.27028-12-joao.m.mart...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 1 + hw/i38

[PULL 12/16] i386/pc: factor out device_memory base/size to helper

2022-07-26 Thread Michael S. Tsirkin
hael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 48 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 611eb197da..ebc27e4cb7 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -

[PULL 14/16] i386/pc: relocate 4g start to 1T where applicable

2022-07-26 Thread Michael S. Tsirkin
rt...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 54 1 file changed, 54 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 56d8c179ea..1c5c9e17c6 100644 --- a/hw/i386/pc.c +++ b/h

[PULL 13/16] i386/pc: bounds check phys-bits against max used GPA

2022-07-26 Thread Michael S. Tsirkin
m.mart...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index ebc27e4cb7..56d8c179ea 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -879,

[PULL 10/16] i386/pc: factor out cxl range start to helper

2022-07-26 Thread Michael S. Tsirkin
Martins Acked-by: Igor Mammedov Message-Id: <20220719170014.27028-7-joao.m.mart...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/hw/i386/pc.c b/h

[PULL 02/16] hw/machine: Clear out left over CXL related pointer from move of state handling to machines.

2022-07-26 Thread Michael S. Tsirkin
4-2-jonathan.came...@huawei.com> Acked-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/boards.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/boards.h b/include/hw/boards.h index d94edcef28..7b416c9787 100644 --- a/include/hw/bo

[PULL 07/16] i386/pc: pass pci_hole64_size to pc_memory_init()

2022-07-26 Thread Michael S. Tsirkin
-hole64-size to be considered to relocate ram-above-4g to be at 1T (on AMD platforms). Signed-off-by: Joao Martins Reviewed-by: Igor Mammedov Message-Id: <20220719170014.27028-4-joao.m.mart...@oracle.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i38

[PULL 16/16] hw/virtio/virtio-iommu: Enforce power-of-two notify for both MAP and UNMAP

2022-07-26 Thread Michael S. Tsirkin
Zhang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-iommu.c | 47 1 file changed, 28 insertions(+), 19 deletions(-) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index 281152d338..62e07ec2e4

[PULL 00/16] pc,virtio: fixes

2022-07-26 Thread Michael S. Tsirkin
fixes. From now on, regression fixes only. Signed-off-by: Michael S. Tsirkin Jean-Philippe Brucker (1): hw/virtio/virtio-iommu: Enforce power-of-two notify for both MAP and UNMAP Joao Martins (11): hw/i386: add 4g boundary

Re: [PATCH v2 0/8] AArch64/HMAT support and tests

2022-07-26 Thread Michael S. Tsirkin
On Tue, Jul 19, 2022 at 10:49:42AM +0100, Hesham Almatary wrote: > This patchset adds support for AArch64/HMAT including a test. > It relies on other two patch sets from: > > Brice Goglin: to support -numa without initiators on q35/x86. >

Re: [PATCH] Add support for SMBIOS type 8 (Port Connector Information)

2022-07-26 Thread Michael S. Tsirkin
On Sun, Jul 10, 2022 at 12:48:04PM +0200, Hal Martin wrote: > > This patch adds support for SMBIOS type 8 to qemu. > > internal_reference: internal reference designator > external_reference: external reference designator > connector_type: hex value for port connector type (see SMBIOS 7.9.2) >

Re: [PATCH v2 0/2] vhost-user: Support vhost_dev_start

2022-07-26 Thread Michael S. Tsirkin
On Tue, Jul 12, 2022 at 01:54:59PM +0300, Yajun Wu wrote: > The motivation of adding vhost-user vhost_dev_start support is to > improve backend configuration speed and reduce live migration VM > downtime. > > Today VQ configuration is issued one by one. For virtio net with > multi-queue support,

Re: [PATCH 00/11] QOM'ify PIIX3 southbridge

2022-07-26 Thread Michael S. Tsirkin
On Wed, Jul 13, 2022 at 10:17:24AM +0200, Bernhard Beschow wrote: > Similar to PIIX4 this series QOM'ifies internal device creation for PIIX3. > This reduces the delta between the implementations of PIIX3 and PIIX4 and > therefore might allow to merge both implementations in the future. > > There

Re: [PATCH] contrib/vhost-user-blk: Clean up deallocation of VuVirtqElement

2022-07-26 Thread Michael S. Tsirkin
quot; condition. Useless, > because it cannot be null (it's dereferenced right before), and even > it it could be, free() and g_free() do the right thing. Drop the > conditional. > > Fixes: Coverity CID 1490290 > Signed-off-by: Markus Armbruster Thanks! Acked-by: Michael S. Tsi

Re: [RFC patch 0/1] block: vhost-blk backend

2022-07-26 Thread Michael S. Tsirkin
On Mon, Jul 25, 2022 at 11:55:26PM +0300, Andrey Zhadchenko wrote: > Although QEMU virtio-blk is quite fast, there is still some room for > improvements. Disk latency can be reduced if we handle virito-blk requests > in host kernel so we avoid a lot of syscalls and context switches. > > The

Re: [PATCH v15 00/10] vhost-vdpa: add support for configure interrupt

2022-07-26 Thread Michael S. Tsirkin
Hi! So I don't think this will make it in 7.1. I'll tag this to be merged afterwards, but just to make sure please ping me right after the release. Thanks! On Sun, Jul 24, 2022 at 02:44:44PM +0800, Cindy Lu wrote: > These patches introduced the support for configure interrupt  > These codes are

Re: [PATCH v13 00/10] vhost-vdpa: add support for configure interrupt

2022-07-22 Thread Michael S. Tsirkin
On Fri, Jul 22, 2022 at 03:46:52PM +0800, Cindy Lu wrote: > Hi Micheal. > Would you help review these patches, not sure if this is ok to merge? > Thanks > Cindy Pls note threading is broken in the patchset. Care to repost? -- MST

Re: [PATCH 0/4] Refactor x86_load_linux and pass RNG seed via setup_data entry

2022-07-21 Thread Michael S. Tsirkin
On Thu, Jul 21, 2022 at 05:11:31PM +0200, Jason A. Donenfeld wrote: > Hi Michael, > > On Thu, Jul 21, 2022 at 10:52:32AM -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 21, 2022 at 02:29:33PM +0200, Paolo Bonzini wrote: > > > As mentioned in the reviews of Jason's

Re: [PATCH 0/4] Refactor x86_load_linux and pass RNG seed via setup_data entry

2022-07-21 Thread Michael S. Tsirkin
arting with an old kernel, > and probably it should also fail when starting a PVH or multiboot kernel. > > Paolo I like the refactoring Reviewed-by: Michael S. Tsirkin To avoid creating extra work for Jason and confusing attribution, maybe apply Jason's patch then your refactoring on top? >

Re: [PATCH 4/4] hw/i386: pass RNG seed via setup_data entry

2022-07-21 Thread Michael S. Tsirkin
On Thu, Jul 21, 2022 at 02:29:37PM +0200, Paolo Bonzini wrote: > From: "Jason A. Donenfeld" > > Tiny machines optimized for fast boot time generally don't use EFI, > which means a random seed has to be supplied some other way. For this > purpose, Linux (≥5.20) supports passing a seed in the

Re: [PATCH v6] hw/i386: pass RNG seed via setup_data entry

2022-07-21 Thread Michael S. Tsirkin
ata table > with SETUP_RNG_SEED, specially intended for hypervisors, kexec, and > specialized bootloaders. The linked commit shows the upstream kernel > implementation. > > Link: https://git.kernel.org/tip/tip/c/68b8e9713c8 > Cc: Michael S. Tsirkin > Cc: Marcel Apfelbaum > Cc: Paolo Bonzi

Re: [PATCH v4] hw/i386: pass RNG seed via setup_data entry

2022-07-21 Thread Michael S. Tsirkin
ata table > with SETUP_RNG_SEED, specially intended for hypervisors, kexec, and > specialized bootloaders. The linked commit shows the upstream kernel > implementation. > > Link: https://git.kernel.org/tip/tip/c/68b8e9713c8 > Cc: Michael S. Tsirkin > Cc: Marcel Apfelbaum > Cc: Paolo Bonzi

Re: [QEMU PATCH v2 4/6] nvdimm: Implement ACPI NVDIMM Label Methods

2022-07-19 Thread Michael S. Tsirkin
On Tue, Jul 19, 2022 at 10:46:38AM +0800, Robert Hoo wrote: > Ping... Igor could you respond? It's been 3 weeks ...

Re: [PATCH v3 00/19] vdpa net devices Rx filter change notification with Shadow VQ

2022-07-19 Thread Michael S. Tsirkin
etdevVhostVDPAOptions > > > > qapi/net.json | 9 +- > > hw/virtio/vhost-shadow-virtqueue.h | 52 - > > include/hw/virtio/vhost-vdpa.h | 8 + > > include/hw/virtio/virtio-net.h | 7 + > > hw/net/virtio-net.c| 85 --- > > hw/virtio/vhost-shadow-virtqueue.c | 202 +++- > > hw/virtio/vhost-vdpa.c | 25 +- > > net/vhost-vdpa.c | 357 +++-- > > 8 files changed, 627 insertions(+), 118 deletions(-) > > Looks good to me. > > Michael, if you don't object, I plan to merge this series so vendors > can start to test this. > > Thanks Sounds good. Acked-by: Michael S. Tsirkin > > > > -- > > 2.31.1 > > > >

Re: [PATCH v3 00/19] vdpa net devices Rx filter change notification with Shadow VQ

2022-07-19 Thread Michael S. Tsirkin
tination's vdpa device yet. This will be added in later > series, using this work. > > Comments are welcome. > v3: > - Replace SVQElement with SVQDescState Series: Reviewed-by: Michael S. Tsirkin > v2: > - (Comments from series [1]). > - Active poll for CVQ a

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-16 Thread Michael S. Tsirkin
On Sat, Jul 16, 2022 at 12:06:00PM +0530, Ani Sinha wrote: > > > On Fri, Jul 15, 2022 at 11:20 Michael S. Tsirkin wrote: > > On Fri, Jul 15, 2022 at 09:47:27AM +0530, Ani Sinha wrote: > > > Instead of all this mess, can't we just spawn e.g. &q

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-15 Thread Michael S. Tsirkin
On Fri, Jul 15, 2022 at 09:47:27AM +0530, Ani Sinha wrote: > > Instead of all this mess, can't we just spawn e.g. "git clone --depth 1"? > > And if the directory exists I would fetch and checkout. > > There are two reasons I can think of why I do not like this idea: > > (a) a git clone of a

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-14 Thread Michael S. Tsirkin
On Thu, Jul 14, 2022 at 07:49:36PM +0530, Ani Sinha wrote: > > so you skip downlaod if it already exists locally. IIUC it is looking > > in the CWD, which is presumably the directory the QEMU build is > > performed in ? > > Yes, build/test/pytest/bits-test > > > So if dev cleans their build

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

2022-07-14 Thread Michael S. Tsirkin
On Sun, Jul 10, 2022 at 10:30:10PM +0530, Ani Sinha wrote: > This change adds python based test environment that can be used to run pytest > from within a virtual environment. A bash script sets up a virtual environment > and then runs the python based tests from within that environment. > All

  1   2   3   4   5   6   7   8   9   10   >