On Thu, Oct 19, 2023 at 5:23 PM Alexander Ivanov
wrote:
>
> We will need these functions in parallels-ext.c too. Let them be global
> functions parallels_mark_used() and parallels_mark_unused().
>
> Signed-off-by: Alexander Ivanov
> ---
> block/parallels.c | 22 --
>
On Thu, Oct 19, 2023 at 4:06 PM Alexander Ivanov
wrote:
>
> After used bitmap freeng s->used_bmap points to the freed memory. If we try
> to free used bitmap one more time it leads to double free error.
>
> Set s->used_bmap to NULL to exclude double free error.
>
> Signed-off-by: Alexander Ivanov
On Thu, Oct 19, 2023 at 4:05 PM Alexander Ivanov
wrote:
>
> Now dirty bitmaps can be loaded but there is no their saving. Add code for
> dirty bitmap storage.
>
> Signed-off-by: Alexander Ivanov
> ---
> block/parallels-ext.c | 167 ++
> block/parallels.c
On Sat, Oct 7, 2023 at 5:30 PM Alexander Ivanov
wrote:
>
>
>
> On 10/7/23 13:21, Mike Maslenkin wrote:
> > On Sat, Oct 7, 2023 at 1:18 PM Alexander Ivanov
> > wrote:
> >>
> >> On 10/6/23 21:43, Mike Maslenkin wrote:
> >>> On Mon,
On Sat, Oct 7, 2023 at 1:18 PM Alexander Ivanov
wrote:
>
>
>
> On 10/6/23 21:43, Mike Maslenkin wrote:
> > On Mon, Oct 2, 2023 at 12:01 PM Alexander Ivanov
> > wrote:
> >> Since we have used bitmap, field data_end in BDRVParallelsState is
> >> r
On Mon, Oct 2, 2023 at 12:01 PM Alexander Ivanov
wrote:
>
> Since we have used bitmap, field data_end in BDRVParallelsState is
> redundant and can be removed.
>
> Add parallels_data_end() helper and remove data_end handling.
>
> Signed-off-by: Alexander Ivanov
> ---
> block/parallels.c | 33
er opinions.
Regards,
Mike.
On Sun, Oct 1, 2023 at 3:25 PM Denis V. Lunev wrote:
>
> On 9/30/23 22:31, Mike Maslenkin wrote:
> > Add a check that destination file exists and do not call bdrv_create for
> > this case.
> >
> > Currently `qemu-img dd` command destroys c
tion image
are preserved. As another visible change of `qemu-img dd` behavior is that
if destination image is less than source it can finish with error (similar
to "dd" utility):
qemu-img: error while writing to output image file: Input/output error
Signed-off-by: Mike Maslenkin
---
d
tion image
are preserved. As another visible change of `qemu-img dd` behavior is that
if destination image is less than source it can finish with error (similar
to "dd" utility):
qemu-img: error while writing to output image file: Input/output error
Signed-off-by: Mike Maslenkin
This patch generates a warning.
On Fri, Sep 15, 2023 at 9:41 PM Denis V. Lunev wrote:
>
> More conditions follows thus the check should be more scalable.
>
> Signed-off-by: Denis V. Lunev
> ---
> block/parallels.c | 19 ---
> 1 file changed, 8 insertions(+), 11 deletions(-)
>
>
I got a warning after this patch:
../block/parallels.c:541:25: warning: 'guarded_by' attribute only
applies to non-static data members and global variables
[-Wignored-attributes]
static int coroutine_fn GRAPH_RDLOCK_PTR
^
This is not introduced by this patch,
but looks like qemu_opts_del(opts) missed.
On Fri, Sep 15, 2023 at 9:41 PM Denis V. Lunev wrote:
>
> This patch creates above mentioned helper and moves its usage to the
> beginning of parallels_open(). This simplifies parallels_open() a bit.
>
> The patch
On Wed, Aug 23, 2023 at 12:17 PM Fiona Ebner wrote:
>
> Am 23.08.23 um 10:47 schrieb Fiona Ebner:
> > Am 17.02.23 um 22:22 schrieb Mike Maslenkin:
> >> I can not tell anything about dma-reentracy issues, but yes, i would
> >> start to look at check_cmd() functio
Hello All,
I'm ok with that.
Regards,
Mike.
On Wed, Aug 2, 2023 at 3:52 AM Jeuk Kim wrote:
>
> On 8/2/2023 6:03 AM, Philippe Mathieu-Daudé wrote:
> > Hi Mike,
> >
> > On 28/7/23 01:34, Mike Maslenkin wrote:
> >> This patchset contains a trivial compilation f
Actually UTRLDBR is 32bit register. There is no need to pass 64bit
value to ufs_process_db() function.
Cc: Jeuk Kim
Cc: Stefan Hajnoczi
Signed-off-by: Mike Maslenkin
---
hw/ufs/ufs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c
index
);
^~~~
Cc: Jeuk Kim
Cc: Stefan Hajnoczi
Signed-off-by: Mike Maslenkin
---
hw/ufs/ufs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c
index af32366c8504..b0656e47598e 100644
--- a/hw/ufs/ufs.c
+++ b/hw/ufs/ufs.c
Signed-off-by: Mike Maslenkin
---
hw/ufs/ufs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c
index 1760e0f88d70..af32366c8504 100644
--- a/hw/ufs/ufs.c
+++ b/hw/ufs/ufs.c
@@ -514,10 +514,10 @@ static UfsReqResult ufs_exec_scsi_cmd(UfsRequest *req
This patchset contains a trivial compilation fixes for UFS support
applied to block-next tree.
Cc: Jeuk Kim
Cc: Stefan Hajnoczi
Signed-off-by: Mike Maslenkin
r Ivanov
wrote:
>
> Good point. Thank you.
>
> Best regards,
> Alexander Ivanov
>
> On 4/26/23 23:56, Mike Maslenkin wrote:
> > On Mon, Apr 24, 2023 at 12:44 PM Alexander Ivanov
> > wrote:
> >> Cluster offsets must be unique among all the BAT entries. Fin
Sorry for the noise again , but I have another note
On Mon, Apr 24, 2023 at 12:44 PM Alexander Ivanov
wrote:
>
> Cluster offsets must be unique among all the BAT entries. Find duplicate
> offsets in the BAT and fix it by copying the content of the relevant
> cluster to a newly allocated cluster
On Mon, Apr 24, 2023 at 12:44 PM Alexander Ivanov
wrote:
>
> Cluster offsets must be unique among all the BAT entries. Find duplicate
> offsets in the BAT and fix it by copying the content of the relevant
> cluster to a newly allocated cluster and set the new cluster offset to the
> duplicated
reproduce problem as well.
On Thu, Apr 13, 2023 at 3:10 PM Fiona Ebner wrote:
>
> Am 13.04.23 um 13:46 schrieb Mike Maslenkin:
> > Sorry for the noise, but just curious, how did you shutdown Windows?
> > Did you use 'shutdown /s' or just press power button?
> > Could it be th
Sorry for the noise, but just curious, how did you shutdown Windows?
Did you use 'shutdown /s' or just press power button?
Could it be that Windows was actually hibernated.
So, when you try to boot it on the new (old) QEMU version with changed
PCI topology, this could make it upset.
I observed
thought about race
with IDE reset where registers initialized with
value SATA_SIGNATURE_DISK = 0x0101, but this means LBA=1 as well...
Regards,
Mike
On Fri, Feb 17, 2023 at 4:40 PM Fiona Ebner wrote:
>
> Am 16.02.23 um 15:17 schrieb Mike Maslenkin:
> > Does additional comparison
guest OS.
In other cases it can be caused by misconfigured IDE registers state
or broken FIS memory area.
On Thu, Feb 16, 2023 at 6:25 PM Fiona Ebner wrote:
>
> Am 16.02.23 um 15:17 schrieb Mike Maslenkin:
> > Does additional comparison make a sense here: check for LBA == 0 and
> &
Does additional comparison make a sense here: check for LBA == 0 and
then check MBR signature bytes.
Additionally it’s easy to check buffer_is_zero() result or even print
FIS contents under these conditions.
Data looks like a part of guest memory of 64bit Windows.
On Wed, Feb 15, 2023 at 1:53 PM
On Fri, Jan 13, 2023 at 7:43 PM Jonathan Cameron via
wrote:
>
> CXL uses PCI AER Internal errors to signal to the host that an error has
> occurred. The host can then read more detailed status from the CXL RAS
> capability.
>
> For uncorrectable errors: support multiple injection in one operation
Hello Sunil!
What about virt_machine_done() function?
kernel_entry variable still points to the second flash started from
virt_memmap[VIRT_FLASH].size / 2.
On Sun, Nov 6, 2022 at 5:41 PM Sunil V L wrote:
>
> The pflash implementation currently assumes fixed size of the
> backend storage. Due to
28 matches
Mail list logo
