On Wed, Nov 9, 2022 at 5:14 PM Philippe Mathieu-Daudé wrote:
>
> Hi Mirek,
>
> On 9/11/22 16:34, mreza...@redhat.com wrote:
> > From: Miroslav Rezanina
> >
> > Commit cfead31326 'acpi: pc: vga: use AcpiDevAmlIf interface to build VGA
> > device descriptor
.
Signed-off-by: Miroslav Rezanina
---
This is v2 of configure: Use -mlittle-endian instead of -mlittle for ppc64.
v2:
- handle both -mlittle and -mbig usage
- fix tests/tcg/configure.sh
---
configure | 4 ++--
tests/tcg/configure.sh | 4 ++--
2 files changed, 4 insertions(+), 4
: previously declared as an array 'const int[16]'
122 |const int const_args[TCG_MAX_OP_ARGS]);
|~~^~~
Fixing argument type to pass build.
Signed-off-by: Miroslav Rezanina
---
tcg/s390x/tcg-target.c.inc
For some reason, libpmem option setting was set to work in an opposite
way (--enable-libpmem disabled it and vice versa). Fixing this so
configuration works properly.
Signed-off-by: Miroslav Rezanina
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure
For some reason, libdaxctl option setting was set to work in an opposite
way (--enable-libdaxctl disabled it and vice versa). Fixing this so
configuration works properly.
Signed-off-by: Miroslav Rezanina
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
- Original Message -
> From: "Peter Maydell"
> To: "Miroslav Rezanina"
> Cc: "QEMU Developers" , "Vladimir Sementsov-Ogievskiy"
> ,
> "Qemu-block"
> Sent: Wednesday, May 5, 2021 12:43:44 PM
> Subject: Re: Prevent
-by: Miroslav Rezanina
---
diff --git a/block.c b/block.c
index 874c22c43e..3ca27bd2d9 100644
--- a/block.c
+++ b/block.c
@@ -4851,7 +4851,7 @@ static int bdrv_replace_node_common(BlockDriverState
*from,
Transaction *tran = tran_new();
g_autoptr(GHashTable) found = NULL;
g_autoptr
> -#include "vixl/a64/disasm-a64.h"
> -
> using namespace vixl;
>
> static Decoder *vixl_decoder = NULL;
> --
> 2.23.0
>
>
This error occurs when c++ compiler is used. With the fix, build pass.
Reviewed-by: Miroslav Rezanina
On Mon, Mar 15, 2021 at 09:08:01AM +0100, Thomas Huth wrote:
> On 15/03/2021 09.00, mreza...@redhat.com wrote:
> > From: Miroslav Rezanina
> >
> > When declaring g_autofree variable without inicialization, compiler
> > will raise "may be used uninitializ
On Mon, Mar 15, 2021 at 02:20:10PM +0800, Zenghui Yu wrote:
> On 2021/3/15 13:48, Miroslav Rezanina wrote:
> > Missing declaration without initialization in hw/s390x/s390-pci-vfio.c
> > othwerwise correct. Will you send v4 with missing initialization or
> > should I send
On Fri, Mar 12, 2021 at 07:21:43PM +0800, Zenghui Yu wrote:
> Quote docs/devel/style.rst (section "Automatic memory deallocation"):
>
> * Variables declared with g_auto* MUST always be initialized,
> otherwise the cleanup function will use uninitialized stack memory
>
> Initialize @name
- Original Message -
> From: "Philippe Mathieu-Daudé"
> To: qemu-devel@nongnu.org
> Cc: "Jason Wang" , "Stefano Garzarella"
> , "Thomas Huth" ,
> "Miroslav Rezanina" , "Dmitry Fleytman"
> , "Paolo Bonzi
- Original Message -
> From: "Philippe Mathieu-Daudé"
> To: qemu-devel@nongnu.org
> Cc: "Laurent Vivier" , "Dmitry Fleytman"
> , "Miroslav Rezanina"
> , "Li Qiang" , "Paolo Bonzini"
> , "Jason Wa
files changed, 72 insertions(+), 20 deletions(-)
> create mode 100644 tests/qtest/fuzz-e1000e-test.c
>
> --
> 2.26.2
>
>
>
Reviewed-by: Miroslav Rezanina
gt;
>
With qtest chunk included:
Reviewed-by: Miroslav Rezanina
On Thu, Jan 14, 2021 at 02:15:59PM +0100, Philippe Mathieu-Daudé wrote:
> +Jason +Dmitry
>
> On 1/14/21 8:07 AM, Miroslav Rezanina wrote:
> > When building qemu with GCC 11, compiling eth.c file produce following
> > warning:
> >
> >warning: array subscr
On Thu, Jan 14, 2021 at 09:19:20AM -0500, Alexander Bulekov wrote:
> On 210114 1415, Philippe Mathieu-Daudé wrote:
> > +Jason +Dmitry
> >
> > On 1/14/21 8:07 AM, Miroslav Rezanina wrote:
> > > When building qemu with GCC 11, compiling eth.c file pr
attributes.
As this usage is expected, suppress the warning temporarily through the function
using this retyping.
Signed-off-by: Miroslav Rezanina
---
net/eth.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/eth.c b/net/eth.c
index 1e0821c5f8..b9bdd0435c 100644
--- a/net/eth.c
+++ b
Compiling qemu using GCC 11 we got several new warnings. To allow
build with --enable-werror, we need to solve issues generating these
warnings.
Signed-of-by: Miroslav Rezanina
v2:
- Patch 2 rewrite to use strpadcpy
- removed Patch 3 (different version sent by Philippe Mathieu-Daudé)
v3
target array after copied string
and does not raise warning when length is equal to target array
size (and ending '\0' is discarded).
Signed-off-by: Miroslav Rezanina
---
target/s390x/kvm.c | 12 +---
target/s390x/misc_helper.c | 7 +--
2 files changed, 10 insertions(+), 9
On Mon, Jan 11, 2021 at 04:01:12PM +0100, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tcg/s390/tcg-target.c.inc | 252 ++
> 1 file changed, 122 insertions(+), 130 deletions(-)
>
> diff --git a/tcg/s390/tcg-target.c.inc
Compiling qemu using GCC 11 we got several new warnings. To allow
build with --enable-werror, we need to solve issues generating these
warnings.
Signed-of-by: Miroslav Rezanina
v2:
- Patch 2 rewrite to use strpadcpy
- removed Patch 3 (different version sent by Philippe Mathieu-Daudé
attributes.
As this usage is expected, suppress the warning temporarily through the function
using this retyping.
Signed-off-by: Miroslav Rezanina
---
net/eth.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/eth.c b/net/eth.c
index 1e0821c5f8..b9bdd0435c 100644
--- a/net/eth.c
+++ b
similar to strncpy but allow copy strings with
length equal size of target array (and discarding endint zero) and
ensure array is zeroed after copied string.
Signed-off-by: Miroslav Rezanina
---
target/s390x/kvm.c | 12 +---
target/s390x/misc_helper.c | 7 +--
2 files changed, 10
u.org, qemu-...@nongnu.org, "Jiaxun Yang"
> , qemu-s3...@nongnu.org,
> "Philippe Mathieu-Daudé" , "Cornelia Huck"
> , "Richard Henderson"
> , "Andrzej Zaborowski" ,
> "Alistair Francis"
> , "Palmer Dabbelt&q
- Original Message -
> From: "Christian Borntraeger"
> To: "Thomas Huth" , "Miroslav Rezanina"
>
> Cc: "qemu-s390x" , "Philippe Mathieu-Daudé"
> , qemu-devel@nongnu.org
> Sent: Monday, January 11, 2021 2:02:32
- Original Message -
> From: "Thomas Huth"
> To: "Miroslav Rezanina"
> Cc: "qemu-s390x" , "Philippe Mathieu-Daudé"
> , qemu-devel@nongnu.org
> Sent: Monday, January 11, 2021 1:54:06 PM
> Subject: Re: [RHEL7 qemu-kvm PATCH 2/
1/21 12:30 PM, mreza...@redhat.com wrote:
> > From: Miroslav Rezanina
> >
> > There are two cases when vm name is copied but closing \0 can be lost
> > in case name is too long (>=256 characters).
> >
> > Updating length to copy so there is space for closing
cg_out_op argument mismatch
> warning
>
> On 1/11/21 12:30 PM, mreza...@redhat.com wrote:
> > From: Miroslav Rezanina
> >
> > There's prototype mismatch between tcg/tcg.c and
> > tcg/aarch/tcg-target.c.inc:
> >
> > tcg.c:
Fix vm name copy length
>
> On 11/01/2021 13.10, Philippe Mathieu-Daudé wrote:
> > Hi Miroslav,
> >
> > On 1/11/21 12:30 PM, mreza...@redhat.com wrote:
> >> From: Miroslav Rezanina
> >>
> >> There are two cases when vm name is copied but closing \0
he main binary.
>
> In the short term we can define STAP_SDT_V2 so dtrace(1) produces a .o
> file with 'default' symbol visibility instead of 'hidden'. This
> workaround is small and easier to merge for QEMU 5.2.
>
Thanks for this fix.
Reviewed-by: Miroslav Rezanina
>
- Original Message -
> From: "Andrew Jones"
> To: "Peter Maydell"
> Cc: "Miroslav Rezanina" , "QEMU Developers"
> , "qemu-arm"
> , "Philippe Mathieu-Daudé"
> Sent: Wednesday, November 11, 2020 6:39:32 P
- Original Message -
> From: "Andrew Jones"
> To: qemu-devel@nongnu.org, qemu-...@nongnu.org
> Cc: "peter maydell" , phi...@redhat.com, "Miroslav
> Rezanina"
> Sent: Wednesday, November 11, 2020 3:34:40 PM
> Subject: [PATCH] hw/arm/vir
- Original Message -
> From: "Paolo Bonzini"
> To: qemu-devel@nongnu.org
> Cc: th...@redhat.com, "Miroslav Rezanina"
> Sent: Monday, August 31, 2020 2:56:45 PM
> Subject: [PATCH] build: fix recurse-all target
>
> The missing "/all" suf
-cpu_name = object_get_canonical_path_component(OBJECT(cpu));
> +g_autofree char *cpu_name =
> +object_get_canonical_path_component(OBJECT(cpu));
> g_string_printf(rs, "%s %s [%s]", cpu_model, cpu_name,
> cpu->halted ? "halted " : "running");
> } else {
> --
> 2.23.0
>
>
>
Fixing broken build with -Wall.
Reviewed-by: Miroslav Rezanina
Patch 6a7e2bbee5 docs: add virtiofsd(1) man page introduced new man
page virtiofsd.1. Unfortunately, wrong file location is used as
source for install command. This cause installation of docs fail.
Fixing wrong location so installation is successful.
Signed-off-by: Miroslav Rezanina
quot;$(MANUAL_BUILDDIR)"
> $(call quiet-command, sed "s|@@VERSION@@|${VERSION}|g" $< >$@, \
> "GEN","$@")
>
> --
> 2.24.1
>
Fixing our issues with build,
Reviewed-by: Miroslav Rezanina
Tuesday, January 21, 2020 11:44:14 AM
> Subject: Re: [PATCH 2/2] aspeed/i2c: Prevent uninitialized warning
>
> On 1/21/20 11:02 AM, Thomas Huth wrote:
> > On 21/01/2020 10.28, mreza...@redhat.com wrote:
> >> From: Miroslav Rezanina
> >>
> >> Compiler r
- Original Message -
> From: "Peter Maydell"
> To: "Thomas Huth"
> Cc: "QEMU Developers" , "Paolo Bonzini"
> , "QEMU Trivial"
> , "Miroslav Rezanina" ,
> "Eduardo Habkost" ,
> "Qemu-block
- Original Message -
> From: "Peter Maydell"
> To: "Miroslav Rezanina"
> Cc: "QEMU Developers" , "Michael Roth"
>
> Sent: Friday, September 20, 2019 12:52:49 PM
> Subject: Re: [Qemu-devel] [PATCH v3] qemu-ga: Convert invocat
Comma-separated list of RPCs to disable (no spaces, @samp{?} to list
> - available RPCs).
> -
> -@item -D, --dump-conf
> - Dump the configuration in a format compatible with @file{qemu-ga.conf}
> - and exit.
> -
> -@item -h, --help
> - Display this help and exit.
> -@end table
> -
> -@c man end
> -
> -@c man begin FILES
> -
> -The syntax of the @file{qemu-ga.conf} configuration file follows the
> -Desktop Entry Specification, here is a quick summary: it consists of
> -groups of key-value pairs, interspersed with comments.
> -
> -@example
> -# qemu-ga configuration sample
> -[general]
> -daemonize = 0
> -pidfile = /var/run/qemu-ga.pid
> -verbose = 0
> -method = virtio-serial
> -path = /dev/virtio-ports/org.qemu.guest_agent.0
> -statedir = /var/run
> -@end example
> -
> -The list of keys follows the command line options:
> -@table @option
> -@item daemon= boolean
> -@item method= string
> -@item path= string
> -@item logfile= string
> -@item pidfile= string
> -@item fsfreeze-hook= string
> -@item statedir= string
> -@item verbose= boolean
> -@item blacklist= string list
> -@end table
> -
> -@c man end
> -
> -@ignore
> -
> -@setfilename qemu-ga
> -@settitle QEMU Guest Agent
> -
> -@c man begin AUTHOR
> -Michael Roth
> -@c man end
> -
> -@c man begin SEEALSO
> -qemu(1)
> -@c man end
> -
> -@end ignore
> --
> 2.20.1
>
>
This patch is breaking build for me. It fails on:
perl -Ww -- /builddir/build/BUILD/qemu-4.1.0/scripts/texi2pod.pl -I docs -I
scripts -I docs/interop -DVERSION="4.1.50" -DCONFDIR="/etc/qemu-kvm"
scripts/texi2pod.pl docs/interop/qemu-ga.8.pod && pod2man --utf8 --section=8
--center=" " --release=" " docs/interop/qemu-ga.8.pod > docs/interop/qemu-ga.8
with:
No filename or title
Not sure why this is happening.
Miroslav Rezanina
f your network has reorder or is very lossy add
> ,pincounter
>
> -qemu-system-i386 linux.img -device e1000,netdev=n1 \
> +@value{qemu_system} linux.img -device e1000,netdev=n1 \
> -netdev
>
> l2tpv3,id=n1,src=4.2.3.1,dst=1.2.3.4,udp,srcport=16384,dstport=16384,rxsession=0x,txsession=0x,counter
>
> @end example
> @@ -2650,7 +2650,7 @@ Example:
> # launch vde switch
> vde_switch -F -sock /tmp/myswitch
> # launch QEMU instance
> -qemu-system-i386 linux.img -nic vde,sock=/tmp/myswitch
> +@value{qemu_system} linux.img -nic vde,sock=/tmp/myswitch
> @end example
>
> @item -netdev vhost-user,chardev=@var{id}[,vhostforce=on|off][,queues=n]
> @@ -3107,7 +3107,7 @@ and communicate. Requires the Linux @code{vhci} driver
> installed. Can
> be used as following:
>
> @example
> -qemu-system-i386 [...OPTIONS...] -bt hci,vlan=5 -bt vhci,vlan=5
> +@value{qemu_system} [...OPTIONS...] -bt hci,vlan=5 -bt vhci,vlan=5
> @end example
>
> @item -bt device:@var{dev}[,vlan=@var{n}]
> @@ -3601,7 +3601,7 @@ connections will likely be TCP-based, but also UDP,
> pseudo TTY, or even
> stdio are reasonable use case. The latter is allowing to start QEMU from
> within gdb and establish the connection via a pipe:
> @example
> -(gdb) target remote | exec qemu-system-i386 -gdb stdio ...
> +(gdb) target remote | exec @value{qemu_system} -gdb stdio ...
> @end example
> ETEXI
>
> @@ -4571,7 +4571,7 @@ which specify the queue number of cryptodev backend,
> the default of
>
> @example
>
> - # qemu-system-x86_64 \
> + # @value{qemu_system} \
> [...] \
> -object cryptodev-backend-builtin,id=cryptodev0 \
> -device virtio-crypto-pci,id=crypto0,cryptodev=cryptodev0 \
> @@ -4591,7 +4591,7 @@ of cryptodev backend for multiqueue vhost-user, the
> default of @var{queues} is 1
>
> @example
>
> - # qemu-system-x86_64 \
> + # @value{qemu_system} \
> [...] \
> -chardev socket,id=chardev0,path=/path/to/socket \
> -object cryptodev-vhost-user,id=cryptodev0,chardev=chardev0 \
> @@ -4627,14 +4627,14 @@ The simplest (insecure) usage is to provide the
> secret inline
>
> @example
>
> - # $QEMU -object secret,id=sec0,data=letmein,format=raw
> + # @value{qemu_system} -object secret,id=sec0,data=letmein,format=raw
>
> @end example
>
> The simplest secure usage is to provide the secret via a file
>
> # printf "letmein" > mypasswd.txt
> - # $QEMU -object secret,id=sec0,file=mypasswd.txt,format=raw
> + # @value{qemu_system} -object secret,id=sec0,file=mypasswd.txt,format=raw
>
> For greater security, AES-256-CBC should be used. To illustrate usage,
> consider the openssl command line tool which can encrypt the data. Note
> @@ -4670,7 +4670,7 @@ and specify that to be used to decrypt the user
> password. Pass the
> contents of @code{iv.b64} to the second secret
>
> @example
> - # $QEMU \
> + # @value{qemu_system} \
> -object secret,id=secmaster0,format=base64,file=key.b64 \
> -object secret,id=sec0,keyid=secmaster0,format=base64,\
> data=$SECRET,iv=$( @@ -4713,7 +4713,7 @@ negotiate keys used for attestation. The file must be
> encoded in base64.
>
> e.g to launch a SEV guest
> @example
> - # $QEMU \
> + # @value{qemu_system_x86} \
> ..
> -object sev-guest,id=sev0,cbitpos=47,reduced-phys-bits=5 \
> -machine ...,memory-encryption=sev0
> @@ -4735,7 +4735,7 @@ any commas in the distinguished name.
> An example authorization object to validate a x509 distinguished name
> would look like:
> @example
> - # $QEMU \
> + # @value{qemu_system} \
> ...
> -object
> 'authz-simple,id=auth0,identity=CN=laptop.example.com,,O=Example
> Org,,L=London,,ST=London,,C=GB' \
> ...
> @@ -4784,7 +4784,7 @@ a TLS x509 distinguished name, or a SASL username.
> An example authorization object to validate a SASL username
> would look like:
> @example
> - # $QEMU \
> + # @value{qemu_system} \
> ...
> -object
> authz-simple,id=auth0,filename=/etc/qemu/vnc-sasl.acl,refresh=yes
> ...
> @@ -4802,7 +4802,7 @@ An example authorization object to validate a TLS x509
> distinguished
> name would look like:
>
> @example
> - # $QEMU \
> + # @value{qemu_system} \
> ...
> -object authz-pam,id=auth0,service=qemu-vnc
> ...
> --
> 2.18.1
>
>
Useful change.
Reviewed-by: Miroslav Rezanina
--
Miroslav Rezanina
Software Engineer - Virtualization Team Maintainer
ULL);
> qtest_module_load(qts, args[0], args[1]);
> --
> 1.8.3.1
>
>
Reviewed-by: Miroslav Rezanina
uot;sdl",
> #endif
> -#if defined(CONFIG_SPICE) && defined(CONFIG_GIO)
> -"ui-", "spice-app",
> -#endif
> };
> int i;
>
> --
> 1.8.3.1
>
>
Making make check pass again for me.
Reviewed-by: Miroslav Rezanina
- Original Message -
> From: "Philippe Mathieu-Daudé"
> To: "Peter Maydell"
> Cc: "QEMU Developers" , "Paolo Bonzini"
> , "Miroslav Rezanina"
> , "Richard Henderson" ,
> "Aleksandar Rikalo"
>
- Original Message -
> From: "Alex Bennée"
> To: "Miroslav Rezanina"
> Cc: qemu-devel@nongnu.org, "Peter Maydell" , "Riku
> Voipio" ,
> qemu-...@nongnu.org, "Laurent Vivier"
> Sent: Friday, May 31, 2019 4:28
- Original Message -
> From: "Peter Maydell"
> To: "Alex Bennée"
> Cc: "Miroslav Rezanina" , "QEMU Developers"
> , "Riku Voipio"
> , "qemu-arm" , "Laurent Vivier"
>
> Sent: Friday, May 3
- Original Message -
> From: "Alex Bennée"
> To: "Miroslav Rezanina"
> Cc: qemu-devel@nongnu.org, "Peter Maydell" , "Riku
> Voipio" ,
> qemu-...@nongnu.org, "Laurent Vivier"
> Sent: Friday, May 31, 2019 3:16
- Original Message -
> From: "Alex Bennée"
> To: "Miroslav Rezanina"
> Cc: qemu-devel@nongnu.org, "Peter Maydell" , "Riku
> Voipio" ,
> qemu-...@nongnu.org, "Laurent Vivier"
> Sent: Friday, May 31, 2019 1:08
- Original Message -
> From: "Philippe Mathieu-Daudé"
> To: "Miroslav Rezanina" , "Alex Bennée"
>
> Cc: "Peter Maydell" , "Riku Voipio"
> , qemu-devel@nongnu.org,
> qemu-...@nongnu.org, "Laurent Vivier"
On Tue, May 14, 2019 at 04:52:56PM +0100, Alex Bennée wrote:
> Now we have a common semihosting console interface use that for our
> string output. However ARM is currently unique in also supporting
> semihosting for linux-user so we need to replicate the API in
> linux-user. If other
to
> create memfd
> FAIL
>
> There is a qemu_memfd_check() to prevent running memfd path, but it
> also checks for fallback implementation. Let's specialize
> qemu_memfd_check() to check memfd only, while qemu_memfd_alloc_check()
> checks for the qemu_memfd_alloc() API.
&g
<< shift;
> + *(U2 *)(d + i) = *(U2 *)(a + i) << shift;
> + *(U4 *)(d + i) = *(U4 *)(a + i) << shift;
> + *(U8 *)(d + i) = *(U8 *)(a + i) << shift;
> +}
> int main(void)
> {
>a1 += b1; a2 += b2; a4 += b4; a8 += b8;
> --
> 2.14.3
>
>
Build works correctly for RHEL 7 with this patch
Reviewed-by: Miroslav Rezanina <mreza...@redhat.com>
- Original Message -
> From: "Thomas Huth" <th...@redhat.com>
> To: "Laurent Vivier" <lviv...@redhat.com>, qemu-devel@nongnu.org
> Cc: "David Gibson" <da...@gibson.dropbear.id.au>, qemu-...@nongnu.org, "Dr .
> David
vel] [PATCH] Whitelist sysinfo call
>
> On Mon, Apr 11, 2016 at 08=19=52PM +, Serge Hallyn wrote:
> > Quoting mreza...@redhat.com (mreza...@redhat.com):
> > > From: Miroslav Rezanina <mreza...@redhat.com>
> > >
> > > Newer version of nss-softokn lib
r 07, 2016 at 10=34=46AM +0100, mreza...@redhat.com wrote:
> > From: Miroslav Rezanina <mreza...@redhat.com>
> >
> > Newer version of nss-softokn libraries (> 3.16.2.3) use sysinfo call
> > so qemu using rbd image hang after start when run in sandbox mode.
&
;
return -1;
}
snprintf(smb_conf, sizeof(smb_conf), %s/%s, s-smb_dir, smb.conf);
--
2.1.4
Reviewed-by: Miroslav Rezanina mreza...@redhat.com
not create samba server dir '%s', s-smb_dir);
return -1;
}
--
2.1.4
I suggest to go with this patch as:
1) It was sent first
2) Is simplier
3) Keep original behavior
Reviewed-by: Miroslav Rezanina mreza...@redhat.com
On Mon, Jun 01, 2015 at 09:58:10AM +0200, Markus Armbruster wrote:
mreza...@redhat.com writes:
From: Miroslav Rezanina mreza...@redhat.com
Qemu's user mode networking stack(-net user) is vulnerable to
a predictable temporary file creation flaw. This patch uses
mkdtemp(3) routine
On Wed, May 13, 2015 at 10:04:23AM +0200, Markus Armbruster wrote:
Paolo Bonzini pbonz...@redhat.com writes:
On 12/05/2015 08:22, mreza...@redhat.com wrote:
From: Miroslav Rezanina mreza...@redhat.com
mips build fail with link error in case PARALLEL_CONFIG is disabled as
hw/mips
On Wed, May 13, 2015 at 10:01:12AM +0200, Markus Armbruster wrote:
mreza...@redhat.com writes:
From: Miroslav Rezanina mreza...@redhat.com
Disabling CONFIG_PARALLEL cause removing parallel_hds_isa_init defined in
parallel.c. This function is called during initialization of some boards
On Mon, May 11, 2015 at 10:40:04AM +0200, Paolo Bonzini wrote:
On 11/05/2015 07:38, mreza...@redhat.com wrote:
From: Miroslav Rezanina mreza...@redhat.com
Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored
out initialization to parallel_hds_isa_init function
On Mon, May 11, 2015 at 08:46:19AM +0200, Markus Armbruster wrote:
mreza...@redhat.com writes:
From: Miroslav Rezanina mreza...@redhat.com
Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored
out initialization to parallel_hds_isa_init function in hw/char/parallel.c
On Tue, May 05, 2015 at 12:32:37PM +0200, Thomas Huth wrote:
On Tue, 5 May 2015 12:18:05 +0200
Miroslav Rezanina mreza...@redhat.com wrote:
On Tue, May 05, 2015 at 11:59:50AM +0200, Thomas Huth wrote:
On Tue, 5 May 2015 11:30:49 +0200
mreza...@redhat.com wrote:
From: Miroslav
On Tue, May 05, 2015 at 11:59:50AM +0200, Thomas Huth wrote:
On Tue, 5 May 2015 11:30:49 +0200
mreza...@redhat.com wrote:
From: Miroslav Rezanina mreza...@redhat.com
Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored
out initialization to parallel_hds_isa_init
On Mon, Feb 09, 2015 at 12:31:18PM +0100, Paolo Bonzini wrote:
On 09/02/2015 11:47, mreza...@redhat.com wrote:
From: Miroslav Rezanina mreza...@redhat.com
It was possible to call strcmp with NULL argument, that can cause
segmentation fault. Properly checking parameters to prevent
Hi,
is there any issue with this patch?
Mirek
- Original Message -
From: mreza...@redhat.com
To: qemu-devel@nongnu.org
Sent: Wednesday, February 5, 2014 2:44:23 PM
Subject: [Qemu-devel] [PATCH v6] vl.c: Output error on invalid machine type
From: Miroslav Rezanina mreza
- Original Message -
From: Fam Zheng f...@redhat.com
To: qemu-devel@nongnu.org
Cc: stefa...@redhat.com, kw...@redhat.com, Miroslav Rezanina
mreza...@redhat.com
Sent: Wednesday, November 13, 2013 5:04:18 AM
Subject: [PATCH] qemu-img: Fix content mismatch offset of image compare
We
? So -bt option is not useable without usb-bt-dongle?
cheers,
Gerd
--
Miroslav Rezanina
Software Engineer - Virtualization Team
usb-bt-dongle device can't be disabled as there's dependency in vl.c file. This
patch add preprocesor condition to be able to disable it.
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
---
hw/usb/Makefile.objs | 1 -
vl.c | 18 ++
2 files changed, 14
in ga_install_service() (Laszlo
Ersek)
--
Miroslav Rezanina
Software Engineer - Virtualization Team
Please ignore this serie. It's resended v10 instead of v11.
Sorry for spam.
- Original Message -
From: Miroslav Rezanina mreza...@redhat.com
To: qemu-devel@nongnu.org, qemu-devel@nongnu.org
Cc: kw...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com,
ebl...@redhat.com, Miroslav
number for output
v2:
- changed option for second image format to -F
- changed handling of -f and -F [1]
- added strict mode (-s)
- added quiet mode (-q)
- improved output messages [2]
- rename variables for larger image handling
- added man page content
Signed-off-by: Miroslav Rezanina mreza
There can be a need to turn output to stdout off. This patch adds a -q option
that enable Quiet mode. In Quiet mode, only errors are printed out.
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
---
block.c | 12 ++--
blockdev.c|6 +-
include/block/block.h
This patch adds new qemu-img subcommand that compares content of two disk
images.
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
---
qemu-img-cmds.hx |6 +
qemu-img.c | 290 +-
qemu-img.texi| 53 ++
3 files
There's no synchronous wrapper for bdrv_co_is_allocated_above function
so it's not possible to check for sector allocation in an image with
a backing file.
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
---
block.c | 39 +++
include/block
Simple test for qemu-img compare to check it's working correctly.
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
---
tests/qemu-iotests/048 | 78
tests/qemu-iotests/048.out | 31 +
tests/qemu-iotests/group |1 +
3
- Original Message -
From: Eric Blake ebl...@redhat.com
To: Miroslav Rezanina mreza...@redhat.com
Cc: qemu-devel@nongnu.org, kw...@redhat.com, pbonz...@redhat.com,
stefa...@redhat.com
Sent: Wednesday, February 13, 2013 2:39:59 PM
Subject: Re: [PATCH v11 3/4] qemu-img: Add compare
- Original Message -
From: Kevin Wolf kw...@redhat.com
To: Miroslav Rezanina mreza...@redhat.com
Cc: qemu-devel@nongnu.org, pbonz...@redhat.com, stefa...@redhat.com,
ebl...@redhat.com
Sent: Tuesday, February 12, 2013 10:36:07 AM
Subject: Re: [PATCH v10 3/4] This patch adds new qemu
There's no synchronous wrapper for bdrv_co_is_allocated_above function
so it's not possible to check for sector allocation in an image with
a backing file.
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
---
block.c | 39 +++
include/block
:
- changed option for second image format to -F
- changed handling of -f and -F [1]
- added strict mode (-s)
- added quiet mode (-q)
- improved output messages [2]
- rename variables for larger image handling
- added man page content
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
Miroslav
Simple test for qemu-img compare to check it's working correctly.
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
---
tests/qemu-iotests/048 | 77
tests/qemu-iotests/048.out | 25 ++
tests/qemu-iotests/group |1 +
3
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
---
qemu-img-cmds.hx |6 +
qemu-img.c | 290 +-
qemu-img.texi| 53 ++
3 files changed, 348 insertions(+), 1 deletions(-)
diff --git a/qemu-img-cmds.hx b/qemu-img
There can be a need to turn output to stdout off. This patch adds a -q option
that enable Quiet mode. In Quiet mode, only errors are printed out.
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
---
block.c | 12 ++--
blockdev.c|6 +-
include/block/block.h
Hi Eric,
- Original Message -
From: Eric Blake ebl...@redhat.com
To: Miroslav Rezanina mreza...@redhat.com
Cc: qemu-devel@nongnu.org, kw...@redhat.com, pbonz...@redhat.com,
stefa...@redhat.com
Sent: Friday, February 8, 2013 6:07:35 PM
Subject: Re: [PATCH 2/4] qemu-img: Add Quiet
- Original Message -
From: Eric Blake ebl...@redhat.com
To: Miroslav Rezanina mreza...@redhat.com
Cc: qemu-devel@nongnu.org, kw...@redhat.com, pbonz...@redhat.com,
stefa...@redhat.com
Sent: Friday, February 8, 2013 8:19:45 PM
Subject: Re: [PATCH 3/4] This patch adds new qemu-img
See response inline, if no response that comment will be handled in next
version.
- Original Message -
From: Kevin Wolf kw...@redhat.com
To: Miroslav Rezanina mreza...@redhat.com
Cc: qemu-devel@nongnu.org
Sent: Tuesday, January 29, 2013 12:28:22 PM
Subject: Re: [Qemu-devel] [PATCH
[1]
- added strict mode (-s)
- added quiet mode (-q)
- improved output messages [2]
- rename variables for larger image handling
- added man page content
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
Miroslav Rezanina (4):
block: Add synchronous wrapper for bdrv_co_is_allocated_above
There's no synchronous wrapper for bdrv_co_is_allocated_above function
so it's not possible to check for sector allocation in in mage with
a backing file.
This patch adds the missing synchronous wrapper.
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
---
block.c | 39
There can be a need to turn output to stdout off. This patch adds a -q option
that enable Quiet mode. In Quiet mode, only errors are printed out.
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
---
block.c | 12 +++--
blockdev.c|6 +-
include/block/block.h
This patch adds new qemu-img subcommand that compares content of two disk
images.
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
---
qemu-img-cmds.hx |6 ++
qemu-img.c | 266 ++
2 files changed, 272 insertions(+), 0 deletions
Adding documentation for new qemu-img subcommand compare.
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
---
qemu-img.c|7 ++-
qemu-img.texi | 32
2 files changed, 38 insertions(+), 1 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index
] [PATCH v7 2/4] qemu-img: Add Quiet mode option
On 12/17/2012 06:39 AM, mreza...@redhat.com wrote:
From: Miroslav Rezanina mreza...@redhat.com
Your git send-email settings threaded each message as a reply to the
other, rather than the more typical setting of threading messages
only
subcommand
On 12/17/2012 06:39 AM, mreza...@redhat.com wrote:
From: Miroslav Rezanina mreza...@redhat.com
This patch adds new qemu-img subcommand that compare content of two
disk
s/compare/compares/
images.
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
---
@@ -587,7
documentation
On 12/17/2012 06:39 AM, mreza...@redhat.com wrote:
From: Miroslav Rezanina mreza...@redhat.com
Adding documentation for new qemu-img subcommand compare.
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
---
qemu-img.c| 7 ++-
qemu-img.texi | 32
Hi Kevin,
thanks for review, comments inline.
- Original Message -
From: Kevin Wolf kw...@redhat.com
To: Miroslav Rezanina mreza...@redhat.com
Cc: qemu-devel@nongnu.org, Paolo Bonzini pbonz...@redhat.com, Stefan
Hajnoczi stefa...@redhat.com
Sent: Tuesday, December 11, 2012 1:27:45
:
- changed option for second image format to -F
- changed handling of -f and -F [1]
- added strict mode (-s)
- added quiet mode (-q)
- improved output messages [2]
- rename variables for larger image handling
- added man page content
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
diff
handling of -f and -F [1]
- added strict mode (-s)
- added quiet mode (-q)
- improved output messages [2]
- rename variables for larger image handling
- added man page content
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
Note: Do not move any code to separate function as suggested
handling
- added man page content
Signed-off-by: Miroslav Rezanina mreza...@redhat.com
diff --git a/block.c b/block.c
index 854ebd6..fdc8c45 100644
--- a/block.c
+++ b/block.c
@@ -2698,6 +2698,7 @@ int bdrv_has_zero_init(BlockDriverState *bs)
typedef struct BdrvCoIsAllocatedData
- changed handlig of -f and -F [1]
- added strict mode (-s)
- added quiet mode (-q)
- improved output messages [2]
- rename variables for larger image handling
- added man page content
Signed-off-by: Miroslav Rezanina
diff --git a/block.c b/block.c
index 854ebd6..fdc8c45 100644
--- a/block.c
+++ b
1 - 100 of 116 matches
Mail list logo
