Re: udp guestfwd

2023-12-08 Thread Patrick Venture
On Fri, Oct 27, 2023 at 11:44 PM Louai Al-Khanji wrote: > Hi, > > I'm interested in having the guestfwd option work for udp. My > understanding is that currently it's restricted to only tcp. > > I'm not familiar with libslirp internals. What would need to be changed to > implement this? I'm

Re: [PATCH 1/1] hw/i2c: add pca9543 i2c-mux switch

2023-12-05 Thread Patrick Venture
On Tue, Nov 14, 2023 at 3:30 PM Corey Minyard wrote: > On Mon, Nov 13, 2023 at 02:31:56PM +0800, Potin Lai wrote: > > Add pca9543 2-channel i2c-mux switch support. > > > > Signed-off-by: Potin Lai > > Looks good to me. > > Acked-by: Corey Minyard > > > --- > > hw/i2c/i2c_mux_pca954x.c

Re: [PATCH v2] system/memory: use ldn_he_p/stn_he_p

2023-12-04 Thread Patrick Venture
On Mon, Dec 4, 2023 at 3:24 AM Philippe Mathieu-Daudé wrote: > Hi Patrick, > > On 3/12/23 16:42, Patrick Venture wrote: > > > Friendly ping? Is this going to be applied or do I need to add another > > CC or? I do think it should go into stable. > > I'll send

Re: [PATCH v2] system/memory: use ldn_he_p/stn_he_p

2023-12-03 Thread Patrick Venture
On Fri, Nov 17, 2023 at 12:43 AM David Hildenbrand wrote: > On 16.11.23 17:36, Patrick Venture wrote: > > Using direct pointer dereferencing can allow for unaligned accesses, > > which was seen during execution with sanitizers enabled. > > > > Reviewed-by: Chris Ra

[PATCH v2] system/memory: use ldn_he_p/stn_he_p

2023-11-16 Thread Patrick Venture
Using direct pointer dereferencing can allow for unaligned accesses, which was seen during execution with sanitizers enabled. Reviewed-by: Chris Rauer Reviewed-by: Peter Foley Signed-off-by: Patrick Venture Cc: qemu-sta...@nongnu.org --- v2: changed commit mesage to be more accurate

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

2023-11-15 Thread Patrick Venture
On Wed, Nov 15, 2023 at 9:26 AM Patrick Venture wrote: > > > On Wed, Nov 15, 2023 at 9:02 AM Richard Henderson < > richard.hender...@linaro.org> wrote: > >> On 11/15/23 08:58, Patrick Venture wrote: >> > >> > >> > On Wed, Nov 15, 2023 at 2:35

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

2023-11-15 Thread Patrick Venture
On Wed, Nov 15, 2023 at 9:02 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/15/23 08:58, Patrick Venture wrote: > > > > > > On Wed, Nov 15, 2023 at 2:35 AM Peter Maydell > <mailto:peter.mayd...@linaro.org>> wrote: > > > >

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

2023-11-15 Thread Patrick Venture
On Wed, Nov 15, 2023 at 2:35 AM Peter Maydell wrote: > On Tue, 14 Nov 2023 at 20:55, Patrick Venture wrote: > > Avoids unaligned pointer issues. > > > > It would be nice to be more specific in the commit message here, by > describing what kind of guest behaviou

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

2023-11-15 Thread Patrick Venture
On Wed, Nov 15, 2023 at 2:30 AM Peter Maydell wrote: > On Tue, 14 Nov 2023 at 21:18, Richard Henderson > wrote: > > > > On 11/14/23 12:55, Patrick Venture wrote: > > > Avoids unaligned pointer issues. > > > > > > Reviewed-by: Chris Rauer >

Re: [PATCH 1/1] hw/i2c: add pca9543 i2c-mux switch

2023-11-14 Thread Patrick Venture
On Sun, Nov 12, 2023 at 10:34 PM Potin Lai wrote: > Add pca9543 2-channel i2c-mux switch support. > > Signed-off-by: Potin Lai > Reviewed-by: Patrick Venture > --- > hw/i2c/i2c_mux_pca954x.c | 12 > include/hw/i2c/i2c_mux_pca954x.h | 1 + &

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

2023-11-14 Thread Patrick Venture
On Tue, Nov 14, 2023 at 1:18 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/14/23 12:55, Patrick Venture wrote: > > Avoids unaligned pointer issues. > > > > Reviewed-by: Chris Rauer > > Reviewed-by: Peter Foley > > Signed-off-by

[PATCH] softmmu/memory: use memcpy for multi-byte accesses

2023-11-14 Thread Patrick Venture
Avoids unaligned pointer issues. Reviewed-by: Chris Rauer Reviewed-by: Peter Foley Signed-off-by: Patrick Venture --- system/memory.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/system/memory.c b/system/memory.c index 304fa843ea..02c97d5187 100644

Re: [PATCH RESEND v2] hw/i2c: Enable an id for the pca954x devices

2023-05-31 Thread Patrick Venture
On Wed, Mar 22, 2023 at 2:40 PM Philippe Mathieu-Daudé wrote: > On 22/3/23 22:19, Corey Minyard wrote: > > On Wed, Mar 22, 2023 at 10:21:36AM -0700, Patrick Venture wrote: > >> This allows the devices to be more readily found and specified. > >> Without setting th

Re: ssl fips self check fails with 7.2.0 on x86 TCG

2023-05-09 Thread Patrick Venture
On Tue, May 9, 2023 at 9:51 AM Michael Tokarev wrote: > 09.05.2023 17:39, Philippe Mathieu-Daudé пишет: > ..> Should be fixed in v7.2-stable: > > > > $ git log --oneline --grep=1d0b9261 v7.2.2 > > c45d10f655 target/i386: fix ADOX followed by ADCX > > 6809dbc5c5 target/i386: Fix C flag for BLSI,

Re: ssl fips self check fails with 7.2.0 on x86 TCG

2023-05-08 Thread Patrick Venture
Verified it was https://gitlab.com/qemu-project/qemu/-/issues/1471 On Thu, May 4, 2023 at 12:03 PM Patrick Venture wrote: > Hi, > > I just finished rebasing my team onto 7.2.0 and now I'm seeing > https://boringssl.googlesource.com/boringssl/+/master/crypto/fipsmodule/self_check/

ssl fips self check fails with 7.2.0 on x86 TCG

2023-05-04 Thread Patrick Venture
Hi, I just finished rebasing my team onto 7.2.0 and now I'm seeing https://boringssl.googlesource.com/boringssl/+/master/crypto/fipsmodule/self_check/self_check.c#361 fail. I applied https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00260.html and it's still failing. Is anyone else

Re: [PATCH v2] hw/net: npcm7xx_emc: set MAC in register space

2023-04-25 Thread Patrick Venture
On Thu, Oct 6, 2022 at 6:18 AM Peter Maydell wrote: > On Mon, 3 Oct 2022 at 18:38, Patrick Venture wrote: > > > > The MAC address set from Qemu wasn't being saved into the register space. > > > > Reviewed-by: Hao Wu > > Signed-off-by: Patrick Venture >

[PATCH] hw/arm/virt: support both pl011 and 16550 uart

2023-03-22 Thread Patrick Venture
From: Shu-Chun Weng Select uart for virt machine from pl011 and ns16550a with -M virt,uart={pl011|ns16550a}. Signed-off-by: Shu-Chun Weng Signed-off-by: Patrick Venture --- hw/arm/virt.c | 85 ++- include/hw/arm/virt.h | 6 +++ 2 files changed

[PATCH RESEND v2] hw/i2c: Enable an id for the pca954x devices

2023-03-22 Thread Patrick Venture
'pca954x[77]', for an instance attached at that address. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Philippe Mathieu-Daudé --- v2: s/id/name/g to use name as the identifier field. left 'id' in subject for email chain. --- hw/i2c/i2c_mux_pca954x.c | 22 ++ 1

Re: [PATCH RESEND] hw/i2c: Enable an id for the pca954x devices

2023-03-22 Thread Patrick Venture
On Tue, Mar 21, 2023 at 6:41 PM Corey Minyard wrote: > On Tue, Mar 21, 2023 at 11:27:44AM -0700, Patrick Venture wrote: > > This allows the devices to be more readily found and specified. > > Without setting the id field, they can only be found by device type > > name,

[PATCH RESEND] hw/i2c: Enable an id for the pca954x devices

2023-03-21 Thread Patrick Venture
]', for an instance attached at that address. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Philippe Mathieu-Daud?? --- hw/i2c/i2c_mux_pca954x.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/hw/i2c/i2c_mux_pca954x.c b/hw/i2c/i2c_mux_pca954x.c

qtest failure mode

2022-11-17 Thread Patrick Venture
Hi; Recently I was debugging why a patch broke all my qtests, and the issue it turns out was that qemu was dying in runtime. The qtests complaint was that the assertion failure on not having valid sockets. I was curious if anyone else has experienced this, and if there's a plan (or a different

Re: Weird qtest FileNotFoundError errors

2022-11-09 Thread Patrick Venture
On Wed, Nov 9, 2022 at 11:20 AM Patrick Venture wrote: > Hi all, > > I've been trying to debug qtest problems recently. I have seen the assert > socket failures a bunch now and am digging into why. I've also seen this a > lot and I'm curious if anyone has any ideas: > >

Weird qtest FileNotFoundError errors

2022-11-09 Thread Patrick Venture
Hi all, I've been trying to debug qtest problems recently. I have seen the assert socket failures a bunch now and am digging into why. I've also seen this a lot and I'm curious if anyone has any ideas: ./configure --target-list=aarch64-softmmu,aarch64-linux-user make -i

[PATCH RESEND] hw/i2c: Enable an id for the pca954x devices

2022-10-11 Thread Patrick Venture
]', for an instance attached at that address. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/i2c/i2c_mux_pca954x.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/hw/i2c/i2c_mux_pca954x.c b/hw/i2c/i2c_mux_pca954x.c index a9517b612a..4f8c2d6ae1 100644

Re: [PATCH] tests/qtest: npcm7xx-emc-test: Skip checking MAC

2022-10-06 Thread Patrick Venture
On Thu, Oct 6, 2022 at 10:58 AM Patrick Venture wrote: > > > On Tue, Sep 20, 2022 at 12:00 AM Thomas Huth wrote: > >> On 20/09/2022 00.37, Patrick Venture wrote: >> > >> > >> > On Mon, Sep 19, 2022 at 5:44 AM Thomas Huth > > <mailto:th...

Re: [PATCH] tests/qtest: npcm7xx-emc-test: Skip checking MAC

2022-10-06 Thread Patrick Venture
On Tue, Sep 20, 2022 at 12:00 AM Thomas Huth wrote: > On 20/09/2022 00.37, Patrick Venture wrote: > > > > > > On Mon, Sep 19, 2022 at 5:44 AM Thomas Huth > <mailto:th...@redhat.com>> wrote: > > > > On 06/09/2022 18.31, Patrick Venture w

[PATCH v2] hw/net: npcm7xx_emc: set MAC in register space

2022-10-03 Thread Patrick Venture
The MAC address set from Qemu wasn't being saved into the register space. Reviewed-by: Hao Wu Signed-off-by: Patrick Venture --- v2: only set the registers from qemu on reset once registers set, only read and write to them --- hw/net/npcm7xx_emc.c | 30 +++--- 1

Re: [PATCH] hw/net: npcm7xx_emc: set MAC in register space

2022-09-29 Thread Patrick Venture
On Thu, Sep 29, 2022 at 8:54 AM Peter Maydell wrote: > On Thu, 29 Sept 2022 at 16:28, Patrick Venture wrote: > > On Mon, Sep 26, 2022 at 8:45 AM Patrick Venture > wrote: > >>> I think what Jason is suggesting is that that should depend on what > >>> the rea

Re: [PATCH] hw/net: npcm7xx_emc: set MAC in register space

2022-09-29 Thread Patrick Venture
On Mon, Sep 26, 2022 at 8:45 AM Patrick Venture wrote: > > > On Sat, Sep 24, 2022 at 2:10 AM Peter Maydell > wrote: > >> On Sat, 24 Sept 2022 at 00:42, Patrick Venture >> wrote: >> > On Thu, Sep 22, 2022 at 8:21 PM Jason Wang wrote: >> >> >

Re: [PATCH] hw/net: npcm7xx_emc: set MAC in register space

2022-09-26 Thread Patrick Venture
On Sat, Sep 24, 2022 at 2:10 AM Peter Maydell wrote: > On Sat, 24 Sept 2022 at 00:42, Patrick Venture wrote: > > On Thu, Sep 22, 2022 at 8:21 PM Jason Wang wrote: > >> > >> On Thu, Sep 22, 2022 at 8:35 PM Peter Maydell > wrote: > >> > A question to w

Re: [PATCH] hw/net: npcm7xx_emc: set MAC in register space

2022-09-23 Thread Patrick Venture
On Thu, Sep 22, 2022 at 8:21 PM Jason Wang wrote: > On Thu, Sep 22, 2022 at 8:35 PM Peter Maydell > wrote: > > > > On Thu, 22 Sept 2022 at 00:47, Patrick Venture > wrote: > > > > > > The MAC address set from Qemu wasn't being saved into the register &

[PATCH] hw/net: npcm7xx_emc: set MAC in register space

2022-09-21 Thread Patrick Venture
The MAC address set from Qemu wasn't being saved into the register space. Reviewed-by: Hao Wu Signed-off-by: Patrick Venture --- hw/net/npcm7xx_emc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/net/npcm7xx_emc.c b/hw/net/npcm7xx_emc.c index 7c86bb52e5..6be1008529

Re: [PATCH] tests/qtest: npcm7xx-emc-test: Skip checking MAC

2022-09-19 Thread Patrick Venture
On Mon, Sep 19, 2022 at 5:44 AM Thomas Huth wrote: > On 06/09/2022 18.31, Patrick Venture wrote: > > The register tests walks all the registers to verify they are initially > > 0 when appropriate. However, if the MAC address is set in the register > >space, this

Re: Seeing qtest assertion failure with 7.1

2022-09-08 Thread Patrick Venture
On Wed, Sep 7, 2022 at 10:40 AM Peter Maydell wrote: > On Wed, 7 Sept 2022 at 16:39, Patrick Venture wrote: > > > > # Start of nvme tests > > # Start of pci-device tests > > # Start of pci-device-tests tests > > # starting QEMU: exec ./qemu-system-aarch64 -

Re: [PATCH] crypto/block-luks: always set splitkeylen to 0

2022-09-07 Thread Patrick Venture
On Wed, Sep 7, 2022 at 9:34 AM Daniel P. Berrangé wrote: > On Wed, Sep 07, 2022 at 09:21:25AM -0700, Patrick Venture wrote: > > This was caught by a sanitized build, that was perhaps oversensitive. > > > > Signed-off-by: Patrick Venture > > --- > > crypto/bl

[PATCH] crypto/block-luks: always set splitkeylen to 0

2022-09-07 Thread Patrick Venture
This was caught by a sanitized build, that was perhaps oversensitive. Signed-off-by: Patrick Venture --- crypto/block-luks.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/block-luks.c b/crypto/block-luks.c index f62be6836b..8633fb7e9f 100644 --- a/crypto/block

Seeing qtest assertion failure with 7.1

2022-09-07 Thread Patrick Venture
# Start of nvme tests # Start of pci-device tests # Start of pci-device-tests tests # starting QEMU: exec ./qemu-system-aarch64 -qtest unix:/tmp/qtest-1431.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-1431.qmp,id=char0 -mon chardev=char0,mode=control -display none -M virt, -cpu max

[PATCH] tests/qtest: npcm7xx-emc-test: Skip checking MAC

2022-09-06 Thread Patrick Venture
The register tests walks all the registers to verify they are initially 0 when appropriate. However, if the MAC address is set in the register space, this should not be checked against 0. Reviewed-by: Hao Wu Change-Id: I02426e39bdab33ceedd42c49d233e8680d4ec058 Signed-off-by: Patrick Venture

[PATCH v2] hw/nvram: Add at24c-eeprom support for small eeproms

2022-07-11 Thread Patrick Venture
Tested: Verified at24c02 driver happy and contents matched expectations. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- v2: Added comment describing the new behavior. --- hw/nvram/eeprom_at24c.c | 56 - 1 file changed, 39 insertions(+), 17

Re: [PATCH 1/8] hw/i2c/pca954x: Add method to get channels

2022-07-06 Thread Patrick Venture
> > > > https://github.com/torvalds/linux/blob/40cb6373b46/arch/arm/boot/dts/aspeed-bmc-facebook-fuji.dts > > > > Signed-off-by: Peter Delevoryas > > Reviewed-by: Cédric Le Goater > Reviewed-by: Patrick Venture > > Thanks, > > Neato :) > C. > >

Re: [PATCH v2 09/13] hw/i2c/pmbus: Add read-only IC_DEVICE_ID support

2022-06-30 Thread Patrick Venture
On Wed, Jun 29, 2022 at 11:34 AM Peter Delevoryas wrote: > > > > On Jun 29, 2022, at 11:04 AM, Titus Rwantare wrote: > > > > On Tue, 28 Jun 2022 at 20:36, Peter Delevoryas > > wrote: > >> > >> Signed-off-by: Peter Delevoryas > >> --- > > > >> --- a/hw/i2c/pmbus_device.c > >> +++

Re: [PATCH 3/9] hw/arm/aspeed: qcom-dc-scm-v1: add block backed FRU device

2022-06-23 Thread Patrick Venture
On Thu, Jun 23, 2022 at 10:16 AM Cédric Le Goater wrote: > On 6/23/22 17:28, Patrick Venture wrote: > > > > > > On Wed, Jun 22, 2022 at 10:48 AM Jae Hyun Yoo <mailto:quic_jaeh...@quicinc.com>> wrote: > > > > From: Graeme Gregory quic_ggreg...@qui

Re: [PATCH 3/9] hw/arm/aspeed: qcom-dc-scm-v1: add block backed FRU device

2022-06-23 Thread Patrick Venture
On Wed, Jun 22, 2022 at 10:48 AM Jae Hyun Yoo wrote: > From: Graeme Gregory > > The FRU device uses the index 0 device on bus IF_NONE. > > -drive file=$FRU,format=raw,if=none > > file must match FRU size of 128k > > Signed-off-by: Graeme Gregory > --- > hw/arm/aspeed.c | 22

Re: misaligned-pointer-use libslirp/src/tcp_input.c

2022-06-21 Thread Patrick Venture
6 > resolved the failure we were seeing in our internal test-case. > Thanks! > Thanks for posting the resolution commits! > > On Tue, Jun 21, 2022 at 12:47 PM Patrick Venture > wrote: > >> >> >> On Fri, Jun 17, 2022 at 7:37 AM Alexander Bulekov wrote: >> &

Re: misaligned-pointer-use libslirp/src/tcp_input.c

2022-06-21 Thread Patrick Venture
On Fri, Jun 17, 2022 at 7:37 AM Alexander Bulekov wrote: > On 220617 1217, Thomas Huth wrote: > > On 16/06/2022 21.03, Alexander Bulekov wrote: > > > On 220616 0930, Patrick Venture wrote: > > > > On Thu, Jun 16, 2022 at 6:31 AM Alexander Bulekov > wrote: >

Re: misaligned-pointer-use libslirp/src/tcp_input.c

2022-06-16 Thread Patrick Venture
Alex > > On 220615 0942, Patrick Venture wrote: > > Hey - I wanted to ask if someone else has seen this or has suggestions on > > how to fix it in libslirp / qemu. > > > > libslirp version: 3ad1710a96678fe79066b1469cead4058713a1d9 > > > > The blow is line

misaligned-pointer-use libslirp/src/tcp_input.c

2022-06-15 Thread Patrick Venture
Hey - I wanted to ask if someone else has seen this or has suggestions on how to fix it in libslirp / qemu. libslirp version: 3ad1710a96678fe79066b1469cead4058713a1d9 The blow is line: https://gitlab.freedesktop.org/slirp/libslirp/-/blob/master/src/tcp_input.c#L310 I0614 13:44:44.3040872040

Re: [PATCH v5] tests/qtest: add qtests for npcm7xx sdhci

2022-05-26 Thread Patrick Venture
On Thu, May 26, 2022 at 8:54 AM Peter Maydell wrote: > On Fri, 25 Feb 2022 at 17:45, Hao Wu wrote: > > > > From: Shengtan Mao > > > > Reviewed-by: Hao Wu > > Reviewed-by: Chris Rauer > > Signed-off-by: Shengtan Mao > > Signed-off-by

Npcm7xx emac tap networking hitting 75MiB limit

2022-05-23 Thread Patrick Venture
Hey; I wanted to ask if anyone has seen this before. When we try to download a file larger than 75MB from within an Ncpm7xx board using TAP networking (versus user) it just fails there. using wget it reports null 75.0M - stalled -\rnull 75.0M - stalled -\rnull

Re: [PATCH 1/2] hw/misc: Add Nuvoton's PCI Mailbox Module

2022-04-11 Thread Patrick Venture
On Thu, Jan 27, 2022 at 1:27 PM Patrick Venture wrote: > > > On Thu, Jan 27, 2022 at 10:37 AM Peter Maydell > wrote: > >> On Mon, 10 Jan 2022 at 17:56, Patrick Venture wrote: >> > >> > From: Hao Wu >> > >> > The PCI Mailbox Module is a

Re: [PATCH v1 8/9] aspeed: Add an AST1030 eval board

2022-03-23 Thread Patrick Venture
On Mon, Mar 21, 2022 at 7:59 PM Jamin Lin wrote: > From: Steven Lee > > The image should be supplied with ELF binary. > $ qemu-system-arm -M ast1030-evb -kernel zephyr.elf -nographic > > Signed-off-by: Troy Lee > Signed-off-by: Jamin Lin > Signed-off-by: Steven Lee

[PATCH] hw/i2c: Enable an id for the pca954x devices

2022-03-17 Thread Patrick Venture
]', for an instance attached at that address. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/i2c/i2c_mux_pca954x.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/hw/i2c/i2c_mux_pca954x.c b/hw/i2c/i2c_mux_pca954x.c index a9517b612a..4f8c2d6ae1 100644

Lost patch, hw/sensor: enable adm1272 temp with qmp

2022-03-14 Thread Patrick Venture
I'm going through my team's spreadsheet for our upstreaming efforts to try to make sure things weren't lost, as sometimes a reply will go into my spam folder, and I saw this patch also fell under the radar: https://lists.gnu.org/archive/html/qemu-devel/2022-01/msg01310.html If you want, I can

[PATCH] hw/nvram: Add at24c-eeprom support for small eeproms

2022-03-14 Thread Patrick Venture
Tested: Verified at24c02 driver happy and contents matched expectations. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/nvram/eeprom_at24c.c | 52 +++-- 1 file changed, 35 insertions(+), 17 deletions(-) diff --git a/hw/nvram/eeprom_at24c.c b/hw

Re: [PATCH] hw/nvram: Add at24c-eeprom support for small eeproms

2022-03-14 Thread Patrick Venture
On Mon, Mar 14, 2022 at 2:12 PM Patrick Venture wrote: > Tested: Verified at24c02 driver happy and contents matched > expectations. > > Signed-off-by: Patrick Venture > Reviewed-by: Hao Wu > --- > hw/nvram/eeprom_at24c.c | 52 +++--

[PATCH] linux-user: Fix missing space in error message

2022-03-10 Thread Patrick Venture
From: Fergus Henderson Signed-off-by: Fergus Henderson Signed-off-by: Patrick Venture --- linux-user/elfload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 9628a38361..c45da4d633 100644 --- a/linux-user/elfload.c +++ b

Re: Lost patch

2022-03-09 Thread Patrick Venture
On Wed, Mar 9, 2022 at 4:16 PM Philippe Mathieu-Daudé < philippe.mathieu.da...@gmail.com> wrote: > On 10/3/22 00:12, Patrick Venture wrote: > > Corey and Peter; > > > > I was about to submit a fix to the at24c-eeprom device and noticed that > > my v2 patch

Lost patch

2022-03-09 Thread Patrick Venture
Corey and Peter; I was about to submit a fix to the at24c-eeprom device and noticed that my v2 patch appears to have been lost to time. Is there any way we can get this pulled into 7.0? https://lists.gnu.org/archive/html/qemu-devel/2021-12/msg03485.html Thanks, Patrick

Re: [PATCH v4] tests/qtest: add qtests for npcm7xx sdhci

2022-02-25 Thread Patrick Venture
gt;> > Reviewed-by: Hao Wu >> > Reviewed-by: Chris Rauer >> > Signed-off-by: Shengtan Mao >> > Signed-off-by: Patrick Venture >> > Signed-off-by: Hao Wu >> > --- >> > v4: >> > * use strncmp to compare fixed length strings >>

Re: [PATCH 0/5] Fixups for PMBus and new sensors

2022-02-24 Thread Patrick Venture
On Thu, Jan 6, 2022 at 3:09 PM Titus Rwantare wrote: > This patch series contains updates to PMBus in QEMU along with some PMBus > device models for Renesas regulators. > I have also added myself to MAINTAINERS as this code is in use daily, > where I am responsible for it. > > Shengtan Mao (1):

Re: [PATCH v2] hw/i2c: flatten pca954x mux device

2022-02-24 Thread Patrick Venture
On Thu, Feb 24, 2022 at 2:56 AM Peter Maydell wrote: > On Wed, 2 Feb 2022 at 17:57, Patrick Venture wrote: > > > > Previously this device created N subdevices which each owned an i2c bus. > > Now this device simply owns the N i2c busses directly. > > > > Te

Re: [PATCH v3] tests/qtest: add qtests for npcm7xx sdhci

2022-02-22 Thread Patrick Venture
On Mon, Feb 21, 2022 at 5:30 AM Peter Maydell wrote: > On Wed, 16 Feb 2022 at 17:30, Peter Maydell > wrote: > > > > On Tue, 8 Feb 2022 at 18:18, Patrick Venture wrote: > > > > > > From: Shengtan Mao > > > > > > Reviewed-by: Hao Wu > &g

at24c* device

2022-02-19 Thread Patrick Venture
Philippe; Looking at the at24c device, it doesn't support the c02 and other 1-byte addressable eeproms that are supported by the at24c driver in linux, and other compatible eeproms. If I recall correctly, the smbus-eeprom device correctly handles the 1-byte addressable variants, and so maybe

[PATCH] hw/arm: add initial mori-bmc board

2022-02-08 Thread Patrick Venture
This is the BMC attached to the OpenBMC Mori board. Signed-off-by: Patrick Venture Reviewed-by: Chris Rauer Reviewed-by: Ilkyun Choi --- docs/system/arm/nuvoton.rst | 1 + hw/arm/npcm7xx_boards.c | 32 2 files changed, 33 insertions(+) diff --git a/docs

[PATCH v3] tests/qtest: add qtests for npcm7xx sdhci

2022-02-08 Thread Patrick Venture
From: Shengtan Mao Reviewed-by: Hao Wu Reviewed-by: Chris Rauer Signed-off-by: Shengtan Mao Signed-off-by: Patrick Venture --- v3: * fixup compilation from missing macro value v2: * update copyright year * check result of open * use g_free instead of free * move declarations to the top

Re: [PATCH v2] tests/qtest: add qtests for npcm7xx sdhci

2022-02-08 Thread Patrick Venture
On Mon, Feb 7, 2022 at 3:07 PM Patrick Venture wrote: > > > On Mon, Feb 7, 2022 at 9:34 AM Peter Maydell > wrote: > >> On Sun, 6 Feb 2022 at 01:41, Patrick Venture wrote: >> > >> > From: Shengtan Mao >> > >> > Reviewed-by: Hao Wu &g

Re: [PATCH v2] tests/qtest: add qtests for npcm7xx sdhci

2022-02-07 Thread Patrick Venture
On Mon, Feb 7, 2022 at 9:34 AM Peter Maydell wrote: > On Sun, 6 Feb 2022 at 01:41, Patrick Venture wrote: > > > > From: Shengtan Mao > > > > Reviewed-by: Hao Wu > > Reviewed-by: Chris Rauer > > Signed-off-by: Shengtan Mao > > Signed-off-by: P

[PATCH v2] tests/qtest: add qtests for npcm7xx sdhci

2022-02-05 Thread Patrick Venture
From: Shengtan Mao Reviewed-by: Hao Wu Reviewed-by: Chris Rauer Signed-off-by: Shengtan Mao Signed-off-by: Patrick Venture --- v2: * update copyright year * check result of open * use g_free instead of free * move declarations to the top * use g_file_open_tmp --- tests/qtest

Re: [PATCH] hw/i2c: flatten pca954x mux device

2022-02-02 Thread Patrick Venture
On Wed, Feb 2, 2022 at 9:31 AM Philippe Mathieu-Daudé wrote: > On 2/2/22 17:40, Patrick Venture wrote: > > > Philippe, > > > > I0202 08:29:45.380384 6641 stream.go:31] qemu: child buses at > > "pca9546": "channel[*]", "cha

Re: [PATCH] hw/i2c: flatten pca954x mux device

2022-02-02 Thread Patrick Venture
On Wed, Feb 2, 2022 at 11:01 AM Peter Maydell wrote: > On Wed, 2 Feb 2022 at 17:36, Patrick Venture wrote: > > Just saw your reply, and found a bunch of other non-spam in my > > spam folder. I sent the message to the anti-spam team, hopefully > > that'll resolve this for

Re: [PATCH] hw/i2c: flatten pca954x mux device

2022-02-02 Thread Patrick Venture
On Tue, Feb 1, 2022 at 12:54 PM Patrick Venture wrote: > > > On Tue, Feb 1, 2022 at 11:02 AM Philippe Mathieu-Daudé > wrote: > >> On 1/2/22 17:30, Patrick Venture wrote: >> > Previously this device created N subdevices which each owned an i2c bus. >> >

[PATCH v2] hw/i2c: flatten pca954x mux device

2022-02-02 Thread Patrick Venture
Previously this device created N subdevices which each owned an i2c bus. Now this device simply owns the N i2c busses directly. Tested: Verified devices behind mux are still accessible via qmp and i2c from within an arm32 SoC. Reviewed-by: Hao Wu Signed-off-by: Patrick Venture Reviewed

Re: [PATCH] hw/i2c: flatten pca954x mux device

2022-02-02 Thread Patrick Venture
On Wed, Feb 2, 2022 at 8:34 AM Patrick Venture wrote: > > > On Tue, Feb 1, 2022 at 12:54 PM Patrick Venture > wrote: > >> >> >> On Tue, Feb 1, 2022 at 11:02 AM Philippe Mathieu-Daudé >> wrote: >> >>> On 1/2/22 17:30, Patrick Venture wr

Re: [PATCH] hw/i2c: flatten pca954x mux device

2022-02-01 Thread Patrick Venture
On Tue, Feb 1, 2022 at 11:02 AM Philippe Mathieu-Daudé wrote: > On 1/2/22 17:30, Patrick Venture wrote: > > Previously this device created N subdevices which each owned an i2c bus. > > Now this device simply owns the N i2c busses directly. > > > > Tested: Verified d

[PATCH] hw/i2c: flatten pca954x mux device

2022-02-01 Thread Patrick Venture
Previously this device created N subdevices which each owned an i2c bus. Now this device simply owns the N i2c busses directly. Tested: Verified devices behind mux are still accessible via qmp and i2c from within an arm32 SoC. Reviewed-by: Hao Wu Signed-off-by: Patrick Venture --- hw/i2c

[PATCH v4 1/2] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-31 Thread Patrick Venture
with the open-source data sheet from AMD and Linux kernel driver. Reference: Linux kernel driver: https://lkml.org/lkml/2020/12/11/968 Register Map: https://developer.amd.com/wp-content/resources/56255_3_03.PDF (Chapter 6) Signed-off-by: Hao Wu Signed-off-by: Patrick Venture Reviewed-by: Doug Evans

[PATCH v4 0/2] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-31 Thread Patrick Venture
v4: * Added missing signature block from submitter. v3: * typofix where I accidentally embedded 'wq' into a string * moved the type sbtsi definition back into the source file * renamed the qtest file to use hyphens only v2: * Split the commit into a separate patch for the qtest * Moved the

[PATCH v4 2/2] tests: add qtest for hw/sensor/sbtsi

2022-01-31 Thread Patrick Venture
From: Hao Wu Reviewed-by: Doug Evans Signed-off-by: Hao Wu Signed-off-by: Patrick Venture Acked-by: Thomas Huth --- tests/qtest/tmp-sbtsi-test.c | 161 +++ tests/qtest/meson.build | 1 + 2 files changed, 162 insertions(+) create mode 100644 tests

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-27 Thread Patrick Venture
already according to the datasheet. > >> Thanks, >> >> -corey >> >> I have to send out a new patchset to include my signature block since I'm sending a patch Hao wrote. Laurent pointed this out to me in a different patch series. >From this exchange, I don't think

Re: [PATCH 1/2] hw/misc: Add Nuvoton's PCI Mailbox Module

2022-01-27 Thread Patrick Venture
On Thu, Jan 27, 2022 at 10:37 AM Peter Maydell wrote: > On Mon, 10 Jan 2022 at 17:56, Patrick Venture wrote: > > > > From: Hao Wu > > > > The PCI Mailbox Module is a high-bandwidth communcation module > > between a Nuvoton BMC and CPU. It features 16KB

[PATCH v3 0/2] linux-user: check read permissions before how

2022-01-26 Thread Patrick Venture
Patrick Venture (1): linux-user: sigprocmask check read perms first Shu-Chun Weng (1): linux-user: rt_sigprocmask, check read perms first linux-user/syscall.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) -- 2.35.0.rc0.227.g00780c9af4-goog

[PATCH v3 1/2] linux-user: rt_sigprocmask, check read perms first

2022-01-26 Thread Patrick Venture
Reviewed-by: Patrick Venture Signed-off-by: Shu-Chun Weng Reviewed-by: Laurent Vivier Signed-off-by: Patrick Venture --- linux-user/syscall.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 5950222a77..34bd819e38

[PATCH v3 2/2] linux-user: sigprocmask check read perms first

2022-01-26 Thread Patrick Venture
Linux kernel now checks the read permissions before validating `how` Suggested-by: Laurent Vivier Signed-off-by: Patrick Venture Reviewed-by: Laurent Vivier --- linux-user/syscall.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/linux-user/syscall.c b/linux

Re: [PATCH v2 1/2] linux-user: rt_sigprocmask, check read perms first

2022-01-26 Thread Patrick Venture
On Wed, Jan 26, 2022 at 11:26 AM Laurent Vivier wrote: > Le 26/01/2022 à 18:58, Patrick Venture a écrit : > > From: Shu-Chun Weng > > > > Linux kernel does it this way (checks read permission before validating > `how`) > > and the latest version of ABSL's

[PATCH v2 2/2] linux-user: sigprocmask check read perms first

2022-01-26 Thread Patrick Venture
Linux kernel now checks the read permissions before validating `how` Suggested-by: Laurent Vivier Signed-off-by: Patrick Venture --- linux-user/syscall.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index

[PATCH v2 1/2] linux-user: rt_sigprocmask, check read perms first

2022-01-26 Thread Patrick Venture
Reviewed-by: Patrick Venture Signed-off-by: Shu-Chun Weng --- linux-user/syscall.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 5950222a77..34bd819e38 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c

[PATCH v2 0/2] linux-user: check read permissions before how

2022-01-26 Thread Patrick Venture
In sigprocmask check the read permissions first before checking the `how`. This is done for both: TARGET_NR_sigprocmask and TARGET_NR_rt_sigprocmask v2: * Update code style during code change * Also update check order for TARGET_NR_sigprocmask Patrick Venture (1): linux-user: sigprocmask

Re: [PATCH] linux-user: rt_sigprocmask, check read perms first

2022-01-26 Thread Patrick Venture
On Tue, Jan 11, 2022 at 3:06 PM Patrick Venture wrote: > > > On Tue, Jan 11, 2022 at 12:50 PM Laurent Vivier wrote: > >> Hi Patrick, >> >> Le 11/01/2022 à 21:14, Patrick Venture a écrit : >> > >> > >> > On Sat, Jan 8, 2022 at 10

Re: [PATCH v2] hw/smbios: Add table 4 parameter, "processor-id"

2022-01-25 Thread Patrick Venture
On Tue, Jan 25, 2022 at 5:35 AM Igor Mammedov wrote: > On Mon, 24 Jan 2022 12:11:51 -0800 > Patrick Venture wrote: > > > This parameter is to be used in the processor_id lower 32-bit entry in > > the type 4 table. The upper 32-bits represent the features for the CPU.

[PATCH v3] hw/smbios: Add table 4 parameter, "processor-id"

2022-01-25 Thread Patrick Venture
concerns. Reviewed-by: Peter Foley Reviewed-by: Titus Rwantare Signed-off-by: Patrick Venture Reviewed-by: Igor Mammedov --- v3: updated commit message to match v2 v2: Added to SRST options list, upgraded to full 64-bit value. --- hw/smbios/smbios.c | 19 --- qemu-options.hx

[PATCH v2] hw/smbios: Add table 4 parameter, "processor-id"

2022-01-24 Thread Patrick Venture
. This enables hiding the host information from the guest and allowing AMD VMs to run pretending to be Intel for some userspace software concerns. Reviewed-by: Peter Foley Reviewed-by: Titus Rwantare Signed-off-by: Patrick Venture --- v2: Added to SRST options list, upgraded to full 64-bit value

Re: [PATCH] hw/smbios: Add table 4 parameter, "processor-id"

2022-01-24 Thread Patrick Venture
On Tue, Jan 18, 2022 at 11:37 PM Igor Mammedov wrote: > On Tue, 18 Jan 2022 09:15:42 -0800 > Patrick Venture wrote: > > > On Tue, Jan 11, 2022 at 5:13 AM Igor Mammedov > wrote: > > > > > On Thu, 6 Jan 2022 14:33:16 -0800 > > > Patrick Venture wrot

Re: [PATCH] hw/nvram: use at24 macro

2022-01-24 Thread Patrick Venture
On Wed, Jan 19, 2022 at 1:43 PM Patrick Venture wrote: > Use the macro for going from I2CSlave to EEPROMState. > > Signed-off-by: Patrick Venture > --- > hw/nvram/eeprom_at24c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/nvram/e

[PATCH] hw/nvram: use at24 macro

2022-01-19 Thread Patrick Venture
Use the macro for going from I2CSlave to EEPROMState. Signed-off-by: Patrick Venture --- hw/nvram/eeprom_at24c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c index af6f5dbb99..da435500ba 100644 --- a/hw/nvram

Re: [PATCH] hw/smbios: Add table 4 parameter, "processor-id"

2022-01-18 Thread Patrick Venture
On Tue, Jan 11, 2022 at 5:13 AM Igor Mammedov wrote: > On Thu, 6 Jan 2022 14:33:16 -0800 > Patrick Venture wrote: > > > This parameter is to be used in the processor_id lower 32-bit entry in > > I'd call it processor_id_lo throughout the patch > or if you prefer to keep

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-18 Thread Patrick Venture
On Mon, Jan 17, 2022 at 6:05 AM Corey Minyard wrote: > On Sun, Jan 09, 2022 at 06:17:34PM -0800, Patrick Venture wrote: > > On Fri, Jan 7, 2022 at 7:04 PM Patrick Venture > wrote: > > > > > From: Hao Wu > > > > > > SB Temperature Sensor Interface (S

[PATCH v3 2/2] tests: add qtest for hw/sensor/sbtsi

2022-01-13 Thread Patrick Venture
From: Hao Wu Reviewed-by: Doug Evans Signed-off-by: Hao Wu Signed-off-by: Patrick Venture Acked-by: Thomas Huth --- tests/qtest/tmp-sbtsi-test.c | 161 +++ tests/qtest/meson.build | 1 + 2 files changed, 162 insertions(+) create mode 100644 tests

[PATCH v3 1/2] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-13 Thread Patrick Venture
From: Hao Wu SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible interface that reports AMD SoC's Ttcl (normalized temperature), and resembles a typical 8-pin remote temperature sensor's I2C interface to BMC. This patch implements a basic AMD SB-TSI sensor that is compatible with

[PATCH v3 0/2] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-13 Thread Patrick Venture
v3: * typofix where I accidentally embedded 'wq' into a string * moved the type sbtsi definition back into the source file * renamed the qtest file to use hyphens only v2: * Split the commit into a separate patch for the qtest * Moved the common registers into the new header * Introduced a

  1   2   3   >