Re: [PATCH for-4.2] hw/i386: Fix compiler warning when CONFIG_IDE_ISA is disabled

2019-11-15 Thread Peter Maydell
On Fri, 15 Nov 2019 at 16:08, Thomas Huth wrote: > > On 15/11/2019 16.54, Peter Maydell wrote: > > On Fri, 15 Nov 2019 at 15:10, Thomas Huth wrote: > >> --- a/hw/i386/pc_piix.c > >> +++ b/hw/i386/pc_piix.c > >> @@ -78,7 +78,6 @@ sta

Re: [PATCH for-4.2] hw/i386: Fix compiler warning when CONFIG_IDE_ISA is disabled

2019-11-15 Thread Peter Maydell
On Fri, 15 Nov 2019 at 15:10, Thomas Huth wrote: > > When CONFIG_IDE_ISA is disabled, compilation currently fails: > > hw/i386/pc_piix.c: In function ‘pc_init1’: > hw/i386/pc_piix.c:81:9: error: unused variable ‘i’ [-Werror=unused-variable] > > Move the variable declaration to the right code

Re: [PATCH 2/3] docs: build a global index page

2019-11-15 Thread Peter Maydell
On Fri, 8 Nov 2019 at 11:39, Stefan Hajnoczi wrote: > You are right: > * The hidden documents are included in the navigation bar (different > from the table of contents). > * The search index (which install-doc omits!) includes content from > the hidden documents. What is install-doc failing

Re: [PULL] RISC-V Fixes for 4.2-rc2

2019-11-15 Thread Peter Maydell
On Fri, 15 Nov 2019 at 04:41, Palmer Dabbelt wrote: > > The following changes since commit aa464db69b40b4b695be31085e6d2f1e90956c89: > > Update version for v4.2.0-rc1 release (2019-11-12 18:40:02 +) > > are available in the Git repository at: > > g...@github.com:palmer-dabbelt/qemu.git

Re: Invalid ARM instruction for clang-compiled Android code

2019-11-15 Thread Peter Maydell
On Fri, 15 Nov 2019 at 05:03, Michael Goffioul wrote: > When running QEMU user mode on some code compiled by clang (dynamic linker > from AOSP-10), the emulator chokes on this instruction: > >9aa92: e8c0 2277 strexd r7, r2, r2, [r0] I think that ought to be a valid insn... >

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-15 Thread Peter Maydell
On Thu, 14 Nov 2019 at 22:27, Keith Packard wrote: > > Richard Henderson writes: > > > For semi-hosting, it seems even better if the semi-hosting syscall > > instruction > > is not "real", because you're explicitly requesting services from "unreal" > > hardware. It should be specified to

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 20:52, Richard Henderson wrote: > Yet another reason why I prefer any semi-hosting call to use an encoding that > is otherwise reserved illegal. > > For this, you have to make up your mind: is it important to execute the > instructions as specified by the ISA, or as

Re: [PATCH] pl031: Expose RTCICR as proper WC register

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 20:45, Alexander Graf wrote: > On 14.11.19 15:42, Peter Maydell wrote: > > Is that OK? > > It's much better. Will you just fix it up inline for me please? :) Sure :-) -- PMM

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 19:18, Richard Henderson wrote: > - If the sequence crosses a page, then so be it. Because of > step 1, this only happens when we *must* cross a page, and > will have recognized any paging exception anyway. > The generic parts of qemu will handle proper

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 17:47, Peter Maydell wrote: > The ARM semihosting ABI also has a number of warts > which are basically historical legacy. With a clean > sheet you get to avoid some of them. (Notably you could > skip the whole 'negotiate presence of extensions' business >

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 18:05, Keith Packard wrote: > > Peter Maydell writes: > > > I had an idle glance at this implementation, and this: > > > >uint32_t pre = opcode_at(>base, ctx->base.pc_next - 4); > >uint32_t ebreak = opcode_at(>base

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 17:39, Keith Packard wrote: > > Peter Maydell writes: > > > That defines the instruction sequence used to make a semihosting > > call, but not the specification of what the calls are: > > * what call numbers perform which functions >

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Fri, 25 Oct 2019 at 20:15, Keith Packard wrote: > There seems to be convergence on a pretty simple interface which uses > ebreak surrounded by a couple of specific no-ops: > > slli x0, x0, 0x1f > ebreak > srai x0, x0, 0x7 > > There are implementations in rust and openocd, and

Re: [PULL 0/1] Seabios 20191113 patches

2019-11-14 Thread Peter Maydell
On Wed, 13 Nov 2019 at 14:05, Gerd Hoffmann wrote: > > The following changes since commit 9f2ce35dfa4ea4a31dbb765dd02bed2500891887: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-2019' into > staging (2019-11-11 16:54:16 +) > > are available in the Git repository at: > >

Re: [PATCH v3 0/4] arm/aspeed: Watchdog and SDRAM fixes

2019-11-14 Thread Peter Maydell
On Wed, 13 Nov 2019 at 22:13, Joel Stanley wrote: > > Three of these are fixes for ast2600 models that I found when testing > master. The forth is a usability improvement that is helpful when > diagnosing why a watchdog is biting. > > v3 adds some comments and fixes whitespace, and r-b from Alex.

Re: [PATCH] pl031: Expose RTCICR as proper WC register

2019-11-14 Thread Peter Maydell
On Tue, 12 Nov 2019 at 11:57, Peter Maydell wrote: > On Tue, 12 Nov 2019 at 07:28, Alexander Graf wrote: > > I still think that being consistent with the actual PL031 spec is > > preferable though. If any real world guest breaks because of this, we > > can still revert th

Re: [PATCH 01/16] memory: do not look at current_machine->accel

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 10:32, Paolo Bonzini wrote: > > On 14/11/19 11:21, Peter Maydell wrote: > >> FlatView #1 > >> AS "memory", root: system > >> AS "cpu-memory-0", root: system > >> Root memory region: system > >>

Re: [PATCH 01/16] memory: do not look at current_machine->accel

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 09:36, Paolo Bonzini wrote: > > On 14/11/19 10:10, Thomas Huth wrote: > >> "info mtree" prints the wrong accelerator name if used with for example > >> "-machine accel=kvm:tcg". > > I had a quick look at the output of "info mtree" with and without > > "accel=kvm:tcg", but I

Re: [PULL 04/11] target/arm/cpu64: max cpu: Introduce sve properties

2019-11-13 Thread Peter Maydell
On Wed, 13 Nov 2019 at 20:17, Richard Henderson wrote: > > On 11/12/19 11:23 AM, Peter Maydell wrote: > >> +static uint32_t sve_zcr_get_valid_len(ARMCPU *cpu, uint32_t start_len) > >> +{ > >> +uint32_t start_vq = (start_len & 0xf) + 1; > >> + &g

Re: QEMU for Qualcomm Hexagon - KVM Forum talk and code available

2019-11-13 Thread Peter Maydell
On Wed, 13 Nov 2019 at 10:32, Alex Bennée wrote: > I don't see including flex/bison as a dependency > being a major issue (in fact we have it in our docker images so I guess > something uses it). They're used by the dtc submodule, so only in setups where you need to use the submodule rather than

Re: [PATCH] spapr/kvm: Set default cpu model for all machine classes

2019-11-13 Thread Peter Maydell
On Wed, 13 Nov 2019 at 15:10, Greg Kurz wrote: > David is away until the 19th of November, which is the release date > of rc2 according to the planning [*]. Then we have rc3 the 26th, and > final release (or rc4) the 3rd of December, so it should be ok. Please don't actively plan to delay

Re: [PULL 0/2] Linux user for 4.2 patches

2019-11-12 Thread Peter Maydell
On Tue, 12 Nov 2019 at 16:18, Laurent Vivier wrote: > > The following changes since commit 2a7e7c3e103a5c29af7c583390c243d85a2527e8: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-and-tcg-121119-1' into staging (2019-11-12 > 14:51:00 +) > > are available in the Git

Re: [PULL v1 0/3] MicroBlaze fixes

2019-11-12 Thread Peter Maydell
On Tue, 12 Nov 2019 at 16:04, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > The following changes since commit 039e285e095c20a88e623b927654b161aaf9d914: > > Merge remote-tracking branch > 'remotes/vivier2/tags/trivial-branch-pull-request' into staging (2019-11-12 > 12:09:19

Re: [PATCH v1 1/2] docs/devel: rename plugins.rst to tcg-plugins.rst

2019-11-12 Thread Peter Maydell
On Tue, 12 Nov 2019 at 16:42, Alex Bennée wrote: > > This makes it a bit clearer what this is about. > > Signed-off-by: Alex Bennée > --- > MAINTAINERS | 1 + > docs/devel/{plugins.rst => tcg-plugins.rst} | 0 > 2 files changed, 1 insertion(+) > rename

Re: [PATCH v1 2/2] docs/devel: update tcg-plugins.rst with API versioning details

2019-11-12 Thread Peter Maydell
On Tue, 12 Nov 2019 at 16:41, Alex Bennée wrote: > > Signed-off-by: Alex Bennée > --- > docs/devel/tcg-plugins.rst | 16 > 1 file changed, 16 insertions(+) > > diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst > index b18fb6729e3..8d619fd44ef 100644 > ---

Re: [PULL 0/8] testing and tcg plugin api ver

2019-11-12 Thread Peter Maydell
On Tue, 12 Nov 2019 at 14:50, Alex Bennée wrote: > > The following changes since commit 039e285e095c20a88e623b927654b161aaf9d914: > > Merge remote-tracking branch > 'remotes/vivier2/tags/trivial-branch-pull-request' into staging (2019-11-12 > 12:09:19 +) > > are available in the Git

Re: [PATCH 1/1] target/arm: Add support for cortex-m7 CPU

2019-11-12 Thread Peter Maydell
id_afr0 = 0x; > +cpu->id_mmfr0 = 0x00100030; > +cpu->id_mmfr1 = 0x; > +cpu->id_mmfr2 = 0x0100; > +cpu->id_mmfr3 = 0x; > +cpu->isar.id_isar0 = 0x01101110; > +cpu->isar.id_isar1 = 0x02112000; > +cpu->is

Re: [PATCH] linux-user: remove host stime() syscall

2019-11-12 Thread Peter Maydell
Tue Nov 12 15:11:00 UTC 2019 > > Buglink: https://bugs.launchpad.net/qemu/+bug/1852115 > Reported-by: Cole Robinson > Signed-off-by: Laurent Vivier > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PULL 0/5] Trivial branch patches

2019-11-12 Thread Peter Maydell
On Tue, 12 Nov 2019 at 10:07, Laurent Vivier wrote: > > The following changes since commit 9f2ce35dfa4ea4a31dbb765dd02bed2500891887: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-2019' into > staging (2019-11-11 16:54:16 +) > > are available in the Git repository at: > >

[Bug 1852115] Re: qemu --static user build fails with fedora rawhide glibc-2.30.9000

2019-11-12 Thread Peter Maydell
We use stime() to implement the target stime syscall. We should probably switch to using clock_settime(CLOCK_REALTIME, ...) instead, as that's what glibc uses internally now to implement its stime():

Re: [PULL 0/6] qtest and misc patches

2019-11-12 Thread Peter Maydell
On Tue, 12 Nov 2019 at 06:43, Thomas Huth wrote: > > Hi Peter, > > the following changes since commit 654efcb511d394c1d3f5292c28503d1d19e5b1d3: > > Merge remote-tracking branch 'remotes/vivier/tags/q800-branch-pull-request' > into staging (2019-11-11 09:23:46 +) > > are available in the

Re: [PATCH] pl031: Expose RTCICR as proper WC register

2019-11-12 Thread Peter Maydell
On Tue, 12 Nov 2019 at 07:28, Alexander Graf wrote: > > Hey Peter, > > On 08.11.19 17:58, Peter Maydell wrote: > > Did you find this because you had a guest that assumed the > > other behaviour? This bug has been in QEMU for a very long time, > > and it seems o

Re: [PATCH] qemu-coroutine-sleep: Silence Coverity warning

2019-11-12 Thread Peter Maydell
On Tue, 12 Nov 2019 at 10:08, Vladimir Sementsov-Ogievskiy wrote: > > 11.11.2019 23:35, Eric Blake wrote: > > Coverity warns that we store the address of a stack variable through a > > pointer passed in by the caller, which would let the caller trivially > > trigger use-after-free if that stored

Re: [PULL 04/11] target/arm/cpu64: max cpu: Introduce sve properties

2019-11-12 Thread Peter Maydell
On Fri, 1 Nov 2019 at 08:51, Peter Maydell wrote: > > From: Andrew Jones > > Introduce cpu properties to give fine control over SVE vector lengths. > We introduce a property for each valid length up to the current > maximum supported, which is 2048-bits. The properties are na

Re: [PULL 20/39] hw/i386: Introduce the microvm machine type

2019-11-12 Thread Peter Maydell
On Thu, 24 Oct 2019 at 16:19, Paolo Bonzini wrote: > > From: Sergio Lopez > > microvm is a machine type inspired by Firecracker and constructed > after its machine model. > > It's a minimalist machine type without PCI nor ACPI support, designed > for short-lived guests. microvm also establishes

Re: [PULL 11/14] vfio: unplug failover primary device before migration

2019-11-12 Thread Peter Maydell
On Tue, 29 Oct 2019 at 23:01, Michael S. Tsirkin wrote: > > From: Jens Freimann > > As usual block all vfio-pci devices from being migrated, but make an > exception for failover primary devices. This is achieved by setting > unmigratable to 0 but also add a migration blocker for all vfio-pci >

Re: [PULL v2 01/13] linux-user: Support for NETLINK socket options

2019-11-12 Thread Peter Maydell
On Wed, 6 Nov 2019 at 13:07, Laurent Vivier wrote: > > From: Josh Kunz > > This change includes support for all AF_NETLINK socket options up to about > kernel version 5.4 (5.4 is not formally released at the time of writing). > Socket options that were introduced in kernel versions before the

Re: [PULL 10/14] net/virtio: add failover support

2019-11-12 Thread Peter Maydell
On Tue, 29 Oct 2019 at 23:01, Michael S. Tsirkin wrote: > > From: Jens Freimann > > This patch adds support to handle failover device pairs of a virtio-net > device and a (vfio-)pci device, where the virtio-net acts as the standby > device and the (vfio-)pci device as the primary. Hi; Coverity

Re: [PATCH] qemu-coroutine-sleep: Silence Coverity warning

2019-11-12 Thread Peter Maydell
an add an assert that we do not leak stack storage to > the caller on function exit. > > Fixes: Coverity CID 1406474 > CC: Peter Maydell > Signed-off-by: Eric Blake > --- > > I don't know if this actually shuts Coverity up; Peter, since you > reported the Coverity issue

Re: [PULL 0/4] tcg patch queue

2019-11-11 Thread Peter Maydell
On Mon, 11 Nov 2019 at 15:56, Richard Henderson wrote: > > The following changes since commit 654efcb511d394c1d3f5292c28503d1d19e5b1d3: > > Merge remote-tracking branch 'remotes/vivier/tags/q800-branch-pull-request' > into staging (2019-11-11 09:23:46 +) > > are available in the Git

Re: [PULL 0/3] target-arm queue

2019-11-11 Thread Peter Maydell
On Mon, 11 Nov 2019 at 13:58, Peter Maydell wrote: > > Arm patches for rc1: > * two final "remove the old API" patches for some API transitions > * bugfix for raspi/highbank Linux boot > > thanks > -- PMM > > The following changes since commit 654

Re: [PATCH] tests/migration: use the common library function

2019-11-11 Thread Peter Maydell
On Mon, 11 Nov 2019 at 14:41, Thomas Huth wrote: > > On 11/11/2019 15.11, Alex Bennée wrote: > > > > Thomas Huth writes: > > > >> On 11/11/2019 13.55, Alex Bennée wrote: > >>> Signed-off-by: Alex Bennée > >> > >> Could you please add at least a short patch description? (Why is this > >> change

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-11 Thread Peter Maydell
On Tue, 5 Nov 2019 at 05:10, Keith Packard wrote: > > Peter Maydell writes: > > > I'm going to push for somebody actually writing out a > > document and putting it somewhere that we can point to > > and say "that's the authoritative spec", please... > &g

[PULL 2/3] Remove unassigned_access CPU hook

2019-11-11 Thread Peter Maydell
All targets have now migrated away from the old unassigned_access hook to the new do_transaction_failed hook. This means we can remove the core-code infrastructure for that hook and the code that calls it. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair

[PULL 1/3] ptimer: Remove old ptimer_init_with_bh() API

2019-11-11 Thread Peter Maydell
result from: * s->bh no longer exists * s->callback is now always non-NULL Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20191025142411.17085-1-peter.mayd...@linaro.org --- include/hw/ptimer.h | 45 +++--- hw/core/ptimer.c

[PULL 3/3] hw/arm/boot: Set NSACR.{CP11, CP10} in dummy SMC setup routine

2019-11-11 Thread Peter Maydell
cs.com Reviewed-by: Peter Maydell [PMM: updated comment to boot.h to note new requirement on users of secure_board_setup; edited/rewrote commit message] Signed-off-by: Peter Maydell --- include/hw/arm/boot.h | 7 +-- hw/arm/boot.c | 3 +++ 2 files changed, 8 insertions(+), 2 deletions(-)

[PULL 0/3] target-arm queue

2019-11-11 Thread Peter Maydell
up routine Clement Deschamps (1): hw/arm/boot: Set NSACR.{CP11, CP10} in dummy SMC setup routine Peter Maydell (2): ptimer: Remove old ptimer_init_with_bh() API Remove unassigned_access CPU hook include/hw/arm/boot.h | 7 ++-- include/hw/

Re: [PATCH v2] tcg plugins: expose an API version concept

2019-11-11 Thread Peter Maydell
old deprecated APIs in the future. > > Signed-off-by: Alex Bennée > Reviewed-by: Philippe Mathieu-Daudé > > --- > v2 > - error out on missing plugin version symbol > - fix missing symbol on hotblocks.so > - more verbose error text, avoid bad grammar > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] hw/arm/boot: Set NSACR.{CP11, CP10} in dummy SMC setup routine

2019-11-11 Thread Peter Maydell
On Mon, 4 Nov 2019 at 15:12, Clement Deschamps wrote: > > Set the NSACR CP11 and CP10 bits, to allow FPU access in Non-Secure state > when using dummy SMC setup routine. Otherwise an AArch32 kernel will UNDEF as > soon as it tries to use the FPU. > > This fixes kernel panic when booting raspbian

Re: [PULL 0/2] Q800 branch patches

2019-11-11 Thread Peter Maydell
On Fri, 8 Nov 2019 at 20:40, Laurent Vivier wrote: > > The following changes since commit 1cee80fa665d37411f8ad8a930b84840bbab62e5: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20191107-pull-request' into staging (2019-11-08 > 11:00:28 +) > > are available in the Git

Re: Looking for issues/features for my first contribution

2019-11-10 Thread Peter Maydell
On Sat, 9 Nov 2019 at 21:08, Aleksandar Markovic wrote: > Given modularity of RasPi, wouldn't it be nice for end users to be able to > specify an RTC via command line? The rtc option specifies properties of the backend of an rtc device. It doesn't specify what the RTC device exposed to the

Re: [PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants

2019-11-09 Thread Peter Maydell
On Fri, 8 Nov 2019 at 19:11, Eduardo Habkost wrote: > > On Fri, Nov 08, 2019 at 01:02:28PM +, Peter Maydell wrote: > > On Fri, 8 Nov 2019 at 12:46, David Hildenbrand wrote: > > > There is a small but important difference between "max"/"host" and >

Re: Looking for issues/features for my first contribution

2019-11-09 Thread Peter Maydell
On Fri, 8 Nov 2019 at 19:32, Aleksandar Markovic wrote: > > > [a] Is there any particular reason that you picked DS3231 ? Linux kernel > > has drivers for DS3232/34 only [1]. I did read the datasheets of both > > 3232 & 3231 and found that they are quite similar except for the 236 > > bytes of

Re: [PATCH v2 1/3] device_tree: Add a helper function for string arrays

2019-11-09 Thread Peter Maydell
On Fri, 8 Nov 2019 at 19:48, Palmer Dabbelt wrote: > > The device tree format allows for arrays of strings, which are encoded > with '\0's inside regular strings. These are ugly to represent in C, so > the helper function represents them as strings with internal '\0's that > are terminated with

Re: [PATCH v2 2/3] ARM/virt: Use fdt_setprop_strings()

2019-11-09 Thread Peter Maydell
On Fri, 8 Nov 2019 at 19:48, Palmer Dabbelt wrote: > > This new helper function encodes the idiom used by the ARM virt board to > set a string array. I don't currently have a working ARM userspace, so I > haven't tested > this, but I made the helper function because I wanted to use it for the >

Re: [PULL 1/3] qemu-coroutine-sleep: introduce qemu_co_sleep_wake

2019-11-08 Thread Peter Maydell
On Wed, 23 Oct 2019 at 03:04, Eric Blake wrote: > > From: Vladimir Sementsov-Ogievskiy > > Introduce a function to gracefully wake a coroutine sleeping in > qemu_co_sleep_ns(). > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Kevin Wolf > Reviewed-by: Eric Blake > Message-Id:

Re: [PATCH] RISC-V: virt: This is a "sifive,test1" test finisher

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 17:15, Alistair Francis wrote: > > On Fri, Nov 8, 2019 at 9:05 AM Palmer Dabbelt wrote: > > > > The test finisher implements the reset command, which means it's a > > "sifive,test1" device. This is a backwards compatible change, so it's > > also a "sifive,test0" device. I

[PATCH v2 for-4.2] Remove unassigned_access CPU hook

2019-11-08 Thread Peter Maydell
All targets have now migrated away from the old unassigned_access hook to the new do_transaction_failed hook. This means we can remove the core-code infrastructure for that hook and the code that calls it. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair

Re: [PULL v2 00/73] tcg plugins and testing updates

2019-11-08 Thread Peter Maydell
On Wed, 6 Nov 2019 at 12:42, Markus Armbruster wrote: > > Markus Armbruster writes: > > > Alex Bennée writes: > > > >> Markus Armbruster writes: > >> > >>> I hate to interfere with the merging of working code for non-technical > >>> reasons > >>> > >>> This is a plugin interface. As I

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 17:07, Philippe Mathieu-Daudé wrote: > On 11/8/19 4:43 PM, Eric Blake wrote: > > bzip2 is no longer a favored compression. If we are trying to pick a > > compression that is most likely to be present on any system, go with > > gzip. If we are trying to pick a compression

Re: [PATCH] pl031: Expose RTCICR as proper WC register

2019-11-08 Thread Peter Maydell
On Mon, 4 Nov 2019 at 11:52, Alexander Graf wrote: > > The current pl031 RTCICR register implementation always clears the IRQ > pending status on a register write, regardless of the value it writes. > > To justify that behavior, it references the arm926e documentation > (DDI0287B) and indicates

Re: [PATCH v5 00/13] Multi-phase reset mechanism

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 15:26, Damien Hedde wrote: > > > On 10/29/19 4:53 PM, Damien Hedde wrote: > > Hi, > > > > Does anyone has comment about the interface / patch 3 ? > > Should I try to split it ? > > ping Hi; this patchset is still in my to-review queue, but we've just gone into softfreeze

Re: [PATCH] tcg plugins: expose an API version concept

2019-11-08 Thread Peter Maydell
On Mon, 4 Nov 2019 at 13:18, Alex Bennée wrote: > > This is a very simple versioning API which allows the plugin > infrastructure to check the API a plugin was built against. We also > expose a min/cur API version to the plugin via the info block in case > it wants to avoid using old deprecated

Re: [PULL 0/1] Seabios 20191108 patches

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 10:24, Gerd Hoffmann wrote: > > The following changes since commit 59015778f3ec7c01202d46c5dbeeac8ab4225c52: > > Update version for v4.2.0-rc0 release (2019-11-07 18:17:31 +) > > are available in the Git repository at: > > git://git.kraxel.org/qemu

Re: [PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 12:46, David Hildenbrand wrote: > There is a small but important difference between "max"/"host" and > "best". Max really means "all features", including deprecated ones. > "best", however, can disable experimental or deprecated features. Or any > other features we don't

Re: [PULL 0/1] Usb 20191107 patches

2019-11-08 Thread Peter Maydell
On Thu, 7 Nov 2019 at 08:58, Gerd Hoffmann wrote: > > The following changes since commit 412fbef3d076c43e56451bacb28c4544858c66a3: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/fw_cfg-next-pull-request' into staging > (2019-11-05 20:17:11 +) > > are available in the Git

Re: [PATCH 2/3] docs: build a global index page

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 11:39, Stefan Hajnoczi wrote: > > On Fri, Nov 8, 2019 at 11:52 AM Peter Maydell > wrote: > > So the reason I went for the odd "run sphinx multiple times" > > approach was because we don't want to ship 'devel' to users, > > and as

Re: [PATCH v1 0/2] s390x/cpumodel: Introduce "best" model variants

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 11:08, David Hildenbrand wrote: > > There was recently a discussion regarding CPU model versions. That concept > does not fit s390x where we have a lot of feature variability. I > proposed an alternative approach in [1], which might work for x86 as well > (but I am not sure

Re: [PATCH 3/3] docs: install CSS and Javascript files for HTML docs

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 10:00, Stefan Hajnoczi wrote: > > Install the sphinx CSS/Javascript support files needed by the HTML > documentation. The documentation looks ugly without this. > > The previous patch switched to only invoking sphinx once so there is > only one _static/ directory that needs

Re: [PATCH 2/3] docs: build a global index page

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 09:59, Stefan Hajnoczi wrote: > > Build docs/ in a single sphinx invocation instead of treating > docs/{devel,interop,specs} separately. This allows us to build a global > index page that links to documentation across the different manuals. > > Some documentation is built

Re: [PULL 0/1] Usb 20191107 patches

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 18:57, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 11/7/19 7:26 PM, Peter Maydell wrote: > > On Thu, 7 Nov 2019 at 08:58, Gerd Hoffmann wrote: > >> > >> The following changes since commit > >> 412fbef3d076c43e56451b

Re: [PULL 0/1] Usb 20191107 patches

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 08:58, Gerd Hoffmann wrote: > > The following changes since commit 412fbef3d076c43e56451bacb28c4544858c66a3: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/fw_cfg-next-pull-request' into staging > (2019-11-05 20:17:11 +) > > are available in the Git

Re: [PULL 0/3] Block patches for 4.2.0-rc0/4.1.1

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 14:34, Max Reitz wrote: > > The following changes since commit d0f90e1423b4f412adc620eee93e8bfef8af4117: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20191106-pull-request' into staging (2019-11-07 > 09:21:52 +) > > are available in the Git

Re: [PATCH for 4.2 v1 1/1] riscv/virt: Increase flash size

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 17:09, Palmer Dabbelt wrote: > > On Wed, 06 Nov 2019 16:47:20 PST (-0800), Alistair Francis wrote: > > Coreboot developers have requested that they have at least 32MB of flash > > to load binaries. We currently have 32MB of flash, but it is split in > > two to allow loading

Re: [PATCH v1 0/6] testing/next (netbsd stuff)

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 17:54, Kamil Rytarowski wrote: > > On 07.11.2019 18:46, Peter Maydell wrote: > > On Mon, 4 Nov 2019 at 17:39, Alex Bennée wrote: > >> > >> Hi, > >> > >> As we approach hard-freeze I'm trying to temper what comes in thro

Re: [PATCH v1 0/6] testing/next (netbsd stuff)

2019-11-07 Thread Peter Maydell
On Mon, 4 Nov 2019 at 17:39, Alex Bennée wrote: > > Hi, > > As we approach hard-freeze I'm trying to temper what comes in through > the testing/next tree. However it would be nice to get the NetBSD upto > speed with the other NetBSDs. Although the serial install is working > well for me this has

Re: [PULL v3 0/3] Trivial branch patches

2019-11-07 Thread Peter Maydell
On Wed, 6 Nov 2019 at 16:26, Laurent Vivier wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git

Re: [PATCH v2 2/4] Memory: Enable writeback for given memory region

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 16:57, Alex Bennée wrote: > > > Beata Michalska writes: > > > On Wed, 6 Nov 2019 at 12:20, Richard Henderson > > wrote: > >> qemu_log_mask w/ GUEST_ERROR? How do we expect the length to overflow? > > > > In theory it shouldn't, at least with current usage. > > I guess the

Re: QEMU HTML documentation now on qemu.org

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 09:29, Stefan Hajnoczi wrote: > > On Wed, Nov 6, 2019 at 5:21 PM Stefan Hajnoczi wrote: > > Hi, > > You can now access the latest QEMU HTML documentation built from > > qemu.git/master nightly at: > > > > https://wiki.qemu.org/docs/qemu-doc.html > >

Re: [Qemu-devel] [PATCH PULL 0/2] RDMA queue

2019-11-07 Thread Peter Maydell
On Wed, 6 Nov 2019 at 14:51, Marcel Apfelbaum wrote: > > The following changes since commit 412fbef3d076c43e56451bacb28c4544858c66a3: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/fw_cfg-next-pull-request' into staging > (2019-11-05 20:17:11 +) > > are available in the

Re: [PULL 0/3] virtio, pci: fixes

2019-11-07 Thread Peter Maydell
On Wed, 6 Nov 2019 at 12:35, Michael S. Tsirkin wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git

Re: [PULL 0/1] Seabios 20191106 patches

2019-11-07 Thread Peter Maydell
On Wed, 6 Nov 2019 at 12:26, Gerd Hoffmann wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git

Re: [PULL 0/1] Audio 20191106 patches

2019-11-07 Thread Peter Maydell
On Wed, 6 Nov 2019 at 08:27, Gerd Hoffmann wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git

Re: [PULL 0/1] Ui 20191106 patches

2019-11-07 Thread Peter Maydell
On Wed, 6 Nov 2019 at 07:08, Gerd Hoffmann wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git

Re: [PULL v2 00/13] Linux user for 4.2 patches

2019-11-06 Thread Peter Maydell
On Wed, 6 Nov 2019 at 13:09, Laurent Vivier wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git

Re: [PULL v2 00/21] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

2019-11-06 Thread Peter Maydell
On Tue, 5 Nov 2019 at 22:55, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > This is a X86/MIPS pull, Paolo and Aleksandar are OK I send it: > > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg04959.html > > Since v1: Fixed the Kconfig bug you reported here: > >

Re: Feature Recommendations?

2019-11-06 Thread Peter Maydell
On Wed, 6 Nov 2019 at 17:42, Eric Blake wrote: > > On 11/3/19 4:59 AM, Dinah A Baum wrote: > > Hello all, > > > > I am a university student whose Virtualization course has tasked me with > > contributing to an open source, virtualization related project. I have a > > little more than a month to

Re: [PULL 0/1] Q800 branch patches

2019-11-06 Thread Peter Maydell
On Tue, 5 Nov 2019 at 18:07, Laurent Vivier wrote: > > The following changes since commit b7c9a7f353c0e260519bf735ff0d4aa01e72784b: > > Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into > staging (2019-10-31 15:57:30 +) > > are available in the Git repository at: > >

Re: [Xen-devel] [PULL v2 0/3] Trivial branch patches

2019-11-06 Thread Peter Maydell
On Tue, 5 Nov 2019 at 20:06, Laurent Vivier wrote: > > Le 05/11/2019 à 20:20, no-re...@patchew.org a écrit : > > Patchew URL: > > https://patchew.org/QEMU/20191105175010.2591-1-laur...@vivier.eu/ > > > > > > > > Hi, > > > > This series seems to have some coding style problems. See output below

Re: [PULL 00/11] Block patches

2019-11-06 Thread Peter Maydell
On Tue, 5 Nov 2019 at 15:43, Stefan Hajnoczi wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git

Re: [PULL 0/2] qemu-ga patch queue for 4.2-rc0

2019-11-06 Thread Peter Maydell
On Mon, 4 Nov 2019 at 17:30, Michael Roth wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git

Re: [PULL 0/5] Block patches for 4.2-rc0

2019-11-06 Thread Peter Maydell
On Mon, 4 Nov 2019 at 09:03, Max Reitz wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git repository

Re: [PULL 0/1] Require Python >= 3.5 to build QEMU

2019-11-06 Thread Peter Maydell
On Wed, 6 Nov 2019 at 10:36, Daniel P. Berrangé wrote: > At what point do we declare that NetBSD CI is broken and is no longer > considered a supported platform from POV of blocking the merging of > PULL requests ? It has been preventing the dropping of python2 for > quite a while now. It isn't

Re: [EXTERNAL] Re: Adding New, Unsupported ISA to Qemu

2019-11-05 Thread Peter Maydell
On Tue, 5 Nov 2019 at 21:23, Hanson, Seth wrote: > I completely understand your concern. Rest assured, this project is entirely > internal and requires no code contribution, unit testing, etc. from QEMU > devs. We simply want to garner as much documentation as possible to ensure > optimal

Re: [PULL 0/2] fw_cfg for-4.2-soft-freeze patches

2019-11-05 Thread Peter Maydell
On Sun, 3 Nov 2019 at 22:26, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > One fw_cfg fix from David Gilbert. > > The following changes since commit f3cad9c6dbd4b9877232c44bf2dd877353a73209: > > iotests: Remove 130 from the "auto" group (2019-10-31 11:04:10 +) > > are available in the Git

Re: Adding New, Unsupported ISA to Qemu

2019-11-05 Thread Peter Maydell
On Tue, 5 Nov 2019 at 16:44, Stefan Hajnoczi wrote > The general advice I've seen is: > > 1. Look at existing TCG targets to learn how to implement aspects of >your ISA. ...and *don't* look at older/less maintained targets (including x86), as they have a lot of bad habits you don't want to

Re: [PATCH] hw/arm/pxa2xx: rebuild hflags cache when modifying CPU state

2019-11-05 Thread Peter Maydell
On Tue, 5 Nov 2019 at 11:20, Richard Henderson wrote: > > On 11/1/19 11:42 AM, Peter Maydell wrote: > > The other place that might need checking is the PSCI/etc > > code for doing CPU power on/off (and other callers to the > > power up/down functions like the imx6 power co

Re: [PING] [PATCH 1/1] target/arm: Add support for cortex-m7 CPU

2019-11-05 Thread Peter Maydell
On Mon, 4 Nov 2019 at 16:41, Christophe Lyon wrote: > > ping? This is on my list to review, but it's missed softfreeze so as a new feature it will go into 5.0 once trunk reopens for development at the end of the year, so it's not the highest priority for patch review for me I'm afraid. thanks

Re: [PULL 0/1] Require Python >= 3.5 to build QEMU

2019-11-05 Thread Peter Maydell
On Tue, 5 Nov 2019 at 19:57, Eduardo Habkost wrote: > Fixing tests/vm/netbsd is being tricky. It looks like the > configure patch will have to wait until after QEMU 4.2.0. :( I think that makes sense at this point in the release cycle, yes. > > Have you tried a test run with Travis/etc/etc to

Re: [Bug 1851095] [NEW] [feature request] awareness of instructions that are well emulated

2019-11-03 Thread Peter Maydell
On Sun, 3 Nov 2019 at 04:41, Shawn Landden <1851...@bugs.launchpad.net> wrote: > While qemu's scalar emulation tends to be excellent, qemu's SIMD > emulation tends to be incorrect (except for arm64 from x86_64)--i have > found this both for mipsel and arm32. Until these code paths are > audited,

  1   2   3   4   5   6   7   8   9   10   >