[Qemu-devel] [Bug 1716028] Re: qemu 2.10 locks images with no feature flag

In our multipath case, the initial open succeeds (it's not locked by anything else) and the second lock attempt fails, however, IIUC the fcntl structure[1] includes the locking pid, which should be our invocation of QEMU; Can we not check if the locking pid matches the current pid and not fail?

[Qemu-devel] [Bug 1716028] Re: qemu 2.10 locks images with no feature flag

Kevin, Thanks for the information. A couple of points for feedback: 1) there doesn't appear to be a way to run qmp query-schema without spawning a qemu instance in -qmp mode and having a second client issue the query-schema; certainly a qemu-system-$arch -qmp-schema would be quite useful when

Re: [Qemu-devel] [Bug 1305402] Re: libvirt fails to start VirtualMachines

Machine type changes may be related to: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1626070 There's a PPA in the bug with a fix for at least the wily machine type. On Thu, Sep 22, 2016 at 6:05 PM, Leo Arias wrote: > This has just happened to me. For some

[Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

As noted, Xenial kernel is not supporting POWER7 cpu. ** Changed in: linux (Ubuntu) Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1563887 Title:

[Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

I should also mention that the original command used will work if we specify which cpu type to use: qemu-system-ppc64 -m 256 \ -cpu POWER8 \ -display none -nographic \ -net nic -net user,net=10.0.0.0/8,host=10.0.0.1,hostfwd=tcp::-:22 \ -machine pseries \ -drive

[Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

Here's an update. The Xenial kernel doesn;t like the emulated POWER7 cpu that the command line being used generates by default. processor : 0 cpu : POWER7 (raw), altivec supported clock : 1000.00MHz revision: 2.3 (pvr 003f 0203) timebase:

[Qemu-devel] [Bug 1465935] Re: kvm_irqchip_commit_routes: Assertion `ret == 0' failed

Thank you for taking the time to report this bug and helping to make Ubuntu better. Please execute the following command, as it will automatically gather debugging information, in a terminal: apport-collect 1465935 When reporting bugs in the future please use apport by using 'ubuntu- bug' and

[Qemu-devel] [Bug 1465935] Re: kvm_irqchip_commit_routes: Assertion `ret == 0' failed

Have you be able to reproduce this issue on a wily host? What about a different guest? Or is only RHEL6.3 affected? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1465935 Title:

[Qemu-devel] [Bug 1465935] Re: kvm_irqchip_commit_routes: Assertion `ret == 0' failed

It appears that the latest version of the patch is here: http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg00822.html However, this hasn't yet be accepted upstream. The most recent discussion requires the submitter to respond to the maintainers questions here:

[Qemu-devel] [Bug 551545] Re: PXE netboot not booting localboot from virtio-disk

This issue should be fixed in the qemu-kvm version included in precise. ** Changed in: qemu-kvm (Ubuntu) Status: Triaged = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/551545

[Qemu-devel] [Bug 1318830] Re: High CPU usage on windows virtual machine

Hi, Are you running ntp in the host or timekeeping in the guest? If so, is the guest clock close to what current time should be? Also, can you try adding this option: -global mc146818rtc.lost_tick_policy=slew -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [Qemu-devel] [RFC] fix crashes with vmware driver

, __FUNCTION__, x, w); -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com

Re: [Qemu-devel] [PATCH v5] qemu-ga: Add guest-network-info command

= NULL; +GuestNetworkInterfaceList *interfaces = guest_build_interfaces_info(errp); + +if (interfaces) { +network_info = g_malloc0(sizeof(*network_info)); +network_info-interfaces = interfaces; +} + +return network_info; +} -- 1.7.3.4 -- Ryan Harper

Re: [Qemu-devel] [PATCH 2/4] Add cleanup function

* Eric Blake ebl...@redhat.com [2012-01-17 16:03]: On 01/16/2012 10:16 AM, Ryan Harper wrote: if test -z $1 -o -z $2; then echo Usage: $0 QEMU TEST1 [TEST2 ...] +cleanup exit 1 Is it worth using 'trap cleanup 0' to install the cleanup handler up front, instead

Re: [Qemu-devel] [PATCH 2/4] Add cleanup function

* Eric Blake ebl...@redhat.com [2012-01-13 17:18]: On 01/13/2012 03:05 PM, Ryan Harper wrote: Create a cleanup function and call it from all exits so we don't leave temp files and directories around since we change the name on each invocation. Also, no need to delete the files

Re: [Qemu-devel] [PATCH 2/2] KVM: Use -cpu best as default on x86

QEMUMachine xenfv_machine = { static void pc_machine_init(void) { +qemu_register_machine(pc_machine_v1_1); qemu_register_machine(pc_machine_v1_0); qemu_register_machine(pc_machine_v0_15); qemu_register_machine(pc_machine_v0_14); -- 1.6.0.2 -- Ryan Harper Software

Re: [Qemu-devel] [PATCH 2/2] KVM: Use -cpu best as default on x86

* Alexander Graf ag...@suse.de [2012-01-16 13:37]: On 16.01.2012, at 20:30, Ryan Harper wrote: * Alexander Graf ag...@suse.de [2012-01-08 17:53]: When running QEMU without -cpu parameter, the user usually wants a sane default. So far, we're using the qemu64/qemu32 CPU type, which

Re: [Qemu-devel] [PATCH 2/2] KVM: Use -cpu best as default on x86

* Alexander Graf ag...@suse.de [2012-01-16 13:52]: On 16.01.2012, at 20:46, Ryan Harper wrote: * Alexander Graf ag...@suse.de [2012-01-16 13:37]: On 16.01.2012, at 20:30, Ryan Harper wrote: * Alexander Graf ag...@suse.de [2012-01-08 17:53]: When running QEMU without -cpu

Re: [Qemu-devel] [PATCH 2/2] KVM: Use -cpu best as default on x86

* Alexander Graf ag...@suse.de [2012-01-16 14:52]: On 16.01.2012, at 21:13, Ryan Harper wrote: * Alexander Graf ag...@suse.de [2012-01-16 13:52]: On 16.01.2012, at 20:46, Ryan Harper wrote: * Alexander Graf ag...@suse.de [2012-01-16 13:37]: On 16.01.2012, at 20:30, Ryan

[Qemu-devel] [PATCH] Add virtio-blk-drive-serial test

We can test out the virtio-blk drive serial number by generating and then reading it back via the file in sysfs. Signed-off-by: Ryan Harper ry...@us.ibm.com --- tests/virtio-blk-drive-serial.sh | 40 ++ 1 files changed, 40 insertions(+), 0 deletions

[Qemu-devel] [PATCH 1/4] update get_file_size to not throw error on non-existant files

extract the size. Signed-off-by: Ryan Harper ry...@us.ibm.com --- qemu-test |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/qemu-test b/qemu-test index c6ea595..cd102a7 100755 --- a/qemu-test +++ b/qemu-test @@ -54,9 +54,10 @@ checkpid() { } get_file_size

[Qemu-devel] [PATCH 4/4] Apply consistent indentation

Inner blocks of if/for/while are all indented. Signed-off-by: Ryan Harper ry...@us.ibm.com --- qemu-test | 56 1 files changed, 28 insertions(+), 28 deletions(-) diff --git a/qemu-test b/qemu-test index 445ca6d..9750a3f 100755

[Qemu-devel] [PATCH 2/4] Add cleanup function

Create a cleanup function and call it from all exits so we don't leave temp files and directories around since we change the name on each invocation. Also, no need to delete the files in the tmpdir, so just remove the tmpdir if it exists. Signed-off-by: Ryan Harper ry...@us.ibm.com --- qemu

[Qemu-devel] [PATCH] qemu-test: qemu-test script cleanups

Ran qemu-test for the first time and found a few places to clean up the output. Did tab removal in qemu-test and then updated the indentation to be consistent. Signed-off-by: Ryan Harper ry...@us.ibm.com

[Qemu-devel] [PATCH 3/4] Remove tabs and replace with four spaces.

Signed-off-by: Ryan Harper ry...@us.ibm.com --- qemu-test | 62 ++-- 1 files changed, 31 insertions(+), 31 deletions(-) diff --git a/qemu-test b/qemu-test index 71c1ba1..445ca6d 100755 --- a/qemu-test +++ b/qemu-test @@ -29,9 +29,9

Re: [Qemu-devel] Storage requirements for live migration

two forms of data, cluster metadata (L1/L2 data, refcount table, etc) and mutable header information (file size, snapshot entries, etc). This data needs to be discarded before after migration starts. before after? pick one =) -- Ryan Harper Software Engineer; Linux Technology Center IBM

Re: [Qemu-devel] [PATCH v10 1/3] block: add the command line support

}[,@var{option}[,...]]] -- 1.7.6 -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com

Re: [Qemu-devel] [PATCH 3/6] trace: Add trace events group implementation in the backend simple

{ +const char *gp_name; +bool state; +int start; +int end; +} TraceEventGroup; + void trace0(TraceEventID event); void trace1(TraceEventID event, uint64_t x1); void trace2(TraceEventID event, uint64_t x1, uint64_t x2); -- 1.7.1 -- Ryan Harper Software Engineer

Re: [Qemu-devel] [PATCH] vhost-net: cleanup host notifiers at last step

virtio_net_hdr)); } +vhost_dev_disable_notifiers(net-dev, dev); } void vhost_net_cleanup(struct vhost_net *net) -- 1.7.5.53.gc233e -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

* Christoph Hellwig h...@lst.de [2011-08-24 13:46]: On Mon, Aug 22, 2011 at 11:46:00AM -0500, Ryan Harper wrote: So, I believe this is how it's happening. we start accounting on a write which is turned into a multiwrite via virtio_blk_handle_write() which calls virtio_submit_multiwrite

Re: [Qemu-devel] [PATCH 2/2] [FYI] coverage test for Linux installs

qstring.o qlist.o qbool.o qjson.o json-streamer.o json-lexer.o js test-coroutine: test-coroutine.o qemu-timer-common.o async.o $(coroutine-obj-y) $(CHECK_PROG_DEPS) +test-linux: test-linux.o $(CHECK_PROG_DEPS) $(qapi-obj-y): $(GENERATED_HEADERS) qapi-dir := qapi-generated -- Ryan Harper

Re: [Qemu-devel] Block layer roadmap on wiki

? is that sufficient? Anything like this in existence? storage stack where either local LVM, btrfs, or storage appliances do the storage management means we exploit those options instead of implementing equivalent functionality ourselves. QEMU then runs with plain old raw in more cases. Stefan -- Ryan

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

-type] += get_clock() - cookie-start_time_ns; 242 } 243 -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

* Christoph Hellwig h...@lst.de [2011-08-22 10:16]: On Mon, Aug 22, 2011 at 09:59:16AM -0500, Ryan Harper wrote: * Christoph Hellwig h...@lst.de [2011-08-21 17:27]: changes since V1: - rebase to apply against the current qemu.git tree Testing on tip + this series

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

* Christoph Hellwig h...@lst.de [2011-08-22 10:37]: On Mon, Aug 22, 2011 at 10:29:11AM -0500, Ryan Harper wrote: (gdb) frame 0 #0 0x004200c1 in bdrv_acct_done (bs=0x12310b0, cookie=0x1c68810) at /root/git/qemu/block_int.h:239 239 bs-nr_bytes[cookie-type] += cookie-bytes

Re: [Qemu-devel] Block layer roadmap on wiki

and aren't strictly virtualization issues, but that doesn't mean we can't integrate some sort of solution. That may require tighter integration and more focus on the higher up pieces in the stack to really enable this. Yes, exactly. Much of it shouldn't be inside QEMU. Stefan -- Ryan

Re: [Qemu-devel] [PATCH v4 0/3] The intro for QEMU disk I/O limits

to rework how the blk-queue is using the AIOPool. I'll reply to that patch. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com

Re: [Qemu-devel] [PATCH v4 2/3] The support for block queue

the memory back to the pool once your request is complete, which you'll know after wiring up the block_queue callback to the completion of the request's handler. And then since we don't double allocate, you won't need to do the qemu_free(request) in block.c in block_timer... -- Ryan Harper Software

Re: [Qemu-devel] [PATCH v4 3/3] The support for queue timer and throttling algorithm

, +BlockIOLimit *io_limits); + #ifdef _WIN32 int is_windows_drive(const char *filename); #endif -- 1.7.2.3 -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com

Re: [Qemu-devel] [PATCH v3 0/2] The intro for QEMU disk I/O limits

. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com

Re: [Qemu-devel] qemu - SCSI disk Device Model, Serial Number, and Firmware Version?

the device? If not, then I suggest just disabling smartmontools since it won't give you meaningful data anyhow. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com

Re: [Qemu-devel] [RFC]QEMU disk I/O limits

, but with files: qemu-kvm -drive file=/path/to/local/vm/images -drive file=/path/to/shared/storage -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com

Re: [Qemu-devel] [PATCH v3 1/2] cdrom: Allow the TEST_UNIT_READY command after a cdrom change

] != GPCMD_TEST_UNIT_READY) { +ide_atapi_cmd_check_status(s); +return; } switch(s-io_buffer[0]) { case GPCMD_TEST_UNIT_READY: -- 1.7.4 -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com

Re: [Qemu-devel] [PATCH v3] Do not delete BlockDriverState when deleting the drive

* Markus Armbruster arm...@redhat.com [2011-03-29 02:44]: Ryan Harper ry...@us.ibm.com writes: When removing a drive from the host-side via drive_del we currently have the following path: drive_del qemu_aio_flush() bdrv_close()// zaps bs-drv, which makes any subsequent I/O get

Re: [Qemu-devel] [PATCH v3] Do not delete BlockDriverState when deleting the drive

* Markus Armbruster arm...@redhat.com [2011-03-29 04:06]: Since you have to respin anyway, would you mind limiting commit message line length to 70-75 characters? Thanks. yep -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com

[Qemu-devel] [PATCH v4] Do not delete BlockDriverState when deleting the drive

...@redhat.com Signed-off-by: Ryan Harper ry...@us.ibm.com --- v3-v4 - add back missing nulling of device_name in v2 - use drive_uninit() when removing drive with no peer - align commit message on 72 char boundary v2-v3 - Update drive_del use after free description - s/bdrv_remove/bdrv_make_anon

Re: [Qemu-devel] [PATCH v2] Do not delete BlockDriverState when deleting the drive

* Markus Armbruster arm...@redhat.com [2011-03-24 07:27]: Whoops, almost missed this. Best to cc: me to avoid that. It was sent directly to you: Sender: qemu-devel-bounces+ryanh=us.ibm@nongnu.org From: Ryan Harper ry...@us.ibm.com Subject: Re: [Qemu-devel] [PATCH v2] Do

[Qemu-devel] [PATCH v3] Do not delete BlockDriverState when deleting the drive

...@redhat.com Signed-off-by: Ryan Harper ry...@us.ibm.com --- v2-v3 - Update drive_del use after free description - s/bdrv_remove/bdrv_make_anon/g - Don't remove qdev property since we don't delete bs any more - If (bs-peer) bdrv_make_anon else bdrv_delete to handle removing drives

Re: [Qemu-devel] [PATCH v2] Do not delete BlockDriverState when deleting the drive

* Markus Armbruster arm...@redhat.com [2011-03-15 04:48]: Sorry for the long delay, I was out of action for a week. Ryan Harper ry...@us.ibm.com writes: When removing a drive from the host-side via drive_del we currently have the following path: drive_del qemu_aio_flush

[Qemu-devel] [PATCH v2] Do not delete BlockDriverState when deleting the drive

about the copy retained in the block devices. Reported-by: Marcus Armbruster arm...@redhat.com Signed-off-by: Ryan Harper ry...@us.ibm.com --- v1-v2 - NULL bs-device_name after removing from list to prevent second removal. block.c| 12 +--- block.h|1 + blockdev.c |2

[Qemu-devel] [PATCH v2] Don't allow multiwrites against a block device without underlying medium

If the block device has been closed, we no longer have a medium to submit IO against, check for this before submitting io. This prevents a segfault further in the code where we dereference elements of the block driver. Signed-off-by: Ryan Harper ry...@us.ibm.com --- v1-v2: - move bs-drv

[Qemu-devel] [PATCH] Do not delete BlockDriverState when deleting the drive

about the copy retained in the block devices. This state will be deleted if the guest is asked and responds to a pci device removal request. Reported-by: Markus Armbruster arm...@redhat.com Signed-off-by: Ryan Harper ry...@us.ibm.com --- block.c| 11 --- block.h|1

Re: [Qemu-devel] [PATCH] Fix ATA SMART and CHECK POWER MODE

to see a version that just implemented the changes needed, which AFAICT are mainly the additional attributes and limits. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com

Re: [Qemu-devel] [PATCH v3] Fix ATA SMART and CHECK POWER MODE

)] = smart_attributes[n][i]; Needs one more indent for s-io_b, per CODING_STYLE (4. Block structure) + } } s-io_buffer[362] = 0x02 | (s-smart_autosave?0x80:0x00); if (s-smart_selftest_count == 0) { -- Ryan Harper Software Engineer

Re: [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize

backing_format[16]; /* if non-zero and backing_file exists */ int is_temporary; int media_changed; +int size_changed; BlockDriverState *backing_hd; BlockDriverState *file; -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry

Re: [Qemu-devel] Re: [PATCH] Fix segfault with ram_size 4095M without kvm

* Ryan Harper ry...@us.ibm.com [2011-01-04 09:49]: * Aurelien Jarno aurel...@aurel32.net [2010-12-25 16:37]: On Wed, Dec 08, 2010 at 04:27:45PM -0200, Luiz Capitulino wrote: On Wed, 08 Dec 2010 12:23:12 -0600 Anthony Liguori aligu...@linux.vnet.ibm.com wrote: On 12/08/2010 12:01

Re: [Qemu-devel] Re: [PATCH] Fix segfault with ram_size 4095M without kvm

-bit hosts. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurel...@aurel32.net http://www.aurel33.net -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com

[Qemu-devel] [PATCH] blockdev: check dinfo ptr before using

if drive_get_by_blockdev() actually returns a valid dinfo pointer or not. 1. (qemu) pci_add auto storage file=images/test01.raw,if=virtio,id=block1,snapshot=on (qemu) drive_del block1 (qemu) pci_del 5 *segfault* Signed-off-by: Ryan Harper ry...@us.ibm.com -- Ryan Harper Software Engineer; Linux

Re: [Qemu-devel] [PATCH 00/10] AHCI emulation support v2

need any convincing that we can do better than IDE); just curious. Alex -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ry...@us.ibm.com

Re: [Qemu-devel] Re: [PATCH 0/2] v8 Decouple block device removal from device removal

* Kevin Wolf kw...@redhat.com [2010-11-16 08:05]: Am 16.11.2010 14:51, schrieb Luiz Capitulino: On Fri, 12 Nov 2010 18:38:57 +0100 Kevin Wolf kw...@redhat.com wrote: Am 12.11.2010 18:07, schrieb Ryan Harper: details, details, v8 This patch series decouples the detachment of a block

[Qemu-devel] [PATCH 0/2] v7 Decouple block device removal from device removal

to hmp/qmp interface Changes since v3: - Moved QMP command for drive_unplug() to separate patch Changes since v2: - Added QMP command for drive_unplug() Changes since v1: - CodingStyle fixes - Added qemu_aio_flush() to bdrv_unplug() Signed-off-by: Ryan Harper ry...@us.ibm.com

[Qemu-devel] [PATCH 1/2] Implement drive_del to decouple block removal from device removal

; bdrv_flush() and bdrv_close()). This prevents further IO from being submitted against the host device. Finally, drive_del cleans up pointers between the drive object (host resource) and the device object (guest resource). Signed-off-by: Ryan Harper ry...@us.ibm.com --- blockdev.c | 39

[Qemu-devel] [PATCH 2/2] Add qmp version of drive_del

Signed-off-by: Ryan Harper ry...@us.ibm.com --- qmp-commands.hx | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 793cf1c..1e0d4e9 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -338,6 +338,35

[Qemu-devel] Re: [PATCH 1/2] Implement drive_del to decouple block removal from device removal

* Kevin Wolf kw...@redhat.com [2010-11-12 10:43]: Am 12.11.2010 16:38, schrieb Ryan Harper: Currently device hotplug removal code is tied to device removal via ACPI. All pci devices that are removable via device_del() require the guest to respond to the request. In some cases the guest

[Qemu-devel] [PATCH 2/2] Add qmp version of drive_del

Signed-off-by: Ryan Harper ry...@us.ibm.com --- qmp-commands.hx | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 793cf1c..1e0d4e9 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -338,6 +338,35

[Qemu-devel] [PATCH 0/2] v8 Decouple block device removal from device removal

-off-by: Ryan Harper ry...@us.ibm.com

[Qemu-devel] [PATCH 1/2] Implement drive_del to decouple block removal from device removal

; bdrv_flush() and bdrv_close()). This prevents further IO from being submitted against the host device. Finally, drive_del cleans up pointers between the drive object (host resource) and the device object (guest resource). Signed-off-by: Ryan Harper ry...@us.ibm.com --- blockdev.c | 39

Re: [Qemu-devel] [PATCH 1/2] Fix Block Hotplug race with drive_del()

* Markus Armbruster arm...@redhat.com [2010-11-11 04:48]: Ryan Harper ry...@us.ibm.com writes: * Markus Armbruster arm...@redhat.com [2010-11-10 11:40]: Ryan Harper ry...@us.ibm.com writes: * Markus Armbruster arm...@redhat.com [2010-11-10 06:48]: One real question, and a couple

Re: [Qemu-devel] [PATCH 1/2] Fix Block Hotplug race with drive_del()

* Markus Armbruster arm...@redhat.com [2010-11-10 06:48]: One real question, and a couple of nits. Ryan Harper ry...@us.ibm.com writes: Block hot unplug is racy since the guest is required to acknowlege the ACPI unplug event; this may not happen synchronously with the device removal

Re: [Qemu-devel] [PATCH 1/2] Fix Block Hotplug race with drive_del()

* Markus Armbruster arm...@redhat.com [2010-11-10 11:40]: Ryan Harper ry...@us.ibm.com writes: * Markus Armbruster arm...@redhat.com [2010-11-10 06:48]: One real question, and a couple of nits. Ryan Harper ry...@us.ibm.com writes: Block hot unplug is racy since the guest

Re: [Qemu-devel] [PATCH 1/2] Fix Block Hotplug race with drive_del()

* Markus Armbruster arm...@redhat.com [2010-11-10 11:40]: Ryan Harper ry...@us.ibm.com writes: * Markus Armbruster arm...@redhat.com [2010-11-10 06:48]: One real question, and a couple of nits. Ryan Harper ry...@us.ibm.com writes: Block hot unplug is racy since the guest

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Markus Armbruster arm...@redhat.com [2010-11-08 06:04]: Michael S. Tsirkin m...@redhat.com writes: On Mon, Nov 08, 2010 at 11:32:01AM +0100, Markus Armbruster wrote: Ryan Harper ry...@us.ibm.com writes: * Markus Armbruster arm...@redhat.com [2010-11-06 04:19]: Ryan Harper ry

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Michael S. Tsirkin m...@redhat.com [2010-11-08 10:57]: On Mon, Nov 08, 2010 at 08:02:50AM -0600, Ryan Harper wrote: * Markus Armbruster arm...@redhat.com [2010-11-08 06:04]: Michael S. Tsirkin m...@redhat.com writes: On Mon, Nov 08, 2010 at 11:32:01AM +0100, Markus Armbruster wrote

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Daniel P. Berrange berra...@redhat.com [2010-11-08 11:05]: On Mon, Nov 08, 2010 at 06:56:02PM +0200, Michael S. Tsirkin wrote: On Mon, Nov 08, 2010 at 08:02:50AM -0600, Ryan Harper wrote: * Markus Armbruster arm...@redhat.com [2010-11-08 06:04]: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PATCH 2/2] Add qmp version of drive_del

Signed-off-by: Ryan Harper ry...@us.ibm.com --- qmp-commands.hx | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 793cf1c..1e0d4e9 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -338,6 +338,35

[Qemu-devel] [PATCH 0/2] v6 Decouple block device removal from device removal

since v1: - CodingStyle fixes - Added qemu_aio_flush() to bdrv_unplug() Signed-off-by: Ryan Harper ry...@us.ibm.com

[Qemu-devel] [PATCH 1/2] Fix Block Hotplug race with drive_del()

(BlockDriverState) and guest (DeviceInfo). A subsequent device removal command can be issued to remove the device, to which the guest may or maynot respond, but as long as the unplugged bit is set, no IO will be sumbitted. Signed-off-by: Ryan Harper ry...@us.ibm.com --- block.c |7

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Markus Armbruster arm...@redhat.com [2010-11-06 04:19]: Ryan Harper ry...@us.ibm.com writes: * Markus Armbruster arm...@redhat.com [2010-11-05 11:11]: Ryan Harper ry...@us.ibm.com writes: * Markus Armbruster arm...@redhat.com [2010-11-05 08:28]: I'd be fine with any

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Michael S. Tsirkin m...@redhat.com [2010-11-05 09:18]: On Fri, Nov 05, 2010 at 02:27:49PM +0100, Markus Armbruster wrote: Ryan Harper ry...@us.ibm.com writes: * Michael S. Tsirkin m...@redhat.com [2010-11-03 16:46]: On Wed, Nov 03, 2010 at 03:59:29PM -0500, Ryan Harper wrote

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Markus Armbruster arm...@redhat.com [2010-11-05 08:28]: Ryan Harper ry...@us.ibm.com writes: * Michael S. Tsirkin m...@redhat.com [2010-11-03 16:46]: On Wed, Nov 03, 2010 at 03:59:29PM -0500, Ryan Harper wrote: * Michael S. Tsirkin m...@redhat.com [2010-11-03 13:03]: On Wed, Nov 03

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Markus Armbruster arm...@redhat.com [2010-11-05 11:11]: Ryan Harper ry...@us.ibm.com writes: * Markus Armbruster arm...@redhat.com [2010-11-05 08:28]: I'd be fine with any of these: 1. A new command device_disconnet ID (or similar name) to disconnect device ID from any host

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Michael S. Tsirkin m...@redhat.com [2010-11-03 16:46]: On Wed, Nov 03, 2010 at 03:59:29PM -0500, Ryan Harper wrote: * Michael S. Tsirkin m...@redhat.com [2010-11-03 13:03]: On Wed, Nov 03, 2010 at 12:29:10PM -0500, Ryan Harper wrote: * Markus Armbruster arm...@redhat.com [2010-11-03 11

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Michael S. Tsirkin m...@redhat.com [2010-11-03 02:22]: On Tue, Nov 02, 2010 at 03:23:38PM -0500, Ryan Harper wrote: * Michael S. Tsirkin m...@redhat.com [2010-11-02 14:18]: On Tue, Nov 02, 2010 at 02:01:08PM -0500, Ryan Harper wrote: I like the idea of disconnect; if part

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Markus Armbruster arm...@redhat.com [2010-11-03 11:42]: Ryan Harper ry...@us.ibm.com writes: * Michael S. Tsirkin m...@redhat.com [2010-11-03 02:22]: On Tue, Nov 02, 2010 at 03:23:38PM -0500, Ryan Harper wrote: * Michael S. Tsirkin m...@redhat.com [2010-11-02 14:18]: On Tue, Nov 02

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Michael S. Tsirkin m...@redhat.com [2010-11-03 13:03]: On Wed, Nov 03, 2010 at 12:29:10PM -0500, Ryan Harper wrote: * Markus Armbruster arm...@redhat.com [2010-11-03 11:42]: Ryan Harper ry...@us.ibm.com writes: * Michael S. Tsirkin m...@redhat.com [2010-11-03 02:22]: On Tue

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Markus Armbruster arm...@redhat.com [2010-11-02 04:40]: Ryan Harper ry...@us.ibm.com writes: * Markus Armbruster arm...@redhat.com [2010-10-29 11:11]: Ryan Harper ry...@us.ibm.com writes: * Markus Armbruster arm...@redhat.com [2010-10-29 09:13]: [Note cc: Michael] Ryan

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Michael S. Tsirkin m...@redhat.com [2010-11-02 08:59]: On Tue, Nov 02, 2010 at 08:46:22AM -0500, Ryan Harper wrote: * Markus Armbruster arm...@redhat.com [2010-11-02 04:40]: I'd like to have some consistency among net, block and char device commands, i.e. a common set of operations

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Michael S. Tsirkin m...@redhat.com [2010-11-02 10:56]: On Tue, Nov 02, 2010 at 09:22:01AM -0500, Ryan Harper wrote: * Michael S. Tsirkin m...@redhat.com [2010-11-02 08:59]: On Tue, Nov 02, 2010 at 08:46:22AM -0500, Ryan Harper wrote: * Markus Armbruster arm...@redhat.com [2010-11-02 04

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

host resources separate from the device removal *if* we're going to retain the guest notification. If we don't care to notify the guest, then we can just do device removal without notifying the guest and be done with it. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Michael S. Tsirkin m...@redhat.com [2010-11-02 14:18]: On Tue, Nov 02, 2010 at 02:01:08PM -0500, Ryan Harper wrote: I like the idea of disconnect; if part of the device_del method was to invoke a disconnect method, we could implement that for block, net, etc

Re: [Qemu-devel] [PATCH 2/3] v2 Fix Block Hotplug race with drive_unplug()

* Markus Armbruster arm...@redhat.com [2010-10-29 09:08]: Ryan Harper ry...@us.ibm.com writes: Block hot unplug is racy since the guest is required to acknowlege the ACPI unplug event; this may not happen synchronously with the device removal command This series aims to close a gap

[Qemu-devel] [PATCH 0/2] v5 Decouple block device removal from device removal

- Added qemu_aio_flush() to bdrv_unplug() Signed-off-by: Ryan Harper ry...@us.ibm.com

[Qemu-devel] [PATCH 1/2] Fix Block Hotplug race with drive_unplug()

the guest may or maynot respond, but as long as the unplugged bit is set, no IO will be sumbitted. Signed-off-by: Ryan Harper ry...@us.ibm.com --- block.c |7 +++ block.h |1 + blockdev.c | 17 + blockdev.h |1 + hmp-commands.hx | 20

[Qemu-devel] [PATCH 2/2] Add qmp version of drive_unplug

Signed-off-by: Ryan Harper ry...@us.ibm.com --- qmp-commands.hx | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 793cf1c..a1f7b2f 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -338,6 +338,37

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Markus Armbruster arm...@redhat.com [2010-10-29 09:13]: [Note cc: Michael] Ryan Harper ry...@us.ibm.com writes: This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires the guest

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

* Markus Armbruster arm...@redhat.com [2010-10-29 11:11]: Ryan Harper ry...@us.ibm.com writes: * Markus Armbruster arm...@redhat.com [2010-10-29 09:13]: [Note cc: Michael] Ryan Harper ry...@us.ibm.com writes: If I understand your patch correctly, the difference between your

[Qemu-devel] [PATCH 2/3] v2 Fix Block Hotplug race with drive_unplug()

the guest may or maynot respond, but as long as the unplugged bit is set, no IO will be sumbitted. Changes since v1: - Added qemu_aio_flush() before bdrv_flush() to wait on pending io Signed-off-by: Ryan Harper ry...@us.ibm.com --- block.c |7 +++ block.h |1

[Qemu-devel] [PATCH 3/3] Add qmp version of drive_unplug

Signed-off-by: Ryan Harper ry...@us.ibm.com --- qmp-commands.hx | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 793cf1c..e8f3d4a 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -338,6 +338,32

[Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

QMP command for drive_unplug() to separate patch Changes since v2: - Added QMP command for drive_unplug() Changes since v1: - CodingStyle fixes - Added qemu_aio_flush() to bdrv_unplug() Signed-off-by: Ryan Harper ry...@us.ibm.com

[Qemu-devel] [PATCH 1/3] v2 Add drive_get_by_id

Add a function to find a drive by id string. Changes since v1: -Coding Style fix Signed-off-by: Ryan Harper ry...@us.ibm.com --- blockdev.c | 13 + blockdev.h |1 + 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index ff7602b..5fc3b9b

  1   2   >