[PULL 1/1] usb-braille: Better explain that one also has to create a chardev backend

2022-09-05 Thread Samuel Thibault
Users have reported not to understand the documentation. This completes it to give an explicit example how one is supposed to set up a virtual braille USB device. Signed-off-by: Samuel Thibault --- docs/system/devices/usb.rst | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions

[PULL 0/1] baum: better document usb-braille configuration

2022-09-05 Thread Samuel Thibault
The following changes since commit 3e01455edd5fce06c14e2926b6ef408d9a94c9fb: usb-braille: Better explain that one also has to create a chardev backend (2022-09-06 00:09:50 +0200) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault

Re: slirp: Can I get IPv6-only DHCP working?

2022-08-25 Thread Samuel Thibault
Peter Delevoryas, le jeu. 25 août 2022 16:15:26 -0700, a ecrit: > On Fri, Aug 26, 2022 at 12:56:10AM +0200, Samuel Thibault wrote: > > Peter Delevoryas, le jeu. 25 août 2022 15:38:53 -0700, a ecrit: > > > It seems like there's support for an IPv6 dns proxy, and there'

Re: slirp: Can I get IPv6-only DHCP working?

2022-08-25 Thread Samuel Thibault
Hello, Peter Delevoryas, le jeu. 25 août 2022 15:38:53 -0700, a ecrit: > It seems like there's support for an IPv6 dns proxy, and there's literally a > file called "dhcpv6.c" in slirp, but it has a comment saying it only supports > whatever is necessary for TFTP network boot I guess. For which

Re: [PATCH v2 for-7.2 0/6] Drop libslirp submodule

2022-08-24 Thread Samuel Thibault
elated tests and finally remove the submodule now. Acked-by: Samuel Thibault Thanks! > v2: > - Added patches to clean up and adapt the tests > - Rebased the removal patch to the latest version of the master branch > > Thomas Huth (6): > tests/docker: Update the debian-all-

Re: [PATCH 4/4] slirp: Add oob-eth-addr to -netdev options

2022-06-18 Thread Samuel Thibault
Peter Delevoryas, le mer. 15 juin 2022 18:05:26 -0700, a ecrit: > With this change, you can now request the out-of-band MAC address from > slirp in fby35-bmc: > > wget > https://github.com/facebook/openbmc/releases/download/openbmc-e2294ff5d31d/fby35.mtd > qemu-system-arm -machine

Re: [PATCH 3/4] slirp: Add mfr-id to -netdev options

2022-06-18 Thread Samuel Thibault
Peter Delevoryas, le mer. 15 juin 2022 18:05:25 -0700, a ecrit: > This lets you set the manufacturer's ID for a slirp netdev, which can be > queried from the guest through the Get Version ID NC-SI command. For > example, by setting the manufacturer's ID to 0x8119: > > wget >

Re: [PATCH 2/4] slirp: Update SlirpConfig version to 5

2022-06-18 Thread Samuel Thibault
Hello, Peter Delevoryas, le mer. 15 juin 2022 18:05:24 -0700, a ecrit: > I think we probably need a new Slirp release > (4.8.0) and a switch statement here instead, right? > > So that we can preserve the behavior for 4.7.0? Yes, that's the idea. Samuel

Re: [RFC PATCH 3/4] net: slirp: add support for CFI-friendly timer API

2022-04-26 Thread Samuel Thibault
ort the new API so that CFI can be made compatible with using a system > libslirp. > > Signed-off-by: Paolo Bonzini Reviewed-by: Samuel Thibault > --- > net/slirp.c | 41 - > 1 file changed, 40 insertions(+), 1 deletion(-) > >

Re: [RFC PATCH 2/4] net: slirp: switch to slirp_new

2022-04-26 Thread Samuel Thibault
Paolo Bonzini, le mar. 12 avril 2022 14:13:35 +0200, a ecrit: > Replace slirp_init with slirp_new, so that a more recent cfg.version > can be specified. > > Signed-off-by: Paolo Bonzini Reviewed-by: Samuel Thibault > --- > net/slirp.c | 27 +-- >

Re: [RFC PATCH 4/4] net: slirp: allow CFI with libslirp >= 4.7

2022-04-26 Thread Samuel Thibault
tem libslirp. > > Signed-off-by: Paolo Bonzini Reviewed-by: Samuel Thibault > --- > meson.build | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/meson.build b/meson.build > index 861de93c4f..92a83580a3 100644 >

Re: [RFC PATCH 1/4] net: slirp: introduce a wrapper struct for QemuTimer

2022-04-26 Thread Samuel Thibault
> Signed-off-by: Paolo Bonzini Reviewed-by: Samuel Thibault > --- > net/slirp.c | 19 ++- > 1 file changed, 14 insertions(+), 5 deletions(-) > > diff --git a/net/slirp.c b/net/slirp.c > index bc5e9e4f77..f1e25d741f 100644 > --- a/net/slirp.c > +++ b/n

Re: [PATCH] configure: Disable capstone and slirp in the --without-default-features mode

2022-02-21 Thread Samuel Thibault
: fdt is *not* changed accordingly since this affects the targets > that we can build, so disabling fdt automatically here might have > unexpected side-effects for the users. > > Signed-off-by: Thomas Huth Acked-by: Samuel Thibault > --- > I thought I sent out that patch a coup

Re: [PATCH] ide: Cap LBA28 capacity announcement to 2^28-1

2021-10-05 Thread Samuel Thibault
Ping? Samuel Thibault, le mar. 24 août 2021 12:43:44 +0200, a ecrit: > The LBA28 capacity (at offsets 60/61 of identification) is supposed to > express the maximum size supported by LBA28 commands. If the device is > larger than this, we have to cap it to 2^28-1. > > At least

Re: [PATCH] net/slirp: Use newer slirp_*_hostxfwd API

2021-10-05 Thread Samuel Thibault
irp_*_hostxfwd API meant for > > address-agnostic forwarding instead of the is_udp parameter which is > > limited to just TCP/UDP. > > > > Signed-off-by: Nicholas Ngai Reviewed-by: Samuel Thibault > > --- > > net/slirp.c | 64 +

Re: [PATCH] ide: Cap LBA28 capacity announcement to 2^28-1

2021-09-05 Thread Samuel Thibault
Ping? Samuel Thibault, le mar. 24 août 2021 12:43:44 +0200, a ecrit: > The LBA28 capacity (at offsets 60/61 of identification) is supposed to > express the maximum size supported by LBA28 commands. If the device is > larger than this, we have to cap it to 2^28-1. > > At least

[PATCH] ide: Cap LBA28 capacity announcement to 2^28-1

2021-08-24 Thread Samuel Thibault
, using LBA28 for sectors that don't need LBA48. This commit thus fixes NetBSD access to disks larger than 128GiB. Signed-off-by: Samuel Thibault --- hw/ide/core.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index fd69ca3167..e28f8aad61

Re: [OSS-Fuzz] Assertion Failure: !in6_zero(_addr) (#111)

2021-05-08 Thread Samuel Thibault
Hello, Alexander Bulekov, le lun. 03 mai 2021 16:09:33 -0400, a ecrit: > Forwarding this along to the list, so it doesn't get burried during the > gitlab issue migration. Thanks! Pushed a proposed fix on https://gitlab.freedesktop.org/slirp/libslirp/-/merge_requests/86 Samuel > -

Re: [PATCH 03/23] chardev/baum: Use definitions to avoid dynamic stack allocation

2021-05-05 Thread Samuel Thibault
Marc-André Lureau, le jeu. 06 mai 2021 01:27:25 +0400, a ecrit: > @@ -408,7 +408,7 @@ static int baum_eat_packet(BaumChardev *baum, const > uint8_t *buf, int len) >          } >          timer_del(baum->cellCount_timer); > > -        memset(zero, 0, sizeof(zero)); > +     

Re: [PATCH 04/23] chardev/baum: Avoid dynamic stack allocation

2021-05-05 Thread Samuel Thibault
Philippe Mathieu-Daudé, le mer. 05 mai 2021 23:10:28 +0200, a ecrit: > Use autofree heap allocation instead of variable-length > array on the stack. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Samuel Thibault > --- > chardev/baum.c | 3 ++- > 1 file change

Re: [PATCH 03/23] chardev/baum: Use definitions to avoid dynamic stack allocation

2021-05-05 Thread Samuel Thibault
; > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Samuel Thibault > --- > chardev/baum.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/chardev/baum.c b/chardev/baum.c > index adc3d7b3b56..0822e9ed5f3 100644 > --- a/chardev/ba

Re: [PATCH 02/23] chardev/baum: Replace magic values by X_MAX / Y_MAX definitions

2021-05-05 Thread Samuel Thibault
Philippe Mathieu-Daudé, le mer. 05 mai 2021 23:10:26 +0200, a ecrit: > Replace '84' magic value by the X_MAX definition, and '1' by Y_MAX. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Samuel Thibault > --- > chardev/baum.c | 11 +++ > 1 file changed,

Re: [PATCH] net/slirp: Fix incorrect permissions on samba >= 2.0.5

2021-04-30 Thread Samuel Thibault
Laurent Vivier, le ven. 30 avril 2021 18:48:29 +0200, a ecrit: > CC: +Samuel I don't know the smb code at all. > Le 23/02/2021 à 03:41, Niklas Hambüchen a écrit : > > As the added commend and `man smb.conf` explain, starting > > with that samba version, `force user` must be configured > > in

Re: [PATCH 3/4] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed)

2021-03-11 Thread Samuel Thibault
Gerd Hoffmann, le jeu. 11 mars 2021 12:37:38 +0100, a ecrit: > Which would also drop support for serial braille devices. Not sure > how much of a problem that would be these days. It is an important concern: we also need to be able to test braille devices connected through serial. Samuel

Re: [PATCH] baum: Fix crash when Braille output is not available

2021-03-10 Thread Samuel Thibault
Peter Maydell, le mer. 10 mars 2021 17:18:11 +, a ecrit: > On Wed, 10 Mar 2021 at 16:08, Samuel Thibault > wrote: > > > > When Braille output is not available, the backend properly reports being > > unable to be created, but 5f8e93c3e262 ("util/qemu-timer

[PATCH] baum: Fix crash when Braille output is not available

2021-03-10 Thread Samuel Thibault
th calling it on baum->cellCount_timer. Signed-off-by: Samuel Thibault --- chardev/baum.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/chardev/baum.c b/chardev/baum.c index 5deca778bc..aca5bf12fb 100644 --- a/chardev/baum.c +++ b/chardev/baum.c @@ -631,7 +631,9 @

Re: [PATCH v2] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed)

2021-03-10 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 10 mars 2021 15:31:48 +, a ecrit: > On Wed, Mar 10, 2021 at 04:26:46PM +0100, Paolo Bonzini wrote: > > On 10/03/21 16:02, Samuel Thibault wrote: > > > > > When trying to remove the -usbdevice option, there were complaints > > &g

Re: [PATCH v2] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed)

2021-03-10 Thread Samuel Thibault
Markus Armbruster, le mer. 10 mars 2021 14:17:48 +0100, a ecrit: > Thomas Huth writes: > > When trying to remove the -usbdevice option, there were complaints that > > "-usbdevice braille" is still a very useful shortcut for some people. > > Pointer? I missed it. For instance

Re: [PATCH v2 4/4] slirp: feature detection for smbd

2021-03-09 Thread Samuel Thibault
acro. Allows slirp smb feature to be disabled manually as well. > > > > > > Signed-off-by: Joelle van Dyne > > > --- > > > configure | 26 +++--- > > > meson.build | 2 +- > > > net/slirp.c | 16 > > > 3 f

Re: [PATCH 4/4] slirp: feature detection for smbd

2021-03-08 Thread Samuel Thibault
Joelle van Dyne, le dim. 07 mars 2021 22:48:21 -0800, a ecrit: > Replace Windows specific macro with a more generic feature detection > macro. Allows slirp smb feature to be disabled manually as well. > > Signed-off-by: Joelle van Dyne Acked-by: Samuel Thibault > --- >

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-06 Thread Samuel Thibault
Hello, Doug Evans, le ven. 05 mars 2021 17:00:13 -0800, a ecrit: > Is it possible for QEMU to lazily determine the guest's IPv6 > address? I.e., postpone the ""->guest address mapping until it's > needed and then, say, take the first entry in the NDP table? That would probably be possible, yes,

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-05 Thread Samuel Thibault
Doug Evans, le ven. 05 mars 2021 16:05:05 -0800, a ecrit: > Given that the code is not supposed to be able to know brackets were present > (they're stripped off early on), what does the above mean w.r.t. the guest? > For the host we can have "" mean listen on both IPv4 and IPv6 > (by default,

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-05 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 03 mars 2021 18:11:41 +, a ecrit: > On Wed, Mar 03, 2021 at 10:06:50AM -0800, Doug Evans wrote: > > On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault > > wrote: > > > > > > + Examples: > > > > + hostfwd_add net0 tcp:12

[Bug 1917442] Re: [AHCI] crash when running a GNU/Hurd guest

2021-03-02 Thread Samuel thibault
Note: this is using the rump ahci driver. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1917442 Title: [AHCI] crash when running a GNU/Hurd guest Status in QEMU: New Bug description: QEMU

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-01 Thread Samuel Thibault
Samuel Thibault, le lun. 01 mars 2021 17:27:47 +0100, a ecrit: > Doug Evans, le lun. 01 mars 2021 08:23:03 -0800, a ecrit: > > On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault <[1]samuel.thiba...@gnu.org> > > wrote: > > > > [...] > > > Note that

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-01 Thread Samuel Thibault
Samuel Thibault, le lun. 01 mars 2021 17:26:23 +0100, a ecrit: > We could make libslirp enable the IPV6ONLY flag to avoid that, and > make qemu pass an AF_UNSPEC address for the ipv4+ipv6 case, in which > case libslirp wouldn't set IPV6ONLY. Ah, no, AF_UNSPEC would not allow to specify

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-01 Thread Samuel Thibault
Doug Evans, le lun. 01 mars 2021 08:23:03 -0800, a ecrit: > On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault <[1]samuel.thiba...@gnu.org> > wrote: > > [...] > > Note that one issue I am leaving for later (i.e., I don't want to drag > this >

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-01 Thread Samuel Thibault
Doug Evans, le lun. 01 mars 2021 08:07:19 -0800, a ecrit: > Are there any users that this functional change would break? > [Previously the empty address meant qemu would only listen on ipv4 addr-any.] One case that could be broken would be a user having already another service listening on

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-03-01 Thread Samuel Thibault
Markus Armbruster, le lun. 01 mars 2021 09:15:41 +0100, a ecrit: > Samuel Thibault writes: > > Specifying [127.0.0.1] would be odd, but for instance > > > > ssh localhost -D '[127.0.0.1]':23456 > > > > happens to listen on 127.0.0.1. So I would say that common pr

Re: [PATCH v2 1/2] net/slirp.c: Refactor address parsing

2021-02-28 Thread Samuel Thibault
Hello, Doug Evans, le lun. 08 févr. 2021 10:59:01 -0800, a ecrit: > Samuel, how do qemu patches involving libslirp changes usually work? Well, we haven't had many yet actually :) > Should I have held off submitting the qemu patch until the libslirp > prerequisite has been added to qemu's tree,

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-02-28 Thread Samuel Thibault
Samuel Thibault, le dim. 28 févr. 2021 22:39:57 +0100, a ecrit: > It was simpler to have e.g. udp_listen and udp6_listen separate to keep > uint32_t / in6_addr parameters, but there is no strict reason for this: > the haddr is only passed to the bind() call, and the laddr is only &

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-02-28 Thread Samuel Thibault
Hello, Daniel P. Berrangé, le lun. 22 févr. 2021 09:39:41 +, a ecrit: > In general callers shouldn't care about which format was parsed. The use > of [] is just a mechanism to reliably separate the port from the address. > Once you have the address part getaddrinfo() will reliably parse the >

Re: [PATCH v2 2/2] net: Add -ipv6-hostfwd option, ipv6_hostfwd_add/remove commands

2021-02-03 Thread Samuel Thibault
Doug Evans, le mer. 03 févr. 2021 13:37:29 -0800, a ecrit: > @@ -1392,6 +1392,34 @@ SRST >Remove host-to-guest TCP or UDP redirection. > ERST > > +#ifdef CONFIG_SLIRP > +{ > +.name = "ipv6_hostfwd_add", > +.args_type = "arg1:s,arg2:s?", > +.params =

Re: [PATCH v2 1/2] net/slirp.c: Refactor address parsing

2021-02-03 Thread Samuel Thibault
Doug Evans, le mer. 03 févr. 2021 13:37:28 -0800, a ecrit: > ... in preparation for adding ipv6 host forwarding support. Reviewed-by: Samuel Thibault except > diff --git a/slirp b/slirp > index 8f43a99191..358c0827d4 16 > --- a/slirp > +++ b/slirp > @@ -1 +1 @@ &g

Re: [RFC] Change default ipv6 network from fec0/10 (site local) to fe80/10 (link local)

2021-01-27 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, le mer. 27 janv. 2021 22:46:13 +0100, a ecrit: > On 1/27/21 8:13 PM, Doug Evans wrote: > > I happened to notice QEMU's default for the ipv6 network is fec0::/10 > > which is deprecated (RFC3879). > > I think(!) an obvious replacement is fe80::/10, link local.

Re: [PATCH] net/slirp.c: Fix spelling error in error message

2021-01-21 Thread Samuel Thibault
Doug Evans, le jeu. 21 janv. 2021 16:42:51 -0800, a ecrit: > DNS should be DHCP > > Signed-off-by: Doug Evans Reviewed-by: Samuel Thibault > --- > net/slirp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/slirp.c b/net/slirp.c > i

Re: [PATCH v2] meson: fix ncurses detection on macOS

2020-12-30 Thread Samuel Thibault
fstaedtler > Cc: Peter Maydell > Cc: Philippe Mathieu-Daudé > Cc: Samuel Thibault > Cc: Yonggang Luo Reviewed-by: Samuel Thibault > --- > meson.build | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meson.build b/meson.build >

Re: [PATCH] meson: fix ncurses detection on macOS

2020-12-28 Thread Samuel Thibault
Philippe Mathieu-Daudé, le lun. 28 déc. 2020 18:20:13 +0100, a ecrit: > On 12/28/20 4:16 PM, Chris Hofstaedtler wrote: > > Without this, meson fails with "curses package not usable" > > when using ncurses 6.2. Apparently the wide functions > > (addwstr, etc) are hidden behind the extra define, and

Re: Does QEMU's coverity-scan run need to track coverity issues in dtb or slirp ?

2020-11-02 Thread Samuel Thibault
Hello, Peter Maydell, le lun. 02 nov. 2020 19:54:14 +, a ecrit: > Do dtc and slirp as upstream projects already track Coverity issues We started tracking them yes. Samuel

Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response

2020-10-26 Thread Samuel Thibault
Mark Cave-Ayland, le lun. 26 oct. 2020 13:40:05 +, a ecrit: > On 26/10/2020 13:00, Jason Andryuk wrote: > > On Mon, Oct 26, 2020 at 7:21 AM Samuel Thibault > > wrote: > > > Aurelien, you introduced the "| 1" in > > > > > > commit a

Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response

2020-10-26 Thread Samuel Thibault
Mark Cave-Ayland, le lun. 26 oct. 2020 10:58:43 +, a ecrit: > On 26/10/2020 09:54, Samuel Thibault wrote: > > Mark Cave-Ayland, le lun. 26 oct. 2020 08:34:00 +, a ecrit: > > > The FTDI_GET_MDM_ST response should only return a single byte indicating > > > the &g

Re: [PATCH 0/9] dev-serial: minor fixes and improvements

2020-10-26 Thread Samuel Thibault
Hello, Mark Cave-Ayland, le lun. 26 oct. 2020 08:33:52 +, a ecrit: > This series comes from a client project that I have been working on over the > past few months which involves communicating with serial hardware and > associated simulators using the QEMU USB serial device. Thanks for

Re: [PATCH 9/9] dev-serial: store flow control and xon/xoff characters

2020-10-26 Thread Samuel Thibault
in the Linux > ftdi_sio.h header file. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault > --- > hw/usb/dev-serial.c | 38 +++--- > hw/usb/trace-events | 2 ++ > 2 files changed, 37 insertions(+), 3 deletions(-) > > diff -

Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response

2020-10-26 Thread Samuel Thibault
Hello, (Cc-ing Aurelien who introduced the support for modem control, and Jason who added the missing THRE and TEMT flags). Mark Cave-Ayland, le lun. 26 oct. 2020 08:34:00 +, a ecrit: > The FTDI_GET_MDM_ST response should only return a single byte indicating the > modem status with bit 0

Re: [PATCH 7/9] dev-serial: add support for setting data_bits in QEMUSerialSetParams

2020-10-26 Thread Samuel Thibault
Mark Cave-Ayland, le lun. 26 oct. 2020 08:33:59 +, a ecrit: > Also implement the behaviour reported in Linux's ftdi_sio.c whereby if an > invalid > data_bits value is provided then the hardware defaults to using 8. > > Signed-off-by: Mark Cave-Ayland Reviewed-by:

Re: [PATCH 6/9] dev-serial: add always-plugged property to ensure USB device is always attached

2020-10-26 Thread Samuel Thibault
t; chardev. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault > --- > hw/usb/dev-serial.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c > index 92c35615eb..919e25e1d9 100644 > -

Re: [PATCH 4/9] dev-serial: add trace-events for baud rate and data parameters

2020-10-26 Thread Samuel Thibault
Mark Cave-Ayland, le lun. 26 oct. 2020 08:33:56 +, a ecrit: > Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault > --- > hw/usb/dev-serial.c | 3 +++ > hw/usb/trace-events | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/hw/usb/dev-serial.c

Re: [PATCH 5/9] dev-serial: replace DeviceOutVendor/DeviceInVendor with equivalent macros from usb.h

2020-10-26 Thread Samuel Thibault
Mark Cave-Ayland, le lun. 26 oct. 2020 08:33:57 +, a ecrit: > The DeviceOutVendor and DeviceInVendor macros can be replaced with their > equivalent VendorDeviceOutRequest and VendorDeviceRequest macros from usb.h. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Sam

Re: [PATCH 3/9] dev-serial: convert from DPRINTF to trace-events

2020-10-26 Thread Samuel Thibault
Mark Cave-Ayland, le lun. 26 oct. 2020 08:33:55 +, a ecrit: > Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault > --- > hw/usb/dev-serial.c | 28 ++-- > hw/usb/trace-events | 8 > 2 files changed, 22 insertions(+), 14 deletio

Re: [PATCH 2/9] dev-serial: use USB_SERIAL QOM macro for USBSerialState assignments

2020-10-26 Thread Samuel Thibault
Mark Cave-Ayland, le lun. 26 oct. 2020 08:33:54 +, a ecrit: > Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel Thibault > --- > hw/usb/dev-serial.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/usb/dev-serial.c b/hw/usb/de

Re: [PATCH 1/9] dev-serial: style changes to improve readability and checkpatch fixes

2020-10-26 Thread Samuel Thibault
Mark Cave-Ayland, le lun. 26 oct. 2020 08:33:53 +, a ecrit: > Signed-off-by: Mark Cave-Ayland Reviewed-by: Samuel thibault > --- > hw/usb/dev-serial.c | 230 > 1 file changed, 126 insertions(+), 104 deletions(-) > > diff

[PATCH] ui: Fix default window_id value

2020-09-22 Thread Samuel Thibault
./chardev/baum.c expects the default window_id value to be -1, and not 0 which could be confused with a proper window id (when numbered from 0 by the ui backend). This fixes getting Braille output with the curses and gtk frontends. Signed-off-by: Samuel Thibault Fixes: f29b3431f62 ("co

[PATCH] ui: Fix default window_id value

2020-09-14 Thread Samuel Thibault
./chardev/baum.c expects the default window_id value to be -1, and not 0 which could be confused with a proper window id (when numbered from 0 by the ui backend). This fixes getting Braille output with the curses and gtk frontends. Signed-off-by: Samuel Thibault --- It would be useful

Re: Is traceroute supposed to work in user mode networking (slirp) ?

2020-07-19 Thread Samuel Thibault
Ottavio Caruso, le dim. 19 juil. 2020 12:07:21 +0100, a ecrit: > On Sun, 19 Jul 2020 at 03:50, Samuel Thibault wrote: > > Ottavio Caruso, le mar. 14 juil. 2020 12:15:48 +0100, a ecrit: > > > I cannot get traceroute to work with standard udp from any of my > > > guest

Re: Is traceroute supposed to work in user mode networking (slirp) ?

2020-07-18 Thread Samuel Thibault
Hello, Ottavio Caruso, le mar. 14 juil. 2020 12:15:48 +0100, a ecrit: > I cannot get traceroute to work with standard udp from any of my > guests. > > $ traceroute 8.8.8.8 > traceroute to 8.8.8.8 (8.8.8.8), 64 hops max, 40 byte packets > 1 * * * That was because - libslirp was not forwarding

Re: [PATCH v2] slirp: update submodule to v4.2.0 + mingw-fix

2020-03-18 Thread Samuel Thibault
; Prasad J Pandit (4): > slirp: ncsi: compute checksum for valid data length > slirp: use correct size while emulating IRC commands > slirp: use correct size while emulating commands > slirp: tftp: restrict relative path access > > Renzo Davoli (2): > Add sl

Re: [PATCH 4/4] usb-serial: Fix timeout closing the device

2020-03-14 Thread Samuel Thibault
. > > Signed-off-by: Jason Andryuk Reviewed-by: Samuel Thibault > --- > Looking at a USB dump for a real FTDI USB adapter, I see these bits set > in all the bulk URBs where QEMU currently has them clear. > --- > hw/usb/dev-serial.c | 2 +- > 1 file changed, 1 inser

Re: [PATCH 3/4] usb-serial: Increase receive buffer to 496

2020-03-14 Thread Samuel Thibault
to 496 ( 512 - 2 * 8 ). > > Signed-off-by: Jason Andryuk Reviewed-by: Samuel Thibault > --- > hw/usb/dev-serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c > index 96b6c34202..ef33bcd127 100644 &g

Re: [PATCH 2/4] usb-serial: chunk data to wMaxPacketSize

2020-03-13 Thread Samuel Thibault
; 8 * 2 byte headers). Since usb-serial only buffers 384 bytes of data, > usb-serial will pass in 6 64 byte blocks and 1 12 byte partial block for > 462 bytes max. > > Signed-off-by: Jason Andryuk Reviewed-by: Samuel Thibault > --- > hw/usb/dev-serial.c | 43

Re: [PATCH 1/4] usb-serial: Move USB_TOKEN_IN into a helper function

2020-03-13 Thread Samuel Thibault
Jason Andryuk, le jeu. 12 mars 2020 08:55:20 -0400, a ecrit: > We'll be adding a loop, so move the code into a helper function. breaks > are replaced with returns. > > Signed-off-by: Jason Andryuk Reviewed-by: Samuel Thibault > --- > hw/usb

Re: [PATCH v2 07/30] qapi/block-core.json: Use literal block for ascii art

2020-02-16 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, le lun. 17 févr. 2020 01:44:35 +0100, a ecrit: > On Sat, Feb 15, 2020 at 10:01 PM Aleksandar Markovic > wrote: > > 9:56 PM Sub, 15.02.2020. Philippe Mathieu-Daudé > > је написао/ла: > > > On Fri, Feb 14, 2020 at 12:04 AM Aleksandar Markovic > > > wrote: > > > >

[Bug 1812451] Re: In windows host, tftp arbitrary file read vulnerability

2020-01-20 Thread Samuel thibault
This is fixed upstream by https://gitlab.freedesktop.org/slirp/libslirp/commit/14ec36e107a8c9af7d0a80c3571fe39b291ff1d4 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1812451 Title: In windows

Re: [PATCH] build-sys: do not include Windows SLIRP dependencies in $LIBS

2019-12-11 Thread Samuel Thibault
S to slirp_libs. > > Based on a patch by Marc-André Lureau. > > Signed-off-by: Paolo Bonzini Acked-by: Samuel Thibault (I don't have a win environment to test this) > --- > configure | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/conf

Re: Braille device (chardev/baum.c) is unable to detect the TTY correctly and does not act on graphic console connect/disconnect

2019-11-14 Thread Samuel Thibault
Samuel Thibault, le jeu. 14 nov. 2019 14:27:12 +0100, a ecrit: > Samuel Thibault, le jeu. 14 nov. 2019 14:08:41 +0100, a ecrit: > > The way to properly fix it is to add a brlapi channel to spice: > > And that would be workable through a spice agent as well, so that > braille ma

Re: Braille device (chardev/baum.c) is unable to detect the TTY correctly and does not act on graphic console connect/disconnect

2019-11-14 Thread Samuel Thibault
Samuel Thibault, le jeu. 14 nov. 2019 14:08:41 +0100, a ecrit: > The way to properly fix it is to add a brlapi channel to spice: And that would be workable through a spice agent as well, so that braille management from orca running inside the guest could talk directly through to brltty runn

Re: Braille device (chardev/baum.c) is unable to detect the TTY correctly and does not act on graphic console connect/disconnect

2019-11-14 Thread Samuel Thibault
Hello, Teemu Kuusisto, le jeu. 14 nov. 2019 14:09:15 +0200, a ecrit: > As a blind developer I would be very happy to use QEMU's baum chardev for a > braille display. Unfortunately, this device fails to detect the tty in which > the spice client is running. Ah indeed that case was never looked

Re: [PATCH] MAINTAINERS: slirp: Remove myself as maintainer

2019-11-11 Thread Samuel Thibault
Thomas Huth, le lun. 11 nov. 2019 14:15:36 +0100, a ecrit: > On 11/11/2019 08.57, Jan Kiszka wrote: > > May I point out that this one was never merged? > > > > Sorry, I really can't help in this area anymore. > > I'm planning to send a "qtest + misc" PULL request tomorrow ... I can > add the

Re: [PATCH v4] smb daemon get additional command line parameters from env variable

2019-11-02 Thread Samuel Thibault
Jordi Pujol, le sam. 02 nov. 2019 08:41:52 +0100, a ecrit: > @@ -909,6 +910,12 @@ static int slirp_smb(SlirpState* s, cons > CONFIG_SMBD_COMMAND, s->smb_dir, smb_conf); > g_free(smb_conf); > > +options = g_getenv("SMBDOPTIONS"); > +if (options) { > +smb_cmdline

Re: [PATCH v3] smb daemon get additional command line parameters from env variable

2019-11-01 Thread Samuel Thibault
Jordi Pujol, le ven. 01 nov. 2019 15:38:19 +0100, a ecrit: > +options = g_getenv("SMBDOPTIONS"); > +if (options) { > +smb_cmdline = g_strdup_printf("%s %s", smb_cmdline, options); > +} > +g_free(options); But then do not free it :) Samuel

Re: [PATCH v2] smb daemon get additional command line parameters from env variable

2019-10-31 Thread Samuel Thibault
Hello, Jordi Pujol, le jeu. 31 oct. 2019 14:33:00 +0100, a ecrit: > The smbd daemon takes additional command line options > from environment variable SMBDOPTIONS. > Set the environment variable SMBDOPTIONS before executing qemu. > > Example: > > export SMBDOPTIONS="--option='server min

Re: Python 2 and test/vm/netbsd

2019-10-22 Thread Samuel Thibault
Eduardo Habkost, le ven. 18 oct. 2019 13:41:43 -0300, a ecrit: > On Fri, Oct 18, 2019 at 06:00:19PM +0200, Samuel Thibault wrote: > > It was implemented at the time of introduction of IPv6 in SLIRP. Perhaps > > NetBSD has a slightly different behavior which makes the implemen

Re: Python 2 and test/vm/netbsd

2019-10-22 Thread Samuel Thibault
Samuel Thibault, le ven. 18 oct. 2019 18:00:19 +0200, a ecrit: > Philippe Mathieu-Daudé, le ven. 18 oct. 2019 16:58:00 +0200, a ecrit: > > On 10/18/19 4:29 PM, Eduardo Habkost wrote: > > > In addition to that, the connect() error should be generating a > > > ICMP6_UNRE

Re: Python 2 and test/vm/netbsd

2019-10-18 Thread Samuel Thibault
Philippe Mathieu-Daudé, le ven. 18 oct. 2019 16:58:00 +0200, a ecrit: > On 10/18/19 4:29 PM, Eduardo Habkost wrote: > > On Fri, Oct 18, 2019 at 12:44:39PM +0200, Gerd Hoffmann wrote: > > >Hi, > > > > > > > > Running with V=1, I see packages being downloaded at reasonable > > > > > speeds,

Re: [PATCH v2 2/2] curses: correctly pass the color pair to setcchar()

2019-10-13 Thread Samuel Thibault
ing PAIR_NUMBER() to retrieve the color pair > number from the chtype value, and then passes that value as an argument > to setcchar(). > > Signed-off-by: Matthew Kilgore Reviewed-by: Samuel Thibault Tested-by: Samuel Thibault Thanks! > --- > ui/curses.c | 4 +++- >

Re: [PATCH v2 1/2] curses: use the bit mask constants provided by curses

2019-10-13 Thread Samuel Thibault
off-by: Matthew Kilgore Reviewed-by: Samuel Thibault Tested-by: Samuel Thibault > --- > ui/curses.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ui/curses.c b/ui/curses.c > index ec281125acbd..84003f56a323 100644 > --- a/ui/curses.c > +++ b

[PULL 0/1] slirp update

2019-10-06 Thread Samuel Thibault
/samuel-thibault for you to fetch changes up to 120b721f5b590393971673a315f02969ec89cccb: slirp: Allow non-local DNS address when restrict is off (2019-10-01 19:03:08 +0200) slirp: Allow non-local DNS address when restrict is off

[PULL 1/1] slirp: Allow non-local DNS address when restrict is off

2019-10-06 Thread Samuel Thibault
This can be used to set a DNS server to be used by the guest which is different from the one configured on the host. Buglink: https://bugs.launchpad.net/qemu/+bug/1010484 Signed-off-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- net/slirp.c | 4 ++-- 1

[PATCHv2] slirp: Allow non-local DNS address when restrict is off

2019-10-01 Thread Samuel Thibault
This can be used to set a DNS server to be used by the guest which is different from the one configured on the host. Buglink: https://bugs.launchpad.net/qemu/+bug/1010484 Signed-off-by: Samuel Thibault --- Difference from first version: - handle DNS IPv6 as well - reference bug with Buglink

[PATCH] slirp: Allow non-local DNS address when restrict is off

2019-10-01 Thread Samuel Thibault
This can be used to set a DNS server to be used by the guest which is different from the one configured on the host. Buglink: https://bugs.launchpad.net/qemu/+bug/1010484 Signed-off-by: Samuel Thibault --- net/slirp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net

[PATCH] slirp: Allow non-local DNS address when restrict is off

2019-09-29 Thread Samuel Thibault
This can be used to set a DNS server to be used by the guest which is different from the one configured on the host. This fixes LP 1010484. Signed-off-by: Samuel Thibault --- net/slirp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/slirp.c b/net/slirp.c index

Re: [Qemu-devel] slirp, incoming packets get truncated

2019-09-09 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, le lun. 09 sept. 2019 12:51:23 +0200, a ecrit: > Anyhow, if you plan to properly (with your S-o-b) commit your patch to > the libslirp repository, Actually the libslirp repository already has something there. Since IPv4/6 have a maximum of 64KB packets, it just

Re: [Qemu-devel] slirp, incoming packets get truncated

2019-09-07 Thread Samuel Thibault
Hello, As usual, several things here. Chris Heinze, le mar. 03 sept. 2019 17:02:15 +0200, a ecrit: > root@guest:~# tcpdump -ni eth0 port 19003 > tcpdump: verbose output suppressed, use -v or -vv for full protocol decode > listening on eth0, link-type EN10MB (Ethernet), capture size 262144 bytes

Re: [Qemu-devel] slirp, incoming packets get truncated

2019-09-06 Thread Samuel Thibault
Chris Heinze, le ven. 06 sept. 2019 12:54:24 +0200, a ecrit: > i'm not aware of any (canonical) parameters to set a max size for received > packets Ah, right. > i found no way to configure slirp (in qemu) itself except for the DEFINEs in > the if.h. Yes, that's where it is to be configured

Re: [Qemu-devel] slirp, incoming packets get truncated

2019-09-06 Thread Samuel Thibault
Hello, Chris Heinze, le mar. 03 sept. 2019 17:02:15 +0200, a ecrit: > on the guest: > root@guest:~# tcpdump -ni eth0 port 19003 > tcpdump: verbose output suppressed, use -v or -vv for full protocol decode > listening on eth0, link-type EN10MB (Ethernet), capture size 262144 bytes >

[Qemu-devel] [Bug 1837094] Re: UndefinedBehaviorSanitizer crash around slirp::ip_reass()

2019-08-29 Thread Samuel thibault
And https://gitlab.freedesktop.org/slirp/libslirp/commit/d203c81b -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1837094 Title: UndefinedBehaviorSanitizer crash around slirp::ip_reass() Status in

Re: [Qemu-devel] [Slirp] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload

2019-08-25 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, le ven. 23 août 2019 17:15:32 +0200, a ecrit: > > Did you make your test with commit 126c04acbabd ("Fix heap overflow in > > ip_reass on big packet input") applied? > > Yes, unfortunately it doesn't fix the issue. Ok. Could you try the attached patch? There was

Re: [Qemu-devel] [Slirp] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload

2019-08-22 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, le jeu. 22 août 2019 16:41:33 +0200, a ecrit: > Later the newly calculated pointer q is converted into ip structure > and values are modified, Due to the wrong calculation of the delta, > ip will be pointing to incorrect location and ip_src and ip_dst can >

Re: [Qemu-devel] [ANNOUNCE] QEMU 4.1.0-rc3 is now available

2019-08-02 Thread Samuel Thibault
Marc-André Lureau, le ven. 02 août 2019 15:07:46 +0400, a ecrit: > And Samuel probably thought the same, since he didn't update the submodule. I'm rather mostly buried under piles of things to do... > According to MAINTAINERS, this is for Samuel to take care of. But I'll > do it if he ask me.

Re: [Qemu-devel] [PATCH] ui/curses: Fix build with -m32

2019-05-27 Thread Samuel Thibault
wchar_t {aka long int} > > Fix this by casting the wchar_t value to an unsigned long and using %lx > as the conversion specifier. > > Fixes: b7b664a4fe9a955338f2e11a0f7433b29c8cbad0 > Signed-off-by: Max Reitz Reviewed-by: Samuel Thibault > --- > ui/curses

[Qemu-devel] [PULL 0/1] Update upstream slirp

2019-05-09 Thread Samuel Thibault
The following changes since commit 30302acee710881cb248ec3391adcd54dcf52396: Update upstream slirp (2019-05-09 09:58:57 +0200) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up

  1   2   3   4   5   6   7   8   9   10   >