Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
No functional change, except:
- naming convention i.e. QemuProcess has been changed to QemuDirtyBitmapUser.
- rectified mistakes in documentation in qapi-schema.json.
- removed acronyms
hmp-commands.hx | 16 ++
hmp.c
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
No functional change, except acronyms have been removed.
Removed acronyms, no functional change.
hmp-commands.hx | 14 ++
hmp.c| 5 +
hmp.h| 1 +
qapi-schema.json | 9 +
qmp
-- v2:
* Added two new run states to avoid simultaneous execution of both migration and
bitmap dump process.
* Removed FILE pointer usage.
* Dumping the data only in machine-readable format.
* Tried to rectify mistakes of the previous version.
Sanidhya Kashyap (6):
generic function between
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
Removed acronyms, no functional change.
hmp-commands.hx | 15 +++
hmp.c| 12
hmp.h| 1 +
qapi-schema.json | 12
qmp-commands.hx | 24
savevm.c
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
Removed acronyms, no functional change.
hmp-commands.hx | 2 ++
hmp.c| 21 +
hmp.h| 1 +
monitor.c| 7 +++
qapi-schema.json | 28
qmp-commands.hx
2 matrix dimension
like
512 X 512 or 1024 X 512 etc for the dumping of the bitmap. But, I am still
supporting
the default square root based method of dimension selection.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
scripts/extract-bitmap.py | 213
Now, the counter variable is available to all the functions that will call
qemu_bitmap_sync_range. I have tried to make the function along with the
variables as generic as possible.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
arch_init.c | 19
that can be written to or read from.
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
Signed-off-by: Joel Schopp jsch...@linux.vnet.ibm.com
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
include/migration/qemu-file.h | 27 +++
qemu-file.c | 411
.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 2 ++
hmp.c| 23 +++
hmp.h| 1 +
monitor.c| 7 +++
qapi-schema.json | 26 ++
qmp-commands.hx | 43
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 15 +++
hmp.c| 14 ++
hmp.h| 1 +
qapi-schema.json | 12
qmp-commands.hx | 21 +
savevm.c | 13 +
6 files changed
bad at naming convention, thanks to
community, specially Eric, I try to improve it with every version.
* On Eric's advice, I have separated all of the qmp and hmp interface patches.
* Changed the DPRINTF statements as required.
Dr. David Alan Gilbert (1):
QEMUSizedBuffer/QEMUFile
Sanidhya
the information about the running
vmstate testing process.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 4 +++-
hmp.c| 31 +++
hmp.h| 1 +
monitor.c| 7 +++
qapi-schema.json | 37
the case pointed
out by Juan does not exist.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 16
hmp.c| 17
hmp.h| 1 +
qapi-schema.json | 22 ++
qmp-commands.hx | 33
savevm.c | 233
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 14 ++
hmp.c| 6 ++
hmp.h| 1 +
qapi-schema.json | 9 +
qmp-commands.hx | 20
savevm.c | 16 ++--
6 files changed, 64
in machine-readable format.
* Tried to rectify mistakes of the previous version.
Sanidhya Kashyap (6):
generic function between migration and bitmap dump
BitmapLog: bitmap dump code
BitmapLog: get the information about the parameters
BitmapLog: cancel mechanism for an already running dump
I have modified the functions to be more generic i.e. I have used the
counter variable which stores the required value. If the value of counter
is 0, it means bitmap dump process whereas the value of 1 means migration.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
arch_init.c
is hot plugged or hot unplugged.
I have modified the variables name as:
current-iteration: for the current iteration under process
iterations: total iterations that will be done which is constant
period: the delay in each iteration.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp
No functional change except the variable name.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 2 ++
hmp.c| 19 +++
hmp.h| 1 +
monitor.c| 7 +++
qapi-schema.json | 28
qmp
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 14 ++
hmp.c| 5 +
hmp.h| 1 +
qapi-schema.json | 9 +
qmp-commands.hx | 20
savevm.c | 14 ++
6 files changed, 63
-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
scripts/extract-bitmap.py | 144 ++
1 file changed, 144 insertions(+)
create mode 100755 scripts/extract-bitmap.py
diff --git a/scripts/extract-bitmap.py b/scripts/extract-bitmap.py
new file mode 100755
No functional change except the variable name -- frequency has been modified
to period.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 15 +++
hmp.c| 12
hmp.h| 1 +
qapi-schema.json | 12
qmp
]
Once here, can we change this to also include the device version?
i.e. something like:
devices: [ [ device: [ name: kvm-tpr-opt, version, 15]]], ...]
Or somesuch?
That is possible. Do you want any other information to be printed?
--
-
Sanidhya Kashyap
the qemu_buf_set_ro and qemu_buf_set_rw,
I guess, I'll have to rewind the pointer, for which I have to get some
idea before doing it, or extend the QEMUFile code for memory buffer.
--
-
Sanidhya Kashyap
this impact the default of the next vmstate test
to
Yes
start, in the case where that command doesn't supply a value for
period but relies on the default?
No, it does not.
- --
- -
Sanidhya Kashyap
-BEGIN PGP SIGNATURE-
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 07/29/2014 10:22 PM, Eric Blake wrote:
On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote:
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com ---
hmp-commands.hx | 14 ++ hmp.c | 6 ++
hmp.h | 1 + 3
):
QEMUSizedBuffer/QEMUFile
Sanidhya Kashyap (11):
reset handler for qdevified devices
VMState test: query command to extract the qdevified device names
VMState test: hmp interface for showing qdevified devices
VMstate test: basic VMState testing mechanism
VMState test: hmp interface
From: Dr. David Alan Gilbert dgilb...@redhat.com
Stefan Berger's to create a QEMUFile that goes to a memory buffer;
from:
http://lists.gnu.org/archive/html/qemu-devel/2013-03/msg05036.html
Using the QEMUFile interface, this patch adds support functions for
operating
on in-memory sized buffers
I have provided a qmp interface for getting the list of qdevified devices
that have been registered with SaveVMHandlers.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
qapi-schema.json | 22 ++
qmp-commands.hx | 25 +
savevm.c
the documentation.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
qapi-schema.json | 26 ++
qmp-commands.hx | 37
savevm.c | 251 +++
3 files changed, 314 insertions(+)
diff --git a/qapi-schema.json b/qapi-schema.json
This patch provides the hmp interface for qdevified devices list.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 2 ++
hmp.c | 21 +
hmp.h | 1 +
monitor.c | 7 +++
4 files changed, 31 insertions(+)
diff --git
be grateful if anyone can give some pointers on this.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
savevm.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/savevm.c b/savevm.c
index e19ae0a..0255fa0 100644
--- a/savevm.c
+++ b/savevm.c
@@ -503,12
I have added the hmp interface for vmstate testing. Currently, the patch does
not support the qdev list, since I could not figure out how to the pass the
VMStatesQdevDevices struct which can be parsed and used.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 15
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 15 +++
hmp.c | 14 ++
hmp.h | 1 +
3 files changed, 30 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index c1dc6a2..6d15184 100644
--- a/hmp-commands.hx
Added a hmp interface for providing the information about the testing process.
I have used the underscore as a separater on Eric's advice. But, I have found
some of the commands having hyphen.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 2 ++
hmp.c
This patch provides the information about an already executing testing
process. I have modified the qmp command to query-test-vmstates from
test-vmstates-get-info.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
qapi-schema.json | 34 ++
qmp
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
qapi-schema.json | 9 +
qmp-commands.hx | 19 +++
savevm.c | 16 ++--
3 files changed, 42 insertions(+), 2 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index 13e922e
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 14 ++
hmp.c | 6 ++
hmp.h | 1 +
3 files changed, 21 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 6d15184..fe224fc 100644
--- a/hmp-commands.hx
+++ b/hmp
No particular change, except variable name. Since I am not modifying other
variables, so I have not made the command generic.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
qapi-schema.json | 12
qmp-commands.hx | 23 +++
savevm.c | 13
very basic approach
that I have thought is about using a global variable but don't know
whether that is a good option or not.
Any other alternative is welcomed.
-
Sanidhya Kashyap
and be done with it
(the user can go look up the documentation of that struct).
Will do that.
- --
- -
Sanidhya Kashyap
-BEGIN PGP SIGNATURE-
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTyVwyAAoJEFt9RLmoahlnS1QH/36mLxnS3sblvYI6v7fJxAF0
commands still use _ in their names; it's only QMP where we
prefer dash.
I didn't notice. Will change it.
- -
Sanidhya Kashyap
-BEGIN PGP SIGNATURE-
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTyV6sAAoJEFt9RLmoahlnPM8H
libvirt. :-/
- --
- -
Sanidhya Kashyap
-BEGIN PGP SIGNATURE-
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTyWESAAoJEFt9RLmoahlnesAIAJi2ZbPkZTvllPl0/n5oQmRm
hqegnl4ggsv8R9lpElcEtJKiwI0JpqwNzmNGp/nUmHqlq9cFgsC58AtdbRQGjDmx
this point in the documentation as well as in the code.
--
-
Sanidhya Kashyap
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 14 ++
hmp.c| 5 +
hmp.h| 1 +
qapi-schema.json | 8
qmp-commands.hx | 21 +
savevm.c | 19 +++
6 files changed, 68
Rectified the example mistake in qmp-commands.hx.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 15 +++
hmp.c| 12
hmp.h| 1 +
qapi-schema.json | 13 +
qmp-commands.hx | 24
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
scripts/extract-bitmap.py | 97 +++
1 file changed, 97 insertions(+)
create mode 100755 scripts/extract-bitmap.py
diff --git a/scripts/extract-bitmap.py b/scripts/extract-bitmap.py
new file
to modify the other values
except frequency, so that is why I have not added the generic set-tuning
interface. If required, I will add it.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
qapi-schema.json | 31 +++
qmp-commands.hx | 24
The single precopy lazy pass would consist of clearing the dirty
bitmap, starting precopy, then if any page is found dirty by the time
precopy tries to send it, we skip it. We only send those pages in
precopy that haven't been modified yet by the time we reach them in
precopy.
Pages
iteration.
With these patches, I haven't found any bug in the device states. I wish I am
on the right track.
Dr. David Alan Gilbert (1):
QEMUSizedBuffer/QEMUFile
Sanidhya Kashyap (4):
VMState test: basic vmstate testing mechanism
VMState test: hmp interface for vmstate testing
VMState test
From: Dr. David Alan Gilbert dgilb...@redhat.com
Using the patch of Stefan Berger for memory buffer based QEMUFile.
http://lists.gnu.org/archive/html/qemu-devel/2013-03/msg05036.html
In the words of David:
Using the QEMUFile interface, this patch adds support functions for
operating on
Added hmp interface.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 15 +++
hmp.c | 14 ++
hmp.h | 1 +
3 files changed, 30 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index d0943b1..c492f3f 100644
the qdevified device tree to reset the functions.
As of now, I am providing DPRINTF to know about the amount of time spend in
saving and loading the data from the buffer. If there is any other way that
should be used to print the stats, then please do let me know.
Signed-off-by: Sanidhya Kashyap sanidhya.ii
This patch introduces the mechanism to update the sleep interval - sinterval.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 15 +++
hmp.c| 14 ++
hmp.h| 1 +
qapi-schema.json | 10 ++
qmp-commands.hx | 22
This patch helps in cancelling an already executing vmstate testing process.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 14 ++
hmp.c| 6 ++
hmp.h| 1 +
qapi-schema.json | 9 +
qmp-commands.hx | 20
Added prefix qemu_ to the function as pointed out by Juan.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
arch_init.c | 19 +++
include/exec/ram_addr.h | 4
2 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/arch_init.c b/arch_init.c
Reformatted the code and added the functionality of dumping the blocks' info
which can be read by the user when required. I have also made the block name
length global.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
include/exec/cpu-all.h | 3 +-
migration.c| 7
Changed those files that were directly using the RUN_STATE_RUNNING flag. Now,
they have been replaced by the runstate_is_running() function.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hw/usb/hcd-ehci.c | 2 +-
hw/usb/redirect.c | 6 +++---
qapi-schema.json | 7 ++-
vl.c
usage.
* Dumping the data only in machine-readable format.
* Tried to rectify mistakes of the previous version.
Sanidhya Kashyap (7):
enable sharing of the function between migration and bitmap dump
RunState: added two new flags for bitmap dump and migration process
bitmap dump code via QAPI
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 16
hmp.c | 16
hmp.h | 1 +
3 files changed, 33 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 5f1a677..cccd53e 100644
--- a/hmp-commands.hx
as a marker identifying
as the end of that bitmap. If the 'M' is missing while reading the file, then
dump is incomplete.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
scripts/extract-bitmap.py | 97 +++
1 file changed, 97 insertions(+)
create
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 14 ++
hmp.c| 5 +
hmp.h| 1 +
qapi-schema.json | 8
qmp-commands.hx | 20
savevm.c | 19 +++
6 files changed, 67
No, particular change except the function name changed - value_in_range().
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 15 +++
hmp.c| 12
hmp.h| 1 +
qapi-schema.json | 11 +++
qmp-commands.hx | 24
int runstate_is_running(void)
{
-return runstate_check(RUN_STATE_RUNNING);
+return (runstate_check(RUN_STATE_RUNNING) ||
+runstate_check(RUN_STATE_MIGRATE) ||
+runstate_check(RUN_STATE_DUMP_BITMAP));
}
Forgot to apply the checkpatch script. The return
Reformatted the code and added the functionality of dumping the blocks' info
which can be read by the user when required. I have also made the block name
length global.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
include/exec/cpu-all.h | 3 +-
migration.c| 7
of both migration and
bitmap dump process.
* Removed FILE pointer usage.
* Dumping the data only in machine-readable format.
* Tried to rectify mistakes of the previous version.
Sanidhya Kashyap (8):
enable sharing of the function between migration and bitmap dump
bitmap dump code via QAPI
with qemu_open / qemu_close.
4) Removed text format, output only in machine-readable format.
5) Defined constants.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
qapi-schema.json | 17
qmp-commands.hx | 33
savevm.c | 246
No particular functional change. This file does not need to be included in
the Makefile as it will be only useful once the user has generated the bitmap
file via bitmap dump process.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
scripts/extract-bitmap.py | 64
have tried
to cover what I thought is necessary).
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
qapi-schema.json | 7 ++-
vl.c | 29 -
2 files changed, 34 insertions(+), 2 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
interface as the current_run_state variable is not
updated.
Any thoughts on that? Do I need to make the changes there as well or is there
any
simple way to do it?
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
migration.c | 7 +++
savevm.c| 26 +++---
2
No particular functional change. Corrected some mistakes.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 15 +++
hmp.c| 12
hmp.h| 1 +
qapi-schema.json | 10 ++
qmp-commands.hx | 23
As advised by Eric, I have enabled sharing of the function between of the
function that syncs the dirty bitmap obtained via kvm ioctl. I have tried
to make the least changes to the functions by concentrating only on the
function definitions.
Signed-off-by: Sanidhya Kashyap sanidhya.ii
No particular functional changes. Rectified some previous mistakes.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 14 ++
hmp.c| 5 +
hmp.h| 1 +
qapi-schema.json | 8
qmp-commands.hx | 20
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 16
hmp.c | 16
hmp.h | 1 +
3 files changed, 33 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 2e462c0..1665587 100644
--- a/hmp-commands.hx
Exporting a function without a prefix could be dangerous.
Later, Juan.
Any particular solution, as the function is being used at two places.
--
Sanidhya Kashyap
bitmap_* prefix is taken for generic bitmap operations.
qemu_bitmap_range_sync()
migration_bitmap_range_sync()
Use a prefix that is known to be used only on qemu.
I can undrestand why you don't want migration, so qemu_ prefix should do
the trick?
Later, Juan.
Got it!
--
Sanidhya
of both migration and
bitmap dump process.
* Removed FILE pointer usage.
* Dumping the data only in machine-readable format.
* Tried to rectified mistakes of the previous version.
Sanidhya Kashyap (8):
enable sharing of the function between migration and bitmap dump
bitmap dump code via QAPI
As advised by Eric, I have enabled sharing of the function between of the
function that syncs the dirty bitmap obtained via kvm ioctl. I have tried
to make the least changes to the functions by concentrating only on the
function definitions.
Signed-off-by: Sanidhya Kashyap sanidhya.ii
No particular functional change. This file does not need to be included in
the Makefile as it will be only useful once the user has generated the bitmap
file via bitmap dump process.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
scripts/extract-bitmap.py | 64
interface as the current_run_state variable is not
updated.
Any thoughts on that? Do I need to make the changes there as well or is there
any
simple way to do it?
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
migration.c | 7 +++
savevm.c| 26 +++---
2
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 16
hmp.c | 16
hmp.h | 1 +
3 files changed, 33 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 2e462c0..1665587 100644
--- a/hmp-commands.hx
No particular functional changes. Rectified some previous mistakes.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 14 ++
hmp.c| 5 +
hmp.h| 1 +
qapi-schema.json | 8
qmp-commands.hx | 20
No particular functional change. Corrected some mistakes.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 15 +++
hmp.c| 12
hmp.h| 1 +
qapi-schema.json | 10 ++
qmp-commands.hx | 23
have tried
to cover what I thought is necessary).
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
qapi-schema.json | 7 ++-
vl.c | 29 -
2 files changed, 34 insertions(+), 2 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
with qemu_open / qemu_close.
4) Removed text format, output only in machine-readable format.
5) Defined constants.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
qapi-schema.json | 17
qmp-commands.hx | 33
savevm.c | 246
On Wed, May 21, 2014 at 12:15 PM, ChenLiang chenlian...@huawei.com wrote:
On 2014/5/21 12:56, Sanidhya Kashyap wrote:
On Wed, May 21, 2014 at 9:43 AM, ChenLiang chenlian...@huawei.com wrote:
Hi,
Nice job. We should avoid running migration_thread and
bitmap_logging_thread simultaneously
.
BTW, it is not your patches problem.
Then, I'll go ahead and implement this part using two flags in my
second version of the patches.
cc: Juan
Best regards
ChenLiang
--
Sanidhya Kashyap
directly use the DIRTY_MEMORY_MIGRATION flag. What is your
suggestion?
--
Sanidhya Kashyap
or
even can cancel the ongoing logging process. Thus, there are 3 hmp and
qmp commands interface provided to perform the task.
Sanidhya Kashyap (6):
split dirty bitmap into four for dumping the bitmaps
bitmap dump code via QAPI framework
hmp interface for dirty bitmap dump
cancel mechanism
This patch introduces both hmp and qmp (log-dirty-bitmap-cancel) interface
to cancel an already executing dump process.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 14 ++
hmp.c| 5 +
hmp.h| 1 +
qapi-schema.json | 5
Added another flag - DIRTY_MEMORY_LOG_BITMAP for the purpose of logging
the dirty bitmap. The dumping bitmap process will utilize this flag for
dumping the data in the file.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
exec.c | 4
include/exec/memory.h
value is false. That is
the data is save in human readable format. The first line is the total number
of pages followed by size of the bitmap and then the hex dump of the bitmap
array.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
include/qapi/qmp/qerror.h | 3 +
qapi-schema.json
This patch introduces both qmp and hmp (log-dirty-bitmap-set-frequency)
interface to update the value of the frequency.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 15 +++
hmp.c| 12
hmp.h| 1 +
qapi
This script extracts the bitmap only from a binary file. It takes only
a single input as file. This will be useful to users for exploring the
writable working set for the VM.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
scripts/extract-bitmap.py | 68
Added the log-dirty-bitmap or ldb hmp interface.
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
hmp-commands.hx | 17 +
hmp.c | 19 +++
hmp.h | 1 +
3 files changed, 37 insertions(+)
diff --git a/hmp-commands.hx b/hmp
+#define QERR_LOG_DIRTY_BITMAP_ACTIVE \
+ERROR_CLASS_GENERIC_ERROR, Dirty bitmap dump already in progress
+
Please don't add new ERROR_CLASS macros. Instead, just use error_setg()
and directly output the error message at the call site that produces the
error.
will keep in mind in my
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com
---
scripts/extract-bitmap.py | 68
+++
1 file changed, 68 insertions(+)
create mode 100755 scripts/extract-bitmap.py
Does this file need to be mentioned in any Makefile to ensure
On Wed, May 21, 2014 at 9:43 AM, ChenLiang chenlian...@huawei.com wrote:
Hi,
Nice job. We should avoid running migration_thread and bitmap_logging_thread
simultaneously.
Any particular suggestion to avoid running simultaneous execution of
the threads?
--
Sanidhya
phase.
2014-03-24 13:46 GMT-04:00 Sanidhya Kashyap sanidhya.ii...@gmail.com:
savevm.c will tell you about the stop time.
arch_init.c (ram_save_block) will tell about the number of pages
transferred.
On Mon, Mar 24, 2014 at 10:51 PM, Bechir Bani bechir.b...@gmail.comwrote:
I have a task
savevm.c will tell you about the stop time.
arch_init.c (ram_save_block) will tell about the number of pages
transferred.
On Mon, Mar 24, 2014 at 10:51 PM, Bechir Bani bechir.b...@gmail.com wrote:
I have a task to add trace points in the source code of Qemu. The goal is
to know the number of
99 matches
Mail list logo
