[PATCH v4] arm/kvm: Enable support for KVM_CAP_ARM_EAGER_SPLIT_CHUNK_SIZE

2023-09-05 Thread Shameer Kolothum via
a single allocation. Bigger the chunk size, more pages need to be allocated ahead of time. Reviewed-by: Gavin Shan Signed-off-by: Shameer Kolothum --- Changes: v3: https://lore.kernel.org/qemu-devel/20230830114818.641-1-shameerali.kolothum.th...@huawei.com/ -Added R-by by Gavin and replaced

[PATCH v3] arm/kvm: Enable support for KVM_CAP_ARM_EAGER_SPLIT_CHUNK_SIZE

2023-08-30 Thread Shameer Kolothum via
a single allocation. Bigger the chunk size, more pages need to be allocated ahead of time. Signed-off-by: Shameer Kolothum --- v2: https://lore.kernel.org/qemu-devel/20230815092709.1290-1-shameerali.kolothum.th...@huawei.com/ -Addressed comments from Gavin(Thanks). RFC v1: https://lore.kernel.org

[PATCH v2] arm/kvm: Enable support for KVM_CAP_ARM_EAGER_SPLIT_CHUNK_SIZE

2023-08-15 Thread Shameer Kolothum via
a single allocation. Bigger the chunk size, more pages need to be allocated ahead of time. Signed-off-by: Shameer Kolothum --- RFC v1: https://lore.kernel.org/qemu-devel/20230725150002.621-1-shameerali.kolothum.th...@huawei.com/ -Updated qemu-options.hx with description -Addressed review comments

[RFC PATCH] arm/kvm: Enable support for KVM_CAP_ARM_EAGER_SPLIT_CHUNK_SIZE

2023-07-25 Thread Shameer Kolothum via
. -ToDo: Update qemu-options.hx [0]: https://lore.kernel.org/all/168426111477.3193133.10748106199843780930.b4...@linux.dev/ Signed-off-by: Shameer Kolothum --- include/sysemu/kvm_int.h | 1 + target/arm/kvm.c | 73 2 files changed, 74 insertions

[PATCH] vfio/pci: Call vfio_prepare_kvm_msi_virq_batch() in MSI retry path

2023-06-13 Thread Shameer Kolothum via
: ../hw/vfio/pci.c:602: vfio_commit_kvm_msi_virq_batch: Assertion `vdev->defer_kvm_irq_routing' failed Fixes: dc580d51f7dd ("vfio: defer to commit kvm irq routing when enable msi/msix") Reviewed-by: Longpeng Signed-off-by: Shameer Kolothum --- hw/vfio/pci.c | 4 ++-- 1 fi

[PATCH v2] fw_cfg: Don't set callback_opaque NULL in fw_cfg_modify_bytes_read()

2022-09-08 Thread Shameer Kolothum via
n't change the callback_opaque in fw_cfg_modify_bytes_read(). Fixes: bdbb5b1706d165 ("fw_cfg: add fw_cfg_machine_reset function") Reported-by: chenxiang Acked-by: Igor Mammedov Acked-by: Gerd Hoffmann Signed-off-by: Shameer Kolothum --- v1 --> v2 -Added Fixes tag as pointed out by Igor -Added Ac

[PATCH] fw_cfg: Don't set callback_opaque NULL in fw_cfg_modify_bytes_read()

2022-08-25 Thread Shameer Kolothum via
x this, don't change the callback_opaque in fw_cfg_modify_bytes_read(). Reported-by: chenxiang Signed-off-by: Shameer Kolothum --- I am still not very convinced this is the root cause of the issue. Though it looks like setting callback_opaque to NULL while updating the file size is wrong, what puzzles me is

[PATCH v4] arm/virt: Add memory hot remove support

2020-06-22 Thread Shameer Kolothum
This adds support for memory(pc-dimm) hot remove on arm/virt that uses acpi ged device. NVDIMM hot removal is not yet supported. Signed-off-by: Shameer Kolothum --- v2 --> v3 -Addressed Eric's comments on v3. v2 --> v3 -Addressed Eric's review comment and added check for NVDIMM.

[PATCH v3] arm/virt: Add memory hot remove support

2020-06-18 Thread Shameer Kolothum
This adds support for memory(pc-dimm) hot remove on arm/virt that uses acpi ged device. NVDIMM hot removal is not yet supported. Signed-off-by: Shameer Kolothum --- V2 --> v3 -Addressed Eric's review comment and added check for NVDIMM. RFC v1 --> v2 -Rebased on top of latest Qemu

[PATCH v2] arm/virt: Add memory hot remove support

2020-05-20 Thread Shameer Kolothum
This adds support for memory hot remove on arm/virt that uses acpi ged device. Signed-off-by: Shameer Kolothum --- RFC v1 --> v2 -Rebased on top of latest Qemu master. -Dropped "RFC" and tested with kernel 5.7-rc6 --- hw/acpi/generic_event_device.c | 28 +

[PATCH v4 6/7] bios-tables-test: test pc-dimm and nvdimm coldplug for arm/virt

2020-04-21 Thread Shameer Kolothum
Since we now have both pc-dimm and nvdimm support, update test_acpi_virt_tcg_memhp() to include those. Signed-off-by: Shameer Kolothum --- tests/qtest/bios-tables-test.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest

[PATCH v4 7/7] tests/acpi: add expected tables for bios-tables-test

2020-04-21 Thread Shameer Kolothum
Because of the following changes, the expeacted tables for bios-tables-test needs to be updated. 1. Changed NVDIM DSM output buffer AML code. 2. Updated arm/virt test_acpi_virt_tcg_memhp() to add pc-dimm/nvdimm Signed-off-by: Shameer Kolothum --- tests/data/acpi/pc/SSDT.dimmpxm

[PATCH v4 4/7] hw/arm/virt: Add nvdimm hotplug support

2020-04-21 Thread Shameer Kolothum
This adds support for nvdimm hotplug events through GED and enables nvdimm for the arm/virt. Now Guests with ACPI can have both cold and hot plug of nvdimms. Hot removal functionality is not yet supported. Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov Reviewed-by: Eric Auger

[PATCH v4 2/7] nvdimm: Use configurable ACPI IO base and size

2020-04-21 Thread Shameer Kolothum
Signed-off-by: Eric Auger Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov --- hw/acpi/nvdimm.c| 32 ++-- hw/i386/acpi-build.c| 6 ++ hw/i386/acpi-build.h| 3 +++ hw/i386/pc_piix.c | 2 ++ hw/i386/pc_q35.c| 2 ++ include/hw

[PATCH v4 3/7] hw/arm/virt: Add nvdimm hot-plug infrastructure

2020-04-21 Thread Shameer Kolothum
From: Kwangwoo Lee This adds support to init nvdimm acpi state and build nvdimm acpi tables. Please note nvdimm_support is not yet enabled. Signed-off-by: Kwangwoo Lee Signed-off-by: Eric Auger Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov --- hw/arm/Kconfig | 1

[PATCH v4 5/7] tests: Update ACPI tables list for upcoming arm/virt test changes

2020-04-21 Thread Shameer Kolothum
This is in preparation to update test_acpi_virt_tcg_memhp() with pc-dimm and nvdimm. Update the bios-tables-test-allowed-diff.h with the affected ACPI tables so that "make check" doesn't fail. Also add empty files for new tables required for new test. Signed-off-by: Shameer Kolothum

[PATCH v4 1/7] hw/acpi/nvdimm: Fix for NVDIMM incorrect DSM output buffer length

2020-04-21 Thread Shameer Kolothum
st kernel to report, "nfit ACPI0012:00: found a zero length table '0' parsing nfit" In order to fix this, aml code is now modified such that it builds the DSM output buffer in a byte by byte fashion when length is smaller than Integer size. Suggested-by: Igor Mammedov Signed-off-by: Shameer

[PATCH v4 0/7] ARM virt: Add NVDIMM support

2020-04-21 Thread Shameer Kolothum
mms(patch #7) Kwangwoo Lee (2): nvdimm: Use configurable ACPI IO base and size hw/arm/virt: Add nvdimm hot-plug infrastructure Shameer Kolothum (5): hw/acpi/nvdimm: Fix for NVDIMM incorrect DSM output buffer length hw/arm/virt: Add nvdimm hotplug support tests: Update ACPI tables list for

[PATCH for-5.0 v2 2/3] fw_cfg: Migrate ACPI table mr sizes separately

2020-04-03 Thread Shameer Kolothum
ted-by: David Hildenbrand Signed-off-by: Shameer Kolothum Acked-by: David Hildenbrand --- v1 --> v2 - Changed *_mr_size from size_t to uint64_t to address portability. - post_copy only done if sizes are not aligned. Please find previous discussions here, https://patchwork.kernel.org/patch/11

[PATCH for-5.0 v2 0/3] acpi: Fixes for inconsistency in ACPI MR size during migration

2020-04-03 Thread Shameer Kolothum
V2 - patch #2, Addressed comments from Dave and MST Updates from [1]: -Added R-by and A-by tags. -Edited commit log for patch#2 -Updated patch#3 as per David's comment David Hildenbrand (1): exec: Fix for qemu_ram_resize() callback Shameer Kolothum (2): acpi: Use macro for table-loader f

[PATCH for-5.0 v2 3/3] exec: Fix for qemu_ram_resize() callback

2020-04-03 Thread Shameer Kolothum
-by: Shameer Kolothum Reviewed-by: Igor Mammedov --- Please find previous discussion here, https://patchwork.kernel.org/patch/11432375/#23216751 --- exec.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index de9d949902..2874bb5088 100644

[PATCH for-5.0 v2 1/3] acpi: Use macro for table-loader file name

2020-04-03 Thread Shameer Kolothum
Use macro for "etc/table-loader" and move it to the header file similar to ACPI_BUILD_TABLE_FILE/ACPI_BUILD_RSDP_FILE etc. Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov --- hw/arm/virt-acpi-build.c| 2 +- hw/i386/acpi-build.c| 2 +- include/hw/acpi/aml-build.

[PATCH for-5.0 3/3] exec: Fix for qemu_ram_resize() callback

2020-03-30 Thread Shameer Kolothum
-by: Shameer Kolothum Reviewed-by: Igor Mammedov --- Please find previous discussion here, https://patchwork.kernel.org/patch/11432375/#23216751 --- exec.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index de9d949902..2874bb5088 100644

[PATCH for-5.0 2/3] fw_cfg: Migrate ACPI table mr sizes separately

2020-03-30 Thread Shameer Kolothum
ted-by: David Hildenbrand Signed-off-by: Shameer Kolothum Acked-by: David Hildenbrand --- Please find previous discussions here, https://patchwork.kernel.org/patch/11339591/#23140343 --- hw/core/machine.c | 1 + hw/nvram/fw_cfg.c | 86 ++- include

[PATCH for-5.0 1/3] acpi: Use macro for table-loader file name

2020-03-30 Thread Shameer Kolothum
Use macro for "etc/table-loader" and move it to the header file similar to ACPI_BUILD_TABLE_FILE/ACPI_BUILD_RSDP_FILE etc. Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov --- hw/arm/virt-acpi-build.c| 2 +- hw/i386/acpi-build.c| 2 +- include/hw/acpi/aml-build.

[PATCH for-5.0 0/3] acpi: Fixes for inconsistency in ACPI MR size during migration

2020-03-30 Thread Shameer Kolothum
: -Added R-by and A-by tags. -Edited commit log for patch#2 -Updated patch#3 as per David's comment David Hildenbrand (1): exec: Fix for qemu_ram_resize() callback Shameer Kolothum (2): acpi: Use macro for table-loader file name fw_cfg: Migrate ACPI table mr sizes separately exec.c

[RFC v1] arm/virt: Add memory hot remove support

2020-03-18 Thread Shameer Kolothum
This adds support for memory hot remove on arm/virt that uses acpi ged device. Signed-off-by: Shameer Kolothum --- -RFC because linux kernel support for mem hot remove is just queued for 5.7[1]. -Tested with guest kernel 5.6-rc5 + [1] 1. https://patchwork.kernel.org/cover/11419301/ --- hw

[PATCH v3 10/10] tests/acpi: add expected tables for bios-tables-test

2020-03-11 Thread Shameer Kolothum
Because of the following changes, the expeacted tables for bios-tables-test needs to be updated. 1. Changed NVDIM DSM output buffer AML code. 2. Updated arm/virt test_acpi_virt_tcg_memhp() to add pc-dimm/nvdimm Signed-off-by: Shameer Kolothum --- tests/data/acpi/pc/SSDT.dimmpxm

[PATCH v3 09/10] tests/bios-tables-test: Update arm/virt memhp test

2020-03-11 Thread Shameer Kolothum
Since we now have both pc-dimm and nvdimm support, update test_acpi_virt_tcg_memhp() to include those. Signed-off-by: Shameer Kolothum --- v2 -> v3 -Moved addition of empty table files to the previous patch --- tests/qtest/bios-tables-test.c | 9 +++-- 1 file changed, 7 insertions(+)

[PATCH v3 05/10] nvdimm: Use configurable ACPI IO base and size

2020-03-11 Thread Shameer Kolothum
Signed-off-by: Eric Auger Signed-off-by: Shameer Kolothum --- hw/acpi/nvdimm.c| 32 ++-- hw/i386/acpi-build.c| 6 ++ hw/i386/acpi-build.h| 3 +++ hw/i386/pc_piix.c | 2 ++ hw/i386/pc_q35.c| 2 ++ include/hw/mem/nvdimm.h | 3 +++ 6

[PATCH v3 08/10] tests: Update ACPI tables list for upcoming arm/virt test changes

2020-03-11 Thread Shameer Kolothum
This is in preparation to update test_acpi_virt_tcg_memhp() with pc-dimm and nvdimm. Update the bios-tables-test-allowed-diff.h with the affected ACPI tables so that "make check" doesn't fail. Also add empty files for new tables required for new test. Signed-off-by: Shameer Kolothum

[PATCH v3 00/10] ARM virt: Add NVDIMM support

2020-03-11 Thread Shameer Kolothum
and (1): exec: Fix for qemu_ram_resize() callback Kwangwoo Lee (2): nvdimm: Use configurable ACPI IO base and size hw/arm/virt: Add nvdimm hot-plug infrastructure Shameer Kolothum (7): acpi: Use macro for table-loader file name fw_cfg: Migrate ACPI table mr sizes separately hw/acpi/

[PATCH v3 07/10] hw/arm/virt: Add nvdimm hotplug support

2020-03-11 Thread Shameer Kolothum
This adds support for nvdimm hotplug events through GED and enables nvdimm for the arm/virt. Now Guests with ACPI can have both cold and hot plug of nvdimms. Hot removal functionality is not yet supported. Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov Reviewed-by: Eric Auger

[PATCH v3 04/10] hw/acpi/nvdimm: Fix for NVDIMM incorrect DSM output buffer length

2020-03-11 Thread Shameer Kolothum
st kernel to report, "nfit ACPI0012:00: found a zero length table '0' parsing nfit" In order to fix this, aml code is now modified such that it builds the DSM output buffer in a byte by byte fashion when length is smaller than Integer size. Suggested-by: Igor Mammedov Signed-off-by: Shame

[PATCH v3 03/10] exec: Fix for qemu_ram_resize() callback

2020-03-11 Thread Shameer Kolothum
-by: Shameer Kolothum --- Please find the discussion here, https://patchwork.kernel.org/patch/11339591/ --- exec.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index 0cc500d53a..f8974cd303 100644 --- a/exec.c +++ b/exec.c @@ -2073,11 +2073,21

[PATCH v3 06/10] hw/arm/virt: Add nvdimm hot-plug infrastructure

2020-03-11 Thread Shameer Kolothum
From: Kwangwoo Lee This adds support to init nvdimm acpi state and build nvdimm acpi tables. Please note nvdimm_support is not yet enabled. Signed-off-by: Kwangwoo Lee Signed-off-by: Eric Auger Signed-off-by: Shameer Kolothum --- v2 -> v3 -Modified commit log. --- hw/arm/Kcon

[PATCH v3 01/10] acpi: Use macro for table-loader file name

2020-03-11 Thread Shameer Kolothum
Use macro for "etc/table-loader" and move it to the header file similar to ACPI_BUILD_TABLE_FILE/ACPI_BUILD_RSDP_FILE etc. Signed-off-by: Shameer Kolothum --- hw/arm/virt-acpi-build.c| 2 +- hw/i386/acpi-build.c| 2 +- include/hw/acpi/aml-build.h | 1 + 3 files changed, 3

[PATCH v3 02/10] fw_cfg: Migrate ACPI table mr sizes separately

2020-03-11 Thread Shameer Kolothum
ion. Suggested-by: David Hildenbrand Signed-off-by: Shameer Kolothum --- Please find the discussion here, https://patchwork.kernel.org/patch/11339591/ --- hw/core/machine.c | 1 + hw/nvram/fw_cfg.c | 86 ++- include/hw/nvram/fw_cfg.h | 6 +++

[PATCH v2 7/7] tests/bios-tables-test: Update arm/virt memhp test

2020-01-17 Thread Shameer Kolothum
Since we now have both pc-dimm and nvdimm support, update test_acpi_virt_tcg_memhp() to include those. Signed-off-by: Shameer Kolothum --- tests/data/acpi/virt/NFIT.memhp | 0 tests/data/acpi/virt/SSDT.memhp | 0 tests/qtest/bios-tables-test.c | 9 +++-- 3 files changed, 7 insertions(+), 2

[PATCH v2 3/7] nvdimm: Use configurable ACPI IO base and size

2020-01-17 Thread Shameer Kolothum
Signed-off-by: Eric Auger Signed-off-by: Shameer Kolothum --- hw/acpi/nvdimm.c| 32 ++-- hw/i386/acpi-build.c| 6 ++ hw/i386/acpi-build.h| 3 +++ hw/i386/pc_piix.c | 2 ++ hw/i386/pc_q35.c| 2 ++ include/hw/mem/nvdimm.h | 3 +++ 6

[PATCH v2 5/7] hw/arm/virt: Add nvdimm hotplug support

2020-01-17 Thread Shameer Kolothum
This adds support for nvdimm hotplug events through GED and enables nvdimm for the arm/virt. Now Guests with ACPI can have both cold and hot plug of nvdimms. Hot removal functionality is not yet supported. Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov --- docs/specs

[PATCH v2 4/7] hw/arm/virt: Add nvdimm hot-plug infrastructure

2020-01-17 Thread Shameer Kolothum
From: Kwangwoo Lee Prepare pre-plug and plug handlers for NVDIMM support. Please note nvdimm_support is not yet enabled. Signed-off-by: Kwangwoo Lee Signed-off-by: Eric Auger Signed-off-by: Shameer Kolothum --- hw/arm/Kconfig | 1 + hw/arm/virt-acpi-build.c | 6 ++ hw/arm

[PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-01-17 Thread Shameer Kolothum
ate() -> qemu_ram_resize() path, qemu_ram_resize() uses used_length (ram_block size which is aligned to PAGE size) and the "resize callback" to update the size seen by firmware is not getting invoked. Hence make sure callback is called if the new size is different from original requested size. Signed

[PATCH v2 6/7] tests: Update ACPI tables list for upcoming arm/virt test changes

2020-01-17 Thread Shameer Kolothum
This is in preparation to update test_acpi_virt_tcg_memhp() with pc-dimm and nvdimm. Update the bios-tables-test-allowed-diff.h with the affected ACPI tables so that "make check" doesn't fail. Signed-off-by: Shameer Kolothum --- tests/qtest/bios-tables-test-allowed-diff.h | 3 +

[PATCH v2 0/7] ARM virt: Add NVDIMM support

2020-01-17 Thread Shameer Kolothum
ble ACPI IO base and size hw/arm/virt: Add nvdimm hot-plug infrastructure Shameer Kolothum (5): exec: Fix for qemu_ram_resize() callback hw/acpi/nvdimm: Fix for NVDIMM incorrect DSM output buffer length hw/arm/virt: Add nvdimm hotplug support tests: Update ACPI tables list for upcoming

[PATCH v2 2/7] hw/acpi/nvdimm: Fix for NVDIMM incorrect DSM output buffer length

2020-01-17 Thread Shameer Kolothum
st kernel to report, "nfit ACPI0012:00: found a zero length table '0' parsing nfit" In order to fix this, aml code is now modified such that it builds the DSM output buffer in a byte by byte fashion when length is smaller than Integer size. Suggested-by: Igor Mammedov Signed-off-by: Shameer K

[PATCH] tests: acpi: update path in rebuild-expected-aml

2020-01-14 Thread Shameer Kolothum
s to a separate directory") Signed-off-by: Shameer Kolothum --- tests/data/acpi/rebuild-expected-aml.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/data/acpi/rebuild-expected-aml.sh b/tests/data/acpi/rebuild-expected-aml.sh index f89d4624bc..d44e511533 100

[PATCH 4/5] hw/arm/boot: Expose the pmem nodes in the DT

2019-10-04 Thread Shameer Kolothum
From: Eric Auger In case of NV-DIMM slots, let's add /pmem DT nodes. Signed-off-by: Eric Auger Signed-off-by: Shameer Kolothum --- hw/arm/boot.c | 45 + 1 file changed, 45 insertions(+) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index c264864c11

[PATCH 2/5] nvdimm: Use configurable ACPI IO base and size

2019-10-04 Thread Shameer Kolothum
Signed-off-by: Eric Auger Signed-off-by: Shameer Kolothum --- hw/acpi/nvdimm.c| 32 ++-- hw/i386/acpi-build.c| 6 ++ hw/i386/acpi-build.h| 3 +++ hw/i386/pc_piix.c | 2 ++ hw/i386/pc_q35.c| 2 ++ include/hw/mem/nvdimm.h | 3 +++ 6

[PATCH 5/5] hw/arm/virt: Add nvdimm hotplug support

2019-10-04 Thread Shameer Kolothum
This adds support for nvdimm hotplug events through GED and enables nvdimm for the arm/virt. Now Guests with DT boot can have nvdimm cold plug and with ACPI both cold/hot plug. Hot removal functionality is not yet supported. Signed-off-by: Shameer Kolothum --- docs/specs

[PATCH 3/5] hw/arm/virt: Add nvdimm hot-plug infrastructure

2019-10-04 Thread Shameer Kolothum
From: Kwangwoo Lee Pre-plug and plug handlers are prepared for NVDIMM support. Please note nvdimm_support is not yet enabled. Signed-off-by: Eric Auger Signed-off-by: Kwangwoo Lee Signed-off-by: Shameer Kolothum --- hw/arm/Kconfig | 1 + hw/arm/virt-acpi-build.c | 6 ++ hw

[PATCH 0/5] ARM virt: Add NVDIMM support

2019-10-04 Thread Shameer Kolothum
://patchwork.kernel.org/patch/11154757/ Eric Auger (1): hw/arm/boot: Expose the pmem nodes in the DT Kwangwoo Lee (2): nvdimm: Use configurable ACPI IO base and size hw/arm/virt: Add nvdimm hot-plug infrastructure Shameer Kolothum (2): hw/arm: Align ACPI blob len to PAGE size hw/arm/virt

[PATCH 1/5] hw/arm: Align ACPI blob len to PAGE size

2019-10-04 Thread Shameer Kolothum
ate() -> qemu_ram_resize() path, qemu_ram_resize() uses ram_block size which is aligned to PAGE size and the "resize callback" to update the size seen by firmware is not getting invoked. Hence align ACPI blob sizes to PAGE boundary. Signed-off-by: Shameer Kolothum --- More details on this issue can be f

[Qemu-devel] [PATCH-for-4.2 v11 10/11] tests: Update ACPI tables list for upcoming arm/virt tests

2019-09-18 Thread Shameer Kolothum
This is in preparation to add numamem and memhp tests to arm/virt platform. The bios-tables-test-allowed-diff.h is updated with a list of expected ACPI tables that needs to be present in tests/data/acpi/virt folder. Signed-off-by: Shameer Kolothum --- v10 --> v11 As per Michael's suggest

[Qemu-devel] [PATCH-for-4.2 v11 11/11] tests: Add bios tests to arm/virt

2019-09-18 Thread Shameer Kolothum
This adds numamem and memhp tests for arm/virt platform. Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov --- v10-->v11 Added Igor's R-by. In order to avoid "make check" failure, the files listed in patch #10 has to be added to tests/data/acpi/virt folder befo

[Qemu-devel] [PATCH-for-4.2 v11 08/11] hw/arm: Use GED for system_powerdown event

2019-09-18 Thread Shameer Kolothum
For machines 4.2 or higher with ACPI boot use GED for system_powerdown event instead of GPIO. Guest boot with DT still uses GPIO. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger Reviewed-by: Igor Mammedov --- hw/acpi/generic_event_device.c | 8 hw/arm/virt-acpi

[Qemu-devel] [PATCH-for-4.2 v11 07/11] hw/arm: Factor out powerdown notifier from GPIO

2019-09-18 Thread Shameer Kolothum
This is in preparation of using GED device for system_powerdown event. Make the powerdown notifier registration independent of create_gpio() fn. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger Reviewed-by: Igor Mammedov --- hw/arm/virt.c | 12 include/hw/arm

[Qemu-devel] [PATCH-for-4.2 v11 03/11] hw/acpi: Add ACPI Generic Event Device Support

2019-09-18 Thread Shameer Kolothum
hotplug for now. Signed-off-by: Samuel Ortiz Signed-off-by: Sebastien Boeuf Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger --- Addressed comments from Igor. - Removed memhp_state.is_enabled condition check and property. - Used instance_init() instead of realize() --- hw/acpi/Kconfig

[Qemu-devel] [PATCH-for-4.2 v11 06/11] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT

2019-09-18 Thread Shameer Kolothum
lly (auto_enable_numa_with_memhp) when QEMU is started with memory hotplug enabled but without '-numa' options on CLI. Signed-off-by: Shameer Kolothum Signed-off-by: Eric Auger Reviewed-by: Igor Mammedov --- hw/arm/virt-acpi-build.c | 8 hw/arm/virt.c| 2 ++ 2 files changed, 10 inserti

[Qemu-devel] [PATCH-for-4.2 v11 05/11] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot

2019-09-18 Thread Shameer Kolothum
. As DSDT table gets changed by this, update bios-tables-test-allowed-diff.h to avoid "make check" failure. Signed-off-by: Shameer Kolothum --- v10--> v11 Update based on Igor's comments, - Invoke build_memory_hotplug_aml() based on ged-event property. --- hw/arm/Kconfig

[Qemu-devel] [PATCH-for-4.2 v11 00/11] ARM virt: ACPI memory hotplug support

2019-09-18 Thread Shameer Kolothum
/virt: Add memory hotplug framework Samuel Ortiz (2): hw/acpi: Do not create memory hotplug method when handler is not defined hw/acpi: Add ACPI Generic Event Device Support Shameer Kolothum (8): hw/acpi: Make ACPI IO address space configurable hw/arm/virt: Enable device memory cold

[Qemu-devel] [PATCH-for-4.2 v11 09/11] docs/specs: Add ACPI GED documentation

2019-09-18 Thread Shameer Kolothum
Documents basic concepts of ACPI Generic Event device(GED) and interface between QEMU and the ACPI BIOS. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger --- Addressed Peter's comments, -changed to rst format. -typo/grammer corrections. --- docs/specs/acpi_hw_reduced_hotplug.rst | 70

[Qemu-devel] [PATCH-for-4.2 v11 02/11] hw/acpi: Do not create memory hotplug method when handler is not defined

2019-09-18 Thread Shameer Kolothum
From: Samuel Ortiz With Hardware-reduced ACPI, the GED device will manage ACPI hotplug entirely. As a consequence, make the memory specific events AML generation optional. The code will only be added when the method name is not NULL. Signed-off-by: Samuel Ortiz Signed-off-by: Shameer Kolothum

[Qemu-devel] [PATCH-for-4.2 v11 04/11] hw/arm/virt: Add memory hotplug framework

2019-09-18 Thread Shameer Kolothum
Signed-off-by: Shameer Kolothum Reviewed-by: Peter Maydell Reviewed-by: Igor Mammedov --- hw/arm/Kconfig | 2 ++ hw/arm/virt.c | 53 +- 2 files changed, 54 insertions(+), 1 deletion(-) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index

[Qemu-devel] [PATCH-for-4.2 v11 01/11] hw/acpi: Make ACPI IO address space configurable

2019-09-18 Thread Shameer Kolothum
that other memory hotplug event signalling mechanisms (eg. Generic Event Device on HW-reduced acpi platforms) can use the same from their respective event handler code. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger Reviewed-by: Igor Mammedov --- hw/acpi/memory_hotplug.c | 33

[Qemu-devel] [PATCH-for-4.2 v10 11/11] tests: Add bios tests to arm/virt

2019-09-04 Thread Shameer Kolothum
This adds numamem and memhp tests for arm/virt platform Signed-off-by: Shameer Kolothum --- tests/bios-tables-test-allowed-diff.h | 1 + tests/bios-tables-test.c | 49 +++ 2 files changed, 50 insertions(+) diff --git a/tests/bios-tables-test-allowed-diff.h

[Qemu-devel] [PATCH-for-4.2 v10 10/11] tests: add dummy ACPI tables for arm/virt board

2019-09-04 Thread Shameer Kolothum
This patch is in preparation for adding numamem and memhp tests to arm/virt board so that 'make check' is happy. This may not be required once the scripts are run and new tables are generated with ".numamem" and ".memhp" extensions. Signed-off-by: Shameer Kolothu

[Qemu-devel] [PATCH-for-4.2 v10 09/11] docs/specs: Add ACPI GED documentation

2019-09-04 Thread Shameer Kolothum
Documents basic concepts of ACPI Generic Event device(GED) and interface between QEMU and the ACPI BIOS. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger --- docs/specs/acpi_hw_reduced_hotplug.txt | 60 ++ 1 file changed, 60 insertions(+) create mode 100644 docs

[Qemu-devel] [PATCH-for-4.2 v10 07/11] hw/arm: Factor out powerdown notifier from GPIO

2019-09-04 Thread Shameer Kolothum
This is in preparation of using GED device for system_powerdown event. Make the powerdown notifier registration independent of create_gpio() fn. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger --- hw/arm/virt.c | 12 include/hw/arm/virt.h | 1 + 2 files changed, 5

[Qemu-devel] [PATCH-for-4.2 v10 05/11] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot

2019-09-04 Thread Shameer Kolothum
. As DSDT table gets changed by this, update bios-tables-test-allowed-diff.h to avoid "make check" failure. Signed-off-by: Shameer Kolothum --- v9 --> v10 -updated commit log with bios-tables-test-allowed-diff.h info. -Removed object_property_add_child() from create_acpi_ged(). v8 --&

[Qemu-devel] [PATCH-for-4.2 v10 02/11] hw/acpi: Do not create memory hotplug method when handler is not defined

2019-09-04 Thread Shameer Kolothum
From: Samuel Ortiz With Hardware-reduced ACPI, the GED device will manage ACPI hotplug entirely. As a consequence, make the memory specific events AML generation optional. The code will only be added when the method name is not NULL. Signed-off-by: Samuel Ortiz Signed-off-by: Shameer Kolothum

[Qemu-devel] [PATCH-for-4.2 v10 08/11] hw/arm: Use GED for system_powerdown event

2019-09-04 Thread Shameer Kolothum
For machines 4.2 or higher with ACPI boot use GED for system_powerdown event instead of GPIO. Guest boot with DT still uses GPIO. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger --- v9 --> v10 -Eric's R-by v8 --> v9 -Re-arranged patches 8 & 9 from v8 based on Igor's com

[Qemu-devel] [PATCH-for-4.2 v10 06/11] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT

2019-09-04 Thread Shameer Kolothum
lly (auto_enable_numa_with_memhp) when QEMU is started with memory hotplug enabled but without '-numa' options on CLI. Signed-off-by: Shameer Kolothum Signed-off-by: Eric Auger Reviewed-by: Igor Mammedov --- v8 --> v9 - Added auto_enable_numa_with_memhp support. --- hw/arm/virt-acpi-build.c | 9 +++

[Qemu-devel] [PATCH-for-4.2 v10 01/11] hw/acpi: Make ACPI IO address space configurable

2019-09-04 Thread Shameer Kolothum
that other memory hotplug event signalling mechanisms (eg. Generic Event Device on HW-reduced acpi platforms) can use the same from their respective event handler code. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger --- v9 --> v10 - Fixed "make check" failure on x86_64. v8 -

[Qemu-devel] [PATCH-for-4.2 v10 03/11] hw/acpi: Add ACPI Generic Event Device Support

2019-09-04 Thread Shameer Kolothum
hotplug for now. Signed-off-by: Samuel Ortiz Signed-off-by: Sebastien Boeuf Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger --- v9 --> v10 -Added few required headers. -Added Eric's R-by v8 --> v9 -Changes related to GED being a TYPE_SYS_BUS_DEVICE now. -Removed Eric's R-

[Qemu-devel] [PATCH-for-4.2 v10 00/11] ARM virt: ACPI memory hotplug support

2019-09-04 Thread Shameer Kolothum
ed patches from Eric's v9 series. Eric Auger (1): hw/arm/virt: Add memory hotplug framework Samuel Ortiz (2): hw/acpi: Do not create memory hotplug method when handler is not defined hw/acpi: Add ACPI Generic Event Device Support Shameer Kolothum (8): hw/acpi: Make ACPI IO address space c

[Qemu-devel] [PATCH-for-4.2 v10 04/11] hw/arm/virt: Add memory hotplug framework

2019-09-04 Thread Shameer Kolothum
Signed-off-by: Shameer Kolothum Reviewed-by: Peter Maydell Reviewed-by: Igor Mammedov --- v8 --> v9 -Added error propagation. --- hw/arm/Kconfig | 2 ++ hw/arm/virt.c | 53 +- 2 files changed, 54 insertions(+), 1 deletion(-) diff --git a/hw/

[Qemu-devel] [PATCH-for-4.2 v9 11/12] tests: add dummy ACPI tables for arm/virt board

2019-08-13 Thread Shameer Kolothum
This patch is in preparation for adding numamem and memhp tests to arm/virt board so that 'make check' is happy. This may not be required once the scripts are run and new tables are generated with ".numamem" and ".memhp" extensions. Signed-off-by: Shameer Kolothu

[Qemu-devel] [PATCH-for-4.2 v9 07/12] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT

2019-08-13 Thread Shameer Kolothum
lly (auto_enable_numa_with_memhp) when QEMU is started with memory hotplug enabled but without '-numa' options on CLI. Signed-off-by: Shameer Kolothum Signed-off-by: Eric Auger Reviewed-by: Igor Mammedov --- v8 --> v9 - Added auto_enable_numa_with_memhp support. --- hw/arm/virt-acpi-build

[Qemu-devel] [PATCH-for-4.2 v9 09/12] hw/arm: Use GED for system_powerdown event

2019-08-13 Thread Shameer Kolothum
For machines 4.2 or higher with ACPI boot use GED for system_powerdown event instead of GPIO. Guest boot with DT still uses GPIO. Signed-off-by: Shameer Kolothum --- v8 --> v9 -Re-arranged patches 8 & 9 from v8 based on Igor's comments. v7 --> v8 -Retained gpio based system_powerdo

[Qemu-devel] [PATCH-for-4.2 v9 12/12] tests: Add bios tests to arm/virt

2019-08-13 Thread Shameer Kolothum
This adds numamem and memhp tests for arm/virt platform Signed-off-by: Shameer Kolothum --- tests/bios-tables-test-allowed-diff.h | 1 + tests/bios-tables-test.c | 49 +++ 2 files changed, 50 insertions(+) diff --git a/tests/bios-tables-test-allowed-diff.h

[Qemu-devel] [PATCH-for-4.2 v9 05/12] hw/arm/virt: Add 4.2 machine type

2019-08-13 Thread Shameer Kolothum
This is in preparation to create ACPI GED device as we need to disable it for <4.2 for migration to work. Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ include/hw/boards.h | 3 +++ 3 files changed, 14 inserti

[Qemu-devel] [PATCH-for-4.2 v9 00/12] ARM virt: ACPI memory hotplug support

2019-08-13 Thread Shameer Kolothum
events. -Removed NVDIMM support for now. -Includes dropped patches from Eric's v9 series. Eric Auger (1): hw/arm/virt: Add memory hotplug framework Samuel Ortiz (2): hw/acpi: Do not create memory hotplug method when handler is not defined hw/acpi: Add ACPI Generic Event Device Support Sham

[Qemu-devel] [PATCH-for-4.2 v9 10/12] docs/specs: Add ACPI GED documentation

2019-08-13 Thread Shameer Kolothum
Documents basic concepts of ACPI Generic Event device(GED) and interface between QEMU and the ACPI BIOS. Signed-off-by: Shameer Kolothum --- docs/specs/acpi_hw_reduced_hotplug.txt | 60 ++ 1 file changed, 60 insertions(+) create mode 100644 docs/specs

[Qemu-devel] [PATCH-for-4.2 v9 08/12] hw/arm: Factor out powerdown notifier from GPIO

2019-08-13 Thread Shameer Kolothum
This is in preparation of using GED device for system_powerdown event. Make the powerdown notifier registration independent of create_gpio() fn. Signed-off-by: Shameer Kolothum --- hw/arm/virt.c | 12 include/hw/arm/virt.h | 1 + 2 files changed, 5 insertions(+), 8

[Qemu-devel] [PATCH-for-4.2 v9 03/12] hw/acpi: Add ACPI Generic Event Device Support

2019-08-13 Thread Shameer Kolothum
hotplug for now. Signed-off-by: Samuel Ortiz Signed-off-by: Sebastien Boeuf Signed-off-by: Shameer Kolothum --- v8 --> v9 -Changes related to GED being a TYPE_SYS_BUS_DEVICE now. -Removed Eric's R-by tag for now. v7 --> v8. -Removed qemu_mutex_lock() across the ged state selector

[Qemu-devel] [PATCH-for-4.2 v9 06/12] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot

2019-08-13 Thread Shameer Kolothum
. Signed-off-by: Shameer Kolothum --- v8 --> v9 -Changes related to GED being a TYPE_SYS_BUS_DEVICE now. -Error propagation to _plug() handler. -Removed R-by by Eric for now. v7 --> v8 -Changed no_acpi_dev to no_ged. -Fixed 'dev' reference leak by object_new(). -Updated bios-tables-test-a

[Qemu-devel] [PATCH-for-4.2 v9 04/12] hw/arm/virt: Add memory hotplug framework

2019-08-13 Thread Shameer Kolothum
Signed-off-by: Shameer Kolothum Reviewed-by: Peter Maydell Reviewed-by: Igor Mammedov --- v8 --> v9 -Added error propagation. --- hw/arm/Kconfig | 2 ++ hw/arm/virt.c | 53 +- 2 files changed, 54 insertions(+), 1 deletion(-) diff --git a/hw/

[Qemu-devel] [PATCH-for-4.2 v9 02/12] hw/acpi: Do not create memory hotplug method when handler is not defined

2019-08-13 Thread Shameer Kolothum
From: Samuel Ortiz With Hardware-reduced ACPI, the GED device will manage ACPI hotplug entirely. As a consequence, make the memory specific events AML generation optional. The code will only be added when the method name is not NULL. Signed-off-by: Samuel Ortiz Signed-off-by: Shameer Kolothum

[Qemu-devel] [PATCH-for-4.2 v9 01/12] hw/acpi: Make ACPI IO address space configurable

2019-08-13 Thread Shameer Kolothum
that other memory hotplug event signalling mechanisms (eg. Generic Event Device on HW-reduced acpi platforms) can use the same from their respective event handler code. Signed-off-by: Shameer Kolothum --- v8 --> v9 -base address is an input into build_memory_hotplug_aml() -Removed R-by tags f

[Qemu-devel] [PATCH-for-4.2 v8 0/9] ARM virt: ACPI memory hotplug support

2019-07-26 Thread Shameer Kolothum
emoved NVDIMM support for now. -Includes dropped patches from Eric's v9 series. Eric Auger (1): hw/arm/virt: Add memory hotplug framework Samuel Ortiz (2): hw/acpi: Do not create memory hotplug method when handler is not defined hw/acpi: Add ACPI Generic Event Device Support Shameer

[Qemu-devel] [PATCH-for-4.2 v8 7/9] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT

2019-07-26 Thread Shameer Kolothum
Generate Memory Affinity Structures for PC-DIMM ranges. Signed-off-by: Shameer Kolothum Signed-off-by: Eric Auger Reviewed-by: Igor Mammedov --- hw/arm/virt-acpi-build.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index

[Qemu-devel] [PATCH-for-4.2 v8 9/9] hw/arm: Use GED for system_powerdown event

2019-07-26 Thread Shameer Kolothum
For machines 4.2 or higher with ACPI boot use GED for system_powerdown event instead of GPIO. Guest boot with DT still uses GPIO. Signed-off-by: Shameer Kolothum --- v7 --> v8 -Retained gpio based system_powerdown support for machines < 4.2. -Reuse of virt_powerdown_req() for ACPI G

[Qemu-devel] [PATCH-for-4.2 v8 5/9] hw/arm/virt: Add 4.2 machine type

2019-07-26 Thread Shameer Kolothum
This is in preparation to create ACPI GED device as we need to disable it for <4.2 for migration to work. Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ include/hw/boards.h | 3 +++ 3 files changed, 14 inserti

[Qemu-devel] [PATCH-for-4.2 v8 8/9] hw/acpi: Add system power down support to GED

2019-07-26 Thread Shameer Kolothum
This adds support to use GED for system power down event. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger --- hw/acpi/generic_event_device.c | 6 ++ include/hw/acpi/generic_event_device.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/hw/acpi/generic_event_device.c

[Qemu-devel] [PATCH-for-4.2 v8 6/9] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot

2019-07-26 Thread Shameer Kolothum
. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger --- -Changed no_acpi_dev to no_ged. -Fixed 'dev' reference leak by object_new(). -Updated bios-tables-test-allowed-diff.h to avoid "make check" failure. --- hw/arm/Kconfig| 2 + hw/arm/virt-ac

[Qemu-devel] [PATCH-for-4.2 v8 3/9] hw/acpi: Add ACPI Generic Event Device Support

2019-07-26 Thread Shameer Kolothum
hotplug for now. Signed-off-by: Samuel Ortiz Signed-off-by: Sebastien Boeuf Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger --- v7 --> v8. -Removed qemu_mutex_lock() across the ged state selector access. -Rephrased comments section in acpi_ged_send_event(). -Moved acpi_ged_event() c

[Qemu-devel] [PATCH-for-4.2 v8 4/9] hw/arm/virt: Add memory hotplug framework

2019-07-26 Thread Shameer Kolothum
Signed-off-by: Shameer Kolothum Reviewed-by: Peter Maydell Reviewed-by: Igor Mammedov --- hw/arm/Kconfig | 2 ++ hw/arm/virt.c | 51 +- 2 files changed, 52 insertions(+), 1 deletion(-) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index

[Qemu-devel] [PATCH-for-4.2 v8 2/9] hw/acpi: Do not create memory hotplug method when handler is not defined

2019-07-26 Thread Shameer Kolothum
From: Samuel Ortiz With Hardware-reduced ACPI, the GED device will manage ACPI hotplug entirely. As a consequence, make the memory specific events AML generation optional. The code will only be added when the method name is not NULL. Signed-off-by: Samuel Ortiz Signed-off-by: Shameer Kolothum

[Qemu-devel] [PATCH-for-4.2 v8 1/9] hw/acpi: Make ACPI IO address space configurable

2019-07-26 Thread Shameer Kolothum
their respective event handler code. Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger Reviewed-by: Igor Mammedov --- hw/acpi/memory_hotplug.c | 25 ++--- hw/i386/acpi-build.c | 3 ++- include/hw/acpi/memory_hotplug.h | 9 +++-- 3 files

  1   2   >