[PATCH] docs: Mark "gluster" support in QEMU as deprecated

2024-09-24 Thread Thomas Huth
According to https://marc.info/?l=fedora-devel-list&m=171934833215726 the GlusterFS development effectively ended. Thus mark it as deprecated in QEMU, so we can remove it in a future release if the project does not gain momentum again. Signed-off-by: Thomas Huth --- docs/about/deprecated

Re: [PATCH v3 30/34] migration: remove return after g_assert_not_reached()

2024-09-24 Thread Thomas Huth
| 7 --- migration/ram.c | 2 -- 3 files changed, 10 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-09-24 Thread Thomas Huth
On 23/09/2024 18.03, Eric Blake wrote: On Sun, Sep 22, 2024 at 08:51:22PM GMT, Richard W.M. Jones wrote: On Thu, Mar 28, 2024 at 02:13:42PM +, Richard W.M. Jones wrote: On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote: Since version 2.66, glib has useful URI parsing functions

Re: [PATCH v1 01/14] s390x/s390-virtio-ccw: don't crash on weird RAM sizes

2024-09-23 Thread Thomas Huth
On 23/09/2024 11.19, David Hildenbrand wrote: On 10.09.24 19:57, David Hildenbrand wrote: KVM is not happy when starting a VM with weird RAM sizes:    # qemu-system-s390x --enable-kvm --nographic -m 1234K    qemu-system-s390x: kvm_set_user_memory_region: KVM_SET_USER_MEMORY_REGION failed,

[PATCH] configs: Fix typo in the sh4-softmmu devices config file

2024-09-20 Thread Thomas Huth
This is the config file for the little endian target, so there should not be a "eb" in here. Signed-off-by: Thomas Huth --- configs/devices/sh4-softmmu/default.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/devices/sh4-softmmu/default.mak b/configs/d

[PATCH] tests/functional: Convert the powernv tests from boot_linux_console.py

2024-09-20 Thread Thomas Huth
Move the tests into the already existing test_ppc64_powernv.py file. Signed-off-by: Thomas Huth --- Based-on: 20240919185749.71222-1-th...@redhat.com tests/avocado/boot_linux_console.py| 46 -- tests/functional/test_ppc64_powernv.py | 42 +-- 2

Re: [PATCH] tests/qemu-iotests/testenv: Use the "r2d" machine for sh4/sh4eb

2024-09-20 Thread Thomas Huth
On 20/09/2024 10.06, Yoshinori Sato wrote: On Wed, 18 Sep 2024 04:43:50 +0900, Thomas Huth wrote: Commit 0ea0538fae516f9b4 removed the default machine of the sh4 binaries, so a lot of iotests are failing now without such a default machine. Teach the iotest harness to use the "r2d&quo

[PATCH 7/7] tests/functional: Convert the r2d sh4 Avocado test

2024-09-19 Thread Thomas Huth
This is the last test that is using the do_test_advcal_2018() function, so we can now remove that function from boot_linux_console.py, too. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/avocado/boot_linux_console.py | 25 --- tests

[PATCH 6/7] tests/functional: Convert the mac ppc Avocado tests

2024-09-19 Thread Thomas Huth
The g3beige and mac99 tests use the same asset, so put them together in a new test_ppc_mac.py file. Signed-off-by: Thomas Huth --- MAINTAINERS | 2 ++ tests/avocado/boot_linux_console.py | 30 --- tests/functional/meson.build| 1 + tests

[PATCH 3/7] tests/functional: Convert the xtensa lx60 Avocado test

2024-09-19 Thread Thomas Huth
Use the new launch_kernel function to convert this test in a simple way. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/avocado/boot_linux_console.py | 9 - tests/functional/meson.build | 4 tests/functional/test_xtensa_lx60.py | 26

[PATCH 2/7] tests/functional: Convert the vexpressa9 Avocado test

2024-09-19 Thread Thomas Huth
Use the new launch_kernel function to convert this test in a simple way. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/avocado/boot_linux_console.py | 9 - tests/functional/meson.build | 1 + tests/functional/test_arm_vexpress.py | 26

[PATCH 0/7] tests/functional: Convert the advent calendar tests

2024-09-19 Thread Thomas Huth
elper function to shorten this repetive task. Thomas Huth (7): tests/functional/qemu_test: Add a function for launching kernels more easily tests/functional: Convert the vexpressa9 Avocado test tests/functional: Convert the xtensa lx60 Avocado test tests/functional: Convert the SPA

[PATCH 5/7] tests/functional: Convert the e500 ppc64 Avocado test

2024-09-19 Thread Thomas Huth
Use the new launch_kernel function to convert this test in a simple way. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/avocado/boot_linux_console.py | 11 --- tests/functional/meson.build| 1 + tests/functional/test_ppc64_e500.py | 25

[PATCH 4/7] tests/functional: Convert the SPARCStation Avocado test

2024-09-19 Thread Thomas Huth
Use the new launch_kernel function to convert this test in a simple way. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/avocado/boot_linux_console.py | 8 tests/functional/meson.build | 4 tests/functional/test_sparc_sun4m.py | 25

[PATCH 1/7] tests/functional/qemu_test: Add a function for launching kernels more easily

2024-09-19 Thread Thomas Huth
The task for launching a kernel is quite repetitive: Set the serial console, set the -kernel and maybe -initrd and -dtb parameters, launch the VM and then wait for the expected console output. So it's easier in some tests to provide these steps via a separate function. Signed-off-by: Thomas

Re: [PATCH 2/2] .gitlab-ci.d: Make separate collapsible log sections for build and test

2024-09-19 Thread Thomas Huth
uild" and "test" separate collapsible stages. As recommended by the GitLab docs, we use some shell which is sourced in the CI job to define functions to emit the magic lines that start and end sections, to hide the ugliness of the printf lines from the log. Signed-off-by: Peter Maydell --- Reviewed-by: Thomas Huth

Re: [PATCH 1/2] .gitlab-ci.d: Split build and test in cross build job templates

2024-09-19 Thread Thomas Huth
ace to separate out how parallel we want to do the build by default from how parallel we want to do the tests by default, which might be helpful in future. Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth

Re: [PATCH] tests/qtest: Add XIVE tests for the powernv10 machine

2024-09-18 Thread Thomas Huth
On 18/09/2024 19.08, Mike Kowal wrote: On 9/18/2024 10:05 AM, Thomas Huth wrote: ... That also does not look like proper content for a header file. Please put it into a .c file instead. When these test were originally written, the authors had all of the tests and their functions in one .c

Re: [PATCH] tests/qtest: Add XIVE tests for the powernv10 machine

2024-09-18 Thread Thomas Huth
-...@nongnu.org S: Odd Fixes F: hw/*/*xive* F: include/hw/*/*xive* +F: tests/qtest/*xive* F: docs/*/*xive* Renesas peripherals @@ -3326,7 +3327,7 @@ R: Paolo Bonzini R: Bandan Das R: Stefan Hajnoczi R: Thomas Huth -R: Darren Kenny +R: Darren Kenny Please drop this hunk. R

[PATCH] tests/qemu-iotests/testenv: Use the "r2d" machine for sh4/sh4eb

2024-09-17 Thread Thomas Huth
Commit 0ea0538fae516f9b4 removed the default machine of the sh4 binaries, so a lot of iotests are failing now without such a default machine. Teach the iotest harness to use the "r2d" machine instead to fix this problem. Signed-off-by: Thomas Huth --- tests/qemu-iotests/testenv.py

[PATCH] tests/qemu-iotests/testenv: Use the "virt" machine for or1k

2024-09-17 Thread Thomas Huth
des PCI and thus e.g. support for virtio-blk and virtio-scsi, too. With this change, there are no failing iotests anymore when using the qemu-system-or1k binary for running the tests. Signed-off-by: Thomas Huth --- tests/qemu-iotests/testenv.py | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] tests/functional: Put the or1k_sim test into the slow category

2024-09-17 Thread Thomas Huth
Looks like a copy-n-paste mistake while adding the or1k_sim test here: The test downloads an asset from the internet, so it should be in the thorough category, not in the quick one. Signed-off-by: Thomas Huth --- tests/functional/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PULL 10/17] include/hw/s390x: replace assert(false) with g_assert_not_reached()

2024-09-17 Thread Thomas Huth
From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Pierrick Bouvier Reviewed-by: Eric Farman

[PULL 15/17] docs/fuzz: fix outdated mention to enable-sanitizers

2024-09-17 Thread Thomas Huth
ge-ID: <0ecf4e1ab26771009d74a2ce61e7c17ddc586ef7.1726226316.git.quic_mathb...@quicinc.com> Signed-off-by: Thomas Huth --- docs/devel/testing/fuzzing.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/devel/testing/fuzzing.rst b/docs/devel/testing/fuzzing.rst index

[PULL 16/17] tests/functional: Move the mips64el fuloong2e test into the thorough category

2024-09-17 Thread Thomas Huth
Commit d2fce37597c2 added a test that downloads an asset from the internet, so this test should not be run by default anymore and be put into the thorough category instead. Message-ID: <20240913175140.3329083-1-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thoma

[PULL 14/17] system: Enable the device aliases for or1k, too

2024-09-17 Thread Thomas Huth
-or1k later. Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240705090808.1305765-1-th...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240705124528.97471-3-phi...@linaro.org> Signed-off-by: Thomas Huth --- system/qdev-monitor.c | 1 + 1 file changed, 1 insertion(+

[PULL 12/17] tests/qtest: remove break after g_assert_not_reached()

2024-09-17 Thread Thomas Huth
ouv...@linaro.org> Signed-off-by: Thomas Huth --- tests/qtest/migration-helpers.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c index a43d180c80..0025933883 100644 --- a/tests/qtest/migration-helpers.c +++ b/tests/qtest/mig

[PULL 09/17] tests/unit: replace assert(0) with g_assert_not_reached()

2024-09-17 Thread Thomas Huth
ouv...@linaro.org> Signed-off-by: Thomas Huth --- tests/unit/test-xs-node.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/test-xs-node.c b/tests/unit/test-xs-node.c index ac94e7ed6c..2f447a73fb 100644 --- a/tests/unit/test-xs-node.c +++ b/tests/unit/test-xs-

[PULL 04/17] tests/qtest/meson.build: Add more CONFIG switches checks for the x86 tests

2024-09-17 Thread Thomas Huth
ice is not available. Message-ID: <20240905191434.694440-6-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/meson.build | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index fc852f

[PULL 08/17] tests/qtest: replace assert(0) with g_assert_not_reached()

2024-09-17 Thread Thomas Huth
From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Pierrick Bouvier Message-ID

[PULL 07/17] gitlab: fix logic for changing docker tag on stable branches

2024-09-17 Thread Thomas Huth
Tokarev Message-ID: <20240906140958.84755-1-berra...@redhat.com> Signed-off-by: Thomas Huth --- .gitlab-ci.d/base.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.d/base.yml b/.gitlab-ci.d/base.yml index bf3d8efab6..25b88aaa06 100644 --- a/.gitlab-ci.d/base.yml +++ b/.gitl

[PULL 11/17] tests/qtest: replace assert(false) with g_assert_not_reached()

2024-09-17 Thread Thomas Huth
ouv...@linaro.org> Signed-off-by: Thomas Huth --- tests/qtest/numa-test.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/qtest/numa-test.c b/tests/qtest/numa-test.c index ede418963c..6d92baee86 100644 --- a/tests/qtest/numa-test.c +++ b/tests/qtest/numa-

[PULL 05/17] tests/qtest: Disable numa-test if the default machine is not available

2024-09-17 Thread Thomas Huth
at.com> Signed-off-by: Thomas Huth --- tests/qtest/meson.build | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index ce0dba18cb..310865e49c 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -142,7

[PULL 17/17] .gitlab-ci.d/crossbuilds.yml: Force 'make check' to -j2 for cross-i686-tci

2024-09-17 Thread Thomas Huth
-by: Thomas Huth Message-ID: <20240916134913.2540486-1-peter.mayd...@linaro.org> Signed-off-by: Thomas Huth --- .gitlab-ci.d/crossbuilds.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index 1e21

[PULL 13/17] system: Sort QEMU_ARCH_VIRTIO_PCI definition

2024-09-17 Thread Thomas Huth
From: Philippe Mathieu-Daudé Sort the QEMU_ARCH_VIRTIO_PCI to simplify adding/removing entries. Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240705124528.97471-2-phi...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Thomas Huth --- system/qdev-monitor.

[PULL 03/17] tests/qtest/hd-geo-test: Check for availability of "pc" machine before using it

2024-09-17 Thread Thomas Huth
In case QEMU has been configured with "--without-default-devices", the "pc" machine type might be missing in the binary. We should check for its availability before using it. Message-ID: <20240905191434.694440-5-th...@redhat.com> Signed-off-by: Thomas Huth --- test

[PULL 06/17] .gitlab-ci.d/buildtest: Build most targets in the build-without-defaults job

2024-09-17 Thread Thomas Huth
erage by a related target. Message-ID: <20240905191434.694440-9-th...@redhat.com> Signed-off-by: Thomas Huth --- .gitlab-ci.d/buildtest.yml | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index b75e4edbf6..2

[PULL 02/17] tests/qtest/boot-order-test: Make the machine name mandatory in this test

2024-09-17 Thread Thomas Huth
ppe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/qtest/boot-order-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/boot-order-test.c b/tests/qtest/boot-order-test.c index 8f2b6ef05a..c67b8cfe16 100644 --- a/tests/qtest/boot-order-test.c +++ b/tests

[PULL 01/17] tests/qtest/cdrom-test: Improve the machine detection in the cdrom test

2024-09-17 Thread Thomas Huth
40905191434.694440-3-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/cdrom-test.c | 77 ++-- 1 file changed, 42 insertions(+), 35 deletions(-) diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c index 5d89e62515..9d72b24e4b 100644 --- a/test

[PULL 00/17] s390x and test patches

2024-09-17 Thread Thomas Huth
_not_reached() tests/qtest: remove break after g_assert_not_reached() Thomas Huth (8): tests/qtest/cdrom-test: Improve the machine detection in the cdrom test tests/qtest/boot-order-test: Make the machine name mandatory in this test tests/qtest/hd-geo-test: Check for avail

Re: [PATCH v2 12/18] tests/tcg: ensure s390x-softmmu output redirected

2024-09-17 Thread Thomas Huth
On 16/09/2024 10.53, Alex Bennée wrote: The multiarch system tests output serial data which should be redirected to the "output" chardev rather than echoed to the console. Comment the use of EXTFLAGS variable while we are at it. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth

Re: [PATCH] .gitlab-ci.d/crossbuilds.yml: Force 'make check' to -j2 for cross-i686-tci

2024-09-16 Thread Thomas Huth
+MAKE_CHECK_ARGS: check check-tcg -j2 cross-mipsel-system: extends: .cross_system_build_job Reviewed-by: Thomas Huth

Re: [PULL 00/47] riscv-to-apply queue

2024-09-15 Thread Thomas Huth
On 15/09/2024 21.58, Daniel Henrique Barboza wrote: Hi Peter, Alistair, On 9/14/24 6:15 AM, Alistair Francis wrote: On Fri, Sep 13, 2024 at 8:37 PM Peter Maydell wrote: On Thu, 12 Sept 2024 at 06:30, Alistair Francis wrote: The following changes since commit a4eb31c678400472de0b4915b915

Re: [PATCH 12/17] tests/tcg: ensure s390x-softmmu output redirected

2024-09-15 Thread Thomas Huth
On 13/09/2024 19.26, Alex Bennée wrote: The multiarch system tests output serial data which should be redirected to the "output" chardev rather than echoed to the console. Remove the unused EXTFLAGS variable while we are at it. Signed-off-by: Alex Bennée --- tests/tcg/s390x/Makefile.softmmu-

[PATCH] tests/functional: Move the mips64el fuloong2e test into the thorough category

2024-09-13 Thread Thomas Huth
Commit d2fce37597c2 added a test that downloads an asset from the internet, so this test should not be run by default anymore and be put into the thorough category instead. Signed-off-by: Thomas Huth --- tests/functional/meson.build | 5 + 1 file changed, 1 insertion(+), 4 deletions

[PATCH] hw/pci-bridge: Add a Kconfig switch for the normal PCI bridge

2024-09-13 Thread Thomas Huth
The pci-bridge device is not usable on s390x, so introduce a Kconfig switch that allows to disable it. Signed-off-by: Thomas Huth --- hw/pci-bridge/Kconfig | 5 + hw/pci-bridge/meson.build | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/pci-bridge/Kconfig b/hw

Re: [PATCH v2] .gitlab-ci.d/crossbuilds.yml: Force 'make check' single-threaded for cross-i686-tci

2024-09-13 Thread Thomas Huth
On 13/09/2024 15.31, Peter Maydell wrote: On Fri, 13 Sept 2024 at 13:24, Peter Maydell wrote: On Thu, 12 Sept 2024 at 16:10, Peter Maydell wrote: The cross-i686-tci CI job is persistently flaky with various tests hitting timeouts. One theory for why this is happening is that we're running

[PATCH] hw/virtio/Kconfig: Include vhost-user-scmi only on arm targets

2024-09-13 Thread Thomas Huth
The System Control and Management Interface is specific to arm machines, so don't include this device in non-arm targets. Signed-off-by: Thomas Huth --- hw/virtio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/Kconfig b/hw/virtio/Kconfig index aa63f

Re: [RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-13 Thread Thomas Huth
On 13/09/2024 13.46, Peter Maydell wrote: On Fri, 13 Sept 2024 at 12:29, Markus Armbruster wrote: Peter Maydell writes: Specifically, if you don't disable the error-exit when qtest is in use, then the generic qom-test tests which say "can we at least instantiate every machine?" will fail, be

Re: [PATCH] hw/loongarch/virt: Add description for virt machine type

2024-09-13 Thread Thomas Huth
>max_cpus = LOONGARCH_MAX_CPUS; mc->is_default = 1; mc->default_kernel_irqchip_split = false; base-commit: 4b7ea33074450bc6148c8e1545d78f179e64adb4 Reviewed-by: Thomas Huth CC:-ing qemu-stable for getting it fixed in the next stable release of 9.1, too.

Re: [PATCH v4 1/5] hw/loongarch: Rename LOONGARCH_MACHINE with LOONGARCH_VIRT_MACHINE

2024-09-13 Thread Thomas Huth
On 08/05/2024 05.11, Bibo Mao wrote: On LoongArch system, there is only virt machine type now, name LOONGARCH_MACHINE is confused, rename it with LOONGARCH_VIRT_MACHINE. Machine name about Other real hw boards can be added in future. Signed-off-by: Bibo Mao --- ... diff --git a/hw/loongarch/v

Re: [PATCH v2] .gitlab-ci.d/crossbuilds.yml: Force 'make check' single-threaded for cross-i686-tci

2024-09-12 Thread Thomas Huth
arallelism of 9. +MAKE_CHECK_ARGS: check check-tcg -j1 Reviewed-by: Thomas Huth

Re: [PATCH v1 07/14] s390x/s390-hypercall: introduce DIAG500 STORAGE_LIMIT

2024-09-12 Thread Thomas Huth
@ -18,6 +18,7 @@ #define DIAG500_VIRTIO_RESET1 /* legacy */ #define DIAG500_VIRTIO_SET_STATUS 2 /* legacy */ #define DIAG500_VIRTIO_CCW_NOTIFY 3 /* KVM_S390_VIRTIO_CCW_NOTIFY */ +#define DIAG500_STORAGE_LIMIT 4 int handle_diag_500(CPUS390XState *env); Revie

Re: [PATCH v1 06/14] s390x: introduce s390_get_memory_limit()

2024-09-12 Thread Thomas Huth
s390x/cpu.h| 1 + 2 files changed, 18 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v1 05/14] s390x/s390-virtio-ccw: move setting the maximum guest size from sclp to machine code

2024-09-12 Thread Thomas Huth
for any memory devices. Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 22 ++ hw/s390x/sclp.c| 11 --- 2 files changed, 18 insertions(+), 15 deletions(-) Reviewed-by: Thomas Huth

Gitlab CI caching is not working

2024-09-11 Thread Thomas Huth
Hi! While looking at some recent CI jobs, I noticed that the caching of the Gitlab-CI jobs is not working at all anymore. In the build jobs, the ccache saving is not working and causing a complete cache miss of each compile: https://gitlab.com/qemu-project/qemu/-/jobs/7802183187#L5328 An

Re: [PATCH v1 04/14] s390x: rename s390-virtio-hcall* to s390-hypercall*

2024-09-11 Thread Thomas Huth
percall.c} (97%) rename hw/s390x/{s390-virtio-hcall.h => s390-hypercall.h} (86%) Reviewed-by: Thomas Huth

Re: [PATCH v1 03/14] s390x/s390-virtio-hcall: prepare for more diag500 hypercalls

2024-09-11 Thread Thomas Huth
4 files changed, 14 insertions(+), 19 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Thomas Huth
On 11/09/2024 14.51, Richard W.M. Jones wrote: On Wed, Sep 11, 2024 at 02:46:18PM +0200, Maciej S. Szmigiero wrote: On 11.09.2024 14:37, Eric Blake wrote: On Wed, Sep 11, 2024 at 07:33:59AM GMT, Eric Blake wrote: On Tue, Sep 10, 2024 at 03:15:28PM GMT, Pierrick Bouvier wrote: Signed-off-by: P

Re: [PATCH v1 02/14] s390x/s390-virtio-hcall: remove hypercall registration mechanism

2024-09-11 Thread Thomas Huth
. Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 58 hw/s390x/s390-virtio-hcall.c | 65 +++- hw/s390x/s390-virtio-hcall.h | 2 -- 3 files changed, 49 insertions(+), 76 deletions(-) Reviewed-by: Thomas

Re: [PATCH v1 01/14] s390x/s390-virtio-ccw: don't crash on weird RAM sizes

2024-09-11 Thread Thomas Huth
On 11/09/2024 14.38, David Hildenbrand wrote: On 11.09.24 13:28, Janosch Frank wrote: On 9/10/24 7:57 PM, David Hildenbrand wrote: KVM is not happy when starting a VM with weird RAM sizes:     # qemu-system-s390x --enable-kvm --nographic -m 1234K     qemu-system-s390x: kvm_set_user_memory_regi

Re: [PATCH v1 01/14] s390x/s390-virtio-ccw: don't crash on weird RAM sizes

2024-09-11 Thread Thomas Huth
1 MiB Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 11 +++ 1 file changed, 11 insertions(+) Reviewed-by: Thomas Huth

[PULL v2 23/24] tests/functional/qemu_test: Use Python hashlib instead of external programs

2024-09-11 Thread Thomas Huth
dhat.com> Reviewed-by: Brian Cain Signed-off-by: Thomas Huth --- tests/functional/qemu_test/asset.py | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_test/asset.py index d3be2aff82..3ec429217e 1

[PULL v2 24/24] Update FreeBSD CI jobs FreeBSD 14.1

2024-09-11 Thread Thomas Huth
The current FreeBSD CI jobs are failing installation since the "opencv" package is now missing there. Updating to 14.1 fixes the issue. Message-Id: <20240911090149.286257-1-th...@redhat.com> Reviewed-by: Li-Wen Hsu Signed-off-by: Thomas Huth --- .gitlab

[PULL v2 00/24] Tests and misc patches

2024-09-11 Thread Thomas Huth
do tests Richard Henderson (2): meson: Split --enable-sanitizers to --enable-{asan, ubsan} meson: Move -fsanitize=undefined into normal configuraton Thomas Huth (11): contrib/plugins/Makefile: Add a 'distclean' target MAINTAINERS: Remove myself from the Meson

[PATCH] Update FreeBSD CI jobs FreeBSD 14.1

2024-09-11 Thread Thomas Huth
The current FreeBSD CI jobs are failing installation since the "opencv" package is now missing there. Updating to 14.1 fixes the issue. Signed-off-by: Thomas Huth --- Here's the output of a successful run: https://gitlab.com/thuth/qemu/-/jobs/7795460644 .gitlab-

Re: [PATCH 12/39] tests/qtest: replace assert(0) with g_assert_not_reached()

2024-09-10 Thread Thomas Huth
) -#define fatal(...) do { g_test_message(__VA_ARGS__); g_assert(0); } while (0) +#define fatal(...) do { g_test_message(__VA_ARGS__); g_assert_not_reached(); } while (0) static void test_timer(void) { Reviewed-by: Thomas Huth

Re: [PATCH 14/39] include/hw/s390x: replace assert(false) with g_assert_not_reached()

2024-09-10 Thread Thomas Huth
); +g_assert_not_reached(); } #endif Reviewed-by: Thomas Huth

[PATCH] tests/functional/qemu_test: Use Python hashlib instead of external programs

2024-09-10 Thread Thomas Huth
Some systems (like OpenBSD) do not have the sha256sum or sha512sum programs installed by default. Use the Python hashlib instead so we don't have to rely on the external programs. Reported-by: Peter Maydell Signed-off-by: Thomas Huth --- tests/functional/qemu_test/asset.py

Re: [PULL 00/22] Tests and misc patches

2024-09-10 Thread Thomas Huth
On 10/09/2024 17.38, Peter Maydell wrote: On Tue, 10 Sept 2024 at 13:37, Thomas Huth wrote: The following changes since commit 7bbadc60b58b742494555f06cd342311ddab9351: Merge tag 'crypto-fixes-pull-request' of https://gitlab.com/berrange/qemu into staging (2024-09-09 15:19:32 +

[PULL 08/22] tests/functional: Convert the m68k Q800 Avocado test into a functional test

2024-09-10 Thread Thomas Huth
Just had to update the asset checksum to use SHA256 instead of SHA1, but apart from that it is a pretty much straightforward conversion. Message-ID: <20240906180549.792832-3-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thoma

[PULL 18/22] tests/functional: Convert the Alpha Clipper Avocado test

2024-09-10 Thread Thomas Huth
Straight forward conversion, just switch to SHA256 hashsum now. Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240906180549.792832-13-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/avocado/boot_linux_console.py| 21 --

[PULL 15/22] tests/functional: Convert ARM Raspi2 avocado tests

2024-09-10 Thread Thomas Huth
age-ID: <20240906180549.792832-10-th...@redhat.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/avocado/boot_linux_console.py | 85 -- tests/functional/meson.build| 1 + tests/functional/test_arm_raspi2.py | 95

[PULL 10/22] tests/functional: Convert mips64el I6400 Malta avocado tests

2024-09-10 Thread Thomas Huth
From: Philippe Mathieu-Daudé Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240827094905.80648-4-phi...@linaro.org> Reviewed-by: Thomas Huth Mess

[PULL 14/22] tests/functional: Convert mips32eb 4Kc Malta avocado tests

2024-09-10 Thread Thomas Huth
age-ID: <20240906180549.792832-9-th...@redhat.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/avocado/boot_linux_console.py | 63 -- tests/functional/meson.build| 4 ++ tests/functional/test_mips_malta.py | 81

[PULL 12/22] tests/functional: Convert mips32el Malta YAMON avocado test

2024-09-10 Thread Thomas Huth
8-6-phi...@linaro.org> Reviewed-by: Thomas Huth Message-ID: <20240906180549.792832-7-th...@redhat.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 2 +- tests/avocado/machine_mips_malta.py | 54 - tests/functional/meson.build

[PULL 05/22] MAINTAINERS: Remove myself as reviewer

2024-09-10 Thread Thomas Huth
f any questions arise. Signed-off-by: Beraldo Leal Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240819150035.2180786-1-bl...@redhat.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 3 --- 1 file changed, 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0c1bc69828..8c7358

[PULL 20/22] tests/functional: Convert the or1k-sim Avocado test

2024-09-10 Thread Thomas Huth
y: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/avocado/boot_linux_console.py | 8 tests/functional/meson.build| 4 tests/functional/test_or1k_sim.py | 29 + 3 files changed, 33 insertions(+),

[PULL 21/22] tests/functional: Convert the multiprocess avocado test into a standalone test

2024-09-10 Thread Thomas Huth
This test handles both, aarch64 and x86_64, with the same test code (apart from some initial setup), so don't split this file by target but add a check for self.arch in the main test function. Message-ID: <20240903051333.102494-1-th...@redhat.com> Signed-off-by: Thomas Huth --- te

[PULL 17/22] tests/functional: Convert Aarch64 Raspi4 avocado tests

2024-09-10 Thread Thomas Huth
age-ID: <20240906180549.792832-12-th...@redhat.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/avocado/boot_linux_console.py | 97 tests/functional/meson.build| 1 + tests/functional/test_aarch64_ra

[PULL 22/22] tests/functional: Fix bad usage of has_cmd

2024-09-10 Thread Thomas Huth
pe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/functional/qemu_test/cmd.py | 6 +++--- tests/functional/qemu_test/tesseract.py | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/functional/qemu_test/cmd.py b/tests/functional/qemu_test/cmd.py index 3acd617324..c

[PULL 11/22] tests/functional: Convert mips64el 5KEc Malta avocado tests

2024-09-10 Thread Thomas Huth
edhat.com> Signed-off-by: Thomas Huth --- tests/avocado/boot_linux_console.py | 74 tests/functional/test_mips64el_malta.py | 76 + 2 files changed, 76 insertions(+), 74 deletions(-) diff --git a/tests/avocado/boot_linux_console.py b/t

[PULL 04/22] contrib/plugins/Makefile: Add a 'distclean' target

2024-09-10 Thread Thomas Huth
ith "make distclean", add this command to one of the build jobs, too. Message-ID: <20240902154749.73876-1-th...@redhat.com> Reviewed-by: Pierrick Bouvier Signed-off-by: Thomas Huth --- .gitlab-ci.d/buildtest.yml | 2 ++ contrib/plugins/Makefile | 2 +- 2 files changed, 3 insertion

[PULL 09/22] tests/functional: Convert mips64el Fuloong2e avocado test (2/2)

2024-09-10 Thread Thomas Huth
s test] Message-ID: <20240906180549.792832-4-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/avocado/boot_linux_console.py | 21 - tests/functional/test_mips64el_fuloong2e.py | 25 ++--- 2 files changed, 22 insertions(+), 24 deletions(-) diff --git a/t

[PULL 07/22] tests/functional: Add the LinuxKernelTest for testing the Linux boot process

2024-09-10 Thread Thomas Huth
Copy the LinuxKernelTest from tests/acceptance/boot_linux_console.py to be able to convert the related tests to the functional test framework in the following patches. Message-ID: <20240906180549.792832-2-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thoma

[PULL 03/22] gitlab-ci: Build MSYS2 job using multiple CPUs

2024-09-10 Thread Thomas Huth
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240819112141.13786-1-phi...@linaro.org> Signed-off-by: Thomas Huth --- .gitlab-ci.d/windows.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.d/windows.yml b/.gitla

[PULL 13/22] tests/functional: Convert nanomips Malta avocado tests

2024-09-10 Thread Thomas Huth
igned-off-by: Thomas Huth --- tests/avocado/boot_linux_console.py | 59 --- tests/functional/test_mipsel_malta.py | 51 ++- 2 files changed, 50 insertions(+), 60 deletions(-) diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_cons

[PULL 06/22] MAINTAINERS: Remove myself from the Meson section

2024-09-10 Thread Thomas Huth
The Meson section has plenty of reviewers, and in order to reduce the load on my Inbox a little bit, I'm stepping back as a reviewer here. Message-ID: <20240906155900.742157-1-th...@redhat.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) d

[PULL 00/22] Tests and misc patches

2024-09-10 Thread Thomas Huth
ts/functional: Convert Aarch64 Raspi3 avocado tests tests/functional: Convert Aarch64 Raspi4 avocado tests Richard Henderson (2): meson: Split --enable-sanitizers to --enable-{asan, ubsan} meson: Move -fsanitize=undefined into normal configuraton Thomas Huth (9): contrib/plug

[PULL 16/22] tests/functional: Convert Aarch64 Raspi3 avocado tests

2024-09-10 Thread Thomas Huth
age-ID: <20240906180549.792832-11-th...@redhat.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/avocado/boot_linux_console.py | 23 -- tests/functional/meson.build| 1 + tests/functional/test_aarch64_ra

[PULL 02/22] meson: Move -fsanitize=undefined into normal configuraton

2024-09-10 Thread Thomas Huth
requires proper ordering of options. Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Message-ID: <20240813095216.306555-3-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- meson.build| 11 +-- .gitlab-ci.d/buildtest.yml | 10 -- 2 files c

[PULL 19/22] tests/functional: Convert the m68k MCF5208EVB Avocado test

2024-09-10 Thread Thomas Huth
y: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/avocado/boot_linux_console.py | 8 --- tests/functional/meson.build | 1 + tests/functional/test_m68k_mcf5208evb.py | 29 3 files changed, 30 inser

[PULL 01/22] meson: Split --enable-sanitizers to --enable-{asan, ubsan}

2024-09-10 Thread Thomas Huth
nd it seems wrong to hold aarch64 and s390x to a different standard. Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Message-ID: <20240813095216.306555-2-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- docs/devel/testing/fuzzing.rst| 4 ++--

Re: [PATCH 2/2] .gitlab-ci.d/crossbuilds.yml: Force 'make check' single threaded for cross-i686-tci

2024-09-10 Thread Thomas Huth
On 06/09/2024 20.07, Peter Maydell wrote: The cross-i686-tci CI job is persistently flaky with various tests hitting timeouts. One theory for why this is happening is that we're running too many tests in parallel and so sometimes a test gets starved of CPU and isn't able to complete within the t

Re: [PATCH 5/5] license: Update deprecated SPDX tag GPL-2.0 to GPL-2.0-only

2024-09-10 Thread Thomas Huth
faa09b2377..b586b4e86d 100644 --- a/tests/tcg/loongarch64/system/regdef.h +++ b/tests/tcg/loongarch64/system/regdef.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0 */ +/* SPDX-License-Identifier: GPL-2.0-only */  /*   * Copyright (c) 2021 Loongson Technology Corporation Limited   */ Looks good, you can keep: Reviewed-by: Thomas Huth

Re: [PATCH 5/5] license: Update deprecated SPDX tag GPL-2.0 to GPL-2.0-only

2024-09-10 Thread Thomas Huth
ml Mechanical patch running: $ sed -i -e s/GPL-2.0/GPL-2.0-only/ \ $(git grep -l 'SPDX-License-Identifier: GPL-2.0$') Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Thomas Huth

Re: [PATCH 4/5] license: Update deprecated SPDX tag GPL-2.0+ to GPL-2.0-or-later

2024-09-10 Thread Thomas Huth
PL-2.0-or-later.html Mechanical patch running: $ sed -i -e s/GPL-2.0+/GPL-2.0-or-later/ \ $(git grep -l 'SPDX-License-Identifier: GPL-2.0+$') Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Thomas Huth

Re: [PATCH 3/5] license: Update deprecated SPDX tag LGPL-2.0+ to LGPL-2.0-or-later

2024-09-10 Thread Thomas Huth
PL-2.0-or-later.html Mechanical patch running: $ sed -i -e s/LGPL-2.0+/LGPL-2.0-or-later/ \ $(git grep -l 'SPDX-License-Identifier: LGPL-2.0+$') Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Thomas Huth

Re: [PATCH 1/5] NSIS: Simplify license description

2024-09-10 Thread Thomas Huth
++- 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Thomas Huth

Re: [PATCH 2/5] tests/functional: Correct typo in test_netdev_ethtool.py SPDX tag

2024-09-10 Thread Thomas Huth
alidate network # device behaviour. # -# SPDX-License-Identifier: GPL-2.0-or-late +# SPDX-License-Identifier: GPL-2.0-or-later from unittest import skip from qemu_test import QemuSystemTest, Asset Reviewed-by: Thomas Huth

  1   2   3   4   5   6   7   8   9   10   >