s390x regression - Re: [PATCH v5 21/26] linux-user/s390x: Implement setup_sigtramp

2022-04-28 Thread Ulrich Weigand
Richard Henderson wrote: >Create and record the two signal trampolines. >Use them when the guest does not use SA_RESTORER. This patch caused a regression when running the wasmtime CI under qemu: https://github.com/bytecodealliance/wasmtime/pull/4076 The problem is that this part: >diff --git

Re: [PATCH v5 1/2] target/s390x: Fix SIGILL/SIGFPE/SIGTRAP psw.addr reporting

2021-07-06 Thread Ulrich Weigand
ve indicates), so this looks OK to me. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain ulrich.weig...@de.ibm.com

Re: [PATCH v5 0/2] target/s390x: Fix SIGILL/SIGFPE/SIGTRAP psw.addr reporting

2021-07-02 Thread Ulrich Weigand
cks. > > > > If from the S390x point of view they are correct, I can collect them via > linux-user. It's certainly correct that SIGILL, SIGFPE and SIGTRAP are delivered with psw.addr pointing *after* the faulting instruction, that forms in effect part of the kernel ABI on s390x. We're planning to document this in the next revision of the ABI document, see here: https://github.com/IBM/s390x-abi/issues/2 I can also confirm that this patch fixes the problems I was seeing when running the s390x wasmtime JIT under qemu. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain ulrich.weig...@de.ibm.com

[PATCH v3] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

2021-06-30 Thread Ulrich Weigand
rect result directly in the helper. (It cannot be re-computed later as the information about the invalid exception is no longer available.) This fixes a bug observed when running the wasmtime test suite under the s390x-linux-user target. Signed-off-by: Ulrich Weigand --- target/s39

Re: [PATCH v2] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

2021-06-30 Thread Ulrich Weigand
On Mon, Jun 28, 2021 at 11:45:27AM -0700, Richard Henderson wrote: > On 6/28/21 9:35 AM, Ulrich Weigand wrote: > >@@ -506,6 +534,7 @@ uint64_t HELPER(cgeb)(CPUS390XState *env, uint64_t v2, > >uint32_t m34) > > { > > int old_mode = s390_swap_bfp_rounding_m

Re: [PATCH] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

2021-06-30 Thread Ulrich Weigand
On Mon, Jun 28, 2021 at 10:49:52AM -0700, Richard Henderson wrote: > On 6/28/21 9:32 AM, Ulrich Weigand wrote: > >>Don't clear out env->fpu_status.float_exception_flags in > >>handle_exceptions. Wait until we're actually done with the data. > > > >I don't r

[PATCH v2] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

2021-06-28 Thread Ulrich Weigand
rect result directly in the helper. (It cannot be re-computed later as the information about the invalid exception is no longer available.) This fixes a bug observed when running the wasmtime test suite under the s390x-linux-user target. Signed-off-by: Ulrich Weigand --- target/s39

Re: [PATCH] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

2021-06-28 Thread Ulrich Weigand
On Mon, Jun 28, 2021 at 06:26:52AM -0700, Richard Henderson wrote: > On 6/28/21 5:58 AM, Ulrich Weigand wrote: > >>>helper.h:DEF_HELPER_FLAGS_3(clgdb, TCG_CALL_NO_WG, i64, env, i64, i32) > >> > >>This won't work reliably. You're writing to a tcg global i

Re: [PATCH] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

2021-06-28 Thread Ulrich Weigand
On Fri, Jun 25, 2021 at 06:19:48PM -0700, Richard Henderson wrote: > On 6/23/21 7:50 AM, Ulrich Weigand wrote: > >@@ -506,6 +534,7 @@ uint64_t HELPER(cgeb)(CPUS390XState *env, uint64_t v2, > >uint32_t m34) > > { > > int old_mode = s390_swap_bfp_rounding_m

[PATCH] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

2021-06-23 Thread Ulrich Weigand
rect result directly in the helper. (It cannot be re-computed later as the information about the invalid exception is no longer available.) This fixes a bug observed when running the wasmtime test suite under the s390x-linux-user target. Signed-off-by: Ulrich Weigand --- target/s39

Re: [Qemu-devel] [PATCH 1/3] linux-user: Handle ELFv2 PPC64 binaries in user mode.

2014-05-08 Thread Ulrich Weigand
Doug Kwan (關振德) dougk...@google.com wrote on 08.05.2014 10:43:14: On Thu, May 8, 2014 at 1:36 AM, Alexander Graf ag...@suse.de wrote: -    _regs-gpr[2] = ldq_raw(infop-entry + 8) + infop-load_bias; -    infop-entry = ldq_raw(infop-entry) + infop-load_bias; +    if (get_ppc64_abi(infop) 2) {

Re: [Qemu-devel] [PATCH 00/26] Merge ppc32/ppc64 tcg backends

2014-05-02 Thread Ulrich Weigand
Richard Henderson rth7...@gmail.com wrote on 01.05.2014 17:44:21: Please review, and if you've got an ELFv2 system (nudge nudge), please give it a try and make sure it works. I ran into illegal instructions due to this patch: tcg-ppc64: Support mulsh_i32 [snip] case

Re: [Qemu-devel] [PATCH] tcg-ppc64: Support the ELFv2 ABI

2014-04-22 Thread Ulrich Weigand
Richard Henderson rth7...@gmail.com wrote on 22.04.2014 19:53:18: On 04/22/2014 09:20 AM, Ulrich Weigand wrote: +#elif _CALL_ELF == 2 +/* In the ELFv2 ABI, we do not need to set up the TOC pointer in r2, + but instead we have to set up r12 to contain the destination address

[Qemu-devel] [PATCH] tcg-ppc64: Support the ELFv2 ABI

2014-04-22 Thread Ulrich Weigand
and function prologue sequences. Signed-off-by: Ulrich Weigand ulrich.weig...@de.ibm.com --- tcg/ppc64/tcg-target.c | 18 +- 1 files changed, 17 insertions(+), 1 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 06e440f..4ef4838 100644 --- a/tcg/ppc64

Re: [Qemu-devel] [PATCH] gdbstub: allow byte swapping for reading/writing registers

2014-01-15 Thread Ulrich Weigand
Alexander Graf ag...@suse.de wrote on 14.01.2014 23:40:20: On 14.01.2014, at 23:06, Thomas Falcon tlfal...@linux.vnet.ibm.com wrote: This patch allows registers to be properly read from and written to when using the gdbstub to debug a ppc guest running in little endian mode. It