Re: [Qemu-devel] [PATCH v4 00/15] tests: acpi: add UEFI (ARM) testing support

anged, 178 insertions(+), 75 deletions(-) > create mode 100644 tests/data/acpi/virt/APIC > create mode 100644 tests/data/acpi/virt/DSDT > create mode 100644 tests/data/acpi/virt/FACP > create mode 100644 tests/data/acpi/virt/GTDT > create mode 100644 tests/data/acpi/virt/MCFG > create mode 100644 tests/data/acpi/virt/SPCR > Tested the series on the hisilicon D05 board(arm64 based), so FWIW: Tested-by: Wei Xu Thanks! Best Regards, Wei

Re: [Qemu-devel] [PATCH v3 11/13] tests: acpi: add simple arm/virt testcase

Hi Igor, On 5/2/2019 3:24 PM, Igor Mammedov wrote: > On Fri, 26 Apr 2019 17:28:10 +0100 > Wei Xu wrote: > >> Hi Igor, >> >> On 4/26/2019 12:54 PM, Igor Mammedov wrote: >>> On Fri, 26 Apr 2019 00:51:56 +0800 >>> x00249684 wrote: >>> >&g

Re: [Qemu-devel] [PATCH v3 11/13] tests: acpi: add simple arm/virt testcase

Hi Igor, On 4/26/2019 12:54 PM, Igor Mammedov wrote: > On Fri, 26 Apr 2019 00:51:56 +0800 > x00249684 wrote: > >> Hi Igor, >> >> +static void test_acpi_virt_tcg(void) >> +{ >> +test_data data = { >> +.machine = "virt", >> +.uefi_fl1 = "pc-bios/edk2-aarch64-code.fd", >> +

Re: [Qemu-devel] [PATCH v4 09/11] virtio-net: update the head descriptor in a chain lastly

On Wed, Feb 20, 2019 at 10:34:32AM +0800, Jason Wang wrote: > > On 2019/2/20 上午9:54, Wei Xu wrote: > >On Tue, Feb 19, 2019 at 09:09:33PM +0800, Jason Wang wrote: > >>On 2019/2/19 下午6:51, Wei Xu wrote: > >>>On Tue, Feb 19, 2019 at 03:23:01PM +0800, Jason Wang wro

Re: [Qemu-devel] [PATCH v4 08/11] virtio: event suppression support for packed ring

On Tue, Feb 19, 2019 at 09:06:42PM +0800, Jason Wang wrote: > > On 2019/2/19 下午6:40, Wei Xu wrote: > >On Tue, Feb 19, 2019 at 03:19:58PM +0800, Jason Wang wrote: > >>On 2019/2/14 下午12:26, w...@redhat.com wrote: > >>>From: Wei Xu > >>>

Re: [Qemu-devel] [PATCH v4 09/11] virtio-net: update the head descriptor in a chain lastly

On Tue, Feb 19, 2019 at 09:09:33PM +0800, Jason Wang wrote: > > On 2019/2/19 下午6:51, Wei Xu wrote: > >On Tue, Feb 19, 2019 at 03:23:01PM +0800, Jason Wang wrote: > >>On 2019/2/14 下午12:26, w...@redhat.com wrote: > >>>From: Wei Xu > >>> > >>&g

Re: [Qemu-devel] [PATCH v4 11/11] virtio: CLI and provide packed ring feature bit by default

On Tue, Feb 19, 2019 at 09:33:40PM +0800, Jason Wang wrote: > > On 2019/2/19 下午7:23, Wei Xu wrote: > >On Tue, Feb 19, 2019 at 03:32:19PM +0800, Jason Wang wrote: > >>On 2019/2/14 下午12:26,w...@redhat.com wrote: > >>>From: Wei Xu > >>> >

Re: [Qemu-devel] [PATCH v4 07/11] virtio: fill/flush/pop for packed ring

On Tue, Feb 19, 2019 at 05:33:57PM +0800, Jason Wang wrote: > > On 2019/2/19 下午4:21, Wei Xu wrote: > >On Tue, Feb 19, 2019 at 02:49:42PM +0800, Jason Wang wrote: > >>On 2019/2/18 下午10:46, Wei Xu wrote: > >>>>Do we allow chain more descriptors than vq size in t

Re: [Qemu-devel] [PATCH v4 11/11] virtio: CLI and provide packed ring feature bit by default

On Tue, Feb 19, 2019 at 03:32:19PM +0800, Jason Wang wrote: > > On 2019/2/14 下午12:26, w...@redhat.com wrote: > >From: Wei Xu > > > >Add userspace and vhost kernel/user support. > > > >Add CLI "ring_packed=true/false" to enable/disable packed ring p

Re: [Qemu-devel] [PATCH v4 10/11] virtio: migration support for packed ring

On Tue, Feb 19, 2019 at 03:30:41PM +0800, Jason Wang wrote: > > On 2019/2/14 下午12:26, w...@redhat.com wrote: > >From: Wei Xu > > > >Both userspace and vhost-net/user are supported with this patch. > > > >A new subsection is introduced f

Re: [Qemu-devel] [PATCH v4 09/11] virtio-net: update the head descriptor in a chain lastly

On Tue, Feb 19, 2019 at 03:23:01PM +0800, Jason Wang wrote: > > On 2019/2/14 下午12:26, w...@redhat.com wrote: > >From: Wei Xu > > > >This is a helper for packed ring. > > > >To support packed ring, the head descriptor in a chain should be updated > >lastl

Re: [Qemu-devel] [PATCH v4 08/11] virtio: event suppression support for packed ring

On Tue, Feb 19, 2019 at 03:19:58PM +0800, Jason Wang wrote: > > On 2019/2/14 下午12:26, w...@redhat.com wrote: > >From: Wei Xu > > > >Difference between 'avail_wrap_counter' and 'last_avail_wrap_counter': > >For Tx(guest transmitting), they are the same after eac

Re: [Qemu-devel] [PATCH v4 06/11] virtio: get avail bytes check for packed ring

On Tue, Feb 19, 2019 at 02:24:11PM +0800, Jason Wang wrote: > > On 2019/2/19 上午1:07, Wei Xu wrote: > >On Mon, Feb 18, 2019 at 03:27:21PM +0800, Jason Wang wrote: > >>On 2019/2/14 下午12:26, w...@redhat.com wrote: > >>>From: Wei Xu > >>> > >>&g

Re: [Qemu-devel] [PATCH v4 07/11] virtio: fill/flush/pop for packed ring

On Tue, Feb 19, 2019 at 02:49:42PM +0800, Jason Wang wrote: > > On 2019/2/18 下午10:46, Wei Xu wrote: > >>Do we allow chain more descriptors than vq size in the case of indirect? > >>According to the spec: > >> > >>" > >> > >

Re: [Qemu-devel] [PATCH v4 06/11] virtio: get avail bytes check for packed ring

On Mon, Feb 18, 2019 at 03:27:21PM +0800, Jason Wang wrote: > > On 2019/2/14 下午12:26, w...@redhat.com wrote: > >From: Wei Xu > > > >Add packed ring headcount check. > > > >Common part of split/packed ring are kept. > > > >Signed-off-

Re: [Qemu-devel] [PATCH v4 07/11] virtio: fill/flush/pop for packed ring

On Mon, Feb 18, 2019 at 03:51:05PM +0800, Jason Wang wrote: > > On 2019/2/14 下午12:26, w...@redhat.com wrote: > >From: Wei Xu > > > >last_used_idx/wrap_counter should be equal to last_avail_idx/wrap_counter > >after a successful flush. > > >

Re: [Qemu-devel] [PATCH v3 00/11] packed ring virtio-net backends support

On Wed, Feb 13, 2019 at 09:17:57AM -0500, Michael S. Tsirkin wrote: > On Wed, Feb 13, 2019 at 08:25:35AM -0500, w...@redhat.com wrote: > > From: Wei Xu > > > > https://github.com/Whishay/qemu.git > > > > Userspace and vhost-net backedn test has been done

Re: [Qemu-devel] [PATCH v1 13/16] virtio: add vhost-net migration of packed ring

On Wed, Nov 28, 2018 at 11:34:46AM +0100, Maxime Coquelin wrote: > > > On 11/22/18 3:06 PM, w...@redhat.com wrote: > >From: Wei Xu > > > >tweaked vhost-net code to test migration. > > > >@@ -1414,64 +1430,20 @@ long vhost_vring_ioctl(struc

Re: [Qemu-devel] [PATCH v1 12/16] virtio: add userspace migration of packed ring

On Thu, Nov 22, 2018 at 10:45:36PM +0800, Jason Wang wrote: > > On 2018/11/22 下午10:06, w...@redhat.com wrote: > >From: Wei Xu > > > >Signed-off-by: Wei Xu > > > I think you need subsection. Otherwise you will break migration > compatibility. ok, thanks. W

Re: [Qemu-devel] [PATCH v1 09/16] virtio: fill/flush/pop for packed ring

On Fri, Nov 30, 2018 at 01:45:19PM +0100, Maxime Coquelin wrote: > Hi Wei, > > On 11/22/18 3:06 PM, w...@redhat.com wrote: > >+void virtqueue_flush(VirtQueue *vq, unsigned int count) > >+{ > >+if (unlikely(vq->vdev->broken)) { > >+vq->inuse -= count; > >+return; > >+} > >+

Re: [Qemu-devel] [PATCH v3 12/16] virtio: split virtio net bits rom virtio-pci

csi-pci.o > obj-$(CONFIG_VIRTIO_BLK) += virtio-blk-pci.o > +obj-$(CONFIG_VIRTIO_NET) += virtio-net-pci.o > endif > endif s/rom/from/ in the subject for patch 10, 11, 12 and 13. Reviewed-by: Wei Xu > > diff --git a/hw/virtio/virtio-net-pci.c b/hw/virtio/virtio-net-pci.c &g

Re: [Qemu-devel] [PATCH v1 00/16] packed ring virtio-net backend support

On Fri, Nov 23, 2018 at 01:57:37PM +0800, Wei Xu wrote: > On Thu, Nov 22, 2018 at 06:57:31PM +0100, Maxime Coquelin wrote: > > Hi Wei, > > > > I just tested your series with Tiwei's v3, and it fails > > with ctrl vq enabled: > > qemu-system-x86_64: virtio-ne

Re: [Qemu-devel] [PATCH v1 00/16] packed ring virtio-net backend support

i > > Regards, > Maxime > > On 11/22/18 3:06 PM, w...@redhat.com wrote: > >From: Wei Xu > > > >Code base: > > https://github.com/Whishay/qemu.git > > > >rfc v3 -> v1 > >- migration support for both userspace and vhost-net, need tweak v

Re: [Qemu-devel] [PATCH v1 01/16] Update version for v3.1.0-rc2 release

This is an irrelevant patch mistakenly posted, please drop this, sorry. On Thu, Nov 22, 2018 at 09:06:06AM -0500, w...@redhat.com wrote: > From: Peter Maydell > > Signed-off-by: Peter Maydell > --- > VERSION | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/VERSION

Re: [Qemu-devel] [[RFC v3 12/12] virtio: feature vhost-net support for packed ring

On Wed, Nov 21, 2018 at 02:03:59PM +0100, Maxime Coquelin wrote: > Hi Wei, > > On 10/11/18 4:08 PM, w...@redhat.com wrote: > >From: Wei Xu > > > >(cherry picked from commit 305a2c4640c15c5717245067ab937fd10f478ee6) > >Signed-off-by: Wei

Re: [Qemu-devel] [RFC v3 00/12] packed ring virtio-net userspace backend support

desc[i].addr = cpu_to_le64(addr); > desc[i].len = cpu_to_le32(sg->length); > i++; > -- > 2.14.1 > > On Thu, Oct 11, 2018 at 10:08:23AM -0400, w...@redhat.com wrote: > > From: Wei Xu > > > > code base: > > https://g

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

Looks good, I can't recall the status of last version well but I remember Jason gave some comments about sanity check are quiet essential, have you addressed them? Reviewed by: Wei Xu On Fri, Nov 09, 2018 at 04:58:27PM +0200, Yuri Benditovich wrote: > This commit adds implementation of

Re: [Qemu-devel] [[RFC v3 08/12] virtio: event suppression support for packed ring

On Mon, Oct 15, 2018 at 02:59:48PM +0800, Jason Wang wrote: > > > On 2018年10月11日 22:08, w...@redhat.com wrote: > >From: Wei Xu > > > >Signed-off-by: Wei Xu > >--- > > hw/virtio/virtio.c | 126 > > ++

Re: [Qemu-devel] [[RFC v3 12/12] virtio: feature vhost-net support for packed ring

On Mon, Oct 15, 2018 at 03:50:21PM +0800, Jason Wang wrote: > > > On 2018年10月11日 22:08, w...@redhat.com wrote: > >From: Wei Xu > > > >(cherry picked from commit 305a2c4640c15c5717245067ab937fd10f478ee6) > >Signed-off-by: Wei

Re: [Qemu-devel] [[RFC v3 09/12] virtio-net: fill head desc after done all in a chain

On Mon, Oct 15, 2018 at 03:45:46PM +0800, Jason Wang wrote: > > > On 2018年10月11日 22:08, w...@redhat.com wrote: > >From: Wei Xu > > > >With the support of marking a descriptor used/unused in 'flags' > >field for 1.1, the current way of filling a chained descript

Re: [Qemu-devel] [[RFC v3 02/12] virtio: redefine structure & memory cache for packed ring

On Mon, Oct 15, 2018 at 11:03:52AM +0800, Jason Wang wrote: > > > On 2018年10月11日 22:08, w...@redhat.com wrote: > >From: Wei Xu > > > >Redefine packed ring structure according to qemu nomenclature, > >also supported data(event index, wrap counter, etc) are intr

Re: [Qemu-devel] [[RFC v3 03/12] virtio: init memory cache for packed ring

On Mon, Oct 15, 2018 at 11:10:12AM +0800, Jason Wang wrote: > > > On 2018年10月11日 22:08, w...@redhat.com wrote: > >From: Wei Xu > > > >Expand 1.0 by adding offset calculation accordingly. > > This is only part of what this patch did and I suggest to another pat

Re: [Qemu-devel] [[RFC v3 05/12] virtio: init and desc empty check for packed ring

On Mon, Oct 15, 2018 at 11:18:05AM +0800, Jason Wang wrote: > > > On 2018年10月11日 22:08, w...@redhat.com wrote: > >From: Wei Xu > > > >Basic initialization and helpers for packed ring. > > > >Signed-off-by: Wei

Re: [Qemu-devel] [RFC v2 5/8] virtio: queue pop for packed ring

On Wed, Jun 06, 2018 at 11:41:18AM +0800, Jason Wang wrote: > > > On 2018年06月06日 11:38, Wei Xu wrote: > >>>+ > >>>+head = vq->last_avail_idx; > >>>+i = head; > >>>+ > >>>+caches = vring_get_region_caches(vq); &g

Re: [Qemu-devel] [RFC v2 8/8] virtio: guest driver reload for vhost-net

On Wed, Jun 06, 2018 at 11:48:19AM +0800, Jason Wang wrote: > > > On 2018年06月06日 03:08, w...@redhat.com wrote: > >From: Wei Xu > > > >last_avail, avail_wrap_count, used_idx and used_wrap_count are > >needed to support vhost-net backend, all these are eith

Re: [Qemu-devel] [RFC v2 0/8] packed ring virtio-net userspace backend support

On Wed, Jun 06, 2018 at 11:49:22AM +0800, Jason Wang wrote: > > > On 2018年06月06日 03:07, w...@redhat.com wrote: > >From: Wei Xu > > > >Todo: > >- address Rx slow performance > >- event index interrupt suppression test > > And there's somet

Re: [Qemu-devel] [RFC v2 2/8] virtio: memory cache for packed ring

On Wed, Jun 06, 2018 at 10:53:07AM +0800, Jason Wang wrote: > > > On 2018年06月06日 03:07, w...@redhat.com wrote: > >From: Wei Xu > > > >Mostly reuse memory cache with 1.0 except for the offset calculation. > > > >Signed-off-by: Wei

Re: [Qemu-devel] [RFC v2 5/8] virtio: queue pop for packed ring

On Wed, Jun 06, 2018 at 11:29:54AM +0800, Jason Wang wrote: > > > On 2018年06月06日 03:08, w...@redhat.com wrote: > >From: Wei Xu > > > >Signed-off-by: Wei Xu > >--- > > hw/virtio/virtio.c | 145 > > ++

Re: [Qemu-devel] [PATCH 4/8] virtio: add detach element for packed ring(1.1)

On Mon, Jun 04, 2018 at 04:54:45AM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2018 at 09:34:35AM +0800, Wei Xu wrote: > > On Tue, Apr 10, 2018 at 03:32:53PM +0800, Jason Wang wrote: > > > > > > > > > On 2018年04月04日 20:54, w...@redhat.com wrote: > &

Re: [Qemu-devel] [PATCH 8/8] virtio: queue pop support for packed ring

On Wed, Apr 11, 2018 at 10:43:40AM +0800, Jason Wang wrote: > > > On 2018年04月04日 20:54, w...@redhat.com wrote: > >From: Wei Xu > > > >cloned from split ring pop, a global static length array > >and the inside-element length array are introduced to > >ea

Re: [Qemu-devel] [PATCH 7/8] virtio: get avail bytes check for packed ring

On Wed, Apr 11, 2018 at 11:03:24AM +0800, Jason Wang wrote: > > > On 2018年04月04日 20:54, w...@redhat.com wrote: > >From: Wei Xu > > > >mostly as same as 1.0, copy it separately for > >prototype, need a refactoring. > > > >Signed-off-by:

Re: [Qemu-devel] [PATCH 4/8] virtio: add detach element for packed ring(1.1)

On Tue, Apr 10, 2018 at 03:32:53PM +0800, Jason Wang wrote: > > > On 2018年04月04日 20:54, w...@redhat.com wrote: > >From: Wei Xu > > > >helper for packed ring > > It's odd and hard to review if you put detach patch first. I think this > patch needs to be reord

Re: [Qemu-devel] [PATCH 3/8] virtio: add empty check for packed ring

On Tue, Apr 10, 2018 at 03:23:03PM +0800, Jason Wang wrote: > > > On 2018年04月04日 20:53, w...@redhat.com wrote: > >From: Wei Xu > > > >helper for ring empty check. > > And descriptor read. OK. > > > > >Signed-off

Re: [Qemu-devel] [PATCH 1/8] virtio: feature bit, data structure for packed ring

On Tue, Apr 10, 2018 at 03:05:24PM +0800, Jason Wang wrote: > > > On 2018年04月04日 20:53, w...@redhat.com wrote: > >From: Wei Xu > > > >Only minimum definitions from the spec are included > >for prototype. > > > >Signed-o

Re: [Qemu-devel] [RFC PATCH 0/8] virtio-net 1.1 userspace backend support

On Tue, Apr 10, 2018 at 11:46:47AM +0800, Jason Wang wrote: > > > On 2018年04月04日 20:53, w...@redhat.com wrote: > >From: Wei Xu <w...@redhat.com> > > > >This is a prototype for virtio-net 1.1 support in userspace backend, > >only minimum part are in

Re: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

Hi Peter, On 2018/1/26 18:01, Peter Maydell wrote: > On 26 January 2018 at 17:33, Wei Xu <xuw...@hisilicon.com> wrote: >> On 2018/1/26 17:15, Peter Maydell wrote: >>> The pl011 code should call qemu_set_irq(..., 1) when the >>> guest enables interrupts on the dev

Re: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

Hi Andrew, On 2018/1/29 10:29, Andrew Jones wrote: > On Fri, Jan 26, 2018 at 06:01:33PM +, Peter Maydell wrote: >> On 26 January 2018 at 17:33, Wei Xu <xuw...@hisilicon.com> wrote: >>> On 2018/1/26 17:15, Peter Maydell wrote: >>>> The pl011 code s

[Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

and the pl011 state could not be driven further. This patch fixed that issue by checking the interruption is enabled or not before putting into the fifo. Signed-off-by: Wei Xu <xuw...@hisilicon.com> --- hw/char/pl011.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/char/pl011.c b/hw/char

Re: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

Hi Peter, On 2018/1/26 17:15, Peter Maydell wrote: > On 26 January 2018 at 17:05, Wei Xu <xuw...@hisilicon.com> wrote: >> On 2018/1/26 16:36, Peter Maydell wrote: >>> If the user presses keys before interrupts are enabled, >>> what ought to happen is: >>>

Re: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

Hi Peter, On 2018/1/26 16:36, Peter Maydell wrote: > On 26 January 2018 at 16:00, Wei Xu <xuw...@hisilicon.com> wrote: >> If the user pressed some keys in the console during the guest booting, >> the console will be hanged after entering the shell. >>

Re: [Qemu-devel] dropped pkts with Qemu on tap interace (RX)

On Wed, Jan 03, 2018 at 04:07:44PM +0100, Stefan Priebe - Profihost AG wrote: > > Am 03.01.2018 um 04:57 schrieb Wei Xu: > > On Tue, Jan 02, 2018 at 10:17:25PM +0100, Stefan Priebe - Profihost AG > > wrote: > >> > >> Am 02.01.2018 um 18:04 schrieb Wei Xu: >

Re: [Qemu-devel] dropped pkts with Qemu on tap interace (RX)

On Tue, Jan 02, 2018 at 10:17:25PM +0100, Stefan Priebe - Profihost AG wrote: > > Am 02.01.2018 um 18:04 schrieb Wei Xu: > > On Tue, Jan 02, 2018 at 04:24:33PM +0100, Stefan Priebe - Profihost AG > > wrote: > >> Hi, > >> Am 02.01.2018 um 15:20 schrieb Wei Xu:

Re: [Qemu-devel] dropped pkts with Qemu on tap interace (RX)

On Tue, Jan 02, 2018 at 04:24:33PM +0100, Stefan Priebe - Profihost AG wrote: > Hi, > Am 02.01.2018 um 15:20 schrieb Wei Xu: > > On Tue, Jan 02, 2018 at 12:17:29PM +0100, Stefan Priebe - Profihost AG > > wrote: > >> Hello, > >> > >> currently i'm

Re: [Qemu-devel] dropped pkts with Qemu on tap interace (RX)

On Tue, Jan 02, 2018 at 12:17:29PM +0100, Stefan Priebe - Profihost AG wrote: > Hello, > > currently i'm trying to fix a problem where we have "random" missing > packets. > > We're doing an ssh connect from machine a to machine b every 5 minutes > via rsync and ssh. > > Sometimes it happens

Re: [Qemu-devel] [PATCH] virtio-scsi: finalize IOMMU support

sgl, DEVICE(s), 8, vdev->dma_as); > qemu_iovec_init(>resp_iov, 1); > memset((uint8_t *)req + zero_skip, 0, sizeof(*req) - zero_skip); > } Reviewed-by: Wei Xu <w...@redhat.com> > -- > 2.7.4 > >

Re: [Qemu-devel] [PATCH 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic

On 2016年11月24日 12:17, Jason Wang wrote: On 2016年11月01日 01:41, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> All the data packets in a tcp connection are cached to a single buffer in every receive interval, and will be sent out via a timer, the 'virtio_net_rsc_timeout' co

Re: [Qemu-devel] [ RFC Patch v7 0/2] Support Receive-Segment-Offload(RSC) for WHQL

On 2016年11月24日 12:28, Jason Wang wrote: On 2016年11月01日 01:41, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> This patch is to support WHQL test for Windows guest, while this feature also benifits other guest works as a kernel 'gro' like feature with userspace implementation. F

Re: [Qemu-devel] [PATCH for 2.8 03/11] intel_iommu: name vtd address space with devfn

On 2016年08月30日 11:06, Jason Wang wrote: To avoid duplicated name and ease debugging. Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Acked-by: Peter Xu

Re: [Qemu-devel] [PATCH for 2.8 02/11] virtio: convert to use DMA api

On 2016年08月30日 11:06, Jason Wang wrote: @@ -1587,6 +1595,11 @@ static void virtio_pci_device_plugged(DeviceState *d, Error **errp) } if (legacy) { +if (virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM)) { +error_setg(errp, "VIRTIO_F_IOMMU_PLATFORM was

Re: [Qemu-devel] [PATCH for 2.8 01/11] linux-headers: update to 4.8-rc4

On 2016年08月30日 11:06, Jason Wang wrote: Signed-off-by: Jason Wang --- include/standard-headers/linux/input-event-codes.h | 32 + include/standard-headers/linux/input.h | 1 + include/standard-headers/linux/virtio_config.h | 10 +-

Re: [Qemu-devel] [RFC Patch 1/3] chardev: add new socket fd parameter for unix socket

On 2016年06月28日 14:48, Michael S. Tsirkin wrote: On Thu, Jun 23, 2016 at 12:46:46AM +0800, Wei Xu wrote: On 2016年06月22日 23:39, Eric Blake wrote: On 06/22/2016 09:25 AM, Wei Xu wrote: There have been comments on this patch, but i forgot adding this patch to the list, just forward it again

Re: [Qemu-devel] [RFC Patch 1/3] chardev: add new socket fd parameter for unix socket

月23日 00:46, Wei Xu wrote: On 2016年06月22日 23:39, Eric Blake wrote: On 06/22/2016 09:25 AM, Wei Xu wrote: There have been comments on this patch, but i forgot adding this patch to the list, just forward it again. When manage VMs via libvirt, qemu ofter runs with limited permission, thus qemu ca

Re: [Qemu-devel] [RFC Patch 1/3] chardev: add new socket fd parameter for unix socket

On 2016年06月22日 23:39, Eric Blake wrote: On 06/22/2016 09:25 AM, Wei Xu wrote: There have been comments on this patch, but i forgot adding this patch to the list, just forward it again. When manage VMs via libvirt, qemu ofter runs with limited permission, thus qemu can't create a file/socket

[Qemu-devel] [RFC Patch 3/3] sockets: replace creating a new socket with the record one

There has been comments on this patch, but i forgot adding this patch to the list, just forward it again. Both server mode and client mode are supported. Signed-off-by: Wei Xu <w...@redhat.com> --- util/qemu-sockets.c | 25 + 1 file changed, 17 insertions

[Qemu-devel] [RFC Patch 1/3] chardev: add new socket fd parameter for unix socket

in from libvirt. Signed-off-by: Wei Xu <w...@redhat.com> --- qapi-schema.json | 3 ++- qemu-char.c | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index 8483bdf..e9f0268 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -

[Qemu-devel] [RFC Patch 2/3] chardev: save the passed in 'fd' parameter during parsing

There has been comments on this patch, but i forgot adding this patch to the list, just forward it again. Save the 'fd' paramter as unix socket 'sockfd' member. Signed-off-by: Wei Xu <w...@redhat.com> --- qemu-char.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/qemu-ch

[Qemu-devel] [RFC Patch 0/3] Accept passed in socket 'fd' open from outside for unix socket

be kept even with the 'fd' is indicated, this looks odd, any comments? Wei Xu (3): chardev: add new socket fd parameter for unix socket chardev: save the passed in 'fd' parameter during parsing sockets: replace creating a new socket with the record one qapi-schema.json| 3 ++- qemu-char.c

Re: [Qemu-devel] [RFC Patch 0/3] Accept passed in socket 'fd' open from outside for unix socket

On 2016年06月14日 22:23, Aaron Conole wrote: "Daniel P. Berrange" <berra...@redhat.com> writes: On Tue, Jun 14, 2016 at 04:03:43PM +0800, Wei Xu wrote: On 2016年06月09日 05:48, Aaron Conole wrote: Flavio Leitner <f...@redhat.com> writes: Adding Aaron who is fixing exactl

Re: [Qemu-devel] [RFC Patch 0/3] Accept passed in socket 'fd' open from outside for unix socket

essage - From: "Michal Privoznik" <mpriv...@redhat.com> To: "Daniel P. Berrange" <berra...@redhat.com> Cc: qemu-devel@nongnu.org, "amit shah" <amit.s...@redhat.com>, jasow...@redhat.com, "Wei Xu" <w...@redhat.com>, arm...@redhat.com

Re: [Qemu-devel] [RFC Patch 0/3] Accept passed in socket 'fd' open from outside for unix socket

On 2016年06月02日 19:38, Michal Privoznik wrote: On 02.06.2016 10:29, Daniel P. Berrange wrote: On Thu, Jun 02, 2016 at 09:41:56AM +0200, Michal Privoznik wrote: On 01.06.2016 18:16, Wei Xu wrote: On 2016年06月01日 00:44, Daniel P. Berrange wrote: On Wed, Jun 01, 2016 at 12:30:44AM +0800, w

Re: [Qemu-devel] [ RFC Patch v6 3/3] virtio-net rsc: add 2 new rsc information fields to 'virtio_net_hdr'

On 2016年05月30日 13:57, Jason Wang wrote: On 2016年05月29日 00:37, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> Field 'coalesced' is to indicate how many packets are coalesced and field 'dup_ack' is how many duplicate acks are merged, guest driver can use these information to

Re: [Qemu-devel] [ RFC Patch v6 2/3] virtio-net rsc: support coalescing ipv6 tcp traffic

On 2016年05月30日 12:25, Jason Wang wrote: On 2016年05月29日 00:37, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> Most stuffs are like ipv4 2 differences between ipv4 and ipv6. 1. Fragment length in ipv4 header includes itself, while it's not included for ipv6, thus means ipv6 can

Re: [Qemu-devel] [ RFC Patch v6 1/3] virtio-net rsc: support coalescing ipv4 tcp traffic

On 2016年05月30日 12:20, Jason Wang wrote: On 2016年05月29日 00:37, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> All the data packets in a tcp connection will be cached to a big buffer in every receive interval, and will be sent out via a timer, the 'virtio_net_rsc_t

Re: [Qemu-devel] [RFC Patch 0/3] Accept passed in socket 'fd' open from outside for unix socket

On 2016年06月01日 00:44, Daniel P. Berrange wrote: On Wed, Jun 01, 2016 at 12:30:44AM +0800, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> Recently I'm working on a fd passing issue, selinux forbids qemu to create a unix socket for a chardev when managing VMs with libvirt, becaus

Re: [Qemu-devel] [RFC Patch 2/3] chardev: save the passed in 'fd' parameter during parsing

On 2016年06月01日 01:26, Eric Blake wrote: On 05/31/2016 10:30 AM, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> Save the 'fd' paramter as unix socket 'sockfd' member. Signed-off-by: Wei Xu <w...@redhat.com> --- qemu-char.c | 7 +++ 1 file changed, 7 insertions(+)

Re: [Qemu-devel] [RFC Patch 0/3] Accept passed in socket 'fd' open from outside for unix socket

On 2016年06月01日 01:22, Eric Blake wrote: On 05/31/2016 10:30 AM, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> Recently I'm working on a fd passing issue, selinux forbids qemu to create a unix socket for a chardev when managing VMs with libvirt, because qemu don't have suff

Re: [Qemu-devel] [ RFC Patch v6 0/2] Support Receive-Segment-Offload(RSC) for WHQL

On 2016年05月30日 12:22, Jason Wang wrote: On 2016年05月29日 00:37, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> Changes in V6: - Sync upstream code - Split new fields in 'virtio_net_hdr' to a seperate patch - Remove feature bit code, replace it with a command line parameter 'gue

Re: [Qemu-devel] [ RFC Patch v5 0/2] Support Receive-Segment-Offload(RSC) for WHQL

On 2016年05月24日 16:26, Michael S. Tsirkin wrote: On Tue, May 24, 2016 at 04:03:04PM +0800, Jason Wang wrote: On 2016年05月24日 04:14, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> Changes in V5: - Passed all IPv4/6 test cases - Add new fields in 'virtio_net_hdr' - Set 'gs

Re: [Qemu-devel] [ RFC Patch v5 0/2] Support Receive-Segment-Offload(RSC) for WHQL

On 2016年05月24日 16:03, Jason Wang wrote: On 2016年05月24日 04:14, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> Changes in V5: - Passed all IPv4/6 test cases - Add new fields in 'virtio_net_hdr' - Set 'gso_type' & 'coalesced packets' in new field. - Bypass all 'tcp opti

Re: [Qemu-devel] [ RFC Patch v4 1/3] virtio-net rsc: add a new host offload(rsc) feature bit

On 2016年04月05日 16:17, Michael S. Tsirkin wrote: On Tue, Apr 05, 2016 at 10:05:17AM +0800, Jason Wang wrote: On 04/04/2016 03:25 AM, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> A new feature bit 'VIRTIO_NET_F_GUEST_RSC' is introduced to support WHQL Receive-Segment-Offloa

Re: [Qemu-devel] [ RFC Patch v4 2/3] virtio-net rsc: support coalescing ipv4 tcp traffic

On 2016年04月08日 16:31, Jason Wang wrote: On 04/08/2016 03:47 PM, Wei Xu wrote: On 2016年04月05日 10:47, Jason Wang wrote: On 04/04/2016 03:25 AM, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> All the data packets in a tcp connection will be cached to a big buffer in every r

Re: [Qemu-devel] [ RFC Patch v4 3/3] virtio-net rsc: support coalescing ipv6 tcp traffic

On 2016年04月08日 15:27, Jason Wang wrote: On 04/08/2016 03:06 PM, Wei Xu wrote: On 2016年04月05日 10:50, Jason Wang wrote: On 04/04/2016 03:25 AM, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> Most things like ipv4 except there is a significant difference between ipv4 an

Re: [Qemu-devel] [ RFC Patch v4 2/3] virtio-net rsc: support coalescing ipv4 tcp traffic

On 2016年04月05日 10:47, Jason Wang wrote: On 04/04/2016 03:25 AM, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> All the data packets in a tcp connection will be cached to a big buffer in every receive interval, and will be sent out via a timer, the 'virtio_net_rsc_timeout' co

Re: [Qemu-devel] [ RFC Patch v4 3/3] virtio-net rsc: support coalescing ipv6 tcp traffic

On 2016年04月05日 10:50, Jason Wang wrote: On 04/04/2016 03:25 AM, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> Most things like ipv4 except there is a significant difference between ipv4 and ipv6, the fragment lenght in ipv4 header includes itself, while it's not typo

Re: [Qemu-devel] [ Patch 0/2] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest

On 2016年03月17日 23:44, Michael S. Tsirkin wrote: On Thu, Mar 17, 2016 at 11:21:28PM +0800, Wei Xu wrote: On 2016年03月17日 14:47, Jason Wang wrote: On 03/15/2016 05:17 PM,w...@redhat.com wrote: From: Wei Xu<w...@redhat.com> Fixed issues based on rfc patch v2: 1. Removed big param list, r

Re: [Qemu-devel] [ Patch 2/2] virtio-net rsc: support coalescing ipv6 tcp traffic

On 2016年03月17日 16:50, Jason Wang wrote: On 03/15/2016 05:17 PM, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> Most things like ipv4 except there is a significant difference between ipv4 and ipv6, the fragment lenght in ipv4 header includes itself, while it's not included fo

Re: [Qemu-devel] [ Patch 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic

On 2016年03月17日 16:42, Jason Wang wrote: On 03/15/2016 05:17 PM, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> All the data packets in a tcp connection will be cached to a big buffer in every receive interval, and will be sent out via a timer, the 'virtio_net_rsc_timeout' co

Re: [Qemu-devel] [ Patch 0/2] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest

On 2016年03月18日 13:21, Jason Wang wrote: On 03/18/2016 12:24 PM, Wei Xu wrote: On 2016年03月18日 10:22, Jason Wang wrote: On 03/18/2016 12:57 AM, Wei Xu wrote: On 2016年03月17日 23:44, Michael S. Tsirkin wrote: On Thu, Mar 17, 2016 at 11:21:28PM +0800, Wei Xu wrote: On 2016年03月17日 14:47, Jason

Re: [Qemu-devel] [ Patch 0/2] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest

On 2016年03月18日 10:22, Jason Wang wrote: On 03/18/2016 12:57 AM, Wei Xu wrote: On 2016年03月17日 23:44, Michael S. Tsirkin wrote: On Thu, Mar 17, 2016 at 11:21:28PM +0800, Wei Xu wrote: On 2016年03月17日 14:47, Jason Wang wrote: On 03/15/2016 05:17 PM,w...@redhat.com wrote: From: Wei Xu&l

Re: [Qemu-devel] [ Patch 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic

On 2016年03月18日 10:03, Jason Wang wrote: On 03/18/2016 12:45 AM, Wei Xu wrote: On 2016年03月17日 16:42, Jason Wang wrote: On 03/15/2016 05:17 PM, w...@redhat.com wrote: From: Wei Xu <w...@redhat.com> All the data packets in a tcp connection will be cached to a big buffer in every r

Re: [Qemu-devel] [ Patch 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic

On 2016年03月18日 14:56, Jason Wang wrote: On 03/18/2016 02:38 PM, Wei Xu wrote: On 2016年03月18日 13:20, Jason Wang wrote: On 03/18/2016 12:17 PM, Wei Xu wrote: +static ssize_t virtio_net_receive(NetClientState *nc, + const uint8_t *buf, size_t size

Re: [Qemu-devel] [ Patch 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic

On 2016年03月18日 13:20, Jason Wang wrote: On 03/18/2016 12:17 PM, Wei Xu wrote: +static ssize_t virtio_net_receive(NetClientState *nc, + const uint8_t *buf, size_t size) +{ +if (virtio_net_rsc_bypass) { +return virtio_net_do_receive(nc, buf, size

Re: [Qemu-devel] [ Patch 0/2] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest

On 2016年03月17日 14:47, Jason Wang wrote: On 03/15/2016 05:17 PM,w...@redhat.com wrote: From: Wei Xu<w...@redhat.com> Fixed issues based on rfc patch v2: 1. Removed big param list, replace it with 'NetRscUnit' 2. Different virtio header size 3. Modify callback function to direct c

Re: [Qemu-devel] [ Patch 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic

Re: [Qemu-devel] [ Patch 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic On Tue, Mar 15, 2016 at 05:17:03PM +0800, w...@redhat.com wrote: > From: Wei Xu <w...@redhat.com> > > All the data packets in a tcp connection will be cached to a big buffer > in every receive interval

Re: [Qemu-devel] [ Patch 0/2] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest

Re: [Qemu-devel] [ Patch 0/2] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest On Tue, Mar 15, 2016 at 05:17:02PM +0800, w...@redhat.com wrote: > From: Wei Xu <w...@redhat.com> > > Fixed issues based on rfc patch v2: > 1. Removed big param list, replace it with '

Re: [Qemu-devel] [RFC Patch v2 06/10] virtio-net rsc: IPv4 checksum

On 02/01/2016 02:31 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu <w...@wei-thinkpad.nay.redhat.com> If a field in the IPv4 header is modified, then the checksum have to be recalculated before sending it out. This in fact breaks bisection. I thi

Re: [Qemu-devel] [RFC Patch v2 05/10] virtio-net rsc: Create timer to drain the packets from the cache pool

On 02/01/2016 02:28 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu <w...@wei-thinkpad.nay.redhat.com> The timer will only be triggered if the packets pool is not empty, and it'll drain off all the cached packets, this is to reduce the delay to upper

Re: [Qemu-devel] [RFC Patch v2 08/10] virtio-net rsc: Sanity check & More bypass cases check

On 02/01/2016 02:58 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu <w...@wei-thinkpad.nay.redhat.com> More general exception cases check 1. Incorrect version in IP header 2. IP options & IP fragment 3. Not a TCP packets 4. Sanity size check to prev

Re: [Qemu-devel] [RFC Patch v2 03/10] virtio-net rsc: Chain Lookup, Packet Caching and Framework of IPv4

On 02/01/2016 01:55 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu <w...@wei-thinkpad.nay.redhat.com> Upon a packet is arriving, a corresponding chain will be selected or created, or be bypassed if it's not an IPv4 packets. The callback in the

Re: [Qemu-devel] [RFC Patch v2 09/10] virtio-net rsc: Add IPv6 support

On 02/01/2016 03:14 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu <w...@wei-thinkpad.nay.redhat.com> A few more stuffs should be included to support this 1. Corresponding chain lookup 2. Coalescing callback for the protocol chain 3. Filter & Sa

  1   2   >