Re: [Qemu-devel] virsh dump (qemu guest memory dump?): KASLR enabled linux guest support

On 11/09/2016 01:02 PM, Dave Young wrote: > On 11/09/16 at 11:58am, Wen Congyang wrote: >> On 11/09/2016 11:17 AM, Dave Young wrote: >>> Drop qiaonuohan, seems the mail address is wrong.. >>> >>> On 11/09/16 at 11:01am, Dave Young wrote: >>>>

Re: [Qemu-devel] virsh dump (qemu guest memory dump?): KASLR enabled linux guest support

emu devel >> list. If this is not correct please let me know. IIRC, 'virsh dump --memory-only' uses dump-guest-memory, and 'virsh dump' uses migration to dump. I think I should study kaslr first... Thanks Wen Congyang >> >> Could you qemu dump people make it work? Or we can not support virt dump >> as long as KASLR being enabled. Latest Fedora kernel has enabled it in >> x86_64. >> >> Thanks >> Dave > > >

Re: [Qemu-devel] [PATCH] replication: interrupt failover if the main device is closed

-by: Paolo Bonzini <pbonz...@redhat.com> This patch looks fine to me. Reviewed-by: Wen Congyang <we...@cn.fujitsu.com> --- block/replication.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/replication.c b/block/replication.c index 3bd1cf1..5231a00 100644 --- a/block/r

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

is removed) We add a new child, its role name is children.2, not children.0. If we want to attach the child not in the tail, for example: Quorum has two children: children.0, children.1. And the new child should be before children.1. In this case, we should rename children.1 to children.2 and the new child role name can be children.1. If we allow such usage, we should rename the other child role name when add/deleting a child. It means that we should query the role name again after add/deleting a child. Thanks Wen Congyang > > Max >

Re: [Qemu-devel] 'make check' failure on Fedora 23

2.6. After this commit, iasl's output is changed: https://github.com/acpica/acpica/commit/1ecbb3d551255dab943f3bbe7e9da0145d154bba Thanks Wen Congyang >

Re: [Qemu-devel] 'make check' failure on Fedora 23

ler Version 0x0001 (1) */ -DefinitionBlock ("t1.aml", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x0001) +DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) { Scope (\) { The newest iasl does't output the aml filename: "tl.aml" In the function normalize_asl(): we hope the output contains the aml filename... Thanks Wen Congyang

Re: [Qemu-devel] [PATCH] filter-buffer: fix segfault while start qemu with status=off property

>netdev); >>> } >> >> We'd better handle this at generic layer and don't let a specific net >> filter need to worry about this. >> >> Looks like the issue is we may trigger status_changed() too early (even >> before the the filter was initialized). >> > > Yes ~ > >> How about not call status_changed() if the initialization is not done? >> > > But seems that it is difficult to confirm if the filter is initialized > or not ... If nfc->setup() is not called, nf->netdev is NULL. Thanks Wen Congyang > >> . >> > > > > >

Re: [Qemu-devel] [PATCH] crypto: do an explicit check for nettle pbkdf functions

hen skipping > compilation of the nettle-pbkdf.o module > > Reported-by: Wen Congyang <we...@cn.fujitsu.com> > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> I build the qemu with this patch. It is OK now. Thanks Wen Congyang > --- > configure

Re: [Qemu-devel] [RFC for-2.7 1/1] block/qapi: Add query-block-node-tree

t char *child_name, const BdrvChildRole *child_role) { BdrvChild *child = bdrv_root_attach_child(child_bs, child_name, child_role); QLIST_INSERT_HEAD(_bs->children, child, next); return child; } We insert the ne

Re: [Qemu-devel] [RFC for-2.7 1/1] block/qapi: Add query-block-node-tree

;}} Shoule we hide the node name like "#blockxxx"? If the bs doesn't have any child, should we output: '"children": [], '? Can we add a new parameter: depth? For example, If I only want to know the quorum's child name, we can limit the depth, and th

Re: [Qemu-devel] [PATCH v16 0/8] Block replication for continuous checkpoints

avoid touch nbd and qcow2. > V3: > 1: use error_setg() instead of error_set() > 2. Add a new block job API > 3. Active disk, hidden disk and nbd target uses the same AioContext > 4. Add a testcase to test new hbitmap API > V2: > 1. Redesign the secondary qemu(use image-fleecing

[Qemu-devel] [PATCH] quorum: Implement bdrv_get_specific_info

The monitor command 'query-block' or 'info block' will output the format specific information. So we can get each child's child-name after this patch. This useful for dynamic reconfiguration. Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> --- block/quorum.c

Re: [Qemu-devel] [PULL v3 02/13] crypto: add support for PBKDF2 algorithm

+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, see > <http://www.gnu.org/licenses/>. > + * > + */ > + > +#include "qemu/osdep.h" > +#include "crypto/pbkdf.h" > +#include "nettle/pbkdf2.h" I get the following building error: CCcrypto/pbkdf.o CCcrypto/pbkdf-nettle.o CCcrypto/ivgen.o crypto/pbkdf-nettle.c:23:27: error: nettle/pbkdf2.h: No such file or directory crypto/pbkdf-nettle.c: In function ‘qcrypto_pbkdf2’: crypto/pbkdf-nettle.c:46: warning: implicit declaration of function ‘pbkdf2_hmac_sha1’ crypto/pbkdf-nettle.c:46: warning: nested extern declaration of ‘pbkdf2_hmac_sha1’ crypto/pbkdf-nettle.c:53: warning: implicit declaration of function ‘pbkdf2_hmac_sha256’ crypto/pbkdf-nettle.c:53: warning: nested extern declaration of ‘pbkdf2_hmac_sha256’ make: *** [crypto/pbkdf-nettle.o] Error 1 make: *** Waiting for unfinished jobs rpm -qf /usr/include/nettle/ libnettle-devel-2.4-8.1.2 The nettle version is very old.. The OS is SUSE 11 SP3. Thanks Wen Congyang

Re: [Qemu-devel] [PATCH v2 1/1] Introduce "xen-load-devices-state"

On 03/23/2016 04:56 PM, Dr. David Alan Gilbert wrote: > * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: >> On 03/22/2016 08:22 PM, Dr. David Alan Gilbert wrote: >>> * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: >>>> From: Wen Congyang <we...@cn.fujitsu.com

Re: [Qemu-devel] [PATCH V4 1/2] net/filter-mirror: implement filter-redirector

On 03/17/2016 02:10 PM, Jason Wang wrote: > > > On 03/16/2016 05:34 PM, Wen Congyang wrote: >> On 03/16/2016 04:18 PM, Jason Wang wrote: >>>> >>>> >>>> On 03/15/2016 06:03 PM, Zhang Chen wrote: >>>>>> Filter-redirector is

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 03/17/2016 05:10 PM, Alberto Garcia wrote: >>> On Thu 17 Mar 2016 02:22:40 AM CET, Wen Congyang <we...@cn.fujitsu.com> >>> wrote: >>>>>>

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

1.qcow2) > > children.0 (hd0.qcow2) is added again: > > s->children[0] <--> "children.1" (hd1.qcow2) > s->children[1] <--> "children.0" (hd0.qcow2) Yes, it is correct. > > Is this correct? Is this the indented behavior? Since you are reading > in FIFO mode, now hd1.qcow2 will always be read first, so if > children.1 was the secondary disk, it has just become the primary. Yes. Thanks Wen Congyang > > I also think that it would be great to have tests for this > functionality, but they can be added later. > > Thanks, > > Berto > > > . >

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 03/17/2016 05:10 PM, Alberto Garcia wrote: > On Thu 17 Mar 2016 02:22:40 AM CET, Wen Congyang <we...@cn.fujitsu.com> wrote: >>>>>> @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { >>>>>> bool rewrite_corrupted;/* true if the

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 03/17/2016 07:25 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 03/17/2016 06:07 PM, Alberto Garcia wrote: >>> On Thu 17 Mar 2016 10:56:09 AM CET, Wen Congyang wrote: >>>>> We should have the failure modes documented,

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

On 03/17/2016 06:07 PM, Alberto Garcia wrote: > On Thu 17 Mar 2016 10:56:09 AM CET, Wen Congyang wrote: >>> We should have the failure modes documented, and how you'll use it >>> after failover etc Without that it's really difficult to tell if this >>> naming is rig

[Qemu-devel] [PATCH] quorum: add child name into filename

The monitor command 'query-block' or 'info block' will output the filename. So we can get each children's child-name after this patch. This useful for dynamic reconfiguration. Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> --- block/quorum.c | 10 +++--- 1 file changed, 7 inse

Re: [Qemu-devel] [PATCH V4 1/2] net/filter-mirror: implement filter-redirector

t; +} >> +memcpy(s->buf + s->index, buf, l); >> +buf += l; >> +size -= l; >> +s->index += l; >> +if (s->index == 4) { >> +/* got length */ >> +

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

t index) > [...] > > Sorry if I missed a previous discussion, but why is this necessary? Hi, Alberto Garcia Do you have any comments about this patch or give a R-B? Thanks Wen Congyang > > Berto > > > . >

Re: [Qemu-devel] [PATCH V9 0/2] net/filter-mirror:add filter-mirror and unit test

devel/git/qemu/include/net/filter.h:12:0, > from net/filter-mirror.c:12: > /home/devel/git/qemu/include/qom/object.h:300:39: error: unknown type > name ‘Error’ >Error **errp); I think he doesn't use the newest commit. After the co

Re: [Qemu-devel] [PATCH] quorum: Fix crash in quorum_aio_cb()

, which results in a QEMU crash. If we use FIFO mode, we don't call quorum_report_bad() in quorum_aio_cb(). But it is OK to iniialize sacb->aiocb for it. > > Signed-off-by: Alberto Garcia <be...@igalia.com> > Reviewed-by: Max Reitz <mre...@redhat.com> Reviewed

Re: [Qemu-devel] [PATCH V8 1/2] net/filter-mirror:Add filter-mirror

,netdev=hn0,queue=tx/rx/all,outdev=mirror0 > > Signed-off-by: Zhang Chen <zhangchen.f...@cn.fujitsu.com> > Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> > Reviewed-by: Yang Hongyang <hongyang.y...@easystack.cn> > Reviewed-by: zhanghailiang <zhang.zhanghaili...

Re: [Qemu-devel] [PULL 00/14] Net patches

On 03/09/2016 12:26 PM, Li Zhijian wrote: > > > On 03/09/2016 09:36 AM, Wen Congyang wrote: >> On 03/08/2016 05:54 PM, Peter Maydell wrote: >>> On 8 March 2016 at 16:06, Zhang Chen <zhangchen.f...@cn.fujitsu.com> wrote: >>>> I found the reason for thi

Re: [Qemu-devel] [PULL 00/14] Net patches

ay and hoping it > is sufficient. Otherwise the test is likely to be unreliable > if run on a heavily loaded or slow machine. Yes, but there is no way to know when tcp_chr_accept() is called. Add a event to notify it? Thanks Wen Congyang > > thanks > -- PMM > > >

Re: [Qemu-devel] [PULL 00/14] Net patches

On 03/08/2016 05:06 PM, Zhang Chen wrote: > > > On 03/08/2016 03:56 PM, Jason Wang wrote: >> >> On 03/08/2016 03:50 PM, Wen Congyang wrote: >>> On 03/08/2016 03:33 PM, Jason Wang wrote: >>>> On 03/08/2016 12:51 PM, Peter Maydell wrote: >>

Re: [Qemu-devel] [PULL 00/14] Net patches

> (consistently, every time I run make check, on the same test). >> >> thanks >> -- PMM > > Sorry, it manages to pass on my machine before submitting the pull > request. But when I re-try this several times, it fails. > > This probably means we have bug in mirror implementation. Chen and > Congyang, please try to fix this bug and resubmit a new version of the > patch. > > Will drop mirror from this pull request and submit a V2. OK. what is the version of the kernel that you use? Thanks Wen Congyang > > Thanks > > > . >

Re: [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor QUORUM_REPORT_BAD

On 02/25/2016 12:59 AM, Eric Blake wrote: > On 02/24/2016 03:11 AM, Changlong Xie wrote: >> Introduce QuorumOpType, and make QUORUM_REPORT_BAD compatible >> with it. >> >> Cc: Dr. David Alan Gilbert <dgilb...@redhat.com> >> Cc: Wen Congyang <we...@cn.fujit

Re: [Qemu-devel] [PATCH v15 7/9] Introduce new APIs to do replication operation

On 02/19/2016 04:41 PM, Hailiang Zhang wrote: > Hi, > > On 2016/2/15 9:13, Wen Congyang wrote: >> On 02/15/2016 08:57 AM, Hailiang Zhang wrote: >>> On 2016/2/5 12:18, Changlong Xie wrote: >>>> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> >>&

Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

ore this patch, sometimes quorum returns error, and sometimes quorum returns 0. In such case, which is better? Always return 0 or always return error? In my opinion, we can always return 0 if we allow quorum returns 0 in case 2. > > Also, is this only supposed to be used in FIFO mode? Your pat

Re: [Qemu-devel] [PATCH v15 7/9] Introduce new APIs to do replication operation

On 02/15/2016 08:57 AM, Hailiang Zhang wrote: > On 2016/2/5 12:18, Changlong Xie wrote: >> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> >> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> >> Signed-off-by: Gonglei <arei.gong...@huawei.

Re: [Qemu-devel] [PATCH v13 00/10] Block replication for continuous checkpoints

On 02/04/2016 05:07 PM, Dr. David Alan Gilbert wrote: > * Changlong Xie (xiecl.f...@cn.fujitsu.com) wrote: >> On 02/01/2016 09:18 AM, Wen Congyang wrote: >>> On 01/29/2016 06:47 PM, Dr. David Alan Gilbert wrote: >>>> * Wen Congyang (we...@cn.fujitsu.com) wrote: &g

Re: [Qemu-devel] [PATCH v14 7/8] Implement new driver for block replication

On 02/03/2016 05:32 PM, Stefan Hajnoczi wrote: > On Wed, Feb 03, 2016 at 09:29:15AM +0800, Wen Congyang wrote: >> On 02/02/2016 10:34 PM, Stefan Hajnoczi wrote: >>> On Mon, Feb 01, 2016 at 09:13:36AM +0800, Wen Congyang wrote: >>>> On 01/29/2016 11:46 PM, Stefan Haj

Re: [Qemu-devel] [PATCH v14 7/8] Implement new driver for block replication

On 02/02/2016 10:34 PM, Stefan Hajnoczi wrote: > On Mon, Feb 01, 2016 at 09:13:36AM +0800, Wen Congyang wrote: >> On 01/29/2016 11:46 PM, Stefan Hajnoczi wrote: >>> On Fri, Jan 29, 2016 at 11:13:42AM +0800, Changlong Xie wrote: >>>> On 01/28/2016 11:15 PM, Stefan Haj

Re: [Qemu-devel] [PATCH v14 5/8] docs: block replication's description

On 02/03/2016 11:35 AM, Eric Blake wrote: > On 02/02/2016 08:18 PM, Changlong Xie wrote: >> On 02/02/2016 11:20 PM, Eric Blake wrote: >>> On 01/13/2016 02:18 AM, Changlong Xie wrote: >>>> From: Wen Congyang <we...@cn.fujitsu.com> >>>> >&g

Re: [Qemu-devel] [PATCH v14 7/8] Implement new driver for block replication

On 01/29/2016 11:46 PM, Stefan Hajnoczi wrote: > On Fri, Jan 29, 2016 at 11:13:42AM +0800, Changlong Xie wrote: >> On 01/28/2016 11:15 PM, Stefan Hajnoczi wrote: >>> On Thu, Jan 28, 2016 at 09:13:24AM +0800, Wen Congyang wrote: >>>> On 01/27/2016 10:46 PM, Stefan Haj

Re: [Qemu-devel] [PATCH v13 00/10] Block replication for continuous checkpoints

On 01/29/2016 06:47 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 01/29/2016 06:07 PM, Dr. David Alan Gilbert wrote: >>> * Wen Congyang (we...@cn.fujitsu.com) wrote: >>>> On 01/27/2016 07:03 PM, Dr. David Alan Gilbert wro

Re: [Qemu-devel] [PATCH v13 00/10] Block replication for continuous checkpoints

On 01/29/2016 06:07 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 01/27/2016 07:03 PM, Dr. David Alan Gilbert wrote: >>> Hi, >>> I've got a block error if I kill the secondary. >>> >>> Start both p

Re: [Qemu-devel] [PATCH v13 00/10] Block replication for continuous checkpoints

s_count > $2 = 0 > (gdb) p acb->is_read > $5 = false Sorry for the late reply. What it the value of acb->count? If secondary host is down, you should remove quorum's children.1. Otherwise, you will get I/O error event. Thanks Wen Congyang > > (qemu) info block > colo-disk0

Re: [Qemu-devel] [PATCH v14 7/8] Implement new driver for block replication

On 01/27/2016 10:46 PM, Stefan Hajnoczi wrote: > On Wed, Jan 13, 2016 at 05:18:31PM +0800, Changlong Xie wrote: >> From: Wen Congyang <we...@cn.fujitsu.com> >> >> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> >> Signed-off-by: zhanghailiang <zha

Re: [Qemu-devel] COLO: how to flip a secondary to a primary?

On 01/26/2016 02:59 AM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 01/23/2016 03:35 AM, Dr. David Alan Gilbert wrote: >>> Hi, >>> I've been looking at what's needed to add a new secondary after >>> a primary failed;

Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

so the user can guarantee that the >> destination has the same data before the shallow mirror. How do you do >> that in this case? > > I think in the colo case they're relying on doing a block migrate > to synchronise the remote disk prior to switching into colo mode. Yes, we can do a block migration to sync the disk. After the migration finished, we stop block migration before starting colo. Thanks Wen Congyang > > Dave > >> Berto > -- > Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK > > > . >

Re: [Qemu-devel] [PATCH v13 00/10] Block replication for continuous checkpoints

175 g_free(acb->qcrs); > (gdb) p acb->child_iter > $1 = 1 > (gdb) p i > $3 = 1 Thanks for your test. Can you give me the following information: 1. acb->ret's value 2. s->num_children I think it is quorum's bug, and acb->ret is < 0. Thanks Wen Congyang >

Re: [Qemu-devel] [PATCH v13 00/10] Block replication for continuous checkpoints

) at > /root/colo/jan-2016/qemu/block/io.c:2122 > . > > So I guess acb->child_iter is wrong, since we only have one child on that > quorum? > and we're trying to do a destroy on the second child. Can you try the following patch: >From 3f2c5ec288cd9a36afb392b4bba24029f3e934

Re: [Qemu-devel] COLO: how to flip a secondary to a primary?

No. I think we can improve 'info block' output. >f) I've not thought about the colo-proxy that much yet - I guess that > existing connections need to keep their sequence number offset but > new connections made by what is now the primary dont need to do anything > special. Hailiang or Zhijian can answer this question. Thanks Wen Congyang > > Dave > -- > Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK > > > . >

Re: [Qemu-devel] [PATCH v14 0/8] Block replication for continuous checkpoints

Stefan:ping Do you have time to review this series patchset? Thanks Wen Congyang At 2016/1/13 17:18, Changlong Xie wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You can get the detailed information about block replication

Re: [Qemu-devel] [PATCH RFC 3/7] net/filter: Skip the disabled filter when delivering packets

> > QTAILQ_FOREACH(nf, >filters, next) { > +/* Don't go through filter if it is off */ > +if (qemu_need_skip_netfilter(nf)) { > +continue; > +} > ret = qemu_netfilter_receive(nf, direction, sender, flags, iov, > iovcnt, sent_cb); > if (ret) { > qemu_netfilter_pass_to_next() shoule also be updated. Thanks Wen Congyang

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

On 01/22/2016 11:15 AM, Jason Wang wrote: > > > On 01/20/2016 06:30 PM, Wen Congyang wrote: >> On 01/20/2016 06:19 PM, Jason Wang wrote: >>>> >>>> >>>> On 01/20/2016 06:01 PM, Wen Congyang wrote: >>>>>> On 01/20/2016 02:54

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

On 01/22/2016 02:21 PM, Jason Wang wrote: > > > On 01/22/2016 01:56 PM, Wen Congyang wrote: >> On 01/22/2016 01:41 PM, Jason Wang wrote: >>>> >>>> >>>> On 01/22/2016 11:28 AM, Wen Congyang wrote: >>>>>> On 01/22/2016 11:1

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

On 01/22/2016 01:41 PM, Jason Wang wrote: > > > On 01/22/2016 11:28 AM, Wen Congyang wrote: >> On 01/22/2016 11:15 AM, Jason Wang wrote: >>> >>> On 01/20/2016 06:30 PM, Wen Congyang wrote: >>>> On 01/20/2016 06:19 PM, Jason Wang wrote: >>>

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

On 01/22/2016 01:33 PM, Jason Wang wrote: > > > On 01/20/2016 06:34 PM, Wen Congyang wrote: >> On 01/20/2016 06:03 PM, Jason Wang wrote: >>> >>> On 01/20/2016 05:49 PM, Wen Congyang wrote: >>>> On 01/20/2016 05:20 PM, Jason Wang wrote: >

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

On 01/22/2016 03:42 PM, Jason Wang wrote: > > > On 01/22/2016 02:47 PM, Wen Congyang wrote: >> On 01/22/2016 02:21 PM, Jason Wang wrote: >>> >>> On 01/22/2016 01:56 PM, Wen Congyang wrote: >>>> On 01/22/2016 01:41 PM, Jason Wang wrote: >>>

Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

ure that the data in a new Quorum > child is consistent with that of the rest of the array? Quorum can have more than one child when it starts. But we don't do the similar check. So I don't think we should do such check here. Thanks Wen Congyang > > Berto > > > . >

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

On 01/20/2016 05:20 PM, Jason Wang wrote: > > > On 01/20/2016 03:44 PM, Wen Congyang wrote: >>>> >>>> ... >>>> -chardev socket,id=comparer0,host=ip_primary,port=X,server,nowait >>>> -chardev socket,id=comparer1,host=ip_primary,po

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

failover scene（primary is down）, the TCP rewriter will keep >> servicing >> for the TCP connection which is established after the last checkpoint。 >> >> >> >> How about this plan? > > Sounds good. > > And there's indeed no need to differ

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

On 01/20/2016 06:03 PM, Jason Wang wrote: > > > On 01/20/2016 05:49 PM, Wen Congyang wrote: >> On 01/20/2016 05:20 PM, Jason Wang wrote: >>> >>> On 01/20/2016 03:44 PM, Wen Congyang wrote: >>>>>> ... >>>>>> -chardev socket,id=

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

On 01/20/2016 06:19 PM, Jason Wang wrote: > > > On 01/20/2016 06:01 PM, Wen Congyang wrote: >> On 01/20/2016 02:54 PM, Jason Wang wrote: >>> >>> On 01/20/2016 11:29 AM, Zhang Chen wrote: >>>>> Sure. >>>>> >>>>>

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

rver by reusing the socket > chardev. E.g: > > In primary node: Thanks for your suggestion. > > ... > -chardev socket,id=comparer0,host=ip_primary,port=X,server,nowait > -chardev socket,id=comparer1,host=ip_primary,port=Y,server,nowait > -chardev socket,id=mirrorer0,host=ip_primary,port=Z,server,nowait > -netdev tap,id=hn0 > -traffic-mirrorer netdev=hn0,id=t0,indev=comparer0,outdev=mirrorer0 > -colo-comparer primary_traffic=comparer0,secondary_traffic=comparer1 > ... > > packet comparer compares the packets from two chardev: comparer0 and > comparer1. > traffic-mirrorer mirror tx to secondary node through chardev mirrorer0, > and mirror rx to packet comparer through chardev comparer0. > > In secondary node: > > ... > -chardev socket,id=redirector0,host=ip_primary,port=Y > -chardev socket,id=redirector1,host=ip_primary,port=Z > -netdev tap,id=hn0 > -traffic-redirector netdev=hn0,id,r0,indev=redirector0,outdev=redirector1 > -colo-rewriter netdev=hn0,id=c0 > ... > > traffic-redirector redirect the rx traffic from primary node through > redirector0 and redirect the tx traffic to promary node through redirector1. > colo-rewriter rewrite seq number as a normal netfilter. What are traffic-mirrorer and colo-comparer, traffic-redirector, colo-rewriter? A netfilter driver? If not, how to get the packet from the netdev, and send back the packet to the netdev? Thanks Wen Congyang > > > >> >> >>> . >>> >> > > > > > . >

Re: [Qemu-devel] [PATCH v9 0/3] qapi: child add/delete support

get_device_or_node_name() instead of new function >bdrv_get_id_or_node_name() > 2. Update the error message > 3. Update the documents in block-core.json > > Wen Congyang (3): > Add new block driver interface to add/delete a BDS's child > quorum: implement bdrv_add_chi

Re: [Qemu-devel] [Patch v12 resend 08/10] Implement new driver for block replication

On 12/23/2015 05:47 PM, Stefan Hajnoczi wrote: > On Wed, Dec 02, 2015 at 01:37:25PM +0800, Wen Congyang wrote: >> +/* >> + * Only write to active disk if the sectors have >> + * already been allocated in active disk/hidden disk. >> + */ >> +

Re: [Qemu-devel] [Patch v12 resend 05/10] docs: block replication's description

On 12/23/2015 05:26 PM, Stefan Hajnoczi wrote: > On Wed, Dec 02, 2015 at 01:31:46PM +0800, Wen Congyang wrote: >> +== Failure Handling == >> +There are 6 internal errors when block replication is running: >> +1. I/O error on primary disk >> +2. Forwarding primary

Re: [Qemu-devel] [Patch v12 resend 00/10] Block replication for continuous checkpoints

On 12/23/2015 06:04 PM, Stefan Hajnoczi wrote: > On Thu, Dec 17, 2015 at 02:22:14PM +0800, Wen Congyang wrote: >> Stefan:Ping... >> >> What about this feature? I have worked for it about 1 year, but it is still >> in the >> way... > > The code still has

Re: [Qemu-devel] [PATCH COLO-Frame v12 25/38] qmp event: Add event notification for COLO error

interface. COLO is not a block job. If live migration is a background jon, COLO is also a backgroud job. > > Quick overview of the block job QMP interface: > > * Commands to create a job: block-commit, block-stream, drive-mirror, > drive-backup. > > * Get information on

Re: [Qemu-devel] [Patch v12 resend 00/10] Block replication for continuous checkpoints

Stefan:Ping... What about this feature? I have worked for it about 1 year, but it is still in the way... On 12/02/2015 01:31 PM, Wen Congyang wrote: > Block replication is a very important feature which is used for > continuous checkpoints(for example: COLO). > > You can get

Re: [Qemu-devel] [PATCH] rcu: optimize rcu_read_lock

le at it mark the wakeup as unlikely in rcu_read_unlock. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Wen Congyang <we...@cn.fujitsu.com> > --- > include/qemu/rcu.h | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH COLO-Frame v12 01/38] configure: Add parameter for configure to enable/disable COLO support

m> > Signed-off-by: Gonglei <arei.gong...@huawei.com> > Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > --- > v11: > - Turn COLO on in default (Eric's suggestion) > > Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> I think you

Re: [Qemu-devel] [PATCH v3 06/21] block: Exclude nested options only for children in append_open_options()

isting child nodes. I think we should have some way to get the child->name. For example, the monitor command 'info block' or 'query-block' display it. Thanks Wen Congyang > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block.c | 20 --

Re: [Qemu-devel] [PATCH COLO-Frame v11 08/39] migration: Rename the'file' member of MigrationState

ber of MigrationState You forgot to update migration/rdma.c. Thanks Wen Congyang > --- > include/migration/migration.h | 2 +- > migration/exec.c | 4 +-- > migration/fd.c| 4 +-- > migration/migration.c | 72 >

Re: [Qemu-devel] [Patch v8 0/3] qapi: child add/delete support

Kevin: ping On 11/27/2015 02:06 PM, Wen Congyang wrote: > If quorum's child is broken, we can use mirror job to replace it. > But sometimes, the user only need to remove the broken child, and > add it later when the problem is fixed. > > It is based on the Kevin's child nam

Re: [Qemu-devel] [PATCH COLO-Frame v11 34/39] net/filter-buffer: Add default filter-buffer for each netdev

> So it has no side effect for the netdev. No, filter-buffer doesn't support vhost, so if you add default filter-buffer for each netdev, you can't use vhost. Thanks Wen Congyang > > Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> > Cc: Jason Wang <jasow..

Re: [Qemu-devel] [PATCH COLO-Frame v11 34/39] net/filter-buffer: Add default filter-buffer for each netdev

On 12/03/2015 11:53 AM, Hailiang Zhang wrote: > On 2015/12/3 9:17, Wen Congyang wrote: >> On 11/24/2015 05:25 PM, zhanghailiang wrote: >>> We add each netdev a default filter-buffer, which will be used for COLO >>> or Micro-checkpoint to buffer VM's packets. The name of

Re: [Qemu-devel] [Patch v12 00/10] Block replication for continuous checkpoints

On 12/01/2015 06:40 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> Block replication is a very important feature which is used for >> continuous checkpoints(for example: COLO). >> >> You can get the detailed information about

Re: [Qemu-devel] [Patch v12 00/10] Block replication for continuous checkpoints

On 12/01/2015 07:58 PM, Hailiang Zhang wrote: > On 2015/12/1 18:40, Dr. David Alan Gilbert wrote: >> * Wen Congyang (we...@cn.fujitsu.com) wrote: >>> Block replication is a very important feature which is used for >>> continuous checkpoints(for example: COLO). >&

Re: [Qemu-devel] [Patch v12 00/10] Block replication for continuous checkpoints

On 12/02/2015 09:00 AM, Wen Congyang wrote: > On 12/01/2015 06:40 PM, Dr. David Alan Gilbert wrote: >> * Wen Congyang (we...@cn.fujitsu.com) wrote: >>> Block replication is a very important feature which is used for >>> continuous checkpoints(for example: COLO). >&

[Qemu-devel] [Patch v12 resend 05/10] docs: block replication's description

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- docs/block-replication.txt | 227 + 1 file changed, 227 insertio

[Qemu-devel] [Patch v12 resend 06/10] Add new block driver interfaces to control block replication

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Cc: Luiz Capitulino <lcapitul...@redhat.com> Cc: Michael Roth <mdr...@linux.vnet.ibm.com> Rev

[Qemu-devel] [Patch v12 resend 10/10] Add a new API to start/stop replication, do checkpoint to all BDSes

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- block.c | 83 +++ include/block/block.h | 4 +++ 2

[Qemu-devel] [Patch v12 resend 00/10] Block replication for continuous checkpoints

hbitmap API V2: 1. Redesign the secondary qemu(use image-fleecing) 2. Use Error objects to return error message 3. Address the comments from Max Reitz and Eric Blake Wen Congyang (10): unblock backup operations in backing file Store parent BDS in BdrvChild Backup: clear all bitmap when doing

[Qemu-devel] [Patch v12 resend 03/10] Backup: clear all bitmap when doing block checkpoint

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Reviewed-by: Jeff Cody <jc...@redhat.com> --- block/backup.c | 14 ++ block

[Qemu-devel] [Patch v12 resend 01/10] unblock backup operations in backing file

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- block.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block.c b/block.c index bfc2b

[Qemu-devel] [Patch v12 resend 08/10] Implement new driver for block replication

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- block/Makefile.objs | 1 + block/replication.c | 549 2

[Qemu-devel] [Patch v12 resend 09/10] support replication driver in blockdev-add

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Reviewed-by: Eric Blake <ebl...@redhat.com> --- qapi/block-core.json | 21 ++--- 1 file chan

[Qemu-devel] [Patch v12 resend 02/10] Store parent BDS in BdrvChild

We need to access the parent BDS to get the root BDS. Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- block.c | 1 + include/block/block_in

[Qemu-devel] [Patch v12 resend 07/10] quorum: implement block driver interfaces for block replication

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Reviewed-by: Alberto Garcia <be...@igalia.com> --- block/quorum.c | 78 +

[Qemu-devel] [Patch v12 resend 04/10] Allow creating backup jobs when opening BDS

When opening BDS, we need to create backup jobs for image-fleecing. Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Reviewed-by: Stefan Hajnoczi <stefa...

Re: [Qemu-devel] [RFC PATCH 1/9] Init colo-proxy object based on netfilter

queue=@var{all|rx|tx}] 1. queue *MUST* be all for the filter colo-proxy. 2. The option port should be removed 3. The option addr is socket address. The format can be host:port, or fd. > + > +colo-proxy Add more description here. Thanks Wen Congyang > + > @item -object > fi

Re: [Qemu-devel] [RFC PATCH 3/9] colo-proxy: add colo-proxy framework

On 11/27/2015 08:27 PM, Zhang Chen wrote: > From: zhangchen > > Colo-proxy is a plugin of qemu netfilter > like filter-buffer and dump > > Signed-off-by: zhangchen > --- > net/Makefile.objs | 1 + > net/colo-proxy.c | 139 >

[Qemu-devel] [Patch v12 05/10] docs: block replication's description

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- docs/block-replication.txt | 227 + 1 file changed, 227 insertio

[Qemu-devel] [Patch v12 06/10] Add new block driver interfaces to control block replication

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Cc: Luiz Capitulino <lcapitul...@redhat.com> Cc: Michael Roth <mdr...@linux.vnet.ibm.com> Rev

[Qemu-devel] [Patch v12 01/10] unblock backup operations in backing file

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> --- block.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block.c b/block.c index bfc2be8..eaf479a 100644 --- a/block.c +++ b/block.c @@ -1275,6 +1275,24 @@ void bdrv_set_backing_hd(BlockDriverSta

[Qemu-devel] [Patch v12 02/10] Store parent BDS in BdrvChild

We need to access the parent BDS to get the root BDS. Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> --- block.c | 1 + include/block/block_int.h | 1 + 2 files changed, 2 insertions(+) diff --git a/block.c b/block.c index eaf479a..0a0468f 100644 --- a/block.c

[Qemu-devel] [Patch v12 03/10] Backup: clear all bitmap when doing block checkpoint

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Reviewed-by: Jeff Cody <jc...@redhat.com> --- block/backup.c | 14 ++ block

[Qemu-devel] [Patch v8 3/3] qmp: add monitor command to add/remove a child

The new QMP command name is x-blockdev-change. It's just for adding/removing quorum's child now, and doesn't support all kinds of children, all kinds of operations, nor all block drivers. So it is experimental now. Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhangha

[Qemu-devel] [Patch v8 1/3] Add new block driver interface to add/delete a BDS's child

In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Reviewed-by: Eric Blake

[Qemu-devel] [Patch v8 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> --- block.c | 8 ++-- block/quorum.c| 124 +++

[Qemu-devel] [Patch v8 0/3] qapi: child add/delete support

. The driver NBD can support filename, path, host:port now. v2: 1. Use bdrv_get_device_or_node_name() instead of new function bdrv_get_id_or_node_name() 2. Update the error message 3. Update the documents in block-core.json Wen Congyang (3): Add new block driver interface to add/delete a BDS's

[Qemu-devel] [Patch v12 04/10] Allow creating backup jobs when opening BDS

When opening BDS, we need to create backup jobs for image-fleecing. Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> Signed-off-by: Gonglei <arei.gong...@huawei.com> Reviewed-by: Stefan Hajnoczi <stefa...

  1   2   3   4   5   6   7   8   9   10   >