Re: [Qemu-devel] [PATCH] Fedora images: use URLs from stable "archives.fedoraproject.org"

[Yash Mankad]

self.fetch_asset(kernel_url, asset_hash=kernel_hash)
>  
> @@ -271,8 +273,9 @@ class BootLinuxConsole(Test):
>  :avocado: tags=arch:arm
>  :avocado: tags=machine:virt
>  """
> -kernel_url = ('https://download.fedoraproject.org/pub/fedora/linux/'
> -  
> 'releases/29/Everything/armhfp/os/images/pxeboot/vmlinuz')
> +kernel_url = ('https://archives.fedoraproject.org/pub/archive/fedora'
> +  
> '/linux/releases/29/Everything/armhfp/os/images/pxeboot'
> +  '/vmlinuz')
>  kernel_hash = 'e9826d741b4fb04cadba8d4824d1ed3b7fb8b4d4'
>  kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)
>  
> @@ -318,8 +321,9 @@ class BootLinuxConsole(Test):
>  :avocado: tags=arch:s390x
>  :avocado: tags=machine:s390_ccw_virtio
>  """
> -kernel_url = 
> ('https://download.fedoraproject.org/pub/fedora-secondary/'
> -  'releases/29/Everything/s390x/os/images/kernel.img')
> +kernel_url = ('https://archives.fedoraproject.org/pub/archive'
> +  
> '/fedora-secondary/releases/29/Everything/s390x/os/images'
> +  '/kernel.img')
>  kernel_hash = 'e8e8439103ef8053418ef062644ffd46a7919313'
>  kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)
>  
> @@ -360,8 +364,9 @@ class BootLinuxConsole(Test):
>  :avocado: tags=arch:ppc64
>  :avocado: tags=machine:pseries
>  """
> -kernel_url = 
> ('https://download.fedoraproject.org/pub/fedora-secondary/'
> -  'releases/29/Everything/ppc64le/os/ppc/ppc64/vmlinuz')
> +kernel_url = ('https://archives.fedoraproject.org/pub/archive'
> +  '/fedora-secondary/releases/29/Everything/ppc64le/os'
> +  '/ppc/ppc64/vmlinuz')
>  kernel_hash = '3fe04abfc852b66653b8c3c897a59a689270bc77'
>  kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)
>  
> diff --git a/tests/acceptance/linux_initrd.py 
> b/tests/acceptance/linux_initrd.py
> index 23be5a63aa..c61d9826a4 100644
> --- a/tests/acceptance/linux_initrd.py
> +++ b/tests/acceptance/linux_initrd.py
> @@ -54,8 +54,9 @@ class LinuxInitrd(Test):
>  QEMU has supported up to 4 GiB initrd for recent kernel
>  Expect guest can reach 'Unpacking initramfs...'
>  """
> -kernel_url = ('https://mirrors.kernel.org/fedora/releases/28/'
> -  'Everything/x86_64/os/images/pxeboot/vmlinuz')
> +kernel_url = ('https://archives.fedoraproject.org/pub/archive/fedora'
> +  
> '/linux/releases/28/Everything/x86_64/os/images/pxeboot/'
> +  'vmlinuz')
>  kernel_hash = '238e083e114c48200f80d889f7e32eeb2793e02a'
>  kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)
>  max_size = 2 * (1024 ** 3) + 1
> diff --git a/tests/vm/fedora b/tests/vm/fedora
> index e8fa5bf0d2..7fec1479fb 100755
> --- a/tests/vm/fedora
> +++ b/tests/vm/fedora
> @@ -23,7 +23,7 @@ class FedoraVM(basevm.BaseVM):
>  name = "fedora"
>  arch = "x86_64"
>  
> -base = "http://dl.fedoraproject.org/pub/fedora/linux/releases/30/;
> +base = 
> "https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/30/;
>  link = base + "Server/x86_64/iso/Fedora-Server-netinst-x86_64-30-1.2.iso"
>  repo = base + "Server/x86_64/os/"
>  full = base + "Everything/x86_64/os/"

Thanks for the fix Cleber.

Reviewed-by: Yash Mankad 

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

[Yash Mankad]

On 8/16/19 1:42 PM, Eduardo Habkost wrote:
> On Fri, Aug 16, 2019 at 02:22:58PM +0200, Markus Armbruster wrote:
>> Erik Skultety  writes:
>>
>>> On Fri, Aug 16, 2019 at 08:10:20AM +0200, Markus Armbruster wrote:
 Eduardo Habkost  writes:

> We have this issue reported when using libvirt to hotplug CPUs:
> https://bugzilla.redhat.com/show_bug.cgi?id=1741451
>
> Basically, libvirt is not copying die-id from
> query-hotpluggable-cpus, but die-id is now mandatory.
 Uh-oh, "is now mandatory": making an optional property mandatory is an
 incompatible change.  When did we do that?  Commit hash, please.

 [...]

>>> I don't even see it as being optional ever - the property wasn't even
>>> recognized before commit 176d2cda0de introduced it as mandatory.
>> Compatibility break.
>>
>> Commit 176d2cda0de is in v4.1.0.  If I had learned about it a bit
>> earlier, I would've argued for a last minute fix or a revert.  Now we
>> have a regression in the release.
>>
>> Eduardo, I think this fix should go into v4.1.1.  Please add cc:
>> qemu-stable.
> I did it in v2.
>
>> How can we best avoid such compatibility breaks to slip in undetected?
>>
>> A static checker would be nice.  For vmstate, we have
>> scripts/vmstate-static-checker.py.  Not sure it's used.
> I don't think this specific bug would be detected with a static
> checker.  "die-id is mandatory" is not something that can be
> extracted by looking at QOM data structures.  The new rule was
> being enforced by the hotplug handler callbacks, and the hotplug
> handler call tree is a bit complex (too complex for my taste, but
> I digress).
>
> We could have detected this with a simple CPU hotplug automated
> test case, though.  Or with a very simple -device test case like
> the one I have submitted with this patch.
>
> This was detected by libvirt automated test cases.  It would be
> nice if this was run during the -rc stage and not only after the
> 4.1.0 release, though.
>
> I don't know details of the test job.  Danilo, Mirek, Yash: do
> you know how this bug was detected, and what we could do to run
> the same test jobs in upstream QEMU release candidates?

This bug was caught by our internal gating tests.

The libvirt gating tests for the virt module include the
following Avocado-VT test case:

libvirt_vcpu_plug_unplug.positive_test.vcpu_set.live.vm_operate.save

This job failed with the error that you can see in the description
of the BZ#1741451 [0].

If you think that this would have been caught by a simple hotplug
case, I'd recommend adding a test for hotplug to avocado_qemu.
Otherwise, if you want, I can look into adding this particular
libvirt test case to our QEMU CI efforts.

Thanks,
Yash

[0] https://bugzilla.redhat.com/show_bug.cgi?id=1741451#c0



>

Re: [Qemu-devel] [PATCH 5/5] docker: Add test-block

[Yash Mankad]

On 05/04/2017 11:23 PM, Fam Zheng wrote:

Signed-off-by: Fam Zheng 
---
  tests/docker/test-block | 21 +
  1 file changed, 21 insertions(+)
  create mode 100755 tests/docker/test-block

diff --git a/tests/docker/test-block b/tests/docker/test-block
new file mode 100755
index 000..20ef705
--- /dev/null
+++ b/tests/docker/test-block
@@ -0,0 +1,21 @@
+#!/bin/bash -e
+#
+# Run block test cases
+#
+# Copyright (c) 2017 Red Hat Inc.
+#
+# Authors:
+#  Fam Zheng 
+#
+# This work is licensed under the terms of the GNU GPL, version 2
+# or (at your option) any later version. See the COPYING file in
+# the top-level directory.
+
+. common.rc
+
+cd "$BUILD_DIR"
+
+build_qemu --target-list=x86_64-softmmu
+cd tests/qemu-iotests
+./check -raw
+./check -qcow2


Could you also consider running -nbd tests ?

Yash