[Qemu-devel] [PATCH v2] target/ppc: simplify bcdadd/sub functions

2018-07-30 Thread Yasmin Beatriz
After solving a corner case in bcdsub, this patch simplifies the logic of both bcdadd/sub instructions by removing some unnecessary local flags. This commit also rearranges some if-else conditions in bcdadd to make it easier to read. Signed-off-by: Yasmin Beatriz --- target/ppc/int_helper.c

Re: [Qemu-devel] [PATCH] target/ppc: simplify bcdadd/sub functions

2018-07-26 Thread Yasmin Beatriz
On Thu, Jul 26, 2018 at 11:40:20AM +1000, David Gibson wrote: > On Tue, Jul 24, 2018 at 12:13:04PM +0000, Yasmin Beatriz wrote: > > After solving a corner case in bcdsub, this patch simplifies the logic > > of both bcdadd/sub instructions by removing some unnecessary local flags.

[Qemu-devel] [PATCH] target/ppc: simplify bcdadd/sub functions

2018-07-24 Thread Yasmin Beatriz
After solving a corner case in bcdsub, this patch simplifies the logic of both bcdadd/sub instructions by removing some unnecessary local flags. Signed-off-by: Yasmin Beatriz --- target/ppc/int_helper.c | 33 + 1 file changed, 9 insertions(+), 24 deletions

Re: [Qemu-devel] [PATCH] target/ppc: bcdsub fix sign when result is zero

2018-07-18 Thread Yasmin Beatriz
On Wed, Jul 18, 2018 at 12:22:02PM +1000, David Gibson wrote: > On Mon, Jul 16, 2018 at 07:03:12PM +0000, Yasmin Beatriz wrote: > > When the result of bcdsub is equal to zero, the result sign may be > > set to negative in some cases, and this does not follow the Power ISA >

[Qemu-devel] [PATCH] target/ppc: bcdsub fix sign when result is zero

2018-07-16 Thread Yasmin Beatriz
When the result of bcdsub is equal to zero, the result sign may be set to negative in some cases, and this does not follow the Power ISA specifications as to decimal integer arithmetic instructions. Signed-off-by: Yasmin Beatriz --- target/ppc/int_helper.c | 3 +++ 1 file changed, 3 insertions

[Qemu-devel] [PATCH v2] dump: Show custom message for ENOSPC

2018-02-09 Thread Yasmin Beatriz
This patch intends to make a more specific message for when the system has not enough space to save guest memory. Reported-by: yilzh...@redhat.com Cc: Jose Ricardo Ziviani <jos...@linux.vnet.ibm.com> Signed-off-by: Yasmin Beatriz <yasm...@linux.vnet.ibm.com> --- dump.c | 8

[Qemu-devel] [PATCH] dump: Show custom message for ENOSPC

2018-02-09 Thread Yasmin Beatriz
This patch intends to make a more specific message for when the system has not enough space to save guest memory. Reported-by: yilzh...@redhat.com Cc: Jose Ricardo Ziviani <jos...@linux.vnet.ibm.com> Signed-off-by: Yasmin Beatriz <yasm...@linux.vnet.ibm.com> --- dump.c | 9 +