Re: How to enable virgl in headless mode?

2021-12-01 Thread Yonggang Luo
e need of rendernode, because I wanna getting egl-headless to be usable on Windows. > > take care, > Gerd > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

How to enable virgl in headless mode?

2021-11-23 Thread Yonggang Luo
22,id=net0 ``` -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: ppc/fpu_helper.c

2021-11-14 Thread Yonggang Luo
On Sun, Nov 14, 2021 at 5:07 PM Richard Henderson < richard.hender...@linaro.org> wrote: > > On 11/13/21 11:07 AM, 罗勇刚(Yonggang Luo) wrote: > > I've seen nothing in fpu_helper.c to update > > the fpscr to FP_FR, > > that is there is no code with `fpscr |= FP_FR`,

ppc/fpu_helper.c

2021-11-13 Thread Yonggang Luo
I've seen nothing in fpu_helper.c to update the fpscr to FP_FR, that is there is no code with `fpscr |= FP_FR`, is that valid for PowerPC? or it's just because this is hard to implement and then the FP_FR are always not set for fpscr -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Idea about float acceleration with tcg

2021-11-13 Thread Yonggang Luo
sor read mxcsr register is slow on AMD x64 processor read/write mxcsr register is about 4x slow on AMD processor and 8x slow on Intel processor, we can take advantage of these when accleration target float instructions. -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH 1/2] target/ppc: Fixed call to deferred exception

2021-11-11 Thread Yonggang Luo
elper that would update FPSCR and throw the > > correct exception based on fp_status, this one I don't see how it would > > feasible in the current implementation as FPSCR has many bits without an > > equivalent in fp_status. > > > > So with this I can see how to implement the 1st and 2nd option, I chose not > > to use the 1st one as do_float_check_status updates the FPSCR then throw the > > exception, which seemed unnecessary. Also looking back I should've removed > > gen_reset_fpstatus() as in the way it ended implemented these instructions > > don't interact with fp_status anywhere else, so I'll remove it in the next > > version. > > > > And looking at the suggestions the current implementation could be changed to > > take advantage of the optimization suggested in the discussion you linked, > > specially the parts about checking when exception bits aren't set (but in > > this case it would've to be the MSR exception bits) and the part about > > skipping calculating a flag when marked to 1. > > I haven't followed the discussion but here's another message with some > links I've collected when FPU came up that may be relevant to the topic: > > https://lists.nongnu.org/archive/html/qemu-ppc/2020-04/msg00387.html > > among those is a long thread on patchwork that has some info on the > current situation. As far as I remember the oddity in handling FPU > exceptions is partly because of two bits FI and FR in FPSCR that should That's correct, the most hard part is to simulate FI and FR bits in FPSCR as that was not provided on other CPU. > reflect the result of the previous FPU op so has to be updated after every > op which makes it hard to emulate as other CPUs usually don't do this. (We > could easily improve it if we did not emulate those bits, most guest code > don't use them anyway, but QEMU prefers accuracy so that way was ruled > out.) Other than that the current code maybe also can be simplified and > maybe optimised via some other ways which were discussed in those threads > but nobody implemented any of the ideas so far. May worth reading through > what was said before as there might be sume useful ideas in there. > > Regards, > BALATON Zoltan -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-07-29 Thread Yonggang Luo
> >> +++ b/subprojects/libvhost-user/standard-headers/linux > > >> @@ -0,0 +1 @@ > > >> +../../../include/standard-headers/linux > > >> \ No newline at end of file > > > > > > > > > Should these really be missing the trailing newline ? > > > > It's a symlink, so yes, there does not need to be a newline in here. > > Interesting. How does it work on Windows hosts ? > > -- PMM > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PULL 09/12] configure, meson: convert libusb detection to meson

2021-06-24 Thread Yonggang Luo
onfig_host.has_key('CONFIG_USB_REDIR')} > summary_info += {'OpenGL support': config_host.has_key('CONFIG_OPENGL')} > summary_info += {'GBM': config_host.has_key('CONFIG_GBM')} > diff --git a/meson_options.txt b/meson_options.txt > index ac6e90da07..02c14d4751 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -86,6 +86,8 @@ option('gcrypt', type : 'feature', value : 'auto', > description: 'libgcrypt cryptography support') > option('libudev', type : 'feature', value : 'auto', > description: 'Use libudev to enumerate host devices') > +option('libusb', type : 'feature', value : 'auto', > + description: 'libusb support for USB passthrough') > option('lzfse', type : 'feature', value : 'auto', > description: 'lzfse support for DMG images') > option('lzo', type : 'feature', value : 'auto', > -- > 2.31.1 > > > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v2 29/30] cirrus.yml: Fix the MSYS2 task

2021-05-11 Thread Yonggang Luo
Reviewed-by: Yonggang Luo On Tue, May 4, 2021 at 6:09 PM Alex Bennée wrote: > > From: Thomas Huth > > The MSYS2 task in the Cirrus-CI is currently failing with error messages > like this: > > warning: database file for 'ucrt64' does not exist (use '-Sy' to download) >

Re: [PATCH v2 29/30] cirrus.yml: Fix the MSYS2 task

2021-05-11 Thread Yonggang Luo
LGTM, Thanks, forget to update this On Wed, May 12, 2021 at 12:49 PM Philippe Mathieu-Daudé wrote: > Hi Yonggang Luo, > > Does this look OK to you? > > On 5/4/21 12:02 PM, Alex Bennée wrote: > > From: Thomas Huth > > > > The MSYS2 task in the Cirrus-CI is curr

[PATCH 1/2] plugins: Update qemu-plugins.symbols to match qemu-plugins.h

2021-03-18 Thread Yonggang Luo
Reorder the function symbols that consistence with qemu-plugins.h Signed-off-by: Yonggang Luo --- plugins/qemu-plugins.symbols | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/plugins/qemu-plugins.symbols b/plugins/qemu-plugins.symbols index

[PATCH 2/2] plugins: Move all typedef and type declaration to the front of the qemu-plugin.h

2021-03-18 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- include/qemu/qemu-plugin.h | 187 ++--- 1 file changed, 92 insertions(+), 95 deletions(-) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index 97cdfd7761..2cb17f3051 100644 --- a/include/qemu/qemu-plugin.h

[PATCH 0/2] Fix qemu-plugins.symbols and improve qemu-plugins.h

2021-03-18 Thread Yonggang Luo
Yonggang Luo (2): plugins: Update qemu-plugins.symbols to match qemu-plugins.h plugins: Move all typedef and type declaration to the front of the qemu-plugin.h include/qemu/qemu-plugin.h | 187 +-- plugins/qemu-plugins.symbols | 25 +++-- 2 files

Re: [PATCH 0/2] *** This is based on pull request from Alex Bennée ***

2021-03-18 Thread Yonggang Luo
85924.32756-1-arm...@redhat.com> > > where the thing in is the pull request's Message-id. > > Note: I used one of my pull requests, not Alex's, for this example. > > Yonggang Luo writes: > > > *** BLURB HERE *** > > Recommend to delete this placeholder next ti

[PATCH 1/2] plugins: Update qemu-plugins.symbols to match qemu-plugins.h

2021-03-17 Thread Yonggang Luo
Reorder the function symbols that consistence with qemu-plugins.h Signed-off-by: Yonggang Luo --- plugins/qemu-plugins.symbols | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/plugins/qemu-plugins.symbols b/plugins/qemu-plugins.symbols index

[PATCH 0/2] *** This is based on pull request from Alex Bennée ***

2021-03-17 Thread Yonggang Luo
*** BLURB HERE *** The pull request https://patchew.org/QEMU/20210317072216.16316-1-alex.ben...@linaro.org/ Yonggang Luo (2): plugins: Update qemu-plugins.symbols to match qemu-plugins.h plugins: Move all typedef and type declaration to the front of the qemu-plugin.h include/qemu/qemu

[PATCH 2/2] plugins: Move all typedef and type declaration to the front of the qemu-plugin.h

2021-03-17 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- include/qemu/qemu-plugin.h | 187 ++--- 1 file changed, 92 insertions(+), 95 deletions(-) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index 97cdfd7761..2cb17f3051 100644 --- a/include/qemu/qemu-plugin.h

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-02-01 Thread Yonggang Luo
SHA-1: 94c13c1048378cbffe552b6fe5c960dc04eaefb2 * gcrypt: test_tls_psk_init should write binary file instead text file. On windows, if open file with "w", it's will automatically convert "\n" to "\r\n" when writing to file. Signed-off-by: Yonggang Luo Is this

Re: [PATCH v3 0/6] Enable plugin support on msys2/mingw

2021-01-26 Thread Yonggang Luo
Hi alex, when does plugins/next getting PR On Tue, Oct 6, 2020 at 7:35 PM Alex Bennée wrote: > > Yonggang Luo writes: > > > V2-V3 > > Split following patches out > > > > V1-V2 > > 1. Fixes review comments > > 2. Increase QEMU_PLUGIN_VERSION to 1 fo

Re: [PATCH 8/8] configure: automatically parse command line for meson -D options

2021-01-22 Thread Yonggang Luo
On Sat, Jan 23, 2021 at 4:44 AM Paolo Bonzini wrote: > > > > Il ven 22 gen 2021, 09:00 罗勇刚(Yonggang Luo) ha scritto: >> >> Hi Paolo, as python and meson are required dependencies to building qemu now, >> can we detecting python/meson at the very begining of config

Re: [PATCH 8/8] configure: automatically parse command line for meson -D options

2021-01-22 Thread Yonggang Luo
code that must be maintained manually and the > former is not". > > Paolo > > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: What's the correct way to implement rfi and related instruction.

2021-01-13 Thread Yonggang Luo
On Tue, Jan 12, 2021 at 1:23 AM Cédric Le Goater wrote: > > > QEMU 5.2.x, an e300 based machine ppc603 are impacted. > > Here is my fix, narrowed down to MSR_TGPR and MSR_ILE > > ``` > > From 42ce41671f1e6c4dd44e6fb481bbda9df09320bd Mon Sep 17 00:00:00

Re: What's the correct way to implement rfi and related instruction.

2021-01-12 Thread Yonggang Luo
On Tue, Jan 12, 2021 at 5:23 PM Cédric Le Goater wrote: > > > QEMU 5.2.x, an e300 based machine ppc603 are impacted. > > Here is my fix, narrowed down to MSR_TGPR and MSR_ILE > > ``` > > From 42ce41671f1e6c4dd44e6fb481bbda9df09320bd Mon Sep 17 00:00:00

Re: [PATCH] cirrus.yml: Replace the hard-coded python-sphinx version with the generic one

2021-01-11 Thread Yonggang Luo
ash.exe -lc "rm -rf /var/cache/pacman/pkg/*" > cd C:\tools\msys64 > echo "Start archive" > -- > 2.27.0 > Hi, I've done that in my previous patch and queued by Paolo Bonzini 4 days, 8 hours ago https://patchew.org/QEMU/20210107101919.80-1-luoyongg...@gmail.com/ -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v16 00/20] Initial support for multi-process Qemu

2021-01-11 Thread Yonggang Luo
On Tue, Jan 12, 2021 at 2:02 AM Jag Raman wrote: > > > > > On Jan 11, 2021, at 12:20 AM, 罗勇刚(Yonggang Luo) wrote: > > > > I have a question, does this support/test on Windows? > > Hi Yonggang, we have not tested this on Windows. The project only builds on Li

Re: [PATCH v16 00/20] Initial support for multi-process Qemu

2021-01-10 Thread Yonggang Luo
mode 100644 hw/pci-host/remote.c > create mode 100644 hw/remote/iohub.c > create mode 100644 hw/remote/machine.c > create mode 100644 hw/remote/memory.c > create mode 100644 hw/remote/message.c > create mode 100644 hw/remote/mpqemu-link.c > create mode 100644 hw/remote/proxy-memory-listener.c > create mode 100644 hw/remote/proxy.c > create mode 100644 hw/remote/remote-obj.c > create mode 100644 hw/remote/Kconfig > create mode 100644 hw/remote/meson.build > create mode 100644 hw/remote/trace-events > > -- > 1.8.3.1 > > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH] util/oslib-win32: Fix _aligned_malloc() arguments order

2021-01-10 Thread Yonggang Luo
=test#L593 > > Fixes: dfbd0b873a8 ("util/oslib-win32: Use _aligned_malloc for qemu_try_memalign") > Reported-by: Yonggang Luo > Reported-by: Volker Rümelin > Suggested-by: Volker Rümelin > Signed-off-by: Philippe Mathieu-Daudé > --- > util/oslib-win32.c | 2

[PATCH] util/oslib-win32: Fixes Use _aligned_malloc for qemu_try_memalign

2021-01-10 Thread Yonggang Luo
In commit dfbd0b873a85021c083d9b4b84630c3732645963, the use of _aligned_malloc are called with wrong parameter order, fixed it. Signed-off-by: Yonggang Luo --- util/oslib-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/oslib-win32.c b/util/oslib-win32.c index

Re: [PULL 04/47] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign

2021-01-10 Thread Yonggang Luo
is failure? https://cirrus-ci.com/task/6055645751279616?command=test#L593 MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} G_TEST_SRCDIR=C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/tests G_TEST_BUILDDIR=C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/build/tests tests/test-qht.exe --tap -k ERROR test-qht - too few tests run (expected 2, got 0) make: *** [Makefile.mtest:256: run-test-30] Error 1 -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PULL 00/23] target-arm queue

2021-01-10 Thread Yonggang Luo
Data/Local/Temp/cirrus-ci-build/tests G_TEST_BUILDDIR=C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/build/tests tests/test-qht.exe --tap -k ERROR test-qht - too few tests run (expected 2, got 0) make: *** [Makefile.mtest:256: run-test-30] Error 1 -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: What's the correct way to implement rfi and related instruction.

2021-01-10 Thread Yonggang Luo
On Fri, Jan 8, 2021 at 2:02 AM Cédric Le Goater wrote: > > On 1/8/21 5:21 AM, 罗勇刚(Yonggang Luo) wrote: > > > > > > On Fri, Jan 8, 2021 at 5:54 AM Cédric Le Goater > wrote: > >> > >> On 1/7/21 8:14 PM, 罗勇刚(Yonggang Luo) wrote: > >> > This i

Re: [PATCH v2] decodetree: Open files with encoding='utf-8'

2021-01-08 Thread Yonggang Luo
nal. I suggest to use sys.stdout = io.TextIOWrapper(sys.stdout.buffer, encoding=sys.stdout.encoding, errors="ignore") When the console/terminal encoding still can not represent the char in the decodetree, still won't cause script failure. And that failure can not be fixed by other means. errors="ignore" are important, from my experince, even there is `char` can not represent in utf8 > > (Based on a suggestion from Yonggang Luo) > > -- > Eduardo > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH] decodetree: Open files with encoding='utf-8'

2021-01-08 Thread Yonggang Luo
, 'r') > > +f = open(filename, 'r', encoding='utf-8') > > parse_file(f, toppat) > > f.close() > > Should we also be opening the output file explicitly as > utf-8 ? (How do we say "write to sys.stdout as utf-8" for > the case where we're doing that?) Can be done with ``` sys.stdout = io.TextIOWrapper(sys.stdout.buffer, encoding="utf8", errors="ignore") ``` > > thanks > -- PMM > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH] decodetree: Open files with encoding='utf-8'

2021-01-08 Thread Yonggang Luo
input_file = filename > -f = open(filename, 'r') > +f = open(filename, 'r', encoding='utf-8') > parse_file(f, toppat) > f.close() > > -- > 2.26.2 > > Reviewed-by: Yonggang Luo uoyongg...@gmail.com > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PULL 00/66] MIPS patches for 2021-01-07

2021-01-08 Thread Yonggang Luo
, in parse_file >> for line in f: >> File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode >> return codecs.ascii_decode(input, self.errors)[0] >> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position >> 93: ordinal not in range(128) >> >> etc. >> >> Looks like decodetree fails to cope with non-ASCII characters in >> its input file -- probably this depends on the host locale settings: >> I think these hosts run in the 'C' locale. > > > Can you provide more information on your host so we can cover it in Gitlab-CI? > > Thanks, > > Phil. -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: What's the correct way to implement rfi and related instruction.

2021-01-07 Thread Yonggang Luo
On Fri, Jan 8, 2021 at 5:54 AM Cédric Le Goater wrote: > > On 1/7/21 8:14 PM, 罗勇刚(Yonggang Luo) wrote: > > This is the first patch,: > > It's store MSR bits differntly for different rfi instructions: > > [Qemu-devel] [PATCH] target-ppc: fix RFI by clearing so

What's the correct way to implement rfi and related instruction.

2021-01-07 Thread Yonggang Luo
nv->lr, env->ctr & 0x); } /* Embedded.Processor Control */ ``` And of cause, the second patch fixes some problem, but also cause new problem, how to implement these instruction properly? -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v4 5/5] whpx: move whpx_lapic_state from header to c file

2021-01-07 Thread Yonggang Luo
On Thu, Jan 7, 2021 at 2:55 AM Paolo Bonzini wrote: > > On 07/01/21 11:28, Marc-André Lureau wrote: > > Hi > > > > On Thu, Jan 7, 2021 at 2:26 PM Yonggang Luo > <mailto:luoyongg...@gmail.com>> wrote: > > > > This struct only used in whpx-apic

[PATCH v4 5/5] whpx: move whpx_lapic_state from header to c file

2021-01-07 Thread Yonggang Luo
This struct only used in whpx-apic.c, there is no need expose it in whpx.h. Signed-off-by: Yonggang Luo --- include/sysemu/whpx.h| 7 --- target/i386/whpx/whpx-apic.c | 7 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/sysemu/whpx.h b/include/sysemu

[PATCH v4 4/5] whpx: Fixes include of whp-dispatch.h in whpx.h

2021-01-07 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- include/sysemu/whpx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sysemu/whpx.h b/include/sysemu/whpx.h index 9346fd92e9..4f38784d7e 100644 --- a/include/sysemu/whpx.h +++ b/include/sysemu/whpx.h @@ -15,7 +15,7 @@ #ifdef

[PATCH v4 1/5] cirrus/msys2: Exit powershell with $LastExitCode

2021-01-07 Thread Yonggang Luo
Currently if we don't exit with $LastExitCode manually, the cirrus would not report the build/testing failure. Signed-off-by: Yonggang Luo --- .cirrus.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.cirrus.yml b/.cirrus.yml index 3907e036da..68b8a8fa9c 100644 --- a/.cirrus.yml +++ b

[PATCH v4 3/5] maintainers: Add me as Windows Hosted Continuous Integration maintainer

2021-01-07 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4be087b88e..4d9df874a1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3198,6 +3198,12 @@ S: Maintained F: .cirrus.yml W: https://cirrus-ci.com/github/qemu/qemu

[PATCH v4 2/5] cirrus/msys2: Cache msys2 mingw in a better way.

2021-01-07 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- .cirrus.yml | 117 ++-- 1 file changed, 68 insertions(+), 49 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index 68b8a8fa9c..bc40a0550d 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -64,23 +64,61

[PATCH v4 0/5] Misc meson fixes along test-vmstate fixes

2021-01-07 Thread Yonggang Luo
V1-V2 Fixes whpx: Fixes include of whp-dispatch.h in whpx.h by the suggestion of Philippe Mathieu-Daudé Add new patch whpx: move whpx_lapic_state from header to c file The test-vmstate can be passed under win32 too so enable it on win32, This is based on Bonzini's upstream tag along Yonggang

[PATCH 4/4] maintainers: Add me as Windows Hosted Continuous Integration maintainer

2021-01-06 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4be087b88e..4d9df874a1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3198,6 +3198,12 @@ S: Maintained F: .cirrus.yml W: https://cirrus-ci.com/github/qemu/qemu

[PATCH 2/4] cirrus/msys2: Cache msys2 mingw in a better way.

2021-01-06 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- .cirrus.yml | 117 ++-- 1 file changed, 68 insertions(+), 49 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index ff6adabd0d..6f2a958472 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -58,23 +58,61

[PATCH 3/4] whpx: Fixes include of whp-dispatch.h in whpx.h

2021-01-06 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- include/sysemu/whpx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sysemu/whpx.h b/include/sysemu/whpx.h index 9346fd92e9..0e6c9faaf6 100644 --- a/include/sysemu/whpx.h +++ b/include/sysemu/whpx.h @@ -15,7 +15,7 @@ #ifdef

[PATCH 1/4] cirrus/msys2: Exit powershell with $LastExitCode

2021-01-06 Thread Yonggang Luo
Currently if we don't exit with $LastExitCode manually, the cirrus would not report the build/testing failure. Signed-off-by: Yonggang Luo --- .cirrus.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.cirrus.yml b/.cirrus.yml index 62a9b57530..ff6adabd0d 100644 --- a/.cirrus.yml +++ b

[PATCH 0/4] Fixes whpx build and improve Windows host CI

2021-01-06 Thread Yonggang Luo
Exit powershell with $LastExitCode so that the CI would report the build/testing failure Fixes include of whp-dispatch.h Cache msys2 mingw with a proper fingerprint so that only when msys2 packages are changed need trigger the re-populate the cache Yonggang Luo (4): cirrus/msys2: Exit

Re: [PATCH v2] meson: fix ncurses detection on macOS

2020-12-31 Thread Yonggang Luo
dtler > Cc: Peter Maydell > Cc: Philippe Mathieu-Daudé > Cc: Samuel Thibault > Cc: Yonggang Luo > --- > meson.build | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meson.build b/meson.build > index 372576f82c..fd74728674 10064

Re: [PATCH] meson: fix ncurses detection on macOS

2020-12-28 Thread Yonggang Luo
urses package not usable' curses = not_found endif endif if not curses.found() -curses_compile_args = ['-DNCURSES_WIDECHAR'] has_curses_h = cc.has_header('curses.h', args: curses_compile_args) if targetos != 'windows' and not has_curses_h message('Trying with /usr/include/ncursesw') -- 2.29.2.windows.3 -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH 11/19] target/mips: Extract common helpers from helper.c to common_helper.c

2020-12-14 Thread Yonggang Luo
> > r~ > Does these are general cpu bits or misp_cpu bits? if only misp cpu related, prefer misp_cpu.c or cpu.c under misp folder. -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds

2020-12-13 Thread Yonggang Luo
gt; > > > > Reviewed-by: Thomas Huth > > > > ... we could maybe also split the --target-list between the two jobs if they > > take too long... > > Maybe it's time, 90min reached: > https://cirrus-ci.com/task/5774549872541696 > Even two hour doesn't working, don't know why -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

[PATCH] meson: Fixes curses detection on msys2

2020-11-16 Thread Yonggang Luo
Fixes regression on curses detection in msys2 by commit#925a40df2828d32d3aaaf022282cba81082fb263 Signed-off-by: Yonggang Luo --- meson.build | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index bbff0880f4..8695f7d1c2 100644

Re: [PATCH 3/4] configure: Add a proper check for sys/ioccom.h and use it in tpm_ioctl.h

2020-11-14 Thread Yonggang Luo
nbd/nbd-internal.h b/nbd/nbd-internal.h > index 60629ef160..1b2141ab4b 100644 > --- a/nbd/nbd-internal.h > +++ b/nbd/nbd-internal.h > @@ -19,7 +19,7 @@ > #ifndef _WIN32 > #include > #endif > -#if defined(__sun__) || defined(__HAIKU__) > +#ifdef HAVE_SYS_IOCCOM_H > #include > #endif > > -- > 2.18.4 > > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

[PATCH v4 0/2] Fixes building nfs on msys2/mingw

2020-11-05 Thread Yonggang Luo
V3-V4 Use uint64_t instead of blkcnt_t V2-V3 Revise the commit message of * block: enable libnfs on msys2/mingw in cirrus.yml V1-V2 Apply suggestion from Peter Lieven Yonggang Luo (2): block: Fixes nfs compiling error on msys2/mingw block: enable libnfs on msys2/mingw in cirrus.yml

Re: [PATCH v2 2/2] block: enable libnfs on msys2/mingw in cirrus.yml

2020-11-05 Thread Yonggang Luo
On Thu, Nov 5, 2020 at 7:43 PM Max Reitz wrote: > > On 13.10.20 02:15, Yonggang Luo wrote: > > At the begging libnfs are not enabled because of compiling error, > > now it's fixed so enable it > > > > Signed-off-by: Yonggang Luo > > --- > > .cirrus.y

Re: [PATCH v2 1/2] block: Fixes nfs compiling error on msys2/mingw

2020-11-05 Thread Yonggang Luo
Updated with fixes. On Thu, Nov 5, 2020 at 8:11 PM Max Reitz wrote: > > On 05.11.20 12:46, 罗勇刚(Yonggang Luo) wrote: > > > > > > On Thu, Nov 5, 2020 at 7:44 PM Max Reitz > <mailto:mre...@redhat.com>> wrote: > > > >

[PATCH v4 1/2] block: Fixes nfs compiling error on msys2/mingw

2020-11-05 Thread Yonggang Luo
tat64 yet, we disable the usage of it on msys2/mingw, and create a typedef long long blkcnt_t; for further implementation Signed-off-by: Yonggang Luo --- block/nfs.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/block/nfs.c b/block/nfs.c index f86e660374..7

[PATCH v4 2/2] block: enable libnfs on msys2/mingw in cirrus.yml

2020-11-05 Thread Yonggang Luo
Initially, libnfs has not been enabled, and now it's fixed, so enable it on cirrus. Signed-off-by: Yonggang Luo --- .cirrus.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.cirrus.yml b/.cirrus.yml index 900437dd2a..f0209b7a3e 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -109,6 +109,7

Re: [PATCH v2 1/2] block: Fixes nfs compiling error on msys2/mingw

2020-11-05 Thread Yonggang Luo
On Thu, Nov 5, 2020 at 7:44 PM Max Reitz wrote: > > On 05.11.20 12:32, 罗勇刚(Yonggang Luo) wrote: > > > > > > On Thu, Nov 5, 2020 at 7:29 PM Max Reitz > <mailto:mre...@redhat.com>> wrote: > > > > > > On 13.10.20 02:15, Yonggan

Re: [PATCH v2 1/2] block: Fixes nfs compiling error on msys2/mingw

2020-11-05 Thread Yonggang Luo
On Thu, Nov 5, 2020 at 7:29 PM Max Reitz wrote: > > On 13.10.20 02:15, Yonggang Luo wrote: > > These compiling errors are fixed: > > ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory > > 27 | #include > >| ^

Re: [PULL v8 062/152] meson: infrastructure for building emulators

2020-11-03 Thread Yonggang Luo
On Tue, Nov 3, 2020 at 10:25 PM Paolo Bonzini wrote: > > On 03/11/20 15:19, 罗勇刚(Yonggang Luo) wrote: > >> > +#include CONFIG_DEVICES > > Mybe add config-devices.h back and detecting the target_cpu and include > > it properly? > > We could add a one-line conf

Re: [PULL v8 062/152] meson: infrastructure for building emulators

2020-11-03 Thread Yonggang Luo
; -#include "config-devices.h" > > +#include CONFIG_DEVICES Mybe add config-devices.h back and detecting the target_cpu and include it properly? > > Suggestion: add a comment to this include, because it is hard to > figure out what it does (if you don't have minikconf + meson > background). At least it was not obvious to me. (other > occurrences in the codebase). > > Regards, > > Phil. > > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PULL 00/17] Build system changes and misc fixes for QEMU 5.2 soft freeze

2020-10-26 Thread Yonggang Luo
On Tue, Oct 27, 2020 at 4:58 AM Paolo Bonzini wrote: > > > > Il lun 26 ott 2020, 19:59 罗勇刚(Yonggang Luo) ha scritto: >> >> This pull request confused me, the windows msys2 build time slow down from 40min to more than one hour. > > > Probably just the cache be

Re: [PATCH 0/2] armv7m_systick: Rewrite to use ptimers

2020-10-26 Thread Yonggang Luo
t; > > thanks > > -- PMM > > > > > > Peter Maydell (2): > > hw/core/ptimer: Support ptimer being disabled by timer callback > > hw/timer/armv7m_systick: Rewrite to use ptimers > > > > include/hw/timer/armv7m_systick.h | 3 +- > > hw/core/ptimer.c | 4 + > > hw/timer/armv7m_systick.c | 124 +- > > 3 files changed, 58 insertions(+), 73 deletions(-) > > > > -- > > 2.20.1 > > > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

How about using a bot to guard the pull request can be apply? like rust compiler does.

2020-10-26 Thread Yonggang Luo
sincerely, Yonggang Luo

Re: [PULL 00/17] Build system changes and misc fixes for QEMU 5.2 soft freeze

2020-10-26 Thread Yonggang Luo
s (Sunil) > > * Remove -no-kbm (Thomas) > > > > > > > Applied, thanks. > > Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2 > for any user-visible changes. > > -- PMM > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH] meson: rewrite curses/iconv test

2020-10-19 Thread Yonggang Luo
get_option('curses').enabled() > -error('Cannot find curses') > - endif > -elif get_option('curses').enabled() > - error('iconv required for curses UI but not available') > + if not curses.found() and msg != '' > +if get_option('curses').enabled() > + error(msg) > else > - warning('iconv required for curses UI but not available, disabling') > + warning(msg + ', disabling') > endif >endif > endif > -- > 2.26.2 > Reviewed-by: Yonggang Luo uoyongg...@gmail.com> -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v11] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-17 Thread Yonggang Luo
On Sun, Oct 18, 2020 at 12:43 AM Yonggang Luo wrote: > > The sh script are harder to maintain for compatible different > xsh environment so convert it to python script > Also incorporate the fixes in > https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com

[PATCH v11] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-17 Thread Yonggang Luo
CYGWIN=noglob and MSYS=noglob in the environment variable for disable wildcard expanding in msys or cygwin git, and setting the shell=False Signed-off-by: Yonggang Luo Message-Id: <20201006112139.700-1-luoyongg...@gmail.com> Signed-off-by: Paolo Bonzini --- meson.build | 2 +- s

Re: [PULL v2 00/22] Build system + misc changes for 2020-10-16

2020-10-17 Thread Yonggang Luo
th). I'll > fix everything up and resend this pull request when I'm done. > > I'm not sure if that will remove the warning or not, but I'll check (and > if it does remain, it'll be of the "useful" kind which documents some > unexpected dependency between options). > > Paolo > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PULL 18/22] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 7:48 PM Paolo Bonzini wrote: > > From: Yonggang Luo > > Signed-off-by: Yonggang Luo > Message-Id: <20201015220626.418-4-luoyongg...@gmail.com> > Signed-off-by: Paolo Bonzini > --- > configure | 59 -

[PATCH v5 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-16 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo --- .cirrus.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index

[PATCH v5 0/4] Fixes docs building on msys2/mingw

2020-10-16 Thread Yonggang Luo
issue that docs can not be build under msys2/mingw Yonggang Luo (4): docs: Fixes build docs on msys2/mingw configure: the docdir option should passed to meson as is. meson: Move the detection logic for sphinx to meson cirrus: Enable doc build on msys2/mingw .cirrus.yml

[PATCH v5 2/4] configure: the docdir option should passed to meson as is.

2020-10-16 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 78062fb091..432ea124e1 100755 --- a/configure +++ b/configure @@ -968,7 +968,7 @@ for opt do ;; --with-suffix=*) qemu_suffix="$o

[PATCH v5 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 59 +++ docs/meson.build | 4 +-- meson.build | 52 ++ meson_options.txt | 5 ++- tests/qapi-schema/meson.build | 2 +- 5

[PATCH v5 1/4] docs: Fixes build docs on msys2/mingw

2020-10-16 Thread Yonggang Luo
meson didn't support running ../scripts/kernel-do directly Add the perl as the first parameter Signed-off-by: Yonggang Luo --- docs/sphinx/kerneldoc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/kerneldoc.py b/docs/sphinx/kerneldoc.py index 3e87940206

Re: [PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 4:05 PM Paolo Bonzini wrote: > > On 16/10/20 09:57, Paolo Bonzini wrote: > > On 16/10/20 09:52, 罗勇刚(Yonggang Luo) wrote: > >> > >>> build_docs = false > >>> if sphinx_build.found() > >>> # This is a bit awkwa

Re: [PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 3:57 PM Paolo Bonzini wrote: > > On 16/10/20 09:52, 罗勇刚(Yonggang Luo) wrote: > > > >> build_docs = false > >> if sphinx_build.found() > >> # This is a bit awkward but works: create a trivial document and > >> # try to ru

Re: [PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 3:57 PM Paolo Bonzini wrote: > > On 16/10/20 09:52, 罗勇刚(Yonggang Luo) wrote: > > > >> build_docs = false > >> if sphinx_build.found() > >> # This is a bit awkward but works: create a trivial document and > >> # try to ru

Re: [PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
nabled() > error('Install a Python 3 version of python-sphinx') > endif > endif > > > > On 16/10/20 00:06, Yonggang Luo wrote: > > Signed-off-by: Yonggang Luo > > --- > > configure | 59 +++--- > >

Re: [PATCH v4 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 6:19 AM Paolo Bonzini wrote: > > > > Il ven 16 ott 2020, 00:06 Yonggang Luo ha scritto: >> >> meson didn't support running ../scripts/kernel-do directly > > > Can you explain why this matters? Meson does not look at docs/conf.py. > >

[PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 59 +++--- docs/meson.build | 4 +-- meson.build | 60 +++ meson_options.txt | 5 ++- tests/qapi-schema/meson.build | 2 +- 5

[PATCH v4 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-15 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo --- .cirrus.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index

[PATCH v4 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
meson didn't support running ../scripts/kernel-do directly Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/conf.py b/docs/conf.py index 00e1b750e2..e584f68393 100644 --- a/docs

[PATCH v4 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Yonggang Luo
v1 - v2 Also move the docs configure part from configure to meson, this also fixed the pending ninjatool removal caused issue that docs can not be build under msys2/mingw Yonggang Luo (4): docs: Fixes build docs on msys2/mingw configure: the docdir option should passed to meson as is. meson

[PATCH v4 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index f839c2a557..1ce31f97b4 100755 --- a/configure +++ b/configure @@ -971,7 +971,7 @@ for opt do ;; --with-suffix=*) qemu_suffix="$o

Re: [PATCH v2 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 5:53 AM Paolo Bonzini wrote: > > Looks good, apart from the CR removal patch that can simply be dropped. Resend with fixes, the CR removal patch composite two part. > > Paolo > > Il gio 15 ott 2020, 22:10 Yonggang Luo ha scritto: >> >>

[PATCH v3 3/4] meson: Move the detection logic for sphinx to meson

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 59 +++ docs/meson.build | 4 +-- meson.build | 59 ++- meson_options.txt | 5 ++- tests/qapi-schema/meson.build | 2 +- 5

[PATCH v3 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-15 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo --- .cirrus.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index

[PATCH v3 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Yonggang Luo
to meson, this also fixed the pending ninjatool removal caused issue that docs can not be build under msys2/mingw Yonggang Luo (4): docs: Fixes build docs on msys2/mingw configure: the docdir option should passed to meson as is. meson: Move the detection logic for sphinx to meson cirrus

[PATCH v3 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index f839c2a557..1ce31f97b4 100755 --- a/configure +++ b/configure @@ -971,7 +971,7 @@ for opt do ;; --with-suffix=*) qemu_suffix="$o

[PATCH v3 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
meson didn't support running ../scripts/kernel-do directly Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/conf.py b/docs/conf.py index 00e1b750e2..e584f68393 100644 --- a/docs

Re: [PATCH v2 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Yonggang Luo
Grep qemu_docdir and docdir in configure, you will know why, qemu_docdir not used at all in configure, On Fri, Oct 16, 2020 at 5:24 AM Paolo Bonzini wrote: > > Why? > > Paolo > > Il gio 15 ott 2020, 22:11 Yonggang Luo ha scritto: >> >> Signed-off-by: Yonggang

Re: [PATCH v2 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
It's tests, running by make On Fri, Oct 16, 2020 at 5:23 AM Paolo Bonzini wrote: > > > > Il gio 15 ott 2020, 22:30 Peter Maydell ha scritto: >> >> On Thu, 15 Oct 2020 at 21:13, Yonggang Luo wrote: >> > >> > Signed-off-by: Yonggang Luo >>

Re: [PATCH v2 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 4:30 AM Peter Maydell wrote: > > On Thu, 15 Oct 2020 at 21:13, Yonggang Luo wrote: > > > > Signed-off-by: Yonggang Luo > > --- > > docs/conf.py | 2 +- > > docs/sphinx/kerneldoc.py | 2 +- >

[PATCH v3 1/2] block: Fixes nfs compiling error on msys2/mingw

2020-10-15 Thread Yonggang Luo
tat64 yet, we disable the usage of it on msys2/mingw, and create a typedef long long blkcnt_t; for further implementation Signed-off-by: Yonggang Luo --- block/nfs.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/block/nfs.c b/block/nfs.c index f86e660374..cf8795fb

[PATCH v3 0/2] Fixes building nfs on msys2/mingw

2020-10-15 Thread Yonggang Luo
Revise the commit message of * block: enable libnfs on msys2/mingw in cirrus.yml V1-V2 Apply suggestion from Peter Lieven Yonggang Luo (2): block: Fixes nfs compiling error on msys2/mingw block: enable libnfs on msys2/mingw in cirrus.yml .cirrus.yml | 1 + block/nfs.c | 15

[PATCH v3 2/2] block: enable libnfs on msys2/mingw in cirrus.yml

2020-10-15 Thread Yonggang Luo
Initially, libnfs has not been enabled, and now it's fixed, so enable it on cirrus. Signed-off-by: Yonggang Luo --- .cirrus.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.cirrus.yml b/.cirrus.yml index f42ccb956a..2c6bf45e6d 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -109,6 +109,7

  1   2   3   4   5   6   7   8   >