Re: [Qemu-devel] [PATCH] Add warmup phase for live migration of large memory apps

2011-05-12 Thread Yoshiaki Tamura
2011/5/12 Isaku Yamahata yamah...@valinux.co.jp: On Thu, May 12, 2011 at 12:39:22PM +0200, Juan Quintela wrote: Shribman, Aidan aidan.shrib...@sap.com wrote: On Wed, May 11, 2011 at 8:58 AM, Shribman, Aidan aidan.shrib...@sap.com wrote: From: Aidan Shribman aidan.shrib...@sap.com

Re: [Qemu-devel] [PATCH 12/18] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c.

2011-04-27 Thread Yoshiaki Tamura
On Apr 26, 2011, at 11:51 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2011-04-26 16:24, 大村 圭 wrote: 2011/4/25 Jan Kiszka jan.kis...@web.de: On 2011-04-25 13:00, OHMURA Kei wrote: From: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Record mmio write event to replay it upon failover

Re: [Qemu-devel] [PATCH 12/18] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c.

2011-04-27 Thread Yoshiaki Tamura
On Apr 27, 2011, at 2:51 PM, Takuya Yoshikawa yoshikawa.tak...@oss.ntt.co.jp wrote: What kind of mmio should be traced here, device or CPU originated? Or both? Jan To let Kemari replay outputs upon failover, tracing CPU originated mmio (specifically write requests) should be

[Qemu-devel] Re: [PATCH v2 2/2] rbd: allow configuration of rados from the rbd filename

2011-04-07 Thread Yoshiaki Tamura
2011/4/7 Stefan Hajnoczi stefa...@gmail.com: On Thu, Apr 07, 2011 at 10:14:03AM +0900, Yoshiaki Tamura wrote: 2011/3/29 Josh Durgin josh.dur...@dreamhost.com: The new format is rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]] Each option is used to configure rados, and may

[Qemu-devel] Re: [PATCH v2 2/2] rbd: allow configuration of rados from the rbd filename

2011-04-07 Thread Yoshiaki Tamura
2011/4/8 Yehuda Sadeh Weinraub yehud...@gmail.com: On Thu, Apr 7, 2011 at 2:54 AM, Yoshiaki Tamura tamura.yoshi...@gmail.com wrote: 2011/4/7 Stefan Hajnoczi stefa...@gmail.com: On Thu, Apr 07, 2011 at 10:14:03AM +0900, Yoshiaki Tamura wrote: 2011/3/29 Josh Durgin josh.dur...@dreamhost.com

Re: [Qemu-devel] [PATCH v2 00/28] Refactor and cleanup migration code

2011-04-02 Thread Yoshiaki Tamura
2011/2/24 Juan Quintela quint...@redhat.com: v2: - make Jan^Wcheckpatch.pl happy - Yoshiaki Tamura suggestions:  - include its two patches to clean things  - MAX_THROTTLE define  - migration_state enum - I removed spurious differences between migration-{tcp,unix} - better error propagation

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-23 Thread Yoshiaki Tamura
2011/3/23 Avi Kivity a...@redhat.com: On 03/22/2011 03:26 PM, Anthony Liguori wrote: Here's how I propose we tackle this.  This patch adds a -dump-savevm option that takes a version.  It spits out all of the fields we save for a particular version (well, not really, but it should).  We also

Re: [Qemu-devel] Re: [PATCH 2/9] vmstate: Fix varrays with uint8 indexes

2011-03-22 Thread Yoshiaki Tamura
2011/3/18 Juan Quintela quint...@redhat.com: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp wrote: Juan, Anthony, It seems this patch broke live migration in my environment.  The guest hangs after switching to remote.  The following is parameters of the guest. -L /usr/local/seabios --enable

[Qemu-devel] [PATCH 04/18] qemu-char: export socket_set_nodelay().

2011-03-22 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- qemu-char.c |2 +- qemu_socket.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 31c9e79..fa16d36 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2111,7 +2111,7 @@ static

[Qemu-devel] [PATCH 17/18] migration-tcp: modify tcp_accept_incoming_migration() to handle ft_mode, and add a hack not to close fd when ft_mode is enabled.

2011-03-22 Thread Yoshiaki Tamura
for it. vm_change_state_handler is added to turn off ft_mode when cont is pressed. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration-tcp.c | 67 ++- 1 files changed, 66 insertions(+), 1 deletions(-) diff --git a/migration-tcp.c b

[Qemu-devel] [PATCH 03/18] Introduce qemu_loadvm_state_no_header() and make qemu_loadvm_state() a wrapper.

2011-03-22 Thread Yoshiaki Tamura
Introduce qemu_loadvm_state_no_header() so that it can be called iteratively without reading the header, and qemu_loadvm_state() becomes a wrapper of it. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- savevm.c | 45 +++-- 1 files

[Qemu-devel] [PATCH 18/18] Introduce kemari: to enable FT migration mode (Kemari).

2011-03-22 Thread Yoshiaki Tamura
When kemari: is set in front of URI of migrate command, it will turn on ft_mode to start FT migration mode (Kemari). On the receiver side, the option looks like, -incoming kemari:protocol:address:port Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Acked-by: Paolo Bonzini pbonz

[Qemu-devel] [PATCH 06/18] virtio: decrement last_avail_idx with inuse before saving.

2011-03-22 Thread Yoshiaki Tamura
to make it repeat the last inuse requests. Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hw/virtio.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index 31bd9e3

[Qemu-devel] [PATCH 11/18] ioport: insert event_tap_ioport() to ioport_write().

2011-03-22 Thread Yoshiaki Tamura
Record ioport event to replay it upon failover. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- ioport.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ioport.c b/ioport.c index 2e971fa..f485bab 100644 --- a/ioport.c +++ b/ioport.c @@ -27,6 +27,7

[Qemu-devel] [PATCH 02/18] Introduce read() to FdMigrationState.

2011-03-22 Thread Yoshiaki Tamura
Currently FdMigrationState doesn't support read(), and this patch introduces it to get response from the other side. Note that this won't change the existing migration protocol to be bi-directional. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration-tcp.c | 15

[Qemu-devel] [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-03-22 Thread Yoshiaki Tamura
This code implements VM transaction protocol. Like buffered_file, it sits between savevm and migration layer. With this architecture, VM transaction protocol is implemented mostly independent from other existing code. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off

[Qemu-devel] [PATCH 12/18] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c.

2011-03-22 Thread Yoshiaki Tamura
Record mmio write event to replay it upon failover. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- exec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index 964ce31..be71464 100644 --- a/exec.c +++ b/exec.c @@ -33,6 +33,7

[Qemu-devel] [PATCH 01/18] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().

2011-03-22 Thread Yoshiaki Tamura
Currently buf size is fixed at 32KB. It would be useful if it could be flexible. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hw/hw.h |2 ++ savevm.c | 20 +++- 2 files changed, 21 insertions(+), 1 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index

[Qemu-devel] [PATCH 15/18] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-03-22 Thread Yoshiaki Tamura
Introduce qemu_savevm_trans_{begin,commit} to send the memory and device info together, while avoiding cancelling memory state tracking. This patch also abstracts common code between qemu_savevm_state_{begin,iterate,commit}. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp

[Qemu-devel] [PATCH 00/18] [PATCH 00/18] Kemari for KVM v0.2.13

2011-03-22 Thread Yoshiaki Tamura
/kemari/kemari next Thanks, Yoshi Yoshiaki Tamura (18): Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer(). Introduce read() to FdMigrationState. Introduce qemu_loadvm_state_no_header() and make qemu_loadvm_state() a wrapper. qemu-char: export

[Qemu-devel] [PATCH 13/18] net: insert event-tap to qemu_send_packet() and qemu_sendv_packet_async().

2011-03-22 Thread Yoshiaki Tamura
event-tap function is called only when it is on. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- net.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index ddcca97..a541ede 100644 --- a/net.c +++ b/net.c @@ -37,6 +37,7 @@ #include

[Qemu-devel] [PATCH 05/18] vl.c: add deleted flag for deleting the handler.

2011-03-22 Thread Yoshiaki Tamura
Make deleting handlers robust against deletion of any elements in a handler by using a deleted flag like in file descriptors. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- vl.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c

[Qemu-devel] [PATCH 08/18] savevm: introduce util functions to control ft_trans_file from savevm layer.

2011-03-22 Thread Yoshiaki Tamura
To utilize ft_trans_file function, savevm needs interfaces to be exported. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hw/hw.h |5 ++ savevm.c | 150 ++ 2 files changed, 155 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH 14/18] block: insert event-tap to bdrv_aio_writev(), bdrv_aio_flush() and bdrv_flush().

2011-03-22 Thread Yoshiaki Tamura
event-tap function is called only when it is on, and requests were sent from device emulators. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Acked-by: Kevin Wolf kw...@redhat.com --- block.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH 09/18] Introduce event-tap.

2011-03-22 Thread Yoshiaki Tamura
event-tap controls when to start FT transaction, and provides proxy functions to called from net/block devices. While FT transaction, it queues up net/block requests, and flush them when the transaction gets completed. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off

[Qemu-devel] [PATCH 16/18] migration: introduce migrate_ft_trans_{put, get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on.

2011-03-22 Thread Yoshiaki Tamura
from the receiver. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration.c | 266 ++- 1 files changed, 265 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index 1c2d956..d536df0 100644

[Qemu-devel] [PATCH 10/18] Call init handler of event-tap at main() in vl.c.

2011-03-22 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- vl.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 483e2e3..6ed9b20 100644 --- a/vl.c +++ b/vl.c @@ -160,6 +160,7 @@ int main(int argc, char **argv) #include qemu-queue.h #include

Re: [Qemu-devel] [PATCH 2/9] vmstate: Fix varrays with uint8 indexes

2011-03-18 Thread Yoshiaki Tamura
Juan, Anthony, It seems this patch broke live migration in my environment. The guest hangs after switching to remote. The following is parameters of the guest. -L /usr/local/seabios --enable-kvm -M pc -m 512 -smp 1 -monitor stdio -localtime -boot c -drive file=/vm/fedora13.img,if=virtio -net

Re: [Qemu-devel] Re: [PATCH 2/9] vmstate: Fix varrays with uint8 indexes

2011-03-18 Thread Yoshiaki Tamura
Ah, now I see what the problem was. Yoshi 2011/3/18 Juan Quintela quint...@redhat.com: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp wrote: Juan, Anthony, It seems this patch broke live migration in my environment.  The guest hangs after switching to remote.  The following is parameters

Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-18 Thread Yoshiaki Tamura
-num_offset);             }             if (field-flags VMS_POINTER) {                 base_addr = *(void **)base_addr + field-start; -- 1.7.4 Acked-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp

Re: [Qemu-devel] Re: KVM call agenda for Mars 14th

2011-03-14 Thread Yoshiaki Tamura
On Mar 15, 2011, at 2:49 AM, Anthony Liguori anth...@codemonkey.ws wrote: On 03/14/2011 11:36 AM, Juan Quintela wrote: Jes Sorensenjes.soren...@redhat.com wrote: On 03/14/11 13:14, Juan Quintela wrote: Please send any agenda items you are interested in covering. Thanks, Juan. I presume

[Qemu-devel] [PATCH v2] migration: allow setting MIG_STATE_CANCEL even if s-state != MIG_STATE_ACTIVE.

2011-02-28 Thread Yoshiaki Tamura
patches are prerequisite. http://www.mail-archive.com/qemu-devel@nongnu.org/msg56448.html http://www.mail-archive.com/qemu-devel@nongnu.org/msg56446.html Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions

[Qemu-devel] [PATCH 18/18] Introduce kemari: to enable FT migration mode (Kemari).

2011-02-24 Thread Yoshiaki Tamura
When kemari: is set in front of URI of migrate command, it will turn on ft_mode to start FT migration mode (Kemari). On the receiver side, the option looks like, -incoming kemari:protocol:address:port Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Acked-by: Paolo Bonzini pbonz

[Qemu-devel] [PATCH 15/18] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-02-24 Thread Yoshiaki Tamura
Introduce qemu_savevm_trans_{begin,commit} to send the memory and device info together, while avoiding cancelling memory state tracking. This patch also abstracts common code between qemu_savevm_state_{begin,iterate,commit}. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp

[Qemu-devel] [PATCH 16/18] migration: introduce migrate_ft_trans_{put, get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on.

2011-02-24 Thread Yoshiaki Tamura
from the receiver. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration.c | 261 ++- 1 files changed, 260 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index 1c2d956..cdea459 100644

[Qemu-devel] [PATCH 09/18] Introduce event-tap.

2011-02-24 Thread Yoshiaki Tamura
event-tap controls when to start FT transaction, and provides proxy functions to called from net/block devices. While FT transaction, it queues up net/block requests, and flush them when the transaction gets completed. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off

[Qemu-devel] Re: [PATCH 21/28] migration: Make state definitions local

2011-02-24 Thread Yoshiaki Tamura
Juan Quintela wrote: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp wrote: 2011/2/24 Juan Quintelaquint...@redhat.com: Signed-off-by: Juan Quintelaquint...@redhat.com --- migration.c |8 migration.h |8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] Re: [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-02-24 Thread Yoshiaki Tamura
2011/2/24 Juan Quintela quint...@redhat.com: [ trimming cc to kvm qemu lists] Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp wrote: Juan Quintela wrote: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp  wrote: This code implements VM transaction protocol.  Like buffered_file, it sits between

[Qemu-devel] [PATCH] migration: allow setting MIG_STATE_CANCEL even if s-state != MIG_STATE_ACTIVE.

2011-02-24 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/migration.c b/migration.c index af3a1f2..098885f 100644 --- a/migration.c +++ b/migration.c @@ -409,15 +409,16 @@ void migrate_fd_cancel

Re: [Qemu-devel] Re: [PATCH 22/22] migration: Make state definitions local

2011-02-24 Thread Yoshiaki Tamura
2011/2/24 Juan Quintela quint...@redhat.com: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp wrote: 2011/2/23 Juan Quintela quint...@redhat.com: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp wrote: 2011/2/23 Juan Quintela quint...@redhat.com: Although you're right, I would prefer to keep it so

Re: [Qemu-devel] Re: [PATCH 22/22] migration: Make state definitions local

2011-02-24 Thread Yoshiaki Tamura
2011/2/24 Anthony Liguori anth...@codemonkey.ws: On 02/24/2011 06:23 AM, Juan Quintela wrote: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp  wrote: 2011/2/23 Juan Quintelaquint...@redhat.com: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp  wrote: 2011/2/23 Juan

Re: [Qemu-devel] [PATCH 03/22] migration: Fold MigrationState into FdMigrationState

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: Signed-off-by: Juan Quintela quint...@redhat.com ---  migration-exec.c |   10 +-  migration-fd.c   |   10 +-  migration-tcp.c  |   10 +-  migration-unix.c |   10 +-  migration.c      |   11 +--  

Re: [Qemu-devel] [PATCH 17/22] migration: use global variable directly

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: We are setting a pointer to a local variable in the previous line, just use the global variable directly.  We remove the -file test because it is already done inside qemu_file_set_rate_limit() function. Signed-off-by: Juan Quintela

Re: [Qemu-devel] [PATCH 12/22] migration: Use migrate_fd_error() in last place that set status to ERROR

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: We are also calling to migrate_fd_cleanup(), but notice that it is the right thing to do. Signed-off-by: Juan Quintela quint...@redhat.com ---  migration.c |    6 +-  1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/migration.c

Re: [Qemu-devel] [PATCH 08/22] migration: Check that migration is active before cancel it

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: Signed-off-by: Juan Quintela quint...@redhat.com ---  migration.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index 397a0b9..55f58c8 100644 --- a/migration.c +++ b/migration.c @@ -138,7

Re: [Qemu-devel] [PATCH 22/22] migration: Make state definitions local

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: Signed-off-by: Juan Quintela quint...@redhat.com ---  migration.c |    6 ++  migration.h |    6 --  2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/migration.c b/migration.c index 383ebaf..90fc2a0 100644 --- a/migration.c

Re: [Qemu-devel] [PATCH 14/22] migration: Remove get_status() accessor

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: It is only used inside migration.c, and fields on that struct are accessed all around the place on that file. Signed-off-by: Juan Quintela quint...@redhat.com ---  migration.c |   16 +---  migration.h |    1 -  2 files changed, 5

Re: [Qemu-devel] [PATCH 21/22] migration: Export a function that tells if the migration has finished correctly

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: This will allows us to hide the status values. Signed-off-by: Juan Quintela quint...@redhat.com ---  migration.c     |    4 ++--  migration.h     |    2 +-  ui/spice-core.c |    4 +---  3 files changed, 4 insertions(+), 6 deletions(-) diff

Re: [Qemu-devel] [PATCH 19/22] migration: convert current_migration from pointer to struct

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: This cleans up a lot the code as we don't have to check anymore if the variable is NULL or not. Signed-off-by: Juan Quintela quint...@redhat.com ---  migration.c |  119 --  1 files changed,

Re: [Qemu-devel] [PATCH 18/22] migration: another case of global variable assigned to local one

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: Signed-off-by: Juan Quintela quint...@redhat.com ---  migration.c |    3 +--  1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/migration.c b/migration.c index accc6e4..4014330 100644 --- a/migration.c +++ b/migration.c @@ -136,9

Re: [Qemu-devel] [PATCH 16/22] migration: Move exported functions to the end of the file

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: This means we can remove the two forward declarations. Signed-off-by: Juan Quintela quint...@redhat.com ---  migration.c |  188 +--  1 files changed, 92 insertions(+), 96 deletions(-)

Re: [Qemu-devel] [PATCH 02/22] migration: Use FdMigrationState instead of MigrationState when possible

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: Signed-off-by: Juan Quintela quint...@redhat.com ---  migration.c |   31 ++-  migration.h |   16  2 files changed, 22 insertions(+), 25 deletions(-) diff --git a/migration.c b/migration.c index

Re: [Qemu-devel] [PATCH 06/22] migration: Make all posible migration functions static

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: I have to move two functions postions to avoid forward declarations Signed-off-by: Juan Quintela quint...@redhat.com ---  migration.c |   72 +-  migration.h |   12 -  2 files

Re: [Qemu-devel] [PATCH 09/22] migration: Introduce MIG_STATE_NONE

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: Use MIG_STATE_ACTIVE only when migration has really started Signed-off-by: Juan Quintela quint...@redhat.com ---  migration.c |    6 +-  migration.h |    3 ++-  2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/migration.c

Re: [Qemu-devel] [PATCH 10/22] migration: Refactor and simplify error checking in migrate_fd_put_ready

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: Signed-off-by: Juan Quintela quint...@redhat.com ---  migration.c |   20 +---  1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/migration.c b/migration.c index f015e02..641df9f 100644 --- a/migration.c +++

Re: [Qemu-devel] Re: [PATCH 0/2] Fix error handling in migration when the peer is killed.

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp wrote: Hi, During live migration, if the receiver side of qemu gets killed, the sender side seems to be handling the error incorrectly, like it passes the iterate phase (stage 2) and moves

Re: [Qemu-devel] Re: [PATCH 10/22] migration: Refactor and simplify error checking in migrate_fd_put_ready

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp wrote: 2011/2/23 Juan Quintela quint...@redhat.com: Signed-off-by: Juan Quintela quint...@redhat.com ---  migration.c |   20 +---  1 files changed, 9 insertions(+), 11 deletions

[Qemu-devel] [PATCH 03/18] Introduce skip_header parameter to qemu_loadvm_state().

2011-02-23 Thread Yoshiaki Tamura
Introduce skip_header parameter to qemu_loadvm_state() so that it can be called iteratively without reading the header. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration.c |2 +- savevm.c| 24 +--- sysemu.h|2 +- 3 files changed, 15

[Qemu-devel] [PATCH 01/18] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().

2011-02-23 Thread Yoshiaki Tamura
Currently buf size is fixed at 32KB. It would be useful if it could be flexible. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hw/hw.h |2 ++ savevm.c | 20 +++- 2 files changed, 21 insertions(+), 1 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index

[Qemu-devel] [PATCH 18/18] Introduce kemari: to enable FT migration mode (Kemari).

2011-02-23 Thread Yoshiaki Tamura
When kemari: is set in front of URI of migrate command, it will turn on ft_mode to start FT migration mode (Kemari). On the receiver side, the option looks like, -incoming kemari:protocol:address:port Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Acked-by: Paolo Bonzini pbonz

[Qemu-devel] [PATCH 06/18] virtio: decrement last_avail_idx with inuse before saving.

2011-02-23 Thread Yoshiaki Tamura
to make it repeat the last inuse requests. Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hw/virtio.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index 31bd9e3

[Qemu-devel] [PATCH 10/18] Call init handler of event-tap at main() in vl.c.

2011-02-23 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- vl.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 4e263c3..614ac9c 100644 --- a/vl.c +++ b/vl.c @@ -162,6 +162,7 @@ int main(int argc, char **argv) #include qemu-queue.h #include

[Qemu-devel] [PATCH 13/18] net: insert event-tap to qemu_send_packet() and qemu_sendv_packet_async().

2011-02-23 Thread Yoshiaki Tamura
event-tap function is called only when it is on. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- net.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index ec4745d..724b549 100644 --- a/net.c +++ b/net.c @@ -36,6 +36,7 @@ #include

[Qemu-devel] [PATCH 09/18] Introduce event-tap.

2011-02-23 Thread Yoshiaki Tamura
event-tap controls when to start FT transaction, and provides proxy functions to called from net/block devices. While FT transaction, it queues up net/block requests, and flush them when the transaction gets completed. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off

[Qemu-devel] [PATCH 00/18] Kemari for KVM v0.2.11

2011-02-23 Thread Yoshiaki Tamura
optimization which aren't ready for posting yet. To remove the dirty bitmap optimization, please look at HEAD~4 of the tree. git://kemari.git.sourceforge.net/gitroot/kemari/kemari next Thanks, Yoshi Yoshiaki Tamura (18): Make QEMUFile buf expandable, and introduce qemu_realloc_buffer

[Qemu-devel] [PATCH 12/18] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c.

2011-02-23 Thread Yoshiaki Tamura
Record mmio write event to replay it upon failover. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- exec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index d611100..e192eec 100644 --- a/exec.c +++ b/exec.c @@ -33,6 +33,7

[Qemu-devel] [PATCH 02/18] Introduce read() to FdMigrationState.

2011-02-23 Thread Yoshiaki Tamura
Currently FdMigrationState doesn't support read(), and this patch introduces it to get response from the other side. Note that this won't change the existing migration protocol to be bi-directional. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration-tcp.c | 15

[Qemu-devel] [PATCH 11/18] ioport: insert event_tap_ioport() to ioport_write().

2011-02-23 Thread Yoshiaki Tamura
Record ioport event to replay it upon failover. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- ioport.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ioport.c b/ioport.c index aa4188a..74aebf5 100644 --- a/ioport.c +++ b/ioport.c @@ -27,6 +27,7

[Qemu-devel] [PATCH 15/18] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-02-23 Thread Yoshiaki Tamura
Introduce qemu_savevm_trans_{begin,commit} to send the memory and device info together, while avoiding cancelling memory state tracking. This patch also abstracts common code between qemu_savevm_state_{begin,iterate,commit}. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp

[Qemu-devel] [PATCH 05/18] vl.c: add deleted flag for deleting the handler.

2011-02-23 Thread Yoshiaki Tamura
Make deleting handlers robust against deletion of any elements in a handler by using a deleted flag like in file descriptors. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- vl.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c

[Qemu-devel] [PATCH 17/18] migration-tcp: modify tcp_accept_incoming_migration() to handle ft_mode, and add a hack not to close fd when ft_mode is enabled.

2011-02-23 Thread Yoshiaki Tamura
for it. vm_change_state_handler is added to turn off ft_mode when cont is pressed. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration-tcp.c | 67 ++- 1 files changed, 66 insertions(+), 1 deletions(-) diff --git a/migration-tcp.c b

[Qemu-devel] [PATCH 14/18] block: insert event-tap to bdrv_aio_writev(), bdrv_aio_flush() and bdrv_flush().

2011-02-23 Thread Yoshiaki Tamura
event-tap function is called only when it is on, and requests were sent from device emulators. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Acked-by: Kevin Wolf kw...@redhat.com --- block.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH 08/18] savevm: introduce util functions to control ft_trans_file from savevm layer.

2011-02-23 Thread Yoshiaki Tamura
To utilize ft_trans_file function, savevm needs interfaces to be exported. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hw/hw.h |5 ++ savevm.c | 149 ++ 2 files changed, 154 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-02-23 Thread Yoshiaki Tamura
This code implements VM transaction protocol. Like buffered_file, it sits between savevm and migration layer. With this architecture, VM transaction protocol is implemented mostly independent from other existing code. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off

[Qemu-devel] [PATCH 16/18] migration: introduce migrate_ft_trans_{put, get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on.

2011-02-23 Thread Yoshiaki Tamura
from the receiver. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration.c | 261 ++- 1 files changed, 260 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index 3be3554..82f4a4d 100644

[Qemu-devel] [PATCH 04/18] qemu-char: export socket_set_nodelay().

2011-02-23 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- qemu-char.c |2 +- qemu_socket.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index bd4e944..c4f1940 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2111,7 +2111,7 @@ static

[Qemu-devel] Re: [PATCH 05/18] vl.c: add deleted flag for deleting the handler.

2011-02-23 Thread Yoshiaki Tamura
Juan Quintela wrote: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp wrote: Make deleting handlers robust against deletion of any elements in a handler by using a deleted flag like in file descriptors. Signed-off-by: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp --- vl.c | 13 +

[Qemu-devel] Re: [PATCH 03/18] Introduce skip_header parameter to qemu_loadvm_state().

2011-02-23 Thread Yoshiaki Tamura
Juan Quintela wrote: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp wrote: Introduce skip_header parameter to qemu_loadvm_state() so that it can be called iteratively without reading the header. Signed-off-by: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp --- migration.c |2 +- savevm.c

[Qemu-devel] Re: [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-02-23 Thread Yoshiaki Tamura
Juan Quintela wrote: Yoshiaki Tamuratamura.yoshi...@lab.ntt.co.jp wrote: This code implements VM transaction protocol. Like buffered_file, it sits between savevm and migration layer. With this architecture, VM transaction protocol is implemented mostly independent from other existing code.

Re: [Qemu-devel] [PATCH 21/28] migration: Make state definitions local

2011-02-23 Thread Yoshiaki Tamura
2011/2/24 Juan Quintela quint...@redhat.com: Signed-off-by: Juan Quintela quint...@redhat.com ---  migration.c |    8  migration.h |    8  2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/migration.c b/migration.c index 493c2d7..697c74f 100644 ---

Re: [Qemu-devel] Re: [PATCH 22/22] migration: Make state definitions local

2011-02-23 Thread Yoshiaki Tamura
2011/2/23 Juan Quintela quint...@redhat.com: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp wrote: 2011/2/23 Juan Quintela quint...@redhat.com: Signed-off-by: Juan Quintela quint...@redhat.com ---  migration.c |    6 ++  migration.h |    6 --  2 files changed, 6 insertions(+), 6

[Qemu-devel] [PATCH 12/18] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c.

2011-02-23 Thread Yoshiaki Tamura
Record mmio write event to replay it upon failover. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- exec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index d611100..e192eec 100644 --- a/exec.c +++ b/exec.c @@ -33,6 +33,7

[Qemu-devel] [PATCH 13/18] net: insert event-tap to qemu_send_packet() and qemu_sendv_packet_async().

2011-02-23 Thread Yoshiaki Tamura
event-tap function is called only when it is on. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- net.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index ec4745d..724b549 100644 --- a/net.c +++ b/net.c @@ -36,6 +36,7 @@ #include

[Qemu-devel] [PATCH 03/18] Introduce qemu_loadvm_state_no_header() and make qemu_loadvm_state() a wrapper.

2011-02-23 Thread Yoshiaki Tamura
Introduce qemu_loadvm_state_no_header() so that it can be called iteratively without reading the header, and qemu_loadvm_state() becomes a wrapper of it. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- savevm.c | 45 +++-- 1 files

[Qemu-devel] [PATCH 01/18] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().

2011-02-23 Thread Yoshiaki Tamura
Currently buf size is fixed at 32KB. It would be useful if it could be flexible. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hw/hw.h |2 ++ savevm.c | 20 +++- 2 files changed, 21 insertions(+), 1 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index

[Qemu-devel] [PATCH 06/18] virtio: decrement last_avail_idx with inuse before saving.

2011-02-23 Thread Yoshiaki Tamura
to make it repeat the last inuse requests. Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hw/virtio.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index 31bd9e3

[Qemu-devel] [PATCH 14/18] block: insert event-tap to bdrv_aio_writev(), bdrv_aio_flush() and bdrv_flush().

2011-02-23 Thread Yoshiaki Tamura
event-tap function is called only when it is on, and requests were sent from device emulators. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Acked-by: Kevin Wolf kw...@redhat.com --- block.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH 00/18] Kemari for KVM v0.2.12

2011-02-23 Thread Yoshiaki Tamura
optimization, please look at HEAD~4 of the tree. git://kemari.git.sourceforge.net/gitroot/kemari/kemari next Thanks, Yoshi Yoshiaki Tamura (18): Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer(). Introduce read() to FdMigrationState. Introduce

[Qemu-devel] [PATCH 08/18] savevm: introduce util functions to control ft_trans_file from savevm layer.

2011-02-23 Thread Yoshiaki Tamura
To utilize ft_trans_file function, savevm needs interfaces to be exported. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hw/hw.h |5 ++ savevm.c | 150 ++ 2 files changed, 155 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH 17/18] migration-tcp: modify tcp_accept_incoming_migration() to handle ft_mode, and add a hack not to close fd when ft_mode is enabled.

2011-02-23 Thread Yoshiaki Tamura
for it. vm_change_state_handler is added to turn off ft_mode when cont is pressed. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration-tcp.c | 67 ++- 1 files changed, 66 insertions(+), 1 deletions(-) diff --git a/migration-tcp.c b

[Qemu-devel] [PATCH 10/18] Call init handler of event-tap at main() in vl.c.

2011-02-23 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- vl.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 0bda77d..0ea1fb7 100644 --- a/vl.c +++ b/vl.c @@ -162,6 +162,7 @@ int main(int argc, char **argv) #include qemu-queue.h #include

[Qemu-devel] [PATCH 11/18] ioport: insert event_tap_ioport() to ioport_write().

2011-02-23 Thread Yoshiaki Tamura
Record ioport event to replay it upon failover. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- ioport.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ioport.c b/ioport.c index aa4188a..74aebf5 100644 --- a/ioport.c +++ b/ioport.c @@ -27,6 +27,7

[Qemu-devel] [PATCH 04/18] qemu-char: export socket_set_nodelay().

2011-02-23 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- qemu-char.c |2 +- qemu_socket.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index bd4e944..c4f1940 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2111,7 +2111,7 @@ static

[Qemu-devel] [PATCH 05/18] vl.c: add deleted flag for deleting the handler.

2011-02-23 Thread Yoshiaki Tamura
Make deleting handlers robust against deletion of any elements in a handler by using a deleted flag like in file descriptors. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- vl.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c

[Qemu-devel] [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-02-23 Thread Yoshiaki Tamura
This code implements VM transaction protocol. Like buffered_file, it sits between savevm and migration layer. With this architecture, VM transaction protocol is implemented mostly independent from other existing code. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off

[Qemu-devel] [PATCH 02/18] Introduce read() to FdMigrationState.

2011-02-23 Thread Yoshiaki Tamura
Currently FdMigrationState doesn't support read(), and this patch introduces it to get response from the other side. Note that this won't change the existing migration protocol to be bi-directional. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration-tcp.c | 15

[Qemu-devel] [PATCH 0/2] Fix error handling in migration when the peer is killed.

2011-02-22 Thread Yoshiaki Tamura
Hi, During live migration, if the receiver side of qemu gets killed, the sender side seems to be handling the error incorrectly, like it passes the iterate phase (stage 2) and moves on to the complete state (stage 3). These patches fix the issue. Yoshiaki Tamura (2): savevm: avoid

[Qemu-devel] [PATCH 1/2] savevm: avoid qemu_savevm_state_iteate() to return 1 when qemu file has error.

2011-02-22 Thread Yoshiaki Tamura
returning 1/0, and avoids migrate_fd_put_ready() to proceed in case of error. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- savevm.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/savevm.c b/savevm.c index a50fd31..1a0be58 100644 --- a/savevm.c +++ b

[Qemu-devel] [PATCH 2/2] migration: add error handling to migrate_fd_put_notify().

2011-02-22 Thread Yoshiaki Tamura
Although migrate_fd_put_buffer() sets MIG_STATE_ERROR if it failed, since migrate_fd_put_notify() isn't checking error of underlying QEMUFile, those resources are kept open. This patch checks it and calls migrate_fd_error() in case of error. Signed-off-by: Yoshiaki Tamura tamura.yoshi

Re: [Qemu-devel] Re: [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-02-22 Thread Yoshiaki Tamura
it in this series though because I don't want to touch other components as much as possible this time. Yoshi Green. 2011/2/21 Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Hi Green, 2011/2/21 ya su suya94...@gmail.com: Yoshiaki:     I have one question about ram_save_live, during migration

  1   2   3   4   5   6   7   >