RE: [PATCH v2] migration/colo: Fix bdrv_graph_rdlock_main_loop: Assertion `!qemu_in_coroutine()' failed.

2024-04-17 Thread Zhang, Chen
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Wednesday, April 17, 2024 2:14 PM > To: Li Zhijian ; Zhang, Hailiang > ; pet...@redhat.com; faro...@suse.de > Cc: qemu-devel@nongnu.org; Zhang, Chen ; Wen > Congyang ; Xie Changlong > > Subject: Re

RE: COLO state?

2024-04-14 Thread Zhang, Chen
> -Original Message- > From: Fabiano Rosas > Sent: Thursday, April 11, 2024 10:40 PM > To: Zhang, Hailiang ; Zhang, Chen > ; Li Zhijian > Cc: qemu-devel@nongnu.org; Peter Xu > Subject: COLO state? > > Hi COLO maintainers, > > Would you please take

RE: [PATCH V2 09/11] migration: privatize colo interfaces

2024-03-11 Thread Zhang, Chen
> -Original Message- > From: Steve Sistare > Sent: Tuesday, March 12, 2024 1:49 AM > To: qemu-devel@nongnu.org > Cc: Alex Williamson ; Cedric Le Goater > ; Michael S. Tsirkin ; David Hildenbrand > ; Peter Xu ; Fabiano Rosas > ; Zhang, Hailiang ; Zhang, > Che

RE: [PATCH trivial] colo: examples: remove mentions of script= and (wrong) downscript=

2024-01-09 Thread Zhang, Chen
> -Original Message- > From: Michael Tokarev > Sent: Tuesday, January 9, 2024 1:44 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc: qemu-triv...@nongnu.org; Li Zhijian > Subject: Re: [PATCH trivial] colo: examples: remove mentions of script= and > (wrong) downsc

RE: [PATCH trivial] colo: examples: remove mentions of script= and (wrong) downscript=

2024-01-08 Thread Zhang, Chen
> -Original Message- > From: Michael Tokarev > Sent: Sunday, January 7, 2024 7:25 PM > To: qemu-devel@nongnu.org > Cc: Michael Tokarev ; qemu-triv...@nongnu.org; Zhang, > Chen ; Li Zhijian > Subject: [PATCH trivial] colo: examples: remove mentions of script= and

RE: [PATCH] tests/qtest: check the return value

2023-11-20 Thread Zhang, Chen
> -Original Message- > From: zhujun2 > Sent: Tuesday, November 21, 2023 2:17 PM > To: Zhang, Chen > Cc: lviv...@redhat.com; pbonz...@redhat.com; qemu-devel@nongnu.org; > th...@redhat.com; zhuj...@cmss.chinamobile.com > Subject: [PATCH] tests/qtest: c

RE: [PATCH] tests/qtest: remove unused variables

2023-11-15 Thread Zhang, Chen
> -Original Message- > From: qemu-devel-bounces+chen.zhang=intel@nongnu.org devel-bounces+chen.zhang=intel@nongnu.org> On Behalf Of zhujun2 > Sent: Wednesday, November 15, 2023 4:00 PM > To: th...@redhat.com > Cc: lviv...@redhat.com; pbonz...@redhat.com; qemu-devel@nongnu.org;

RE: [PATCH v6 13/21] virtio-net: Always set populate_hash

2023-10-30 Thread Zhang, Chen
> -Original Message- > From: qemu-devel-bounces+chen.zhang=intel@nongnu.org devel-bounces+chen.zhang=intel@nongnu.org> On Behalf Of Akihiko > Odaki > Sent: Monday, October 30, 2023 1:13 PM > Cc: qemu-devel@nongnu.org; Yuri Benditovich > ; Andrew Melnychenko > ; Michael S .

RE: [PATCH v6 05/21] tap: Remove tap_receive()

2023-10-30 Thread Zhang, Chen
> -Original Message- > From: qemu-devel-bounces+chen.zhang=intel@nongnu.org devel-bounces+chen.zhang=intel@nongnu.org> On Behalf Of Akihiko > Odaki > Sent: Monday, October 30, 2023 1:12 PM > Cc: qemu-devel@nongnu.org; Yuri Benditovich > ; Andrew Melnychenko > ; Michael S .

RE: [PATCH 2/8] colo: Setup ram cache in normal migration path

2023-06-28 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Thursday, June 22, 2023 8:15 PM > To: qemu-devel > Cc: Zhang, Hailiang ; Juan Quintela > ; Peter Xu ; Leonardo Bras > ; Zhang, Chen > Subject: [PATCH 2/8] colo: Setup ram cache in normal migration path > &

RE: [PATCH 1/8] colo: Only support the same qemu version on source and destination

2023-06-27 Thread Zhang, Chen
> -Original Message- > From: Dong, Eddie > Sent: Friday, June 23, 2023 1:17 AM > To: Lukas Straub ; qemu-devel de...@nongnu.org> > Cc: Zhang, Hailiang ; Juan Quintela > ; Peter Xu ; Leonardo Bras > ; Zhang, Chen > Subject: RE: [PATCH 1/8] colo: Only su

RE: [PATCH v4 00/10] COLO: improve build options

2023-05-05 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru > Subject: [PATCH v4 00/10] COLO: improve build

RE: [PATCH v4 10/10] migration: block incoming colo when capability is disabled

2023-05-05 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Friday, May 5, 2023 6:46 AM > To: Vladimir Sementsov-Ogievskiy > Cc: qemu-devel@nongnu.org; quint...@redhat.com; Zhang, Chen > ; Peter Xu ; Leonardo Bras > > Subject: Re: [PATCH v4 10/10] migration: block incom

RE: [PATCH v4 10/10] migration: block incoming colo when capability is disabled

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Peter Xu > ; Leonardo Bras > Subject: [P

RE: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Thursday, May 4, 2023 4:23 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Peter Xu > ; Leonardo Bras > Subject: Re: [PATCH v4 09/10] migration: disallo

RE: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Peter Xu > ; Leonardo Bras > Subject: [P

RE: [PATCH v4 07/10] migration: split migration_incoming_co

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Thursday, May 4, 2023 6:52 AM > To: Peter Xu > Cc: qemu-devel@nongnu.org; lukasstra...@web.de; quint...@redhat.com; > Zhang, Chen ; Zhang, Hailiang > ; Leonardo Bras > Subject: Re: [PATCH v4

RE: [PATCH v4 06/10] migration: process_incoming_migration_co: simplify code flow around ret

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Peter Xu > ; Leonardo Bras > Subject: [P

RE: [PATCH v4 05/10] migration: drop colo_incoming_thread from MigrationIncomingState

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Peter Xu > ; Leonardo Bras > Subject: [P

RE: [PATCH v4 04/10] configure: add --disable-colo-proxy option

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Paolo Bonzini > ; Marc-André Lureau &

RE: [PATCH v4 02/10] colo: make colo_checkpoint_notify static and provide simpler API

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Zhang, Hailiang > ; Peter Xu ; Leonardo > Br

RE: [PATCH v4 01/10] block/meson.build: prefer positive condition for replication

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Philippe Mathieu- > Daudé ; Kevin Wolf ;

RE: [PATCH v3 4/4] configure: add --disable-colo-proxy option

2023-04-28 Thread Zhang, Chen
...@redhat.com; Zhang, Hailiang > ; phi...@linaro.org; th...@redhat.com; > berra...@redhat.com; marcandre.lur...@redhat.com; > pbonz...@redhat.com; d...@treblig.org; hre...@redhat.com; > kw...@redhat.com; Zhang, Chen ; > lizhij...@fujitsu.com > Subject: Re: [PATCH v3 4/4] con

RE: [PATCH v2 6/6] tests/migration: Only run auto_converge in slow mode

2023-04-24 Thread Zhang, Chen
> -Original Message- > From: Thomas Huth > Sent: Monday, April 24, 2023 2:56 PM > To: quint...@redhat.com; Zhang, Chen > Cc: Daniel P. Berrangé ; qemu-devel@nongnu.org; > qemu-bl...@nongnu.org; Paolo Bonzini ; John > Snow ; Li Zhijian ; Stefan > Hajnoczi ; Laure

RE: [PATCH v2 6/6] tests/migration: Only run auto_converge in slow mode

2023-04-24 Thread Zhang, Chen
> -Original Message- > From: Daniel P. Berrangé > Sent: Saturday, April 22, 2023 1:14 AM > To: qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; Paolo Bonzini ; > Thomas Huth ; John Snow ; Li > Zhijian ; Juan Quintela ; > Stefan Hajnoczi ; Zhang, Chen >

RE: [PATCH v2 6/6] tests/migration: Only run auto_converge in slow mode

2023-04-22 Thread Zhang, Chen
> -Original Message- > From: Daniel P. Berrangé > Sent: Saturday, April 22, 2023 1:14 AM > To: qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; Paolo Bonzini ; > Thomas Huth ; John Snow ; Li > Zhijian ; Juan Quintela ; > Stefan Hajnoczi ; Zhang, Chen >

RE: [PATCH v2 1/6] tests/qtest: replace qmp_discard_response with qtest_qmp_assert_success

2023-04-22 Thread Zhang, Chen
> -Original Message- > From: Daniel P. Berrangé > Sent: Saturday, April 22, 2023 1:14 AM > To: qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; Paolo Bonzini ; > Thomas Huth ; John Snow ; Li > Zhijian ; Juan Quintela ; > Stefan Hajnoczi ; Zhang, Chen >

RE: [PATCH v2 4/4] configure: add --disable-colo-filters option

2023-04-22 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Friday, April 21, 2023 4:53 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; michael.r...@amd.com; arm...@redhat.com; > ebl...@redhat.com; jasow...@redhat.com; quint...

RE: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION

2023-04-22 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Friday, April 21, 2023 4:36 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; michael.r...@amd.com; arm...@redhat.com; > ebl...@redhat.com; jasow...@redhat.com; quint...

RE: [PATCH v2 3/4] build: move COLO under CONFIG_REPLICATION

2023-04-20 Thread Zhang, Chen
, > Hailiang ; phi...@linaro.org; > th...@redhat.com; berra...@redhat.com; marcandre.lur...@redhat.com; > pbonz...@redhat.com; d...@treblig.org; hre...@redhat.com; > kw...@redhat.com; Zhang, Chen ; > lizhij...@fujitsu.com; Vladimir Sementsov-Ogievskiy team.ru> > Subject

RE: [PATCH v2 4/4] configure: add --disable-colo-filters option

2023-04-20 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Thursday, April 20, 2023 7:26 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; michael.r...@amd.com; arm...@redhat.com; > ebl...@redhat.com; jasow...@redhat.com; quint...

RE: [PATCH v2 4/4] configure: add --disable-colo-filters option

2023-04-20 Thread Zhang, Chen
, > Hailiang ; phi...@linaro.org; > th...@redhat.com; berra...@redhat.com; marcandre.lur...@redhat.com; > pbonz...@redhat.com; d...@treblig.org; hre...@redhat.com; > kw...@redhat.com; Zhang, Chen ; > lizhij...@fujitsu.com; Vladimir Sementsov-Ogievskiy team.ru> > Subject: [PATC

RE: [PATCH] replication: compile out some staff when replication is not configured

2023-04-16 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Friday, April 14, 2023 5:51 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc: qemu-bl...@nongnu.org; pbonz...@redhat.com; arm...@redhat.com; > ebl...@redhat.com; jasow...@redhat.com; dgilb...@r

RE: [PATCH] replication: compile out some staff when replication is not configured

2023-04-13 Thread Zhang, Chen
> -Original Message- > From: qemu-devel-bounces+chen.zhang=intel@nongnu.org devel-bounces+chen.zhang=intel@nongnu.org> On Behalf Of Vladimir > Sementsov-Ogievskiy > Sent: Thursday, April 13, 2023 9:47 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc:

RE: [PATCH] replication: compile out some staff when replication is not configured

2023-04-13 Thread Zhang, Chen
nt...@redhat.com; hre...@redhat.com; kw...@redhat.com; Zhang, > Hailiang ; Zhang, Chen > ; lizhij...@fujitsu.com; > wencongya...@huawei.com; xiechanglon...@gmail.com; den- > plotni...@yandex-team.ru; Vladimir Sementsov-Ogievskiy > > Subject: [PATCH] replication:

RE: [PATCH] MAINTAINERS: Remove and change David Gilbert maintainer entries

2023-04-03 Thread Zhang, Chen
intainer entries. > > 'virtiofs' is just the device code now, so is pretty small, and Stefan is > still a > maintainer there. > > 'migration' still has Juan. Reviewed-by: Zhang Chen Thanks for the guidance and help with the migration/HMP/QMP... over the years. Good

RE: [PATCH 00/14] migration/ram.c: Refactor compress code

2023-04-02 Thread Zhang, Chen
> -Original Message- > From: qemu-devel-bounces+chen.zhang=intel@nongnu.org devel-bounces+chen.zhang=intel@nongnu.org> On Behalf Of Lukas > Straub > Sent: Monday, April 3, 2023 1:56 AM > To: qemu-devel > Cc: Dr. David Alan Gilbert ; Juan Quintela > ; Peter Xu > Subject:

RE: [PATCH] vfio/migration: Fix wrong enum usage

2022-10-17 Thread Zhang, Chen
VFIOMigration") > Signed-off-by: Avihai Horon Looks good to me. Reviewed-by: Zhang Chen But I found nowhere using the enum of VFIO migration protocol v2 (vfio_device_mig_state). I don't know more about the background, should we remove the redundancy definition or add full support for th

RE: [PATCH v2] migration/channel-block: fix return value for qio_channel_block_{readv, writev}

2022-10-17 Thread Zhang, Chen
> the call sides. Non-blocking mode is not implemented currently, so -1 it is. > > Signed-off-by: Fiona Ebner LGTM. Reviewed-by: Zhang Chen But I found the same problem elsewhere, for example: "qio_channel_rdma_writev/readv", "qio_channel_buffer_writev/readv"...etc... Ca

RE: [PATCH] tests/qtest/cxl-test: Remove temporary directories after testing

2022-10-17 Thread Zhang, Chen
porary directories after > testing > > The cxl-test leaves some temporary directories behind. Let's clean them up > now! > > Signed-off-by: Thomas Huth LGTM. Reviewed-by: Zhang Chen Thanks Chen > --- > tests/qtest/cxl-test.c | 3 +++ > 1 file changed, 3 insertions(+) >

RE: [PATCH V5] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-22 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Tuesday, August 23, 2022 10:03 AM > To: Zhang, Chen > Cc: Peter Maydell ; Li Zhijian > ; qemu-dev > Subject: Re: [PATCH V5] net/colo.c: Fix the pointer issue reported by > Coverity. > > On Mon, Aug 22, 202

[PATCH V5] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-22 Thread Zhang Chen
misconfiguration here, the vnet_hdr_len is wrong for parse the packet, the data+offset will point to wrong place. Signed-off-by: Zhang Chen --- net/colo.c | 25 - net/colo.h | 1 + net/trace-events | 2 +- 3 files changed, 18 insertions(+), 10 deletions

RE: [PATCH V4 RESEND] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-18 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Thursday, August 18, 2022 4:04 PM > To: Zhang, Chen > Cc: Peter Maydell ; Li Zhijian > ; qemu-dev > Subject: Re: [PATCH V4 RESEND] net/colo.c: Fix the pointer issue reported by > Coverity. > > On Wed, Aug 1

RE: [PATCH V4 RESEND] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-17 Thread Zhang, Chen
Ping Jason and Peter, any comments for this patch? Thanks Chen > -Original Message- > From: Zhang, Chen > Sent: Tuesday, August 9, 2022 4:49 PM > To: Jason Wang ; Peter Maydell > ; Li Zhijian ; qemu-dev > > Cc: Zhang, Chen > Subject: [PATCH V4 RESEND] net

RE: [PATCH V4] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-09 Thread Zhang, Chen
Please review the V4 RESEND version. Thanks Chen > -Original Message- > From: Zhang, Chen > Sent: Tuesday, August 9, 2022 4:45 PM > To: Jason Wang ; Peter Maydell > ; Li Zhijian ; qemu-dev > > Cc: Zhang, Chen > Subject: [PATCH V4] net/colo.c: Fix the pointer is

[PATCH V4 RESEND] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-09 Thread Zhang Chen
misconfiguration here, the vnet_hdr_len is wrong for parse the packet, the data+offset will point to wrong place. Signed-off-by: Zhang Chen --- net/colo.c | 18 ++ net/colo.h | 1 + 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/net/colo.c b/net/colo.c index

[PATCH V4] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-09 Thread Zhang Chen
misconfiguration here, the vnet_hdr_len is wrong for parse the packet, the data+offset will point to wrong place. Signed-off-by: Zhang Chen --- net/colo.c | 18 ++ net/colo.h | 1 + 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/net/colo.c b/net/colo.c index

RE: [PATCH V3] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-09 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Tuesday, August 9, 2022 4:43 PM > To: Zhang, Chen > Cc: Peter Maydell ; Li Zhijian > ; qemu-dev > Subject: Re: [PATCH V3] net/colo.c: Fix the pointer issue reported by > Coverity. > > On Tue, Aug 9, 2022

RE: [PATCH V3] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-09 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Tuesday, August 9, 2022 4:12 PM > To: Zhang, Chen > Cc: Peter Maydell ; Li Zhijian > ; qemu-dev > Subject: Re: [PATCH V3] net/colo.c: Fix the pointer issue reported by > Coverity. > > On Tue, Aug 9, 2022

[PATCH V3] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-08 Thread Zhang Chen
misconfiguration here, the vnet_hdr_len is wrong for parse the packet, the data+offset will point to wrong place. Signed-off-by: Zhang Chen --- net/colo.c | 18 ++ net/colo.h | 1 + 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/net/colo.c b/net/colo.c index

RE: [PATCH V2] net/colo.c: Fix the pointer issuse reported by Coverity.

2022-08-08 Thread Zhang, Chen
> -Original Message- > From: Peter Maydell > Sent: Friday, August 5, 2022 5:57 PM > To: Zhang, Chen > Cc: Jason Wang ; Li Zhijian ; > qemu-dev > Subject: Re: [PATCH V2] net/colo.c: Fix the pointer issuse reported by > Coverity. > > On Fri, 5 Aug 20

[PATCH V2] net/colo.c: Fix the pointer issuse reported by Coverity.

2022-08-05 Thread Zhang Chen
misconfiguration here, the vnet_hdr_len is wrong for parse the packet, the data+offset will point to wrong place. Signed-off-by: Zhang Chen --- net/colo.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/net/colo.c b/net/colo.c index 6b0ff562ad..524afa3d9b 100644

RE: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity.

2022-08-05 Thread Zhang, Chen
> -Original Message- > From: Peter Maydell > Sent: Friday, August 5, 2022 4:53 PM > To: Zhang, Chen > Cc: Jason Wang ; Li Zhijian ; > qemu-dev > Subject: Re: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity. > > On Fri, 5 Aug 2022 a

RE: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity.

2022-08-04 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Friday, August 5, 2022 11:46 AM > To: Zhang, Chen > Cc: Peter Maydell ; Li Zhijian > ; qemu-dev > Subject: Re: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity. > > On Tue, Aug 2, 2022 a

RE: [PATCH 0/1] Update vfio-user module to the latest

2022-08-02 Thread Zhang, Chen
> -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Jagannathan > Raman > Sent: Tuesday, August 2, 2022 9:24 AM > To: qemu-devel@nongnu.org > Cc: stefa...@gmail.com; berra...@redhat.com > Subject: [PATCH 0/1] Update vfio-user module to the

[PATCH] net/colo.c: Fix the pointer issuse reported by Coverity.

2022-08-02 Thread Zhang Chen
misconfiguration here, the vnet_hdr_len is wrong for parse the packet, the data+offset will point to wrong place. Signed-off-by: Zhang Chen --- net/colo.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/net/colo.c b/net/colo.c index 6b0ff562ad..dfb15b4c14 100644

RE: [PULL V2 25/25] net/colo.c: fix segmentation fault when packet is not parsed correctly

2022-07-31 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Monday, August 1, 2022 12:18 PM > To: Zhang, Chen ; Xu, Tao3 > Cc: qemu-devel@nongnu.org; Li Zhijian ; Peter > Maydell > Subject: Re: [PULL V2 25/25] net/colo.c: fix segmentation fault when packet > is not parsed

RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

2022-07-05 Thread Zhang, Chen
> > > > > > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen > wrote: > > > > > > > > > > > > > > If the checkpoint occurs when the guest finishes restarting > > > > > > > but has not started running, the runstate_set

RE: [PATCH] gtk: Add show_tabs=on|off command line option.

2022-07-01 Thread Zhang, Chen
> -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Felix xq > Queißner > Sent: Tuesday, June 28, 2022 12:44 AM > To: qemu-devel@nongnu.org > Cc: kra...@redhat.com; th...@redhat.com; Felix "xq" Queißner > > Subject: [PATCH] gtk: Add

RE: [RFC PATCH 00/12] Introduce QEMU userspace ebpf support

2022-07-01 Thread Zhang, Chen
> -Original Message- > From: Andrew Melnichenko > Sent: Wednesday, June 29, 2022 6:43 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Daniel P. > Berrangé ; Eduardo Habkost > ; Eric Blake ; Markus > Armbruster ; Pe

RE: [PATCH] common-user: Only compile the common user code if have_user is set

2022-06-24 Thread Zhang, Chen
not have an entry in the common-user/host/ folder > (since common-user/meson.build is trying to add such a path via the > include_directories() command). > > Reported-by: Michael Tokarev > Signed-off-by: Thomas Huth Looks good to me. Reviewed-by: Zhang Chen > --- > c

RE: [PATCH 1/1] i386/monitor: Fix page table walking issue for LA57 enabled guest

2022-06-23 Thread Zhang, Chen
pping information was collected from "info > mem" for guest with LA57 enabled. > > Signed-off-by: Yuan Yao LGTM. It should same with the excp_helper.c/mmu_translate() la57 implementation. Reviewed-by: Zhang Chen Add Eric and Markus for double check. Thanks Chen > --- &

RE: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-22 Thread Zhang, Chen
> -Original Message- > From: Daniel P. Berrangé > Sent: Monday, June 20, 2022 6:37 PM > To: Zhang, Chen > Cc: Thomas Huth ; Jason Wang > ; qemu-dev ; Paolo > Bonzini ; Eduardo Habkost ; > Eric Blake ; Markus Armbruster > ; Peter Maydell ; Laurent > Vivier

RE: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-20 Thread Zhang, Chen
> -Original Message- > From: Thomas Huth > Sent: Monday, June 20, 2022 5:44 PM > To: Zhang, Chen ; Daniel P. Berrangé > > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Eduardo > Habkost ; Eric Blake ; Markus > Armbruster ; Peter Maydel

RE: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-20 Thread Zhang, Chen
> -Original Message- > From: Daniel P. Berrangé > Sent: Monday, June 20, 2022 6:01 PM > To: Zhang, Chen > Cc: Thomas Huth ; Jason Wang > ; qemu-dev ; Paolo > Bonzini ; Eduardo Habkost ; > Eric Blake ; Markus Armbruster > ; Peter Maydell ; Laurent > Vivier

RE: [RFC PATCH 08/12] qapi: Add FilterUbpfProperties and qemu-options

2022-06-20 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Monday, June 20, 2022 3:45 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Daniel > P.Berrangé ; Eduardo Habkost > ; Eric Blake ; Peter Maydell > ; Thomas Hut

RE: [RFC PATCH 12/12] test/qtest: Add ubpf basic test case

2022-06-20 Thread Zhang, Chen
> -Original Message- > From: Thomas Huth > Sent: Friday, June 17, 2022 5:34 PM > To: Zhang, Chen ; Jason Wang > ; qemu-dev ; Paolo > Bonzini ; Daniel P. Berrangé > ; Eduardo Habkost ; Eric > Blake ; Markus Armbruster > Cc: Peter Maydell ; Laurent Vivier >

RE: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-20 Thread Zhang, Chen
> -Original Message- > From: Thomas Huth > Sent: Monday, June 20, 2022 4:47 PM > To: Daniel P. Berrangé ; Zhang, Chen > > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Eduardo > Habkost ; Eric Blake ; Markus > Armbruster ; Peter Maydel

RE: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-19 Thread Zhang, Chen
> -Original Message- > From: Daniel P. Berrangé > Sent: Friday, June 17, 2022 4:05 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Eduardo > Habkost ; Eric Blake ; Markus > Armbruster ; Peter Maydell > ; Thomas Hut

[RFC PATCH 12/12] test/qtest: Add ubpf basic test case

2022-06-17 Thread Zhang Chen
will load pre-compiled ebpf binary and run it in QEMU. Signed-off-by: Zhang Chen --- tests/qtest/demo_ubpf.o | Bin 0 -> 544 bytes tests/qtest/integer_5.mem | Bin 0 -> 4 bytes tests/qtest/meson.build | 3 +- tests/qtest/ubpf-test.c | 64 ++ 4 f

[RFC PATCH 11/12] docs/devel: Add userspace-ebpf.rst

2022-06-17 Thread Zhang Chen
Introduce userspace ebpf basic knowledge. Signed-off-by: Zhang Chen --- docs/devel/userspace-ebpf.rst | 106 ++ 1 file changed, 106 insertions(+) create mode 100644 docs/devel/userspace-ebpf.rst diff --git a/docs/devel/userspace-ebpf.rst b/docs/devel/userspace

[RFC PATCH 07/12] net/filter: Introduce filter-ubpf module

2022-06-17 Thread Zhang Chen
The filter-ubpf module able to load user defined ebpf program to handle network packet based on filter framework. Signed-off-by: Zhang Chen --- net/filter-ubpf.c | 149 ++ net/meson.build | 1 + 2 files changed, 150 insertions(+) create mode

[RFC PATCH 08/12] qapi: Add FilterUbpfProperties and qemu-options

2022-06-17 Thread Zhang Chen
Add filter-ubpf related QOM and qemu-options. Signed-off-by: Zhang Chen --- qapi/qom.json | 18 ++ qemu-options.hx | 6 ++ 2 files changed, 24 insertions(+) diff --git a/qapi/qom.json b/qapi/qom.json index 6a653c6636..820a5218e8 100644 --- a/qapi/qom.json +++ b/qapi

[RFC PATCH 05/12] ebpf/uBPF: Add qemu_prepare_ubpf to load ebpf binary

2022-06-17 Thread Zhang Chen
The qemu_prepare_ubpf() can load user defined userspace ebpf binary file to Qemu userspace ebpf VM but not run it. The ebpf program will triggered in the hook point. Signed-off-by: Zhang Chen --- ebpf/ubpf-stub.c | 5 +++ ebpf/ubpf.c | 100

[RFC PATCH 10/12] net/filter-ubpf.c: run the ubpf program to handle network packet

2022-06-17 Thread Zhang Chen
Run the loaded userspace ebpf program with the packet. Signed-off-by: Zhang Chen --- net/filter-ubpf.c | 40 ++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/net/filter-ubpf.c b/net/filter-ubpf.c index c63a021759..554cc24d8f 100644

[RFC PATCH 06/12] ebpf/uBPF: Add qemu_ubpf_run_once excute real ebpf program

2022-06-17 Thread Zhang Chen
Before running this function, we need to ensure that the userspace ebpf program has been loaded correctly. Signed-off-by: Zhang Chen --- ebpf/ubpf-stub.c | 6 ++ ebpf/ubpf.c | 16 ebpf/ubpf.h | 2 ++ 3 files changed, 24 insertions(+) diff --git a/ebpf/ubpf

[RFC PATCH 04/12] ebpf/uBPF: Introduce ubpf initialize functions

2022-06-17 Thread Zhang Chen
Introduce ubpf.c/ubpf-stub.c with basic read and init_jit functions. Add ubpf related .c files to meson.build. Signed-off-by: Zhang Chen --- ebpf/meson.build | 1 + ebpf/ubpf-stub.c | 24 +++ ebpf/ubpf.c | 101 +++ ebpf/ubpf.h

[RFC PATCH 00/12] Introduce QEMU userspace ebpf support

2022-06-17 Thread Zhang Chen
needs strict inspection, but yes, it still need basic check). Any comments are welcome. Thanks Chen Zhang Chen (12): configure: Add iovisor/ubpf project as a submodule for QEMU meson: Add ubpf build config and misc ebpf/uBPF: Introduce userspace ebpf data structure ebpf/uBPF: Introduce ubp

[RFC PATCH 09/12] softmmu/vl.c: Add filter-ubpf for netdev as other netfilters

2022-06-17 Thread Zhang Chen
Signed-off-by: Zhang Chen --- softmmu/vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 4c1e94b00e..d924fb1c71 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -1822,7 +1822,8 @@ static bool object_create_early(const char *type

[RFC PATCH 03/12] ebpf/uBPF: Introduce userspace ebpf data structure

2022-06-17 Thread Zhang Chen
Add ebpf/ubpf.h for the UbpfState. Signed-off-by: Zhang Chen --- ebpf/ubpf.h | 37 + 1 file changed, 37 insertions(+) create mode 100644 ebpf/ubpf.h diff --git a/ebpf/ubpf.h b/ebpf/ubpf.h new file mode 100644 index 00..2562fff503 --- /dev/null +++ b

[RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-17 Thread Zhang Chen
Make iovisor/ubpf project be a git submodule for QEMU. It will auto clone ubpf project when configure QEMU. Signed-off-by: Zhang Chen --- .gitmodules | 3 +++ configure | 20 ubpf| 1 + 3 files changed, 24 insertions(+) create mode 16 ubpf diff --git

[RFC PATCH 02/12] meson: Add ubpf build config and misc

2022-06-17 Thread Zhang Chen
Make meson to build iovisor/ubpf code in Qemu. Signed-off-by: Zhang Chen --- meson.build | 47 + meson_options.txt | 3 ++ scripts/coverity-scan/COMPONENTS.md | 3 ++ scripts/meson-buildoptions.sh | 5 +++ 4 files

RE: [PATCH v7 05/13] multifd: Count the number of bytes sent correctly

2022-06-08 Thread Zhang, Chen
> -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Juan Quintela > Sent: Tuesday, May 31, 2022 6:43 PM > To: qemu-devel@nongnu.org > Cc: Marcel Apfelbaum ; Philippe Mathieu- > Daudé ; Yanan Wang ; Dr. > David Alan Gilbert ; Juan Quintela > ;

RE: [PATCH v7 01/13] multifd: Document the locking of MultiFD{Send/Recv}Params

2022-06-08 Thread Zhang, Chen
> -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Juan Quintela > Sent: Tuesday, May 31, 2022 6:43 PM > To: qemu-devel@nongnu.org > Cc: Marcel Apfelbaum ; Philippe Mathieu- > Daudé ; Yanan Wang ; Dr. > David Alan Gilbert ; Juan Quintela > ;

RE: [PATCH] ebpf: replace deprecated bpf_program__set_socket_filter

2022-05-30 Thread Zhang, Chen
f: replace deprecated bpf_program__set_socket_filter > > bpf_program__set_ functions have been deprecated since libbpf 0.8. > Replace with the equivalent bpf_program__set_type call to avoid a > deprecation warning. > > Signed-off-by: Haochen Tong It looks good to me. By the way, add eBPF maintainers

RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

2022-05-06 Thread Zhang, Chen
> -Original Message- > From: Zhang, Chen > Sent: Wednesday, April 27, 2022 5:26 PM > To: Jason Wang ; Paolo Bonzini > > Cc: Li Zhijian ; qemu-dev de...@nongnu.org>; Like Xu > Subject: RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition > sup

RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

2022-04-27 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Wednesday, April 27, 2022 4:57 PM > To: Zhang, Chen > Cc: Li Zhijian ; qemu-dev de...@nongnu.org>; Like Xu > Subject: Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition > support form COLO to PREL

RE: [PATCH V2 0/4] COLO net and runstate bugfix/optimization

2022-04-13 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Thursday, April 14, 2022 11:12 AM > To: Zhang, Chen > Cc: Li Zhijian ; qemu-dev de...@nongnu.org> > Subject: Re: [PATCH V2 0/4] COLO net and runstate bugfix/optimization > > On Thu, Apr 14, 2022 at 9

RE: [PATCH V2 0/4] COLO net and runstate bugfix/optimization

2022-04-13 Thread Zhang, Chen
No update for a while. Ping... Thanks Chen > -Original Message- > From: Zhang, Chen > Sent: Friday, April 1, 2022 11:47 AM > To: Jason Wang ; Li Zhijian > Cc: Zhang, Chen ; qemu-dev de...@nongnu.org> > Subject: [PATCH V2 0/4] COLO net and runstate bugfix/optimiza

[PATCH V2 4/4] net/colo.c: fix segmentation fault when packet is not parsed correctly

2022-03-31 Thread Zhang Chen
o Xu Signed-off-by: Zhang Chen Reviewed-by: Li Zhijian --- net/colo.c | 9 - net/trace-events | 1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/net/colo.c b/net/colo.c index 694f3c93ef..6b0ff562ad 100644 --- a/net/colo.c +++ b/net/colo.c @@ -46,7 +46,14 @@ int parse_pac

[PATCH V2 3/4] net/colo.c: No need to track conn_list for filter-rewriter

2022-03-31 Thread Zhang Chen
Filter-rewriter no need to track connection in conn_list. This patch fix the glib g_queue_is_empty assertion when COLO guest keep a lot of network connection. Signed-off-by: Zhang Chen Reviewed-by: Li Zhijian --- net/colo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

2022-03-31 Thread Zhang Chen
"RESET", "data": {"guest": true, "reason": "guest-reset"}} qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch' Long-term testing says that it's pretty safe. Signed-off-by: Like Xu Signed-off-by: Zhang Chen --- softmmu/runstate.

[PATCH V2 2/4] net/colo: Fix a "double free" crash to clear the conn_list

2022-03-31 Thread Zhang Chen
onn instance. It will trigger double free in conn_list clear. So this patch remove free action on hash table side to avoid double free the conn. Signed-off-by: Like Xu Signed-off-by: Zhang Chen --- net/colo-compare.c| 2 +- net/filter-rewriter.c | 2 +- 2 files changed, 2 insertions(+), 2 deleti

[PATCH V2 0/4] COLO net and runstate bugfix/optimization

2022-03-31 Thread Zhang Chen
This series fix some COLO related issues in internal stress testing. - V2: - Add more comments in patch 2/4 commit log. Zhang Chen (4): softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH net/colo: Fix a "double free" crash to clear the conn_list

RE: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the conn_list

2022-03-31 Thread Zhang, Chen
> -Original Message- > From: lizhij...@fujitsu.com > Sent: Friday, April 1, 2022 9:47 AM > To: Zhang, Chen ; Jason Wang > > Cc: qemu-dev ; Like Xu > Subject: Re: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the > conn_list > > >

RE: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the conn_list

2022-03-30 Thread Zhang, Chen
> -Original Message- > From: lizhij...@fujitsu.com > Sent: Thursday, March 31, 2022 9:15 AM > To: Zhang, Chen ; Jason Wang > > Cc: qemu-dev ; Like Xu > Subject: Re: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the > conn_l

RE: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the conn_list

2022-03-28 Thread Zhang, Chen
> -Original Message- > From: lizhij...@fujitsu.com > Sent: Monday, March 21, 2022 11:06 AM > To: Zhang, Chen ; Jason Wang > ; lizhij...@fujitsu.com > Cc: qemu-dev ; Like Xu > Subject: Re: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the >

RE: [PATCH] docs/devel/migration.rst: Updates content from code and fixes minor issues

2022-03-09 Thread Zhang, Chen
Ping Thanks Chen > -Original Message- > From: Zhang, Chen > Sent: Thursday, January 27, 2022 6:33 PM > To: Dr. David Alan Gilbert ; Juan Quintela > ; qemu-dev ; qemu- > triv...@nongnu.org > Cc: Zhang, Chen > Subject: [PATCH] docs/devel/migration.rst: U

[PATCH 2/4] net/colo: Fix a "double free" crash to clear the conn_list

2022-03-09 Thread Zhang Chen
t's buggy when other agents try to call connection_get() with the same connection_track_table. Signed-off-by: Like Xu Signed-off-by: Zhang Chen --- net/colo-compare.c| 2 +- net/filter-rewriter.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/colo-compare.c b/net/c

[PATCH 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

2022-03-09 Thread Zhang Chen
"RESET", "data": {"guest": true, "reason": "guest-reset"}} qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch' Long-term testing says that it's pretty safe. Signed-off-by: Like Xu Signed-off-by: Zhang Chen --- softmmu/runstate.

  1   2   3   4   5   6   7   8   9   10   >