When hash table is created with g_hash_table_new_full(),
the free function has been registered. So it isn't necessary
since g_hash_table_remove_all() will call connection_destroy()
for each connection struct automatically.
Signed-off-by: Zhi Yong Wu
---
net/colo.c |6 --
1 files ch
From 4439e5853f98fb4b32f346245a46414d3c7e2221 Mon Sep 17 00:00:00 2001
From: Zhi Yong Wu
Date: Tue, 24 Oct 2017 03:19:00 +0800
Subject: [PATCH] COLO: remove the operation to clear connection list
When hash table is created with g_hash_table_new_full(),
the free function has been registered. So
Tested-by: Zhi Yong Wu
Regards,
Zhi Yong Wu
At 2017-08-10 00:40:57, "Greg Kurz" wrote:
>This function has to ensure it doesn't follow a symlink that could be used
>to escape the virtfs directory. This could be easily achieved if fchmodat()
>on linux honored the AT_
1 is_write 1
addr 880037071240 len 0010 is_write 0
qemu-system-x86_64: virtio: error trying to map MMIO memory
--
Regards,
Zhi Yong Wu
1 is_write 1
addr 880037071240 len 0010 is_write 0
qemu-system-x86_64: virtio: error trying to map MMIO memory
--
Regards,
Zhi Yong Wu
On Tue, May 26, 2015 at 7:13 PM, Paolo Bonzini wrote:
>
>
> On 26/05/2015 13:06, Zhi Yong Wu wrote:
>> HI,
>>
>> Does anyone know why these *.dsl files exist in qemu project? Since
>> these files are used to define some hardware resource and operation
>> met
admin 3490 May 26 10:43 hw/i386/ssdt-pcihp.dsl
-rw-rw-r-- 1 admin admin 2351 May 26 10:43 hw/i386/ssdt-proc.dsl
--
Regards,
Zhi Yong Wu
On Fri, Feb 6, 2015 at 3:54 PM, Zhu Guihua wrote:
> On Tue, 2015-02-03 at 16:41 +0800, Zhi Yong Wu wrote:
>> HI,
>>
>> Can you push the patchset to a branch on github? It will be convenient
>> for other guys to do some tests.
>
> sorry for late reply.
> I had
memory_hotplug.h | 6 +++
> include/hw/acpi/pc-hotplug.h | 2 +
> include/hw/qdev-core.h| 1 +
> 11 files changed, 192 insertions(+), 31 deletions(-)
>
> --
> 1.8.4.2
>
>
--
Regards,
Zhi Yong Wu
lude/hw/cpu/icc_bus.h | 1 +
> include/hw/i386/apic_internal.h | 1 +
> include/hw/qdev-core.h| 1 +
> include/qom/cpu.h | 9
> include/sysemu/kvm.h | 1 +
> kvm-all.c | 57 -
> target-i386/cpu.c | 46
> 19 files changed, 378 insertions(+), 27 deletions(-)
>
> --
> 1.9.3
>
>
--
Regards,
Zhi Yong Wu
> include/hw/acpi/ich9.h | 4
> 5 files changed, 54 insertions(+), 2 deletions(-)
>
> --
> 1.9.3
>
>
--
Regards,
Zhi Yong Wu
On Tue, Sep 30, 2014 at 11:16 PM, Paolo Bonzini wrote:
> Il 30/09/2014 17:09, Zhi Yong Wu ha scritto:
>>> >
>>> > So the problem seems to be with "-Wl,-fstack-protector-all". Where does
>>> > it come from? QEMU or some pkg-config file?
&
On Tue, Sep 30, 2014 at 10:06 PM, Paolo Bonzini wrote:
> Il 30/09/2014 15:57, Zhi Yong Wu ha scritto:
>> libtool --mode=link --tag=CC c++ -m64 -D_GNU_SOURCE
>> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes
>> -Wredundant-decls -Wall -Wundef -Wwrite-strings
-lgthread-2.0 -lglib-2.0 -lrt -lz -luuid -lutil
-Wl,--rpath -Wl,/usr/local/lib
/usr/bin/ld: -f may not be used without -shared
collect2: ld returned 1 exit status
make: *** [vscclient] Error 1
On Tue, Sep 30, 2014 at 5:28 PM, Paolo Bonzini wrote:
> Il 30/09/2014 11:12, Zhi Yong Wu ha scritto:
>
lt LINK libcacard.la
CClibcacard/vscclient.o
lt LINK vscclient
/usr/bin/ld: -f may not be used without -shared
collect2: ld returned 1 exit status
make: *** [vscclient] Error 1
Suguested-by: Paolo Bonzini
Signed-off-by: Zhi Yong Wu
---
Makefile |2 ++
1 files changed, 2 insertions
config:
> [aik@dyn232 ~]$ brctl show
> bridge name bridge id STP enabled interfaces
> brtest 8000.00145e992e88 no pin eth4
>
>
> The ifup.sh script:
> ifconfig $1 hw ether ee:01:02:03:04:05
> /sbin/ifconfig $1 up
> /usr/sbin/brctl addif brtest $1
>
>
>
>
> --
> Alexey
>
--
Regards,
Zhi Yong Wu
On Thu, Dec 12, 2013 at 8:53 PM, Michael S. Tsirkin wrote:
> On Thu, Dec 12, 2013 at 05:01:55PM +0800, Zhi Yong Wu wrote:
>> On Tue, Dec 10, 2013 at 11:23 PM, Kevin Wolf wrote:
>> > Am 10.12.2013 um 16:11 hat Juan Quintela geschrieben:
>> >> Anthony can't assis
;> I can do any of them. Votes for the people that attend?
>> As I guess he commutes everyday, moving the day will not help :p
>
> I prefer 15:00 CET (14:00 UTC).
+1, but it will be perfect if it's 13:00 or 14:00 CET
>
> Kevin
>
--
Regards,
Zhi Yong Wu
From: Zhi Yong Wu
Signed-off-by: Zhi Yong Wu
---
hw/net/virtio-net.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index b75c753..90eca9a 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -1428,7 +1428,7
On Mon, Nov 18, 2013 at 6:15 PM, Michael S. Tsirkin wrote:
> On Mon, Nov 18, 2013 at 06:07:45PM +0800, Zhi Yong Wu wrote:
>> On Mon, Nov 18, 2013 at 5:50 PM, Michael S. Tsirkin wrote:
>> > On Mon, Nov 18, 2013 at 04:46:20PM +0800, Zhi Yong Wu wrote:
>> >> From:
On Mon, Nov 18, 2013 at 5:50 PM, Michael S. Tsirkin wrote:
> On Mon, Nov 18, 2013 at 04:46:20PM +0800, Zhi Yong Wu wrote:
>> From: Zhi Yong Wu
>>
>> It is more appropriate to use # of queue pairs currently used by
>> the driver instead of a magic value.
>>
>
From: Zhi Yong Wu
It is more appropriate to use # of queue pairs currently used by
the driver instead of a magic value.
Signed-off-by: Zhi Yong Wu
---
drivers/net/virtio_net.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net
From: Zhi Yong Wu
Since i did a lot of work to make this feature get merged,
and hope to gain some excercises about how to become a good
maintainer, i'm applying for this role now and hope to get
this chance, thanks.
Signed-off-by: Zhi Yong Wu
---
MAINTAINERS | 8
1 file chang
git\n");
> $printed_novcs = 1;
> }
> return 0;
> diff --git a/scripts/qmp/qemu-ga-client b/scripts/qmp/qemu-ga-client
> index b5f7e7c..9908f21 100755
> --- a/scripts/qmp/qemu-ga-client
> +++ b/scripts/qmp/qemu-ga-client
> @@ -33,7 +33,7 @@
> # $ qemu-ga-client fsfreeze freeze
> # 2 filesystems frozen
> #
> -# See also: http://wiki.qemu.org/Features/QAPI/GuestAgent
> +# See also: http://wiki.qemu-project.org/Features/QAPI/GuestAgent
> #
>
> import base64
> diff --git a/version.rc b/version.rc
> index a50d62f..d42ef62 100644
> --- a/version.rc
> +++ b/version.rc
> @@ -13,7 +13,7 @@ FILESUBTYPE VFT2_UNKNOWN
>{
> BLOCK "040904E4"
> {
> - VALUE "CompanyName", "http://www.qemu.org";
> + VALUE "CompanyName", "http://www.qemu-project.org";
>VALUE "FileDescription", "QEMU machine emulators and tools"
>VALUE "FileVersion", QEMU_VERSION
>VALUE "LegalCopyright", "Copyright various authors. Released under the
> GNU General Public License."
> --
> 1.8.3.1
>
>
--
Regards,
Zhi Yong Wu
Thanks for your pointers, Dor.
On Wed, Sep 18, 2013 at 8:59 PM, Dor Laor wrote:
> On Wed, Sep 18, 2013 at 3:43 PM, Zhi Yong Wu wrote:
>>
>> any doc that describes its archtecture or interval?
>>
>
> You can find some of the design principles here [1] and here [2].
&
Pekka
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Zhi Yong Wu
-monitor_printf(mon, " images:\n");
> -image_info = info->value->inserted->image;
> -while (1) {
> -
> bdrv_image_info_dump((fprintf_function)monitor_printf,
> - mon, image_info);
> -if (image_info->has_backing_image) {
> -image_info = image_info->backing_image;
> -} else {
> -break;
> -}
> +if (verbose) {
> +monitor_printf(mon, "\nImages:\n");
> +image_info = info->value->inserted->image;
> +while (1) {
> +bdrv_image_info_dump((fprintf_function)monitor_printf,
> + mon, image_info);
> +if (image_info->has_backing_image) {
> +image_info = image_info->backing_image;
> +} else {
> +break;
> }
> }
> -} else {
> -monitor_printf(mon, " [not inserted]");
> }
> -
> -monitor_printf(mon, "\n");
> }
>
> qapi_free_BlockInfoList(block_list);
> --
> 1.8.1.4
>
>
--
Regards,
Zhi Yong Wu
drop duplicated slice extension code
> block: clean up I/O throttling wait_time code
>
> block.c | 47
> ---
> blockdev.c| 1 -
> include/block/block_int.h | 3 +--
> 3 files changed, 21 insertions(+), 30 deletions(-)
>
> --
> 1.8.1.4
>
>
--
Regards,
Zhi Yong Wu
On Wed, Mar 27, 2013 at 5:14 PM, Stefan Hajnoczi wrote:
> On Wed, Mar 27, 2013 at 9:50 AM, Zhi Yong Wu wrote:
>> On Thu, Mar 21, 2013 at 10:49 PM, Stefan Hajnoczi
>> wrote:
>>> I/O throttling relies on bdrv_acct_done() which is called when a request
>>> com
[!is_write];
> +memset(&bs->slice_submitted, 0, sizeof(bs->slice_submitted));
> }
>
> elapsed_time = now - bs->slice_start;
> diff --git a/include/block/block_int.h b/include/block/block_int.h
> index ce0aa26..b461764 100644
> --- a/include/block/block_int.h
> +++ b/include/block/block_int.h
> @@ -251,7 +251,7 @@ struct BlockDriverState {
> int64_t slice_start;
> int64_t slice_end;
> BlockIOLimit io_limits;
> -BlockIOBaseValue io_base;
> +BlockIOBaseValue slice_submitted;
> CoQueue throttled_reqs;
> QEMUTimer*block_timer;
> bool io_limits_enabled;
> --
> 1.8.1.4
>
>
--
Regards,
Zhi Yong Wu
On Thu, 2013-03-21 at 10:17 +0100, Stefan Hajnoczi wrote:
> On Thu, Mar 21, 2013 at 09:18:27AM +0800, Zhi Yong Wu wrote:
> > On Wed, 2013-03-20 at 16:12 +0100, Stefan Hajnoczi wrote:
> > > On Wed, Mar 20, 2013 at 03:56:33PM +0100, Benoît Canet wrote:
> > > > &
is expected to
100ms(a assumed value), and is more bigger than current slice_time, I/O
throttling function will not throttle actual I/O speed well. In the
case, slice_time need to be adjusted to one more suitable value which
depends on wait_time.
In some other case that the bare I/O speed is very slow and I/O
throttling speed is fast, slice_time also need to be adjusted
dynamically based on wait_time.
If i remember correctly, it's the reason.
>
> Stefan
>
--
Regards,
Zhi Yong Wu
Reviewed-by: Zhi Yong Wu
On Wed, 2013-03-20 at 10:12 +0100, Benoît Canet wrote:
> This patch fix an I/O throttling behavior triggered by limiting at 150 iops
> and running a load of 50 threads doing random pwrites on a raw virtio device.
>
> After a few moments the iops count start
er_dma(&ns->ide[0], s->dbdma, 0x1a);
> +macio_ide_register_dma(&ns->ide[1], s->dbdma, 0x1a);
> ret = qdev_init(DEVICE(&ns->ide[1]));
> if (ret < 0) {
> return ret;
> --
> 1.7.10.4
>
>
--
Regards,
Zhi Yong Wu
On Tue, Jan 22, 2013 at 2:44 AM, Eric Blake wrote:
> On 01/21/2013 11:35 AM, Zhi Yong Wu wrote:
>> On Mon, Jan 21, 2013 at 10:25 PM, Benoît Canet
>> wrote:
>>>> I don't know if the following case can be handled correctly.
>>>> For example, quorum:2/3:
different images,
how will quorum block filter determine which images are correct while
which aren't?
> That's why one must set each image on a different filer to avoid identical
> corruptions.
Since each image locates on different filer, you can't also make 100%
sure to avoid identical corruptions.
>
> Regards,
>
> Benoīt
--
Regards,
Zhi Yong Wu
gth().
> quorum: Add quorum_invalidate_cache().
> quorum: Add quorum_co_is_allocated.
> quorum: Add quorum_co_flush().
>
> block/Makefile.objs |1 +
> block/blkverify.c | 108 +--
> block/quorum.c| 789
> +++++++++++++
> configure | 22 ++
> include/qemu-common.h |2 +
> util/iov.c| 103 +++
> 6 files changed, 919 insertions(+), 106 deletions(-)
> create mode 100644 block/quorum.c
>
> --
> 1.7.10.4
>
>
--
Regards,
Zhi Yong Wu
d for memory device
>
> Makefile |2 +-
> src/acpi-dsdt-mem-hotplug.dsl | 136 +++
> src/acpi-dsdt.dsl |5 +-
> src/acpi.c| 158
> +++--
> src/paravirt.c|6 ++
> src/paravirt.h|2 +
> src/pciinit.c |9 +++
> src/q35-acpi-dsdt.dsl |6 +-
> src/ssdt-mem.dsl | 73 +++
> tools/acpi_extract.py | 28 +++
> 10 files changed, 415 insertions(+), 10 deletions(-)
> create mode 100644 src/acpi-dsdt-mem-hotplug.dsl
> create mode 100644 src/ssdt-mem.dsl
>
> --
> 1.7.9
>
>
--
Regards,
Zhi Yong Wu
ioport = (IORange *) 0x30d1d5e7400
> #10 0x030b0d5bfb65 in ioport_write (index=0, address=49216, data=8) at
> /home/ports/pobj/qemu-1.3.0-debug/qemu-1.3.0/ioport.c:83
> func = (IOPortWriteFunc *) 0x30b0d5c0148
> default_func = {0x30b0d5bfbbc ,
> 0x30b0d5bfc61 , 0x30b0d5bfd0c }
> #11 0x030b0d5c0704 in cpu_outb (addr=49216, val=8 '\b') at
> /home/ports/pobj/qemu-1.3.0-debug/qemu-1.3.0/ioport.c:289
> No locals.
> #12 0x030b0d6067dd in helper_outb (port=49216, data=8) at
> /home/ports/pobj/qemu-1.3.0-debug/qemu-1.3.0/target-i386/misc_helper.c:72
> No locals.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qemu/+bug/1087114/+subscriptions
>
--
Regards,
Zhi Yong Wu
B Status presentation at KVM Forum 2012 in
> November:
>
> http://www.linux-kvm.org/wiki/images/b/be/2012-forum-qemu-usb-status-update.pdf
>
> Stefan
>
--
Regards,
Zhi Yong Wu
ckr.com/photos/dberrange/ :|
> |: http://libvirt.org -o- http://virt-manager.org :|
> |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
>
--
Regards,
Zhi Yong Wu
t; in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Zhi Yong Wu
nformation Science,
> Academia Sinica, Taiwan (R.O.C.)
> Tel:886-2-2788-3799 #1667
> Homepage: http://people.cs.nctu.edu.tw/~chenwj
>
--
Regards,
Zhi Yong Wu
>> net: Drop vlan argument to qemu_new_net_client()
>> net: Remove vlan code from net.c
>> net: Remove VLANState
>> net: Rename non_vlan_clients to net_clients
>> net: Rename VLANClientState to NetClientState
>> net: Rename vc local variables to nc
&g
ed, 430 insertions(+), 8 deletions(-)
> create mode 100644 hw/vhost-scsi.c
> create mode 100644 hw/vhost-scsi.h
>
> --
> 1.7.2.5
>
> --
> You received this message because you are subscribed to the Google Groups
> "Linux-iSCSI.org Target Development" group.
> To post to this group, send email to linux-iscsi-target-...@googlegroups.com.
> To unsubscribe from this group, send email to
> linux-iscsi-target-dev+unsubscr...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/linux-iscsi-target-dev?hl=en.
>
--
Regards,
Zhi Yong Wu
patchsets. You can see that only some lines of code in most above
files are changed.
On Fri, Jul 20, 2012 at 12:08 AM, Paolo Bonzini wrote:
> Il 19/07/2012 17:57, Zhi Yong Wu ha scritto:
>> qapi/opts-visitor.h | 31
>> qapi/opts-v
log of laszlo's patchset, there seems to be no too much
conflict with my patchset.
On Thu, Jul 19, 2012 at 11:49 PM, Paolo Bonzini wrote:
> Il 19/07/2012 17:48, Zhi Yong Wu ha scritto:
>>>> >> I have been basing work off this series. I'm sending a rebased and
>>
On Thu, Jul 19, 2012 at 11:41 PM, Paolo Bonzini wrote:
> Il 19/07/2012 17:40, Stefan Hajnoczi ha scritto:
>> On Sun, Jun 24, 2012 at 4:11 PM, Zhi Yong Wu wrote:
>>> > pull?
>> I have been basing work off this series. I'm sending a rebased and
>> ret
HI, nab,
On Fri, Jul 13, 2012 at 6:08 AM, Nicholas A. Bellinger
wrote:
> Hi Zhi,
>
> On Thu, 2012-07-12 at 14:59 +0800, Zhi Yong Wu wrote:
>> thanks, it is applied to my vhost_scsi git tree
>> git://github.com/wuzhy/qemu.git vhost-scsi
>>
>
> Thanks for picking
>
> It's currently cut against Zhi's qemu vhost-scsi tree here:
>
>https://github.com/wuzhy/qemu/tree/vhost-scsi
>
> Cc: Stefan Hajnoczi
> Cc: Zhi Yong Wu
> Cc: Paolo Bonzini
> Signed-off-by: Nicholas Bellinger
> ---
> hw/virtio-scsi.c |6 +
>
> It's currently cut against Zhi's qemu vhost-scsi tree here:
>
>https://github.com/wuzhy/qemu/tree/vhost-scsi
>
> Cc: Stefan Hajnoczi
> Cc: Zhi Yong Wu
> Cc: Paolo Bonzini
> Signed-off-by: Nicholas Bellinger
> ---
> hw/virtio-scsi.c |6 +
ts to scan target IDs up to
> VIRTIO_SCSI_MAX_TARGET when connected via virtio-scsi-raw.
>
> It's currently cut against Zhi's qemu vhost-scsi tree here:
>
>https://github.com/wuzhy/qemu/tree/vhost-scsi
>
> Cc: Stefan Hajnoczi
> Cc: Zhi Yong Wu
> Cc: Paolo Bonzini
>
changed, 292 insertions(+), 22 deletions(-)
> create mode 100755 tests/qemu-iotests/039
> create mode 100644 tests/qemu-iotests/039.out
>
> --
> 1.7.10
>
>
--
Regards,
Zhi Yong Wu
pull?
On Wed, Jun 20, 2012 at 5:46 PM, wrote:
> From: Zhi Yong Wu
>
> The patchset is on top of hub-based networking patchset.
>
> For this patchset, my git repo:
>
> g...@github.com:wuzhy/qemu.git for-anthony
>
> Zhi Yong Wu (3):
> net: fix the coding sty
pull?
On Thu, Jun 21, 2012 at 9:14 PM, Stefan Hajnoczi wrote:
> On Wed, Jun 20, 2012 at 10:42 AM, wrote:
>> From: Zhi Yong Wu
>>
>> All comments have been addressed and stefan has completed one more reviewing.
>>
>> For this patchset, my git repo:
>>
On Mon, Jun 18, 2012 at 11:37 PM, Dunrong Huang wrote:
> 2012/6/18 Zhi Yong Wu :
>> HI,
>>
>> When i want to rebase my hub-based network patchset to latest
>> qemu.git/master, i found the build break.
>>
>> lt LINK libcacard.la
>> ar: libcaca
please ignore this. thanks.
On Tue, Jun 19, 2012 at 1:13 AM, wrote:
> From: Zhi Yong Wu
>
> The NetSocketState struct contains two file descriptors: an active
> connection and a listen socket for new connections. It's important that
> we clean up after ourselves so these
HI,
When i want to rebase my hub-based network patchset to latest
qemu.git/master, i found the build break.
lt LINK libcacard.la
ar: libcacard/cac.o: No such file or directory
make[1]: *** [libcacard.la] Error 1
make: *** [subdir-libcacard] Error 2
--
Regards,
Zhi Yong Wu
gt; + unsigned int hub_id;
>> + net_hub_id_for_client(*ptr, &hub_id);
>
> It's unclear what happens if net_hub_id_for_client() fails but it looks
> like hub_id may be uninitialized.
>
> Stefan
>
--
Regards,
Zhi Yong Wu
_stream(VLANState *vlan,
> s = DO_UPCAST(NetSocketState, nc, nc);
>
> s->fd = fd;
> + s->listen_fd = -1;
>
> if (is_connected) {
> net_socket_connect(s);
> @@ -445,6 +458,7 @@ static int net_socket_listen_init(VLANState *vlan,
>
> nc = qemu_new_net_client(&net_socket_info, vlan, NULL, model, name);
> s = DO_UPCAST(NetSocketState, nc, nc);
> + s->fd = -1;
> s->listen_fd = fd;
> s->nc.link_down = true;
>
> --
> 1.7.10
>
>
Reviewed-by: Zhi Yong Wu
--
Regards,
Zhi Yong Wu
On Tue, Jun 12, 2012 at 4:05 AM, Luiz Capitulino wrote:
> On Mon, 11 Jun 2012 22:15:55 +0800
> Zhi Yong Wu wrote:
>
>> On Mon, Jun 11, 2012 at 2:28 PM, Paolo Bonzini wrote:
>> > Il 09/06/2012 05:04, Zhi Yong Wu ha scritto:
>> >>>>> This commit looks
On Mon, Jun 11, 2012 at 10:42 PM, Stefan Hajnoczi wrote:
> On Mon, Jun 11, 2012 at 3:24 PM, Zhi Yong Wu wrote:
>> On Mon, Jun 11, 2012 at 4:57 PM, Stefan Hajnoczi
>> wrote:
>>> On Mon, Jun 11, 2012 at 08:28:57AM +0200, Paolo Bonzini wrote:
>>>> Il 09/0
On Mon, Jun 11, 2012 at 4:57 PM, Stefan Hajnoczi
wrote:
> On Mon, Jun 11, 2012 at 08:28:57AM +0200, Paolo Bonzini wrote:
>> Il 09/06/2012 05:04, Zhi Yong Wu ha scritto:
>> >>>> This commit looks suspicious because it removes a user-visible qdev
>> >>&
On Mon, Jun 11, 2012 at 2:28 PM, Paolo Bonzini wrote:
> Il 09/06/2012 05:04, Zhi Yong Wu ha scritto:
>>>>> This commit looks suspicious because it removes a user-visible qdev
>>>>> property but we're trying to preserve backward compatibilit
On Sat, Jun 9, 2012 at 12:09 AM, Stefan Hajnoczi wrote:
> On Fri, Jun 8, 2012 at 3:48 PM, Zhi Yong Wu wrote:
>> On Fri, Jun 8, 2012 at 9:23 PM, Stefan Hajnoczi wrote:
>>> On Mon, Jun 4, 2012 at 6:29 AM, wrote:
>>>> From: Stefan Hajnoczi
>>>>
>&
On Fri, Jun 8, 2012 at 11:59 PM, Stefan Hajnoczi wrote:
> On Fri, Jun 8, 2012 at 3:54 PM, Zhi Yong Wu wrote:
>> On Fri, Jun 8, 2012 at 6:31 PM, Stefan Hajnoczi wrote:
>>> On Thu, Jun 7, 2012 at 3:54 PM, wrote:
>>>> @@ -86,7 +82,16 @@ static voi
it is zero,
this fd hasn't been registered with every handler. You can see that
"qemu_set_fd_handler(s->fd, NULL, NULL, NULL);" before "s->fd = 0".
>
> Stefan
>
--
Regards,
Zhi Yong Wu
; properties.
>>
>> Signed-off-by: Stefan Hajnoczi
>> Signed-off-by: Zhi Yong Wu
>> ---
>> hw/qdev-properties.c | 72
>> --
>> hw/qdev.c | 2 -
>> hw/qdev.h | 4 ---
>
On Fri, Jun 8, 2012 at 10:20 PM, Stefan Hajnoczi wrote:
> On Fri, Jun 8, 2012 at 3:15 PM, Zhi Yong Wu wrote:
>> On Fri, Jun 8, 2012 at 6:31 PM, Stefan Hajnoczi wrote:
>>> On Thu, Jun 7, 2012 at 3:54 PM, wrote:
>>>> @@ -86,7 +82,16 @@ static voi
On Fri, Jun 8, 2012 at 10:20 PM, Stefan Hajnoczi wrote:
> On Fri, Jun 8, 2012 at 3:15 PM, Zhi Yong Wu wrote:
>> On Fri, Jun 8, 2012 at 6:31 PM, Stefan Hajnoczi wrote:
>>> On Thu, Jun 7, 2012 at 3:54 PM, wrote:
>>>> @@ -86,7 +82,16 @@ static voi
criptor (standard input).
OK. done, but In fact, some other places default fd to zero.
>
> Stefan
>
--
Regards,
Zhi Yong Wu
On Thu, Jun 7, 2012 at 10:16 PM, Paolo Bonzini wrote:
> Il 07/06/2012 14:49, Zhi Yong Wu ha scritto:
>>> > Instead, drop the NetSocketListenState struct and add a listen_fd field
>>> > to NetSocketState. When a -netdev socket,listen= instance is created
>>> &
On Thu, Jun 7, 2012 at 6:08 PM, Stefan Hajnoczi
wrote:
> On Wed, Jun 06, 2012 at 09:26:23PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> The -net socket,listen option does not work with the newer -netdev
>> syntax:
>> http://lists.gnu.or
On Wed, Jun 6, 2012 at 6:32 PM, Stefan Hajnoczi wrote:
> On Fri, Jun 1, 2012 at 9:26 AM, Zhi Yong Wu wrote:
>> On Fri, Jun 1, 2012 at 4:06 PM, Stefan Hajnoczi wrote:
>>> On Fri, Jun 1, 2012 at 6:22 AM, Zhi Yong Wu wrote:
>>>> On Thu, May 31, 2012 at 5:26 PM
e.
>
>
> Those two problems corrupt the dynamicity of a QEMU topology which could be
> strongly problematic for the development of network tools based on QEMU.
>
>
> Thanks a lot.
> Vince
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qemu/+bug/1003054/+subscriptions
>
--
Regards,
Zhi Yong Wu
On Mon, Jun 4, 2012 at 12:51 PM, Anthony Liguori wrote:
> On 06/04/2012 10:46 AM, zwu.ker...@gmail.com wrote:
>>
>> From: Zhi Yong Wu
>>
>> All comments from other guys were addressed.
>
>
> v3 had review comments from Paolo that you acknowledged. I don't
On Sun, Feb 26, 2012 at 10:48 PM, Stefan Hajnoczi wrote:
> On Sat, Feb 18, 2012 at 9:19 AM, wrote:
>> From: Zhi Yong Wu
>>
>> The -net socket,listen option does not work with the newer -netdev
>> syntax:
>> http://lists.gnu.org/archive/html/qemu-devel/2011-
On Fri, Jun 1, 2012 at 4:06 PM, Stefan Hajnoczi wrote:
> On Fri, Jun 1, 2012 at 6:22 AM, Zhi Yong Wu wrote:
>> On Thu, May 31, 2012 at 5:26 PM, Stefan Hajnoczi wrote:
>>> On Wed, May 30, 2012 at 9:31 AM, Zhi Yong Wu wrote:
>>>> On Sat, May 12, 2012 at 12:48
On Thu, May 31, 2012 at 5:26 PM, Stefan Hajnoczi wrote:
> On Wed, May 30, 2012 at 9:31 AM, Zhi Yong Wu wrote:
>> On Sat, May 12, 2012 at 12:48 AM, Kevin Wolf wrote:
>>> A prerequisite for a "QED mode" in qcow2, which doesn't update the refcount
>> Recen
On Thu, May 31, 2012 at 10:16 PM, Jan Kiszka wrote:
> On 2012-05-31 16:10, Zhi Yong Wu wrote:
>> On Thu, May 31, 2012 at 9:48 PM, Jan Kiszka wrote:
>>> On 2012-05-31 15:45, Zhi Yong Wu wrote:
>>>> On Thu, May 31, 2012 at 5:18 PM, Stefan Hajnoczi
>>>>
On Thu, May 31, 2012 at 9:48 PM, Jan Kiszka wrote:
> On 2012-05-31 15:45, Zhi Yong Wu wrote:
>> On Thu, May 31, 2012 at 5:18 PM, Stefan Hajnoczi wrote:
>>> On Wed, May 30, 2012 at 8:59 AM, Luigi Rizzo wrote:
>>>> Hi,
>>>> while investigating rx perfor
On Thu, May 31, 2012 at 9:19 PM, Paolo Bonzini wrote:
> Il 31/05/2012 15:07, Zhi Yong Wu ha scritto:
>> Yeah, this case actually exists, but tcp/ip protocol stack in guest
>> will make sure this ordering will finally be correct.
>
> Nevertheless it's not good, and the
> (re-entrant) qemu_net_queue_send() calls to this queue. We'll be in
If qemu_net_queue_send() are re-entranced, what issue or badness will
it introduce?
I haven't found what issue will take place when queue_flush() is moved
before queue_deliver().
> ->delivering state and queue those packets. After we've finished
> delivering the initial packet we flush the queue.
>
> This is a weird case but this is how I read the intention of the code.
>
> Jan: maybe slirp can do this re-entrant qemu_net_queue_send()?
>
> Stefan
>
--
Regards,
Zhi Yong Wu
d(pkt-B)
> qemu_net_queue_deliver() returns successfully, pkt-B is sent to the
> frontend
> then we call qemu_net_queue_flush() and this sends pkt-B to the
> frontend,
> in the wrong order
>
> cheers
> luigi
>
> --
> -+---
> Prof. Luigi RIZZO, ri...@iet.unipi.it . Dip. di Ing. dell'Informazione
> http://www.iet.unipi.it/~luigi/ . Universita` di Pisa
> TEL +39-050-2211611 . via Diotisalvi 2
> Mobile +39-338-6809875 . 56122 PISA (Italy)
> -+---
>
--
Regards,
Zhi Yong Wu
| 35 ---
> qemu-img.texi | 7 ++++++-
> 12 files changed, 93 insertions(+), 18 deletions(-)
>
> --
> 1.7.6.5
>
>
--
Regards,
Zhi Yong Wu
On Mon, May 28, 2012 at 6:51 PM, Stefan Hajnoczi
wrote:
> On Mon, May 28, 2012 at 03:49:11PM +0800, Zhi Yong Wu wrote:
>> On Sun, Feb 26, 2012 at 10:48 PM, Stefan Hajnoczi wrote:
>> > On Sat, Feb 18, 2012 at 9:19 AM, wrote:
>> >> From: Zhi Yong Wu
>> &g
On Sun, Feb 26, 2012 at 10:48 PM, Stefan Hajnoczi wrote:
> On Sat, Feb 18, 2012 at 9:19 AM, wrote:
>> From: Zhi Yong Wu
>>
>> The -net socket,listen option does not work with the newer -netdev
>> syntax:
>> http://lists.gnu.org/archive/html/qemu-devel/2011-
point we've given it our best shot:
> we already checked that port peers can receive. If they error out now
> there's not much we can do. The packet is dropped for that particular
> peer but at least we tried to deliver it when they claimed to be ready.
Yeah, i think that he is lack of enough understanding on net subsystem
code. He can't see that his thought brought a lot of issues.
>
> Stefan
>
--
Regards,
Zhi Yong Wu
On Fri, May 25, 2012 at 10:50 PM, Jan Kiszka wrote:
> On 2012-05-25 11:44, Zhi Yong Wu wrote:
>> On Fri, May 25, 2012 at 10:40 PM, Jan Kiszka wrote:
>>> On 2012-05-25 11:25, Zhi Yong Wu wrote:
>>>>>> diff --git a/net/hub.c b/net/hub.c
>>>>>>
On Fri, May 25, 2012 at 10:40 PM, Jan Kiszka wrote:
> On 2012-05-25 11:25, Zhi Yong Wu wrote:
>>>> diff --git a/net/hub.c b/net/hub.c
>>>> index 122de69..8c77d03 100644
>>>> --- a/net/hub.c
>>>> +++ b/net/hub.c
>>>> @@ -184,6
On Fri, May 25, 2012 at 10:17 PM, Jan Kiszka wrote:
> On 2012-05-25 11:02, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Reviewed-by: Jan Kiszka
>
> Please don't put reviewed-by tags here before the reviewer had a chance
> to look at the co
On Fri, May 25, 2012 at 9:49 PM, Jan Kiszka wrote:
> On 2012-05-25 09:00, Zhi Yong Wu wrote:
>> On Fri, May 25, 2012 at 4:34 AM, Jan Kiszka wrote:
>>> On 2012-05-24 14:59, zwu.ker...@gmail.com wrote:
>>>> From: Zhi Yong Wu
>>>>
>>>> Signe
On Fri, May 25, 2012 at 4:34 AM, Jan Kiszka wrote:
> On 2012-05-24 14:59, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Signed-off-by: Zhi Yong Wu
>> ---
>> net.c | 7 ++-
>> net/hub.c | 2 +-
>> 2 files changed, 7 insertions(
On Fri, May 25, 2012 at 7:05 PM, Paolo Bonzini wrote:
> Il 25/05/2012 12:52, zwu.ker...@gmail.com ha scritto:
>> From: Zhi Yong Wu
>>
>> Only when all other hub port's *peer* .can_receive() all return 1, the
>> source hub port .can_receive() return 1.
On Fri, May 25, 2012 at 6:08 PM, Paolo Bonzini wrote:
> Il 25/05/2012 09:48, Zhi Yong Wu ha scritto:
>>>> static ssize_t net_hub_receive(NetHub *hub, NetHubPort *source_port,
>>>> const uint8_t *buf, size_t len)
>>
On Fri, May 25, 2012 at 3:04 PM, Paolo Bonzini wrote:
> Il 24/05/2012 19:59, zwu.ker...@gmail.com ha scritto:
>> From: Zhi Yong Wu
>>
>> Signed-off-by: Zhi Yong Wu
>> ---
>> net/hub.c | 35 ---
>> net/hub.h |
On Fri, May 25, 2012 at 3:04 PM, Paolo Bonzini wrote:
> Il 24/05/2012 19:59, zwu.ker...@gmail.com ha scritto:
>> From: Zhi Yong Wu
>>
>> Signed-off-by: Zhi Yong Wu
>> ---
>> net/hub.c | 35 ---
>> net/hub.h |
On Fri, May 25, 2012 at 3:04 PM, Paolo Bonzini wrote:
> Il 24/05/2012 19:59, zwu.ker...@gmail.com ha scritto:
>> From: Zhi Yong Wu
>>
>> Signed-off-by: Zhi Yong Wu
>> ---
>> net/hub.c | 35 ---
>> net/hub.h |
On Fri, May 25, 2012 at 4:34 AM, Jan Kiszka wrote:
> On 2012-05-24 14:59, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> Signed-off-by: Zhi Yong Wu
>> ---
>> net.c | 7 ++-
>> net/hub.c | 2 +-
>> 2 files changed, 7 insertions(
On Fri, May 25, 2012 at 4:53 AM, Luiz Capitulino wrote:
> On Fri, 25 May 2012 01:59:06 +0800
> zwu.ker...@gmail.com wrote:
>
>> From: Zhi Yong Wu
>>
>> The patchset implements network hub stead of vlan. The main work was done by
>> stefan, and i rebased it
1 - 100 of 492 matches
Mail list logo
