Re: [PATCH v7 0/3] vnc: support reload x509 certificates

2021-03-16 Thread Zihao Chang
On 2021/3/16 2:07, Gerd Hoffmann wrote: > On Mon, Mar 15, 2021 at 09:16:06PM +0800, Zihao Chang wrote: >> This series supports reload x509 certificates for vnc >> 1. Support reload x509 certificates. >> 2. Support reload vnc certificates. >> 3. Add new qmp display-

[PATCH v8 2/3] vnc: support reload x509 certificates for vnc

2021-03-16 Thread Zihao Chang
This patch add vnc_display_reload_certs() to support update x509 certificates. Signed-off-by: Zihao Chang Reviewed-by: Daniel P. Berrang?? --- include/ui/console.h | 1 + ui/vnc.c | 28 2 files changed, 29 insertions(+) diff --git a/include/ui

[PATCH v8 3/3] qmp: add new qmp display-reload

2021-03-16 Thread Zihao Chang
This patch provides a new qmp to reload display configuration without restart VM, but only reloading the vnc tls certificates is implemented. Example: {"execute": "display-reload", "arguments":{"type": "vnc", "tls-certs": true

[PATCH v8 1/3] crypto: add reload for QCryptoTLSCredsClass

2021-03-16 Thread Zihao Chang
This patch adds reload interface for QCryptoTLSCredsClass and implements the interface for QCryptoTLSCredsX509. Signed-off-by: Zihao Chang Acked-by: Daniel P. Berrang?? --- crypto/tlscredsx509.c | 48 +++ include/crypto/tlscreds.h | 8 --- 2 files

[PATCH v8 0/3] vnc: support reload x509 certificates

2021-03-16 Thread Zihao Chang
uot;type": "vnc", "tls-certs": true}} Zihao Chang (3): crypto: add reload for QCryptoTLSCredsClass vnc: support reload x509 certificates for vnc qmp: add new qmp display-reload crypto/tlscredsx509.c | 48 ++ include/crypto/tlscreds.h | 8

[PATCH v7 2/3] vnc: support reload x509 certificates for vnc

2021-03-15 Thread Zihao Chang
This patch add vnc_display_reload_certs() to support update x509 certificates. Signed-off-by: Zihao Chang Reviewed-by: Daniel P. Berrang?? --- include/ui/console.h | 1 + ui/vnc.c | 28 2 files changed, 29 insertions(+) diff --git a/include/ui

[PATCH v7 1/3] crypto: add reload for QCryptoTLSCredsClass

2021-03-15 Thread Zihao Chang
This patch adds reload interface for QCryptoTLSCredsClass and implements the interface for QCryptoTLSCredsX509. Signed-off-by: Zihao Chang --- crypto/tlscredsx509.c | 48 +++ include/crypto/tlscreds.h | 8 --- 2 files changed, 53 insertions(+), 3

[PATCH v7 3/3] qmp: add new qmp display-reload

2021-03-15 Thread Zihao Chang
This patch provides a new qmp to reload display configuration without restart VM, but only reloading the vnc tls certificates is implemented. Example: {"execute": "display-reload", "arguments":{"type": "vnc", "tls-certs": tru

[PATCH v7 0/3] vnc: support reload x509 certificates

2021-03-15 Thread Zihao Chang
uot;type": "vnc", "tls-certs": true}} Zihao Chang (3): crypto: add reload for QCryptoTLSCredsClass vnc: support reload x509 certificates for vnc qmp: add new qmp display-reload crypto/tlscredsx509.c | 48 ++ include/crypto/tlscreds.h | 8

[PATCH v6 0/3] vnc: support reload x509 certificates

2021-03-12 Thread Zihao Chang
uot;type": "vnc", "tls-certs": true}} Zihao Chang (3): crypto: add reload for QCryptoTLSCredsClass vnc: support reload x509 certificates for vnc qmp: add new qmp display-reload crypto/tlscredsx509.c | 49 +++ include/crypto/tlscreds.h | 8

[PATCH v6 3/3] qmp: add new qmp display-reload

2021-03-12 Thread Zihao Chang
This patch provides a new qmp to reload display configuration without restart VM, but only reloading the vnc tls certificates is implemented. Example: {"execute": "display-reload", "arguments":{"type": "vnc", "tls-certs": true

[PATCH v6 1/3] crypto: add reload for QCryptoTLSCredsClass

2021-03-12 Thread Zihao Chang
This patch adds reload interface for QCryptoTLSCredsClass and implements the interface for QCryptoTLSCredsX509. Signed-off-by: Zihao Chang --- crypto/tlscredsx509.c | 48 +++ include/crypto/tlscreds.h | 8 --- 2 files changed, 53 insertions(+), 3

[PATCH v6 2/3] vnc: support reload x509 certificates for vnc

2021-03-12 Thread Zihao Chang
This patch add vnc_display_reload_certs() to support update x509 certificates. Signed-off-by: Zihao Chang Reviewed-by: Daniel P. Berrang?? --- include/ui/console.h | 1 + ui/vnc.c | 28 2 files changed, 29 insertions(+) diff --git a/include/ui

Re: [PATCH v4 3/3] qmp: add new qmp display-reload

2021-03-11 Thread Zihao Chang
On 2021/3/9 17:35, Markus Armbruster wrote: > Sorry for the delay, I missed this one. > > Zihao Chang writes: > >> This patch provides a new qmp to reload display configuration >> without restart VM, but only reloading the vnc tls certificates >> is impleme

[PATCH v5 2/3] vnc: support reload x509 certificates for vnc

2021-03-11 Thread Zihao Chang
This patch add vnc_display_reload_certs() to support update x509 certificates. Signed-off-by: Zihao Chang --- include/ui/console.h | 1 + ui/vnc.c | 28 2 files changed, 29 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index

[PATCH v5 3/3] qmp: add new qmp display-reload

2021-03-11 Thread Zihao Chang
This patch provides a new qmp to reload display configuration without restart VM, but only reloading the vnc tls certificates is implemented. Example: {"execute": "display-reload", "arguments":{"vnc-tls-certs": true}} Signed-off-by: Zihao Chang --- mon

[PATCH v5 1/3] crypto: add reload for QCryptoTLSCredsClass

2021-03-11 Thread Zihao Chang
This patch adds reload interface for QCryptoTLSCredsClass and implements the interface for QCryptoTLSCredsX509. Signed-off-by: Zihao Chang --- crypto/tlscredsx509.c | 117 ++ include/crypto/tlscreds.h | 8 ++- 2 files changed, 122 insertions(+), 3

[PATCH v5 0/3] vnc: support reload x509 certificates

2021-03-11 Thread Zihao Chang
This series supports reload x509 certificates for vnc 1. Support reload x509 certificates. 2. Support reload vnc certificates. 3. Add new qmp display-reload and implement reload x509 certificates for vnc. Example: {"execute": "display-reload", "arguments":{"vnc-

Re: [PATCH v4 0/3] vnc: support reload x509 certificates

2021-03-09 Thread Zihao Chang
Ping? Is this patch set being reviewed? Who can help to do this? Thanks Zihao On 2021/2/24 20:34, Zihao Chang wrote: > This series supports reload x509 certificates for vnc > 1. Support reload x509 certificates. > 2. Support reload vnc certificates. > 3. Add new qmp displa

[PATCH v4 1/3] crypto: add reload for QCryptoTLSCredsClass

2021-02-24 Thread Zihao Chang
This patch adds reload interface for QCryptoTLSCredsClass and implements the interface for QCryptoTLSCredsX509. Signed-off-by: Zihao Chang --- crypto/tlscredsx509.c | 117 ++ include/crypto/tlscreds.h | 8 ++- 2 files changed, 122 insertions(+), 3

[PATCH v4 2/3] vnc: support reload x509 certificates for vnc

2021-02-24 Thread Zihao Chang
This patch add vnc_display_reload_certs() to support update x509 certificates. Signed-off-by: Zihao Chang --- include/ui/console.h | 1 + ui/vnc.c | 28 2 files changed, 29 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index

[PATCH v4 3/3] qmp: add new qmp display-reload

2021-02-24 Thread Zihao Chang
This patch provides a new qmp to reload display configuration without restart VM, but only reloading the vnc tls certificates is implemented. Example: {"execute": "display-reload", "arguments":{"vnc-tls-certs": true}} Signed-off-by: Zihao Chang --- mo

[PATCH v4 0/3] vnc: support reload x509 certificates

2021-02-24 Thread Zihao Chang
This series supports reload x509 certificates for vnc 1. Support reload x509 certificates. 2. Support reload vnc certificates. 3. Add new qmp display-reload and implement reload x509 certificates for vnc. Example: {"execute": "display-reload", "arguments":{"vnc-

[PATCH v3 0/3] vnc: support reload x509 certificates

2021-02-06 Thread Zihao Chang
This series supports reload x509 certificates for vnc 1. Support reload x509 certificates. 2. Support reload vnc certificates. 3. Add new qmp display-reload and implement reload x509 certificates for vnc. Example: {"execute": "display-reload", "arguments":{"vnc-

[PATCH v3 3/3] qmp: add new qmp display-reload

2021-02-06 Thread Zihao Chang
This patch provides a new qmp to reload display configuration without restart VM, but only reloading the vnc tls certificates is implemented. Example: {"execute": "display-reload", "arguments":{"vnc-tls-certs": true}} Signed-off-by: Zihao Chang --- mo

[PATCH v3 1/3] crypto: add reload for QCryptoTLSCredsClass

2021-02-06 Thread Zihao Chang
This patch adds reload interface for QCryptoTLSCredsClass and implements the interface for QCryptoTLSCredsX509. Signed-off-by: Zihao Chang --- crypto/tlscredsx509.c | 112 ++ include/crypto/tlscreds.h | 8 ++- 2 files changed, 117 insertions(+), 3

[PATCH v3 2/3] vnc: support reload x509 certificates for vnc

2021-02-06 Thread Zihao Chang
This patch add vnc_display_reload_certs() to support update x509 certificates. Signed-off-by: Zihao Chang --- include/ui/console.h | 1 + ui/vnc.c | 28 2 files changed, 29 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index

Re: [PATCH v2 2/2] vnc: add qmp to support reload vnc tls certificates

2021-01-17 Thread Zihao Chang
On 2021/1/15 21:47, Daniel P. Berrangé wrote: > On Fri, Jan 15, 2021 at 02:37:33PM +0100, Markus Armbruster wrote: >> Zihao Chang writes: >> >>> QEMU loads vnc tls certificates only when vm is started. This patch >>> provides a new qmp to reload vnc tls cer

Re: [PATCH] scsi: allow user to set werror as report

2021-01-11 Thread Zihao Chang
Ping again? Another month has passed, whose tree should it go via? Or did I miss any response? Thanks Zihao On 2020/12/3 17:53, Philippe Mathieu-Daudé wrote: > On 12/3/20 3:55 AM, Zihao Chang wrote: >> Ping? This is a fix patch which has been reviewed, whose tree should it go >>

[PATCH] vnc: fix unfinalized tlscreds for VncDisplay

2021-01-11 Thread Zihao Chang
alized. 2. the qemu_opts of tls-creds(id: creds0) is not deleted, so new tls object with the same id(creds0) can not be delete & add. Signed-off-by: Zihao Chang --- ui/vnc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index 7452ac7df2..69e92b1ef3 10

Re: [PATCH] vnc: add qmp to support change authz

2021-01-07 Thread Zihao Chang
Hi, On 2021/1/8 0:04, Gerd Hoffmann wrote: > Hi, > >> This patch add a new qmp 'change-vnc-authz' to support change the >> tls/sasl authz of vm. If index='', unset tlsauthzid/sasl.authzid >> { >>"execute":"change-vnc-authz", >>"arguments":{ >> "index":"object-authz-id", >> "

[PATCH v2 1/2] crypto: add reload for QCryptoTLSCredsClass

2021-01-07 Thread Zihao Chang
This patch adds reload interface for QCryptoTLSCredsClass and implements the interface for QCryptoTLSCredsX509. Signed-off-by: Zihao Chang --- crypto/tlscredsx509.c | 77 +++ include/crypto/tlscreds.h | 8 ++-- 2 files changed, 82 insertions(+), 3

[PATCH v2 0/2] support tls certificates reload

2021-01-07 Thread Zihao Chang
This patch set implements the reload interface for QCryptoTLSCredsX509 and add qmp to trigger the tls certificates reload. Zihao Chang (2): crypto: add reload for QCryptoTLSCredsClass vnc: add qmp to support reload vnc tls certificates crypto/tlscredsx509.c | 77

[PATCH v2 2/2] vnc: add qmp to support reload vnc tls certificates

2021-01-07 Thread Zihao Chang
QEMU loads vnc tls certificates only when vm is started. This patch provides a new qmp to reload vnc tls certificates without restart vnc-server/VM. {"execute": "reload-vnc-cert"} Signed-off-by: Zihao Chang --- include/ui/console.h | 1 + monitor/qmp-cmds.c | 5

[PATCH] vnc: add qmp to support change authz

2021-01-07 Thread Zihao Chang
This patch add a new qmp 'change-vnc-authz' to support change the tls/sasl authz of vm. If index='', unset tlsauthzid/sasl.authzid { "execute":"change-vnc-authz", "arguments":{ "index":"object-authz-id",

[PATCH] vnc: add qmp to support reload vnc tls certificates

2021-01-03 Thread Zihao Chang
QEMU loads vnc tls certificates only when vm is started. This patch provides a new qmp command to reload vnc tls certificates without restart vnc-server/VM. Signed-off-by: Zihao Chang --- include/ui/console.h | 1 + monitor/qmp-cmds.c | 7 +++ qapi/ui.json | 17

[Question] VNC CA certificate update live

2020-12-28 Thread zihao chang
Hi all:The VNC of QEMU suppots TLS encryption. The client & server can use arbitrary certificates from CA certificates the running VM loaded(user can use new certificates immediately), but if the CA certificate is changed to a new one,the running VM still use the old CA. Is it reasonable to provide

Re: [PULL 13/13] docs/devel/writing-qmp-commands.txt: Fix docs

2020-12-10 Thread Zihao Chang
On 2020/12/11 0:31, Markus Armbruster wrote: > From: Zihao Chang > > Fix the example of add qmp hello-world example. > Without ":", make will report error: > ../qapi/misc.json:573:2: line should end with ':' > > Signed-off-by: Zihao Chang >

Re: [PATCH] scsi: allow user to set werror as report

2020-12-02 Thread Zihao Chang
Ping? This is a fix patch which has been reviewed, whose tree should it go via? Thanks Zihao On 2020/11/3 22:03, Zihao Chang wrote: > > > On 2020/11/3 18:52, Fam Zheng wrote: >> On Tue, 2020-11-03 at 14:12 +0800, Zihao Chang wrote: >>> 'enospc' is the defaul

[PATCH] docs/devel/writing-qmp-commands.txt: Fix docs

2020-12-01 Thread Zihao Chang
Fix the example of add qmp hello-world example. Without ":", make will report error: ../qapi/misc.json:573:2: line should end with ':' Signed-off-by: Zihao Chang --- docs/devel/writing-qmp-commands.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/do

Re: [PATCH] scsi: allow user to set werror as report

2020-11-03 Thread Zihao Chang
On 2020/11/3 18:52, Fam Zheng wrote: > On Tue, 2020-11-03 at 14:12 +0800, Zihao Chang wrote: >> 'enospc' is the default for -drive, but qemu allows user to set >> drive option werror. If werror of scsi-generic is set to 'report' >> by user, qemu wil

[PATCH] scsi: allow user to set werror as report

2020-11-03 Thread Zihao Chang
'enospc' is the default for -drive, but qemu allows user to set drive option werror. If werror of scsi-generic is set to 'report' by user, qemu will not allow vm to start. This patch allow user to set werror as 'report' for scsi-generic. Signed-off-by: Zihao Chan