e_can_write() is true.
>>
>> (use qemu_chr_be_write(), _impl() bypasses replay)
>>
>> Signed-off-by: Marc-André Lureau
>> ---
>> hw/bt/hci-csr.c | 9 +++--
>>
>
> No maintainer for this file. Andrzej, as author of the file, can you
> revi
Hi Yang,
On 26 August 2013 03:47, Yang Ning wrote:
>
> Dear All:
>
> Firstly,I'm writing to express my thanks to Zaborowski for the source code
> of Max7310 which have helped me so much.
> But I'm still confused about the method of reading output port register.
> code:
>>
>>case 0x01: /*
Hi Alex,
On 1 December 2012 20:39, Alex Horn wrote:
> Hello all,
>
> As I have been browsing through QEMU's source code, I've noticed a
> hardware model for a temperature sensor called TMP105. This model
> implements the function tmp105_set(I2CSlave *i2c, int temp) declared
> in i2c.h [0, 1].
>
>
HCI Reset command returns a Command Complete event, not a Command Status
event. We need to avoid resetting the stored last command code for the
response to be fully correct.
Signed-off-by: Andrzej Zaborowski
---
hw/bt-hci.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff
Signed-off-by: Andrzej Zaborowski
---
hw/bt-hci.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/bt-hci.c b/hw/bt-hci.c
index 8c717f9..48cbbb5 100644
--- a/hw/bt-hci.c
+++ b/hw/bt-hci.c
@@ -442,7 +442,7 @@ static inline uint8_t *bt_hci_event_start(struct bt_hci_s
On 11 May 2012 13:16, Peter Maydell wrote:
> On 10 May 2012 01:14, Andreas Färber wrote:
>> Also use cpu_reset() in place of cpu_state_reset().
>>
>> Signed-off-by: Andreas Färber
>
> The pxa2xx stuff is probably going to clash with the cp15
> rework, but I guess we'll sort that out when one or
On 20 April 2012 11:50, Stefan Hajnoczi wrote:
> On Fri, Apr 20, 2012 at 12:21 AM, andrzej zaborowski
> wrote:
>> Yes, controllers would be affected, but there are various ways to go
>> about it. Some could be simple to implement (looking at
>> pxa2xx_mmci.
On 18 April 2012 14:35, Stefan Hajnoczi wrote:
> Recently there have been new SD card emulation patches so I want to
> raise the issue of synchronous I/O while there is focus on the SD
> subsystem. Maybe some of the people who are improving the SD
> subsystem will be able to help.
>
> sd_blk_read
Signed-off-by: Andrzej Zaborowski
---
qemu-options.hx | 24
vl.c| 36
2 files changed, 60 insertions(+), 0 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index b129996..8a5784c 100644
--- a/qemu
r the port access
and open/close the device at every command buffer.
* host cannot know for sure when a guest process has died unexpectedly.
Signed-off-by: Andrzej Zaborowski
---
v2: rebase after QOM.
---
Makefile.target |3 +-
hw/virtio-gl-por
Without that it's impossible to write a virtio-serial port driver that
sends any buffers bigger than a couple kilobytes, other than by
polling to check when space in the queue becomes available.
Signed-off-by: Andrzej Zaborowski
---
v2: rebase after QOM.
---
hw/virtio-serial-bus.c |
On 23 February 2012 09:48, Markus Armbruster wrote:
> andrzej zaborowski writes:
>
>> On 23 February 2012 09:20, Gerd Hoffmann wrote:
>>> $subject says all, which pretty much breaks libvirt-managed qemu ...
>>
>> Also "device_add nonexistent-device"
On 23 February 2012 09:20, Gerd Hoffmann wrote:
> $subject says all, which pretty much breaks libvirt-managed qemu ...
Also "device_add nonexistent-device" in the monitor gives a rather
unhelpful message:
Parameter 'driver' expects device type
Cheers
On 22 February 2012 13:48, Peter Maydell wrote:
> On 22 February 2012 12:13, andrzej zaborowski wrote:
>> On 22 February 2012 13:00, Peter Maydell wrote:
>>> On 22 February 2012 11:36, andrzej zaborowski wrote:
>>>> On 22 February 2012 11:15, Igor Mitsyan
On 22 February 2012 13:26, Mitsyanko Igor wrote:
> On 02/22/2012 03:36 PM, andrzej zaborowski wrote:
>> Why's uint32_t more correct though? The purpose of using a named type
>> across qemu is to mark fields as memory addresses (similar to size_t
>> being used for size
On 22 February 2012 13:00, Peter Maydell wrote:
> On 22 February 2012 11:36, andrzej zaborowski wrote:
>> On 22 February 2012 11:15, Igor Mitsyanko wrote:
>>> Convert three variables in DMAChannel state from type target_phys_addr_t to
>>> uint32_t,
>&g
On 22 February 2012 11:15, Igor Mitsyanko wrote:
> Convert three variables in DMAChannel state from type target_phys_addr_t to
> uint32_t,
> use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables.
> We can do it safely because:
> 1) pxa2xx has 32-bit physical address;
> 2) rest of the c
From: Andrzej Zaborowski
Signed-off-by: Andrzej Zaborowski
---
v2: pass only char *prop_name as qdev_driver_prop_foreach_func parameter,
Anthony noted Property was soon going away.
v3: use QOM.
---
monitor.c | 58 ++
1 files changed
On 20 February 2012 13:12, andrzej zaborowski wrote:
> I have neither of the TRMs at hand but I downloaded the TRM for
> omap35x which features i2c module 3.1 and it looks like the current
Sorry, the revision is not given in the TRM, 3.1 is an example.
Cheers
Hi,
On 17 February 2012 19:21, Peter Maydell wrote:
> I'm looking at cleaning up some more omap3 patches, and have
> been working on the omap_i2c related ones. At the moment in
> omap_i2c.c there are the following #defines for the I2C module
> revision (as exposed via the revision register):
>
>
On 17 February 2012 13:03, Andreas Färber wrote:
> Am 17.02.2012 10:59, schrieb andrzej zaborowski:
>> On 3 February 2012 03:59, Andreas Färber wrote:
>>> No other emulated CPU uses this at this time.
>>
>> But why does this code better fit in hw/ than target-arm
On 3 February 2012 03:59, Andreas Färber wrote:
> No other emulated CPU uses this at this time.
But why does this code better fit in hw/ than target-arm? The iwMMXt
registers are core registers after all.
Also the defines let the board code request a cpu revision by name
instead of using a magi
On 17 February 2012 09:05, Paolo Bonzini wrote:
> On 02/17/2012 08:09 AM, andrzej zaborowski wrote:
>>> > This lets the user specify the desired semantics. By default, the RTC
>>> > will follow adjustments from the host's NTP client. "-rtc clock=vm"
On 8 February 2012 06:41, Peter Maydell wrote:
> Make the "machine" option list use list merging, so that multiple
> -machine arguments (and the -enable-kvm argument) all merge together
> into a single list. Drop the calls to qemu_opts_reset() which meant
> that only the last -machine or -enable-k
On 1 February 2012 18:23, Peter Maydell wrote:
> Since target-arm has some CPUState fields for which we take the approach
> of baking assumptions about them into translated code and then calling
> tb_flush() when the fields change, we must also tb_flush on CPU reset,
> because reset is a change of
On 29 January 2012 08:52, Stefan Weil wrote:
> The parameters initrd_size and base are already included
> in the info parameter, so there is no need to pass them
> separately.
Thanks, applied.
Cheers
On 24 January 2012 20:32, Vasily Khoruzhick wrote:
> Signed-off-by: Vasily Khoruzhick
Thanks, applied this patch.
Cheers
On 7 February 2012 18:56, Peter Maydell wrote:
> The correct FPSID for the Cortex-A9 (according to the TRM) is
> 0x41033090 for the r0p0 that we claim to model.
Thanks, applied this patch.
Cheers
On 20 January 2012 13:06, Paolo Bonzini wrote:
> This lets the user specify the desired semantics. By default, the RTC
> will follow adjustments from the host's NTP client. "-rtc clock=vm" will
> improve determinism with both icount and qtest. Finally, the previous
> behavior is available with
On 20 January 2012 12:10, Paolo Bonzini wrote:
> I noticed some unused code in the twl92230, probably from before
> qdev-ification. This patch makes the machine use the chip's pwrbtn
> signal.
Thanks, applied this patch.
Cheers
On 17 January 2012 12:06, Andreas Färber wrote:
> Am 17.01.2012 00:46, schrieb Andrzej Zaborowski:
>> On 14 January 2012 01:42, Andreas Färber wrote:
>>> Am 08.12.2011 01:41, schrieb Andreas Färber:
>>>> Am 10.11.2011 19:40, schrieb Pavel Borzenkov:
>>>&g
From: Andrzej Zaborowski
Signed-off-by: Andrzej Zaborowski
---
v2: pass only char *prop_name as qdev_driver_prop_foreach_func parameter,
Anthony noted Property was soon going away.
---
hw/qdev.c | 38 ++
hw/qdev.h |7 +++
monitor.c | 41
On 13 January 2012 21:52, Peter Maydell wrote:
> From: Evgeny Voevodin
>
> The secondary CPU bootloader in arm_boot.c holds secondary CPUs in a
> pen until the primary CPU releases them. Make boards specify the
> address to be polled to determine whether to leave the pen (it was
> previously hard
On 16 January 2012 07:48, Evgeny Voevodin wrote:
> Samsung exynos4210 Interrupt Combiner needs 512 IRQ sources.
Thanks, I applied this patch and the second one reviewed by Peter
Maydell. I haven't look at the other patches but on quick glance the
code formatting is still a little off in places.
On 12 January 2012 20:30, Vasily Khoruzhick wrote:
> u-boot uses single automatic scans and polling in
> pxa2xx_keypad driver, so clear KPC_AS bit immediately
> and update keys state even if KPC_AS and KPC_ASACT are
> cleared.
Thanks, applied.
Cheers
On 12 January 2012 20:30, Vasily Khoruzhick wrote:
> Pallete entry size for 16bpp format is 2 bytes, not 4
>
> Signed-off-by: Vasily Khoruzhick
Thanks, applied, (with a style consistency change).
Cheers
On 14 January 2012 01:42, Andreas Färber wrote:
> Am 08.12.2011 01:41, schrieb Andreas Färber:
>> Am 10.11.2011 19:40, schrieb Pavel Borzenkov:
>>> When SDL support is disabled, there is no way to build QEMU without
>>> Cocoa support on MacOS X. This patch adds '--disable-cocoa' switch and
>>> all
On 16 January 2012 09:31, Peter Maydell wrote:
> On 16 January 2012 01:56, Alexander Graf wrote:
>>
>> On 13.01.2012, at 21:52, Peter Maydell wrote:
>>
>>> From: Evgeny Voevodin
>>>
>>> The secondary CPU bootloader in arm_boot.c holds secondary CPUs in a
>>> pen until the primary CPU releases th
On 12 January 2012 11:42, Alon Levy wrote:
> Don't mind at all! But for some reason this email and the other one I
> send before it to you and to the qemu-devel list didn't reach the list.
> If you saw this email is it too much to assume you saw the other one as
> well?
Thanks.
http://lists.nongn
On 10 January 2012 09:35, Stefan Hajnoczi wrote:
> On Mon, Jan 09, 2012 at 06:29:51PM +0100, Stefan Weil wrote:
>> These comments are used by static code analysis tools and in code reviews
>> to avoid false warnings because of missing break statements.
>>
>> The case statements handled here were r
On 10 January 2012 09:44, Alon Levy wrote:
> All but the last are assigned but unused variables,
> and an always true comparison, but the last looks like a logic
> error - decode not returning the actual return value for the last call
> in the buffer (vmgl-exec.c).
> ---
> gl/gloffscreen-xcomposi
Hi,
On 10 January 2012 09:29, Alon Levy wrote:
> On Mon, Jan 09, 2012 at 08:57:50AM +0100, Andrzej Zaborowski wrote:
>> This is the host part of an OpenGL passthrough framework to make apps
>> run faster. It has initially lived on nongnu.org as a separate project
>> by Ev
On 9 January 2012 19:32, Stefan Weil wrote:
> Coverity says that the division by sizeof(*s->rate) might be wrong.
> I think that coverity is right.
Thanks, applied.
Cheers
On 9 January 2012 12:24, Peter Maydell wrote:
> Ping?
>
> (either I forgot to cc you, Andrzej, or the mailing list manager helpfully
> dropped you off the cc list again. Sorry.)
Thank you, now applied. I've been in CC but my patch queue was moving
slow, sorry.
Cheers
On 6 January 2012 19:58, Peter Maydell wrote:
> Fix the sense of the REMAP bit: 0 should mean "map flash",
> 1 should mean "map RAM".
Thanks, applied both patches.
Cheers
On 7 January 2012 12:59, Stefan Hajnoczi wrote:
> The RFBI_READ/RFBI_STATUS code incorrectly uses chip[0] when it should
> be using chip[1]. Andrzej Zaborowski confirmed this
> bug since I don't know this code well.
>
> Reported-by: Dr David Alan Gilbert
> Signed-
On 5 January 2012 15:39, Stefan Weil wrote:
> Coverity complained about local variable key which was only partially
> initiated. Only key.st_value was set. As this was also the only part
> of key which was used in function symfind, the code could be optimized
> by directly passing a pointer to ori
Signed-off-by: Andrzej Zaborowski
---
qemu-options.hx | 24
vl.c| 36
2 files changed, 60 insertions(+), 0 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 7903e5c..f00bb6d 100644
--- a/qemu
r the port access
and open/close the device at every command buffer.
* host cannot know for sure when a guest process has died unexpectedly.
Signed-off-by: Andrzej Zaborowski
---
Makefile.target |3 +-
hw/virtio-gl-port.c | 241 +++
2 files ch
Without that it's impossible to write a virtio-serial port driver that
sends any buffers bigger than a couple kilobytes, other than by
polling to check when space in the queue becomes available.
Signed-off-by: Andrzej Zaborowski
---
hw/virtio-serial-bus.c |8
1 files chang
5340
(Actual authors of each file are listed in the file headers, not
in the Signed-off-by)
Andrzej Zaborowski (6):
gl: Add an OpenGL offscreen rendering API and backends.
gl: Add mesa OpenGL headers.
gl: OpenGL passthrough implementation.
virtio-serial: Call .guest_ready when new space is a
Signed-off-by: Andrzej Zaborowski
---
There are other ways to do this, but adding an API for querying
available qdev drivers was the one that made most sense to me.
---
hw/qdev.c | 38 ++
hw/qdev.h |7 +++
monitor.c | 41
On 8 January 2012 16:14, Andrzej Zaborowski wrote:
> Signed-off-by: Andrzej Zaborowski
> ---
> There are other ways to do this, but adding an API for querying
> available qdev drivers was the one that made most sense to me.
> ---
> hw/qdev.c | 38 ++
Signed-off-by: Andrzej Zaborowski
---
There are other ways to do this, but adding an API for querying
available qdev drivers was the one that made most sense to me.
---
hw/qdev.c | 38 ++
hw/qdev.h |7 +++
monitor.c | 41
Signed-off-by: Andrzej Zaborowski
---
scripts/hxtool |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/scripts/hxtool b/scripts/hxtool
index 995bb7f..a985f5c 100644
--- a/scripts/hxtool
+++ b/scripts/hxtool
@@ -20,6 +20,8 @@ hxtotexi()
{
flag=0
line=1
+echo
Hi,
On 6 January 2012 17:55, Stefan Hajnoczi wrote:
> Is the following code correct in hw/omap_dss.c:
>
> case 0x58: /* RFBI_READ */
> if ((s->rfbi.control & (1 << 2)) && s->rfbi.chip[0])
> s->rfbi.rxbuf = s->rfbi.chip[0]->read(s->rfbi.chip[0]->opaque, 1);
> else if ((s->rfbi.contro
Hi Peter,
On 18 December 2011 21:37, Peter Maydell wrote:
> This patchset fixes a number of bugs in our SD card emulation, mostly
> in the status bit handling. In particular, it fixes the issues raised
> in https://bugs.launchpad.net/qemu/+bug/597641 . The others are things
> I noticed while I wa
On 20 December 2011 17:25, Eric Blake wrote:
> On 12/20/2011 02:15 AM, Wen Congyang wrote:
>> Signed-off-by: Wen Congyang
>> ---
>> Makefile.target | 8 +-
>> dump.c | 452
>> +++
>> dump.h | 4 +
>> hmp-commands.hx |
On 20 December 2011 19:11, Peter Maydell wrote:
> From: Juha Riihimäki
>
> Signed-off-by: Juha Riihimäki
> [Riku Voipio: Fixes and restructuring patchset]
> Signed-off-by: Riku Voipio
> [Peter Maydell: More fixes and cleanups for upstream submission]
> Signed-off-by: Peter Maydell
> ---
> hw
On 7 December 2011 20:06, andrzej zaborowski wrote:
> On 7 December 2011 19:57, Stefan Weil wrote:
>> Am 07.12.2011 08:47, schrieb Andrzej Zaborowski:
>>> +#ifdef NCURSES_VERSION
>>> +# if NCURSES_VERSION_PATCH < 20040117
>>> +# error Old ncurses contain da
On 13 December 2011 19:30, Peter Maydell wrote:
> Current target-arm pending patches; mostly these are Andreas'
> inference series, plus one from Jean-Christophe that's been
> waiting since before the 1.0 release.
>
> Please pull.
Thanks, pulled (and pushed)
Cheers
On 12 December 2011 16:37, Dr. David Alan Gilbert
wrote:
> On ARM, don't map the code buffer at a fixed location, and fix up the
> call/goto tcg routines to let it do long jumps.
>
> Mapping the code buffer at a fixed address could sometimes result in it being
> mapped over the top of the heap wit
On 12 December 2011 19:03, Peter Maydell wrote:
> On 12 December 2011 17:24, andrzej zaborowski wrote:
>> BTW: I think we can also use the "ld" branch when we see the goto
>> target is in Thumb mode.
>
> The target of a goto is currently never Thumb (because
Hi,
On 12 December 2011 16:55, Peter Maydell wrote:
> On 12 December 2011 15:37, Dr. David Alan Gilbert
> wrote:
>> On ARM, don't map the code buffer at a fixed location, and fix up the
>> call/goto tcg routines to let it do long jumps.
>>
>> Mapping the code buffer at a fixed address could some
On 9 December 2011 02:25, andrzej zaborowski wrote:
>>> Cocoa support seems to be broken at the moment, at least on some
>>> MacOS X versions. But qemu builds and runs with SDL.
>>
>> Many times have I asked how to actually use SDL with QEMU on Mac OS X.
>> If
On 7 December 2011 22:12, Andreas Färber wrote:
> Am 07.12.2011 08:47, schrieb Andrzej Zaborowski:
>> Cocoa can only be enabled on Darwin, and is enabled by default too,
>> making --enable-cocoa redundant, with no way to disable Cocoa. It
>> also interfered with SDL supp
On 7 December 2011 19:56, Peter Maydell wrote:
> On 7 December 2011 07:47, Andrzej Zaborowski wrote:
>> Cocoa can only be enabled on Darwin, and is enabled by default too,
>> making --enable-cocoa redundant, with no way to disable Cocoa. It
>> also interfered with SDL supp
On 7 December 2011 19:57, Stefan Weil wrote:
> Am 07.12.2011 08:47, schrieb Andrzej Zaborowski:
>> +#ifdef NCURSES_VERSION
>> +# if NCURSES_VERSION_PATCH < 20040117
>> +# error Old ncurses contain dangerous typedefs, break qemu build (and are
>> old)
>>
Cocoa can only be enabled on Darwin, and is enabled by default too,
making --enable-cocoa redundant, with no way to disable Cocoa. It
also interfered with SDL support in a way that was dependent on
the order of commandline switches.
Signed-off-by: Andrzej Zaborowski
---
Cocoa support seems to
The SDL check is supposed to set $sdl to "yes" or "no", but with that
check it leaves $sdl unset on darwin, unless --enable-cocoa was
specified (which is not needed to enable cocoa anyway).
Signed-off-by: Andrzej Zaborowski
---
configure |4 +---
1 files changed
This should resolve a problem noted by Caraman Mihai Claudiu.
Signed-off-by: Andrzej Zaborowski
---
configure |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/configure b/configure
index 61c43b9..678b982 100755
--- a/configure
+++ b/configure
@@ -1846,6 +1846,11
On 5 December 2011 22:44, Stefan Weil wrote:
> Am 05.12.2011 20:13, schrieb andrzej zaborowski:
>
>> Hi,
>>
>> On 17 November 2011 10:06, Caraman Mihai Claudiu-B02008
>> wrote:
>>>
>>> A recent patch in qemu conflicts with old ncurses libraries (ve
On 1 December 2011 19:37, Peter Maydell wrote:
> Ignore attempts to complete non-existent IRQs; this fixes a buffer
> overrun if the guest writes a bad value to the GICC_EOIR register.
> (This case is UNPREDICTABLE so ignoring it is a valid choice.)
> Note that doing nothing if the guest writes 10
On 30 November 2011 10:57, Peter Maydell wrote:
> Drop the distinction between armv4l/armv4b in the $cpu variable
> (ie host cpu type) in favour of calling everything 'arm'. This
> makes it the same as the ARCH setting and removes some special
> casing. The only thing we were using the distinction
On 29 November 2011 08:41, David Gibson wrote:
> On Tue, Nov 29, 2011 at 05:21:39PM +1100, David Gibson wrote:
>> spapr_populate_pci_devices() containd a loop with PCI_NUM_REGIONS (7)
>> iterations. However this overruns the 'bars' global array, which only has
>> 6 elements. In fact we only want
On 25 November 2011 19:25, Peter Maydell wrote:
> Don't call arm_translate_init() (which allocates TCG resources)
> unless TCG is enabled.
Thanks, applied this patch.
Cheers
On 24 November 2011 19:33, Peter Maydell wrote:
> Clarify some slightly misleading comments in the Thumb decoder's
> handling of the memory hint space -- in particular one code path
> marked as 'UNPREDICTABLE or unallocated hint' also includes some
> legitimate preload instructions.
Thanks, appli
On 22 November 2011 04:20, Peter Chubb wrote:
> Two of the calls to hw_error() in arm_timer.c contain the wrong function name.
>
> As suggested by Andreas Färber, use the C99 standard __func__ macro to
> get the correct name, instead of putting the name directly into the code.
Thanks, applied.
C
Hi,
On 17 November 2011 10:06, Caraman Mihai Claudiu-B02008
wrote:
> A recent patch in qemu conflicts with old ncurses libraries (version 5.3).
> You will see this error cause by bool type redefinition in curses.h (with
> CONFIG_CURSES configured by default):
>
> console.c: In function 'text_co
On 24 November 2011 16:57, Avi Kivity wrote:
> Also add omap_l4_region_size(), since memory API functions need
> the size during initialization.
Logically it should be one of the omap_l4_* functions that set the
size for the region instead of the target agents because this is where
all the memory
ned-off-by: Avi Kivity
Reviewed-by: Andrzej Zaborowski
On 14 November 2011 09:08, Peter Maydell wrote:
> I'm happy that non-rndis works, I tested that. What I don't know
> is whether the patch breaks rndis
Sorry, I misread what you said assuming that you tested a branch
affected by this patch. I'm unable to find a guest to test the rndis
mode so I r
On 20 October 2011 14:53, wrote:
> From: Juha Riihimäki
>
> Make NAND and OneNAND device models reject read-only drives.
> Test for example by running
>
> $ qemu-system-arm -drive if=none,file=/dev/zero,readonly,id=foo -device
> nand,drive=foo,chip_id=0x59 -kernel /dev/null
>
> or
>
> $ qemu-sy
On 6 November 2011 20:14, Jean-Christophe DUBOIS wrote:
> Depending on the considered baseboard the bit used to
> reset the platform is different.
>
> Here is the list of considered Realview/Versatile platforms:
>
> Realview/Versatile AB for ARM926EJ-S: BOARD_ID = 0x100 = BOARD_ID_PB926
> http://i
On 9 November 2011 22:09, Peter Maydell wrote:
> "!X == 2" is always false (spotted by Coverity), so the checks
> for whether rndis is in the correct state would never fire.
I pushed this patch because it's a bugfix and the check is guarded by
is_rndis() so there should be no risk of affecting no
On 13 November 2011 15:18, Peter Maydell wrote:
> Fix an error in commit afd4a6522 which meant that writing a zero
> to the RW bits in the PMCR wouldn't actually clear them. (Error
> spotted by Andrzej Zaborowski.)
>
> Signed-off-by: Peter Maydell
Thanks, pushed.
Cheers
Hi,
On 11 November 2011 20:45, Anthony Liguori wrote:
> On 11/09/2011 02:46 PM, Peter Maydell wrote:
>>
>> Fix a bug in handling the write-one-to-clear bits in the PMCR
>> which meant that we would always clear the bit even if the
>> value written was a zero. Spotted by Coverity (see bug 887883).
from vl.c?
>
> To make things more complicated, it looks like Thiemo Seufer did the
> original mips support, and he passed away. So he can't obviously
> comment.
>
> Anthony asked me to send a patch to the list, asking form comments.
Acked-by: Andrzej Zaborowski
Cheers
On 28 October 2011 11:55, Peter Maydell wrote:
> From: Mathieu Sonet
>
> This driver emulates the ARM AACI interface (PL041) connected to a LM4549
> codec.
> It enables audio playback for the Versatile/PB platform.
Thanks, pushed both changes.
Cheers
On 20 October 2011 16:36, Peter Maydell wrote:
> Hi; these are the pending target-arm patches I'd like to get in for 1.0;
> a couple of minor ones plus the A15 insn work. Please pull.
>
> V2 of this pullreq just adds Andreas' trivial patch as 8/8,
> so I haven't bothered re-emailing the identical
Hi Mathieu,
On 18 October 2011 23:45, Mathieu Sonet wrote:
> This driver emulates the ARM AACI interface (PL041) connected to a LM4549
> codec.
> It enables audio playback for the Versatile/PB platform.
>
> Limitations:
> - Supports only a playback on one channel (Versatile/Vexpress)
> - Supports
On 13 October 2011 19:45, Peter Maydell wrote:
> Don't pass a NULL pointer in to SYS_signalfd in qemu_signalfd_available():
> this isn't valid and Valgrind complains about it.
Also pushed this patch.
Cheers
On 29 September 2011 16:48, Peter Maydell wrote:
> Fix the "-version" option, which was accidentally broken in commit
> fc9c541:
> * exit after printing version information rather than proceeding
> blithely onward (and likely printing the full usage message)
> * correct the cut-n-paste error i
On 18 October 2011 17:12, Peter Maydell wrote:
> The OMAP2430 version of the omap-gpio device has five GPIO modules,
> not four like the other OMAP2 versions; wire up the fifth module's
> IRQ line correctly.
Thanks, pushed this patch.
Cheers
On 20 October 2011 12:48, Dmitry Koshelev wrote:
> irq_target array saving/loading is in the wrong loop.
> Version bump.
>
> Signed-off-by: Dmitry Koshelev
Thanks, pushed this patch.
Cheers
On 18 October 2011 15:03, Anthony Liguori wrote:
> Okay, let's get serious about it. I set up the following wiki page for
> coordination:
>
> http://wiki.qemu.org/Relicensing
The bottom section with "some SVN authors" has a bunch of files by me
that are "GPLv2". Most of them were probably meant
On 17 September 2011 20:51, Peter Maydell wrote:
> Promote the remark about why we handle FIFOTHRESHOLDSTATUS the
> way we do from the commit message of de8af7fe0 to a comment in
> the code.
Thanks, I applied both patches. Looks like any other related patches
are waiting for other events.
Cheer
On 28 August 2011 18:56, Peter Maydell wrote:
> The OMAP3 TRM is inconsistent about whether the GPMC FIFOTHRESHOLDSTATUS
> bit should be set when FIFOPOINTER > FIFOTHRESHOLD or when it is >=
> FIFOTHRESHOLD. Apparently the underlying functional spec from which
> the TRM was created states that the
On 28 August 2011 18:56, Peter Maydell wrote:
> Fix a bug in the handling of writes to GPMC_IRQSTATUS:
> it behaves as "write one to clear, writing zero is ignored".
>
> Signed-off-by: Peter Maydell
> ---
> hw/omap_gpmc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --g
On 31 August 2011 17:55, Peter Maydell wrote:
> Convert omap_intc to use the MemoryRegion API
>
> Signed-off-by: Peter Maydell
> ---
> hw/omap_intc.c | 64 ++-
> 1 files changed, 30 insertions(+), 34 deletions(-)
>
> diff --git a/hw/omap_intc
1 - 100 of 626 matches
Mail list logo
