Re: [PATCH v3 0/9] block-backend: Introduce I/O hang

2020-11-03 Thread cenjiahui
On 2020/10/30 21:21, Stefan Hajnoczi wrote: > On Thu, Oct 29, 2020 at 05:42:42PM +0800, cenjiahui wrote: >> >> On 2020/10/27 0:53, Stefan Hajnoczi wrote: >>> On Thu, Oct 22, 2020 at 09:02:54PM +0800, Jiahui Cen wrote: >>>> A VM in the cloud environment m

Re: [PATCH v3 0/9] block-backend: Introduce I/O hang

2020-10-29 Thread cenjiahui
On 2020/10/27 0:53, Stefan Hajnoczi wrote: > On Thu, Oct 22, 2020 at 09:02:54PM +0800, Jiahui Cen wrote: >> A VM in the cloud environment may use a virutal disk as the backend storage, >> and there are usually filesystems on the virtual block device. When backend >> storage is temporarily down,

Re: [RFC PATCH v2 0/8] block-backend: Introduce I/O hang

2020-10-09 Thread cenjiahui
Hi Kevin, Could you please spend some time reviewing and commenting on this patch series. Thanks, Jiahui Cen On 2020/9/30 17:45, Jiahui Cen wrote: > A VM in the cloud environment may use a virutal disk as the backend storage, > and there are usually filesystems on the virtual block device. When

Re: [RFC PATCH 0/7] block-backend: Introduce I/O hang

2020-09-29 Thread cenjiahui
On 2020/9/28 18:57, Kevin Wolf wrote: > Am 27.09.2020 um 15:04 hat Ying Fang geschrieben: >> A VM in the cloud environment may use a virutal disk as the backend storage, >> and there are usually filesystems on the virtual block device. When backend >> storage is temporarily down, any I/O issued

Re: [PATCH 3/3] migration/multifd: fix potential wrong acception order of IOChannel

2019-10-24 Thread cenjiahui
On 2019/10/24 17:52, Daniel P. Berrangé wrote: > On Wed, Oct 23, 2019 at 11:32:14AM +0800, cenjiahui wrote: >> From: Jiahui Cen >> >> Multifd assumes the migration thread IOChannel is always established before >> the multifd IOChannels, but this assumption will b

[PATCH 1/3] migration/multifd: fix nullptr access in terminating multifd threads

2019-10-22 Thread cenjiahui
From: Jiahui Cen One multifd channel will shutdown all the other multifd's IOChannel when it fails to receive an IOChannel. In this senario, if some multifds had not received its IOChannel yet, it would try to shutdown its IOChannel which could cause nullptr access at qio_channel_shutdown. Here

[PATCH 2/3] migration/multifd: fix destroyed mutex access in terminating multifd threads

2019-10-22 Thread cenjiahui
From: Jiahui Cen One multifd will lock all the other multifds' IOChannel mutex to inform them to quit by setting p->quit or shutting down p->c. In this senario, if some multifds had already been terminated and multifd_load_cleanup/multifd_save_cleanup had destroyed their mutex, it could cause

[PATCH 3/3] migration/multifd: fix potential wrong acception order of IOChannel

2019-10-22 Thread cenjiahui
From: Jiahui Cen Multifd assumes the migration thread IOChannel is always established before the multifd IOChannels, but this assumption will be broken in many situations like network packet loss. For example: Step1: Source (migration thread IOChannel) --SYN--> Destination Step2: Source