Re: [Qemu-devel] [PATCH] audio: Convert use of atoi to qemu_strtoi

On Mon, Mar 19, 2018 at 2:47 PM, Eric Blake wrote: > On 03/16/2018 09:40 AM, Nia Alarie wrote: >> >> If qemu_strtoi indicates an error, return the default value. > > > Would it be better to diagnose the error instead of silently returning a > default value? > >> >>

Re: [Qemu-devel] [PATCH] block/xen_disk: Convert atoi use to qemu_strtol to allow error checking

On Fri, Mar 16, 2018 at 2:43 PM, Nia Alarie wrote: > Signed-off-by: Nia Alarie > --- > hw/block/xen_disk.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c > index

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

On Mon, Mar 12, 2018 at 1:21 PM, Greg Kurz wrote: > On Mon, 12 Mar 2018 13:08:29 + > Daniel P. Berrangé wrote: > >> On Mon, Mar 12, 2018 at 02:02:29PM +0100, Greg Kurz wrote: >> > On Mon, 12 Mar 2018 07:12:52 -0500 >> > Eric Blake

Re: [Qemu-devel] [PATCH v2] 9p: Convert use of atoi to qemu_strtoi to allow error checking

On Mon, Mar 12, 2018 at 3:43 PM, Eric Blake wrote: > On 03/12/2018 10:33 AM, Nia Alarie wrote: >> >> Signed-off-by: Nia Alarie >> --- >> hw/9pfs/9p.c | 11 +-- >> 1 file changed, 9 insertions(+), 2 deletions(-) > > > Helping out our CI tools: >

Re: [Qemu-devel] [PATCH] s390x/virtio: Convert virtio-ccw from *_exit to *_unrealize

On Thu, Mar 8, 2018 at 4:13 PM, Stefan Hajnoczi wrote: > On Wed, Mar 07, 2018 at 04:29:58PM +, Nia Alarie wrote: >> @@ -760,12 +760,12 @@ static int virtio_ccw_exit(VirtioCcwDevice *dev) >> if (sch) { >> css_subch_assign(sch->cssid, sch->ssid, sch->schid,

Re: [Qemu-devel] [PATCH v3 2/2] s390x: Change return type of virtio_ccw_exit to void.

On Tue, Mar 6, 2018 at 2:40 PM, Cornelia Huck wrote: > On Tue, 6 Mar 2018 10:07:21 + > Nia Alarie wrote: > >> Allows a branch to be removed - this function always returns 0. >> >> Signed-off-by: Nia Alarie >> Reviewed-by: