On 05/27/2014 09:40 AM, arei.gong...@huawei.com wrote:
From: Gongleiarei.gong...@huawei.com
Spotted by Coverity:
(7) Event closed_arg: write_dump_pages(DumpState *) closes s-fd. [details]
Also see events: [pass_closed_arg]
1490ret = write_dump_pages(s);
(8) Event cond_false:
On 04/29/2014 02:21 PM, Stefan Weil wrote:
Those options were not enabled by default, even when the build
environment would have supported them, so the corresponding
code was not compiled in normal test builds like on build bots.
Signed-off-by: Stefan Weils...@weilnetz.de
Reviewed-by: Qiao
On 04/23/2014 09:30 PM, Luiz Capitulino wrote:
On Wed, 23 Apr 2014 12:38:12 +0200
Christian Borntraegerborntrae...@de.ibm.com wrote:
On 17/04/14 10:15, Qiao Nuohan wrote:
The last version is here:
http://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg00018.html
ChangLog:
Changes from
On 04/17/2014 04:15 PM, Qiao Nuohan wrote:
The last version is here:
http://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg00018.html
ChangLog:
Changes from v7 to v8:
1. add a patch to fix doc of dump-guest-memory
Qiao Nuohan (2):
HMP: fix doc of dump-guest-memory
HMP: support
On 04/16/2014 04:51 PM, Qiao Nuohan wrote:
The last version is here:
http://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg00018.html
ChangLog:
Changes from v7 to v8:
1. add a patch to fix doc of dump-guest-memory
Qiao Nuohan (2):
HMP: fix doc of dump-guest-memory
HMP: support
ping...
On 04/03/2014 08:16 PM, Christian Borntraeger wrote:
On 01/04/14 15:25, Christian Borntraeger wrote:
On 01/04/14 10:33, Qiao Nuohan wrote:
Dumping guest memory is available to specify the dump format now. This patch
adds options '-z|-l|-s' to HMP command dump-guest-memory to specify
Hello guys,
I have sent the patch, please check here:
http://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg00018.html
On 03/27/2014 04:38 PM, Markus Armbruster wrote:
qiaonuo...@cn.fujitsu.comqiaonuo...@cn.fujitsu.com writes:
On 03/27/2014 01:04 AM, Markus Armbruster wrote:
So
comment: replace reinventing new constants by using the
ready-made ones accoring.
3. Address Andreas's comment: remove useless include.
qiaonuohan (14):
dump: const-qualify the buf of WriteCoreDumpFunction
dump: add argument to write_elfxx_notes
dump: add API to write header of flatten
write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to
vmcore. Adding parameter WriteCoreDumpFunction f makes it available to choose
the method of writing elf notes
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Laszlo Ersek ler...@redhat.com
---
dump.c
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Reviewed-by: Laszlo Ersek ler...@redhat.com
Reviewed-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
---
dump.c |7 +--
target-i386/cpu.h |2 ++
target-s390x/cpu.h |1 +
3 files changed, 8 insertions(+), 2
'query-dump-guest-memory-capability' is used to query the available formats for
'dump-guest-memory'. The output of the command will be like:
- { execute: query-dump-guest-memory-capability }
- { return: { formats:
[elf, kdump-zlib, kdump-lzo, kdump-snappy] }
Signed-off-by:
the functions are used to write header of kdump-compressed format to vmcore.
Header of kdump-compressed format includes:
1. common header: DiskDumpHeader32 / DiskDumpHeader64
2. sub header: KdumpSubHeader32 / KdumpSubHeader64
3. extra information: only elf notes here
Signed-off-by: Qiao Nuohan
the function can be used by write_elf32_notes/write_elf64_notes to write notes
to a buffer. If fd_write_vmcore is used, write_elf32_notes/write_elf64_notes
will write elf notes to vmcore directly. Instead, if buf_write_note is used,
elf notes will be written to opaque-note_buf at first.
functions are used to write 1st and 2nd dump_bitmap of kdump-compressed format,
which is used to indicate whether the corresponded page is existed in vmcore.
1st and 2nd dump_bitmap are same, because dump level is specified to 1 here.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
flatten format will be used when writing kdump-compressed format. The format is
also used by makedumpfile, you can refer to the following URL to get more
detailed information about flatten format of kdump-compressed format:
http://sourceforge.net/projects/makedumpfile/
The two functions here are
WriteCoreDumpFunction is a function pointer that points to the function used to
write content in buf into core file, so buf should be const-qualify.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Laszlo Ersek ler...@redhat.com
---
dump.c|2 +-
include/qom/cpu.h
Function is used to write vmcore in flatten format. In flatten format, data is
written block by block, and in front of each block, a struct
MakedumpfileDataHeader is stored there to indicate the offset and size of the
data block.
struct MakedumpfileDataHeader {
int64_t offset;
int64_t
add some members to DumpState that will be used in writing vmcore in
kdump-compressed format. some of them, like page_size, will be initialized
in the patch.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Laszlo Ersek ler...@redhat.com
---
dump.c| 28
kdump-compressed format supports three compression format, zlib/lzo/snappy.
Currently, only zlib is available. This patch is used to support lzo/snappy.
'--enable-lzo/--enable-snappy' is needed to be specified with configure to make
lzo/snappy available for qemu
Signed-off-by: Qiao Nuohan
Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed
format. The command's usage:
dump [-p] protocol [begin] [length] [format]
'format' is used to specified the format of vmcore and can be:
1. 'elf': ELF format, without compression
2. 'kdump-zlib': kdump-compressed
DataCache is used to store data temporarily, then the data will be written to
vmcore. These functions will be called later when writing data of page to
vmcore.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Laszlo Ersek ler...@redhat.com
---
dump.c| 47
functions are used to write page to vmcore. vmcore is written page by page.
page desc is used to store the information of a page, including a page's size,
offset, compression format, etc.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Laszlo Ersek ler...@redhat.com
---
dump.c
kdump-compressed format supports three compression format, zlib/lzo/snappy.
Currently, only zlib is available. This patch is used to support lzo/snappy.
'--enable-lzo/--enable-snappy' is needed to be specified with configure to make
lzo/snappy available for qemu
Signed-off-by: Qiao Nuohan
flatten format will be used when writing kdump-compressed format. The format is
also used by makedumpfile, you can refer to the following URL to get more
detailed information about flatten format of kdump-compressed format:
http://sourceforge.net/projects/makedumpfile/
The two functions here are
'query-dump-guest-memory-capability' is used to query whether option 'format'
is available for 'dump-guest-memory' and the available format. The output
of the command will be like:
- { execute: query-dump-guest-memory-capability }
- { return: {
format-option: optional,
write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to
vmcore. Adding parameter WriteCoreDumpFunction f makes it available to choose
the method of writing elf notes
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Laszlo Ersek ler...@redhat.com
---
dump.c
the functions are used to write header of kdump-compressed format to vmcore.
Header of kdump-compressed format includes:
1. common header: DiskDumpHeader32 / DiskDumpHeader64
2. sub header: KdumpSubHeader32 / KdumpSubHeader64
3. extra information: only elf notes here
Signed-off-by: Qiao Nuohan
functions are used to write page to vmcore. vmcore is written page by page.
page desc is used to store the information of a page, including a page's size,
offset, compression format, etc.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Laszlo Ersek ler...@redhat.com
---
dump.c
Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed
format. The command's usage:
dump [-p] protocol [begin] [length] [format]
'format' is used to specified the format of vmcore and can be:
1. 'elf': ELF format, without compression
2. 'kdump-zlib': kdump-compressed
Function is used to write vmcore in flatten format. In flatten format, data is
written block by block, and in front of each block, a struct
MakedumpfileDataHeader is stored there to indicate the offset and size of the
data block.
struct MakedumpfileDataHeader {
int64_t offset;
int64_t
DataCache is used to store data temporarily, then the data will be written to
vmcore. These functions will be called later when writing data of page to
vmcore.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Laszlo Ersek ler...@redhat.com
---
dump.c| 47
add some members to DumpState that will be used in writing vmcore in
kdump-compressed format. some of them, like page_size, will be initialized
in the patch.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
---
dump.c| 28
include/sysemu/dump.h
WriteCoreDumpFunction is a function pointer that points to the function used to
write content in buf into core file, so buf should be const-qualify.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Laszlo Ersek ler...@redhat.com
---
dump.c|2 +-
include/qom/cpu.h
the function can be used by write_elf32_notes/write_elf64_notes to write notes
to a buffer. If fd_write_vmcore is used, write_elf32_notes/write_elf64_notes
will write elf notes to vmcore directly. Instead, if buf_write_note is used,
elf notes will be written to opaque-note_buf at first.
functions are used to write 1st and 2nd dump_bitmap of kdump-compressed format,
which is used to indicate whether the corresponded page is existed in vmcore.
1st and 2nd dump_bitmap are same, because dump level is specified to 1 here.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
---
DataCache is used to store data temporarily, then the data will be written to
vmcore. These functions will be called later when writing data of page to
vmcore.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Laszlo Ersek ler...@redhat.com
---
dump.c| 47
functions are used to write page to vmcore. vmcore is written page by page.
page desc is used to store the information of a page, including a page's size,
offset, compression format, etc.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
---
dump.c| 229
Changes from v2 to v3:
1. Address Eric's comment
Changes from v1 to v2:
1. Address Eric Daniel's comment: fix manner of string copy.
2. Address Eric's comment: replace reinventing new constants by using the
ready-made ones accoring.
3. Address Andreas's comment: remove useless include.
qiaonuohan
WriteCoreDumpFunction is a function pointer that points to the function used to
write content in buf into core file, so buf should be const-qualify.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
---
dump.c|2 +-
include/qom/cpu.h |3 ++-
2 files changed, 3
add some members to DumpState that will be used in writing vmcore in
kdump-compressed format. some of them, like page_size, will be initialized
in the patch.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
---
dump.c| 30 ++
kdump-compressed format supports three compression format, zlib/lzo/snappy.
Currently, only zlib is available. This patch is used to support lzo/snappy.
'--enable-lzo/--enable-snappy' is needed to be specified with configure to make
lzo/snappy available for qemu
Signed-off-by: Qiao Nuohan
the function can be used by write_elf32_notes/write_elf64_notes to write notes
to a buffer. If fd_write_vmcore is used, write_elf32_notes/write_elf64_notes
will write elf notes to vmcore directly. Instead, if buf_write_note is used,
elf notes will be written to opaque-note_buf at first.
'query-dump-guest-memory-capability' is used to query whether option 'format'
is available for 'dump-guest-memory' and the available format. The output
of the command will be like:
- { execute: query-dump-guest-memory-capability }
- { return: {
format-option: optional,
write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to
vmcore. Adding parameter WriteCoreDumpFunction f makes it available to choose
the method of writing elf notes
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Laszlo Ersek ler...@redhat.com
---
dump.c
flatten format will be used when writing kdump-compressed format. The format is
also used by makedumpfile, you can refer to the following URL to get more
detailed information about flatten format of kdump-compressed format:
http://sourceforge.net/projects/makedumpfile/
The two functions here are
the functions are used to write header of kdump-compressed format to vmcore.
Header of kdump-compressed format includes:
1. common header: DiskDumpHeader32 / DiskDumpHeader64
2. sub header: KdumpSubHeader32 / KdumpSubHeader64
3. extra information: only elf notes here
Signed-off-by: Qiao Nuohan
Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed
format. The command's usage:
dump [-p] protocol [begin] [length] [format]
'format' is used to specified the format of vmcore and can be:
1. 'elf': ELF format, without compression
2. 'kdump-zlib': kdump-compressed
Function is used to write vmcore in flatten format. In flatten format, data is
written block by block, and in front of each block, a struct
MakedumpfileDataHeader is stored there to indicate the offset and size of the
data block.
struct MakedumpfileDataHeader {
int64_t offset;
int64_t
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Hi, all
The last version is here:
http://lists.gnu.org/archive/html/qemu-devel/2013-05/msg02280.html
Command 'dump-guest-memory' was introduced to dump guest's memory. But the
vmcore's format is only elf32 or elf64. The message is here:
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Move definition of struct DumpState into include/sysemu/dump_memory.h.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com
---
dump.c | 22 +-
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Struct dump_bitmap is associated with a tmp file which is used to store bitmap
in kdump-compressed format temporarily. The following patch will use these
functions to gather data of bitmap and cache them into tmp files.
Signed-off-by: Qiao Nuohan
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Functions in this patch are used to gather data of 1st and 2nd dump bitmap in
kdump-compressed format. The following patch will use these functions to gather
data of dump bitmap, then cache them into tmp files.
Signed-off-by: Qiao Nuohan
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
The following patch will use these functions to write cached data into vmcore.
Header is cached in DumpState, and bitmap and page are cached in tmp files.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Zhang Xiaohe
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
When calling create_header, create_dump_bitmap and create_pages, some memory
spaces are allocated. The following patch will use this function to free these
memory.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Zhang Xiaohe
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Functions in this patch are used to gather data of header and sub header in
kdump-compressed format. The following patch will use these functions to gather
data of header, then cache them into struct DumpState.
Signed-off-by: Qiao Nuohan
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Struct cache_data is associated with a tmp file which is used to store page
desc and page data in kdump-compressed format temporarily. The following patch
will use these function to gather data of page and cache them in tmp files.
Signed-off-by: Qiao
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Functions in this patch are used to gather data of page desc and page data in
kdump-compressed format. The following patch will use these functions to gather
data of page, then cache them into tmp files
Signed-off-by: Qiao Nuohan
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed
format. The command's usage:
dump [-p] protocol [begin] [length] [format]
'format' is used to specified the format of vmcore and can be:
1. 'elf': ELF format, without
Sorry, the cc list is wrong, I will resend the mails.
-Original Message-
From: qiaonuo...@cn.fujitsu.com [mailto:qiaonuo...@cn.fujitsu.com]
Sent: Wednesday, May 08, 2013 9:54 AM
To: qemu-devel@nongnu.org
Cc:
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Hi, all
The last version is here:
http://lists.gnu.org/archive/html/qemu-devel/2013-05/msg00803.html
Command 'dump-guest-memory' was introduced to dump guest's memory. But the
vmcore's format is only elf32 or elf64. The message is here:
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Struct dump_bitmap is associated with a tmp file, and the tmp file can be used
to save data of page desc and page data in kdump-compressed format temporarily.
The following patch will use these function to get the data of page desc and
page data and
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Move includes and definition of struct DumpState into include/sysemu/dump.h.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com
---
dump.c| 29 -
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Struct dump_bitmap is associated with a tmp file, and the tmp file can be used
to save data of bitmap in kdump-compressed format temporarily.
The following patch will use these functions to get the data of bitmap and cache
them into tmp files.
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Add API to get data of page desc and page data and save them into tmp files.
The following patch will use these functions to gather data of page desc and
page data, then write them into vmcore
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
The following patch will use these functions to write cached data into vmcore.
Header is cached in DumpState, and bitmap and page are cached in tmp files.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Zhang Xiaohe
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Make monitor command 'dump-guest-memory' dump in kdump-compressed format.
The command's usage:
dump [-p] protocol [begin] [length] [format]
'format' is used to specified the format of vmcore and can be:
1. 'elf': ELF format, without compression
2.
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Add API to get data of the 1st and 2nd dump bitmap and save them into tmp files.
The following patch will use these functions to gather data of dump bitmap,
then write them into vmcore.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by:
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Add API to create header, sub header of vmcore in kdump-compressed format.
The data is store in struct DumpState.
The following patch will use this function to gather data of header, then
write them into vmcore.
Signed-off-by: Qiao Nuohan
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
When calling create_header, create_dump_bitmap and create_pages, some memory
spaces
are allocated. The following patch will use this function to free these spaces.
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
Reviewed-by: Zhang Xiaohe
From: Qiao Nuohan qiaonuo...@cn.fujitsu.com
This patch is used to remove twice include of qemu-common.h in
block/win32-aio.c
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com
---
block/win32-aio.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/block/win32-aio.c
-Original Message-
From: Eric Blake [mailto:ebl...@redhat.com]
Sent: Wednesday, May 08, 2013 12:14 AM
To: Qiao Nuohan
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/9] Add API to manipulate dump_bitmap
On 05/07/2013 01:16 AM, Qiao Nuohan wrote:
Struct dump_bitmap
-Original Message-
From: Eric Blake [mailto:ebl...@redhat.com]
Sent: Wednesday, May 08, 2013 1:13 AM
To: Qiao Nuohan
Cc: qemu-devel@nongnu.org; Zhang Xiaohe
Subject: Re: [Qemu-devel] [PATCH 9/9] Make monitor command 'dump-guest-memory'
dump in kdump-compressed format
+
72 matches
Mail list logo
