Re: [PATCH] Makefile: add missing mkdir MANUAL_BUILDDIR
On Tue, 21 Jan 2020 at 11:06, Miroslav Rezanina wrote: > > On Mon, Jan 20, 2020 at 04:34:00PM +, Stefan Hajnoczi wrote: > > The MANUAL_BUILDDIR directory is automatically created by sphinx-build > > for the other targets. The index.html target does not use sphinx-build > > so we must manually create the directory to avoid the following error: > > > > GEN docs/built/index.html > > /bin/sh: docs/built/index.html: No such file or directory > > > > Signed-off-by: Stefan Hajnoczi > > --- > > Makefile | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Makefile b/Makefile > > index afa5cb6548..6562b0dc97 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -1022,6 +1022,7 @@ $(MANUAL_BUILDDIR)/interop/qemu-ga.8: $(call > > manual-deps,interop) > > $(call build-manual,interop,man) > > > > $(MANUAL_BUILDDIR)/index.html: $(SRC_PATH)/docs/index.html.in > > qemu-version.h > > + @mkdir -p "$(MANUAL_BUILDDIR)" > > $(call quiet-command, sed "s|@@VERSION@@|${VERSION}|g" $< >$@, \ > > "GEN","$@") > > > > -- > > 2.24.1 > > > > Fixing our issues with build, > > Reviewed-by: Miroslav Rezanina Thanks; applied to master as a build-fix. -- PMM
Re: [PATCH] Makefile: add missing mkdir MANUAL_BUILDDIR
On Mon, Jan 20, 2020 at 04:34:00PM +, Stefan Hajnoczi wrote: > The MANUAL_BUILDDIR directory is automatically created by sphinx-build > for the other targets. The index.html target does not use sphinx-build > so we must manually create the directory to avoid the following error: > > GEN docs/built/index.html > /bin/sh: docs/built/index.html: No such file or directory > > Signed-off-by: Stefan Hajnoczi > --- > Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Makefile b/Makefile > index afa5cb6548..6562b0dc97 100644 > --- a/Makefile > +++ b/Makefile > @@ -1022,6 +1022,7 @@ $(MANUAL_BUILDDIR)/interop/qemu-ga.8: $(call > manual-deps,interop) > $(call build-manual,interop,man) > > $(MANUAL_BUILDDIR)/index.html: $(SRC_PATH)/docs/index.html.in qemu-version.h > + @mkdir -p "$(MANUAL_BUILDDIR)" > $(call quiet-command, sed "s|@@VERSION@@|${VERSION}|g" $< >$@, \ > "GEN","$@") > > -- > 2.24.1 > Fixing our issues with build, Reviewed-by: Miroslav Rezanina
[PATCH] Makefile: add missing mkdir MANUAL_BUILDDIR
The MANUAL_BUILDDIR directory is automatically created by sphinx-build for the other targets. The index.html target does not use sphinx-build so we must manually create the directory to avoid the following error: GEN docs/built/index.html /bin/sh: docs/built/index.html: No such file or directory Signed-off-by: Stefan Hajnoczi --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index afa5cb6548..6562b0dc97 100644 --- a/Makefile +++ b/Makefile @@ -1022,6 +1022,7 @@ $(MANUAL_BUILDDIR)/interop/qemu-ga.8: $(call manual-deps,interop) $(call build-manual,interop,man) $(MANUAL_BUILDDIR)/index.html: $(SRC_PATH)/docs/index.html.in qemu-version.h + @mkdir -p "$(MANUAL_BUILDDIR)" $(call quiet-command, sed "s|@@VERSION@@|${VERSION}|g" $< >$@, \ "GEN","$@") -- 2.24.1