Re: [PATCH] qtest: bios-tables-test: fix a memory leak

[Igor Mammedov]

On Tue, 14 Jul 2020 08:35:36 -0700
Li Qiang  wrote:

> Fixes: 5da7c35e25a("bios-tables-test: Add Q35/TPM-TIS test")
> Signed-off-by: Li Qiang 

Reviewed-by: Igor Mammedov 

> ---
>  tests/qtest/bios-tables-test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index c315156858..d49b3988ec 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -924,6 +924,7 @@ static void test_acpi_tcg_tpm(const char *machine, const 
> char *tpm_if,
>  g_free(variant);
>  g_free(tmp_path);
>  g_free(tmp_dir_name);
> +g_free(args);
>  free_test_data();
>  #else
>  g_test_skip("TPM disabled");

Re: [PATCH] qtest: bios-tables-test: fix a memory leak

[Auger Eric]

Hi Li,

On 7/14/20 5:35 PM, Li Qiang wrote:
> Fixes: 5da7c35e25a("bios-tables-test: Add Q35/TPM-TIS test")
> Signed-off-by: Li Qiang 
> ---
>  tests/qtest/bios-tables-test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index c315156858..d49b3988ec 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -924,6 +924,7 @@ static void test_acpi_tcg_tpm(const char *machine, const 
> char *tpm_if,
>  g_free(variant);
>  g_free(tmp_path);
>  g_free(tmp_dir_name);
> +g_free(args);
>  free_test_data();
>  #else
>  g_test_skip("TPM disabled");
> 
Reviewed-by: Eric Auger 

Thanks!

Eric

[PATCH] qtest: bios-tables-test: fix a memory leak

[Li Qiang]

Fixes: 5da7c35e25a("bios-tables-test: Add Q35/TPM-TIS test")
Signed-off-by: Li Qiang 
---
 tests/qtest/bios-tables-test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index c315156858..d49b3988ec 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -924,6 +924,7 @@ static void test_acpi_tcg_tpm(const char *machine, const 
char *tpm_if,
 g_free(variant);
 g_free(tmp_path);
 g_free(tmp_dir_name);
+g_free(args);
 free_test_data();
 #else
 g_test_skip("TPM disabled");
-- 
2.17.1