Re: [PATCH] virtio-pci: Fix the failure process in kvm_virtio_pci_vector_use_one()

2024-04-18 Thread Cindy Lu
On Wed, Apr 17, 2024 at 2:38 AM Michael S. Tsirkin wrote: > > On Tue, Apr 16, 2024 at 02:14:57PM +0100, Peter Maydell wrote: > > On Tue, 16 Apr 2024 at 13:41, Cindy Lu wrote: > > > > > > On Tue, Apr 16, 2024 at 8:30 PM Peter Maydell > > > wrote: > > > > > > > > On Tue, 16 Apr 2024 at 13:29,

Re: [PATCH] virtio-pci: Fix the failure process in kvm_virtio_pci_vector_use_one()

2024-04-16 Thread Michael S. Tsirkin
On Tue, Apr 16, 2024 at 02:14:57PM +0100, Peter Maydell wrote: > On Tue, 16 Apr 2024 at 13:41, Cindy Lu wrote: > > > > On Tue, Apr 16, 2024 at 8:30 PM Peter Maydell > > wrote: > > > > > > On Tue, 16 Apr 2024 at 13:29, Cindy Lu wrote: > > > > > > > > In function kvm_virtio_pci_vector_use_one(),

Re: [PATCH] virtio-pci: Fix the failure process in kvm_virtio_pci_vector_use_one()

2024-04-16 Thread Peter Maydell
On Tue, 16 Apr 2024 at 13:41, Cindy Lu wrote: > > On Tue, Apr 16, 2024 at 8:30 PM Peter Maydell > wrote: > > > > On Tue, 16 Apr 2024 at 13:29, Cindy Lu wrote: > > > > > > In function kvm_virtio_pci_vector_use_one(), in the undo label, > > > the function will get the vector incorrectly while

Re: [PATCH] virtio-pci: Fix the failure process in kvm_virtio_pci_vector_use_one()

2024-04-16 Thread Cindy Lu
On Tue, Apr 16, 2024 at 8:30 PM Peter Maydell wrote: > > On Tue, 16 Apr 2024 at 13:29, Cindy Lu wrote: > > > > In function kvm_virtio_pci_vector_use_one(), in the undo label, > > the function will get the vector incorrectly while using > > VIRTIO_CONFIG_IRQ_IDX > > To fix this, we remove this

Re: [PATCH] virtio-pci: Fix the failure process in kvm_virtio_pci_vector_use_one()

2024-04-16 Thread Peter Maydell
On Tue, 16 Apr 2024 at 13:29, Cindy Lu wrote: > > In function kvm_virtio_pci_vector_use_one(), in the undo label, > the function will get the vector incorrectly while using > VIRTIO_CONFIG_IRQ_IDX > To fix this, we remove this label and simplify the failure process > > Fixes: f9a09ca3ea ("vhost:

[PATCH] virtio-pci: Fix the failure process in kvm_virtio_pci_vector_use_one()

2024-04-16 Thread Cindy Lu
In function kvm_virtio_pci_vector_use_one(), in the undo label, the function will get the vector incorrectly while using VIRTIO_CONFIG_IRQ_IDX To fix this, we remove this label and simplify the failure process Fixes: f9a09ca3ea ("vhost: add support for configure interrupt") Cc: