Re: [PATCH RFC 4/5] cpu: Allow cpu_synchronize_all_post_init() to take an errp

2022-06-13 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Jun 09, 2022 at 05:02:29PM -0400, Peter Xu wrote: > > On Wed, Jun 08, 2022 at 06:05:28PM +0100, Dr. David Alan Gilbert wrote: > > > > @@ -2005,7 +2005,17 @@ static void loadvm_postcopy_handle_run_bh(void > > > > *opaque) > > > > /* TODO we

Re: [PATCH RFC 4/5] cpu: Allow cpu_synchronize_all_post_init() to take an errp

2022-06-10 Thread Peter Xu
On Thu, Jun 09, 2022 at 05:02:29PM -0400, Peter Xu wrote: > On Wed, Jun 08, 2022 at 06:05:28PM +0100, Dr. David Alan Gilbert wrote: > > > @@ -2005,7 +2005,17 @@ static void loadvm_postcopy_handle_run_bh(void > > > *opaque) > > > /* TODO we should move all of this lot into postcopy_ram.c or a

Re: [PATCH RFC 4/5] cpu: Allow cpu_synchronize_all_post_init() to take an errp

2022-06-09 Thread Peter Xu
On Wed, Jun 08, 2022 at 06:05:28PM +0100, Dr. David Alan Gilbert wrote: > > @@ -2005,7 +2005,17 @@ static void loadvm_postcopy_handle_run_bh(void > > *opaque) > > /* TODO we should move all of this lot into postcopy_ram.c or a shared > > code > > * in migration.c > > */ > > -

Re: [PATCH RFC 4/5] cpu: Allow cpu_synchronize_all_post_init() to take an errp

2022-06-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Allow cpu_synchronize_all_post_init() to fail with an errp when it's set. > Modify both precopy and postcopy to try to detect such error. > > Signed-off-by: Peter Xu > --- > hw/core/machine.c | 2 +- > include/sysemu/cpus.h | 2 +- >

[PATCH RFC 4/5] cpu: Allow cpu_synchronize_all_post_init() to take an errp

2022-06-07 Thread Peter Xu
Allow cpu_synchronize_all_post_init() to fail with an errp when it's set. Modify both precopy and postcopy to try to detect such error. Signed-off-by: Peter Xu --- hw/core/machine.c | 2 +- include/sysemu/cpus.h | 2 +- migration/savevm.c| 20 +--- softmmu/cpus.c