Re: [PATCH v12 09/13] virtio-iommu: Implement fault reporting

2020-01-15 Thread Auger Eric
Hi Peter, On 1/15/20 4:04 PM, Peter Xu wrote: > On Wed, Jan 15, 2020 at 02:12:20PM +0100, Auger Eric wrote: +static void virtio_iommu_report_fault(VirtIOIOMMU *viommu, uint8_t reason, + int flags, uint32_t endpoint, +

Re: [PATCH v12 09/13] virtio-iommu: Implement fault reporting

2020-01-15 Thread Peter Xu
On Wed, Jan 15, 2020 at 02:12:20PM +0100, Auger Eric wrote: > >> +static void virtio_iommu_report_fault(VirtIOIOMMU *viommu, uint8_t reason, > >> + int flags, uint32_t endpoint, > >> + uint64_t address) > >> +{ [...] > >>

Re: [PATCH v12 09/13] virtio-iommu: Implement fault reporting

2020-01-15 Thread Auger Eric
Hi Peter, On 1/14/20 8:04 PM, Peter Xu wrote: > On Thu, Jan 09, 2020 at 03:43:15PM +0100, Eric Auger wrote: >> The event queue allows to report asynchronous errors. >> The translate function now injects faults when relevant. >> >> Signed-off-by: Eric Auger >> >> --- >> >> v11 -> v12: >> -

Re: [PATCH v12 09/13] virtio-iommu: Implement fault reporting

2020-01-14 Thread Peter Xu
On Thu, Jan 09, 2020 at 03:43:15PM +0100, Eric Auger wrote: > The event queue allows to report asynchronous errors. > The translate function now injects faults when relevant. > > Signed-off-by: Eric Auger > > --- > > v11 -> v12: > - reporting the addr associated with the fault and set the >

[PATCH v12 09/13] virtio-iommu: Implement fault reporting

2020-01-09 Thread Eric Auger
The event queue allows to report asynchronous errors. The translate function now injects faults when relevant. Signed-off-by: Eric Auger --- v11 -> v12: - reporting the addr associated with the fault and set the VIRTIO_IOMMU_FAULT_F_ADDRESS flag. - added cpu_to_le v10 -> v11: - change a