Re: [Qemu-devel] [PATCH] build-sys: make help could have 'modules' target

[Paolo Bonzini]

On 07/03/2018 02:38, Fam Zheng wrote:
> On Tue, 03/06 17:17, Marc-André Lureau wrote:
>> Available when configure --enable-modules.
>>
>> Signed-off-by: Marc-André Lureau 
>> ---
>>  Makefile | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/Makefile b/Makefile
>> index 9a75c48ae0..5d9ef3b8fd 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1046,6 +1046,9 @@ include $(SRC_PATH)/tests/vm/Makefile.include
>>  help:
>>  @echo  'Generic targets:'
>>  @echo  '  all - Build all'
>> +ifdef CONFIG_MODULES
>> +@echo  '  modules - Build all modules'
>> +endif
> 
> Hi Marc-André,
> 
> I'd just remove the 'ifdef' condition and include the line everywhere, since
> this is the help. The behavior is fine even without running ./configure:
> 
> $ make modules
> make: Nothing to be done for 'modules'.
> $ make all
> make: Nothing to be done for 'all'.
> 
> Fam
> 

Queued, thanks.

Paolo

Re: [Qemu-devel] [PATCH] build-sys: make help could have 'modules' target

[Fam Zheng]

On Tue, 03/06 17:17, Marc-André Lureau wrote:
> Available when configure --enable-modules.
> 
> Signed-off-by: Marc-André Lureau 
> ---
>  Makefile | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 9a75c48ae0..5d9ef3b8fd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1046,6 +1046,9 @@ include $(SRC_PATH)/tests/vm/Makefile.include
>  help:
>   @echo  'Generic targets:'
>   @echo  '  all - Build all'
> +ifdef CONFIG_MODULES
> + @echo  '  modules - Build all modules'
> +endif

Hi Marc-André,

I'd just remove the 'ifdef' condition and include the line everywhere, since
this is the help. The behavior is fine even without running ./configure:

$ make modules
make: Nothing to be done for 'modules'.
$ make all
make: Nothing to be done for 'all'.

Fam

[Qemu-devel] [PATCH] build-sys: make help could have 'modules' target

[Marc-André Lureau]

Available when configure --enable-modules.

Signed-off-by: Marc-André Lureau 
---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Makefile b/Makefile
index 9a75c48ae0..5d9ef3b8fd 100644
--- a/Makefile
+++ b/Makefile
@@ -1046,6 +1046,9 @@ include $(SRC_PATH)/tests/vm/Makefile.include
 help:
@echo  'Generic targets:'
@echo  '  all - Build all'
+ifdef CONFIG_MODULES
+   @echo  '  modules - Build all modules'
+endif
@echo  '  dir/file.o  - Build specified target only'
@echo  '  install - Install QEMU, documentation and tools'
@echo  '  ctags/TAGS  - Generate tags file for editors'
-- 
2.16.2.346.g9779355e34