Re: [Qemu-devel] [PATCH] omap_dss: correct chip[1] index in RFBI_READ/RFBI_STATUS

2012-01-11 Thread andrzej zaborowski
On 7 January 2012 12:59, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote:
 The RFBI_READ/RFBI_STATUS code incorrectly uses chip[0] when it should
 be using chip[1].  Andrzej Zaborowski bal...@zabor.org confirmed this
 bug since I don't know this code well.

 Reported-by: Dr David Alan Gilbert davidagilb...@uk.ibm.com
 Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com

Reviewed-by: Andrzej Zaborowski andrew.zaborow...@intel.com

Cheers



[Qemu-devel] [PATCH] omap_dss: correct chip[1] index in RFBI_READ/RFBI_STATUS

2012-01-07 Thread Stefan Hajnoczi
The RFBI_READ/RFBI_STATUS code incorrectly uses chip[0] when it should
be using chip[1].  Andrzej Zaborowski bal...@zabor.org confirmed this
bug since I don't know this code well.

Reported-by: Dr David Alan Gilbert davidagilb...@uk.ibm.com
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
---
 hw/omap_dss.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/omap_dss.c b/hw/omap_dss.c
index ede640b..86ed6ea 100644
--- a/hw/omap_dss.c
+++ b/hw/omap_dss.c
@@ -793,7 +793,7 @@ static void omap_rfbi_write(void *opaque, 
target_phys_addr_t addr,
 if ((s-rfbi.control  (1  2))  s-rfbi.chip[0])
 s-rfbi.rxbuf = s-rfbi.chip[0]-read(s-rfbi.chip[0]-opaque, 1);
 else if ((s-rfbi.control  (1  3))  s-rfbi.chip[1])
-s-rfbi.rxbuf = s-rfbi.chip[0]-read(s-rfbi.chip[0]-opaque, 1);
+s-rfbi.rxbuf = s-rfbi.chip[1]-read(s-rfbi.chip[1]-opaque, 1);
 if (!-- s-rfbi.pixels)
 omap_rfbi_transfer_stop(s);
 break;
@@ -802,7 +802,7 @@ static void omap_rfbi_write(void *opaque, 
target_phys_addr_t addr,
 if ((s-rfbi.control  (1  2))  s-rfbi.chip[0])
 s-rfbi.rxbuf = s-rfbi.chip[0]-read(s-rfbi.chip[0]-opaque, 0);
 else if ((s-rfbi.control  (1  3))  s-rfbi.chip[1])
-s-rfbi.rxbuf = s-rfbi.chip[0]-read(s-rfbi.chip[0]-opaque, 0);
+s-rfbi.rxbuf = s-rfbi.chip[1]-read(s-rfbi.chip[1]-opaque, 0);
 if (!-- s-rfbi.pixels)
 omap_rfbi_transfer_stop(s);
 break;
-- 
1.7.7.3