Re: [Qemu-devel] [PATCH 08/16] Move main signal handler setup to os specificfiles.

2010-06-04 Thread Jes Sorensen 
On 06/03/10 22:52, Richard Henderson wrote:
 On 06/03/2010 09:48 AM, jes.soren...@redhat.com wrote:
 --- a/qemu-os-win32.h
 +++ b/qemu-os-win32.h
 @@ -41,4 +41,7 @@ int qemu_add_wait_object(HANDLE handle, WaitObjectFunc 
 *func, void *opaque);
  void qemu_del_wait_object(HANDLE handle, WaitObjectFunc *func, void 
 *opaque);
  
  void os_host_main_loop_wait(int *timeout);
 +
 +static inline void os_setup_signal_handling(void) {};
 
 Stray ;

Sorry, not sure what you mean here?

Jes

Re: [Qemu-devel] [PATCH 08/16] Move main signal handler setup to os specificfiles.

2010-06-04 Thread Markus Armbruster 
Jes Sorensen jes.soren...@redhat.com writes:

 On 06/03/10 22:52, Richard Henderson wrote:
 On 06/03/2010 09:48 AM, jes.soren...@redhat.com wrote:
 --- a/qemu-os-win32.h
 +++ b/qemu-os-win32.h
 @@ -41,4 +41,7 @@ int qemu_add_wait_object(HANDLE handle, WaitObjectFunc 
 *func, void *opaque);
  void qemu_del_wait_object(HANDLE handle, WaitObjectFunc *func, void 
 *opaque);
  
  void os_host_main_loop_wait(int *timeout);
 +
 +static inline void os_setup_signal_handling(void) {};
 
 Stray ;

 Sorry, not sure what you mean here?

There's a stray ';' after the function body's closing brace.  Please
drop it.