Re: [Qemu-devel] [PATCH v1 4/4] .travis.yml: add --disable-tools to the modules build

[Alex Bennée]

Daniel P. Berrangé  writes:

> On Tue, Mar 13, 2018 at 03:32:10PM +, Alex Bennée wrote:
>> The tools are already built elsewhere so we might as well not build it
>> here as we just need to test the modules build of QEMU itself.
>>
>> Signed-off-by: Alex Bennée 
>> ---
>>  .travis.yml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index c1e99237b2..373181c109 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -53,7 +53,7 @@ env:
>>  - CONFIG="--disable-user"
>>  - CONFIG="--enable-debug --enable-debug-tcg"
>>  - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr 
>> --disable-brlapi --disable-uuid --disable-libusb --disable-user"
>> -- CONFIG="--enable-modules --disable-linux-user"
>> +- CONFIG="--enable-modules --disable-tools --disable-linux-user"
>>  - CONFIG="--with-coroutine=ucontext --disable-linux-user"
>>  - CONFIG="--with-coroutine=sigaltstack --disable-linux-user"
>>  git:
>
> Modules affects the block drivers in particular, which could in theory
> affect the qemu-img, qemu-io and qemu-nbd tools, so possibly worth
> keeping that enabled but only if we actually run those tools
> during the job otherwise we're not likely to catch any problems ?

OK, I've dropped this for the pull-req as it shouldn't affect our
timeouts anyway.

>
>
> Regards,
> Daniel


--
Alex Bennée

Re: [Qemu-devel] [PATCH v1 4/4] .travis.yml: add --disable-tools to the modules build

[Daniel P . Berrangé]

On Tue, Mar 13, 2018 at 03:32:10PM +, Alex Bennée wrote:
> The tools are already built elsewhere so we might as well not build it
> here as we just need to test the modules build of QEMU itself.
> 
> Signed-off-by: Alex Bennée 
> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index c1e99237b2..373181c109 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -53,7 +53,7 @@ env:
>  - CONFIG="--disable-user"
>  - CONFIG="--enable-debug --enable-debug-tcg"
>  - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr 
> --disable-brlapi --disable-uuid --disable-libusb --disable-user"
> -- CONFIG="--enable-modules --disable-linux-user"
> +- CONFIG="--enable-modules --disable-tools --disable-linux-user"
>  - CONFIG="--with-coroutine=ucontext --disable-linux-user"
>  - CONFIG="--with-coroutine=sigaltstack --disable-linux-user"
>  git:

Modules affects the block drivers in particular, which could in theory
affect the qemu-img, qemu-io and qemu-nbd tools, so possibly worth
keeping that enabled but only if we actually run those tools
during the job otherwise we're not likely to catch any problems ? 


Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

[Qemu-devel] [PATCH v1 4/4] .travis.yml: add --disable-tools to the modules build

[Alex Bennée]

The tools are already built elsewhere so we might as well not build it
here as we just need to test the modules build of QEMU itself.

Signed-off-by: Alex Bennée 
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index c1e99237b2..373181c109 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -53,7 +53,7 @@ env:
 - CONFIG="--disable-user"
 - CONFIG="--enable-debug --enable-debug-tcg"
 - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr 
--disable-brlapi --disable-uuid --disable-libusb --disable-user"
-- CONFIG="--enable-modules --disable-linux-user"
+- CONFIG="--enable-modules --disable-tools --disable-linux-user"
 - CONFIG="--with-coroutine=ucontext --disable-linux-user"
 - CONFIG="--with-coroutine=sigaltstack --disable-linux-user"
 git:
-- 
2.16.2