Re: [Qemu-devel] [PATCH v4 RESEND 2/3] IOMMU: change iommu_op->translate's is_write to flags, add support to NO_FAIL flag mode

2016-10-20 Thread Aviv B.D.
Hi, You are right, and I will revert those functions you mentioned. Thanks, Aviv. On Wed, Oct 19, 2016 at 11:35 AM, Peter Xu wrote: > On Mon, Oct 17, 2016 at 06:44:23PM +0300, Aviv B.D wrote: > > [...] > > > @@ -364,7 +364,7 @@ static void

Re: [Qemu-devel] [PATCH v4 RESEND 2/3] IOMMU: change iommu_op->translate's is_write to flags, add support to NO_FAIL flag mode

2016-10-19 Thread Peter Xu
On Mon, Oct 17, 2016 at 06:44:23PM +0300, Aviv B.D wrote: [...] > @@ -364,7 +364,7 @@ static void vtd_set_frcd_and_update_ppf(IntelIOMMUState > *s, uint16_t index) > /* Must not update F field now, should be done later */ > static void vtd_record_frcd(IntelIOMMUState *s, uint16_t index, >

Re: [Qemu-devel] [PATCH v4 RESEND 2/3] IOMMU: change iommu_op->translate's is_write to flags, add support to NO_FAIL flag mode

2016-10-17 Thread David Gibson
On Mon, Oct 17, 2016 at 06:44:23PM +0300, Aviv B.D wrote: > From: "Aviv Ben-David" > > Supports translation trials without reporting error to guest on > translation failure. > > Signed-off-by: Aviv Ben-David > --- > exec.c| 3 ++- >

[Qemu-devel] [PATCH v4 RESEND 2/3] IOMMU: change iommu_op->translate's is_write to flags, add support to NO_FAIL flag mode

2016-10-17 Thread Aviv B.D
From: "Aviv Ben-David" Supports translation trials without reporting error to guest on translation failure. Signed-off-by: Aviv Ben-David --- exec.c| 3 ++- hw/i386/amd_iommu.c | 4 +-- hw/i386/intel_iommu.c | 70