Re: [Qemu-devel] [PATCH v6 00/11] s390: channel I/O support in qemu.

2013-01-25 Thread Anthony Liguori 
Hi,

Thank you for submitting your patch series.  checkpatch.pl has
detected that one or more of the patches in this series violate
the QEMU coding style.

If you believe this message was sent in error, please ignore it
or respond here with an explanation.

Otherwise, please correct the coding style issues and resubmit a
new version of the patch.

For more information about QEMU coding style, see:

http://git.qemu.org/?p=qemu.git;a=blob_plain;f=CODING_STYLE;hb=HEAD

Here is the output from checkpatch.pl:

Subject: s390: Add s390-ccw-virtio machine.
Subject: s390: Add default support for SCLP console
ERROR: do not initialise statics to 0 or NULL
#72: FILE: vl.c:2468:
+static int index = 0;

WARNING: braces {} are necessary for all arms of this statement
#126: FILE: vl.c:3923:
+if (default_sclp)
[...]

WARNING: braces {} are necessary for all arms of this statement
#135: FILE: vl.c:3937:
+if (default_sclp)
[...]

WARNING: braces {} are necessary for all arms of this statement
#144: FILE: vl.c:4109:
+if (foreach_device_config(DEV_SCLP, sclp_parse)  0)
[...]

total: 1 errors, 3 warnings, 114 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Subject: s390-virtio: Factor out some initialization code.
Subject: s390: Add new channel I/O based virtio transport.
Subject: s390: Wire up channel I/O in kvm.
Subject: s390: Virtual channel subsystem support.
ERROR: need consistent spacing around '*' (ctx:WxV)
#56: FILE: hw/s390x/css.c:31:
+SubchDev *sch[MAX_SCHID + 1];
  ^

ERROR: need consistent spacing around '*' (ctx:WxV)
#62: FILE: hw/s390x/css.c:37:
+SubchSet *sch_set[MAX_SSID + 1];
  ^

ERROR: need consistent spacing around '*' (ctx:WxV)
#74: FILE: hw/s390x/css.c:49:
+CssImage *css[MAX_CSSID + 1];
  ^

total: 3 errors, 0 warnings, 1469 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Subject: s390: Add channel I/O instructions.
Subject: s390: I/O interrupt and machine check injection.
Subject: s390: Channel I/O basic definitions.
Subject: s390: Add mapping helper functions.
Subject: s390: Lowcore mapping helper.


Regards,

Anthony Liguori

[Qemu-devel] [PATCH v6 00/11] s390: channel I/O support in qemu.

2013-01-24 Thread Cornelia Huck 
Hi,

another round for virtual channel I/O in qemu.

The patches have been respun against current master; changelogs
are in the patches themselves.

Changes are mostly some cleanups; of note are the preparations
for VirtioBus and some changes for making the code endianness
aware.

Making s390-ccw-virtio the default machine has been deferred until
after tcg support is available.

Alexander Graf (1):
  s390: Add default support for SCLP console

Cornelia Huck (10):
  s390: Lowcore mapping helper.
  s390: Add mapping helper functions.
  s390: Channel I/O basic definitions.
  s390: I/O interrupt and machine check injection.
  s390: Add channel I/O instructions.
  s390: Virtual channel subsystem support.
  s390: Wire up channel I/O in kvm.
  s390: Add new channel I/O based virtio transport.
  s390-virtio: Factor out some initialization code.
  s390: Add s390-ccw-virtio machine.

 hw/boards.h|1 +
 hw/s390-virtio.c   |  118 ++--
 hw/s390-virtio.h   |6 +
 hw/s390x/Makefile.objs |3 +
 hw/s390x/css.c | 1277 
 hw/s390x/css.h |   99 
 hw/s390x/s390-virtio-ccw.c |  134 +
 hw/s390x/virtio-ccw.c  |  947 
 hw/s390x/virtio-ccw.h  |   94 
 target-s390x/Makefile.objs |2 +-
 target-s390x/cpu.h |  247 -
 target-s390x/helper.c  |  200 ++-
 target-s390x/ioinst.c  |  752 ++
 target-s390x/ioinst.h  |  223 
 target-s390x/kvm.c |  239 -
 trace-events   |   18 +
 vl.c   |   48 ++
 17 files changed, 4333 insertions(+), 75 deletions(-)
 create mode 100644 hw/s390x/css.c
 create mode 100644 hw/s390x/css.h
 create mode 100644 hw/s390x/s390-virtio-ccw.c
 create mode 100644 hw/s390x/virtio-ccw.c
 create mode 100644 hw/s390x/virtio-ccw.h
 create mode 100644 target-s390x/ioinst.c
 create mode 100644 target-s390x/ioinst.h

-- 
1.7.12.4

Re: [Qemu-devel] [PATCH v6 00/11] s390: channel I/O support in qemu.

2013-01-24 Thread Alexander Graf 

On 24.01.2013, at 13:28, Cornelia Huck wrote:

 Hi,
 
 another round for virtual channel I/O in qemu.
 
 The patches have been respun against current master; changelogs
 are in the patches themselves.
 
 Changes are mostly some cleanups; of note are the preparations
 for VirtioBus and some changes for making the code endianness
 aware.
 
 Making s390-ccw-virtio the default machine has been deferred until
 after tcg support is available.

Thanks, applied [01..07], 09 to s390-next.


Alex