Re: [Qemu-devel] [PULL v3 00/44] pci, pc, virtio: fixes, features

2018-12-25 Thread no-reply 
Patchew URL: https://patchew.org/QEMU/20181220183059.20726-1-...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20181220183059.20726-1-...@redhat.com
Type: series
Subject: [Qemu-devel] [PULL v3 00/44] pci, pc, virtio: fixes, features

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
00bb933 x86-iommu: turn on IR by default if proper
84205d7 x86-iommu: switch intr_supported to OnOffAuto type
e90352f q35: set split kernel irqchip as default
5b42631 pci: Adjust PCI config limit based on bus topology
10af565 spapr_pci: perform unplug via the hotplug handler
19d636e pci/shpc: perform unplug via the hotplug handler
547f401 pci: Reuse pci-bridge hotplug handler handlers for pcie-pci-bridge
54491be pci/pcie: perform unplug via the hotplug handler
d48a499 pci/pcihp: perform unplug via the hotplug handler
69293f5 pci/pcihp: overwrite hotplug handler recursively from the start
cb4db34 pci/pcihp: perform check for bus capability in pre_plug handler
1966b59 s390x/pci: rename hotplug handler callbacks
c9b84c2 pci/shpc: rename hotplug handler callbacks
7d3cc09 pci/pcie: rename hotplug handler callbacks
14b804a hw/i386: Remove deprecated machines pc-0.10 and pc-0.11
2ecba91 hw: acpi: Remove AcpiRsdpDescriptor and fix tests
6eec914 hw: acpi: Export and share the ARM RSDP build
6ce7573 hw: arm: Support both legacy and current RSDP build
05e6bb6 hw: arm: Convert the RSDP build to the buid_append_foo() API
1e3f0b8 hw: arm: Carry RSDP specific data through AcpiRsdpData
1149d53 hw: i386: Use correct RSDT length for checksum
08f1f3d hw: arm: acpi: Fix incorrect checksums in RSDP
833c5a9 hw: acpi: The RSDP build API can return void
6764083 intel_iommu: remove "x-" prefix for "aw-bits"
073d52a intel_iommu: dma read/write draining support
f3f77a5 intel_iommu: convert invalid traces into error reports
3d38fe7 intel_iommu: dump correct iova when failed
bf967a3 pcie: Fast PCIe root ports for new machines
c116234 vfio/pci: Remove PCIe Link Status emulation
b2b0199 pcie: Allow generic PCIe root port to specify link speed and width
de6a18a pcie: Fill PCIESlot link fields to support higher speeds and widths
b19b53a pcie: Add link speed and width fields to PCIESlot
e909a5f qapi: Define PCIe link speed and width properties
2b940de pci: Sync PCIe downstream port LNKSTA on read
e9a0604 pcie: Create enums for link speed and width
d1ef1d5 hw/pci-bridge: Fix invalid free()
3f5466b hw/smbios: Move to the hw/firmware/ subdirectory
22e0d61 hw/smbios: Remove "smbios_ipmi.h"
8f50a34 hw/smbios: Restrict access to "hw/smbios/ipmi.h"
6075c5e tests: Remove unused include
b4cf945 virtio: Provide version-specific variants of virtio PCI devices
4dff116 virtio: Helper for registering virtio device types
be858a5 pc:piix4: Update smbus I/O space after a migration
9a3c2f2 pcie: set link state inactive/active after hot unplug/plug

=== OUTPUT BEGIN ===
Checking PATCH 1/44: pcie: set link state inactive/active after hot 
unplug/plug...
Checking PATCH 2/44: pc:piix4: Update smbus I/O space after a migration...
Checking PATCH 3/44: virtio: Helper for registering virtio device types...
WARNING: line over 80 characters
#498: FILE: hw/virtio/virtio-pci.h:443:
+ * Implements both INTERFACE_PCIE_DEVICE and 
INTERFACE_CONVENTIONAL_PCI_DEVICE,

WARNING: line over 80 characters
#507: FILE: hw/virtio/virtio-pci.h:452:
+ * Implements both INTERFACE_PCIE_DEVICE and 
INTERFACE_CONVENTIONAL_PCI_DEVICE.

total: 0 errors, 2 warnings, 469 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/44: virtio: Provide version-specific variants of virtio PCI 
devices...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#318: 
new file mode 100644

ERROR: line over 90 characters
#374: FILE: tests/acceptance/virtio_version.py:52:
+return devtype in [d['name'] for d in vm.command('qom-list-types', 
implements=implements)]

WARNING: line over 80 characters
#429: FILE: tests/acceptance/virtio_version.py:107:
+dev_1_0, nt_ifaces = self.run_device('%s-non-transitional' % 
(qemu_devtype))

WARNING: line over 80 characters
#453: FILE: tests/acceptance/virtio_version.py:131:
+dev_trans, trans_ifaces = self.run_dev

Re: [Qemu-devel] [PULL v3 00/44] pci, pc, virtio: fixes, features

2018-12-21 Thread Peter Maydell 
On Thu, 20 Dec 2018 at 18:37, Michael S. Tsirkin  wrote:
>
> The following changes since commit b72566a4ffaddbc0c0c1f6f5ee91b42ab13ff429:
>
>   Merge remote-tracking branch 
> 'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2018-12-19 
> 15:31:02 +)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>
> for you to fetch changes up to 47748bbba24d4f4680b77da3dc5b4da531cd17d4:
>
>   x86-iommu: turn on IR by default if proper (2018-12-20 13:25:11 -0500)
>
> 
> pci, pc, virtio: fixes, features
>
> VTD fixes
> IR and split irqchip are now the default for Q35
> ACPI refactoring
> hotplug refactoring
> new names for virtio devices
> multiple pcie link width/speeds
> PCI fixes
>
> Signed-off-by: Michael S. Tsirkin 
>
Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
for any user-visible changes.

-- PMM

[Qemu-devel] [PULL v3 00/44] pci, pc, virtio: fixes, features

2018-12-20 Thread Michael S. Tsirkin 
The following changes since commit b72566a4ffaddbc0c0c1f6f5ee91b42ab13ff429:

  Merge remote-tracking branch 
'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2018-12-19 
15:31:02 +)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

for you to fetch changes up to 47748bbba24d4f4680b77da3dc5b4da531cd17d4:

  x86-iommu: turn on IR by default if proper (2018-12-20 13:25:11 -0500)


pci, pc, virtio: fixes, features

VTD fixes
IR and split irqchip are now the default for Q35
ACPI refactoring
hotplug refactoring
new names for virtio devices
multiple pcie link width/speeds
PCI fixes

Signed-off-by: Michael S. Tsirkin 


Alex Williamson (9):
  pcie: Create enums for link speed and width
  pci: Sync PCIe downstream port LNKSTA on read
  qapi: Define PCIe link speed and width properties
  pcie: Add link speed and width fields to PCIESlot
  pcie: Fill PCIESlot link fields to support higher speeds and widths
  pcie: Allow generic PCIe root port to specify link speed and width
  vfio/pci: Remove PCIe Link Status emulation
  pcie: Fast PCIe root ports for new machines
  pci: Adjust PCI config limit based on bus topology

Corey Minyard (1):
  pc:piix4: Update smbus I/O space after a migration

David Hildenbrand (10):
  pci/pcie: rename hotplug handler callbacks
  pci/shpc: rename hotplug handler callbacks
  s390x/pci: rename hotplug handler callbacks
  pci/pcihp: perform check for bus capability in pre_plug handler
  pci/pcihp: overwrite hotplug handler recursively from the start
  pci/pcihp: perform unplug via the hotplug handler
  pci/pcie: perform unplug via the hotplug handler
  pci: Reuse pci-bridge hotplug handler handlers for pcie-pci-bridge
  pci/shpc: perform unplug via the hotplug handler
  spapr_pci: perform unplug via the hotplug handler

Eduardo Habkost (2):
  virtio: Helper for registering virtio device types
  virtio: Provide version-specific variants of virtio PCI devices

Igor Mammedov (2):
  hw: arm: acpi: Fix incorrect checksums in RSDP
  hw: i386: Use correct RSDT length for checksum

Matthias Weckbecker (1):
  hw/pci-bridge: Fix invalid free()

Peter Xu (7):
  intel_iommu: dump correct iova when failed
  intel_iommu: convert invalid traces into error reports
  intel_iommu: dma read/write draining support
  intel_iommu: remove "x-" prefix for "aw-bits"
  q35: set split kernel irqchip as default
  x86-iommu: switch intr_supported to OnOffAuto type
  x86-iommu: turn on IR by default if proper

Philippe Mathieu-Daudé (4):
  tests: Remove unused include
  hw/smbios: Restrict access to "hw/smbios/ipmi.h"
  hw/smbios: Remove "smbios_ipmi.h"
  hw/smbios: Move to the hw/firmware/ subdirectory

Samuel Ortiz (6):
  hw: acpi: The RSDP build API can return void
  hw: arm: Carry RSDP specific data through AcpiRsdpData
  hw: arm: Convert the RSDP build to the buid_append_foo() API
  hw: arm: Support both legacy and current RSDP build
  hw: acpi: Export and share the ARM RSDP build
  hw: acpi: Remove AcpiRsdpDescriptor and fix tests

Thomas Huth (1):
  hw/i386: Remove deprecated machines pc-0.10 and pc-0.11

Zheng Xiang (1):
  pcie: set link state inactive/active after hot unplug/plug

 qapi/common.json |  42 +
 hw/i386/intel_iommu_internal.h   |   3 +
 hw/smbios/smbios_build.h |   4 +
 hw/virtio/virtio-pci.h   |  78 +++--
 include/hw/acpi/acpi-defs.h  |  19 +--
 include/hw/acpi/aml-build.h  |   2 +
 include/hw/acpi/pcihp.h  |   5 +
 include/hw/boards.h  |   1 +
 include/hw/compat.h  |  10 +-
 include/hw/{smbios => firmware}/smbios.h |   0
 include/hw/i386/intel_iommu.h|   1 +
 include/hw/i386/pc.h |   5 +
 include/hw/i386/x86-iommu.h  |   4 +-
 include/hw/pci/pci.h |  13 ++
 include/hw/pci/pci_bridge.h  |   6 +
 include/hw/pci/pcie.h|  11 +-
 include/hw/pci/pcie_port.h   |   4 +
 include/hw/pci/pcie_regs.h   |  23 ++-
 include/hw/pci/shpc.h|  10 +-
 include/hw/qdev-properties.h |   8 +
 include/hw/smbios/ipmi.h |  15 --
 tests/acpi-utils.h   |   5 +-
 hw/acpi/aml-build.c  |  68 
 hw/acpi/pcihp.c  |  47 +-
 hw/acpi/piix4.c  |  40 ++---
 hw/arm/virt-acpi-build.c |  40 +
 hw/arm/virt.c|   2 +-
 hw/core/machine.c|   2 +
 hw/core/qdev-properties.c