Re: [Qemu-devel] [RFC PATCH 01/11] qapi-types.py: Split off generate_struct_fields()

2013-07-11 Thread Eric Blake 
On 07/09/2013 03:53 AM, Kevin Wolf wrote:
 Signed-off-by: Kevin Wolf kw...@redhat.com
 ---
  scripts/qapi-types.py | 19 +--
  1 file changed, 13 insertions(+), 6 deletions(-)

Reviewed-by: Eric Blake ebl...@redhat.com

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature

[Qemu-devel] [RFC PATCH 01/11] qapi-types.py: Split off generate_struct_fields()

2013-07-09 Thread Kevin Wolf 
Signed-off-by: Kevin Wolf kw...@redhat.com
---
 scripts/qapi-types.py | 19 +--
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
index ddcfed9..e1239e1 100644
--- a/scripts/qapi-types.py
+++ b/scripts/qapi-types.py
@@ -57,12 +57,8 @@ typedef struct %(name)sList
 ''',
  name=name)
 
-def generate_struct(structname, fieldname, members):
-ret = mcgen('''
-struct %(name)s
-{
-''',
-  name=structname)
+def generate_struct_fields(members):
+ret = ''
 
 for argname, argentry, optional, structured in parse_args(members):
 if optional:
@@ -80,6 +76,17 @@ struct %(name)s
 ''',
  c_type=c_type(argentry), c_name=c_var(argname))
 
+return ret
+
+def generate_struct(structname, fieldname, members):
+ret = mcgen('''
+struct %(name)s
+{
+''',
+  name=structname)
+
+ret += generate_struct_fields(members)
+
 if len(fieldname):
 fieldname =   + fieldname
 ret += mcgen('''
-- 
1.8.1.4