[Qemu-devel] Re: [PATCH v2] scsi-disk: add some optional scsi commands

2010-09-06 Thread Kevin Wolf
Am 06.09.2010 11:25, schrieb Bernhard Kohl:
 I use a legacy OS which depends on some optional SCSI commands.
 In fact this implementation does nothing special, but provides minimum
 support for the following commands:
 
 REZERO UNIT
 WRITE AND VERIFY(10)
 WRITE AND VERIFY(12)
 WRITE AND VERIFY(16)
 MODE SELECT(6)
 MODE SELECT(10)
 SEEK(6)
 SEEK(10)
 
 Signed-off-by: Bernhard Kohl bernhard.k...@nsn.com
 ---
   hw/scsi-disk.c |   36 +++-
   1 files changed, 35 insertions(+), 1 deletions(-)
 
 diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
 index b80c9bd..1446ca6 100644
 --- a/hw/scsi-disk.c
 +++ b/hw/scsi-disk.c
 @@ -892,6 +892,12 @@ static int scsi_disk_emulate_command(SCSIRequest 
 *req, uint8_t *outbuf)

Sorry to request another version, but this patch is corrupted by line
wraps. I think it was right when you sent the first version, did you
change anything?

Kevin



[Qemu-devel] Re: [PATCH v2] scsi-disk: add some optional scsi commands

2010-09-06 Thread Bernhard Kohl

Am 06.09.2010 11:33, schrieb ext Kevin Wolf:

Sorry to request another version, but this patch is corrupted by line
wraps. I think it was right when you sent the first version, did you
change anything?
   


No I didn't change anything. I did 'git commit -s --amend' and
'git format-patch' and then I pasted it into Thunderbird. What
email program are you using?

The first version I sent with 'git send-email'. I'll try that again.

Bernhard




[Qemu-devel] Re: [PATCH v2] scsi-disk: add some optional scsi commands

2010-09-06 Thread Kevin Wolf
Am 06.09.2010 11:41, schrieb Bernhard Kohl:
 Am 06.09.2010 11:33, schrieb ext Kevin Wolf:
 Sorry to request another version, but this patch is corrupted by line
 wraps. I think it was right when you sent the first version, did you
 change anything?

 
 No I didn't change anything. I did 'git commit -s --amend' and
 'git format-patch' and then I pasted it into Thunderbird. What
 email program are you using?
 
 The first version I sent with 'git send-email'. I'll try that again.

git send-email is what I use for patches, too. It hasn't broken my
patches so far and it's also quite convenient because it works from the
shell where I just ran git format-patch.

Kevin