Re: [Qemu-devel] [PATCH 07/10] linux-user: init_guest_space: Clean up control flow a bit

2018-03-13 Thread Laurent Vivier
Le 13/03/2018 à 14:54, Peter Maydell a écrit : > On 13 March 2018 at 13:30, Laurent Vivier wrote: >> Le 09/03/2018 à 21:37, Laurent Vivier a écrit : >>> Le 28/12/2017 à 19:08, Luke Shumaker a écrit : --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@

Re: [Qemu-devel] [PATCH 07/10] linux-user: init_guest_space: Clean up control flow a bit

2018-03-13 Thread Peter Maydell
On 13 March 2018 at 13:30, Laurent Vivier wrote: > Le 09/03/2018 à 21:37, Laurent Vivier a écrit : >> Le 28/12/2017 à 19:08, Luke Shumaker a écrit : >>> --- a/linux-user/elfload.c >>> +++ b/linux-user/elfload.c >>> @@ -1906,24 +1906,28 @@ unsigned long init_guest_space(unsigned

Re: [Qemu-devel] [PATCH 07/10] linux-user: init_guest_space: Clean up control flow a bit

2018-03-13 Thread Laurent Vivier
Le 09/03/2018 à 21:37, Laurent Vivier a écrit : > Le 28/12/2017 à 19:08, Luke Shumaker a écrit : >> From: Luke Shumaker >> >> Instead of doing >> >> if (check1) { >> if (check2) { >>success; >> } >> } >> >>

Re: [Qemu-devel] [PATCH 07/10] linux-user: init_guest_space: Clean up control flow a bit

2018-03-09 Thread Laurent Vivier
Le 28/12/2017 à 19:08, Luke Shumaker a écrit : > From: Luke Shumaker > > Instead of doing > > if (check1) { > if (check2) { >success; > } > } > > retry; > > Do a clearer > > if (!check1) { >

Re: [Qemu-devel] [PATCH 07/10] linux-user: init_guest_space: Clean up control flow a bit

2018-03-02 Thread Peter Maydell
On 28 December 2017 at 18:08, Luke Shumaker wrote: > From: Luke Shumaker > > Instead of doing > > if (check1) { > if (check2) { >success; > } > } > > retry; > > Do a clearer > > if