Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-20 Thread Daniel P. Berrange
On Thu, Oct 13, 2016 at 02:35:38PM +0200, Markus Armbruster wrote: > Cc: Kevin for discussion of QemuOpts dotted key convention > > "Daniel P. Berrange" writes: > > > Currently qdict_crumple requires a totally flat QDict as its > > input. i.e. all values in the QDict must be scalar types. > > >

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-19 Thread Daniel P. Berrange
On Wed, Oct 19, 2016 at 11:25:27AM +0200, Kevin Wolf wrote: > Am 18.10.2016 um 17:35 hat Markus Armbruster geschrieben: > > Kevin Wolf writes: > > > Of course, you could argue that flat QDicts are the wrong data structure > > > in the first place and instead of flatting everything we should have >

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-19 Thread Kevin Wolf
Am 18.10.2016 um 17:35 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > Of course, you could argue that flat QDicts are the wrong data structure > > in the first place and instead of flatting everything we should have > > done the equivalent of qdict_crumple from the beginning, but they

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-18 Thread Markus Armbruster
Kevin Wolf writes: > Am 17.10.2016 um 16:50 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 13.10.2016 um 14:35 hat Markus Armbruster geschrieben: >> >> Cc: Kevin for discussion of QemuOpts dotted key convention >> >> >> >> "Daniel P. Berrange" writes: >> >> >> >> > Curre

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-18 Thread Markus Armbruster
Eric Blake writes: > On 10/17/2016 09:50 AM, Markus Armbruster wrote: >>> But even if I realised that QemuOpts support this syntax, I think we >>> would still have to use the dotted syntax because it's explicit about >>> the index and we need that because the list can contains dicts. >>> >>> Comp

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-18 Thread Kevin Wolf
Am 17.10.2016 um 16:50 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 13.10.2016 um 14:35 hat Markus Armbruster geschrieben: > >> Cc: Kevin for discussion of QemuOpts dotted key convention > >> > >> "Daniel P. Berrange" writes: > >> > >> > Currently qdict_crumple requires a t

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-17 Thread Markus Armbruster
Paolo Bonzini writes: >> For me, a replacement should do structured values by providing suitable >> *value* syntax instead of hacking it into the keys: >> >> { "driver": "quorum", >> "child": [ { "driver": "file", "filename": "disk1.img" }, >> { "driver": "host_device"

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-17 Thread Eric Blake
On 10/17/2016 09:50 AM, Markus Armbruster wrote: >> But even if I realised that QemuOpts support this syntax, I think we >> would still have to use the dotted syntax because it's explicit about >> the index and we need that because the list can contains dicts. >> >> Compare this: >> >> driver=q

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-17 Thread Paolo Bonzini
> For me, a replacement should do structured values by providing suitable > *value* syntax instead of hacking it into the keys: > > { "driver": "quorum", > "child": [ { "driver": "file", "filename": "disk1.img" }, > { "driver": "host_device", "filename=/dev/sdb" }, >

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 13.10.2016 um 14:35 hat Markus Armbruster geschrieben: >> Cc: Kevin for discussion of QemuOpts dotted key convention >> >> "Daniel P. Berrange" writes: >> >> > Currently qdict_crumple requires a totally flat QDict as its >> > input. i.e. all values in the QDict must be

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-13 Thread Kevin Wolf
Am 13.10.2016 um 14:35 hat Markus Armbruster geschrieben: > Cc: Kevin for discussion of QemuOpts dotted key convention > > "Daniel P. Berrange" writes: > > > Currently qdict_crumple requires a totally flat QDict as its > > input. i.e. all values in the QDict must be scalar types. > > > > In orde

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-13 Thread Markus Armbruster
Cc: Kevin for discussion of QemuOpts dotted key convention "Daniel P. Berrange" writes: > Currently qdict_crumple requires a totally flat QDict as its > input. i.e. all values in the QDict must be scalar types. > > In order to have backwards compatibility with the OptsVisitor, > qemu_opt_to_qdic