Re: [Qemu-devel] [PATCH v2 2/2] e1000: fix buliding complaint

2016-09-22 Thread Jason Wang 



On 2016年09月13日 14:00, Dmitry Fleytman wrote:

>On 9 Sep 2016, at 10:15 AM, Gonglei (Arei)  wrote:
>
>Who can pick up this patch? Dmitry or Jason? Thanks!

Jason, would you please?



Picked in my tree.

Thanks

Re: [Qemu-devel] [PATCH v2 2/2] e1000: fix buliding complaint

2016-09-13 Thread Dmitry Fleytman 

> On 9 Sep 2016, at 10:15 AM, Gonglei (Arei)  wrote:
> 
> Who can pick up this patch? Dmitry or Jason? Thanks!

Jason, would you please?

> 
> 
> Regards,
> -Gonglei
> 
> 
>> -Original Message-
>> From: Dmitry Fleytman [mailto:dmi...@daynix.com]
>> Sent: Wednesday, August 31, 2016 8:59 PM
>> To: Gonglei (Arei)
>> Cc: qemu-devel@nongnu.org; berra...@redhat.com
>> Subject: Re: [PATCH v2 2/2] e1000: fix buliding complaint
>> 
>> Reviewed-by: Dmitry Fleytman 
>> 
>>> On 30 Aug 2016, at 07:10 AM, Gonglei  wrote:
>>> 
>>> hw/net/e1000e_core.c:56: warning: e1000e_set_interrupt_cause declared
>> inline after being called
>>> hw/net/e1000e_core.c:56: warning: previous declaration of
>> e1000e_set_interrupt_cause was here
>>> 
>>> Signed-off-by: Gonglei 
>>> ---
>>> hw/net/e1000e_core.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
>>> index badb1fe..825e169 100644
>>> --- a/hw/net/e1000e_core.c
>>> +++ b/hw/net/e1000e_core.c
>>> @@ -2168,7 +2168,7 @@ e1000e_update_interrupt_state(E1000ECore
>> *core)
>>>}
>>> }
>>> 
>>> -static inline void
>>> +static void
>>> e1000e_set_interrupt_cause(E1000ECore *core, uint32_t val)
>>> {
>>>trace_e1000e_irq_set_cause_entry(val, core->mac[ICR]);
>>> --
>>> 1.7.12.4
>>> 
>>> 
>

Re: [Qemu-devel] [PATCH v2 2/2] e1000: fix buliding complaint

2016-09-09 Thread Gonglei (Arei) 
Who can pick up this patch? Dmitry or Jason? Thanks!


Regards,
-Gonglei


> -Original Message-
> From: Dmitry Fleytman [mailto:dmi...@daynix.com]
> Sent: Wednesday, August 31, 2016 8:59 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; berra...@redhat.com
> Subject: Re: [PATCH v2 2/2] e1000: fix buliding complaint
> 
> Reviewed-by: Dmitry Fleytman 
> 
> > On 30 Aug 2016, at 07:10 AM, Gonglei  wrote:
> >
> > hw/net/e1000e_core.c:56: warning: e1000e_set_interrupt_cause declared
> inline after being called
> > hw/net/e1000e_core.c:56: warning: previous declaration of
> e1000e_set_interrupt_cause was here
> >
> > Signed-off-by: Gonglei 
> > ---
> > hw/net/e1000e_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
> > index badb1fe..825e169 100644
> > --- a/hw/net/e1000e_core.c
> > +++ b/hw/net/e1000e_core.c
> > @@ -2168,7 +2168,7 @@ e1000e_update_interrupt_state(E1000ECore
> *core)
> > }
> > }
> >
> > -static inline void
> > +static void
> > e1000e_set_interrupt_cause(E1000ECore *core, uint32_t val)
> > {
> > trace_e1000e_irq_set_cause_entry(val, core->mac[ICR]);
> > --
> > 1.7.12.4
> >
> >

Re: [Qemu-devel] [PATCH v2 2/2] e1000: fix buliding complaint

2016-08-31 Thread Dmitry Fleytman 
Reviewed-by: Dmitry Fleytman 

> On 30 Aug 2016, at 07:10 AM, Gonglei  wrote:
> 
> hw/net/e1000e_core.c:56: warning: e1000e_set_interrupt_cause declared inline 
> after being called
> hw/net/e1000e_core.c:56: warning: previous declaration of 
> e1000e_set_interrupt_cause was here
> 
> Signed-off-by: Gonglei 
> ---
> hw/net/e1000e_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
> index badb1fe..825e169 100644
> --- a/hw/net/e1000e_core.c
> +++ b/hw/net/e1000e_core.c
> @@ -2168,7 +2168,7 @@ e1000e_update_interrupt_state(E1000ECore *core)
> }
> }
> 
> -static inline void
> +static void
> e1000e_set_interrupt_cause(E1000ECore *core, uint32_t val)
> {
> trace_e1000e_irq_set_cause_entry(val, core->mac[ICR]);
> -- 
> 1.7.12.4
> 
>