Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

On 18 October 2016 at 18:57, Andrew Jones wrote: > On Tue, Oct 18, 2016 at 06:07:49PM +0100, Peter Maydell wrote: >> Why do you want to un-property mp_affinity? Eventually it would >> be nice for the machine model to be able to use it to set up >> a specific NUMA

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

On Tue, Oct 18, 2016 at 06:07:49PM +0100, Peter Maydell wrote: > On 18 October 2016 at 17:22, Andrew Jones wrote: > > I'll note that it's > > accepted to reach into machine state through current_machine from > > the machine's devices. > > That doesn't sound like a great idea

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

On 18 October 2016 at 17:22, Andrew Jones wrote: > I'll note that it's > accepted to reach into machine state through current_machine from > the machine's devices. That doesn't sound like a great idea to me -- where do we do it? A quick grep for uses of current_machine in hw/

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

On 18/10/2016 18:22, Andrew Jones wrote: > On Tue, Oct 18, 2016 at 01:22:07PM -0200, Eduardo Habkost wrote: >> On Tue, Oct 18, 2016 at 04:22:47PM +0200, Andrew Jones wrote: ... >>> OK, to proceed with this patch, since mp-affinity *is* currently a >>> property, we can just change its default

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

On Tue, Oct 18, 2016 at 01:22:07PM -0200, Eduardo Habkost wrote: > On Tue, Oct 18, 2016 at 04:22:47PM +0200, Andrew Jones wrote: > > On Tue, Oct 18, 2016 at 11:18:29AM -0200, Eduardo Habkost wrote: > > > On Tue, Oct 18, 2016 at 03:00:07PM +0200, Andrew Jones wrote: > > > > On Mon, Oct 17, 2016 at

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

On Tue, Oct 18, 2016 at 04:22:47PM +0200, Andrew Jones wrote: > On Tue, Oct 18, 2016 at 11:18:29AM -0200, Eduardo Habkost wrote: > > On Tue, Oct 18, 2016 at 03:00:07PM +0200, Andrew Jones wrote: > > > On Mon, Oct 17, 2016 at 05:20:22PM -0200, Eduardo Habkost wrote: > > > > On Sat, Oct 15, 2016 at

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

On Tue, Oct 18, 2016 at 11:18:29AM -0200, Eduardo Habkost wrote: > On Tue, Oct 18, 2016 at 03:00:07PM +0200, Andrew Jones wrote: > > On Mon, Oct 17, 2016 at 05:20:22PM -0200, Eduardo Habkost wrote: > > > On Sat, Oct 15, 2016 at 12:52:48AM +0200, Laurent Vivier wrote: > > > > Modify all CPUs to

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

On Tue, Oct 18, 2016 at 03:00:07PM +0200, Andrew Jones wrote: > On Mon, Oct 17, 2016 at 05:20:22PM -0200, Eduardo Habkost wrote: > > On Sat, Oct 15, 2016 at 12:52:48AM +0200, Laurent Vivier wrote: > > > Modify all CPUs to call it from XXX_cpu_realizefn() function. > > > > > > Remove all the

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

On Mon, Oct 17, 2016 at 05:20:22PM -0200, Eduardo Habkost wrote: > On Sat, Oct 15, 2016 at 12:52:48AM +0200, Laurent Vivier wrote: > > Modify all CPUs to call it from XXX_cpu_realizefn() function. > > > > Remove all the cannot_destroy_with_object_finalize_yet as > > unsafe references have been

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

On Mon, 17 Oct 2016 17:20:22 -0200 Eduardo Habkost wrote: > On Sat, Oct 15, 2016 at 12:52:48AM +0200, Laurent Vivier wrote: > > Modify all CPUs to call it from XXX_cpu_realizefn() function. > > > > Remove all the cannot_destroy_with_object_finalize_yet as > > unsafe

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

On Sat, Oct 15, 2016 at 12:52:48AM +0200, Laurent Vivier wrote: > Modify all CPUs to call it from XXX_cpu_realizefn() function. > > Remove all the cannot_destroy_with_object_finalize_yet as > unsafe references have been moved to cpu_exec_realizefn(). > (tested with QOM command provided by commit

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

On Sat, Oct 15, 2016 at 12:52:48AM +0200, Laurent Vivier wrote: > Modify all CPUs to call it from XXX_cpu_realizefn() function. > > Remove all the cannot_destroy_with_object_finalize_yet as > unsafe references have been moved to cpu_exec_realizefn(). > (tested with QOM command provided by commit

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

On 17/10/2016 16:03, Eduardo Habkost wrote: > On Sat, Oct 15, 2016 at 12:52:48AM +0200, Laurent Vivier wrote: >> Modify all CPUs to call it from XXX_cpu_realizefn() function. >> >> Remove all the cannot_destroy_with_object_finalize_yet as >> unsafe references have been moved to

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

On Sat, 15 Oct 2016 00:52:48 +0200 Laurent Vivier wrote: > Modify all CPUs to call it from XXX_cpu_realizefn() function. > > Remove all the cannot_destroy_with_object_finalize_yet as > unsafe references have been moved to cpu_exec_realizefn(). > (tested with QOM command

Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()

On Sat, Oct 15, 2016 at 12:52:48AM +0200, Laurent Vivier wrote: > Modify all CPUs to call it from XXX_cpu_realizefn() function. > > Remove all the cannot_destroy_with_object_finalize_yet as > unsafe references have been moved to cpu_exec_realizefn(). > (tested with QOM command provided by commit