Re: [Qemu-devel] [PATCH v4 19/22] libqtest: Add qmp_args_dict() helper

2017-08-10 Thread Markus Armbruster
Eric Blake writes: > On 08/09/2017 10:59 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Leaving interpolation into JSON to qobject_from_jsonf() is more >>> robust than building QMP input manually; however, we have a few >>> places where code is

Re: [Qemu-devel] [PATCH v4 19/22] libqtest: Add qmp_args_dict() helper

2017-08-09 Thread Eric Blake
On 08/09/2017 10:59 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Leaving interpolation into JSON to qobject_from_jsonf() is more >> robust than building QMP input manually; however, we have a few >> places where code is already creating a QDict to interpolate >>

Re: [Qemu-devel] [PATCH v4 19/22] libqtest: Add qmp_args_dict() helper

2017-08-09 Thread Markus Armbruster
Eric Blake writes: > Leaving interpolation into JSON to qobject_from_jsonf() is more > robust than building QMP input manually; however, we have a few > places where code is already creating a QDict to interpolate > individual arguments, which cannot be reproduced with the >