Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-09-12 Thread Kevin Wolf
Am 11.09.2019 um 13:00 hat Max Reitz geschrieben: > On 11.09.19 12:31, Kevin Wolf wrote: > > Am 11.09.2019 um 12:00 hat Max Reitz geschrieben: > >> So all in all I think it’s best to make the callback mandatory and add > >> two global helper functions. That’s simple enough and should prevent > >>

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-09-11 Thread Max Reitz
On 11.09.19 12:31, Kevin Wolf wrote: > Am 11.09.2019 um 12:00 hat Max Reitz geschrieben: >> On 11.09.19 10:27, Kevin Wolf wrote: >>> Am 11.09.2019 um 09:37 hat Max Reitz geschrieben: On 11.09.19 08:55, Kevin Wolf wrote: > Well, by default the primary child, which should cover like 90% of

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-09-11 Thread Kevin Wolf
Am 11.09.2019 um 12:00 hat Max Reitz geschrieben: > On 11.09.19 10:27, Kevin Wolf wrote: > > Am 11.09.2019 um 09:37 hat Max Reitz geschrieben: > >> On 11.09.19 08:55, Kevin Wolf wrote: > >>> Well, by default the primary child, which should cover like 90% of the > >>> drivers? > >> > >> Hm, yes. >

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-09-11 Thread Max Reitz
On 11.09.19 10:27, Kevin Wolf wrote: > Am 11.09.2019 um 09:37 hat Max Reitz geschrieben: >> On 11.09.19 08:55, Kevin Wolf wrote: >>> Am 11.09.2019 um 08:20 hat Max Reitz geschrieben: On 10.09.19 16:52, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> If the

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-09-11 Thread Kevin Wolf
Am 11.09.2019 um 09:37 hat Max Reitz geschrieben: > On 11.09.19 08:55, Kevin Wolf wrote: > > Am 11.09.2019 um 08:20 hat Max Reitz geschrieben: > >> On 10.09.19 16:52, Kevin Wolf wrote: > >>> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > If the driver does not implement

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-09-11 Thread Max Reitz
On 11.09.19 08:55, Kevin Wolf wrote: > Am 11.09.2019 um 08:20 hat Max Reitz geschrieben: >> On 10.09.19 16:52, Kevin Wolf wrote: >>> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: If the driver does not implement bdrv_get_allocated_file_size(), we should fall back to cumulating the

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-09-11 Thread Kevin Wolf
Am 11.09.2019 um 08:20 hat Max Reitz geschrieben: > On 10.09.19 16:52, Kevin Wolf wrote: > > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > >> If the driver does not implement bdrv_get_allocated_file_size(), we > >> should fall back to cumulating the allocated size of all non-COW > >>

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-09-11 Thread Max Reitz
On 10.09.19 16:52, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> If the driver does not implement bdrv_get_allocated_file_size(), we >> should fall back to cumulating the allocated size of all non-COW >> children instead of just bs->file. >> >> Suggested-by: Vladimir

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-09-10 Thread Kevin Wolf
Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > If the driver does not implement bdrv_get_allocated_file_size(), we > should fall back to cumulating the allocated size of all non-COW > children instead of just bs->file. > > Suggested-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Max

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-08-12 Thread Max Reitz
On 12.08.19 19:14, Vladimir Sementsov-Ogievskiy wrote: > 12.08.2019 16:09, Max Reitz wrote: >> On 10.08.19 18:41, Vladimir Sementsov-Ogievskiy wrote: >>> 09.08.2019 19:13, Max Reitz wrote: If the driver does not implement bdrv_get_allocated_file_size(), we should fall back to cumulating

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-08-12 Thread Vladimir Sementsov-Ogievskiy
12.08.2019 16:09, Max Reitz wrote: > On 10.08.19 18:41, Vladimir Sementsov-Ogievskiy wrote: >> 09.08.2019 19:13, Max Reitz wrote: >>> If the driver does not implement bdrv_get_allocated_file_size(), we >>> should fall back to cumulating the allocated size of all non-COW >>> children instead of

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-08-12 Thread Max Reitz
On 10.08.19 18:41, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:13, Max Reitz wrote: >> If the driver does not implement bdrv_get_allocated_file_size(), we >> should fall back to cumulating the allocated size of all non-COW >> children instead of just bs->file. >> >> Suggested-by: Vladimir

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-08-10 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 19:13, Max Reitz wrote: > If the driver does not implement bdrv_get_allocated_file_size(), we > should fall back to cumulating the allocated size of all non-COW > children instead of just bs->file. > > Suggested-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Max Reitz > --- >