Re: [Qemu-devel] [PATCH v7 5/6] fsdev: hmp interface for throttling

[Pradeep Jagadeesh]

On 7/6/2017 8:15 PM, Markus Armbruster wrote:

Pradeep Jagadeesh  writes:


This patch introduces hmp interfaces for the fsdev
devices.

Signed-off-by: Pradeep Jagadeesh 


Fails to compile, first error:

/work/armbru/qemu/hmp.c: In function ‘hmp_fsdev_set_io_throttle’:
/work/armbru/qemu/hmp.c:1791:5: warning: implicit declaration of function 
‘qmp_fsdev_set_io_throttle’ [-Wimplicit-function-declaration]
 qmp_fsdev_set_io_throttle(, );
 ^

Do you need to swap PATCH 5 and 6?

Hmm, yes better to swap, because of dependency.
I will do in V8.

-Pradeep

Re: [Qemu-devel] [PATCH v7 5/6] fsdev: hmp interface for throttling

[Markus Armbruster]

Pradeep Jagadeesh  writes:

> This patch introduces hmp interfaces for the fsdev
> devices.
>
> Signed-off-by: Pradeep Jagadeesh 

Fails to compile, first error:

/work/armbru/qemu/hmp.c: In function ‘hmp_fsdev_set_io_throttle’:
/work/armbru/qemu/hmp.c:1791:5: warning: implicit declaration of function 
‘qmp_fsdev_set_io_throttle’ [-Wimplicit-function-declaration]
 qmp_fsdev_set_io_throttle(, );
 ^

Do you need to swap PATCH 5 and 6?

Re: [Qemu-devel] [PATCH v7 5/6] fsdev: hmp interface for throttling

[Dr. David Alan Gilbert]

* Pradeep Jagadeesh (pradeepkiruv...@gmail.com) wrote:
> This patch introduces hmp interfaces for the fsdev
> devices.
> 
> Signed-off-by: Pradeep Jagadeesh 

Yes I think that's better;

Reviewed-by: Dr. David Alan Gilbert 

> ---
>  hmp-commands-info.hx | 18 +++
>  hmp-commands.hx  | 19 
>  hmp.c| 62 
> 
>  hmp.h|  4 
>  4 files changed, 103 insertions(+)
> 
> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
> index ae16901..5e4ea51 100644
> --- a/hmp-commands-info.hx
> +++ b/hmp-commands-info.hx
> @@ -84,6 +84,24 @@ STEXI
>  Show block device statistics.
>  ETEXI
>  
> +#if defined(CONFIG_VIRTFS)
> +
> +{
> +.name   = "fsdev_iothrottle",
> +.args_type  = "",
> +.params = "",
> +.help   = "show fsdev iothrottle information",
> +.cmd= hmp_info_fsdev_iothrottle,
> +},
> +
> +#endif
> +
> +STEXI
> +@item info fsdev_iothrottle
> +@findex fsdev_iothrottle
> +Show fsdev device throttle info.
> +ETEXI
> +
>  {
>  .name   = "block-jobs",
>  .args_type  = "",
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index e763606..b7eb9a6 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1662,6 +1662,25 @@ STEXI
>  Change I/O throttle limits for a block drive to @var{bps} @var{bps_rd} 
> @var{bps_wr} @var{iops} @var{iops_rd} @var{iops_wr}
>  ETEXI
>  
> +#if defined(CONFIG_VIRTFS)
> +
> +{
> +.name   = "fsdev_set_io_throttle",
> +.args_type  = 
> "device:B,bps:l,bps_rd:l,bps_wr:l,iops:l,iops_rd:l,iops_wr:l",
> +.params = "device bps bps_rd bps_wr iops iops_rd iops_wr",
> +.help   = "change I/O throttle limits for a fs devices",
> +.cmd= hmp_fsdev_set_io_throttle,
> +},
> +
> +#endif
> +
> +STEXI
> +@item fsdev_set_io_throttle @var{device} @var{bps} @var{bps_rd} @var{bps_wr} 
> @var{iops} @var{iops_rd} @var{iops_wr}
> +@findex fsdev_set_io_throttle
> +Change I/O throttle limits for a fs devices to @var{bps} @var{bps_rd} 
> @var{bps_wr} @var{iops} @var{iops_rd} @var{iops_wr}
> +ETEXI
> +
> +
>  {
>  .name   = "set_password",
>  .args_type  = "protocol:s,password:s,connected:s?",
> diff --git a/hmp.c b/hmp.c
> index 3f76073..97014d4 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1774,6 +1774,68 @@ void hmp_block_set_io_throttle(Monitor *mon, const 
> QDict *qdict)
>  hmp_handle_error(mon, );
>  }
>  
> +#ifdef CONFIG_VIRTFS
> +
> +void hmp_fsdev_set_io_throttle(Monitor *mon, const QDict *qdict)
> +{
> +Error *err = NULL;
> +IOThrottle throttle = {
> +.has_id = true,
> +.id = (char *) qdict_get_str(qdict, "device"),
> +};
> +
> +hmp_initialize_io_throttle(, qdict);
> +qmp_fsdev_set_io_throttle(, );
> +hmp_handle_error(mon, );
> +}
> +
> +static void print_fsdev_throttle_config(Monitor *mon, IOThrottle *fscfg,
> +   Error *err)
> +{
> +monitor_printf(mon, "%s", fscfg->id);
> +monitor_printf(mon, "I/O throttling:"
> +   " bps=%" PRId64
> +   " bps_rd=%" PRId64  " bps_wr=%" PRId64
> +   " bps_max=%" PRId64
> +   " bps_rd_max=%" PRId64
> +   " bps_wr_max=%" PRId64
> +   " iops=%" PRId64 " iops_rd=%" PRId64
> +   " iops_wr=%" PRId64
> +   " iops_max=%" PRId64
> +   " iops_rd_max=%" PRId64
> +   " iops_wr_max=%" PRId64
> +   " iops_size=%" PRId64
> +   "\n",
> +   fscfg->bps,
> +   fscfg->bps_rd,
> +   fscfg->bps_wr,
> +   fscfg->bps_max,
> +   fscfg->bps_rd_max,
> +   fscfg->bps_wr_max,
> +   fscfg->iops,
> +   fscfg->iops_rd,
> +   fscfg->iops_wr,
> +   fscfg->iops_max,
> +   fscfg->iops_rd_max,
> +   fscfg->iops_wr_max,
> +   fscfg->iops_size);
> +   hmp_handle_error(mon, );
> +}
> +
> +void hmp_info_fsdev_iothrottle(Monitor *mon, const QDict *qdict)
> +{
> +Error *err = NULL;
> +IOThrottleList *fsdev_list, *info;
> +fsdev_list = qmp_query_fsdev_io_throttle();
> +
> +for (info = fsdev_list; info; info = info->next) {
> +print_fsdev_throttle_config(mon, info->value, err);
> +}
> +qapi_free_IOThrottleList(fsdev_list);
> +}
> +
> +#endif
> +
>  void hmp_block_stream(Monitor *mon, const QDict *qdict)
>  {
>  Error *error = NULL;
> diff --git a/hmp.h b/hmp.h
> index d8b94ce..dbf024d 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -81,6 +81,10 @@ void hmp_set_password(Monitor *mon, const QDict *qdict);
>  void hmp_expire_password(Monitor *mon, const QDict